From unknown Sun Jun 15 08:03:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#55897 <55897@debbugs.gnu.org> To: bug#55897 <55897@debbugs.gnu.org> Subject: Status: [PATCH] bindat (str, strz): Convert to unibyte when packing Reply-To: bug#55897 <55897@debbugs.gnu.org> Date: Sun, 15 Jun 2025 15:03:27 +0000 retitle 55897 [PATCH] bindat (str, strz): Convert to unibyte when packing reassign 55897 emacs submitter 55897 Richard Hansen severity 55897 normal tag 55897 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 11 00:38:19 2022 Received: (at submit) by debbugs.gnu.org; 11 Jun 2022 04:38:19 +0000 Received: from localhost ([127.0.0.1]:51673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzst8-00067o-Th for submit@debbugs.gnu.org; Sat, 11 Jun 2022 00:38:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:42506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzst6-00067f-De for submit@debbugs.gnu.org; Sat, 11 Jun 2022 00:38:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzst2-0002Aw-Oy for bug-gnu-emacs@gnu.org; Sat, 11 Jun 2022 00:38:14 -0400 Received: from spork.scientician.org ([66.228.35.160]:34350) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzssz-00083S-Fd for bug-gnu-emacs@gnu.org; Sat, 11 Jun 2022 00:38:12 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id 397F5486D7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1654922288; bh=B/5EZ1rMRzR6ifh3NlHHhkt/VH+prCAJd94m5/EHM+4=; h=Date:To:From:Subject:From; b=bdr78zwebwFOMtwViswcbiSNd+GCe7sHN9lfeo/j3yGe+R0At2biLjW2AxSf237nn kQcWtXLBZDTOIKPAAJ3EWZ6ilL4UhrjQbFXDgeCB/UVbkcnti1il0OwbKaQ8EEU4uE p9Wz5njWOBA89GbIC4jJSvR+vox16QkbN6mgicwo= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id 13DE620277 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1654922285; bh=B/5EZ1rMRzR6ifh3NlHHhkt/VH+prCAJd94m5/EHM+4=; h=Date:To:From:Subject:From; b=LWTRLuVehrtNg6uL2DNhuiYAxrH+mpyA83wo/XcAQtxOMZ77ZirAg0zqZiBDOIF6Z AuTYKivvJkXDsfMqvgnA9z65Q7qOq7JRctgom6wZPuYHhdOC6YqG+3TKbEASVk2glT 9BPzwVLaRwJyBKGqmiIsfoj8gzWVIVLuIT3mQFn0= Message-ID: Date: Sat, 11 Jun 2022 00:38:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Richard Hansen Subject: [PATCH] bindat (str, strz): Convert to unibyte when packing Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------RtfraAbqzj3oYgRNcjbyiqyP" Received-SPF: pass client-ip=66.228.35.160; envelope-from=rhansen@rhansen.org; helo=spork.scientician.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------RtfraAbqzj3oYgRNcjbyiqyP Content-Type: multipart/mixed; boundary="------------TpYjt07HgXk4eCTUB6zXz0p8"; protected-headers="v1" From: Richard Hansen To: bug-gnu-emacs@gnu.org Message-ID: Subject: [PATCH] bindat (str, strz): Convert to unibyte when packing --------------TpYjt07HgXk4eCTUB6zXz0p8 Content-Type: multipart/mixed; boundary="------------32sY0S0fvuC01O4FRLmSAEQD" --------------32sY0S0fvuC01O4FRLmSAEQD Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 WC1EZWJidWdzLUNDOiBtb25uaWVyQGlyby51bW9udHJlYWwuY2ENCg0KVHdvIHBhdGNoZXMg YXR0YWNoZWQ6DQoNClBhdGNoIDE6DQoNCiAgICAgYmluZGF0IChzdHIsIHN0cnopOiBSZWpl Y3QgbXVsdGlieXRlIGlucHV0IHN0cmluZ3MNCg0KICAgICAqIGxpc3AvZW1hY3MtbGlzcC9i aW5kYXQuZWwgKHN0cikgKHN0cnopOiBTaWduYWwgYW4gZXJyb3IgaWYgdGhlIHVzZXINCiAg ICAgYXR0ZW1wdHMgdG8gcGFjayBhIG11bHRpYnl0ZSBzdHJpbmcuDQogICAgICogdGVzdC9s aXNwL2VtYWNzLWxpc3AvYmluZGF0LXRlc3RzLmVsIChzdHIpIChzdHJ6KTogQWRkIHRlc3Rz Lg0KDQpQYXRjaCAyOg0KDQogICAgIGJpbmRhdCAoc3RyLCBzdHJ6KTogQ29udmVydCB0byB1 bmlieXRlIHdoZW4gcGFja2luZw0KDQogICAgICogbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5l bCAoc3RyKSAoc3Ryeik6IEFsbG93IGNhbGxlcnMgdG8gcGFjayBhDQogICAgIG11bHRpYnl0 ZSBzdHJpbmcgaWYgaXQgb25seSBjb250YWlucyBBU0NJSSBhbmQgYGVpZ2h0LWJpdCcgY2hh cmFjdGVycy4NCiAgICAgKiBkb2MvbGlzcHJlZi9wcm9jZXNzZXMudGV4aSAoQmluZGF0IFR5 cGVzKTogVXBkYXRlIGRvY3VtZW50YXRpb24uDQogICAgICogdGVzdC9saXNwL2VtYWNzLWxp c3AvYmluZGF0LXRlc3RzLmVsIChzdHIpIChzdHJ6KTogVXBkYXRlIHRlc3RzLg0K --------------32sY0S0fvuC01O4FRLmSAEQD Content-Type: text/x-patch; charset=UTF-8; name="0001-bindat-str-strz-Reject-multibyte-input-strings.patch" Content-Disposition: attachment; filename*0="0001-bindat-str-strz-Reject-multibyte-input-strings.patch" Content-Transfer-Encoding: base64 RnJvbSA4MGNmMGYzYzE2NTIxOTZmYzY4OWJmNzJjYTNiNzUxZmIzYzUyYTAxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogU3VuLCA1IEp1biAyMDIyIDIzOjQ0OjQyIC0wNDAwClN1YmplY3Q6IFtQ QVRDSCAxLzJdIGJpbmRhdCAoc3RyLCBzdHJ6KTogUmVqZWN0IG11bHRpYnl0ZSBpbnB1dCBz dHJpbmdzCgoqIGxpc3AvZW1hY3MtbGlzcC9iaW5kYXQuZWwgKHN0cikgKHN0cnopOiBTaWdu YWwgYW4gZXJyb3IgaWYgdGhlIHVzZXIKYXR0ZW1wdHMgdG8gcGFjayBhIG11bHRpYnl0ZSBz dHJpbmcuCiogdGVzdC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRlc3RzLmVsIChzdHIpIChz dHJ6KTogQWRkIHRlc3RzLgotLS0KIGxpc3AvZW1hY3MtbGlzcC9iaW5kYXQuZWwgICAgICAg ICAgICB8ICA0ICsrKysKIHRlc3QvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC10ZXN0cy5lbCB8 IDE0ICsrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKykK CmRpZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsIGIvbGlzcC9lbWFjcy1s aXNwL2JpbmRhdC5lbAppbmRleCA1ZjNjNzcyOTgzLi45YWMyNGZhMDA4IDEwMDY0NAotLS0g YS9saXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9iaW5k YXQuZWwKQEAgLTQzNSwxMSArNDM1LDE1IEBAIGJpbmRhdC0tcGFjay11NjRyCiAgIChiaW5k YXQtLXBhY2stdTMyciAoYXNoIHYgLTMyKSkpCiAKIChkZWZ1biBiaW5kYXQtLXBhY2stc3Ry IChsZW4gdikKKyAgKGlmIChtdWx0aWJ5dGUtc3RyaW5nLXAgdikKKyAgICAgIChzaWduYWwg J3dyb25nLXR5cGUtYXJndW1lbnQgYChtdWx0aWJ5dGUtc3RyaW5nLXAgLHYpKSkKICAgKGRv dGltZXMgKGkgKG1pbiBsZW4gKGxlbmd0aCB2KSkpCiAgICAgKGFzZXQgYmluZGF0LXJhdyAo KyBiaW5kYXQtaWR4IGkpIChhcmVmIHYgaSkpKQogICAoc2V0cSBiaW5kYXQtaWR4ICgrIGJp bmRhdC1pZHggbGVuKSkpCiAKIChkZWZ1biBiaW5kYXQtLXBhY2stc3RyeiAodikKKyAgKGlm IChtdWx0aWJ5dGUtc3RyaW5nLXAgdikKKyAgICAgIChzaWduYWwgJ3dyb25nLXR5cGUtYXJn dW1lbnQgYChtdWx0aWJ5dGUtc3RyaW5nLXAgLHYpKSkKICAgKGxldCAoKGxlbiAobGVuZ3Ro IHYpKSkKICAgICAoZG90aW1lcyAoaSBsZW4pCiAgICAgICAoYXNldCBiaW5kYXQtcmF3ICgr IGJpbmRhdC1pZHggaSkgKGFyZWYgdiBpKSkpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZW1h Y3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQt dGVzdHMuZWwKaW5kZXggNDgxNzA3Mjc1Mi4uZGE2ODhkMWU4MiAxMDA2NDQKLS0tIGEvdGVz dC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9lbWFj cy1saXNwL2JpbmRhdC10ZXN0cy5lbApAQCAtMTg5LDYgKzE4OSwyMCBAQCBiaW5kYXQtdGVz dC0tc3RyLXN0cnotcHJlYWxsb2MKICAgICAgIChhcHBseSAjJ2JpbmRhdC1wYWNrIChhcHBl bmQgKGNhciB0YykgKGxpc3QgcHJlYWxsb2MpKSkKICAgICAgIChzaG91bGQgKGVxdWFsIHBy ZWFsbG9jIChjZHIgdGMpKSkpKSkKIAorKGVydC1kZWZ0ZXN0IGJpbmRhdC10ZXN0LS1zdHIt c3Ryei1tdWx0aWJ5dGUgKCkKKyAgKGRvbGlzdCAoc3BlYyAobGlzdCAoYmluZGF0LXR5cGUg c3RyIDIpCisgICAgICAgICAgICAgICAgICAgICAgKGJpbmRhdC10eXBlIHN0cnogMikKKyAg ICAgICAgICAgICAgICAgICAgICAoYmluZGF0LXR5cGUgc3RyeikpKQorICAgIChzaG91bGQt ZXJyb3IgKGJpbmRhdC1wYWNrIHNwZWMgKHN0cmluZy10by1tdWx0aWJ5dGUgIngiKSkpCisg ICAgKHNob3VsZC1lcnJvciAoYmluZGF0LXBhY2sgc3BlYyAoc3RyaW5nLXRvLW11bHRpYnl0 ZSAiXHhmZiIpKSkKKyAgICAoc2hvdWxkLWVycm9yIChiaW5kYXQtcGFjayBzcGVjICLwn5Kp IikpCisgICAgKHNob3VsZC1lcnJvciAoYmluZGF0LXBhY2sgc3BlYyAiXE57VStmZn0iKSkp CisgIChkb2xpc3QgKHNwZWMgKGxpc3QgJygoeCBzdHIgMikpICcoKHggc3RyeiAyKSkpKQor ICAgIChzaG91bGQtZXJyb3IgKGJpbmRhdC1wYWNrIHNwZWMgYCgoeCAuICwoc3RyaW5nLXRv LW11bHRpYnl0ZSAieCIpKSkpKQorICAgIChzaG91bGQtZXJyb3IgKGJpbmRhdC1wYWNrIHNw ZWMgYCgoeCAuICwoc3RyaW5nLXRvLW11bHRpYnl0ZSAiXHhmZiIpKSkpKQorICAgIChzaG91 bGQtZXJyb3IgKGJpbmRhdC1wYWNrIHNwZWMgJygoeCAuICLwn5KpIikpKSkKKyAgICAoc2hv dWxkLWVycm9yIChiaW5kYXQtcGFjayBzcGVjICcoKHggLiAiXE57VStmZn0iKSkpKSkpCisK IChsZXQgKChzcGVjIChiaW5kYXQtdHlwZSBzdHJ6IDIpKSkKICAgKGVydC1kZWZ0ZXN0IGJp bmRhdC10ZXN0LS1zdHJ6LWZpeGVkbGVuLWxlbiAoKQogICAgIChzaG91bGQgKGVxdWFsIChi aW5kYXQtbGVuZ3RoIHNwZWMgIiIpIDIpKQotLSAKMi4zNi4xCgo= --------------32sY0S0fvuC01O4FRLmSAEQD Content-Type: text/x-patch; charset=UTF-8; name="0002-bindat-str-strz-Convert-to-unibyte-when-packing.patch" Content-Disposition: attachment; filename*0="0002-bindat-str-strz-Convert-to-unibyte-when-packing.patch" Content-Transfer-Encoding: base64 RnJvbSA2YTRkZTA1MGQzZDk0MDdjYTBiM2RlNDhlNGZiNGE2YTJiM2MyZWIxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogU3VuLCA1IEp1biAyMDIyIDIzOjU0OjExIC0wNDAwClN1YmplY3Q6IFtQ QVRDSCAyLzJdIGJpbmRhdCAoc3RyLCBzdHJ6KTogQ29udmVydCB0byB1bmlieXRlIHdoZW4g cGFja2luZwoKKiBsaXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsIChzdHIpIChzdHJ6KTogQWxs b3cgY2FsbGVycyB0byBwYWNrIGEKbXVsdGlieXRlIHN0cmluZyBpZiBpdCBvbmx5IGNvbnRh aW5zIEFTQ0lJIGFuZCBgZWlnaHQtYml0JyBjaGFyYWN0ZXJzLgoqIGRvYy9saXNwcmVmL3By b2Nlc3Nlcy50ZXhpIChCaW5kYXQgVHlwZXMpOiBVcGRhdGUgZG9jdW1lbnRhdGlvbi4KKiB0 ZXN0L2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwgKHN0cikgKHN0cnopOiBVcGRh dGUgdGVzdHMuCi0tLQogZG9jL2xpc3ByZWYvcHJvY2Vzc2VzLnRleGkgICAgICAgICAgIHwg MTQgKysrKysrKysrKy0tLS0KIGxpc3AvZW1hY3MtbGlzcC9iaW5kYXQuZWwgICAgICAgICAg ICB8IDE0ICsrKysrKy0tLS0tLS0tCiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQtdGVz dHMuZWwgfCAxMCArKysrKystLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMo KyksIDE2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL3Byb2Nlc3Nl cy50ZXhpIGIvZG9jL2xpc3ByZWYvcHJvY2Vzc2VzLnRleGkKaW5kZXggNTVmYjkzZWM1YS4u ZmJmMjg1YzFjYyAxMDA2NDQKLS0tIGEvZG9jL2xpc3ByZWYvcHJvY2Vzc2VzLnRleGkKKysr IGIvZG9jL2xpc3ByZWYvcHJvY2Vzc2VzLnRleGkKQEAgLTM0ODQsOCArMzQ4NCwxMSBAQCBC aW5kYXQgVHlwZXMKIHRvIHRoZSBwYWNrZWQgb3V0cHV0LiAgSWYgdGhlIGlucHV0IHN0cmlu ZyBpcyBzaG9ydGVyIHRoYW4gQHZhcntsZW59LAogdGhlIHJlbWFpbmluZyBieXRlcyB3aWxs IGJlIG51bGwgKHplcm8pIHVubGVzcyBhIHByZS1hbGxvY2F0ZWQgc3RyaW5nCiB3YXMgcHJv dmlkZWQgdG8gQGNvZGV7YmluZGF0LXBhY2t9LCBpbiB3aGljaCBjYXNlIHRoZSByZW1haW5p bmcgYnl0ZXMKLWFyZSBsZWZ0IHVubW9kaWZpZWQuICBXaGVuIHVucGFja2luZywgYW55IG51 bGwgYnl0ZXMgaW4gdGhlIHBhY2tlZAotaW5wdXQgc3RyaW5nIHdpbGwgYXBwZWFyIGluIHRo ZSB1bnBhY2tlZCBvdXRwdXQuCithcmUgbGVmdCB1bm1vZGlmaWVkLiAgSWYgdGhlIGlucHV0 IHN0cmluZyBpcyBtdWx0aWJ5dGUgd2l0aCBvbmx5IEFTQ0lJCithbmQgQGNvZGV7ZWlnaHQt Yml0fSBjaGFyYWN0ZXJzLCBpdCBpcyBjb252ZXJ0ZWQgdG8gdW5pYnl0ZSBiZWZvcmUgaXQK K2lzIHBhY2tlZDsgb3RoZXIgbXVsdGlieXRlIHN0cmluZ3Mgc2lnbmFsIGFuIGVycm9yLiAg V2hlbiB1bnBhY2tpbmcsCithbnkgbnVsbCBieXRlcyBpbiB0aGUgcGFja2VkIGlucHV0IHN0 cmluZyB3aWxsIGFwcGVhciBpbiB0aGUgdW5wYWNrZWQKK291dHB1dC4KIAogQGl0ZW0gc3Ry eiAmb3B0aW9uYWwgQHZhcntsZW59CiBJZiBAdmFye2xlbn0gaXMgbm90IHByb3ZpZGVkOiBW YXJpYWJsZS1sZW5ndGggbnVsbC10ZXJtaW5hdGVkIHVuaWJ5dGUKQEAgLTM0OTUsOCArMzQ5 OCwxMSBAQCBCaW5kYXQgVHlwZXMKIEBjb2Rle2JpbmRhdC1wYWNrfSwgaW4gd2hpY2ggY2Fz ZSB0aGF0IGJ5dGUgaXMgbGVmdCB1bm1vZGlmaWVkLiAgVGhlCiBsZW5ndGggb2YgdGhlIHBh Y2tlZCBvdXRwdXQgaXMgdGhlIGxlbmd0aCBvZiB0aGUgaW5wdXQgc3RyaW5nIHBsdXMgb25l CiAoZm9yIHRoZSBudWxsIHRlcm1pbmF0b3IpLiAgVGhlIGlucHV0IHN0cmluZyBtdXN0IG5v dCBjb250YWluIGFueSBudWxsCi1ieXRlcy4gIFdoZW4gdW5wYWNraW5nLCB0aGUgcmVzdWx0 aW5nIHN0cmluZyBjb250YWlucyBhbGwgYnl0ZXMgdXAgdG8KLShidXQgZXhjbHVkaW5nKSB0 aGUgbnVsbCBieXRlLgorYnl0ZXMuICBJZiB0aGUgaW5wdXQgc3RyaW5nIGlzIG11bHRpYnl0 ZSB3aXRoIG9ubHkgQVNDSUkgYW5kCitAY29kZXtlaWdodC1iaXR9IGNoYXJhY3RlcnMsIGl0 IGlzIGNvbnZlcnRlZCB0byB1bmlieXRlIGJlZm9yZSBpdCBpcworcGFja2VkOyBvdGhlciBt dWx0aWJ5dGUgc3RyaW5ncyBzaWduYWwgYW4gZXJyb3IuICBXaGVuIHVucGFja2luZywgdGhl CityZXN1bHRpbmcgc3RyaW5nIGNvbnRhaW5zIGFsbCBieXRlcyB1cCB0byAoYnV0IGV4Y2x1 ZGluZykgdGhlIG51bGwKK2J5dGUuCiAKIEBxdW90YXRpb24gQ2F1dGlvbgogSWYgYSBwcmUt YWxsb2NhdGVkIHN0cmluZyBpcyBwcm92aWRlZCB0byBAY29kZXtiaW5kYXQtcGFja30sIHRo ZQpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbCBiL2xpc3AvZW1hY3Mt bGlzcC9iaW5kYXQuZWwKaW5kZXggOWFjMjRmYTAwOC4uMDRhZDA5YWJjMSAxMDA2NDQKLS0t IGEvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvYmlu ZGF0LmVsCkBAIC00MzUsMTYgKzQzNSwxNCBAQCBiaW5kYXQtLXBhY2stdTY0cgogICAoYmlu ZGF0LS1wYWNrLXUzMnIgKGFzaCB2IC0zMikpKQogCiAoZGVmdW4gYmluZGF0LS1wYWNrLXN0 ciAobGVuIHYpCi0gIChpZiAobXVsdGlieXRlLXN0cmluZy1wIHYpCi0gICAgICAoc2lnbmFs ICd3cm9uZy10eXBlLWFyZ3VtZW50IGAobXVsdGlieXRlLXN0cmluZy1wICx2KSkpCi0gIChk b3RpbWVzIChpIChtaW4gbGVuIChsZW5ndGggdikpKQotICAgIChhc2V0IGJpbmRhdC1yYXcg KCsgYmluZGF0LWlkeCBpKSAoYXJlZiB2IGkpKSkKLSAgKHNldHEgYmluZGF0LWlkeCAoKyBi aW5kYXQtaWR4IGxlbikpKQorICAobGV0ICgodiAoc3RyaW5nLXRvLXVuaWJ5dGUgdikpKQor ICAgIChkb3RpbWVzIChpIChtaW4gbGVuIChsZW5ndGggdikpKQorICAgICAgKGFzZXQgYmlu ZGF0LXJhdyAoKyBiaW5kYXQtaWR4IGkpIChhcmVmIHYgaSkpKQorICAgIChzZXRxIGJpbmRh dC1pZHggKCsgYmluZGF0LWlkeCBsZW4pKSkpCiAKIChkZWZ1biBiaW5kYXQtLXBhY2stc3Ry eiAodikKLSAgKGlmIChtdWx0aWJ5dGUtc3RyaW5nLXAgdikKLSAgICAgIChzaWduYWwgJ3dy b25nLXR5cGUtYXJndW1lbnQgYChtdWx0aWJ5dGUtc3RyaW5nLXAgLHYpKSkKLSAgKGxldCAo KGxlbiAobGVuZ3RoIHYpKSkKKyAgKGxldCogKCh2IChzdHJpbmctdG8tdW5pYnl0ZSB2KSkK KyAgICAgICAgIChsZW4gKGxlbmd0aCB2KSkpCiAgICAgKGRvdGltZXMgKGkgbGVuKQogICAg ICAgKGFzZXQgYmluZGF0LXJhdyAoKyBiaW5kYXQtaWR4IGkpIChhcmVmIHYgaSkpKQogICAg IChzZXRxIGJpbmRhdC1pZHggKCsgYmluZGF0LWlkeCBsZW4gMSkpKSkKZGlmZiAtLWdpdCBh L3Rlc3QvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9lbWFj cy1saXNwL2JpbmRhdC10ZXN0cy5lbAppbmRleCBkYTY4OGQxZTgyLi5kMzNmMWMwMWEyIDEw MDY0NAotLS0gYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwKKysrIGIv dGVzdC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRlc3RzLmVsCkBAIC0xOTMsMTMgKzE5Mywx NSBAQCBiaW5kYXQtdGVzdC0tc3RyLXN0cnotbXVsdGlieXRlCiAgIChkb2xpc3QgKHNwZWMg KGxpc3QgKGJpbmRhdC10eXBlIHN0ciAyKQogICAgICAgICAgICAgICAgICAgICAgIChiaW5k YXQtdHlwZSBzdHJ6IDIpCiAgICAgICAgICAgICAgICAgICAgICAgKGJpbmRhdC10eXBlIHN0 cnopKSkKLSAgICAoc2hvdWxkLWVycm9yIChiaW5kYXQtcGFjayBzcGVjIChzdHJpbmctdG8t bXVsdGlieXRlICJ4IikpKQotICAgIChzaG91bGQtZXJyb3IgKGJpbmRhdC1wYWNrIHNwZWMg KHN0cmluZy10by1tdWx0aWJ5dGUgIlx4ZmYiKSkpCisgICAgKHNob3VsZCAoZXF1YWwgKGJp bmRhdC1wYWNrIHNwZWMgKHN0cmluZy10by1tdWx0aWJ5dGUgIngiKSkgInhcMCIpKQorICAg IChzaG91bGQgKGVxdWFsIChiaW5kYXQtcGFjayBzcGVjIChzdHJpbmctdG8tbXVsdGlieXRl ICJceGZmIikpICJceGZmXDAiKSkKICAgICAoc2hvdWxkLWVycm9yIChiaW5kYXQtcGFjayBz cGVjICLwn5KpIikpCiAgICAgKHNob3VsZC1lcnJvciAoYmluZGF0LXBhY2sgc3BlYyAiXE57 VStmZn0iKSkpCiAgIChkb2xpc3QgKHNwZWMgKGxpc3QgJygoeCBzdHIgMikpICcoKHggc3Ry eiAyKSkpKQotICAgIChzaG91bGQtZXJyb3IgKGJpbmRhdC1wYWNrIHNwZWMgYCgoeCAuICwo c3RyaW5nLXRvLW11bHRpYnl0ZSAieCIpKSkpKQotICAgIChzaG91bGQtZXJyb3IgKGJpbmRh dC1wYWNrIHNwZWMgYCgoeCAuICwoc3RyaW5nLXRvLW11bHRpYnl0ZSAiXHhmZiIpKSkpKQor ICAgIChzaG91bGQgKGVxdWFsIChiaW5kYXQtcGFjayBzcGVjIGAoKHggLiAsKHN0cmluZy10 by1tdWx0aWJ5dGUgIngiKSkpKQorICAgICAgICAgICAgICAgICAgICJ4XDAiKSkKKyAgICAo c2hvdWxkIChlcXVhbCAoYmluZGF0LXBhY2sgc3BlYyBgKCh4IC4gLChzdHJpbmctdG8tbXVs dGlieXRlICJceGZmIikpKSkKKyAgICAgICAgICAgICAgICAgICAiXHhmZlwwIikpCiAgICAg KHNob3VsZC1lcnJvciAoYmluZGF0LXBhY2sgc3BlYyAnKCh4IC4gIvCfkqkiKSkpKQogICAg IChzaG91bGQtZXJyb3IgKGJpbmRhdC1wYWNrIHNwZWMgJygoeCAuICJcTntVK2ZmfSIpKSkp KSkKIAotLSAKMi4zNi4xCgo= --------------32sY0S0fvuC01O4FRLmSAEQD-- --------------TpYjt07HgXk4eCTUB6zXz0p8-- --------------RtfraAbqzj3oYgRNcjbyiqyP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfoCctB7fyOzE09bW0GvrRa1X4hQFAmKkHCkACgkQ0GvrRa1X 4hQzQg/+MJ1GnQVOBlaGneFJ6SnRtzsCxCdAm0D1sRl0TDhJJR1uYcG+GA/vzb4+ LNncxG7Q3fXaYg84ui2NOiO/+Z+iNslpGSEjZM0TI+MW+CPctp/MJK3ErZT2lnkn 8Jezs2T0nqvG1DLWzCzpTccKmweulirKOA0ga+Kry5rK+iWCub4SyCY1pbDPW5Bv J8JTtKhQ5vRVUWrOyrYU/b66DHv1o+TWxtTxYn3y28YRw5sGEAcEYxD3StJvHzAA wNbQbfl9hSVLmN8YTLI04DmkixI4Sjc+ym5wkhKW5dwP8Dv3w3/sCauGb2yv67Mt uXn5OlnlUQZynLn7rZ5bhLEhviTKbW9nju/O2Y8Q5kcOOXj3bQPyVPS/RDmn17D5 sV5HauVnYnCul+WIGpO0NIQsbQu5raWjpta9WeyQxRBELgcpe5wz1jWRd8m5XRaG kmOk/MCaf9LT6b2IsIUFjlrUdN75kqrTaKfEukaY3MF5vfpEdDTRU0CfGsmJwDQ0 3JdS79f6vpYtt4IgO70Ueh6FxDsgB7DMFJsBv2ObGDFj6NQg5M17CBeEMmbbv3e0 mv1tN1k6MeOrxMyOU2GU16A7wz02dA/vTuIxIcCMxPmSnEmfjRAv0mW5cA2f7StS PpBDHwfHY9bdO3n3lfVdxXqbtGip0DUcm6+1nt48Hq82jELDDTE= =zpYy -----END PGP SIGNATURE----- --------------RtfraAbqzj3oYgRNcjbyiqyP-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 11 04:11:32 2022 Received: (at 55897) by debbugs.gnu.org; 11 Jun 2022 08:11:32 +0000 Received: from localhost ([127.0.0.1]:51803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzwDT-0003fd-Vg for submit@debbugs.gnu.org; Sat, 11 Jun 2022 04:11:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzwDP-0003fN-Kf for 55897@debbugs.gnu.org; Sat, 11 Jun 2022 04:11:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51296) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzwDK-0003Xv-7s; Sat, 11 Jun 2022 04:11:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=0y/S38upLlXMPkUiWM/331Cfu2qp0n47eUFwvrtSvcM=; b=a3Kg4ulx+K7TkA71+Uex iZXdum/PDXHUNc6joS883VoLhAyQonqxfrLxNC70W8QY2xU9eVSAca6m7G3PHaVV478aREH7K5pV4 8wEbsGCABO+CGgCIuXI6loOwikOFMyxKYbZiwMQHd1v18U7XPqvu1SlIlkyxHTKe2rdWHBumSA982 Tl+YMD3+MJwJQdQ3TUTtrkOgizvThAQvrKvQ4Qzw0n3+cPJAu8HYI5ZKbVGzjimkOscix455MlFa9 zE8V2XMkaBhqYzTKs1KNTbJecCSSoeXAduyqHKCxCCagNGlKD/wWhAZ0prR1n2o+Jm20Kpn0i59hI j4uGcp7hMu5Zbg==; Received: from [87.69.77.57] (port=4929 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzwDJ-0005Un-Nn; Sat, 11 Jun 2022 04:11:22 -0400 Date: Sat, 11 Jun 2022 11:11:15 +0300 Message-Id: <83zgijy5zw.fsf@gnu.org> From: Eli Zaretskii To: Richard Hansen In-Reply-To: (message from Richard Hansen on Sat, 11 Jun 2022 00:38:00 -0400) Subject: Re: bug#55897: [PATCH] bindat (str, strz): Convert to unibyte when packing References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55897 Cc: 55897@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: monnier@iro.umontreal.ca > Date: Sat, 11 Jun 2022 00:38:00 -0400 > From: Richard Hansen > > (defun bindat--pack-str (len v) > + (if (multibyte-string-p v) > + (signal 'wrong-type-argument `(multibyte-string-p ,v))) Isn't this too strict? First, a string can be multibyte and pure-ASCII: (let ((str (decode-coding-string "abcde" 'utf-8))) (multibyte-string-p str)) => t Shouldn't it be possible to use such strings here? Furthermore, I think you said you wanted to extend bindat so it could use multibyte string that contain ASCII and eight-bit characters? If so, this sounds like shooting ourselves in the foot? > (defun bindat--pack-str (len v) > - (if (multibyte-string-p v) > - (signal 'wrong-type-argument `(multibyte-string-p ,v))) > - (dotimes (i (min len (length v))) > - (aset bindat-raw (+ bindat-idx i) (aref v i))) > - (setq bindat-idx (+ bindat-idx len))) > + (let ((v (string-to-unibyte v))) > + (dotimes (i (min len (length v))) > + (aset bindat-raw (+ bindat-idx i) (aref v i))) > + (setq bindat-idx (+ bindat-idx len)))) And here you remove that error back? Why does it make sense to introduce an error message, only to remove it in the very next commit? Please instead make a single change which incorporates both. > --- a/test/lisp/emacs-lisp/bindat-tests.el > +++ b/test/lisp/emacs-lisp/bindat-tests.el > @@ -193,13 +193,15 @@ bindat-test--str-strz-multibyte > (dolist (spec (list (bindat-type str 2) > (bindat-type strz 2) > (bindat-type strz))) > - (should-error (bindat-pack spec (string-to-multibyte "x"))) > - (should-error (bindat-pack spec (string-to-multibyte "\xff"))) > + (should (equal (bindat-pack spec (string-to-multibyte "x")) "x\0")) > + (should (equal (bindat-pack spec (string-to-multibyte "\xff")) "\xff\0")) > (should-error (bindat-pack spec "💩")) > (should-error (bindat-pack spec "\N{U+ff}"))) > (dolist (spec (list '((x str 2)) '((x strz 2)))) > - (should-error (bindat-pack spec `((x . ,(string-to-multibyte "x"))))) > - (should-error (bindat-pack spec `((x . ,(string-to-multibyte "\xff"))))) > + (should (equal (bindat-pack spec `((x . ,(string-to-multibyte "x")))) > + "x\0")) > + (should (equal (bindat-pack spec `((x . ,(string-to-multibyte "\xff")))) > + "\xff\0")) > (should-error (bindat-pack spec '((x . "💩")))) > (should-error (bindat-pack spec '((x . "\N{U+ff}")))))) Likewise here. Thanks. P.S. Please also mention the bug number in the log message of the next version of the patch, since the number is now known. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 12 01:23:26 2022 Received: (at 55897) by debbugs.gnu.org; 12 Jun 2022 05:23:26 +0000 Received: from localhost ([127.0.0.1]:54398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0G4L-0007b6-NT for submit@debbugs.gnu.org; Sun, 12 Jun 2022 01:23:26 -0400 Received: from spork.scientician.org ([66.228.35.160]:40732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0G4I-0007as-8c for 55897@debbugs.gnu.org; Sun, 12 Jun 2022 01:23:24 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id BE4FB48A43 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1655011401; bh=97iKfsnr/nvsd/2YCqCob+Yjy2gVkiOjItKe+0h+HrI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iNqtD0c8s/CABSZhs0DanY09/bXif2+QXuNiYvJmuCOT3LrcgY/+ip78z1T7a1QQI KpoaJs38R0A0qOGU2/ogLyjXa0gPQR/U6O+Z+/791wW2czulzXB5H6/p8mucau9KY4 m3a0lAxX4G68qXdlcpEXKFqjBOtmZwoGKz86vwK8= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id CAA24201AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1655011399; bh=97iKfsnr/nvsd/2YCqCob+Yjy2gVkiOjItKe+0h+HrI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SZYLPK0PcdF8o0apzVewB4Rz3MWxuMYVQ57YaWqMZK2YlIahpmqBYrwPQpE1d0WgN E7i6SftZe/hN3eODqtcsdDuDTKJtSiAG0WQPqiz+0rH4dSRyrtP2Y6DEm95Yp2D1P8 t+JdUVGUlqTp82v401kEWdJaRKkhdlkquielxAbg= Message-ID: <4ac312cf-87aa-1cd3-d27a-3626e192b28d@rhansen.org> Date: Sun, 12 Jun 2022 01:23:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#55897: [PATCH] bindat (str, strz): Convert to unibyte when packing Content-Language: en-US To: Eli Zaretskii References: <83zgijy5zw.fsf@gnu.org> From: Richard Hansen In-Reply-To: <83zgijy5zw.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------JDQWYmoLK7MI6Ch0osFLoZKc" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55897 Cc: 55897@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------JDQWYmoLK7MI6Ch0osFLoZKc Content-Type: multipart/mixed; boundary="------------EVMGUiySLGmDKzmGiePcAU41"; protected-headers="v1" From: Richard Hansen To: Eli Zaretskii Cc: 55897@debbugs.gnu.org, monnier@iro.umontreal.ca Message-ID: <4ac312cf-87aa-1cd3-d27a-3626e192b28d@rhansen.org> Subject: Re: bug#55897: [PATCH] bindat (str, strz): Convert to unibyte when packing References: <83zgijy5zw.fsf@gnu.org> In-Reply-To: <83zgijy5zw.fsf@gnu.org> --------------EVMGUiySLGmDKzmGiePcAU41 Content-Type: multipart/mixed; boundary="------------Zdad74NS1cb4IqM0VK2SN7B0" --------------Zdad74NS1cb4IqM0VK2SN7B0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 PiBQbGVhc2UgaW5zdGVhZCBtYWtlIGEgc2luZ2xlIGNoYW5nZSB3aGljaCBpbmNvcnBvcmF0 ZXMgYm90aC4NCg0KRG9uZTsgc2VlIGF0dGFjaGVkLg0KDQo+IFAuUy4gUGxlYXNlIGFsc28g bWVudGlvbiB0aGUgYnVnIG51bWJlciBpbiB0aGUgbG9nIG1lc3NhZ2Ugb2YgdGhlIG5leHQN Cj4gdmVyc2lvbiBvZiB0aGUgcGF0Y2gsIHNpbmNlIHRoZSBudW1iZXIgaXMgbm93IGtub3du Lg0KDQpEb25lLg0K --------------Zdad74NS1cb4IqM0VK2SN7B0 Content-Type: text/x-patch; charset=UTF-8; name="v2-0001-bindat-str-strz-Reject-non-ASCII-non-eight-bit-ch.patch" Content-Disposition: attachment; filename*0="v2-0001-bindat-str-strz-Reject-non-ASCII-non-eight-bit-ch.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAzNDRiZWMxZmEwMWZmNGQxMmMzNTJjMjIwMjM3ZmU4YzI2MmU5MWE0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogU3VuLCAxMiBKdW4gMjAyMiAwMToxOTo0MyAtMDQwMApTdWJqZWN0OiBb UEFUQ0ggdjJdIGJpbmRhdCAoc3RyLCBzdHJ6KTogUmVqZWN0IG5vbi1BU0NJSSwgbm9uLWBl aWdodC1iaXQnCiBjaGFyYWN0ZXJzCgoqIGxpc3AvZW1hY3MtbGlzcC9iaW5kYXQuZWwgKHN0 cikgKHN0cnopOiBTaWduYWwgYW4gZXJyb3IgaWYgdGhlIHVzZXIKYXR0ZW1wdHMgdG8gcGFj ayBhIG11bHRpYnl0ZSBzdHJpbmcgY29udGFpbmluZyBjaGFyYWN0ZXJzIG90aGVyIHRoYW4K QVNDSUkgYW5kIGBlaWdodC1iaXQnIGNoYXJhY3RlcnMgKGJ1ZyM1NTg5NykuCiogZG9jL2xp c3ByZWYvcHJvY2Vzc2VzLnRleGkgKEJpbmRhdCBUeXBlcyk6IFVwZGF0ZSBkb2N1bWVudGF0 aW9uLgoqIHRlc3QvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC10ZXN0cy5lbCAoc3RyKSAoc3Ry eik6IEFkZCB0ZXN0cy4KLS0tCiBkb2MvbGlzcHJlZi9wcm9jZXNzZXMudGV4aSAgICAgICAg ICAgfCAxNCArKysrKysrKysrLS0tLQogbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbCAgICAg ICAgICAgIHwgMTAgKysrKysrLS0tLQogdGVzdC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRl c3RzLmVsIHwgMTYgKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAzMiBpbnNl cnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL3By b2Nlc3Nlcy50ZXhpIGIvZG9jL2xpc3ByZWYvcHJvY2Vzc2VzLnRleGkKaW5kZXggYWE0ZDBl M2VlNC4uOGM4ZjhmZDZiMiAxMDA2NDQKLS0tIGEvZG9jL2xpc3ByZWYvcHJvY2Vzc2VzLnRl eGkKKysrIGIvZG9jL2xpc3ByZWYvcHJvY2Vzc2VzLnRleGkKQEAgLTM0ODYsOCArMzQ4Niwx MSBAQCBCaW5kYXQgVHlwZXMKIHRvIHRoZSBwYWNrZWQgb3V0cHV0LiAgSWYgdGhlIGlucHV0 IHN0cmluZyBpcyBzaG9ydGVyIHRoYW4gQHZhcntsZW59LAogdGhlIHJlbWFpbmluZyBieXRl cyB3aWxsIGJlIG51bGwgKHplcm8pIHVubGVzcyBhIHByZS1hbGxvY2F0ZWQgc3RyaW5nCiB3 YXMgcHJvdmlkZWQgdG8gQGNvZGV7YmluZGF0LXBhY2t9LCBpbiB3aGljaCBjYXNlIHRoZSBy ZW1haW5pbmcgYnl0ZXMKLWFyZSBsZWZ0IHVubW9kaWZpZWQuICBXaGVuIHVucGFja2luZywg YW55IG51bGwgYnl0ZXMgaW4gdGhlIHBhY2tlZAotaW5wdXQgc3RyaW5nIHdpbGwgYXBwZWFy IGluIHRoZSB1bnBhY2tlZCBvdXRwdXQuCithcmUgbGVmdCB1bm1vZGlmaWVkLiAgSWYgdGhl IGlucHV0IHN0cmluZyBpcyBtdWx0aWJ5dGUgd2l0aCBvbmx5IEFTQ0lJCithbmQgQGNvZGV7 ZWlnaHQtYml0fSBjaGFyYWN0ZXJzLCBpdCBpcyBjb252ZXJ0ZWQgdG8gdW5pYnl0ZSBiZWZv cmUgaXQKK2lzIHBhY2tlZDsgb3RoZXIgbXVsdGlieXRlIHN0cmluZ3Mgc2lnbmFsIGFuIGVy cm9yLiAgV2hlbiB1bnBhY2tpbmcsCithbnkgbnVsbCBieXRlcyBpbiB0aGUgcGFja2VkIGlu cHV0IHN0cmluZyB3aWxsIGFwcGVhciBpbiB0aGUgdW5wYWNrZWQKK291dHB1dC4KIAogQGl0 ZW0gc3RyeiAmb3B0aW9uYWwgQHZhcntsZW59CiBJZiBAdmFye2xlbn0gaXMgbm90IHByb3Zp ZGVkOiBWYXJpYWJsZS1sZW5ndGggbnVsbC10ZXJtaW5hdGVkIHVuaWJ5dGUKQEAgLTM0OTcs OCArMzUwMCwxMSBAQCBCaW5kYXQgVHlwZXMKIEBjb2Rle2JpbmRhdC1wYWNrfSwgaW4gd2hp Y2ggY2FzZSB0aGF0IGJ5dGUgaXMgbGVmdCB1bm1vZGlmaWVkLiAgVGhlCiBsZW5ndGggb2Yg dGhlIHBhY2tlZCBvdXRwdXQgaXMgdGhlIGxlbmd0aCBvZiB0aGUgaW5wdXQgc3RyaW5nIHBs dXMgb25lCiAoZm9yIHRoZSBudWxsIHRlcm1pbmF0b3IpLiAgVGhlIGlucHV0IHN0cmluZyBt dXN0IG5vdCBjb250YWluIGFueSBudWxsCi1ieXRlcy4gIFdoZW4gdW5wYWNraW5nLCB0aGUg cmVzdWx0aW5nIHN0cmluZyBjb250YWlucyBhbGwgYnl0ZXMgdXAgdG8KLShidXQgZXhjbHVk aW5nKSB0aGUgbnVsbCBieXRlLgorYnl0ZXMuICBJZiB0aGUgaW5wdXQgc3RyaW5nIGlzIG11 bHRpYnl0ZSB3aXRoIG9ubHkgQVNDSUkgYW5kCitAY29kZXtlaWdodC1iaXR9IGNoYXJhY3Rl cnMsIGl0IGlzIGNvbnZlcnRlZCB0byB1bmlieXRlIGJlZm9yZSBpdCBpcworcGFja2VkOyBv dGhlciBtdWx0aWJ5dGUgc3RyaW5ncyBzaWduYWwgYW4gZXJyb3IuICBXaGVuIHVucGFja2lu ZywgdGhlCityZXN1bHRpbmcgc3RyaW5nIGNvbnRhaW5zIGFsbCBieXRlcyB1cCB0byAoYnV0 IGV4Y2x1ZGluZykgdGhlIG51bGwKK2J5dGUuCiAKIEBxdW90YXRpb24gQ2F1dGlvbgogSWYg YSBwcmUtYWxsb2NhdGVkIHN0cmluZyBpcyBwcm92aWRlZCB0byBAY29kZXtiaW5kYXQtcGFj a30sIHRoZQpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbCBiL2xpc3Av ZW1hY3MtbGlzcC9iaW5kYXQuZWwKaW5kZXggODRkNWVhMWUzYi4uMmQ2NTg5YjUyZCAxMDA2 NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbAorKysgYi9saXNwL2VtYWNzLWxp c3AvYmluZGF0LmVsCkBAIC00MzUsMTIgKzQzNSwxNCBAQCBiaW5kYXQtLXBhY2stdTY0cgog ICAoYmluZGF0LS1wYWNrLXUzMnIgKGFzaCB2IC0zMikpKQogCiAoZGVmdW4gYmluZGF0LS1w YWNrLXN0ciAobGVuIHYpCi0gIChkb3RpbWVzIChpIChtaW4gbGVuIChsZW5ndGggdikpKQot ICAgIChhc2V0IGJpbmRhdC1yYXcgKCsgYmluZGF0LWlkeCBpKSAoYXJlZiB2IGkpKSkKLSAg KHNldHEgYmluZGF0LWlkeCAoKyBiaW5kYXQtaWR4IGxlbikpKQorICAobGV0ICgodiAoc3Ry aW5nLXRvLXVuaWJ5dGUgdikpKQorICAgIChkb3RpbWVzIChpIChtaW4gbGVuIChsZW5ndGgg dikpKQorICAgICAgKGFzZXQgYmluZGF0LXJhdyAoKyBiaW5kYXQtaWR4IGkpIChhcmVmIHYg aSkpKQorICAgIChzZXRxIGJpbmRhdC1pZHggKCsgYmluZGF0LWlkeCBsZW4pKSkpCiAKIChk ZWZ1biBiaW5kYXQtLXBhY2stc3RyeiAodikKLSAgKGxldCAoKGxlbiAobGVuZ3RoIHYpKSkK KyAgKGxldCogKCh2IChzdHJpbmctdG8tdW5pYnl0ZSB2KSkKKyAgICAgICAgIChsZW4gKGxl bmd0aCB2KSkpCiAgICAgKGRvdGltZXMgKGkgbGVuKQogICAgICAgKGFzZXQgYmluZGF0LXJh dyAoKyBiaW5kYXQtaWR4IGkpIChhcmVmIHYgaSkpKQogICAgIChzZXRxIGJpbmRhdC1pZHgg KCsgYmluZGF0LWlkeCBsZW4gMSkpKSkKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lbWFjcy1s aXNwL2JpbmRhdC10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC10ZXN0 cy5lbAppbmRleCAxY2U0MDI5NzdmLi44YmIzYmFhNDg1IDEwMDY0NAotLS0gYS90ZXN0L2xp c3AvZW1hY3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2VtYWNzLWxp c3AvYmluZGF0LXRlc3RzLmVsCkBAIC0xODgsNiArMTg4LDIyIEBAIGJpbmRhdC10ZXN0LS1z dHItc3Ryei1wcmVhbGxvYwogICAgICAgKGFwcGx5ICMnYmluZGF0LXBhY2sgKGFwcGVuZCAo Y2FyIHRjKSAobGlzdCBwcmVhbGxvYykpKQogICAgICAgKHNob3VsZCAoZXF1YWwgcHJlYWxs b2MgKGNkciB0YykpKSkpKQogCisoZXJ0LWRlZnRlc3QgYmluZGF0LXRlc3QtLXN0ci1zdHJ6 LW11bHRpYnl0ZSAoKQorICAoZG9saXN0IChzcGVjIChsaXN0IChiaW5kYXQtdHlwZSBzdHIg MikKKyAgICAgICAgICAgICAgICAgICAgICAoYmluZGF0LXR5cGUgc3RyeiAyKQorICAgICAg ICAgICAgICAgICAgICAgIChiaW5kYXQtdHlwZSBzdHJ6KSkpCisgICAgKHNob3VsZCAoZXF1 YWwgKGJpbmRhdC1wYWNrIHNwZWMgKHN0cmluZy10by1tdWx0aWJ5dGUgIngiKSkgInhcMCIp KQorICAgIChzaG91bGQgKGVxdWFsIChiaW5kYXQtcGFjayBzcGVjIChzdHJpbmctdG8tbXVs dGlieXRlICJceGZmIikpICJceGZmXDAiKSkKKyAgICAoc2hvdWxkLWVycm9yIChiaW5kYXQt cGFjayBzcGVjICLwn5KpIikpCisgICAgKHNob3VsZC1lcnJvciAoYmluZGF0LXBhY2sgc3Bl YyAiXE57VStmZn0iKSkpCisgIChkb2xpc3QgKHNwZWMgKGxpc3QgJygoeCBzdHIgMikpICco KHggc3RyeiAyKSkpKQorICAgIChzaG91bGQgKGVxdWFsIChiaW5kYXQtcGFjayBzcGVjIGAo KHggLiAsKHN0cmluZy10by1tdWx0aWJ5dGUgIngiKSkpKQorICAgICAgICAgICAgICAgICAg ICJ4XDAiKSkKKyAgICAoc2hvdWxkIChlcXVhbCAoYmluZGF0LXBhY2sgc3BlYyBgKCh4IC4g LChzdHJpbmctdG8tbXVsdGlieXRlICJceGZmIikpKSkKKyAgICAgICAgICAgICAgICAgICAi XHhmZlwwIikpCisgICAgKHNob3VsZC1lcnJvciAoYmluZGF0LXBhY2sgc3BlYyAnKCh4IC4g IvCfkqkiKSkpKQorICAgIChzaG91bGQtZXJyb3IgKGJpbmRhdC1wYWNrIHNwZWMgJygoeCAu ICJcTntVK2ZmfSIpKSkpKSkKKwogKGxldCAoKHNwZWMgKGJpbmRhdC10eXBlIHN0cnogMikp KQogICAoZXJ0LWRlZnRlc3QgYmluZGF0LXRlc3QtLXN0cnotZml4ZWRsZW4tbGVuICgpCiAg ICAgKHNob3VsZCAoZXF1YWwgKGJpbmRhdC1sZW5ndGggc3BlYyAiIikgMikpCi0tIAoyLjM2 LjEKCg== --------------Zdad74NS1cb4IqM0VK2SN7B0-- --------------EVMGUiySLGmDKzmGiePcAU41-- --------------JDQWYmoLK7MI6Ch0osFLoZKc Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfoCctB7fyOzE09bW0GvrRa1X4hQFAmKleEYACgkQ0GvrRa1X 4hSZjQ/7BU4zHVJX/His6SRWcHSUq2qv7+AD69DieTCSxcKWdzVUeq8K9+91voac DAe0+wW0MZebi095PeOjz1b3yIsyMO0bpua7O3B/Iyhhh1e2tz56jgGEQ6PWZCH7 0gbtz9HCRRqBXZyGUn43u7yt1NNPkgakEr0zj3zq1B50qxXubRNOz1Neb7zKnCxT CBuYDDjJCa92NIeQ40kYoakYd8FH2WdDsHazjfwlBN/wSVnGZvvMTfKdsl5toA4U Ww8H/7eCALFG5h7h3xME6t2y6//Kfpt0ZAqiGwgR46RFDpQYJPCuzn+wr0bVdEfk EDXWsVsiNmzW27isGX1GlwRuil0fhuAQWAR/jrMOXaO+2bK9Q275Hy3zX8fOHz5l Ogn1qcZrOiVRwsku/FR2kpEWFnflmheD76mPT+yYY5gGR1v/n7TypWmk48UsJmCw 2rMsF5/bDpdqJCj+lVsc01Hn0QX9MkJieZCgZqDHEGZlVCJgGOVsAm7X412jnlhU tlqaFoDlRAnQIr4XQXNWLWUSviKmhtEx3h4IToYIu2RNloRki0TrtiTXFA3196Qi vwA6ANVhwelgf9UNRh33NX0E06lI1yfk2o6tMlNNIX4H91SxfSUT/zbIr8zRxPH1 /v2sJSy/q12ajlT/gA4YIjbfiBtFZoRuNLIdHx06Ro5eawZ5A8A= =W1+J -----END PGP SIGNATURE----- --------------JDQWYmoLK7MI6Ch0osFLoZKc-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 12 03:01:08 2022 Received: (at 55897-done) by debbugs.gnu.org; 12 Jun 2022 07:01:08 +0000 Received: from localhost ([127.0.0.1]:54500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0Hau-00024u-ES for submit@debbugs.gnu.org; Sun, 12 Jun 2022 03:01:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0Haq-00024G-3M for 55897-done@debbugs.gnu.org; Sun, 12 Jun 2022 03:01:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0Hak-0006fq-Jk; Sun, 12 Jun 2022 03:00:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=v0hB1of0wRdb1/8XTj/Vxb86EIibrhQi7z64luQNdqg=; b=J3BlhGj0qNfe wDpCOK93OX3F/n9fCqOSZ9/bC465/s48VyPOGyBUgHthjdiGehcDX616bJzt9sMwBcwqEz+nHgC7j FWiEjFBme/WTGhznH78asZLM6JCOMHPgm033+LmaKi55ZYFw4IdeNQsOIDPuPYctO/XFfXYndSOqu jc9+bOSb8e7tZdQ5Z3q6w39Zvt/0JLmZFjPLwatWdQZqJ6JF4t4VH2uTtoW7Oi0L1Lkp1J2/b6nUV Fmt6zZ3KIuFEnkcS1ZcSescXh2uaE36a6/5lQEGGV8rNRu51RJSH3Q+78Ncl5kdexhCzXpB7/1pLz FP/OsZwJ8SX3nYNAGSCOFQ==; Received: from [87.69.77.57] (port=1727 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0Hak-0004q7-2v; Sun, 12 Jun 2022 03:00:58 -0400 Date: Sun, 12 Jun 2022 10:00:42 +0300 Message-Id: <83h74qwelh.fsf@gnu.org> From: Eli Zaretskii To: Richard Hansen In-Reply-To: <4ac312cf-87aa-1cd3-d27a-3626e192b28d@rhansen.org> (message from Richard Hansen on Sun, 12 Jun 2022 01:23:17 -0400) Subject: Re: bug#55897: [PATCH] bindat (str, strz): Convert to unibyte when packing References: <83zgijy5zw.fsf@gnu.org> <4ac312cf-87aa-1cd3-d27a-3626e192b28d@rhansen.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55897-done Cc: 55897-done@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 12 Jun 2022 01:23:17 -0400 > Cc: 55897@debbugs.gnu.org, monnier@iro.umontreal.ca > From: Richard Hansen > > > Please instead make a single change which incorporates both. > > Done; see attached. > > > P.S. Please also mention the bug number in the log message of the next > > version of the patch, since the number is now known. > > Done. Thanks, installed. From unknown Sun Jun 15 08:03:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 10 Jul 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator