Subject: Re: [bug#55891] [PATCH] gnu: Add iec16022

From: Remco van 't Veer <[email-masked]>
Date: Fri, 10 Jun 2022 19:39:51 +0200

2022/06/10 17:55, Maxime Devos:

> Remco van 't Veer schreef op vr 10-06-2022 om 17:04 [+0200]:
>> +    (source (origin
>> +              (method git-fetch)
>> +              (uri (git-reference
>> +                    (url "https://github.com/rdoeffinger/iec16022")
>> +                    (commit "c9a9fd926fd1e6cca9782fe3f8c2bab66010ca51")))
>> +              (file-name (git-file-name name version))
>> +              (sha256
>
> Contains a bug: on line
>
> https://github.com/rdoeffinger/iec16022/blob/c9a9fd926fd1e6cca9782fe3f8c2bab66010ca51/image.c#L284
>
> , it allocates a buffer, which can fail (by returning NULL).
> It then passes the possibly NULL buffer to compress2.
> Also, it writes files without checking for errors
> (e.g. EIO, ENOSPC or EDQUOT).

Good catch!  I'll need to brush up on my C skills to fix these.
Meanwhile I'd like to ship including bugs, WDYT?