GNU bug report logs - #55889
29.0.50; Support mksh-specific function names in imenu

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55889 in the body.
You can then email your comments to 55889 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Support mksh-specific function names in imenu
Date: Fri, 10 Jun 2022 20:06:21 +0530

[Message part 1 (text/plain, inline)]

Tags: patch

mksh supports characters well beyond [:alnum:_] in its function names.
More specifically, syn.c:function_body says the following

	/*-
	 * Check for valid characters in name. POSIX and AT&T ksh93 say
	 * only allow [a-zA-Z_0-9] but this allows more as old pdkshs
	 * have allowed more; the following were never allowed:
	 *	NUL TAB NL SP " $ & ' ( ) ; < = > \ ` |
	 * C_QUOTE|C_SPC covers all but adds # * ? [ ]
	 */

However, it seems like executing a function with a forward-slash (/)
character in it is impossible as well.

Attached patch adds a mksh-specific entry to sh-imenu-generic-expression
to do that.

[0001-Support-mksh-specific-function-names-in-imenu.patch (text/x-diff, attachment)]

Message #8 received at 55889 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 55889 <at> debbugs.gnu.org
Subject: Re: bug#55889: 29.0.50; Support mksh-specific function names in imenu
Date: Sat, 11 Jun 2022 13:05:38 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

> Attached patch adds a mksh-specific entry to sh-imenu-generic-expression
> to do that.

Thanks; pushed to Emacs 29 (with an indentation fix).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 55889 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 55889 <at> debbugs.gnu.org
Subject: Re: bug#55889: 29.0.50; Support mksh-specific function names in imenu
Date: Sat, 11 Jun 2022 21:16:56 +0530

[சனி ஜூன் 11, 2022] Lars Ingebrigtsen wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
>> Attached patch adds a mksh-specific entry to sh-imenu-generic-expression
>> to do that.
>
> Thanks; pushed to Emacs 29 (with an indentation fix).

I forgot to bump :version as well, oops.

Message #16 received at 55889 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 55889 <at> debbugs.gnu.org
Subject: Re: bug#55889: 29.0.50; Support mksh-specific function names in imenu
Date: Sat, 11 Jun 2022 18:13:16 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

>> Thanks; pushed to Emacs 29 (with an indentation fix).
>
> I forgot to bump :version as well, oops.

No prob; now done.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.