GNU bug report logs - #55883
[PATCH] Update X Primary Selection with active regions

Previous Next

Package: emacs;

Reported by: Duncan Findlay <duncf <at> google.com>

Date: Fri, 10 Jun 2022 06:29:02 UTC

Severity: wishlist

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #49 received at 55883 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Duncan Findlay <duncf <at> google.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 55883 <at> debbugs.gnu.org
Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions
Date: Wed, 22 Jun 2022 18:37:24 +0300
Duncan Findlay [2022-06-21 18:58 -0700] wrote:

> I'm wondering if the attached patch would have worked too?

Its downside is that the variable can then be defined in more than one
place, with potentially different/out-of-sync values, depending on load
order.  This makes debugging and maintenance a bit harder.  Using
bound-and-true-p would have achieved the same effect while keeping the
user option squarely defined in a single place.  But Eli's patch
generalises even further.

Thanks,

-- 
Basil




This bug report was last modified 3 years and 29 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.