GNU bug report logs - #55883
[PATCH] Update X Primary Selection with active regions

Previous Next

Package: emacs;

Reported by: Duncan Findlay <duncf <at> google.com>

Date: Fri, 10 Jun 2022 06:29:02 UTC

Severity: wishlist

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Po Lu <luangruo <at> yahoo.com>
To: Duncan Findlay <duncf <at> google.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 55883 <at> debbugs.gnu.org
Subject: bug#55883: [PATCH] Update X Primary Selection with active regions
Date: Tue, 14 Jun 2022 13:57:33 +0800

>> +	      if ((!NILP (Fwindow_system (Qnil)) ||
>> +		   !NILP (Fterminal_parameter (Qnil, Qdisplay_selections_p)))

In addition to what Eli wrote, this code is formatted incorrectly.

Here and elsewhere, please write:

  if (very_long_condition ()
      || another_very_long_condition ())

as opposed to

  if (very_long_condition () ||
      another_very_long_condition ())

Thanks.
This bug report was last modified 3 years and 29 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.