From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 02:28:33 2022 Received: (at submit) by debbugs.gnu.org; 10 Jun 2022 06:28:34 +0000 Received: from localhost ([127.0.0.1]:48490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzY8E-0006BX-9U for submit@debbugs.gnu.org; Fri, 10 Jun 2022 02:28:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:52460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzXyt-0005rk-AH for submit@debbugs.gnu.org; Fri, 10 Jun 2022 02:18:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzXyn-0008K4-Qw for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 02:18:50 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:37641) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzXyl-0008JI-VM for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 02:18:45 -0400 Received: by mail-wr1-x42b.google.com with SMTP id o16so1404260wra.4 for ; Thu, 09 Jun 2022 23:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=Er6AxIuiWBdBMy1lXbR51LNeFwH3OJLfl33SwmpG0KM=; b=PeFoaxc8dllTWGiJhOPhtfio08tDT2/KrOmOneADqa55ne1LH1bXzzBlrfxhnJEa4I 7HHKCip+tamMTMo4WB9HBc+mB7wQEm/NbRbka0C/qAA8ViTBUCxMG/zeWvwX5wnNbQt8 p0eqKh/gjhq7euxi9nLhifW9paf54AT3M/bYfzSnKT73SJl3lWptwgjcnwyo/ZSOPM+L unudaUMYLvd1xV0F8pFdJjy12uEaj5Fi4ezvwe8N8eGLz7wKlIFlNymKc+QLat8lZpnT s73VhHKumaGpzPauhatYGMxfa940ECfgY3oT84uQKDPWX0n3c+Co4OlhIzoG2xZALkIc 2zPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Er6AxIuiWBdBMy1lXbR51LNeFwH3OJLfl33SwmpG0KM=; b=kxfEATZvo2Tdv2xOMoD9KHhGcVbITcbCtdb50oH3SAOvZygNBrAnS2mIDArm/i3yxa Qv/gQ3PJI/00zum9l7LN/LUgzRYJyT74yE/qTsxspiQD5+ow7SZSnYrq8OyfKpZBnjEj u0sIvYSYg00u95+y3OGaLHKPM+w4EcTflTzH77UHtLw2aJw1h/ZHYrK2VDw5Rw+C7wjo UpPLRSdgnJaUFTBmzlTpzyGKkwtc1vu0IFm5/GZOXctci3lxYMKB7igdrl7HlDUOvsLA P0iwCQ9BA2oMQyR3Jn7kTB5R3ONQUbn7x76jCkFht8twOeNxPFl/6Hyshotg6uIxh/To y/uw== X-Gm-Message-State: AOAM5317cXzkhqbajT0vRBMQx2jgRQXhF0BgqxWYzk0j+9/E43ijT+rG 8XNwI7l0G7SrsS20ivJpRy+FpWQYcAHWVue305uB+egsnPYvSg== X-Google-Smtp-Source: ABdhPJxHo1FUn48lFmONVUzhXdipDzQ/EP+VDJZ6Be8hyqLJgPppG+sqIYsL+eAqMgGKmXSOj7QWFM5iBvy/H3YS4Oc= X-Received: by 2002:a5d:59a5:0:b0:218:3ffb:e6ea with SMTP id p5-20020a5d59a5000000b002183ffbe6eamr25207101wrr.715.1654841918831; Thu, 09 Jun 2022 23:18:38 -0700 (PDT) MIME-Version: 1.0 From: Duncan Findlay Date: Thu, 9 Jun 2022 23:18:01 -0700 Message-ID: Subject: [PATCH] Update X Primary Selection with active regions To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000bbe5b105e111e875" Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=duncf@google.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 10 Jun 2022 02:28:28 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000bbe5b105e111e875 Content-Type: text/plain; charset="UTF-8" Severity: wishlist Tags: patch Attached are two patches to allow users that use xterm's OSC 52 clipboard support to have their primary selection updated with the active region, to better match the behavior of running Emacs in X locally. This behavior is enabled automatically for supported terminals, and is controlled by the existing `select-active-regions' variable. Previous discussion: https://lists.gnu.org/archive/html/emacs-devel/2022-06/msg00126.html This should be covered by a corporate copyright assignment on file. --000000000000bbe5b105e111e875 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Use-display-selections-p-for-selecting-active-region.patch" Content-Disposition: attachment; filename="0001-Use-display-selections-p-for-selecting-active-region.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l481m63x0 RnJvbSA1ZGVlNWE0NGZkMGQzYWQ1N2JhN2U0MGZkNWIwNTQyZDcwMTYwYzE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEdW5jYW4gRmluZGxheSA8ZHVuY2ZAZ29vZ2xlLmNvbT4KRGF0 ZTogRnJpLCAyMCBNYXkgMjAyMiAwMDoxNzo1MSAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSBV c2UgYGRpc3BsYXktc2VsZWN0aW9ucy1wJyBmb3Igc2VsZWN0aW5nIGFjdGl2ZSByZWdpb24KCmBk aXNwbGF5LXNlbGVjdGlvbnMtcCcgaXMgZG9jdW1lbnRlZCBhcyB0aGUgcHJlZmVycmVkIHdheSB0 byBkZXRlcm1pbmUKY2FwYWJpbGl0aWVzLCBvdmVyIGB3aW5kb3ctc3lzdGVtJy4gIFRoaXMgYWxs b3dzIHN1cHBvcnRlZCB0ZXh0CnRlcm1pbmFscyB0byBpbmRpY2F0ZSBzdXBwb3J0IGZvciB0aGVz ZSBzZWxlY3Rpb25zLgoKKiBzcmMva2V5Ym9hcmQuYyAoY29tbWFuZF9sb29wXzEpOiBSZXBsYWNl IGNhbGwgdG8gYHdpbmRvdy1zeXN0ZW0nCndpdGggYGRpc3BsYXktc2VsZWN0aW9ucy1wJyB3aGVu IGRlY2lkaW5nIHdoZXRoZXIgdG8gdXBkYXRlIHByaW1hcnkKc2VsZWN0aW9uLgotLS0KIHNyYy9r ZXlib2FyZC5jIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMva2V5Ym9hcmQuYyBiL3NyYy9rZXlib2FyZC5jCmlu ZGV4IDU1ZDcxMGVkNjIuLmRjM2MzN2U0ZDggMTAwNjQ0Ci0tLSBhL3NyYy9rZXlib2FyZC5jCisr KyBiL3NyYy9rZXlib2FyZC5jCkBAIC0xNTY5LDcgKzE1NjksNyBAQCBjb21tYW5kX2xvb3BfMSAo dm9pZCkKIAkgICAgewogCSAgICAgIC8qIEV2ZW4gaWYgbm90IGRlYWN0aXZhdGluZyB0aGUgbWFy aywgc2V0IFBSSU1BUlkgaWYKIAkJIGBzZWxlY3QtYWN0aXZlLXJlZ2lvbnMnIGlzIG5vbi1uaWwu ICAqLwotCSAgICAgIGlmICghTklMUCAoRndpbmRvd19zeXN0ZW0gKFFuaWwpKQorCSAgICAgIGlm ICghTklMUCAoY2FsbDAgKFFkaXNwbGF5X3NlbGVjdGlvbnNfcCkpCiAJCSAgLyogRXZlbiBpZiBt YXJrX2FjdGl2ZSBpcyBub24tbmlsLCB0aGUgYWN0dWFsIGJ1ZmZlcgogCQkgICAgIG1hcmtlciBt YXkgbm90IGhhdmUgYmVlbiBzZXQgeWV0IChCdWcjNzA0NCkuICAqLwogCQkgICYmIFhNQVJLRVIg KEJWQVIgKGN1cnJlbnRfYnVmZmVyLCBtYXJrKSktPmJ1ZmZlcgpAQCAtMTIxNjIsNiArMTIxNjIs NyBAQCBzeW1zX29mX2tleWJvYXJkICh2b2lkKQogCiAgIERFRlNZTSAoUXBvbGxpbmdfcGVyaW9k LCAicG9sbGluZy1wZXJpb2QiKTsKIAorICBERUZTWU0gKFFkaXNwbGF5X3NlbGVjdGlvbnNfcCwg ImRpc3BsYXktc2VsZWN0aW9ucy1wIik7CiAgIERFRlNZTSAoUWd1aV9zZXRfc2VsZWN0aW9uLCAi Z3VpLXNldC1zZWxlY3Rpb24iKTsKIAogICAvKiBUaGUgcHJpbWFyeSBzZWxlY3Rpb24uICAqLwot LSAKMi4zNi4xLjQ3Ni5nMGM0ZGFhMjA2ZC1nb29nCgo= --000000000000bbe5b105e111e875 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-Support-select-active-regions-with-xterm.patch" Content-Disposition: attachment; filename="0002-Support-select-active-regions-with-xterm.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l481maqq1 RnJvbSAyNWJiMTg3OTExZTA0NDRjNWUxNjE4NjUwYTA2MWYwYmUzMTdiZWU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEdW5jYW4gRmluZGxheSA8ZHVuY2ZAZ29vZ2xlLmNvbT4KRGF0 ZTogVGh1LCAyIEp1biAyMDIyIDIwOjIzOjQ0IC0wNzAwClN1YmplY3Q6IFtQQVRDSCAyLzJdIFN1 cHBvcnQgYHNlbGVjdC1hY3RpdmUtcmVnaW9ucycgd2l0aCB4dGVybQoKVGhpcyBhbGxvd3MgRW1h Y3MgdG8gc2F2ZSB0aGUgYWN0aXZlIHJlZ2lvbiB0byB0aGUgdXNlcidzIHByaW1hcnkKc2VsZWN0 aW9uIG9uIHN1cHBvcnRlZCB0ZXJtaW5hbHMuICBUaGlzIGJlaGF2aW9yIGlzIGNvbnRyb2xsZWQg YnkgdGhlCmV4aXN0aW5nIGBzZWxlY3QtYWN0aXZlLXJlZ2lvbnMnIHZhcmlhYmxlLgoKKiBsaXNw L2ZyYW1lLmVsIChkaXNwbGF5LXNlbGVjdGlvbnMtcCk6IEZvciB0ZXh0IHRlcm1pbmFscywgcmV0 dXJuCnRlcm1pbmFsIHBhcmFtZXRlciBgZGlzcGxheS1zZWxlY3Rpb25zLXBgIHRvIGluZGljYXRl IHNlbGVjdGlvbgpzdXBwb3J0LgoqIGxpc3AvdGVybS94dGVybS5lbCAoeHRlcm0tLWluaXQtYWN0 aXZhdGUtc2V0LXNlbGVjdGlvbik6IFNldCB0aGUKYGRpc3BsYXktc2VsZWN0aW9ucy1wYCB0ZXJt aW5hbCBwYXJhbWV0ZXIuCi0tLQogZXRjL05FV1MgICAgICAgICAgIHwgNSArKysrKwogbGlzcC9m cmFtZS5lbCAgICAgIHwgMiArKwogbGlzcC90ZXJtL3h0ZXJtLmVsIHwgMyArKy0KIDMgZmlsZXMg Y2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZXRj L05FV1MgYi9ldGMvTkVXUwppbmRleCBjZDRiMWIwNmVjLi4xN2M5OGI3NzJjIDEwMDY0NAotLS0g YS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtNDc3LDYgKzQ3NywxMSBAQCBUaGlzIGlzIGlu IGFkZGl0aW9uIHRvIHByZXZpb3VzbHktc3VwcG9ydGVkIHdheXMgb2YgZGlzY292ZXJpbmcgMjQt Yml0CiBjb2xvciBzdXBwb3J0OiBlaXRoZXIgdmlhIHRoZSAiUkdCIiBvciAic2V0ZjI0IiBjYXBh YmlsaXRpZXMsIG9yIGlmCiB0aGUgJ0NPTE9SVEVSTScgZW52aXJvbm1lbnQgdmFyaWFibGUgaXMg c2V0IHRvIHRoZSB2YWx1ZSAidHJ1ZWNvbG9yIi4KIAorKioqIFByaW1hcnkgc2VsZWN0aW9uIG9m IGFjdGl2ZSByZWdpb25zIHdpdGggeHRlcm0gc2V0U2VsZWN0aW9uIHN1cHBvcnQuCitPbiBzdXBw b3J0ZWQgdGVybWluYWxzLCB0aGUgYWN0aXZlIHJlZ2lvbiBtYXkgYmUgc2F2ZWQgdG8gdGhlIFgK K3ByaW1hcnkgc2VsZWN0aW9uLiAgVGhpcyBiZWhhdmlvciBpcyBjb250cm9sbGVkIGJ5IHRoZQor J3NlbGVjdC1hY3RpdmUtcmVnaW9ucycgdmFyaWFibGUuCisKICoqIEVSVAogCiArKysKZGlmZiAt LWdpdCBhL2xpc3AvZnJhbWUuZWwgYi9saXNwL2ZyYW1lLmVsCmluZGV4IDI3Zjk5ZmI3ZDIuLmU5 MjZkZmYyMDEgMTAwNjQ0Ci0tLSBhL2xpc3AvZnJhbWUuZWwKKysrIGIvbGlzcC9mcmFtZS5lbApA QCAtMjE2NCw2ICsyMTY0LDggQEAgZGlzcGxheS1zZWxlY3Rpb25zLXAKICAgICAgICAobm90IChu dWxsIGRvcy13aW5kb3dzLXZlcnNpb24pKSkpCiAgICAgICgobWVtcSBmcmFtZS10eXBlICcoeCB3 MzIgbnMgcGd0aykpCiAgICAgICB0KQorICAgICAoKGVxIGZyYW1lLXR5cGUgdCkKKyAgICAgICh0 ZXJtaW5hbC1wYXJhbWV0ZXIgZGlzcGxheSAnZGlzcGxheS1zZWxlY3Rpb25zLXApKQogICAgICAo dAogICAgICAgbmlsKSkpKQogCmRpZmYgLS1naXQgYS9saXNwL3Rlcm0veHRlcm0uZWwgYi9saXNw L3Rlcm0veHRlcm0uZWwKaW5kZXggYTdlMjU3ZjQxYy4uZjZhZGQwZmJmMiAxMDA2NDQKLS0tIGEv bGlzcC90ZXJtL3h0ZXJtLmVsCisrKyBiL2xpc3AvdGVybS94dGVybS5lbApAQCAtOTQ2LDcgKzk0 Niw4IEBAIHh0ZXJtLS1pbml0LWFjdGl2YXRlLWdldC1zZWxlY3Rpb24KIAogKGRlZnVuIHh0ZXJt LS1pbml0LWFjdGl2YXRlLXNldC1zZWxlY3Rpb24gKCkKICAgIlRlcm1pbmFsIGluaXRpYWxpemF0 aW9uIGZvciBgZ3VpLXNldC1zZWxlY3Rpb24nLiIKLSAgKHNldC10ZXJtaW5hbC1wYXJhbWV0ZXIg bmlsICd4dGVybS0tc2V0LXNlbGVjdGlvbiB0KSkKKyAgKHNldC10ZXJtaW5hbC1wYXJhbWV0ZXIg bmlsICd4dGVybS0tc2V0LXNlbGVjdGlvbiB0KQorICAoc2V0LXRlcm1pbmFsLXBhcmFtZXRlciBu aWwgJ2Rpc3BsYXktc2VsZWN0aW9ucy1wIHQpKQogCiAoZGVmdW4geHRlcm0tLWluaXQtZnJhbWUt dGl0bGUgKCkKICAgIlRlcm1pbmFsIGluaXRpYWxpemF0aW9uIGZvciBYVGVybSBmcmFtZSB0aXRs ZXMuIgotLSAKMi4zNi4xLjQ3Ni5nMGM0ZGFhMjA2ZC1nb29nCgo= --000000000000bbe5b105e111e875-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 02:52:12 2022 Received: (at 55883) by debbugs.gnu.org; 10 Jun 2022 06:52:12 +0000 Received: from localhost ([127.0.0.1]:48523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzYVA-0006yG-70 for submit@debbugs.gnu.org; Fri, 10 Jun 2022 02:52:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzYV7-0006y0-DX for 55883@debbugs.gnu.org; Fri, 10 Jun 2022 02:52:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzYV1-0004wi-JY; Fri, 10 Jun 2022 02:52:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CqAl0OirMuieBizkc7hCj0e9+BdVfNYGFQoCRY+8OH8=; b=kxLjI3MLqxvX dL+reYbIYcrhoqtEY5gLn4h9YCVhmlh5aR1nSGJsu1qhkxORvk7hqL2EwMQuIfLdfbvum5FMtKwbp 8wVFRmPkn9p+L+JNTq9QPmuxxT9AArOUL+mJEqt4A/aX4eTmnUKHnbRQu8I+ytJZCKbcbck94vYKp CBclK6T0VGx1/1vI+/TuF7xnpcHjnGePS7O6Xo7XaWj1fE6+8VdUi7rjYbNa35MmKnlcUhJFwzz5J EDgp9Ouic/+r4D76GnRcHWg7xYWJJDCN3GBeCTR95iOJSrXrERe8sAtMVrhvNgY+kIVb3DjnnBkn/ qWhpLh5O2ab+Xp2K/e90Vg==; Received: from [87.69.77.57] (port=3640 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzYV0-0000Yj-U7; Fri, 10 Jun 2022 02:52:03 -0400 Date: Fri, 10 Jun 2022 09:52:01 +0300 Message-Id: <834k0t104u.fsf@gnu.org> From: Eli Zaretskii To: Duncan Findlay In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55883 Cc: 55883@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 9 Jun 2022 23:18:01 -0700 > From: Duncan Findlay via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Attached are two patches to allow users that use xterm's OSC 52 > clipboard support to have their primary selection updated with the > active region, to better match the behavior of running Emacs in X > locally. > > This behavior is enabled automatically for supported terminals, and is > controlled by the existing `select-active-regions' variable. > > Previous discussion: > https://lists.gnu.org/archive/html/emacs-devel/2022-06/msg00126.html Thanks. However, the patches you posted seem to ignore the comments I made in the above-mentioned discussions, specifically here: https://lists.gnu.org/archive/html/emacs-devel/2022-06/msg00134.html Did you send a wrong version of the patches, perhaps? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 11 03:53:28 2022 Received: (at 55883) by debbugs.gnu.org; 11 Jun 2022 07:53:28 +0000 Received: from localhost ([127.0.0.1]:51791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzvvz-0003BA-VS for submit@debbugs.gnu.org; Sat, 11 Jun 2022 03:53:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzvvx-0003Au-RF for 55883@debbugs.gnu.org; Sat, 11 Jun 2022 03:53:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzvvs-0000hr-DL; Sat, 11 Jun 2022 03:53:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oyoB8vdiOZmsDkRuckfPiLVMMEQpaz4TA/rHdO5XwHw=; b=fpceIn+asUZa P4YgaEp3jCt6V0lCf4AYkobPrLc4rQ1UxN5+PcfjIdCI53E/LHBhZkIErUfWVSjhg9PV5t3Jfat/t rIP9vNAcp6Al9ubsHjWJqFGJqYUb5dVDUDgE1eTgiOuWgs45ZuMMPr8eZq1dRhZzNfpzCdfFS76NS e7UfW81Z3OKvOOlY+UsLkeA+8Pgvp6Rqmel6Q7hvxSIajlcvifFKnpfBNPm6//ZA1bd0IWvzEXfmh 9L5x869WPQj0JL3Evu7F6XcrR/BVwccjWxXfc9pc8ANIMKUSvy0eStegR1eVQtVfBaT/j4TdbQS99 l5Sr8QK5IBzxnzAnoWLSlw==; Received: from [87.69.77.57] (port=3823 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzvvr-0005A6-Ji; Sat, 11 Jun 2022 03:53:20 -0400 Date: Sat, 11 Jun 2022 10:53:14 +0300 Message-Id: <8335gbzled.fsf@gnu.org> From: Eli Zaretskii To: Duncan Findlay In-Reply-To: (message from Duncan Findlay on Fri, 10 Jun 2022 18:59:47 -0700) Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions References: <834k0t104u.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55883 Cc: 55883@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Duncan Findlay > Date: Fri, 10 Jun 2022 18:59:47 -0700 > Cc: 55883@debbugs.gnu.org > > Attached is an updated version that I believe addresses all the > concerns raised on the mailing list. > > Given the changes don't split so cleanly into two any more, I've > combined them into a single patch. Thanks. A few minor issues with this version: > * src/keyboard.c (command_loop_1): Check terminal parameter > `display-selections-p' for text terminals when deciding whether > to update primary selection. > * lisp/frame.el (display-selections-p): Return terminal > parameter `display-selections-p' to indicate selection support. > * lisp/term/xterm.el (xterm-select-active-regions): New > defcustom. (xterm--init-activate-set-selection): Set > the `display-selections-p' terminal parameter. Please mention the bug number in the log message. > +*** Select active regions with xterm selection support. > +On terminals with xterm setSelection support, the active region may be > +saved to the X primary selection, following the > +'select-active-regions' variable. This support is enabled with > +'xterm-select-active-regions'. ^^ Our convention is to leave 2 spaces between sentences in documentation. > --- a/lisp/frame.el > +++ b/lisp/frame.el > @@ -2164,6 +2164,8 @@ display-selections-p > (not (null dos-windows-version)))) > ((memq frame-type '(x w32 ns pgtk)) > t) > + ((terminal-parameter display 'display-selections-p) > + t) This should test xterm--set-selection parameter. > +(defcustom xterm-select-active-regions nil > + "If non-nil, on a terminal with setSelection support, Emacs will > +also update the primary selection with the active region, based > +on the value of `select-active-regions'." The first line of a doc string should be a complete sentence. So this doc strings should be reworded to comply with this convention. For example: "If non-nil, update PRIMARY X selection on text-mode frames. On a text-mode terminal that supports setSelection command, if this variable is non-nil, Emacs will set the PRIMARY selection from the active region, according to `select-active-regions'." > @@ -946,7 +953,9 @@ xterm--init-activate-get-selection > > (defun xterm--init-activate-set-selection () > "Terminal initialization for `gui-set-selection'." > - (set-terminal-parameter nil 'xterm--set-selection t)) > + (set-terminal-parameter nil 'xterm--set-selection t) > + (when xterm-select-active-regions > + (set-terminal-parameter nil 'display-selections-p t))) I see no reason to introduce a new terminal parameter with non-trivial semantics. Moreover, this consults the value of xterm-select-active-regions only once, so if the user later modifies the value of the option, the terminal parameter will stay at its stale value. I think the code should instead check the value of xterm-select-active-regions in keyboard.c, where it decides whether to set PRIMARY. (Let me know if you need guidance for how to reference a Lisp variable from C.) > @@ -1569,7 +1570,8 @@ command_loop_1 (void) > { > /* Even if not deactivating the mark, set PRIMARY if > `select-active-regions' is non-nil. */ > - if (!NILP (Fwindow_system (Qnil)) > + if ((!NILP (Fwindow_system (Qnil)) || > + !NILP (Fterminal_parameter (Qnil, Qdisplay_selections_p))) This should be looking at the xterm--set-selection parameter instead, and test the value of xterm-select-active-regions in addition, as described above. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 11 04:29:56 2022 Received: (at 55883) by debbugs.gnu.org; 11 Jun 2022 08:29:57 +0000 Received: from localhost ([127.0.0.1]:51824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzwVI-00048h-Cd for submit@debbugs.gnu.org; Sat, 11 Jun 2022 04:29:56 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:34484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzqQT-0001uL-Bx for 55883@debbugs.gnu.org; Fri, 10 Jun 2022 22:00:33 -0400 Received: by mail-wr1-f43.google.com with SMTP id c21so658027wrb.1 for <55883@debbugs.gnu.org>; Fri, 10 Jun 2022 19:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lD7xJ0EYYqQm1DKMsiWDJJ/W9gD8Kf9l/OPdtDGwmFA=; b=bxIagmYtfPKJ8bPHjcH6pLq62JX/RghHybIxxjkLRPUTvtsrItETiWYnbAuNDfkrIU 0dutUKw8cMJyC0voJbFXlSq1odeYkIKtKIe8QVWmdwKN533+dSCED2dapEBACbkxSOcW CjXTZU2pHVSV6cgej1J+cQrI2i1i2ARN/xyR33fk5DF4WFdnKrPRF1GnfQMgPYuR/Czc sfpaYs0QUUwqP99sPqlOm28VaJBrQezSAnasnn5wLQdNYk+APo3TiR7C+LJfmyMnXmP2 XeY5/Zhkpdqa+71jo6aQcKwJJ4ujmQNuZocJrkpTLlBkaFk1JYpizfuopnp6tqpMuDFn MfEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lD7xJ0EYYqQm1DKMsiWDJJ/W9gD8Kf9l/OPdtDGwmFA=; b=O9BKNhhhA5NPArCkENeABG9usNYX8qjNaaFqzeVrSdSJkheKhACnftsaYco8s1mgPu yQzZB6eH2Q8VjEVgmnqt6cHq0shqTaorIwo46WQaxwUyoolcvLkRKttFpHlOawe7PYi5 6tFdQbNZKOcGgbSsMjppUDeQt2/8/xiv16svbTbP/gHjT+G2PfIcWvOxRTH8c2r+1Tgy CVzCIzx31VvpPsXFgZG/xiH0v2ZdROIkZPk3nj4RmuGYY0TuzjrLen3K7Otru1OEwkKe EOErF8ifp5OM+FCo5cfK2+lsxXP/DjM3dOaCosr9jQMKqoD1url0h3du6UHnTnMqX3Te 1+1A== X-Gm-Message-State: AOAM531uOXE2eDq2ZUJQx/mV3UfsoJ6L/J0ti8PgDv8BcCRB6HbsGXlr E3JMU/nt8v3L+zl0qpbFb6r2ou8A55R/zYr9AIly7g== X-Google-Smtp-Source: ABdhPJzVbuCKHbObiYwHB9nSPGF/PEjssrtjBDoUamjkMvh7RUzQqls/tOVY4Y2Wg7QGYIkAdfPzzAeJRHROLF9usOw= X-Received: by 2002:a5d:5581:0:b0:20f:fc51:7754 with SMTP id i1-20020a5d5581000000b0020ffc517754mr45666099wrv.413.1654912826979; Fri, 10 Jun 2022 19:00:26 -0700 (PDT) MIME-Version: 1.0 References: <834k0t104u.fsf@gnu.org> In-Reply-To: <834k0t104u.fsf@gnu.org> From: Duncan Findlay Date: Fri, 10 Jun 2022 18:59:47 -0700 Message-ID: Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000303c8d05e1226b58" X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 55883 X-Mailman-Approved-At: Sat, 11 Jun 2022 04:29:55 -0400 Cc: 55883@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -9.0 (---------) --000000000000303c8d05e1226b58 Content-Type: text/plain; charset="UTF-8" Attached is an updated version that I believe addresses all the concerns raised on the mailing list. Given the changes don't split so cleanly into two any more, I've combined them into a single patch. Thanks! On Thu, Jun 9, 2022 at 11:52 PM Eli Zaretskii wrote: > > > Date: Thu, 9 Jun 2022 23:18:01 -0700 > > From: Duncan Findlay via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > Attached are two patches to allow users that use xterm's OSC 52 > > clipboard support to have their primary selection updated with the > > active region, to better match the behavior of running Emacs in X > > locally. > > > > This behavior is enabled automatically for supported terminals, and is > > controlled by the existing `select-active-regions' variable. > > > > Previous discussion: > > https://lists.gnu.org/archive/html/emacs-devel/2022-06/msg00126.html > > Thanks. > > However, the patches you posted seem to ignore the comments I made in > the above-mentioned discussions, specifically here: > > https://lists.gnu.org/archive/html/emacs-devel/2022-06/msg00134.html > > Did you send a wrong version of the patches, perhaps? --000000000000303c8d05e1226b58 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Support-select-active-regions-with-xterm.patch" Content-Disposition: attachment; filename="0001-Support-select-active-regions-with-xterm.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l4988c840 RnJvbSBiYzkwNmE4YTBjNjcxMjU4ODA0OTdjNDcyOWQ3OTQwZmE0YmE4YmY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEdW5jYW4gRmluZGxheSA8ZHVuY2ZAZ29vZ2xlLmNvbT4KRGF0 ZTogRnJpLCAxMCBKdW4gMjAyMiAxODo0Njo0OSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFN1cHBv cnQgYHNlbGVjdC1hY3RpdmUtcmVnaW9ucycgd2l0aCB4dGVybQoKVGhpcyBhbGxvd3MgRW1hY3Mg dG8gc2F2ZSB0aGUgYWN0aXZlIHJlZ2lvbiB0byB0aGUgdXNlcidzCnByaW1hcnkgc2VsZWN0aW9u IG9uIHN1cHBvcnRlZCB0ZXJtaW5hbHMuICBUaGUgYmVoYXZpb3IgZm9sbG93cwp0aGUgZXhpc3Rp bmcgYHNlbGVjdC1hY3RpdmUtcmVnaW9ucycgdmFyaWFibGUgYW5kIHJlcXVpcmVzCmB4dGVybS1z ZWxlY3QtYWN0aXZlLXJlZ2lvbnMnIHRvIGJlIG5vbi1uaWwuCgoqIHNyYy9rZXlib2FyZC5jIChj b21tYW5kX2xvb3BfMSk6IENoZWNrIHRlcm1pbmFsIHBhcmFtZXRlcgpgZGlzcGxheS1zZWxlY3Rp b25zLXAnIGZvciB0ZXh0IHRlcm1pbmFscyB3aGVuIGRlY2lkaW5nIHdoZXRoZXIKdG8gdXBkYXRl IHByaW1hcnkgc2VsZWN0aW9uLgoqIGxpc3AvZnJhbWUuZWwgKGRpc3BsYXktc2VsZWN0aW9ucy1w KTogUmV0dXJuIHRlcm1pbmFsCnBhcmFtZXRlciBgZGlzcGxheS1zZWxlY3Rpb25zLXAnIHRvIGlu ZGljYXRlIHNlbGVjdGlvbiBzdXBwb3J0LgoqIGxpc3AvdGVybS94dGVybS5lbCAoeHRlcm0tc2Vs ZWN0LWFjdGl2ZS1yZWdpb25zKTogTmV3CmRlZmN1c3RvbS4gICh4dGVybS0taW5pdC1hY3RpdmF0 ZS1zZXQtc2VsZWN0aW9uKTogU2V0CnRoZSBgZGlzcGxheS1zZWxlY3Rpb25zLXAnIHRlcm1pbmFs IHBhcmFtZXRlci4KLS0tCiBldGMvTkVXUyAgICAgICAgICAgfCAgNiArKysrKysKIGxpc3AvZnJh bWUuZWwgICAgICB8ICAyICsrCiBsaXNwL3Rlcm0veHRlcm0uZWwgfCAxMSArKysrKysrKysrLQog c3JjL2tleWJvYXJkLmMgICAgIHwgIDUgKysrKy0KIDQgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdT CmluZGV4IDE3ODlkNDczNTEuLjU3YjVkMDZlNzggMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBi L2V0Yy9ORVdTCkBAIC00OTIsNiArNDkyLDEyIEBAIFRoaXMgaXMgaW4gYWRkaXRpb24gdG8gcHJl dmlvdXNseS1zdXBwb3J0ZWQgd2F5cyBvZiBkaXNjb3ZlcmluZyAyNC1iaXQKIGNvbG9yIHN1cHBv cnQ6IGVpdGhlciB2aWEgdGhlICJSR0IiIG9yICJzZXRmMjQiIGNhcGFiaWxpdGllcywgb3IgaWYK IHRoZSAnQ09MT1JURVJNJyBlbnZpcm9ubWVudCB2YXJpYWJsZSBpcyBzZXQgdG8gdGhlIHZhbHVl ICJ0cnVlY29sb3IiLgogCisqKiogU2VsZWN0IGFjdGl2ZSByZWdpb25zIHdpdGggeHRlcm0gc2Vs ZWN0aW9uIHN1cHBvcnQuCitPbiB0ZXJtaW5hbHMgd2l0aCB4dGVybSBzZXRTZWxlY3Rpb24gc3Vw cG9ydCwgdGhlIGFjdGl2ZSByZWdpb24gbWF5IGJlCitzYXZlZCB0byB0aGUgWCBwcmltYXJ5IHNl bGVjdGlvbiwgZm9sbG93aW5nIHRoZQorJ3NlbGVjdC1hY3RpdmUtcmVnaW9ucycgdmFyaWFibGUu IFRoaXMgc3VwcG9ydCBpcyBlbmFibGVkIHdpdGgKKyd4dGVybS1zZWxlY3QtYWN0aXZlLXJlZ2lv bnMnLgorCiAqKiBFUlQKIAogKysrCmRpZmYgLS1naXQgYS9saXNwL2ZyYW1lLmVsIGIvbGlzcC9m cmFtZS5lbAppbmRleCAyN2Y5OWZiN2QyLi5lNTMwYWZiMzg3IDEwMDY0NAotLS0gYS9saXNwL2Zy YW1lLmVsCisrKyBiL2xpc3AvZnJhbWUuZWwKQEAgLTIxNjQsNiArMjE2NCw4IEBAIGRpc3BsYXkt c2VsZWN0aW9ucy1wCiAgICAgICAgKG5vdCAobnVsbCBkb3Mtd2luZG93cy12ZXJzaW9uKSkpKQog ICAgICAoKG1lbXEgZnJhbWUtdHlwZSAnKHggdzMyIG5zIHBndGspKQogICAgICAgdCkKKyAgICAg KCh0ZXJtaW5hbC1wYXJhbWV0ZXIgZGlzcGxheSAnZGlzcGxheS1zZWxlY3Rpb25zLXApCisgICAg ICB0KQogICAgICAodAogICAgICAgbmlsKSkpKQogCmRpZmYgLS1naXQgYS9saXNwL3Rlcm0veHRl cm0uZWwgYi9saXNwL3Rlcm0veHRlcm0uZWwKaW5kZXggYTdlMjU3ZjQxYy4uNjcxZDc1N2MxMSAx MDA2NDQKLS0tIGEvbGlzcC90ZXJtL3h0ZXJtLmVsCisrKyBiL2xpc3AvdGVybS94dGVybS5lbApA QCAtODAsNiArODAsMTMgQEAgeHRlcm0tc3RvcmUtcGFzdGUtb24ta2lsbC1yaW5nCiAgIDp2ZXJz aW9uICIyOC4xIgogICA6dHlwZSAnYm9vbGVhbikKIAorKGRlZmN1c3RvbSB4dGVybS1zZWxlY3Qt YWN0aXZlLXJlZ2lvbnMgbmlsCisgICJJZiBub24tbmlsLCBvbiBhIHRlcm1pbmFsIHdpdGggc2V0 U2VsZWN0aW9uIHN1cHBvcnQsIEVtYWNzIHdpbGwKK2Fsc28gdXBkYXRlIHRoZSBwcmltYXJ5IHNl bGVjdGlvbiB3aXRoIHRoZSBhY3RpdmUgcmVnaW9uLCBiYXNlZAorb24gdGhlIHZhbHVlIG9mIGBz ZWxlY3QtYWN0aXZlLXJlZ2lvbnMnLiIKKyAgOnZlcnNpb24gIjI5LjEiCisgIDp0eXBlICdib29s ZWFuKQorCiAoZGVmY29uc3QgeHRlcm0tcGFzdGUtZW5kaW5nLXNlcXVlbmNlICJcZVsyMDF+Igog ICAiQ2hhcmFjdGVycyBzZW50IGJ5IHRoZSB0ZXJtaW5hbCB0byBlbmQgYSBicmFja2V0ZWQgcGFz dGUuIikKIApAQCAtOTQ2LDcgKzk1Myw5IEBAIHh0ZXJtLS1pbml0LWFjdGl2YXRlLWdldC1zZWxl Y3Rpb24KIAogKGRlZnVuIHh0ZXJtLS1pbml0LWFjdGl2YXRlLXNldC1zZWxlY3Rpb24gKCkKICAg IlRlcm1pbmFsIGluaXRpYWxpemF0aW9uIGZvciBgZ3VpLXNldC1zZWxlY3Rpb24nLiIKLSAgKHNl dC10ZXJtaW5hbC1wYXJhbWV0ZXIgbmlsICd4dGVybS0tc2V0LXNlbGVjdGlvbiB0KSkKKyAgKHNl dC10ZXJtaW5hbC1wYXJhbWV0ZXIgbmlsICd4dGVybS0tc2V0LXNlbGVjdGlvbiB0KQorICAod2hl biB4dGVybS1zZWxlY3QtYWN0aXZlLXJlZ2lvbnMKKyAgICAoc2V0LXRlcm1pbmFsLXBhcmFtZXRl ciBuaWwgJ2Rpc3BsYXktc2VsZWN0aW9ucy1wIHQpKSkKIAogKGRlZnVuIHh0ZXJtLS1pbml0LWZy YW1lLXRpdGxlICgpCiAgICJUZXJtaW5hbCBpbml0aWFsaXphdGlvbiBmb3IgWFRlcm0gZnJhbWUg dGl0bGVzLiIKZGlmZiAtLWdpdCBhL3NyYy9rZXlib2FyZC5jIGIvc3JjL2tleWJvYXJkLmMKaW5k ZXggNTVkNzEwZWQ2Mi4uOGUzNzM4YjRjNyAxMDA2NDQKLS0tIGEvc3JjL2tleWJvYXJkLmMKKysr IGIvc3JjL2tleWJvYXJkLmMKQEAgLTEsMyArMSw0IEBACisKIC8qIEtleWJvYXJkIGFuZCBtb3Vz ZSBpbnB1dDsgZWRpdG9yIGNvbW1hbmQgbG9vcC4KIAogQ29weXJpZ2h0IChDKSAxOTg1LTE5ODks IDE5OTMtMTk5NywgMTk5OS0yMDIyIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwKQEAgLTE1Njks NyArMTU3MCw4IEBAIGNvbW1hbmRfbG9vcF8xICh2b2lkKQogCSAgICB7CiAJICAgICAgLyogRXZl biBpZiBub3QgZGVhY3RpdmF0aW5nIHRoZSBtYXJrLCBzZXQgUFJJTUFSWSBpZgogCQkgYHNlbGVj dC1hY3RpdmUtcmVnaW9ucycgaXMgbm9uLW5pbC4gICovCi0JICAgICAgaWYgKCFOSUxQIChGd2lu ZG93X3N5c3RlbSAoUW5pbCkpCisJICAgICAgaWYgKCghTklMUCAoRndpbmRvd19zeXN0ZW0gKFFu aWwpKSB8fAorCQkgICAhTklMUCAoRnRlcm1pbmFsX3BhcmFtZXRlciAoUW5pbCwgUWRpc3BsYXlf c2VsZWN0aW9uc19wKSkpCiAJCSAgLyogRXZlbiBpZiBtYXJrX2FjdGl2ZSBpcyBub24tbmlsLCB0 aGUgYWN0dWFsIGJ1ZmZlcgogCQkgICAgIG1hcmtlciBtYXkgbm90IGhhdmUgYmVlbiBzZXQgeWV0 IChCdWcjNzA0NCkuICAqLwogCQkgICYmIFhNQVJLRVIgKEJWQVIgKGN1cnJlbnRfYnVmZmVyLCBt YXJrKSktPmJ1ZmZlcgpAQCAtMTIxNjIsNiArMTIxNjQsNyBAQCBzeW1zX29mX2tleWJvYXJkICh2 b2lkKQogCiAgIERFRlNZTSAoUXBvbGxpbmdfcGVyaW9kLCAicG9sbGluZy1wZXJpb2QiKTsKIAor ICBERUZTWU0gKFFkaXNwbGF5X3NlbGVjdGlvbnNfcCwgImRpc3BsYXktc2VsZWN0aW9ucy1wIik7 CiAgIERFRlNZTSAoUWd1aV9zZXRfc2VsZWN0aW9uLCAiZ3VpLXNldC1zZWxlY3Rpb24iKTsKIAog ICAvKiBUaGUgcHJpbWFyeSBzZWxlY3Rpb24uICAqLwotLSAKMi4zNi4xLjQ3Ni5nMGM0ZGFhMjA2 ZC1nb29nCgo= --000000000000303c8d05e1226b58-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 01:57:51 2022 Received: (at 55883) by debbugs.gnu.org; 14 Jun 2022 05:57:51 +0000 Received: from localhost ([127.0.0.1]:60927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0zYl-0003Rh-Ky for submit@debbugs.gnu.org; Tue, 14 Jun 2022 01:57:51 -0400 Received: from sonic309-22.consmr.mail.ne1.yahoo.com ([66.163.184.148]:42877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0zYj-0003RU-Uk for 55883@debbugs.gnu.org; Tue, 14 Jun 2022 01:57:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1655186264; bh=1V214OtGaD3sMQqDB+eknse0cS4wzBAsGBtHYQUGU7o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=iPtrRtr1dIs7rlkdS7/XTN09HPIvW7D12Ylxmyg/9hvfjhaEgDOAAxjJUMgZlqQcNCalErT0YdMKSCFzvqjawqQBznHYb6Ssu8kUTshUlxO6JocU+1wiJFmI/fQabWTlmHc2/M4fD9/pPg6icKWBIDLhEgAuRumxmBxZETc+LNp6Ua5hErQBpewpymR8DrWTh9CdX5bu2mw8Dx2OGtYzpq8M+t33l58D0TBve6KXSxl/KiWEypTKEwSw4v7EqwSBtEwoTLlRTYu43wIBJ5zvEE3Pn+/DC/8492X4/4DysPzoZsAWO0pnmYsHzwTbmqzIqDwPx2pFSD25C6DGyLEhEA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1655186264; bh=Z9xGoq9dC7Pi8khfI2HGo27CvfXSIifoax4JjJOMiHl=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=PqX3JOedy8R5vMKRFPqldLe1APefijKTGm6VbZvCm7z6tA2Hzw8AqTYjeyGoMgjP86BAkaN2xus32/CBQqz5FXDyMbXOvuA7QDwZEXFpTvahyGxAelYHapHG0a17MHPeODf0e2AuKnF0wW8qUsdw7ZYEXgBhvAWzdsoqjHRdnMya+2W/AfKfMoXUuWpu3DlVnaMt0bFrOGaIvz+VATrh4d6fUkNwZttE8pWRlPi4ZXs20QzSJ/zpAgZ1i+1mzdHjkNDBf0GnYMjSnN32z2yI+L1tR0vHI8Ty00HOMwAVsKvWVT9Bc1pPrFTrs1h0kT8CACA3kVIFGx+HNn5fDt5SaA== X-YMail-OSG: hBiN8W4VM1lwZ8JUXn3CRA6g2eiX.krCVKUvOVV3geT1Eii.EBL__aav1VahubB 084Pe9.ZLtMfc2FEHO3yH1k.ZzCo4RBjZ7m0IQCuiAnJwxlLOrEAbGspOw7yrz17gDkRSctHuX9B 5VPbHckb5ms0M2APCIAyvnSttdGmnKmgX.pKokfm10_2IyxiH_XsRHb_Co3AQdMG_9ZW_J7AJvQe kMwmPhjvexyeJH70Pso2S0aPqgfV_j9JMCNWOWHxTHrrD2d9zjtMspItkt5yJvS9oTKRQLJXSN9S 7TT_SKHGnLetFdm83j6e5yx3_Pfov0dmhxqL4_TTSpi7dLkyAMrfp3C5g_a9PnvdF0P5Axg2J0BN _vjXQ2cdoCLy9ddV2ClYvgWqMjAvyHog6DfJkH4dQh0TTdqYsvT9URJJRBWH_1jQOrA9UdQGGNiV 289Oj2Aw4v3KLDhPZhH5zy.giju3XFydChUm..WpI.A5shSTINL31lxLoUd3IIJk90mIRamNVcos 1N2ypFbIuzmFnUiI5BVAnJL8HMNbJ9GB4sNMU6Lwyu2YKRBaHmT95.8kUKmAkFTBT1n3pm_yroXP byYPzSs_76o6vMegjFaSdj.JitdLwbqnDhAFhyWF2ZzkaqxaDg4yWGhPupLsK4pskRw97UHElvw1 OxCkRhBUTrV4Rnc0CdagSaQxulr.tUFjlZenyZcawLruLQLnOgNnQiJU3qyQv8JopSk5xcRDKE6x emtTpeP5_e0CVgg4lj_i5PT9iPZVg9HCwZ4sD2UIM9aeX9JVj9h1tHkH49vlpR_X5AY__80yub8M Zuu_EAbqqIbVQa27aiOab6FyrJNAspoPC_voK8M0VTjDwpYnfSS53e9INLBnWygqmY6OEwjNnoO7 pUR941S0Q2_uhqVNr1xIXh1BUBGgWegWnm950B2Aqk1OM2wb1v7CXlvMgksDKhHh4KHnPuSNBYXX xiUfKRU3hKEPXwlDFAra02W59qrgHIGu2gcr4erlGNuxiSm7aVptIJmNkHgsB4ctxe_Dn95RcC3g bO6R.3hNJi7iODuE6IaRK9pV9iMHoM8rP.PI5sFJBFH9TKIyeOvkAstcm7X44bGGK5PAuzw9ozOa 3q_JG.kvstEEEqvYtUgwZJH87enA8dGEYMU3SXvwK_gf8WRwRQPhx2kMHlmHGUeQj69wUGmo5MMt hApLPezX4VWijlP1cTRHavx0TlbbcOgGHD5JR5EHVijOkdo_5gw8va9SPRP8ynFpTHVkSacffFsB rqBo0LWpBkh5PFm3W9zW4MnocYBFDH.7sgqfmX0tsdwfuFP37sAQUl4Kl3j1App_mpYlJyF3w.JU .ePyITctG4Ko2hG3cYw9NbVxM74uSvJjsbZHshLU7taio26yPSG1m7y4hB2mP53YlkGfzwkAjSM2 WPkh97eU3_1NHzasq.RLOyfaU7bJOkvRF71wZPPGJVDBo._uWB.m.zX7YlB5yk4JZHJ8mUWhkMD. 23uMdnmCByfncjcbL3nzzIc.z_hR6hM.SCchOA5Gx.kr.EGK2qFUpfxsOxAxe_2tYcISRpyuDQam t7Q3ZxPcPsK5PhXUcOvVHqVP3hTQLLxviG6HjZW33hIUeXmwy_e47MoE8fDXVu8fHTg87bYlPXVg 8zeRYlJQLud4b4xY1x5lTatPF1b_ZJWylgNQltu1HY077LmF.GEt12K378lEPkrwSISc6SqTMfvz 89i72bkLqy8NxJWF0pVTrstd7DRXUtOXcZ9hMo_GI0im3G2XEyBm8aJ9Yk83EQ01fgGk99kjHj2F kB1P19VD55PZUgjI_oEpn0dzciOOZbJJppvfpp97yt.vNntefz86pBya2d0ry3TLGSC9a.Pn2q01 byyO9E07m3BMMc3qDUtbYqbhxZ4qJ.RD4uqhExLEQTvXHr4Q5ZptH1E1oCYU4yzJs.rQ1lY7vQhj _xtpgeRi1zEtdVdl3WtBD18QXJjaD.eg.nIGjRqDl9IOnHh2vlTlRuxcMlSoF7Xz._KFsNVIFYGa Gmg1a_CmOn0Ff7BJxE3ElIlt2fttBE3lY8cwDX6lEWYAJTTSMZW.ylVNUxdEuChx3q_Hh2c2rFox c9E06bm9RrzYdJwW_cINXZJ4Pt3TelGvlC1EK..cvIHIJWzi9IgERAtO4NrqtoC_VqL3iOa_HlLY ZAQ4sG8nqbICFirZrxGG.mMkw054RynTspIa5pKoQAy_gk.hemewjKuZakSvNOPaoGj5HyY1afy7 OnKLLtUiR_ha1nf8GKE3et2aWqqOFmvo4EsjTPqeJaYfqxaFu98_P X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Tue, 14 Jun 2022 05:57:44 +0000 Received: by hermes--canary-production-sg3-5f7658c994-7rkj7 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 745fc29793c5c33cf888568ff1c8e394; Tue, 14 Jun 2022 05:57:37 +0000 (UTC) From: Po Lu To: Duncan Findlay Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions References: <834k0t104u.fsf@gnu.org> <8335gbzled.fsf@gnu.org> Date: Tue, 14 Jun 2022 13:57:33 +0800 In-Reply-To: <8335gbzled.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 11 Jun 2022 10:53:14 +0300") Message-ID: <87sfo7aisy.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20280 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 387 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55883 Cc: Eli Zaretskii , 55883@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> + if ((!NILP (Fwindow_system (Qnil)) || >> + !NILP (Fterminal_parameter (Qnil, Qdisplay_selections_p))) In addition to what Eli wrote, this code is formatted incorrectly. Here and elsewhere, please write: if (very_long_condition () || another_very_long_condition ()) as opposed to if (very_long_condition () || another_very_long_condition ()) Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 03:34:12 2022 Received: (at 55883) by debbugs.gnu.org; 14 Jun 2022 07:34:12 +0000 Received: from localhost ([127.0.0.1]:32795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o113z-0007xV-TX for submit@debbugs.gnu.org; Tue, 14 Jun 2022 03:34:12 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:46992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o10Ac-0004P1-5d for 55883@debbugs.gnu.org; Tue, 14 Jun 2022 02:36:59 -0400 Received: by mail-wr1-f51.google.com with SMTP id u8so9771123wrm.13 for <55883@debbugs.gnu.org>; Mon, 13 Jun 2022 23:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jZ5cIc0EYlWs1in2jzWh3IXOg0gLbPa/eDgysDf2JEo=; b=INnjndI/+/ZyQql8zXB2AvTs+yZLmfssvRbVoU4wXqY/XYVg03saf9kfR6UB7RVbrP q1LzfR6I02qsDuy46HQwNBkLcj81styqw5QZx0tYaJl3dONvVeiG4ng7Wu9GfykzFm/p wkD0ilsi16UGGdVQIL00qOjamKs8FfPi9+8B5gIXzPg2otEWjNRBnIA9s8F4lgh2F2BH 9Icxj2RDVyLNHzLpHlO3YKr03JSAqBERYvAaqDY8XKr/ZfSqNEnTInhrYhuLLBOBROeg BaDhMJ//OKcog3T5gz8niEwfnwEBdvoJLEyaFr7D7844Uv68DYnJ+Rx2bvKVjSzAIqSS WyWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jZ5cIc0EYlWs1in2jzWh3IXOg0gLbPa/eDgysDf2JEo=; b=fzXtR0hIVSCGalFTpGJxBD/l3/HoZe8x4TLrWUPfaDQicbXAdopA1Qq3CrLGN5kNCs acv4L4ifN/XQBJ+B++t5fI55/HM/6rRfAPUQs2uJkayRPi2XVBr525Iz1w7l3cwYZWQ0 rwlgorkt22VojAj0L80IpsOmNom7O1mMWhVCXC2r8rTZ4APfuWX88jq5UnsGUNIzKUhz Jk4CWdwht7uqiJD8pMmZ3qoZds9jODJYVQNuHQOPN9kCi4lThCey0drKUSntmiAsX3Jt cvgriGQLgaKgUm8v/ziEZiIRKHWS8c2w/L8q42xbzliMxhqjrC/gyvJXbWWqIYukaMNW RJ0A== X-Gm-Message-State: AJIora/Mvc1n9jlUXwXvoqBu+CWbcg4y/ItvONu7VBXjepIrvosF3xzY OBIhqSwuySaP89b5CBmVEQl4Qi+3Al008uh0+YvqWqtvDrY= X-Google-Smtp-Source: AGRyM1tnLauNWPm8ddpqjjZ5NhrZGEvkwO5fbC1bHHlbbhtIXRsAMIWO819/PvOfKhzknzG49Z5pO0yJjOyeFdcqVMc= X-Received: by 2002:a05:6000:91:b0:217:8efc:f572 with SMTP id m17-20020a056000009100b002178efcf572mr3166467wrx.186.1655188611799; Mon, 13 Jun 2022 23:36:51 -0700 (PDT) MIME-Version: 1.0 References: <834k0t104u.fsf@gnu.org> <8335gbzled.fsf@gnu.org> In-Reply-To: <8335gbzled.fsf@gnu.org> From: Duncan Findlay Date: Mon, 13 Jun 2022 23:36:13 -0700 Message-ID: Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions To: Eli Zaretskii Content-Type: multipart/mixed; boundary="0000000000003f19e605e162a190" X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 55883 X-Mailman-Approved-At: Tue, 14 Jun 2022 03:34:10 -0400 Cc: 55883@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -9.0 (---------) --0000000000003f19e605e162a190 Content-Type: text/plain; charset="UTF-8" On Sat, Jun 11, 2022 at 12:53 AM Eli Zaretskii wrote: > > > From: Duncan Findlay > > Date: Fri, 10 Jun 2022 18:59:47 -0700 > > Cc: 55883@debbugs.gnu.org > > > > Attached is an updated version that I believe addresses all the > > concerns raised on the mailing list. > > > > Given the changes don't split so cleanly into two any more, I've > > combined them into a single patch. > > Thanks. A few minor issues with this version: > > > * src/keyboard.c (command_loop_1): Check terminal parameter > > `display-selections-p' for text terminals when deciding whether > > to update primary selection. > > * lisp/frame.el (display-selections-p): Return terminal > > parameter `display-selections-p' to indicate selection support. > > * lisp/term/xterm.el (xterm-select-active-regions): New > > defcustom. (xterm--init-activate-set-selection): Set > > the `display-selections-p' terminal parameter. > > Please mention the bug number in the log message. Done. > > +*** Select active regions with xterm selection support. > > +On terminals with xterm setSelection support, the active region may be > > +saved to the X primary selection, following the > > +'select-active-regions' variable. This support is enabled with > > +'xterm-select-active-regions'. ^^ > > Our convention is to leave 2 spaces between sentences in > documentation. Done. > > --- a/lisp/frame.el > > +++ b/lisp/frame.el > > @@ -2164,6 +2164,8 @@ display-selections-p > > (not (null dos-windows-version)))) > > ((memq frame-type '(x w32 ns pgtk)) > > t) > > + ((terminal-parameter display 'display-selections-p) > > + t) > > This should test xterm--set-selection parameter. OK, so the goal is to check the xterm--set-selection terminal parameter and variable xterm-select-active-regions before selecting the active region in deactivate-mark in simple.el. We could do this in display-selections-p, but given that these variables are not obviously related to display-selections-p, it seems to me we probably want to do this check in deactivate-mark instead. Does that seem reasonable to you? > > +(defcustom xterm-select-active-regions nil > > + "If non-nil, on a terminal with setSelection support, Emacs will > > +also update the primary selection with the active region, based > > +on the value of `select-active-regions'." > > The first line of a doc string should be a complete sentence. So this > doc strings should be reworded to comply with this convention. For > example: > > "If non-nil, update PRIMARY X selection on text-mode frames. > On a text-mode terminal that supports setSelection command, if > this variable is non-nil, Emacs will set the PRIMARY selection > from the active region, according to `select-active-regions'." Done, thanks. > > @@ -946,7 +953,9 @@ xterm--init-activate-get-selection > > > > (defun xterm--init-activate-set-selection () > > "Terminal initialization for `gui-set-selection'." > > - (set-terminal-parameter nil 'xterm--set-selection t)) > > + (set-terminal-parameter nil 'xterm--set-selection t) > > + (when xterm-select-active-regions > > + (set-terminal-parameter nil 'display-selections-p t))) > > I see no reason to introduce a new terminal parameter with non-trivial > semantics. Moreover, this consults the value of > xterm-select-active-regions only once, so if the user later modifies > the value of the option, the terminal parameter will stay at its stale > value. > > I think the code should instead check the value of > xterm-select-active-regions in keyboard.c, where it decides whether to > set PRIMARY. (Let me know if you need guidance for how to reference a > Lisp variable from C.) This seems to work -- is there a better way? !NILP (SYMBOL_VAL (XSYMBOL (Qxterm_select_active_regions))) > > @@ -1569,7 +1570,8 @@ command_loop_1 (void) > > { > > /* Even if not deactivating the mark, set PRIMARY if > > `select-active-regions' is non-nil. */ > > - if (!NILP (Fwindow_system (Qnil)) > > + if ((!NILP (Fwindow_system (Qnil)) || > > + !NILP (Fterminal_parameter (Qnil, Qdisplay_selections_p))) > > This should be looking at the xterm--set-selection parameter instead, > and test the value of xterm-select-active-regions in addition, as > described above. Done. I've also addressed Po's comments about long conditionals. Thanks Duncan --0000000000003f19e605e162a190 Content-Type: application/x-patch; name="0001-Support-select-active-regions-with-xterm.patch" Content-Disposition: attachment; filename="0001-Support-select-active-regions-with-xterm.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l4dsi9n40 RnJvbSAxNDY4M2U2YWQ2M2JkMWY2MzEyZmQ2MDlkODBiZDg5MDM1ZWUwMzcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEdW5jYW4gRmluZGxheSA8ZHVuY2ZAZ29vZ2xlLmNvbT4KRGF0 ZTogRnJpLCAxMCBKdW4gMjAyMiAxODo0Njo0OSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFN1cHBv cnQgYHNlbGVjdC1hY3RpdmUtcmVnaW9ucycgd2l0aCB4dGVybQoKVGhpcyBhbGxvd3MgRW1hY3Mg dG8gc2F2ZSB0aGUgYWN0aXZlIHJlZ2lvbiB0byB0aGUgdXNlcidzCnByaW1hcnkgc2VsZWN0aW9u IG9uIHN1cHBvcnRlZCB0ZXJtaW5hbHMuICBUaGUgYmVoYXZpb3IgZm9sbG93cwp0aGUgZXhpc3Rp bmcgYHNlbGVjdC1hY3RpdmUtcmVnaW9ucycgdmFyaWFibGUgYW5kIHJlcXVpcmVzCmB4dGVybS1z ZWxlY3QtYWN0aXZlLXJlZ2lvbnMnIHRvIGJlIG5vbi1uaWwuCgoqIHNyYy9rZXlib2FyZC5jIChj b21tYW5kX2xvb3BfMSk6CiogbGlzcC9zaW1wbGUuZWwgKGRlYWN0aXZhdGUtbWFyayk6IE9uIHRl eHQgdGVybWluYWxzLCBjaGVjawp0ZXJtaW5hbCBwYXJhbWV0ZXIgYHh0ZXJtLS1zZXQtc2VsZWN0 aW9ucycgYW5kIHZhcmlhYmxlCmB4dGVybS1zZWxlY3QtYWN0aXZlLXJlZ2lvbnMnIHdoZW4gZGVj aWRpbmcgd2hldGhlciB0byB1cGRhdGUKcHJpbWFyeSBzZWxlY3Rpb24uIChidWcjNTU4ODMpCiog bGlzcC90ZXJtL3h0ZXJtLmVsICh4dGVybS1zZWxlY3QtYWN0aXZlLXJlZ2lvbnMpOiBOZXcKZGVm Y3VzdG9tLgotLS0KIGV0Yy9ORVdTICAgICAgICAgICB8IDYgKysrKysrCiBsaXNwL3NpbXBsZS5l bCAgICAgfCA3ICsrKysrKy0KIGxpc3AvdGVybS94dGVybS5lbCB8IDggKysrKysrKysKIHNyYy9r ZXlib2FyZC5jICAgICB8IDYgKysrKystCiA0IGZpbGVzIGNoYW5nZWQsIDI1IGluc2VydGlvbnMo KyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRl eCAxYjg1NjBhOTIzLi41ZGE5YjRhN2VhIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMv TkVXUwpAQCAtNTAyLDYgKzUwMiwxMiBAQCBUaGlzIGlzIGluIGFkZGl0aW9uIHRvIHByZXZpb3Vz bHktc3VwcG9ydGVkIHdheXMgb2YgZGlzY292ZXJpbmcgMjQtYml0CiBjb2xvciBzdXBwb3J0OiBl aXRoZXIgdmlhIHRoZSAiUkdCIiBvciAic2V0ZjI0IiBjYXBhYmlsaXRpZXMsIG9yIGlmCiB0aGUg J0NPTE9SVEVSTScgZW52aXJvbm1lbnQgdmFyaWFibGUgaXMgc2V0IHRvIHRoZSB2YWx1ZSAidHJ1 ZWNvbG9yIi4KIAorKioqIFNlbGVjdCBhY3RpdmUgcmVnaW9ucyB3aXRoIHh0ZXJtIHNlbGVjdGlv biBzdXBwb3J0LgorT24gdGVybWluYWxzIHdpdGggeHRlcm0gc2V0U2VsZWN0aW9uIHN1cHBvcnQs IHRoZSBhY3RpdmUgcmVnaW9uIG1heSBiZQorc2F2ZWQgdG8gdGhlIFggcHJpbWFyeSBzZWxlY3Rp b24sIGZvbGxvd2luZyB0aGUKKydzZWxlY3QtYWN0aXZlLXJlZ2lvbnMnIHZhcmlhYmxlLiAgVGhp cyBzdXBwb3J0IGlzIGVuYWJsZWQgd2l0aAorJ3h0ZXJtLXNlbGVjdC1hY3RpdmUtcmVnaW9ucycu CisKICoqIEVSVAogCiArKysKZGlmZiAtLWdpdCBhL2xpc3Avc2ltcGxlLmVsIGIvbGlzcC9zaW1w bGUuZWwKaW5kZXggMDVhMDg1NWE5Ni4uMGJlNGNiYjIyZSAxMDA2NDQKLS0tIGEvbGlzcC9zaW1w bGUuZWwKKysrIGIvbGlzcC9zaW1wbGUuZWwKQEAgLTY2NjEsNiArNjY2MSw5IEBAIG1hcmsKIAog OzsgQmVoaW5kIGRpc3BsYXktc2VsZWN0aW9ucy1wLgogCis7OyBGcm9tIHRlcm0veHRlcm0uZWwK KyhkZWZ2YXIgeHRlcm0tc2VsZWN0LWFjdGl2ZS1yZWdpb25zKQorCiAoZGVmdW4gZGVhY3RpdmF0 ZS1tYXJrICgmb3B0aW9uYWwgZm9yY2UpCiAgICJEZWFjdGl2YXRlIHRoZSBtYXJrLgogSWYgVHJh bnNpZW50IE1hcmsgbW9kZSBpcyBkaXNhYmxlZCwgdGhpcyBmdW5jdGlvbiBub3JtYWxseSBkb2Vz CkBAIC02Njc5LDcgKzY2ODIsOSBAQCBkZWFjdGl2YXRlLW1hcmsKIAkJICAgKGVxIChjYXItc2Fm ZSB0cmFuc2llbnQtbWFyay1tb2RlKSAnb25seSkKIAkJIHNlbGVjdC1hY3RpdmUtcmVnaW9ucykK IAkgICAgICAgKHJlZ2lvbi1hY3RpdmUtcCkKLQkgICAgICAgKGRpc3BsYXktc2VsZWN0aW9ucy1w KSkKKyAgICAgICAgICAgICAgIChvciAoZGlzcGxheS1zZWxlY3Rpb25zLXApCisgICAgICAgICAg ICAgICAgICAgKGFuZCB4dGVybS1zZWxlY3QtYWN0aXZlLXJlZ2lvbnMKKyAgICAgICAgICAgICAg ICAgICAgICAgICh0ZXJtaW5hbC1wYXJhbWV0ZXIgbmlsICd4dGVybS0tc2V0LXNlbGVjdGlvbikp KSkKICAgICAgIDs7IFRoZSB2YXIgYHNhdmVkLXJlZ2lvbi1zZWxlY3Rpb24nLCBpZiBub24tbmls LCBpcyB0aGUgdGV4dCBpbgogICAgICAgOzsgdGhlIHJlZ2lvbiBwcmlvciB0byB0aGUgbGFzdCBj b21tYW5kIG1vZGlmeWluZyB0aGUgYnVmZmVyLgogICAgICAgOzsgU2V0IHRoZSBzZWxlY3Rpb24g dG8gdGhhdCwgb3IgdG8gdGhlIGN1cnJlbnQgcmVnaW9uLgpkaWZmIC0tZ2l0IGEvbGlzcC90ZXJt L3h0ZXJtLmVsIGIvbGlzcC90ZXJtL3h0ZXJtLmVsCmluZGV4IGE3ZTI1N2Y0MWMuLjA3OTE3ODBk NDAgMTAwNjQ0Ci0tLSBhL2xpc3AvdGVybS94dGVybS5lbAorKysgYi9saXNwL3Rlcm0veHRlcm0u ZWwKQEAgLTgwLDYgKzgwLDE0IEBAIHh0ZXJtLXN0b3JlLXBhc3RlLW9uLWtpbGwtcmluZwogICA6 dmVyc2lvbiAiMjguMSIKICAgOnR5cGUgJ2Jvb2xlYW4pCiAKKyhkZWZjdXN0b20geHRlcm0tc2Vs ZWN0LWFjdGl2ZS1yZWdpb25zIG5pbAorICAiSWYgbm9uLW5pbCwgdXBkYXRlIFBSSU1BUlkgWCBz ZWxlY3Rpb24gb24gdGV4dC1tb2RlIGZyYW1lcy4KK09uIGEgdGV4dC1tb2RlIHRlcm1pbmFsIHRo YXQgc3VwcG9ydHMgc2V0U2VsZWN0aW9uIGNvbW1hbmQsIGlmCit0aGlzIHZhcmlhYmxlIGlzIG5v bi1uaWwsIEVtYWNzIHdpbGwgc2V0IHRoZSBQUklNQVJZIHNlbGVjdGlvbgorZnJvbSB0aGUgYWN0 aXZlIHJlZ2lvbiwgYWNjb3JkaW5nIHRvIGBzZWxlY3QtYWN0aXZlLXJlZ2lvbnMnLiIKKyAgOnZl cnNpb24gIjI5LjEiCisgIDp0eXBlICdib29sZWFuKQorCiAoZGVmY29uc3QgeHRlcm0tcGFzdGUt ZW5kaW5nLXNlcXVlbmNlICJcZVsyMDF+IgogICAiQ2hhcmFjdGVycyBzZW50IGJ5IHRoZSB0ZXJt aW5hbCB0byBlbmQgYSBicmFja2V0ZWQgcGFzdGUuIikKIApkaWZmIC0tZ2l0IGEvc3JjL2tleWJv YXJkLmMgYi9zcmMva2V5Ym9hcmQuYwppbmRleCA1NWQ3MTBlZDYyLi43NmI5ZTNiZDEzIDEwMDY0 NAotLS0gYS9zcmMva2V5Ym9hcmQuYworKysgYi9zcmMva2V5Ym9hcmQuYwpAQCAtMTU2OSw3ICsx NTY5LDkgQEAgY29tbWFuZF9sb29wXzEgKHZvaWQpCiAJICAgIHsKIAkgICAgICAvKiBFdmVuIGlm IG5vdCBkZWFjdGl2YXRpbmcgdGhlIG1hcmssIHNldCBQUklNQVJZIGlmCiAJCSBgc2VsZWN0LWFj dGl2ZS1yZWdpb25zJyBpcyBub24tbmlsLiAgKi8KLQkgICAgICBpZiAoIU5JTFAgKEZ3aW5kb3df c3lzdGVtIChRbmlsKSkKKwkgICAgICBpZiAoKCFOSUxQIChGd2luZG93X3N5c3RlbSAoUW5pbCkp CisJCSAgIHx8ICghTklMUCAoU1lNQk9MX1ZBTCAoWFNZTUJPTCAoUXh0ZXJtX3NlbGVjdF9hY3Rp dmVfcmVnaW9ucykpKQorCQkgICAgICAgJiYgIU5JTFAgKEZ0ZXJtaW5hbF9wYXJhbWV0ZXIgKFFu aWwsIFF4dGVybV9fc2V0X3NlbGVjdGlvbikpKSkKIAkJICAvKiBFdmVuIGlmIG1hcmtfYWN0aXZl IGlzIG5vbi1uaWwsIHRoZSBhY3R1YWwgYnVmZmVyCiAJCSAgICAgbWFya2VyIG1heSBub3QgaGF2 ZSBiZWVuIHNldCB5ZXQgKEJ1ZyM3MDQ0KS4gICovCiAJCSAgJiYgWE1BUktFUiAoQlZBUiAoY3Vy cmVudF9idWZmZXIsIG1hcmspKS0+YnVmZmVyCkBAIC0xMjE2Myw2ICsxMjE2NSw4IEBAIHN5bXNf b2Zfa2V5Ym9hcmQgKHZvaWQpCiAgIERFRlNZTSAoUXBvbGxpbmdfcGVyaW9kLCAicG9sbGluZy1w ZXJpb2QiKTsKIAogICBERUZTWU0gKFFndWlfc2V0X3NlbGVjdGlvbiwgImd1aS1zZXQtc2VsZWN0 aW9uIik7CisgIERFRlNZTSAoUXh0ZXJtX19zZXRfc2VsZWN0aW9uLCAieHRlcm0tLXNldC1zZWxl Y3Rpb24iKTsKKyAgREVGU1lNIChReHRlcm1fc2VsZWN0X2FjdGl2ZV9yZWdpb25zLCAieHRlcm0t c2VsZWN0LWFjdGl2ZS1yZWdpb25zIik7CiAKICAgLyogVGhlIHByaW1hcnkgc2VsZWN0aW9uLiAg Ki8KICAgREVGU1lNIChRUFJJTUFSWSwgIlBSSU1BUlkiKTsKLS0gCjIuMzYuMS40NzYuZzBjNGRh YTIwNmQtZ29vZwoK --0000000000003f19e605e162a190-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 08:15:31 2022 Received: (at 55883) by debbugs.gnu.org; 14 Jun 2022 12:15:31 +0000 Received: from localhost ([127.0.0.1]:33314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o15SF-0000Px-FC for submit@debbugs.gnu.org; Tue, 14 Jun 2022 08:15:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o15S9-0000Ph-FF for 55883@debbugs.gnu.org; Tue, 14 Jun 2022 08:15:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34296) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o15S4-0007Ud-7h; Tue, 14 Jun 2022 08:15:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=A5+gVFaitLx5ntclcqPfd7f2uZgvOmZ6d7g93nd0h8M=; b=rMow5pfDCgn4 Dt9ROJoa04mI00iitpqS5HAOdMSQ2Wkqh+LoG6iPM+nM9imQZT/W5tGK2sdrj+zZ8feY/6DDVeZUv r44g5UHx8yLmpdNPsJ8nucTs7yQ/9YNtyMfRzFaX60k9AXuhS3Jo8Y8oDCFCuYCN6JRug0MT7xgCu a5xMZjHQRo7UgKuozAHlLSv0uT5dV9RS3cECr38N5zNWSCuAF60i7GSUXAmH4c1uZu7l7zSLYcRcZ wHTTydZm18zwh+1VBLhIhnHBt7jg79uU0v6FUs0FpezgznutELGv0n4edlZbJ8l+JqjJe5apQ2dPc u+H7Z+oGXCrbSGhyiuGzMw==; Received: from [87.69.77.57] (port=2332 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o15S0-0005Ha-Qm; Tue, 14 Jun 2022 08:15:20 -0400 Date: Tue, 14 Jun 2022 15:15:06 +0300 Message-Id: <837d5jtp9x.fsf@gnu.org> From: Eli Zaretskii To: Duncan Findlay In-Reply-To: (message from Duncan Findlay on Mon, 13 Jun 2022 23:36:13 -0700) Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions References: <834k0t104u.fsf@gnu.org> <8335gbzled.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55883 Cc: 55883@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Duncan Findlay > Date: Mon, 13 Jun 2022 23:36:13 -0700 > Cc: 55883@debbugs.gnu.org > > > > --- a/lisp/frame.el > > > +++ b/lisp/frame.el > > > @@ -2164,6 +2164,8 @@ display-selections-p > > > (not (null dos-windows-version)))) > > > ((memq frame-type '(x w32 ns pgtk)) > > > t) > > > + ((terminal-parameter display 'display-selections-p) > > > + t) > > > > This should test xterm--set-selection parameter. > > OK, so the goal is to check the xterm--set-selection terminal > parameter and variable xterm-select-active-regions before selecting > the active region in deactivate-mark in simple.el. > > We could do this in display-selections-p, but given that these > variables are not obviously related to display-selections-p, it seems > to me we probably want to do this check in deactivate-mark instead. > Does that seem reasonable to you? I think I'd prefer to have it in display-selections-p, like your last version did, just using xterm--set-selection terminal parameter, not the new one you invented. > > I think the code should instead check the value of > > xterm-select-active-regions in keyboard.c, where it decides whether to > > set PRIMARY. (Let me know if you need guidance for how to reference a > > Lisp variable from C.) > > This seems to work -- is there a better way? > > !NILP (SYMBOL_VAL (XSYMBOL (Qxterm_select_active_regions))) This is not safe, IMO. I think this is better: if ((!NILP (Fwindow_system (Qnil)) || ((symval = find_symbol_value (Qxterm_select_active_regions), (!EQ (symval, Qunbound) && !NILP (symval))) && !NILP (Fterminal_parameter (Qnil, Qxterm__set_selection)))) > I've also addressed Po's comments about long conditionals. Thanks, the patch LGTM, modulo the above 2 minor nits. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 22:40:40 2022 Received: (at 55883) by debbugs.gnu.org; 15 Jun 2022 02:40:40 +0000 Received: from localhost ([127.0.0.1]:36195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1IxT-0002QT-8X for submit@debbugs.gnu.org; Tue, 14 Jun 2022 22:40:40 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:41805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1IMk-0001S4-AC for 55883@debbugs.gnu.org; Tue, 14 Jun 2022 22:02:44 -0400 Received: by mail-wr1-f46.google.com with SMTP id k19so13395265wrd.8 for <55883@debbugs.gnu.org>; Tue, 14 Jun 2022 19:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AxDp4Ygckt31fAcHma1XrP5k2g2cghbLjpYyIPMzISw=; b=BxcTqVu05ehxkKrN5x/fk+lXlP1bH4noYuJM+mdEsmza8fCsS0mgUsWfx+MfTxSZnO BNYSXkkycgf3JOwwlYRTOZ1r1JWh0rjPsKWU3I3fr+FG7ZxPmPT4YBz51rxqGy2Cpf5K BfMQbMDT0p23yN2PaPR/2TAoU0qzL9EXTsETEBNjYvP6qywCQkOd7oZXBc9idNUpE4PC C8W93GHr5YrvpcoKW0Ula75iIaAESOiqudZltWVXRSYASmf0shmctlGxpZFnWO8kv0bs 4Hv2+3R0kA3zQZtDDwO720/pTDeO+hclLv9ZuskRBOL8vX2NwTxpoHlAmFjKnDMM4YBF lqYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AxDp4Ygckt31fAcHma1XrP5k2g2cghbLjpYyIPMzISw=; b=vzrWcuoHUL9SPZFgItbty3FoLLOEv8v5IIIavhntkYd1m7svk/kGlvYode7ff+oNrA JPpUTSreadzjUwmj/sqNXQ+JrXmKT56Xm3GD65o0xSPn/Uv9ehJL+dA4f90Qc8xI5QUC bRbbx6QTOMl77Pt9gKAFEWPj5WGqRQtVKM5/lC3SuoJr8jkavy1IZnIR0LL9F5evflHJ MPYlO+AnLqFWAN6r9CuYsPP0XWl8vMGjHdgYr0qBBK1K0sCbYLet/vFlayEgif5LiAxS oZgzh8TfD04KBUX0ypknOZ4yhRtaSvV0fVG6giy5be+oSDKZfHFFHY4AdR3T3npdn6kt DUkw== X-Gm-Message-State: AJIora9b5JLPjWc46BfDUXW9ZMgSQAsAlmx18IcJyHf2283biJ4q3DR+ KvqIwm+m2eLPMCYoH7Jp8jIljvEaRkWqV01NkegUWBBEj1g= X-Google-Smtp-Source: AGRyM1tkPIYcSUjF/htiaQ9RquaL+lgGXvbPH6DekuKbOoZkSvGmqjyAfcZ3Q4TViDS0DfjGg70WkhJ3+mibPbTGqwk= X-Received: by 2002:a5d:5581:0:b0:20f:fc51:7754 with SMTP id i1-20020a5d5581000000b0020ffc517754mr7382762wrv.413.1655258556020; Tue, 14 Jun 2022 19:02:36 -0700 (PDT) MIME-Version: 1.0 References: <834k0t104u.fsf@gnu.org> <8335gbzled.fsf@gnu.org> <837d5jtp9x.fsf@gnu.org> In-Reply-To: <837d5jtp9x.fsf@gnu.org> From: Duncan Findlay Date: Tue, 14 Jun 2022 19:01:58 -0700 Message-ID: Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions To: Eli Zaretskii Content-Type: multipart/mixed; boundary="0000000000003eedb305e172eac6" X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 55883 X-Mailman-Approved-At: Tue, 14 Jun 2022 22:40:38 -0400 Cc: 55883@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -9.0 (---------) --0000000000003eedb305e172eac6 Content-Type: text/plain; charset="UTF-8" On Tue, Jun 14, 2022 at 5:15 AM Eli Zaretskii wrote: > > > From: Duncan Findlay > > Date: Mon, 13 Jun 2022 23:36:13 -0700 > > Cc: 55883@debbugs.gnu.org > > > > > > --- a/lisp/frame.el > > > > +++ b/lisp/frame.el > > > > @@ -2164,6 +2164,8 @@ display-selections-p > > > > (not (null dos-windows-version)))) > > > > ((memq frame-type '(x w32 ns pgtk)) > > > > t) > > > > + ((terminal-parameter display 'display-selections-p) > > > > + t) > > > > > > This should test xterm--set-selection parameter. > > > > OK, so the goal is to check the xterm--set-selection terminal > > parameter and variable xterm-select-active-regions before selecting > > the active region in deactivate-mark in simple.el. > > > > We could do this in display-selections-p, but given that these > > variables are not obviously related to display-selections-p, it seems > > to me we probably want to do this check in deactivate-mark instead. > > Does that seem reasonable to you? > > I think I'd prefer to have it in display-selections-p, like your last > version did, just using xterm--set-selection terminal parameter, not > the new one you invented. Updated. > > > I think the code should instead check the value of > > > xterm-select-active-regions in keyboard.c, where it decides whether to > > > set PRIMARY. (Let me know if you need guidance for how to reference a > > > Lisp variable from C.) > > > > This seems to work -- is there a better way? > > > > !NILP (SYMBOL_VAL (XSYMBOL (Qxterm_select_active_regions))) > > This is not safe, IMO. I think this is better: > > if ((!NILP (Fwindow_system (Qnil)) > || ((symval = find_symbol_value (Qxterm_select_active_regions), > (!EQ (symval, Qunbound) && !NILP (symval))) > && !NILP (Fterminal_parameter (Qnil, Qxterm__set_selection)))) Thanks, I would never have figured that out myself. > > I've also addressed Po's comments about long conditionals. > > Thanks, the patch LGTM, modulo the above 2 minor nits. Duncan --0000000000003eedb305e172eac6 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Support-select-active-regions-with-xterm.patch" Content-Disposition: attachment; filename="0001-Support-select-active-regions-with-xterm.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l4ey4eju0 RnJvbSA5OTMzN2QxNWYzZTBhZWNkNTdkZDIzOGM5NjE2ZGY4M2QxYWU4MmE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEdW5jYW4gRmluZGxheSA8ZHVuY2ZAZ29vZ2xlLmNvbT4KRGF0 ZTogRnJpLCAxMCBKdW4gMjAyMiAxODo0Njo0OSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFN1cHBv cnQgYHNlbGVjdC1hY3RpdmUtcmVnaW9ucycgd2l0aCB4dGVybQoKVGhpcyBhbGxvd3MgRW1hY3Mg dG8gc2F2ZSB0aGUgYWN0aXZlIHJlZ2lvbiB0byB0aGUgdXNlcidzCnByaW1hcnkgc2VsZWN0aW9u IG9uIHN1cHBvcnRlZCB0ZXJtaW5hbHMuICBUaGUgYmVoYXZpb3IgZm9sbG93cwp0aGUgZXhpc3Rp bmcgYHNlbGVjdC1hY3RpdmUtcmVnaW9ucycgdmFyaWFibGUgYW5kIHJlcXVpcmVzCmB4dGVybS1z ZWxlY3QtYWN0aXZlLXJlZ2lvbnMnIHRvIGJlIG5vbi1uaWwuCgoqIHNyYy9rZXlib2FyZC5jIChj b21tYW5kX2xvb3BfMSk6CiogbGlzcC9mcmFtZS5lbCAoZGlzcGxheS1zZWxlY3Rpb25zLXApOiBP biB0ZXh0IHRlcm1pbmFscywgY2hlY2sKdGVybWluYWwgcGFyYW1ldGVyIGB4dGVybS0tc2V0LXNl bGVjdGlvbnMnIGFuZCB2YXJpYWJsZQpgeHRlcm0tc2VsZWN0LWFjdGl2ZS1yZWdpb25zJyB3aGVu IGRlY2lkaW5nIHdoZXRoZXIgdG8gdXBkYXRlCnByaW1hcnkgc2VsZWN0aW9uLiAoYnVnIzU1ODgz KQoqIGxpc3AvdGVybS94dGVybS5lbCAoeHRlcm0tc2VsZWN0LWFjdGl2ZS1yZWdpb25zKTogTmV3 CmRlZmN1c3RvbS4KLS0tCiBldGMvTkVXUyAgICAgICAgICAgfCAgNiArKysrKysKIGxpc3AvZnJh bWUuZWwgICAgICB8ICA2ICsrKysrKwogbGlzcC90ZXJtL3h0ZXJtLmVsIHwgIDggKysrKysrKysK IHNyYy9rZXlib2FyZC5jICAgICB8IDEwICsrKysrKysrKy0KIDQgZmlsZXMgY2hhbmdlZCwgMjkg aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRj L05FV1MKaW5kZXggMTljYTIxZjY2Ni4uZWE1MDFiN2M2OSAxMDA2NDQKLS0tIGEvZXRjL05FV1MK KysrIGIvZXRjL05FV1MKQEAgLTUwMiw2ICs1MDIsMTIgQEAgVGhpcyBpcyBpbiBhZGRpdGlvbiB0 byBwcmV2aW91c2x5LXN1cHBvcnRlZCB3YXlzIG9mIGRpc2NvdmVyaW5nIDI0LWJpdAogY29sb3Ig c3VwcG9ydDogZWl0aGVyIHZpYSB0aGUgIlJHQiIgb3IgInNldGYyNCIgY2FwYWJpbGl0aWVzLCBv ciBpZgogdGhlICdDT0xPUlRFUk0nIGVudmlyb25tZW50IHZhcmlhYmxlIGlzIHNldCB0byB0aGUg dmFsdWUgInRydWVjb2xvciIuCiAKKyoqKiBTZWxlY3QgYWN0aXZlIHJlZ2lvbnMgd2l0aCB4dGVy bSBzZWxlY3Rpb24gc3VwcG9ydC4KK09uIHRlcm1pbmFscyB3aXRoIHh0ZXJtIHNldFNlbGVjdGlv biBzdXBwb3J0LCB0aGUgYWN0aXZlIHJlZ2lvbiBtYXkgYmUKK3NhdmVkIHRvIHRoZSBYIHByaW1h cnkgc2VsZWN0aW9uLCBmb2xsb3dpbmcgdGhlCisnc2VsZWN0LWFjdGl2ZS1yZWdpb25zJyB2YXJp YWJsZS4gIFRoaXMgc3VwcG9ydCBpcyBlbmFibGVkIHdpdGgKKyd4dGVybS1zZWxlY3QtYWN0aXZl LXJlZ2lvbnMnLgorCiAqKiBFUlQKIAogKysrCmRpZmYgLS1naXQgYS9saXNwL2ZyYW1lLmVsIGIv bGlzcC9mcmFtZS5lbAppbmRleCAyN2Y5OWZiN2QyLi4zNTg2M2MwMTM1IDEwMDY0NAotLS0gYS9s aXNwL2ZyYW1lLmVsCisrKyBiL2xpc3AvZnJhbWUuZWwKQEAgLTIxNDksNiArMjE0OSw5IEBAICdk aXNwbGF5LWJsaW5rLWN1cnNvci1wCiAoZGVmYWxpYXMgJ2Rpc3BsYXktbXVsdGktZnJhbWUtcCAj J2Rpc3BsYXktZ3JhcGhpYy1wKQogKGRlZmFsaWFzICdkaXNwbGF5LW11bHRpLWZvbnQtcCAjJ2Rp c3BsYXktZ3JhcGhpYy1wKQogCis7OyBGcm9tIHRlcm0veHRlcm0uZWwKKyhkZWZ2YXIgeHRlcm0t c2VsZWN0LWFjdGl2ZS1yZWdpb25zKQorCiAoZGVmdW4gZGlzcGxheS1zZWxlY3Rpb25zLXAgKCZv cHRpb25hbCBkaXNwbGF5KQogICAiUmV0dXJuIG5vbi1uaWwgaWYgRElTUExBWSBzdXBwb3J0cyBz ZWxlY3Rpb25zLgogQSBzZWxlY3Rpb24gaXMgYSB3YXkgdG8gdHJhbnNmZXIgdGV4dCBvciBvdGhl ciBkYXRhIGJldHdlZW4gcHJvZ3JhbXMKQEAgLTIxNjQsNiArMjE2Nyw5IEBAIGRpc3BsYXktc2Vs ZWN0aW9ucy1wCiAgICAgICAgKG5vdCAobnVsbCBkb3Mtd2luZG93cy12ZXJzaW9uKSkpKQogICAg ICAoKG1lbXEgZnJhbWUtdHlwZSAnKHggdzMyIG5zIHBndGspKQogICAgICAgdCkKKyAgICAgKChh bmQgeHRlcm0tc2VsZWN0LWFjdGl2ZS1yZWdpb25zCisgICAgICAgICAgICh0ZXJtaW5hbC1wYXJh bWV0ZXIgbmlsICd4dGVybS0tc2V0LXNlbGVjdGlvbikpCisgICAgICB0KQogICAgICAodAogICAg ICAgbmlsKSkpKQogCmRpZmYgLS1naXQgYS9saXNwL3Rlcm0veHRlcm0uZWwgYi9saXNwL3Rlcm0v eHRlcm0uZWwKaW5kZXggYTdlMjU3ZjQxYy4uMDc5MTc4MGQ0MCAxMDA2NDQKLS0tIGEvbGlzcC90 ZXJtL3h0ZXJtLmVsCisrKyBiL2xpc3AvdGVybS94dGVybS5lbApAQCAtODAsNiArODAsMTQgQEAg eHRlcm0tc3RvcmUtcGFzdGUtb24ta2lsbC1yaW5nCiAgIDp2ZXJzaW9uICIyOC4xIgogICA6dHlw ZSAnYm9vbGVhbikKIAorKGRlZmN1c3RvbSB4dGVybS1zZWxlY3QtYWN0aXZlLXJlZ2lvbnMgbmls CisgICJJZiBub24tbmlsLCB1cGRhdGUgUFJJTUFSWSBYIHNlbGVjdGlvbiBvbiB0ZXh0LW1vZGUg ZnJhbWVzLgorT24gYSB0ZXh0LW1vZGUgdGVybWluYWwgdGhhdCBzdXBwb3J0cyBzZXRTZWxlY3Rp b24gY29tbWFuZCwgaWYKK3RoaXMgdmFyaWFibGUgaXMgbm9uLW5pbCwgRW1hY3Mgd2lsbCBzZXQg dGhlIFBSSU1BUlkgc2VsZWN0aW9uCitmcm9tIHRoZSBhY3RpdmUgcmVnaW9uLCBhY2NvcmRpbmcg dG8gYHNlbGVjdC1hY3RpdmUtcmVnaW9ucycuIgorICA6dmVyc2lvbiAiMjkuMSIKKyAgOnR5cGUg J2Jvb2xlYW4pCisKIChkZWZjb25zdCB4dGVybS1wYXN0ZS1lbmRpbmctc2VxdWVuY2UgIlxlWzIw MX4iCiAgICJDaGFyYWN0ZXJzIHNlbnQgYnkgdGhlIHRlcm1pbmFsIHRvIGVuZCBhIGJyYWNrZXRl ZCBwYXN0ZS4iKQogCmRpZmYgLS1naXQgYS9zcmMva2V5Ym9hcmQuYyBiL3NyYy9rZXlib2FyZC5j CmluZGV4IDU1ZDcxMGVkNjIuLjliMzRhNDc2NzUgMTAwNjQ0Ci0tLSBhL3NyYy9rZXlib2FyZC5j CisrKyBiL3NyYy9rZXlib2FyZC5jCkBAIC0xNTY3LDkgKzE1NjcsMTUgQEAgY29tbWFuZF9sb29w XzEgKHZvaWQpCiAJICAgIGNhbGwwIChRZGVhY3RpdmF0ZV9tYXJrKTsKIAkgIGVsc2UKIAkgICAg eworCSAgICAgIExpc3BfT2JqZWN0IHN5bXZhbDsKIAkgICAgICAvKiBFdmVuIGlmIG5vdCBkZWFj dGl2YXRpbmcgdGhlIG1hcmssIHNldCBQUklNQVJZIGlmCiAJCSBgc2VsZWN0LWFjdGl2ZS1yZWdp b25zJyBpcyBub24tbmlsLiAgKi8KLQkgICAgICBpZiAoIU5JTFAgKEZ3aW5kb3dfc3lzdGVtIChR bmlsKSkKKwkgICAgICBpZiAoKCFOSUxQIChGd2luZG93X3N5c3RlbSAoUW5pbCkpCisJCSAgIHx8 ICgoc3ltdmFsID0KKwkJCWZpbmRfc3ltYm9sX3ZhbHVlIChReHRlcm1fc2VsZWN0X2FjdGl2ZV9y ZWdpb25zKSwKKwkJCSghRVEgKHN5bXZhbCwgUXVuYm91bmQpICYmICFOSUxQIChzeW12YWwpKSkK KwkJICAgICAgICYmICFOSUxQIChGdGVybWluYWxfcGFyYW1ldGVyIChRbmlsLAorCQkJCQkJICAg ICAgUXh0ZXJtX19zZXRfc2VsZWN0aW9uKSkpKQogCQkgIC8qIEV2ZW4gaWYgbWFya19hY3RpdmUg aXMgbm9uLW5pbCwgdGhlIGFjdHVhbCBidWZmZXIKIAkJICAgICBtYXJrZXIgbWF5IG5vdCBoYXZl IGJlZW4gc2V0IHlldCAoQnVnIzcwNDQpLiAgKi8KIAkJICAmJiBYTUFSS0VSIChCVkFSIChjdXJy ZW50X2J1ZmZlciwgbWFyaykpLT5idWZmZXIKQEAgLTEyMTYzLDYgKzEyMTY5LDggQEAgc3ltc19v Zl9rZXlib2FyZCAodm9pZCkKICAgREVGU1lNIChRcG9sbGluZ19wZXJpb2QsICJwb2xsaW5nLXBl cmlvZCIpOwogCiAgIERFRlNZTSAoUWd1aV9zZXRfc2VsZWN0aW9uLCAiZ3VpLXNldC1zZWxlY3Rp b24iKTsKKyAgREVGU1lNIChReHRlcm1fX3NldF9zZWxlY3Rpb24sICJ4dGVybS0tc2V0LXNlbGVj dGlvbiIpOworICBERUZTWU0gKFF4dGVybV9zZWxlY3RfYWN0aXZlX3JlZ2lvbnMsICJ4dGVybS1z ZWxlY3QtYWN0aXZlLXJlZ2lvbnMiKTsKIAogICAvKiBUaGUgcHJpbWFyeSBzZWxlY3Rpb24uICAq LwogICBERUZTWU0gKFFQUklNQVJZLCAiUFJJTUFSWSIpOwotLSAKMi4zNi4xLjQ3Ni5nMGM0ZGFh MjA2ZC1nb29nCgo= --0000000000003eedb305e172eac6-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 12:52:01 2022 Received: (at 55883) by debbugs.gnu.org; 15 Jun 2022 16:52:01 +0000 Received: from localhost ([127.0.0.1]:39716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1WFL-00019X-5K for submit@debbugs.gnu.org; Wed, 15 Jun 2022 12:52:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1WFG-000192-4y for 55883@debbugs.gnu.org; Wed, 15 Jun 2022 12:51:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39198) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1WEy-0002Lu-T0; Wed, 15 Jun 2022 12:51:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=J5rbngz4Y2vCNIVgUvGhOuRSTBorvtREF56BnRbLc3k=; b=PVvLJzC7BuS2 i8e7AU9uueSulBvWFd5rYr9ObEHQ/v6ZvLmpkOmr9OgcOlaymuMBULsP0ufy+/p113j1bwQ3aQPBC cW72LA6yK4BmosfAL4eZYxOQ070cLWQ/tCPV/HeSU1n7EhQSGHMKUAfkmc/Yy58ODlaQHVQqS647G +lEhBWR9rWsNkJSn4dknH+5NanqpyiVMAA1rP6BAUwhtluaM5ESyJFRyPtbnwAYCOEWsYeTKZqO9C o4Nh5QdjPAbdHD3lI4SoH7Z9ba8/dxvsxg2Rokz1ikqxGUKmUZpmXhpwaGbAB0qpoyG8pxL51R+zK rtgG5dCeIDskFpOycJwagg==; Received: from [87.69.77.57] (port=4201 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1WEf-0001vH-U4; Wed, 15 Jun 2022 12:51:21 -0400 Date: Wed, 15 Jun 2022 19:51:10 +0300 Message-Id: <83v8t1rhtt.fsf@gnu.org> From: Eli Zaretskii To: Duncan Findlay In-Reply-To: (message from Duncan Findlay on Tue, 14 Jun 2022 19:01:58 -0700) Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions References: <834k0t104u.fsf@gnu.org> <8335gbzled.fsf@gnu.org> <837d5jtp9x.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55883 Cc: 55883@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Duncan Findlay > Date: Tue, 14 Jun 2022 19:01:58 -0700 > Cc: 55883@debbugs.gnu.org > > > > !NILP (SYMBOL_VAL (XSYMBOL (Qxterm_select_active_regions))) > > > > This is not safe, IMO. I think this is better: > > > > if ((!NILP (Fwindow_system (Qnil)) > > || ((symval = find_symbol_value (Qxterm_select_active_regions), > > (!EQ (symval, Qunbound) && !NILP (symval))) > > && !NILP (Fterminal_parameter (Qnil, Qxterm__set_selection)))) > > Thanks, I would never have figured that out myself. That's what we are here for (one reason, at least). > > > I've also addressed Po's comments about long conditionals. > > > > Thanks, the patch LGTM, modulo the above 2 minor nits. This version LGTM, I will install soon, unless someone comes up with more comments. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 07:14:09 2022 Received: (at 55883-done) by debbugs.gnu.org; 18 Jun 2022 11:14:09 +0000 Received: from localhost ([127.0.0.1]:47660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2WP3-0007Jt-Ll for submit@debbugs.gnu.org; Sat, 18 Jun 2022 07:14:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2WP0-0007JJ-Te for 55883-done@debbugs.gnu.org; Sat, 18 Jun 2022 07:14:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33402) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2WOv-0003DW-Mw; Sat, 18 Jun 2022 07:14:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QviglpzayK7Hd7KTTT7VatnTktxAq1e3/LyzcQVEnT0=; b=W9RXchzlzDxO vuD0nAkatE3yQZ31pZgvinMn0brQJgffJVTmL7VYx1T4pQTfx2E44YFN/20c/qTO3z9B17IQNwZmZ yDaFXUlpcWpjn5sgmeH0dsuVB3YV8VeLgB1saCAFUJf9ZhYYyiDbs95ZkgIyKiJDstj/ieqo85sHV onML97IcWOHl20jD1aTGWqUocYOrndak9GVXJCegh/eRT+P0lc2I8+1HgEKzkuuVQeZAYnbEhGhi5 lxnUcX50yFfJNBG9TjO3jg02S/KHpmj0tScVIqtZRe89CC7f+Y63Q8NGeGYVbHd59eM7HRnSzd5Mo Y4r0tdrwNpOnsPER/Xfp5Q==; Received: from [87.69.77.57] (port=2201 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2WOv-0004Ji-6W; Sat, 18 Jun 2022 07:14:01 -0400 Date: Sat, 18 Jun 2022 14:13:53 +0300 Message-Id: <83czf6ns0e.fsf@gnu.org> From: Eli Zaretskii To: duncf@google.com In-Reply-To: <83v8t1rhtt.fsf@gnu.org> (message from Eli Zaretskii on Wed, 15 Jun 2022 19:51:10 +0300) Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions References: <834k0t104u.fsf@gnu.org> <8335gbzled.fsf@gnu.org> <837d5jtp9x.fsf@gnu.org> <83v8t1rhtt.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55883-done Cc: 55883-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 55883@debbugs.gnu.org > Date: Wed, 15 Jun 2022 19:51:10 +0300 > From: Eli Zaretskii > > > From: Duncan Findlay > > Date: Tue, 14 Jun 2022 19:01:58 -0700 > > Cc: 55883@debbugs.gnu.org > > > > > > I've also addressed Po's comments about long conditionals. > > > > > > Thanks, the patch LGTM, modulo the above 2 minor nits. > > This version LGTM, I will install soon, unless someone comes up with > more comments. No further comments, so I installed this on the master branch now. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 11:15:41 2022 Received: (at 55883) by debbugs.gnu.org; 18 Jun 2022 15:15:41 +0000 Received: from localhost ([127.0.0.1]:49849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2aAm-0003Ok-5s for submit@debbugs.gnu.org; Sat, 18 Jun 2022 11:15:41 -0400 Received: from mail-ed1-f52.google.com ([209.85.208.52]:35487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2aAj-0003OV-I1 for 55883@debbugs.gnu.org; Sat, 18 Jun 2022 11:15:38 -0400 Received: by mail-ed1-f52.google.com with SMTP id x5so9683975edi.2 for <55883@debbugs.gnu.org>; Sat, 18 Jun 2022 08:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=o/OCz0zjZTSpqo35iqNpFW8V/q+piezcGj5LRrcFdwA=; b=GIT2rwiEEqKvNSa6cm4CZOFoboAM+SVQrxbpeTe8mME02O+ZSLb9InOCrfnJS4NSJn nO8EpRyyXArxUhbUvGdZL6pWd9+2Njy3MfC6MYLSccTPeDwt81/wZM9lZzpzurHyNRym z08oTOYCbGzh7b3yOrlrOSCv9tB4810xj5VHiF8BtOXobiQeYx4AentB28DOt9Br8vy7 x3xdG7iqZWGA3ooNogX1GmzRkxjXBZ25h4wYYu3j3aqrBfLnwqnAAu/vnDhWoSRpgGmJ wIAp7Sa1g4EzeVeUQfuwZZG2jQVXUbHYtwuS9rhj9jceLr4kppgi83VIi/vdBNFMlDDX S8Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=o/OCz0zjZTSpqo35iqNpFW8V/q+piezcGj5LRrcFdwA=; b=TDPvXwSDE9xq7paOWgSxkyktXRd7iJ9ANR6EE0HKWet6C8USurGov9y51OCmFWO9Uy wuhWzcAPx1pniRsNAXbDLctDHqj5W8Xu7ZaKrp7LnOFQhimMx6phv0f3uSA4vyg02rbz WcojprzeK9O7R5cNABr1b1X/kicYiGfdsJBspQ2C14QPSwMBWaVxWYxv4yO2fX2O1E4g lLPzHwuj/Aj10wlGB3Hr0SEqw8BUW/0cHCS15/Vxi/PfsrEJl9Z3lwTmnpzYTogP4zbq 6knYwh/MWgNs9HCT6/7g2FMaesx6jXaQK6GLRsu3Ne7Gww2v2LQCc8W9w7tiOw/NpIbA KfJw== X-Gm-Message-State: AJIora+LMaIhCDt9L7/ZfhLhNYjaUZQTBWMhYGbJ7Y7i1UbETgjT+Sen 16xs/iFp0/stzRlpve/H/db2aax5WFwQ/A== X-Google-Smtp-Source: AGRyM1sB661lzEMwzQEx+wYVyrYE2cCFyxYvLdZU3TUS3eAJSGe98PWHjt8KNrRvFZYq5fqMKCSISg== X-Received: by 2002:a05:6402:1e8b:b0:41c:59f6:2c26 with SMTP id f11-20020a0564021e8b00b0041c59f62c26mr19037493edf.156.1655565331238; Sat, 18 Jun 2022 08:15:31 -0700 (PDT) Received: from localhost ([2a02:587:322b:6f5e:dc92:136a:a7c4:dc8c]) by smtp.gmail.com with ESMTPSA id l2-20020a1709063d2200b0070759e37183sm3535441ejf.59.2022.06.18.08.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jun 2022 08:15:30 -0700 (PDT) From: "Basil L. Contovounesios" To: 55883@debbugs.gnu.org Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions References: <834k0t104u.fsf@gnu.org> <8335gbzled.fsf@gnu.org> <837d5jtp9x.fsf@gnu.org> <83v8t1rhtt.fsf@gnu.org> <83czf6ns0e.fsf@gnu.org> Date: Sat, 18 Jun 2022 18:15:28 +0300 In-Reply-To: <83czf6ns0e.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Jun 2022 14:13:53 +0300") Message-ID: <878rpuknov.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55883 Cc: eliz@gnu.org, duncf@google.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii [2022-06-18 14:13 +0300] wrote: >> Cc: 55883@debbugs.gnu.org >> Date: Wed, 15 Jun 2022 19:51:10 +0300 >> From: Eli Zaretskii >> >> > From: Duncan Findlay >> > Date: Tue, 14 Jun 2022 19:01:58 -0700 >> > Cc: 55883@debbugs.gnu.org >> > >> > > > I've also addressed Po's comments about long conditionals. >> > > >> > > Thanks, the patch LGTM, modulo the above 2 minor nits. >> >> This version LGTM, I will install soon, unless someone comes up with >> more comments. > > No further comments, so I installed this on the master branch now. Thanks, but please see the resulting 'make check' errors attached. Perhaps dereferencing xterm-select-active-regions should be guarded by bound-and-true-p or the like? -- Basil --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=errors.log -*- mode: compilation; default-directory: "~/.local/src/emacs/" -*- Compilation started at Sat Jun 18 18:07:38 make -k EMACS_TEST_VERBOSE=1 test/simple-tests test/lisp-tests make -C test simple-tests make[1]: Entering directory '/home/blc/.local/src/emacs/test' make[2]: Entering directory '/home/blc/.local/src/emacs/test' GEN lisp/simple-tests.log Running 46 tests (2022-06-18 18:07:39+0300, selector `(not (or (tag :unstable) (tag :nativecomp)))') Fill column set to 5 (was 70) passed 1/46 auto-fill-mode-no-break-before-length-of-fill-prefix (0.000131 sec) passed 2/46 command-execute-prune-command-history (0.000085 sec) passed 3/46 eval-expression-print-format-large-int (0.000089 sec) skipped 4/46 eval-expression-print-format-large-int-echo (0.000096 sec) passed 5/46 eval-expression-print-format-small-int (0.000066 sec) skipped 6/46 eval-expression-print-format-small-int-echo (0.000091 sec) passed 7/46 eval-expression-print-format-sym (0.000050 sec) skipped 8/46 eval-expression-print-format-sym-echo (0.000092 sec) passed 9/46 line-number-at-pos-in-narrow-buffer (0.000053 sec) passed 10/46 line-number-at-pos-in-widen-buffer (0.000048 sec) passed 11/46 line-number-at-pos-keeps-point (0.000044 sec) passed 12/46 line-number-at-pos-keeps-restriction (0.000051 sec) passed 13/46 line-number-at-pos-when-passing-point (0.000057 sec) Undo passed 14/46 missing-record-point-in-undo (0.000246 sec) passed 15/46 newline (0.000489 sec) passed 16/46 newline-indent (0.000839 sec) passed 17/46 open-line (0.000472 sec) passed 18/46 open-line-hook (0.000379 sec) passed 19/46 open-line-indent (0.000574 sec) passed 20/46 open-line-margin-and-prefix (0.000393 sec) passed 21/46 simple-delete-indentation-blank-line (0.000121 sec) passed 22/46 simple-delete-indentation-boundaries (0.000076 sec) passed 23/46 simple-delete-indentation-inactive-region (0.000066 sec) passed 24/46 simple-delete-indentation-no-region (0.000091 sec) passed 25/46 simple-delete-indentation-prefix (0.000079 sec) passed 26/46 simple-delete-indentation-region (0.000121 sec) passed 27/46 simple-delete-trailing-whitespace--bug-21766 (0.022844 sec) passed 28/46 simple-delete-trailing-whitespace--formfeeds (0.000078 sec) passed 29/46 simple-test-count-lines (0.000067 sec) passed 30/46 simple-test-count-lines/ignore-invisible-lines (0.000067 sec) passed 31/46 simple-test-count-words-bug-41761 (0.000081 sec) Undo passed 32/46 simple-test-undo-extra-boundary-in-tex (0.039261 sec) Undo Undo Redo Redo Redo Redo Redo Redo Redo Redo Undo Undo Undo Undo Redo Redo Redo Redo passed 33/46 simple-tests--undo (0.000296 sec) Undo Redo Mark set Undo in region Test simple-tests--undo-equiv-table backtrace: display-selections-p() deactivate-mark(force) (let ((ul-hash-table (make-hash-table :test #'equal))) (let ((--doli (progn (buffer-enable-undo) (transient-mark-mode) (let ((ul-hash-tab (unwind-protect (progn (buffer-enable-undo) (transient-mark-mode) (l (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current (closure (t) nil (let ((temp-buffer (generate-new-buffer " *temp*" t ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name simple-tests--undo-equiv-table :docum ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/simple-tests.el" "-- command-line() normal-top-level() Test simple-tests--undo-equiv-table condition: (void-variable xterm-select-active-regions) FAILED 34/46 simple-tests--undo-equiv-table (0.000231 sec) at lisp/simple-tests.el:511 Mark set Undo in region Mark activated Undo in region Redo in region Redo in region passed 35/46 simple-tests--undo-in-region (0.000447 sec) passed 36/46 simple-tests-async-shell-command-30280 (0.029269 sec) passed 37/46 simple-tests-shell-command-39067 (2.665546 sec) passed 38/46 simple-tests-shell-command-dont-erase-buffer (1.280669 sec) passed 39/46 simple-tests-zap-to-char (0.000376 sec) passed 40/46 simple-text-count-lines-non-ascii (0.000156 sec) passed 41/46 simple-transpose-subr (0.000744 sec) passed 42/46 test-undo-region (0.000201 sec) Setting up indent for shell type bash Indentation variables are now local. Indentation setup for shell type bash Mark set Setting up indent for shell type bash Indentation variables are now local. Indentation setup for shell type bash Mark set Setting up indent for shell type bash Indentation variables are now local. Indentation setup for shell type bash Mark set passed 43/46 test-yank-in-context (0.021730 sec) passed 44/46 undo-auto--boundaries-added (0.000075 sec) passed 45/46 undo-auto-boundary-timer (0.000038 sec) Undo Undo passed 46/46 undo-point-in-wrong-place (0.000379 sec) Ran 46 tests, 42 results as expected, 1 unexpected, 3 skipped (2022-06-18 18:07:43+0300, 4.450341 sec) 1 unexpected results: FAILED simple-tests--undo-equiv-table xterm-select-active-regions 3 skipped results: SKIPPED eval-expression-print-format-large-int-echo ((skip-unless (not noninteractive)) :form (not t) :value nil) SKIPPED eval-expression-print-format-small-int-echo ((skip-unless (not noninteractive)) :form (not t) :value nil) SKIPPED eval-expression-print-format-sym-echo ((skip-unless (not noninteractive)) :form (not t) :value nil) nilmake[2]: *** [Makefile:174: lisp/simple-tests.log] Error 1 make[2]: Leaving directory '/home/blc/.local/src/emacs/test' make[1]: *** [Makefile:240: lisp/simple-tests] Error 2 make[1]: Target 'simple-tests' not remade because of errors. make[1]: Leaving directory '/home/blc/.local/src/emacs/test' make: *** [Makefile:1022: test/simple-tests] Error 2 make -C test lisp-tests make[1]: Entering directory '/home/blc/.local/src/emacs/test' make[2]: Entering directory '/home/blc/.local/src/emacs/test' GEN lisp/emacs-lisp/lisp-tests.log Running 37 tests (2022-06-18 18:07:44+0300, selector `(not (or (tag :unstable) (tag :nativecomp)))') passed 1/37 backward-up-list-basic (0.000117 sec) passed 2/37 core-elisp-tests-1-defvar-in-let (0.000057 sec) Mark set passed 3/37 core-elisp-tests-2-window-configurations (0.000064 sec) passed 4/37 core-elisp-tests-3-backquote (0.000042 sec) passed 5/37 end-of-defun-twice (0.000238 sec) passed 6/37 lisp-backward-sexp-1-empty-parens (0.000048 sec) passed 7/37 lisp-backward-sexp-1-eobp (0.000047 sec) passed 8/37 lisp-backward-sexp-1-error-mismatch (0.000047 sec) passed 9/37 lisp-backward-sexp-2-bobp (0.000049 sec) passed 10/37 lisp-backward-sexp-2-bobp-and-subsequent (0.000054 sec) passed 11/37 lisp-delete-pair-parens (1.001608 sec) passed 12/37 lisp-delete-pair-quotation-marks (1.001738 sec) passed 13/37 lisp-delete-pair-quotes-in-text-mode (0.000242 sec) passed 14/37 lisp-delete-pair-quotes-text-mode-syntax-table (1.001739 sec) passed 15/37 lisp-fill-paragraph-colon (0.001325 sec) passed 16/37 lisp-forward-sexp-1-empty-parens (0.000162 sec) passed 17/37 lisp-forward-sexp-1-eobp (0.000145 sec) passed 18/37 lisp-forward-sexp-1-error-mismatch (0.000159 sec) passed 19/37 lisp-forward-sexp-2-eobp (0.000158 sec) passed 20/37 lisp-forward-sexp-2-eobp-and-subsequent (0.000165 sec) passed 21/37 lisp-forward-sexp-elisp-inside-symbol (0.000409 sec) passed 22/37 lisp-forward-sexp-elisp-quoted-symbol (0.000376 sec) passed 23/37 lisp-forward-sexp-emacs-lisp-quote-char (0.000369 sec) passed 24/37 lisp-forward-sexp-emacs-lisp-semi-char-error (0.000339 sec) passed 25/37 lisp-forward-sexp-python-triple-quoted-string (0.001036 sec) passed 26/37 lisp-forward-sexp-python-triple-quotes-string (0.000929 sec) passed 27/37 mark-defun-arg-region-active (0.000594 sec) Mark set Mark set Mark set Mark set Mark set Mark set Mark set Mark set passed 28/37 mark-defun-bob (0.001626 sec) Mark set Mark set Test mark-defun-neg-arg-region-inactive backtrace: display-selections-p() deactivate-mark() (let ((after-4 216) (inside-4 207) (before-4 174) (after-3 174) (ins (progn (emacs-lisp-mode) (insert ";; Comment header\n\n(defun func-1 (unwind-protect (progn (emacs-lisp-mode) (insert ";; Comment header\ (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current (closure (c-e-x t) nil (setq last-command nil) (let ((temp-buffer (g ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name mark-defun-neg-arg-region-inactive :d ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/lisp-test command-line() normal-top-level() Test mark-defun-neg-arg-region-inactive condition: (void-variable xterm-select-active-regions) FAILED 29/37 mark-defun-neg-arg-region-inactive (0.000682 sec) at lisp/emacs-lisp/lisp-tests.el:546 Test mark-defun-no-arg-region-active backtrace: display-selections-p() deactivate-mark() (let ((after-4 216) (inside-4 207) (before-4 174) (after-3 174) (ins (progn (emacs-lisp-mode) (insert ";; Comment header\n\n(defun func-1 (unwind-protect (progn (emacs-lisp-mode) (insert ";; Comment header\ (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current (closure (c-e-x t) nil (transient-mark-mode 1) (setq last-command ni ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name mark-defun-no-arg-region-active :docu ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/lisp-test command-line() normal-top-level() Test mark-defun-no-arg-region-active condition: (void-variable xterm-select-active-regions) FAILED 30/37 mark-defun-no-arg-region-active (0.000302 sec) at lisp/emacs-lisp/lisp-tests.el:476 Mark set Mark set Test mark-defun-no-arg-region-inactive backtrace: display-selections-p() deactivate-mark() (let ((after-4 216) (inside-4 207) (before-4 174) (after-3 174) (ins (progn (emacs-lisp-mode) (insert ";; Comment header\n\n(defun func-1 (unwind-protect (progn (emacs-lisp-mode) (insert ";; Comment header\ (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current (closure (c-e-x t) nil (setq last-command nil) (let ((temp-buffer (g ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name mark-defun-no-arg-region-inactive :do ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/lisp-test command-line() normal-top-level() Test mark-defun-no-arg-region-inactive condition: (void-variable xterm-select-active-regions) FAILED 31/37 mark-defun-no-arg-region-inactive (0.000294 sec) at lisp/emacs-lisp/lisp-tests.el:427 Mark set Mark set Test mark-defun-pos-arg-region-inactive backtrace: display-selections-p() deactivate-mark() (let ((after-4 216) (inside-4 207) (before-4 174) (after-3 174) (ins (progn (emacs-lisp-mode) (insert ";; Comment header\n\n(defun func-1 (unwind-protect (progn (emacs-lisp-mode) (insert ";; Comment header\ (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current (closure (c-e-x t) nil (setq last-command nil) (let ((temp-buffer (g ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name mark-defun-pos-arg-region-inactive :d ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/lisp-test command-line() normal-top-level() Test mark-defun-pos-arg-region-inactive condition: (void-variable xterm-select-active-regions) FAILED 32/37 mark-defun-pos-arg-region-inactive (0.000331 sec) at lisp/emacs-lisp/lisp-tests.el:522 passed 33/37 up-list-basic (0.000104 sec) passed 34/37 up-list-cross-string (0.000087 sec) passed 35/37 up-list-no-cross-string (0.000083 sec) passed 36/37 up-list-out-of-string (0.000078 sec) passed 37/37 up-list-with-forward-sexp-function (0.000077 sec) Ran 37 tests, 33 results as expected, 4 unexpected (2022-06-18 18:07:48+0300, 4.020046 sec) 4 unexpected results: FAILED mark-defun-neg-arg-region-inactive xterm-select-active-regions FAILED mark-defun-no-arg-region-active xterm-select-active-regions FAILED mark-defun-no-arg-region-inactive xterm-select-active-regions FAILED mark-defun-pos-arg-region-inactive xterm-select-active-regions make[2]: *** [Makefile:174: lisp/emacs-lisp/lisp-tests.log] Error 1 make[2]: Leaving directory '/home/blc/.local/src/emacs/test' make[1]: *** [Makefile:240: lisp/emacs-lisp/lisp-tests] Error 2 make[1]: Target 'lisp-tests' not remade because of errors. make[1]: Leaving directory '/home/blc/.local/src/emacs/test' make: *** [Makefile:1022: test/lisp-tests] Error 2 Compilation exited abnormally with code 2 at Sat Jun 18 18:07:48 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 12:10:17 2022 Received: (at 55883) by debbugs.gnu.org; 18 Jun 2022 16:10:17 +0000 Received: from localhost ([127.0.0.1]:49903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2b1d-0004nc-HQ for submit@debbugs.gnu.org; Sat, 18 Jun 2022 12:10:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2b1a-0004nG-Ka for 55883@debbugs.gnu.org; Sat, 18 Jun 2022 12:10:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38890) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2b1U-00084P-Np; Sat, 18 Jun 2022 12:10:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BsC6MMI8fwCN3YQ87vLxnzUm3P55jeKZyEirNM2Keuo=; b=C6+3sTkVDXWs uC1AXGV/sSxaRf0OdpP81CqbIMCkoYXl6/peIlQn56/Nhh9rFXsDGg0rwwswSoJ9kQrTtPo7fXZ++ jliv25QEc9kfrP7Mm6L/xqTWQaVrNom2mS/te3kRL6/H59A1XmKgAOTa0pnwXY7T13ZJLKroYFHCg qpZ3LMcvvtKKlwffAL3xA+x98UmPQAn7kUg/UAGuRtVeTDrScZ7ziFZyK2zGg+C3IHRngTKxAWMNN X2Sq4wSc4LbUDlxXs4DWXYdrsZEWYt5B9EmiDofDWCNBVQ3teGzKp7CcvAr3ImndKSDn0t1NDRUf0 +friFjeWz4P6rcNpKwkCRA==; Received: from [87.69.77.57] (port=4359 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2b1U-0004uR-5u; Sat, 18 Jun 2022 12:10:08 -0400 Date: Sat, 18 Jun 2022 19:09:54 +0300 Message-Id: <838rpuneb1.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-Reply-To: <878rpuknov.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions References: <834k0t104u.fsf@gnu.org> <8335gbzled.fsf@gnu.org> <837d5jtp9x.fsf@gnu.org> <83v8t1rhtt.fsf@gnu.org> <83czf6ns0e.fsf@gnu.org> <878rpuknov.fsf@tcd.ie> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55883 Cc: 55883@debbugs.gnu.org, duncf@google.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "Basil L. Contovounesios" > Cc: eliz@gnu.org, duncf@google.com > Date: Sat, 18 Jun 2022 18:15:28 +0300 > > > No further comments, so I installed this on the master branch now. > > Thanks, but please see the resulting 'make check' errors attached. > > Perhaps dereferencing xterm-select-active-regions should be guarded by > bound-and-true-p or the like? No, that's ugly. I fixed it in a different way, thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 21:59:03 2022 Received: (at 55883) by debbugs.gnu.org; 22 Jun 2022 01:59:03 +0000 Received: from localhost ([127.0.0.1]:33608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3pe3-0004pD-CV for submit@debbugs.gnu.org; Tue, 21 Jun 2022 21:59:03 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:41889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3pe0-0004og-5Z for 55883@debbugs.gnu.org; Tue, 21 Jun 2022 21:59:01 -0400 Received: by mail-wr1-f50.google.com with SMTP id q9so21298139wrd.8 for <55883@debbugs.gnu.org>; Tue, 21 Jun 2022 18:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u7/jflI1TYM8Ou+17mVZBjDMc25wfmw9I47AC2cwgh0=; b=UGGyhH7wOolv6/sXvb3oDJy1gigxEOzOKUMbSsfIhg4iCe/x8AU8r8qQqfIdcmGWX6 dfZiC1kAaWbGaiB9E0+ehA7q15/w2auOHcycOAfOIeSJRZoE1Yk5OpQAYb22atQBhi8P vfOq/dOuLq2j5HaI4OrxJ23+7zFGrhnpcd+OpfHOH9GbHbVX1VAi3tPJLa2+eYHhTQ/D sJUOKUpNZiW7V07jGN2+JqvHb5y2i7pUquSiujAaiKp8XTWWAdVuxSI1qqV6gDl6z6IG 0cUp1AFEjcKHx+z691G+DXOQSJnVTPtsNOP0XN/e7sUjoI2MV5HGCCWnpogiKYHxrFu8 XqyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u7/jflI1TYM8Ou+17mVZBjDMc25wfmw9I47AC2cwgh0=; b=PBs6cXuh/WxoDZSoD7WLs7XbdEJswmxQbgVAylW5/Xqvky7fG/h8UBfebq9ezHfyKA /bKB1scXJxGSnmPNHDtrM7WotbnDvAlkWZnNWEJir5Yf+s6mbZb2xh3rFNvN9SteKgB1 97UbxFM1BsqZrmFabekIEUnueqBTs5O/FxCP7BrFUGP5VSzVPRlAsZ1i4CNxgMBAnjTj RbjO8QQIaqybD6gu4VZy9KN5aoAp9Yv7tluEoUhWWQ5MepVdrHEEwzkOqpq64Zfw8DqY AR7q1hDZkmSQutpkpoSIxn5g+DklztWvklp3MmsrzRO7I+XcfJggYt0zxs3RKVQSFngf Y+ag== X-Gm-Message-State: AJIora/8WQOMmihqsXw6kCw1HBoai1nGdHmhHwMAXslIWH2Zm8pIVn0m cxT8pzpFkoQbCgnTSQAva8nG4z1sb8LD+ugF6vI3Ug== X-Google-Smtp-Source: AGRyM1v8kh5F3+Szcgbhy9Jhl9BSFuvKWFsPHI9Z6fXt6ioFYIyvy2CtgvJViYVhAtawnmUWkdmTFRHneuSOjAl2gJw= X-Received: by 2002:a5d:5581:0:b0:20f:fc51:7754 with SMTP id i1-20020a5d5581000000b0020ffc517754mr746937wrv.413.1655863133779; Tue, 21 Jun 2022 18:58:53 -0700 (PDT) MIME-Version: 1.0 References: <834k0t104u.fsf@gnu.org> <8335gbzled.fsf@gnu.org> <837d5jtp9x.fsf@gnu.org> <83v8t1rhtt.fsf@gnu.org> <83czf6ns0e.fsf@gnu.org> <878rpuknov.fsf@tcd.ie> <838rpuneb1.fsf@gnu.org> In-Reply-To: <838rpuneb1.fsf@gnu.org> From: Duncan Findlay Date: Tue, 21 Jun 2022 18:58:16 -0700 Message-ID: Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000e3472a05e1ffad96" X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 55883 Cc: "Basil L. Contovounesios" , 55883@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -9.0 (---------) --000000000000e3472a05e1ffad96 Content-Type: text/plain; charset="UTF-8" Oops. I'm sorry I missed that, and thank you for the quick fixes! It looks like you renamed the variable, and put it in frame.el with 7e1f84fa3bc7dfd84415813889c91070c0759da2 and 4e68166d77cdd0f3b84c9bf5681f6a95e51ad238. I assume that means that frame.el is always loaded in tests, and that xterm.el is sometimes not loaded? I don't have a problem with the current fix, though I'm wondering if the attached patch would have worked too? Thanks Duncan On Sat, Jun 18, 2022 at 9:10 AM Eli Zaretskii wrote: > > > From: "Basil L. Contovounesios" > > Cc: eliz@gnu.org, duncf@google.com > > Date: Sat, 18 Jun 2022 18:15:28 +0300 > > > > > No further comments, so I installed this on the master branch now. > > > > Thanks, but please see the resulting 'make check' errors attached. > > > > Perhaps dereferencing xterm-select-active-regions should be guarded by > > bound-and-true-p or the like? > > No, that's ugly. I fixed it in a different way, thanks. --000000000000e3472a05e1ffad96 Content-Type: application/x-patch; name="0001-Set-default-value-for-xterm-select-active-regions.patch" Content-Disposition: attachment; filename="0001-Set-default-value-for-xterm-select-active-regions.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l4oy24580 RnJvbSA3YmQyY2QxYWI3MWIyMmE1ZGRlMTI5MTQ1ZTg0MTQyYzRkMjhjNDFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEdW5jYW4gRmluZGxheSA8ZHVuY2ZAZ29vZ2xlLmNvbT4KRGF0 ZTogVHVlLCAyMSBKdW4gMjAyMiAxODozMzoyOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFNldCBk ZWZhdWx0IHZhbHVlIGZvciB4dGVybS1zZWxlY3QtYWN0aXZlLXJlZ2lvbnMKCiogbGlzcC9mcmFt ZS5lbCAoeHRlcm0tc2VsZWN0LWFjdGl2ZS1yZWdpb25zKTogU2V0IGRlZmF1bHQgdmFsdWUKb2Yg bmlsIGlmIG5vdCBkZWZpbmVkLiAoYnVnIzU1ODgzKQotLS0KIGxpc3AvZnJhbWUuZWwgfCAyICst CiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1n aXQgYS9saXNwL2ZyYW1lLmVsIGIvbGlzcC9mcmFtZS5lbAppbmRleCAzNTg2M2MwMTM1Li40MjNi MWM0N2EyIDEwMDY0NAotLS0gYS9saXNwL2ZyYW1lLmVsCisrKyBiL2xpc3AvZnJhbWUuZWwKQEAg LTIxNTAsNyArMjE1MCw3IEBAICdkaXNwbGF5LW11bHRpLWZyYW1lLXAKIChkZWZhbGlhcyAnZGlz cGxheS1tdWx0aS1mb250LXAgIydkaXNwbGF5LWdyYXBoaWMtcCkKIAogOzsgRnJvbSB0ZXJtL3h0 ZXJtLmVsCi0oZGVmdmFyIHh0ZXJtLXNlbGVjdC1hY3RpdmUtcmVnaW9ucykKKyhkZWZ2YXIgeHRl cm0tc2VsZWN0LWFjdGl2ZS1yZWdpb25zIG5pbCkKIAogKGRlZnVuIGRpc3BsYXktc2VsZWN0aW9u cy1wICgmb3B0aW9uYWwgZGlzcGxheSkKICAgIlJldHVybiBub24tbmlsIGlmIERJU1BMQVkgc3Vw cG9ydHMgc2VsZWN0aW9ucy4KLS0gCjIuMzcuMC5yYzAuMTA0LmcwNjExNjExYTk0LWdvb2cKCg== --000000000000e3472a05e1ffad96-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 22 09:02:52 2022 Received: (at 55883) by debbugs.gnu.org; 22 Jun 2022 13:02:52 +0000 Received: from localhost ([127.0.0.1]:34349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o400R-00006i-R8 for submit@debbugs.gnu.org; Wed, 22 Jun 2022 09:02:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o400N-00006S-F4 for 55883@debbugs.gnu.org; Wed, 22 Jun 2022 09:02:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o400G-0007fI-QN; Wed, 22 Jun 2022 09:02:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=y1I4maRf7f1Lh1ASIOrQ44EyB3xLAduIzWFysYV9nF0=; b=m+5UbYxa9oZq mskJIsFHHVVrmQ1dPsGR1pjGW0JBmcT3FYmJxGoM8+evTAuz3j0jslJWLYj4EBeA4JiRnihndhU67 l6KH0tFEJdQ5u3xPdQDhk8kOvAaFfk7YqE2W3VVAxLCkm6VYVey9ikKjSyz0FkLLbh0gQaBWyr4PI TymZxOEFzxqEBEnZgxvqmvxf7zKwFZExtNnSupyhYbnttbko8RH5pdrCmYjNdv7J9aP3OX/m8F3Xh Xn+Hm4GrnrE9sDUI6GNCSA7PHvT6LTDCyeWMHBuu7kEXiCueoWoH/SPrka48PUS8mz1Pt7oY51WCJ 0ml6Dy1feN001jMN6JngXQ==; Received: from [87.69.77.57] (port=4362 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o400G-0004ce-0w; Wed, 22 Jun 2022 09:02:40 -0400 Date: Wed, 22 Jun 2022 16:02:30 +0300 Message-Id: <83iloskg0p.fsf@gnu.org> From: Eli Zaretskii To: Duncan Findlay In-Reply-To: (message from Duncan Findlay on Tue, 21 Jun 2022 18:58:16 -0700) Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions References: <834k0t104u.fsf@gnu.org> <8335gbzled.fsf@gnu.org> <837d5jtp9x.fsf@gnu.org> <83v8t1rhtt.fsf@gnu.org> <83czf6ns0e.fsf@gnu.org> <878rpuknov.fsf@tcd.ie> <838rpuneb1.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55883 Cc: contovob@tcd.ie, 55883@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Duncan Findlay > Date: Tue, 21 Jun 2022 18:58:16 -0700 > Cc: "Basil L. Contovounesios" , 55883@debbugs.gnu.org > > Oops. I'm sorry I missed that, and thank you for the quick fixes! It > looks like you renamed the variable, and put it in frame.el with > 7e1f84fa3bc7dfd84415813889c91070c0759da2 and > 4e68166d77cdd0f3b84c9bf5681f6a95e51ad238. I assume that means that > frame.el is always loaded in tests, and that xterm.el is sometimes not > loaded? frame.el is preloaded, so it is present in every Emacs session, yes. xterm.el is only loaded when Emacs needs to display some frame on a TTY terminal emulated by xterm. > I don't have a problem with the current fix, though I'm wondering if > the attached patch would have worked too? I considered that, but I don't like to have variables related to xterm (or any other particular terminal type) in a general-purpose infrastructure code. I apologize for not realizing this adverse effect earlier. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 22 11:37:42 2022 Received: (at 55883) by debbugs.gnu.org; 22 Jun 2022 15:37:42 +0000 Received: from localhost ([127.0.0.1]:36366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o42QI-0004Wq-7M for submit@debbugs.gnu.org; Wed, 22 Jun 2022 11:37:42 -0400 Received: from mail-ed1-f49.google.com ([209.85.208.49]:41578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o42QG-0004WZ-7v for 55883@debbugs.gnu.org; Wed, 22 Jun 2022 11:37:40 -0400 Received: by mail-ed1-f49.google.com with SMTP id cf14so14693969edb.8 for <55883@debbugs.gnu.org>; Wed, 22 Jun 2022 08:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=gY0n0ez/781dPMno7mIA3u9Xa/tfyWL2ynAJ7WirOqo=; b=ZPPpr7M1s4B7HeCwrqGn2A2oOL2nen+GBoWmXxZHtcAZYLtBOg4pkL7l+vEFnlAhH9 IJ5fo9wx7XzNSXdn6iFSSA9ygThCsxRfLlD5rI88SBGknIqpGJfLp+inR/HrzAZCPc2C tCfi3ks6eEb+l7QdELMJWxDtCk0Zz5+KrkDX6dtmlW7iQsAXq3aqyt+X/sv0fdRTH/ei TdXmdgcXv+04AjCr4dNI+BmcFKawVu9tNlg5oMLLavJmZcY46QBj9US5HHKTUSp6ZC9N Fj5tNh0xExAZUhP3pvfYzJMVlv2lvcbq3WU5qpzAb7P893JO4Fy4kCIM4/SCLm1JVMy/ SI8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=gY0n0ez/781dPMno7mIA3u9Xa/tfyWL2ynAJ7WirOqo=; b=eLRCnsdvGXP8X6p4rknek9uPi4oR2QPx2+Cw9AV3JiQ7qINmRxTktyP7h+3mSB1W7i dIdkMpZuV1ibd5irqwe1ftvMf1uXamdeqti35e7CUTFxYmFi3nqnB4cqtmJXQveJVlAk lp2SBzlhBmmDNj8Wl8iMyQUa2ooVQNpJdxRWNx3I1xQHYMp5LocUbGMeDSRGMjUfdve0 Qz8vGnJ2dhaLWuMbpcuykX74DJouwFIbnTfORVaJFvh7yZW4DjOAQYBzz5yDh1APH4YH Sbg9gIqWi7m6z5WqLlfrvghPrrchzSb4GZXcwfJIZ8cLuJA99gO68E/B3Dm/pXkP/Ylh drQA== X-Gm-Message-State: AJIora9Q88HqXV1DM4EcNZAeLbI7mnMcBi8dHmmqh9uk5eMqjuaSTDRA bqNvcRxgYt3Z856+NArcVIDDkA== X-Google-Smtp-Source: AGRyM1te+CjO+G/ME8wwMPpGmQ2asdeltGKOHLCgK4LRDxmyvZR9584fvIZKbO3ogPY+51v/+YEhLQ== X-Received: by 2002:a05:6402:448c:b0:435:9dcc:b8a5 with SMTP id er12-20020a056402448c00b004359dccb8a5mr4774073edb.287.1655912254250; Wed, 22 Jun 2022 08:37:34 -0700 (PDT) Received: from localhost ([2a02:587:322b:6f5e:dc92:136a:a7c4:dc8c]) by smtp.gmail.com with ESMTPSA id b12-20020a17090630cc00b00722edb5fb53sm1449523ejb.116.2022.06.22.08.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 08:37:33 -0700 (PDT) From: "Basil L. Contovounesios" To: Duncan Findlay Subject: Re: bug#55883: [PATCH] Update X Primary Selection with active regions References: <834k0t104u.fsf@gnu.org> <8335gbzled.fsf@gnu.org> <837d5jtp9x.fsf@gnu.org> <83v8t1rhtt.fsf@gnu.org> <83czf6ns0e.fsf@gnu.org> <878rpuknov.fsf@tcd.ie> <838rpuneb1.fsf@gnu.org> Date: Wed, 22 Jun 2022 18:37:24 +0300 In-Reply-To: (Duncan Findlay's message of "Tue, 21 Jun 2022 18:58:16 -0700") Message-ID: <871qvgzp3f.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55883 Cc: Eli Zaretskii , 55883@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Duncan Findlay [2022-06-21 18:58 -0700] wrote: > I'm wondering if the attached patch would have worked too? Its downside is that the variable can then be defined in more than one place, with potentially different/out-of-sync values, depending on load order. This makes debugging and maintenance a bit harder. Using bound-and-true-p would have achieved the same effect while keeping the user option squarely defined in a single place. But Eli's patch generalises even further. Thanks, -- Basil From unknown Fri Sep 05 08:20:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 21 Jul 2022 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator