GNU bug report logs - #55873
28.1; browse-url-encode-url escaped dollar symbol

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55873 in the body.
You can then email your comments to 55873 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: urugang <urugang <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.1; browse-url-encode-url escaped dollar symbol
Date: Thu, 09 Jun 2022 23:04:37 +0800

(browse-url
"https://www.javadoc.io/doc/com.lightbend.akka/akka-stream-alpakka-amqp_2.13/latest/akka/stream/alpakka/amqp/javadsl/AmqpSource$.html")

It opens url
"https://www.javadoc.io/doc/com.lightbend.akka/akka-stream-alpakka-amqp_2.13/latest/akka/stream/alpakka/amqp/javadsl/AmqpSource%24.html"
which escaped dollor symbol "$" to "%24".
firefox/chrome/safari all recognize dollor symbol ("$") and escaped char ("%24")
as different things.

I found browse-url-url-encode-chars replace "$" as "%24", which is not
correct.

(defun browse-url-encode-url (url)
 (browse-url-url-encode-chars url "[\"()$ ]"))
(defun browse-url-url-encode-chars (text chars)
  (replace-regexp-in-string chars
                            (lambda (s)
                              (format "%%%X" (string-to-char s)))
                            text))

So I think we should remove escape encode of dollar symbol ("$") as below.

(defun browse-url-encode-url (url)
 (browse-url-url-encode-chars url "[\"() ]"))

Message #8 received at 55873 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: urugang <urugang <at> gmail.com>
Cc: 55873 <at> debbugs.gnu.org
Subject: Re: bug#55873: 28.1; browse-url-encode-url escaped dollar symbol
Date: Thu, 09 Jun 2022 17:12:09 +0200

urugang <urugang <at> gmail.com> writes:

> So I think we should remove escape encode of dollar symbol ("$") as below.
>
> (defun browse-url-encode-url (url)
>  (browse-url-url-encode-chars url "[\"() ]"))

Yup.  I've fixed this in Emacs 29 now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.