GNU bug report logs - #55861
[PATCH] Update native-comp error message to reflect variable change

Previous Next

Package: emacs;

Reported by: Fejfighter <fejfighter <at> gmail.com>

Date: Thu, 9 Jun 2022 00:19:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55861 in the body.
You can then email your comments to 55861 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#55861; Package emacs. (Thu, 09 Jun 2022 00:19:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Fejfighter <fejfighter <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 09 Jun 2022 00:19:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fejfighter <fejfighter <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Update native-comp error message to reflect variable change
Date: Thu, 9 Jun 2022 10:17:48 +1000

[Message part 1 (text/plain, inline)]
Updates a Native-compilation error message to make debugging user init
files much easier.

The referenced variable got renamed sometime during integration, this just
got missed somehow.

My paperwork is done, but this should be small enough anyway

Thanks

Jeff W

[Message part 2 (text/html, inline)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55861; Package emacs. (Thu, 09 Jun 2022 05:33:01 GMT) Full text and rfc822 format available.

Message #8 received at 55861 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Fejfighter <fejfighter <at> gmail.com>
Cc: 55861 <at> debbugs.gnu.org
Subject: Re: bug#55861: [PATCH] Update native-comp error message to reflect
 variable change
Date: Thu, 09 Jun 2022 08:31:58 +0300

> From: Fejfighter <fejfighter <at> gmail.com>
> Date: Thu, 9 Jun 2022 10:17:48 +1000
> 
> Updates a Native-compilation error message to make debugging user init
> files much easier.
> 
> The referenced variable got renamed sometime during integration, this just
> got missed somehow.

ENOPATCH
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55861; Package emacs. (Thu, 09 Jun 2022 06:07:02 GMT) Full text and rfc822 format available.

Message #11 received at 55861 <at> debbugs.gnu.org (full text, mbox):

From: Fejfighter <fejfighter <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55861 <at> debbugs.gnu.org
Subject: Re: bug#55861: [PATCH] Update native-comp error message to reflect
 variable change
Date: Thu, 9 Jun 2022 16:06:26 +1000

[Message part 1 (text/plain, inline)]
On Thu, Jun 9, 2022 at 3:32 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Fejfighter <fejfighter <at> gmail.com>
> > Date: Thu, 9 Jun 2022 10:17:48 +1000
> >
> > Updates a Native-compilation error message to make debugging user init
> > files much easier.
> >
> > The referenced variable got renamed sometime during integration, this
> just
> > got missed somehow.
>
> ENOPATCH
>

[Message part 2 (text/html, inline)]
[0001-Update-error-message-to-reflect-variable-rename.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55861; Package emacs. (Thu, 09 Jun 2022 06:38:02 GMT) Full text and rfc822 format available.

Message #14 received at 55861 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Fejfighter <fejfighter <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 55861 <at> debbugs.gnu.org
Subject: Re: bug#55861: [PATCH] Update native-comp error message to reflect
 variable change
Date: Thu, 09 Jun 2022 06:37:20 +0000

Fejfighter <fejfighter <at> gmail.com> writes:

> On Thu, Jun 9, 2022 at 3:32 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>  > From: Fejfighter <fejfighter <at> gmail.com>
>  > Date: Thu, 9 Jun 2022 10:17:48 +1000
>  > 
>  > Updates a Native-compilation error message to make debugging user init
>  > files much easier.
>  > 
>  > The referenced variable got renamed sometime during integration, this just
>  > got missed somehow.
>
>  ENOPATCH

Hi,

pushed as ec987e3e17.

Thanks

  Andrea
Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Thu, 09 Jun 2022 06:54:01 GMT) Full text and rfc822 format available.
Notification sent to Fejfighter <fejfighter <at> gmail.com>:
bug acknowledged by developer. (Thu, 09 Jun 2022 06:54:01 GMT) Full text and rfc822 format available.

Message #19 received at 55861-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Fejfighter <fejfighter <at> gmail.com>
Cc: 55861-done <at> debbugs.gnu.org
Subject: Re: bug#55861: [PATCH] Update native-comp error message to reflect
 variable change
Date: Thu, 09 Jun 2022 09:52:49 +0300

> From: Fejfighter <fejfighter <at> gmail.com>
> Date: Thu, 9 Jun 2022 16:06:26 +1000
> Cc: 55861 <at> debbugs.gnu.org
> 
> From 940357a6ec07527609784d7d5515bfa9b45096d0 Mon Sep 17 00:00:00 2001
> From: Jeff Walsh <fejfighter <at> gmail.com>
> Date: Thu, 9 Jun 2022 10:02:01 +1000
> Subject: [PATCH] Update error message to reflect variable rename
> 
> * src/comp.c (Fcomp_el_to_eln_filename): update mesage

Thanks, installed on the release branch.

Please in the future make sure the commit log message is according to
our conventions: the description of the individual changes should be
one or more complete sentences, starting with a capital letter and
ending with a period.  It also should mention the bug number (when you
know it).
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55861; Package emacs. (Thu, 09 Jun 2022 07:07:02 GMT) Full text and rfc822 format available.

Message #22 received at 55861 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: fejfighter <at> gmail.com, 55861 <at> debbugs.gnu.org
Subject: Re: bug#55861: [PATCH] Update native-comp error message to reflect
 variable change
Date: Thu, 09 Jun 2022 10:06:33 +0300

> From: Andrea Corallo <akrl <at> sdf.org>
> Cc: Eli Zaretskii <eliz <at> gnu.org>, 55861 <at> debbugs.gnu.org
> Date: Thu, 09 Jun 2022 06:37:20 +0000
> 
> Fejfighter <fejfighter <at> gmail.com> writes:
> 
> > On Thu, Jun 9, 2022 at 3:32 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
> >
> >  > From: Fejfighter <fejfighter <at> gmail.com>
> >  > Date: Thu, 9 Jun 2022 10:17:48 +1000
> >  > 
> >  > Updates a Native-compilation error message to make debugging user init
> >  > files much easier.
> >  > 
> >  > The referenced variable got renamed sometime during integration, this just
> >  > got missed somehow.
> >
> >  ENOPATCH
> 
> Hi,
> 
> pushed as ec987e3e17.

Thanks, but that was a mistake: the problem exists in Emacs 28.1 as
well, so this change should have been installed on the release branch
instead.

So I have now installed it on the release branch, and reverted the
change on master to avoid merge conflicts.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55861; Package emacs. (Thu, 09 Jun 2022 08:15:02 GMT) Full text and rfc822 format available.

Message #25 received at 55861 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: fejfighter <at> gmail.com, 55861 <at> debbugs.gnu.org
Subject: Re: bug#55861: [PATCH] Update native-comp error message to reflect
 variable change
Date: Thu, 09 Jun 2022 08:14:47 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Andrea Corallo <akrl <at> sdf.org>
>> Cc: Eli Zaretskii <eliz <at> gnu.org>, 55861 <at> debbugs.gnu.org
>> Date: Thu, 09 Jun 2022 06:37:20 +0000
>> 
>> Fejfighter <fejfighter <at> gmail.com> writes:
>> 
>> > On Thu, Jun 9, 2022 at 3:32 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
>> >
>> >  > From: Fejfighter <fejfighter <at> gmail.com>
>> >  > Date: Thu, 9 Jun 2022 10:17:48 +1000
>> >  > 
>> >  > Updates a Native-compilation error message to make debugging user init
>> >  > files much easier.
>> >  > 
>> >  > The referenced variable got renamed sometime during integration, this just
>> >  > got missed somehow.
>> >
>> >  ENOPATCH
>> 
>> Hi,
>> 
>> pushed as ec987e3e17.
>
> Thanks, but that was a mistake: the problem exists in Emacs 28.1 as
> well, so this change should have been installed on the release branch
> instead.
>
> So I have now installed it on the release branch, and reverted the
> change on master to avoid merge conflicts.

Right, thanks!

  Andrea
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 07 Jul 2022 11:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 76 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.