GNU bug report logs - #55836
29.0.50; (iconify-frame) freezes buffer view under Wayland.

Previous Next

Package: emacs;

Reported by: "koaaa.outlook" <whainte <at> outlook.com>

Date: Tue, 7 Jun 2022 20:25:02 UTC

Severity: normal

Tags: patch

Merged with 56833, 58424

Found in version 29.0.50

Done: Po Lu <luangruo <at> yahoo.com>

Bug is archived. No further changes may be made.

Full log


Message #71 received at 55836 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: 55836 <at> debbugs.gnu.org
Subject: Re: bug#55836: 29.0.50; (iconify-frame) freezes buffer view under
 Wayland.
Date: Fri, 30 Sep 2022 21:17:23 +0800
Tino Calancha <tino.calancha <at> gmail.com> writes:

> On Thu, 29 Sep 2022, Po Lu wrote:
>
>> You should simply be able to type "b gdk_wayland_window_handle_configure".
>
> I see, thank you.
>
>> Could you install debug info for GDK, put breakpoints on both
>> window_state_event (in pgtkterm.c) and
>> gdk_wayland_window_handle_configure (in gdkwindow-wayland.c)?
>
>> Please see whether the former is called after the latter, and in doing
>> so clears the iconified flag?
>
> This is what I see:
>
> 1. The breakpoint at gdk_wayland_window_handle_configure is never reached.
>     I have tried with both patches discussed above, and the master branch
>     with no success: such breakpoint is not reached.
>
> 2. I have played with the following patch that also fixes the issue in my
>     machine:
>
> diff --git a/src/pgtkterm.c b/src/pgtkterm.c
> index 491ba33..58456c9 100644
> --- a/src/pgtkterm.c
> +++ b/src/pgtkterm.c
> @@ -5502,13 +5502,6 @@ window_state_event (GtkWidget *widget,
>
>     if (new_state & GDK_WINDOW_STATE_ICONIFIED)
>       SET_FRAME_ICONIFIED (f, true);
> -  else
> -    {
> -      FRAME_X_OUTPUT (f)->has_been_visible = true;
> -      inev.ie.kind = DEICONIFY_EVENT;
> -      XSETFRAME (inev.ie.frame_or_window, f);
> -      SET_FRAME_ICONIFIED (f, false);
> -    }
>
>     if (new_state & GDK_WINDOW_STATE_STICKY)
>       store_frame_param (f, Qsticky, Qt);

That's shocking.  I will look into this further myself (in a Wayland
session.)

Thanks.




This bug report was last modified 2 years and 192 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.