GNU bug report logs - #55825
[PATCH] Reconvert EPUB buffers when user CSS is changed

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kjartan Oli Agustsson <kjartanoli <at> outlook.com>
Cc: 55825 <at> debbugs.gnu.org
Subject: bug#55825: [PATCH] Reconvert EPUB buffers when user CSS is changed
Date: Tue, 07 Jun 2022 11:57:16 +0200

Kjartan Oli Agustsson <kjartanoli <at> outlook.com> writes:

> Following my patch from a few months ago which added the
> `doc-view-mutool-user-stylesheet' defcustom to Doc-View making use of
> mutools ability to apply a user specified CSS file when converting a
> EPUB file.  Here is a patch to reconvert existing EPUB buffers when the
> value of that variable (renamed to `doc-view-epub-user-stylesheet' as
> discussed after my last patch) is changed, or the specified file is
> changed, therefore applying the new CSS immediately.

Did you mean to remove the doc-view-mutool-user-stylesheet user option
instead of renaming it?

In any case, the patch has the following warnings:

In doc-view--epub-reconvert:
doc-view.el:238:44: Warning: Unused lexical argument `event'
In doc-view-custom-set-epub-user-stylesheet:
doc-view.el:256:16: Warning: reference to free variable `doc-view-epub-user-stylesheet'


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.