GNU bug report logs - #55825
[PATCH] Reconvert EPUB buffers when user CSS is changed

Previous Next

Full log

Message #17 received at 55825 <at> debbugs.gnu.org (full text, mbox):

From: Kjartan Oli Agustsson <kjartanoli <at> outlook.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55825 <at> debbugs.gnu.org
Subject: Re: bug#55825: [PATCH] Reconvert EPUB buffers when user CSS is changed
Date: Tue, 07 Jun 2022 21:51:46 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> Are you sure 'change is TRT here?  What kinds of changes did you want
> to watch in this case

I'm trying to detect a change in the contents of the file, which would
probably mean that the CSS rules have been modified.

>(it isn't clear from the doc string or the log message)

Yes, I see now that I forgot to add a mention of this in the docstring
when I added the file watcher, I will rectify this.

> 'change is a synthetic event, and it means slightly different things
> with each file-notification back-end, so I wonder whether 'change is
> portable enough here?

From what I could see from the docstring of `file-notify-add-watch'
'change seemed the most appropriate, but if you think something else
would be better I will gladly modify the patch to use that instead.

-- 
Kjartan Óli Ágústsson

GPG Key fingerprint: 4801 0D71 49C0 1DD6 E5FD  6AC9 D757 2FE3 605E E6B0

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.