Subject: [bug#55819] [PATCH 0/2] gnu: Add f3d.

From: 宋文武 <[email-masked]>
Date: Thu, 11 Aug 2022 17:02:53 +0800

"Paul A. Patience" <[email-masked]> writes:

Hello, I had pushed those patches, with adjusted f3d synopsis and
description (remove "fast", "minimalistic", "KISS"), and also phases.

> [...]
> +        #:phases
> +        #~(modify-phases %standard-phases
> +            (add-after 'unpack 'adjust-titles-and-descriptions
> +              (lambda _
> +                (substitute* '("CMakeLists.txt"
> +                               "resources/f3d.desktop.in"
> +                               "resources/io.github.f3d_app.f3d.metainfo.xml")
> +                  (("A fast and minimalist 3D viewer")
> +                   "Fast and minimalistic 3D viewer"))
> +                (substitute* "resources/io.github.f3d_app.f3d.metainfo.xml"
> +                  (("it is minimalist,")
> +                   "it is minimalistic,")
> +                  (("arguments in the command line\\.")
> +                   "arguments on the command line."))
> +                ;; Keep the title bar short.
> +                (substitute* "application/F3DConfig.h.in"
> +                  (("AppTitle = \"@PROJECT_DESCRIPTION@\";")
> +                   "AppTitle = \"F3D\";"))))
> +            (add-after 'unpack 'fix-typos
> +              (lambda _
> +                (substitute* '("application/F3DOptionsParser.cxx"
> +                               "application/F3DStarter.cxx"
> +                               "cmake/testing.cmake"
> +                               "library/testing/TestSDKHelpers.h")
> +                  (("does not exists")
> +                   "does not exist"))))
> +            ;; Skip checking for the relative-to-executable configuration file
> +            ;; (located in ../../argv[0]) when the user configuration file
> +            ;; doesn't exist, because the check fails and prints a warning
> +            ;; message upon each invocation of the program.
> +            ;; Besides, the usefulness of this configuration file is unclear
> +            ;; because F3D reads /etc/f3d/config.json as a fallback system
> +            ;; configuration file.
> +            (add-after 'unpack 'ignore-binary-config-file-dir
> +              (lambda _
> +                (substitute* "application/F3DOptionsParser.cxx"
> +                  (("^ +filePath = .*->GetBinaryConfigFileDirectory\\(\\) .*")
> +                   "")))))))

I think those titles, descriptions, typos, and warning should go direct
to the upstream, since they don't change the function of f3d, so I pushed
this patch without those modifications first.

Thank you!