From unknown Fri Aug 15 03:56:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55815: [PATCH] bindat: Improve str, strz documentation Resent-From: Richard Hansen Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jun 2022 02:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55815 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 55815@debbugs.gnu.org Cc: monnier@iro.umontreal.ca X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: monnier@iro.umontreal.ca Received: via spool by submit@debbugs.gnu.org id=B.16544821288543 (code B ref -1); Mon, 06 Jun 2022 02:23:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Jun 2022 02:22:08 +0000 Received: from localhost ([127.0.0.1]:33998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ny2Nc-0002Dj-7x for submit@debbugs.gnu.org; Sun, 05 Jun 2022 22:22:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:36454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ny2Na-0002Da-8N for submit@debbugs.gnu.org; Sun, 05 Jun 2022 22:22:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ny2NZ-0003ey-U6 for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 22:22:06 -0400 Received: from spork.scientician.org ([2600:3c03:e000:66::1]:48911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ny2NX-0006wj-R3 for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 22:22:05 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id 1A23D47F45 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1654482122; bh=Jj13ab1AvtAg4S+dh2pKbTaPpYCC8GOFSkvTKWXjDGc=; h=Date:To:From:Subject:From; b=OK1mkhCRU0H+lbiaVq2ve3H2xFmRreHWbSsjhh5hLfhfLgDjYdW5y6yCU2mL+G8xU 9OlcHS62G+VsZWy+4yaHTmIAatwSc+YL3+EhfJ5/V0l46x7MvoMd+Van+vn5JtUDXU 6CG/QaneecBprVbvoOBm7q2faWdd3BrYGX88CNCE= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id D0718201AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1654482120; bh=Jj13ab1AvtAg4S+dh2pKbTaPpYCC8GOFSkvTKWXjDGc=; h=Date:To:From:Subject:From; b=hQMJkozPtnYEd3+r9h1nNl0rHn2Kwta3JSOgCbsAVkaVn1XJjofQ2Ms2R9ouUMKop H9TujmKKFq14L8s4qnsjmWsX273s3z2ZLpKOvvFJaR6NLdowOmF0fh/trRqACIJdvz Yc96/VhdPDBXQstcUI86DQ8gX0ZZeJkus60VHfYI= Content-Type: multipart/mixed; boundary="------------GIIlSDw95bYa075mDCrL8JGM" Message-ID: <3fc223d1-6dc0-6f59-1b27-d72dd8a3004e@rhansen.org> Date: Sun, 5 Jun 2022 22:22:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US From: Richard Hansen Received-SPF: pass client-ip=2600:3c03:e000:66::1; envelope-from=rhansen@rhansen.org; helo=spork.scientician.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------GIIlSDw95bYa075mDCrL8JGM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Debbugs-CC: monnier@iro.umontreal.ca * doc/lispref/processes.texi (Bindat Types): Expand the documentation for the `str' and `strz' types to clarify expectations and explain edge case behavior. --- doc/lispref/processes.texi | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/doc/lispref/processes.texi b/doc/lispref/processes.texi index 668a577870..68621d32a8 100644 --- a/doc/lispref/processes.texi +++ b/doc/lispref/processes.texi @@ -3479,11 +3479,31 @@ Bindat Types @var{bitlen} has to be a multiple of 8. @item str @var{len} -String of bytes of length @var{len}. +String of length @var{len}. When packing, the first @var{len} bytes +of the input string are copied to the packed output. If the input +string is shorter than @var{len}, the remaining bytes are set to zero. +The input string must be unibyte (@pxref{Text Representations}). When +unpacking, any zero bytes in the packed input string will appear in +the unpacked output. @item strz &optional @var{len} -Zero-terminated string of bytes, can be of arbitrary length or in a fixed-size -field with length @var{len}. +If @var{len} is not provided: Variable-length null-terminated string. +When packing, the entire input string is copied to the packed output +followed by a zero byte (null terminator). The input string must be +unibyte (@pxref{Text Representations}) and must not contain any zero +bytes. When unpacking, the resulting string contains all bytes up to +(but excluding) the null terminator. + +If @var{len} is provided: @code{strz} behaves the same as @code{str} +with one difference. When unpacking, the first zero byte (null +terminator) encountered in the packed string and all subsequent bytes +are excluded from the unpacked result. + +@quotation Caution +The packed output will not be null-terminated unless the input string +is shorter than @var{len} or it contains a zero byte within the first +@var{len} bytes. +@end quotation @item vec @var{len} [@var{type}] Vector of @var{len} elements. The type of the elements is given by -- 2.36.1 --------------GIIlSDw95bYa075mDCrL8JGM Content-Type: text/x-patch; charset=UTF-8; name="0001-bindat-Improve-str-strz-documentation.patch" Content-Disposition: attachment; filename="0001-bindat-Improve-str-strz-documentation.patch" Content-Transfer-Encoding: base64 RnJvbSAzMjllYzM2NTBjMGNjYzhhMDFiZDYxOTY4MDVkNTEzNjIxOGVmMzkxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogVGh1LCAyIEp1biAyMDIyIDIxOjA1OjQwIC0wNDAwClN1YmplY3Q6IFtQ QVRDSF0gYmluZGF0OiBJbXByb3ZlIHN0ciwgc3RyeiBkb2N1bWVudGF0aW9uCgoqIGRvYy9s aXNwcmVmL3Byb2Nlc3Nlcy50ZXhpIChCaW5kYXQgVHlwZXMpOiBFeHBhbmQgdGhlIGRvY3Vt ZW50YXRpb24KZm9yIHRoZSBgc3RyJyBhbmQgYHN0cnonIHR5cGVzIHRvIGNsYXJpZnkgZXhw ZWN0YXRpb25zIGFuZCBleHBsYWluCmVkZ2UgY2FzZSBiZWhhdmlvci4KLS0tCiBkb2MvbGlz cHJlZi9wcm9jZXNzZXMudGV4aSB8IDI2ICsrKysrKysrKysrKysrKysrKysrKysrLS0tCiAx IGZpbGUgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9kb2MvbGlzcHJlZi9wcm9jZXNzZXMudGV4aSBiL2RvYy9saXNwcmVmL3Byb2Nl c3Nlcy50ZXhpCmluZGV4IDY2OGE1Nzc4NzAuLjY4NjIxZDMyYTggMTAwNjQ0Ci0tLSBhL2Rv Yy9saXNwcmVmL3Byb2Nlc3Nlcy50ZXhpCisrKyBiL2RvYy9saXNwcmVmL3Byb2Nlc3Nlcy50 ZXhpCkBAIC0zNDc5LDExICszNDc5LDMxIEBAIEJpbmRhdCBUeXBlcwogQHZhcntiaXRsZW59 IGhhcyB0byBiZSBhIG11bHRpcGxlIG9mIDguCiAKIEBpdGVtIHN0ciBAdmFye2xlbn0KLVN0 cmluZyBvZiBieXRlcyBvZiBsZW5ndGggQHZhcntsZW59LgorU3RyaW5nIG9mIGxlbmd0aCBA dmFye2xlbn0uICBXaGVuIHBhY2tpbmcsIHRoZSBmaXJzdCBAdmFye2xlbn0gYnl0ZXMKK29m IHRoZSBpbnB1dCBzdHJpbmcgYXJlIGNvcGllZCB0byB0aGUgcGFja2VkIG91dHB1dC4gIElm IHRoZSBpbnB1dAorc3RyaW5nIGlzIHNob3J0ZXIgdGhhbiBAdmFye2xlbn0sIHRoZSByZW1h aW5pbmcgYnl0ZXMgYXJlIHNldCB0byB6ZXJvLgorVGhlIGlucHV0IHN0cmluZyBtdXN0IGJl IHVuaWJ5dGUgKEBweHJlZntUZXh0IFJlcHJlc2VudGF0aW9uc30pLiAgV2hlbgordW5wYWNr aW5nLCBhbnkgemVybyBieXRlcyBpbiB0aGUgcGFja2VkIGlucHV0IHN0cmluZyB3aWxsIGFw cGVhciBpbgordGhlIHVucGFja2VkIG91dHB1dC4KIAogQGl0ZW0gc3RyeiAmb3B0aW9uYWwg QHZhcntsZW59Ci1aZXJvLXRlcm1pbmF0ZWQgc3RyaW5nIG9mIGJ5dGVzLCBjYW4gYmUgb2Yg YXJiaXRyYXJ5IGxlbmd0aCBvciBpbiBhIGZpeGVkLXNpemUKLWZpZWxkIHdpdGggbGVuZ3Ro IEB2YXJ7bGVufS4KK0lmIEB2YXJ7bGVufSBpcyBub3QgcHJvdmlkZWQ6IFZhcmlhYmxlLWxl bmd0aCBudWxsLXRlcm1pbmF0ZWQgc3RyaW5nLgorV2hlbiBwYWNraW5nLCB0aGUgZW50aXJl IGlucHV0IHN0cmluZyBpcyBjb3BpZWQgdG8gdGhlIHBhY2tlZCBvdXRwdXQKK2ZvbGxvd2Vk IGJ5IGEgemVybyBieXRlIChudWxsIHRlcm1pbmF0b3IpLiAgVGhlIGlucHV0IHN0cmluZyBt dXN0IGJlCit1bmlieXRlIChAcHhyZWZ7VGV4dCBSZXByZXNlbnRhdGlvbnN9KSBhbmQgbXVz dCBub3QgY29udGFpbiBhbnkgemVybworYnl0ZXMuICBXaGVuIHVucGFja2luZywgdGhlIHJl c3VsdGluZyBzdHJpbmcgY29udGFpbnMgYWxsIGJ5dGVzIHVwIHRvCisoYnV0IGV4Y2x1ZGlu ZykgdGhlIG51bGwgdGVybWluYXRvci4KKworSWYgQHZhcntsZW59IGlzIHByb3ZpZGVkOiBA Y29kZXtzdHJ6fSBiZWhhdmVzIHRoZSBzYW1lIGFzIEBjb2Rle3N0cn0KK3dpdGggb25lIGRp ZmZlcmVuY2UuIFdoZW4gdW5wYWNraW5nLCB0aGUgZmlyc3QgemVybyBieXRlIChudWxsCit0 ZXJtaW5hdG9yKSBlbmNvdW50ZXJlZCBpbiB0aGUgcGFja2VkIHN0cmluZyBhbmQgYWxsIHN1 YnNlcXVlbnQgYnl0ZXMKK2FyZSBleGNsdWRlZCBmcm9tIHRoZSB1bnBhY2tlZCByZXN1bHQu CisKK0BxdW90YXRpb24gQ2F1dGlvbgorVGhlIHBhY2tlZCBvdXRwdXQgd2lsbCBub3QgYmUg bnVsbC10ZXJtaW5hdGVkIHVubGVzcyB0aGUgaW5wdXQgc3RyaW5nCitpcyBzaG9ydGVyIHRo YW4gQHZhcntsZW59IG9yIGl0IGNvbnRhaW5zIGEgemVybyBieXRlIHdpdGhpbiB0aGUgZmly c3QKK0B2YXJ7bGVufSBieXRlcy4KK0BlbmQgcXVvdGF0aW9uCiAKIEBpdGVtIHZlYyBAdmFy e2xlbn0gW0B2YXJ7dHlwZX1dCiBWZWN0b3Igb2YgQHZhcntsZW59IGVsZW1lbnRzLiAgVGhl IHR5cGUgb2YgdGhlIGVsZW1lbnRzIGlzIGdpdmVuIGJ5Ci0tIAoyLjM2LjEKCg== --------------GIIlSDw95bYa075mDCrL8JGM-- From unknown Fri Aug 15 03:56:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55815: [PATCH] bindat: Improve str, strz documentation Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jun 2022 11:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55815 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Richard Hansen Cc: 55815@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 55815-submit@debbugs.gnu.org id=B55815.16545132054752 (code B ref 55815); Mon, 06 Jun 2022 11:01:02 +0000 Received: (at 55815) by debbugs.gnu.org; 6 Jun 2022 11:00:05 +0000 Received: from localhost ([127.0.0.1]:34487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyASr-0001Ea-0r for submit@debbugs.gnu.org; Mon, 06 Jun 2022 07:00:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyASn-0001DR-Fo for 55815@debbugs.gnu.org; Mon, 06 Jun 2022 07:00:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33960) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyASh-0003Aq-MI; Mon, 06 Jun 2022 06:59:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=glqcMf+ycEe9Ci62JjtcBfTt5ch4cBEBjHDp8dpDn9w=; b=CWqehWidExiF vWGcPvi/xALOP/Vupy2xSRzCGC7IKhtMzAI88kFcpqP68yt6j2oelpvNSUGu06pP0P3SMxMV+5muR dfvVmwSixg+IE16CIM+/X+zB+n+LnsVmL0F7wgOMgpszfJ4htA0cE1Hz2OnQEjjlzGAjRX2PNwvkj ljN2qcQp8oxXjojFmkUUzVbWObM3AIUdI9l4lKhIZQhEcW8k6XlMAY6TN00FPzwKc1q+bCTpoVSt8 P8Rv+NJ6/DyyoVmSzaiRkilEqUelJG4Y2Ui9+LmO8UeWjUWNLr/Gf0Y4sprdQQFXTGlq9668pUErG AB3PqkM97UUkY3g+qIiD9Q==; Received: from [87.69.77.57] (port=1943 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyASg-00066d-HP; Mon, 06 Jun 2022 06:59:55 -0400 Date: Mon, 06 Jun 2022 13:59:44 +0300 Message-Id: <83h74y83bz.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <3fc223d1-6dc0-6f59-1b27-d72dd8a3004e@rhansen.org> (message from Richard Hansen on Sun, 5 Jun 2022 22:22:01 -0400) References: <3fc223d1-6dc0-6f59-1b27-d72dd8a3004e@rhansen.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: monnier@iro.umontreal.ca > Date: Sun, 5 Jun 2022 22:22:01 -0400 > From: Richard Hansen > > @item str @var{len} > -String of bytes of length @var{len}. > +String of length @var{len}. I think it is better to say Unibyte string that is @var{len} bytes long. > @item strz &optional @var{len} > -Zero-terminated string of bytes, can be of arbitrary length or in a fixed-size > -field with length @var{len}. > +If @var{len} is not provided: Variable-length null-terminated string. Same here: it is better to mention the unibyte-ness up front, since it's important. > +If @var{len} is provided: @code{strz} behaves the same as @code{str} > +with one difference. When unpacking, the first zero byte (null ^^ Our conventions are to leave two spaces between sentences. Also, for consistency, I suggest to use "null byte" everywhere, to avoid potential confusion of non-native English speakers. Thanks. From unknown Fri Aug 15 03:56:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55815: [PATCH] bindat: Improve str, strz documentation Resent-From: Richard Hansen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jun 2022 23:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55815 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 55815@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 55815-submit@debbugs.gnu.org id=B55815.16545583056661 (code B ref 55815); Mon, 06 Jun 2022 23:32:02 +0000 Received: (at 55815) by debbugs.gnu.org; 6 Jun 2022 23:31:45 +0000 Received: from localhost ([127.0.0.1]:37089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyMCG-0001jN-RE for submit@debbugs.gnu.org; Mon, 06 Jun 2022 19:31:45 -0400 Received: from spork.scientician.org ([66.228.35.160]:34046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyMCE-0001jE-6s for 55815@debbugs.gnu.org; Mon, 06 Jun 2022 19:31:43 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id 9C5AC47F45 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1654558301; bh=tCAW5EQGT5YaF75yfiCvROvOKCzq54OSMc4mjvHm3rM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tItsboKZwFmoakCDEiXoqLfnjjNT+mda68ieF8PMsKqkYSacIuaO2DNushE3Y9g8K s3ZwVdYu72R0EmTTlVCnT9vjna5WPYftN1nZQRk3rJzo2BOKYr2NAEn94Q8wmMg7NB QrHLXoOB5iCqjrXYDHzq/O5aLZix/fXidLndVkO8= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id B17ED201AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1654558300; bh=tCAW5EQGT5YaF75yfiCvROvOKCzq54OSMc4mjvHm3rM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Z+oRh8QugDce+ln1T5j8NF4/vmKP+IoZ+XiHd7iAAjRbcwMJdTwCjFaLFi8Qc4vpu l2s/rsANZ/ZoYAPI2cjrBYfrNm+Paj3wcNbOTFDT1c2ELSlZxne6vPjwiJAKDM7Dis He58EABVRTvMuBD1Lzg7ktvm6naxSz1b0VXgcnwY= Message-ID: <13fe3d31-c2a7-f2ea-ba1a-305d5f5924ed@rhansen.org> Date: Mon, 6 Jun 2022 19:31:35 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US References: <3fc223d1-6dc0-6f59-1b27-d72dd8a3004e@rhansen.org> <83h74y83bz.fsf@gnu.org> From: Richard Hansen In-Reply-To: <83h74y83bz.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------rxJDk0XBuYWR5EdvDWBX4Zoi" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------rxJDk0XBuYWR5EdvDWBX4Zoi Content-Type: multipart/mixed; boundary="------------y3vOCT6eAQRmQoWFcIX4eZPZ"; protected-headers="v1" From: Richard Hansen To: Eli Zaretskii Cc: 55815@debbugs.gnu.org, monnier@iro.umontreal.ca Message-ID: <13fe3d31-c2a7-f2ea-ba1a-305d5f5924ed@rhansen.org> Subject: Re: bug#55815: [PATCH] bindat: Improve str, strz documentation References: <3fc223d1-6dc0-6f59-1b27-d72dd8a3004e@rhansen.org> <83h74y83bz.fsf@gnu.org> In-Reply-To: <83h74y83bz.fsf@gnu.org> --------------y3vOCT6eAQRmQoWFcIX4eZPZ Content-Type: multipart/mixed; boundary="------------pbmZ3pT3dNJ1P7veH5DFgOHv" --------------pbmZ3pT3dNJ1P7veH5DFgOHv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 VGhhbmtzIGZvciB0aGUgcmV2aWV3LiAgQSBuZXcgcmV2aXNpb24gaXMgYXR0YWNoZWQuDQoN Ck9uIDYvNi8yMiAwNjo1OSwgRWxpIFphcmV0c2tpaSB3cm90ZToNCj4gSSB0aGluayBpdCBp cyBiZXR0ZXIgdG8gc2F5DQo+IA0KPiAgICBVbmlieXRlIHN0cmluZyB0aGF0IGlzIEB2YXJ7 bGVufSBieXRlcyBsb25nLg0KDQpEb25lLiAgSSBtYXkgaGF2ZSBnb25lIG92ZXJib2FyZCB0 aG91Z2ggLS0gSSBkaWQgc28gYmVjYXVzZSB0aGVyZSBhcmUgdGhyZWUgcmVwcmVzZW50YXRp b25zIHRoYXQgbWF0dGVyOg0KDQogICAxLiBUaGUgaW5wdXQgc3RyaW5nIHRvIGJlIHBhY2tl ZC4NCiAgIDIuIFRoZSBwYWNrZWQgb3V0cHV0Lg0KICAgMy4gVGhlIHJlc3VsdCBvZiB1bnBh Y2tpbmcuDQoNClJpZ2h0IG5vdyBhbGwgdGhyZWUgb2YgdGhvc2UgYXJlIHVuaWJ5dGUsIGJ1 dCBpbiBhIGZ1dHVyZSBwYXRjaCBJIHBsYW4gb24gY2hhbmdpbmcgdGhlIGZpcnN0IHRvIGFj Y2VwdCB1bmlieXRlLWNvbnZlcnRpYmxlIG11bHRpYnl0ZSBpbnB1dCBzdHJpbmdzLg0KDQo+ IE91ciBjb252ZW50aW9ucyBhcmUgdG8gbGVhdmUgdHdvIHNwYWNlcyBiZXR3ZWVuIHNlbnRl bmNlcy4NCg0KRG9uZS4NCg0KPiBBbHNvLCBmb3IgY29uc2lzdGVuY3ksIEkgc3VnZ2VzdCB0 byB1c2UgIm51bGwgYnl0ZSIgZXZlcnl3aGVyZSwgdG8gDQo+IGF2b2lkIHBvdGVudGlhbCBj b25mdXNpb24gb2Ygbm9uLW5hdGl2ZSBFbmdsaXNoIHNwZWFrZXJzLg0KDQpEb25lLg0KDQpJ IGFsc28gZml4ZWQgYSBmbGF3IGluIHRoZSBwcmV2aW91cyByZXZpc2lvbjogcGFja2luZyB0 byBhIGZpeGVkLWxlbmd0aCBmaWVsZCBkb2Vzbid0IGFjdHVhbGx5IHdyaXRlIGEgbnVsbCBi eXRlIGlmIHRoZSBpbnB1dCBpcyBzaG9ydGVyIHRoYW4gdGhlIGZpZWxkLiBUaGlzIG9ubHkg bWF0dGVycyBpZiB0aGUgY2FsbGVyIHByb3ZpZGVkIGEgcHJlLWFsbG9jYXRlZCBzdHJpbmcg dGhhdCBkb2Vzbid0IGhhdmUgbnVsbCBieXRlcy4NCg0KVGhhbmtzLA0KUmljaGFyZA0K --------------pbmZ3pT3dNJ1P7veH5DFgOHv Content-Type: text/x-patch; charset=UTF-8; name="v2-0001-bindat-Improve-str-strz-documentation.patch" Content-Disposition: attachment; filename="v2-0001-bindat-Improve-str-strz-documentation.patch" Content-Transfer-Encoding: base64 RnJvbSBhY2M3NzE3ZGVlODVkYmFhYzY2YzNkZGM2NWVhOWRmZTYyYmJkYzIzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogVGh1LCAyIEp1biAyMDIyIDIxOjA1OjQwIC0wNDAwClN1YmplY3Q6IFtQ QVRDSCB2Ml0gYmluZGF0OiBJbXByb3ZlIHN0ciwgc3RyeiBkb2N1bWVudGF0aW9uCgoqIGRv Yy9saXNwcmVmL3Byb2Nlc3Nlcy50ZXhpIChCaW5kYXQgVHlwZXMpOiBFeHBhbmQgdGhlIGRv Y3VtZW50YXRpb24KZm9yIHRoZSBgc3RyJyBhbmQgYHN0cnonIHR5cGVzIHRvIGNsYXJpZnkg ZXhwZWN0YXRpb25zIGFuZCBleHBsYWluCmVkZ2UgY2FzZSBiZWhhdmlvci4KLS0tCiBkb2Mv bGlzcHJlZi9wcm9jZXNzZXMudGV4aSB8IDM3ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCAzIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL3Byb2Nlc3Nlcy50ZXhpIGIvZG9j L2xpc3ByZWYvcHJvY2Vzc2VzLnRleGkKaW5kZXggNjY4YTU3Nzg3MC4uMWY2YTllM2E3ZCAx MDA2NDQKLS0tIGEvZG9jL2xpc3ByZWYvcHJvY2Vzc2VzLnRleGkKKysrIGIvZG9jL2xpc3By ZWYvcHJvY2Vzc2VzLnRleGkKQEAgLTM0NzksMTEgKzM0NzksNDIgQEAgQmluZGF0IFR5cGVz CiBAdmFye2JpdGxlbn0gaGFzIHRvIGJlIGEgbXVsdGlwbGUgb2YgOC4KIAogQGl0ZW0gc3Ry IEB2YXJ7bGVufQotU3RyaW5nIG9mIGJ5dGVzIG9mIGxlbmd0aCBAdmFye2xlbn0uCitVbmli eXRlIHN0cmluZyBvZiBsZW5ndGggQHZhcntsZW59LiAgV2hlbiBwYWNraW5nLCB0aGUgZmly c3QgQHZhcntsZW59CitieXRlcyBvZiB0aGUgaW5wdXQgc3RyaW5nIGFyZSBjb3BpZWQgdG8g dGhlIHBhY2tlZCBvdXRwdXQuICBJZiB0aGUKK2lucHV0IHN0cmluZyBpcyBzaG9ydGVyIHRo YW4gQHZhcntsZW59LCB0aGUgcmVtYWluaW5nIGJ5dGVzIHdpbGwgYmUKK251bGwgKHplcm8p IHVubGVzcyBhIHByZS1hbGxvY2F0ZWQgc3RyaW5nIHdhcyBwcm92aWRlZCB0bworQGNvZGV7 YmluZGF0LXBhY2t9LCBpbiB3aGljaCBjYXNlIHRoZSByZW1haW5pbmcgYnl0ZXMgYXJlIGxl ZnQKK3VubW9kaWZpZWQuICBUaGUgaW5wdXQgc3RyaW5nIG11c3QgYmUgdW5pYnl0ZSAoQHB4 cmVme1RleHQKK1JlcHJlc2VudGF0aW9uc30pLiAgV2hlbiB1bnBhY2tpbmcsIGFueSBudWxs IGJ5dGVzIGluIHRoZSBwYWNrZWQgaW5wdXQKK3N0cmluZyB3aWxsIGFwcGVhciBpbiB0aGUg dW5wYWNrZWQgdW5pYnl0ZSBvdXRwdXQuCiAKIEBpdGVtIHN0cnogJm9wdGlvbmFsIEB2YXJ7 bGVufQotWmVyby10ZXJtaW5hdGVkIHN0cmluZyBvZiBieXRlcywgY2FuIGJlIG9mIGFyYml0 cmFyeSBsZW5ndGggb3IgaW4gYSBmaXhlZC1zaXplCi1maWVsZCB3aXRoIGxlbmd0aCBAdmFy e2xlbn0uCitJZiBAdmFye2xlbn0gaXMgbm90IHByb3ZpZGVkOiBWYXJpYWJsZS1sZW5ndGgg bnVsbC10ZXJtaW5hdGVkIHVuaWJ5dGUKK3N0cmluZy4gIFdoZW4gcGFja2luZywgdGhlIGVu dGlyZSBpbnB1dCBzdHJpbmcgaXMgY29waWVkIHRvIHRoZSBwYWNrZWQKK291dHB1dCBmb2xs b3dlZCBieSBhIG51bGwgYnl0ZS4gIFRoZSBsZW5ndGggb2YgdGhlIHBhY2tlZCBvdXRwdXQg aXMKK3RoZSBsZW5ndGggb2YgdGhlIGlucHV0IHN0cmluZyBwbHVzIG9uZSAoZm9yIHRoZSBh ZGRlZCBudWxsIGJ5dGUpLgorVGhlIGlucHV0IHN0cmluZyBtdXN0IGJlIHVuaWJ5dGUgKEBw eHJlZntUZXh0IFJlcHJlc2VudGF0aW9uc30pIGFuZAorbXVzdCBub3QgY29udGFpbiBhbnkg bnVsbCBieXRlcy4gIFdoZW4gdW5wYWNraW5nLCB0aGUgcmVzdWx0aW5nCit1bmlieXRlIHN0 cmluZyBjb250YWlucyBhbGwgYnl0ZXMgdXAgdG8gKGJ1dCBleGNsdWRpbmcpIHRoZSBudWxs IGJ5dGUuCisKK0lmIEB2YXJ7bGVufSBpcyBwcm92aWRlZDogQGNvZGV7c3Ryen0gYmVoYXZl cyB0aGUgc2FtZSBhcyBAY29kZXtzdHJ9Cit3aXRoIG9uZSBkaWZmZXJlbmNlOiBXaGVuIHVu cGFja2luZywgdGhlIGZpcnN0IG51bGwgYnl0ZSBlbmNvdW50ZXJlZAoraW4gdGhlIHBhY2tl ZCBzdHJpbmcgYW5kIGFsbCBzdWJzZXF1ZW50IGJ5dGVzIGFyZSBleGNsdWRlZCBmcm9tIHRo ZQordW5wYWNrZWQgcmVzdWx0LgorCitAcXVvdGF0aW9uIENhdXRpb24KK1RoZSBwYWNrZWQg b3V0cHV0IHdpbGwgbm90IGJlIG51bGwtdGVybWluYXRlZCB1bmxlc3Mgb25lIG9mIHRoZQor Zm9sbG93aW5nIGlzIHRydWU6CitAaXRlbWl6ZQorQGl0ZW0KK1RoZSBpbnB1dCBzdHJpbmcg aXMgc2hvcnRlciB0aGFuIEB2YXJ7bGVufSBhbmQgZWl0aGVyIG5vIHByZS1hbGxvY2F0ZWQK K3N0cmluZyB3YXMgcHJvdmlkZWQgdG8gQGNvZGV7YmluZGF0LXBhY2t9IG9yIHRoZSBhcHBy b3ByaWF0ZSBieXRlIGluCit0aGUgcHJlLWFsbG9jYXRlZCBzdHJpbmcgd2FzIGFscmVhZHkg bnVsbC4KK0BpdGVtCitUaGUgaW5wdXQgc3RyaW5nIGNvbnRhaW5zIGEgbnVsbCBieXRlIHdp dGhpbiB0aGUgZmlyc3QgQHZhcntsZW59CitieXRlcy4KK0BlbmQgaXRlbWl6ZQorQGVuZCBx dW90YXRpb24KIAogQGl0ZW0gdmVjIEB2YXJ7bGVufSBbQHZhcnt0eXBlfV0KIFZlY3RvciBv ZiBAdmFye2xlbn0gZWxlbWVudHMuICBUaGUgdHlwZSBvZiB0aGUgZWxlbWVudHMgaXMgZ2l2 ZW4gYnkKLS0gCjIuMzYuMQoK --------------pbmZ3pT3dNJ1P7veH5DFgOHv-- --------------y3vOCT6eAQRmQoWFcIX4eZPZ-- --------------rxJDk0XBuYWR5EdvDWBX4Zoi Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfoCctB7fyOzE09bW0GvrRa1X4hQFAmKejlgACgkQ0GvrRa1X 4hTE7A/+Jx4pAU0F4Ply/c1FDsShvC3azl84WqSLvshH1ytI8wlNTxZgGxwx9Hk7 JuH3utI9ADkglLFkmZYPLe/u2EwSWLa0AhuIzxWM/JuEoK7BVgUqXTcUCg5ETyFF f8Y36fUDVm/viGVrmNDgOoH2J+fRmqvk4YyJTDUWupmXGXXkGhO1xrg4zYxivjoW +1I7bqzJOj6Y3BNVE6TLxwxUDfRtAPYi1Y8wt6cjEuA08TwYwe5SsCsQlgspmCCQ lkEfxdAN9yxAsuS49JafWPQp9Lm+vs0qgDj7WLHo9a7s89aDMgiaA+8GxLHdw6t3 oE2gmFnLNVEV2h0kFtPWCOpwhPU1Hh4YIq4HVJFeXFrEBHZH4ngi3whMgk4VJ/No Zcu5MX5KlSM5h0mFfI26Vknthr07C3FaeLnsIgZF7e/qEhXa+o4WGJU33JvfbMlZ wpBYwIw8FjUVFjN+tlN1Mz0Lf4/zbglBz9rFLoDFA+z3BeDc06rE7gAWeQvEkbWS 8c20HKZRVNk9+2/24mugVaR9Ugwlv/9iVd5rQjDcntpXU2T7/tVxNAMBsclCcDSv vlB76auKFao1L+w/D1EvRTaqPttnsPT1e2dGYsKQZUqrLCrliwKkMAqwxlbgW8ko zedaJZorfVy5Mi1qnfl7Oo90xeg4M9GF6QhAqLULG8n2g249e98= =yaTl -----END PGP SIGNATURE----- --------------rxJDk0XBuYWR5EdvDWBX4Zoi-- From unknown Fri Aug 15 03:56:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55815: [PATCH] bindat: Improve str, strz documentation Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jun 2022 16:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55815 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Richard Hansen Cc: 55815@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 55815-submit@debbugs.gnu.org id=B55815.165461945125132 (code B ref 55815); Tue, 07 Jun 2022 16:31:02 +0000 Received: (at 55815) by debbugs.gnu.org; 7 Jun 2022 16:30:51 +0000 Received: from localhost ([127.0.0.1]:41261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyc6V-0006XI-CT for submit@debbugs.gnu.org; Tue, 07 Jun 2022 12:30:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyc6T-0006X1-FL for 55815@debbugs.gnu.org; Tue, 07 Jun 2022 12:30:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyc6L-0000UN-9N; Tue, 07 Jun 2022 12:30:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QjS7nlQoZmHazAzKUbR8q8OvPwz9g4m6It8pIxUh2U0=; b=XgncNs4+ZIWZ 38AwGyEsCmSnaWS7YXhnWbMbfouyMWZOB00Uv7LnyabZ6TAfeTbmrCMnBmhv8xaurXoMyOC6mqjS1 2v8X5yQOdSLY8Ud5Fzz3X0vnbJjHegVOXPNXQNH3+RS+HyeID0auTPIpw2hlMg3jii+BAq/bU7Vvj FfQK5LU+vLnIVFv7q2GlynSV90dltWicAFXuwnV98uMUvNgBguUn0NBe19VnrP8Xlhb3lYu1Q+OJh 8sCEnUOIntcXZWA4ASXt35LlvExh7D484IrSvikXqebEp6ILdqe5FXW49AqW5AtEH2Iy9R0i8h3ig tns2BKlXukPPIDXFZ9uC8Q==; Received: from [87.69.77.57] (port=3975 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyc6H-0002y0-1X; Tue, 07 Jun 2022 12:30:41 -0400 Date: Tue, 07 Jun 2022 19:30:25 +0300 Message-Id: <831qw077xa.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <13fe3d31-c2a7-f2ea-ba1a-305d5f5924ed@rhansen.org> (message from Richard Hansen on Mon, 6 Jun 2022 19:31:35 -0400) References: <3fc223d1-6dc0-6f59-1b27-d72dd8a3004e@rhansen.org> <83h74y83bz.fsf@gnu.org> <13fe3d31-c2a7-f2ea-ba1a-305d5f5924ed@rhansen.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 6 Jun 2022 19:31:35 -0400 > Cc: 55815@debbugs.gnu.org, monnier@iro.umontreal.ca > From: Richard Hansen > > > I think it is better to say > > > > Unibyte string that is @var{len} bytes long. > > Done. I may have gone overboard though -- I did so because there are three representations that matter: > > 1. The input string to be packed. > 2. The packed output. > 3. The result of unpacking. > > Right now all three of those are unibyte, but in a future patch I plan on changing the first to accept unibyte-convertible multibyte input strings. Not sure I understand: what do you mean by "unibyte-convertible multibyte input strings", and how do they differ from the other kinds? In any case, you say "unibyte input string" too many time, and that's unnecessary. One example: > +Unibyte string of length @var{len}. When packing, the first @var{len} > +bytes of the input string are copied to the packed output. If the > +input string is shorter than @var{len}, the remaining bytes will be > +null (zero) unless a pre-allocated string was provided to > +@code{bindat-pack}, in which case the remaining bytes are left > +unmodified. The input string must be unibyte (@pxref{Text Why do we need to say the input must be unibyte when we already said that up front? (There's more of this redundancy in the patch.) Stefan, any further comments? From unknown Fri Aug 15 03:56:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55815: [PATCH] bindat: Improve str, strz documentation Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jun 2022 18:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55815 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 55815@debbugs.gnu.org, Richard Hansen Received: via spool by 55815-submit@debbugs.gnu.org id=B55815.165462587728751 (code B ref 55815); Tue, 07 Jun 2022 18:18:01 +0000 Received: (at 55815) by debbugs.gnu.org; 7 Jun 2022 18:17:57 +0000 Received: from localhost ([127.0.0.1]:41448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nydm8-0007Tf-Ro for submit@debbugs.gnu.org; Tue, 07 Jun 2022 14:17:56 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nydm3-0007TO-Nr for 55815@debbugs.gnu.org; Tue, 07 Jun 2022 14:17:55 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6103E4426F8; Tue, 7 Jun 2022 14:17:46 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DA9CA4426F4; Tue, 7 Jun 2022 14:17:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654625864; bh=/k4MDq9+4rmLgPTbSLogVYsjMWpYDtNnaT0MMF04SMM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GV36hGTkBnAmnTOmineCZzbdAm1YCmDriapuVtPGdeD3TaCtwBvj8kjaqChBgjE6r e7zB/bwtyweAXhY9J9A0U7f/8a3e2etMQg3LTR9tULidA1R9tCnPUxWCr6x5rZ58ag 5bBwC4C64y3HbR5kyoQ47khPbd4129P2CzulDSNDLO9CQsoEk3CXU4pw/spz+1ahKN PQJyeXaHGfkiU9cU4wtpOkvJx2x1+dHD6OkzKpHBDjmjJ1uDM2HQavRkHrBSZ5MxTD Ei3G2IAICXiZ+DxAb7hvUFRKBIwPNS3DloJL+f4EO/4rlvEs8BaV8srwXWczYf9gtf OaD+0NTh4+cmQ== Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A9C5F120495; Tue, 7 Jun 2022 14:17:44 -0400 (EDT) From: Stefan Monnier Message-ID: References: <3fc223d1-6dc0-6f59-1b27-d72dd8a3004e@rhansen.org> <83h74y83bz.fsf@gnu.org> <13fe3d31-c2a7-f2ea-ba1a-305d5f5924ed@rhansen.org> <831qw077xa.fsf@gnu.org> Date: Tue, 07 Jun 2022 14:17:43 -0400 In-Reply-To: <831qw077xa.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 07 Jun 2022 19:30:25 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Stefan, any further comments? Nothign specific, no. The patch sounds good (it's important to clarify what kind of "zero-terminated strings" we're supporting). Stefan From unknown Fri Aug 15 03:56:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55815: [PATCH] bindat: Improve str, strz documentation Resent-From: Richard Hansen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jun 2022 04:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55815 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 55815@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 55815-submit@debbugs.gnu.org id=B55815.165466182331164 (code B ref 55815); Wed, 08 Jun 2022 04:18:02 +0000 Received: (at 55815) by debbugs.gnu.org; 8 Jun 2022 04:17:03 +0000 Received: from localhost ([127.0.0.1]:42187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyn7t-00086L-Rt for submit@debbugs.gnu.org; Wed, 08 Jun 2022 00:17:03 -0400 Received: from spork.scientician.org ([66.228.35.160]:40054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyn7o-000864-K1 for 55815@debbugs.gnu.org; Wed, 08 Jun 2022 00:17:00 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id 0FCA94A1AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1654661816; bh=Nmrgt0WJBLoKzY6Z40utCmrjEPgS/knQi/uPjsOMlzc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fhzRhh+xs+dY36VMqdT9i3qKtBKZ59fsuLU4E27l1YFoBAnTZ2NEB7RYuQiccFp90 HZo7vMtXm03Yv66ALJOQvLDgPzkD/tLS66mXShi/cquoU2BlVeEYRvtqRp2OdxSHeo Yvhfzq9H7tN+BQ3eK2OrTPXhee06ZyJzGDvHBwBc= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id 40A6E201AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1654661814; bh=Nmrgt0WJBLoKzY6Z40utCmrjEPgS/knQi/uPjsOMlzc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HMMHqvngB1D6roiZgGHhtTQ0xVaVb/JyYmSydusNuCA6u4v05Nf0q98l29KSo/16A b1zVs2GUm+Ov9AnUlsAsXLh5xmDsMxRllQxcbjhP5AZbQqVMSu64dJLcG2kidbvVsT 9YVbWsTXwpnsrtIrsNoY/dAhn8B5KZ2qrlZL4bVs= Message-ID: <5bcd8ca9-4be6-5aa4-ac63-b65a89c97b39@rhansen.org> Date: Wed, 8 Jun 2022 00:16:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US References: <3fc223d1-6dc0-6f59-1b27-d72dd8a3004e@rhansen.org> <83h74y83bz.fsf@gnu.org> <13fe3d31-c2a7-f2ea-ba1a-305d5f5924ed@rhansen.org> <831qw077xa.fsf@gnu.org> From: Richard Hansen In-Reply-To: <831qw077xa.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------6Yvmhr8VqlYL200r5wLWKD7y" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------6Yvmhr8VqlYL200r5wLWKD7y Content-Type: multipart/mixed; boundary="------------fIodNWQ8ohyDNPv0ydtuf7kC"; protected-headers="v1" From: Richard Hansen To: Eli Zaretskii Cc: 55815@debbugs.gnu.org, monnier@iro.umontreal.ca Message-ID: <5bcd8ca9-4be6-5aa4-ac63-b65a89c97b39@rhansen.org> Subject: Re: bug#55815: [PATCH] bindat: Improve str, strz documentation References: <3fc223d1-6dc0-6f59-1b27-d72dd8a3004e@rhansen.org> <83h74y83bz.fsf@gnu.org> <13fe3d31-c2a7-f2ea-ba1a-305d5f5924ed@rhansen.org> <831qw077xa.fsf@gnu.org> In-Reply-To: <831qw077xa.fsf@gnu.org> --------------fIodNWQ8ohyDNPv0ydtuf7kC Content-Type: multipart/mixed; boundary="------------c8cc7Mi9ENNbZesIVn301Lp2" --------------c8cc7Mi9ENNbZesIVn301Lp2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gNi83LzIyIDEyOjMwLCBFbGkgWmFyZXRza2lpIHdyb3RlOg0KPj4gUmlnaHQgbm93IGFs bCB0aHJlZSBvZiB0aG9zZSBhcmUgdW5pYnl0ZSwgYnV0IGluIGEgZnV0dXJlIHBhdGNoIEkg DQo+PiBwbGFuIG9uIGNoYW5naW5nIHRoZSBmaXJzdCB0byBhY2NlcHQgdW5pYnl0ZS1jb252 ZXJ0aWJsZSBtdWx0aWJ5dGUgDQo+PiBpbnB1dCBzdHJpbmdzLg0KPiANCj4gTm90IHN1cmUg SSB1bmRlcnN0YW5kOiB3aGF0IGRvIHlvdSBtZWFuIGJ5ICJ1bmlieXRlLWNvbnZlcnRpYmxl IA0KPiBtdWx0aWJ5dGUgaW5wdXQgc3RyaW5ncyIsIGFuZCBob3cgZG8gdGhleSBkaWZmZXIg ZnJvbSB0aGUgb3RoZXIga2luZHM/DQoNCkkgbWVhbiBtdWx0aWJ5dGUgc3RyaW5ncyB0aGF0 IGRvIG5vdCBjb250YWluIGNoYXJhY3RlcnMgdGhhdCB3aWxsIGNhdXNlIHN0cmluZy10by11 bmlieXRlIHRvIHNpZ25hbCBhbiBlcnJvci4NCg0KPiBJbiBhbnkgY2FzZSwgeW91IHNheSAi dW5pYnl0ZSBpbnB1dCBzdHJpbmciIHRvbyBtYW55IHRpbWUsIGFuZCB0aGF0J3MgDQo+IHVu bmVjZXNzYXJ5Lg0KDQpEb25lLCBzZWUgYXR0YWNoZWQuDQo= --------------c8cc7Mi9ENNbZesIVn301Lp2 Content-Type: text/x-patch; charset=UTF-8; name="v3-0001-bindat-Improve-str-strz-documentation.patch" Content-Disposition: attachment; filename="v3-0001-bindat-Improve-str-strz-documentation.patch" Content-Transfer-Encoding: base64 RnJvbSAwODliMGU1NGU4NjhlMGMyOGIyNjJkNmIwOWEyZDZhZjMyMmVhMzFlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogVGh1LCAyIEp1biAyMDIyIDIxOjA1OjQwIC0wNDAwClN1YmplY3Q6IFtQ QVRDSCB2M10gYmluZGF0OiBJbXByb3ZlIHN0ciwgc3RyeiBkb2N1bWVudGF0aW9uCgoqIGRv Yy9saXNwcmVmL3Byb2Nlc3Nlcy50ZXhpIChCaW5kYXQgVHlwZXMpOiBFeHBhbmQgdGhlIGRv Y3VtZW50YXRpb24KZm9yIHRoZSBgc3RyJyBhbmQgYHN0cnonIHR5cGVzIHRvIGNsYXJpZnkg ZXhwZWN0YXRpb25zIGFuZCBleHBsYWluCmVkZ2UgY2FzZSBiZWhhdmlvci4KLS0tCiBkb2Mv bGlzcHJlZi9wcm9jZXNzZXMudGV4aSB8IDM2ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvcHJvY2Vzc2VzLnRleGkgYi9kb2Mv bGlzcHJlZi9wcm9jZXNzZXMudGV4aQppbmRleCA2NjhhNTc3ODcwLi5hOTNhNjE3YzhhIDEw MDY0NAotLS0gYS9kb2MvbGlzcHJlZi9wcm9jZXNzZXMudGV4aQorKysgYi9kb2MvbGlzcHJl Zi9wcm9jZXNzZXMudGV4aQpAQCAtMzQ3OSwxMSArMzQ3OSw0MSBAQCBCaW5kYXQgVHlwZXMK IEB2YXJ7Yml0bGVufSBoYXMgdG8gYmUgYSBtdWx0aXBsZSBvZiA4LgogCiBAaXRlbSBzdHIg QHZhcntsZW59Ci1TdHJpbmcgb2YgYnl0ZXMgb2YgbGVuZ3RoIEB2YXJ7bGVufS4KK1VuaWJ5 dGUgc3RyaW5nIChAcHhyZWZ7VGV4dCBSZXByZXNlbnRhdGlvbnN9KSBvZiBsZW5ndGggQHZh cntsZW59LgorV2hlbiBwYWNraW5nLCB0aGUgZmlyc3QgQHZhcntsZW59IGJ5dGVzIG9mIHRo ZSBpbnB1dCBzdHJpbmcgYXJlIGNvcGllZAordG8gdGhlIHBhY2tlZCBvdXRwdXQuICBJZiB0 aGUgaW5wdXQgc3RyaW5nIGlzIHNob3J0ZXIgdGhhbiBAdmFye2xlbn0sCit0aGUgcmVtYWlu aW5nIGJ5dGVzIHdpbGwgYmUgbnVsbCAoemVybykgdW5sZXNzIGEgcHJlLWFsbG9jYXRlZCBz dHJpbmcKK3dhcyBwcm92aWRlZCB0byBAY29kZXtiaW5kYXQtcGFja30sIGluIHdoaWNoIGNh c2UgdGhlIHJlbWFpbmluZyBieXRlcworYXJlIGxlZnQgdW5tb2RpZmllZC4gIFdoZW4gdW5w YWNraW5nLCBhbnkgbnVsbCBieXRlcyBpbiB0aGUgcGFja2VkCitpbnB1dCBzdHJpbmcgd2ls bCBhcHBlYXIgaW4gdGhlIHVucGFja2VkIG91dHB1dC4KIAogQGl0ZW0gc3RyeiAmb3B0aW9u YWwgQHZhcntsZW59Ci1aZXJvLXRlcm1pbmF0ZWQgc3RyaW5nIG9mIGJ5dGVzLCBjYW4gYmUg b2YgYXJiaXRyYXJ5IGxlbmd0aCBvciBpbiBhIGZpeGVkLXNpemUKLWZpZWxkIHdpdGggbGVu Z3RoIEB2YXJ7bGVufS4KK0lmIEB2YXJ7bGVufSBpcyBub3QgcHJvdmlkZWQ6IFZhcmlhYmxl LWxlbmd0aCBudWxsLXRlcm1pbmF0ZWQgdW5pYnl0ZQorc3RyaW5nIChAcHhyZWZ7VGV4dCBS ZXByZXNlbnRhdGlvbnN9KS4gIFdoZW4gcGFja2luZywgdGhlIGVudGlyZSBpbnB1dAorc3Ry aW5nIGlzIGNvcGllZCB0byB0aGUgcGFja2VkIG91dHB1dCBmb2xsb3dlZCBieSBhIG51bGwg Ynl0ZS4gIFRoZQorbGVuZ3RoIG9mIHRoZSBwYWNrZWQgb3V0cHV0IGlzIHRoZSBsZW5ndGgg b2YgdGhlIGlucHV0IHN0cmluZyBwbHVzIG9uZQorKGZvciB0aGUgYWRkZWQgbnVsbCBieXRl KS4gIFRoZSBpbnB1dCBzdHJpbmcgbXVzdCBub3QgY29udGFpbiBhbnkgbnVsbAorYnl0ZXMu ICBXaGVuIHVucGFja2luZywgdGhlIHJlc3VsdGluZyBzdHJpbmcgY29udGFpbnMgYWxsIGJ5 dGVzIHVwIHRvCisoYnV0IGV4Y2x1ZGluZykgdGhlIG51bGwgYnl0ZS4KKworSWYgQHZhcnts ZW59IGlzIHByb3ZpZGVkOiBAY29kZXtzdHJ6fSBiZWhhdmVzIHRoZSBzYW1lIGFzIEBjb2Rl e3N0cn0KK3dpdGggb25lIGRpZmZlcmVuY2U6IFdoZW4gdW5wYWNraW5nLCB0aGUgZmlyc3Qg bnVsbCBieXRlIGVuY291bnRlcmVkCitpbiB0aGUgcGFja2VkIHN0cmluZyBhbmQgYWxsIHN1 YnNlcXVlbnQgYnl0ZXMgYXJlIGV4Y2x1ZGVkIGZyb20gdGhlCit1bnBhY2tlZCByZXN1bHQu CisKK0BxdW90YXRpb24gQ2F1dGlvbgorVGhlIHBhY2tlZCBvdXRwdXQgd2lsbCBub3QgYmUg bnVsbC10ZXJtaW5hdGVkIHVubGVzcyBvbmUgb2YgdGhlCitmb2xsb3dpbmcgaXMgdHJ1ZToK K0BpdGVtaXplCitAaXRlbQorVGhlIGlucHV0IHN0cmluZyBpcyBzaG9ydGVyIHRoYW4gQHZh cntsZW59IGFuZCBlaXRoZXIgbm8gcHJlLWFsbG9jYXRlZAorc3RyaW5nIHdhcyBwcm92aWRl ZCB0byBAY29kZXtiaW5kYXQtcGFja30gb3IgdGhlIGFwcHJvcHJpYXRlIGJ5dGUgaW4KK3Ro ZSBwcmUtYWxsb2NhdGVkIHN0cmluZyB3YXMgYWxyZWFkeSBudWxsLgorQGl0ZW0KK1RoZSBp bnB1dCBzdHJpbmcgY29udGFpbnMgYSBudWxsIGJ5dGUgd2l0aGluIHRoZSBmaXJzdCBAdmFy e2xlbn0KK2J5dGVzLgorQGVuZCBpdGVtaXplCitAZW5kIHF1b3RhdGlvbgogCiBAaXRlbSB2 ZWMgQHZhcntsZW59IFtAdmFye3R5cGV9XQogVmVjdG9yIG9mIEB2YXJ7bGVufSBlbGVtZW50 cy4gIFRoZSB0eXBlIG9mIHRoZSBlbGVtZW50cyBpcyBnaXZlbiBieQotLSAKMi4zNi4xCgo= --------------c8cc7Mi9ENNbZesIVn301Lp2-- --------------fIodNWQ8ohyDNPv0ydtuf7kC-- --------------6Yvmhr8VqlYL200r5wLWKD7y Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfoCctB7fyOzE09bW0GvrRa1X4hQFAmKgIrQACgkQ0GvrRa1X 4hS3Tg/+KaV7VZXBn1b5pUEDxl48fiRB6qI0t30SfnMWRbI6vYAMIhtFkeuLsDuZ wZc8ns8+Sw6QlDH1PZkwo100ThJgxAkdbAm3e9VBofHvPTlpHtj0/Hwu62cS6zdr 8mEy0QGHxjfYgJw8Nh4QeyvDDdcFwt22/JhW3h7ZhgEkCa4tK/vMa6xdoHFVLICS av5Q5hAshsnuDNAuzETcBoubbiRAPmC8fU0tuRccgZT5hGmoV51qa9+RIe5qQPB/ eTrf7O/NVtZP7GOkwn9bZgqbxoKdV61NMmDqrMSrkKuDckLPwP2lcbyv3oT9Ze8R tXDsPfdWc5NaydrMf4SKWefEjm4yhskOFBwZMfme8cBqwtzk3y9xugWk9ZpYmS0L DBPAAvfloYBMUSaeofWJySFUMoxtVKXDNegKmsd5FjGGuUpu5fswX6DbX2LnkAH4 faf4ovTIuxSj1fWsty/zi6XlcpEm4YJVqRuQzlji9llpZLGalkroDYsuFGz59sfn FlENwTaICjjz+goXvishPpqWr2AK/sG75HV5JW3mQgbbFpkYDaXcBPO0QQo6IuQ+ reArVoUqol7tLRaf2TcX/ggAaWc9ubBjAAaxOEmT+r8XH8L8c6zpEHHWDZWBXQek 7acKBu69FFzygnz4k+T3JTrjShrxK/Xs2hp64VZbOUAE2e57bb8= =gA/F -----END PGP SIGNATURE----- --------------6Yvmhr8VqlYL200r5wLWKD7y-- From unknown Fri Aug 15 03:56:16 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Richard Hansen Subject: bug#55815: closed (Re: bug#55815: [PATCH] bindat: Improve str, strz documentation) Message-ID: References: <838rq647l1.fsf@gnu.org> <3fc223d1-6dc0-6f59-1b27-d72dd8a3004e@rhansen.org> X-Gnu-PR-Message: they-closed 55815 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 55815@debbugs.gnu.org Date: Thu, 09 Jun 2022 07:31:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1654759862-12062-1" This is a multi-part message in MIME format... ------------=_1654759862-12062-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55815: [PATCH] bindat: Improve str, strz documentation which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55815@debbugs.gnu.org. --=20 55815: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55815 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1654759862-12062-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55815-done) by debbugs.gnu.org; 9 Jun 2022 07:30:54 +0000 Received: from localhost ([127.0.0.1]:44861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzCd4-00038F-FB for submit@debbugs.gnu.org; Thu, 09 Jun 2022 03:30:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzCd3-000381-Fz for 55815-done@debbugs.gnu.org; Thu, 09 Jun 2022 03:30:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzCcw-0007c1-KX; Thu, 09 Jun 2022 03:30:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=H2SLJc9JJrpJtVijZFNwo68llYRwOrCedErHfDFh3xY=; b=bzCOuOI/aVbi 4oTmT5y2F0D8bM3IHO8QrwoeIvMFG94ZJRVQH/maKNDUrh4m8farJ22gmGMnlM4uwrreNvzmx55Y9 ewjYCkFn9mLdtbcCOovQ+NkPZHA+y6f3mXSSokIOtOD8baWZN9QIs4/JTFhfUcpMrtyL65qVpjsXz u/hSc4AeRwWJwr6ToyIzIWrDIdlBrFQ7y6BazCkId+GrApsD5TmKGW3sDPVEX9HCQopgMAt+Ul2Gt Dw1ZMmilPDoxdGfdJGEf5gAPUvcQQ60a2z/TX8b/NOe0/JTuJmQL/gc3dyBPTf9vKK6USmgA9X06k HcOqU3ATaUVk2WBt9kT1kg==; Received: from [87.69.77.57] (port=1172 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzCcn-0004do-Uk; Thu, 09 Jun 2022 03:30:44 -0400 Date: Thu, 09 Jun 2022 10:30:34 +0300 Message-Id: <838rq647l1.fsf@gnu.org> From: Eli Zaretskii To: Richard Hansen In-Reply-To: <5bcd8ca9-4be6-5aa4-ac63-b65a89c97b39@rhansen.org> (message from Richard Hansen on Wed, 8 Jun 2022 00:16:51 -0400) Subject: Re: bug#55815: [PATCH] bindat: Improve str, strz documentation References: <3fc223d1-6dc0-6f59-1b27-d72dd8a3004e@rhansen.org> <83h74y83bz.fsf@gnu.org> <13fe3d31-c2a7-f2ea-ba1a-305d5f5924ed@rhansen.org> <831qw077xa.fsf@gnu.org> <5bcd8ca9-4be6-5aa4-ac63-b65a89c97b39@rhansen.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55815-done Cc: 55815-done@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 8 Jun 2022 00:16:51 -0400 > Cc: 55815@debbugs.gnu.org, monnier@iro.umontreal.ca > From: Richard Hansen > > On 6/7/22 12:30, Eli Zaretskii wrote: > >> Right now all three of those are unibyte, but in a future patch I > >> plan on changing the first to accept unibyte-convertible multibyte > >> input strings. > > > > Not sure I understand: what do you mean by "unibyte-convertible > > multibyte input strings", and how do they differ from the other kinds? > > I mean multibyte strings that do not contain characters that will cause string-to-unibyte to signal an error. IOW, multibyte strings that contain only ASCII characters and characters of the 'eight-bit' charset. > > In any case, you say "unibyte input string" too many time, and that's > > unnecessary. > > Done, see attached. Thanks, installed. ------------=_1654759862-12062-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Jun 2022 02:22:08 +0000 Received: from localhost ([127.0.0.1]:33998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ny2Nc-0002Dj-7x for submit@debbugs.gnu.org; Sun, 05 Jun 2022 22:22:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:36454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ny2Na-0002Da-8N for submit@debbugs.gnu.org; Sun, 05 Jun 2022 22:22:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ny2NZ-0003ey-U6 for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 22:22:06 -0400 Received: from spork.scientician.org ([2600:3c03:e000:66::1]:48911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ny2NX-0006wj-R3 for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 22:22:05 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id 1A23D47F45 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1654482122; bh=Jj13ab1AvtAg4S+dh2pKbTaPpYCC8GOFSkvTKWXjDGc=; h=Date:To:From:Subject:From; b=OK1mkhCRU0H+lbiaVq2ve3H2xFmRreHWbSsjhh5hLfhfLgDjYdW5y6yCU2mL+G8xU 9OlcHS62G+VsZWy+4yaHTmIAatwSc+YL3+EhfJ5/V0l46x7MvoMd+Van+vn5JtUDXU 6CG/QaneecBprVbvoOBm7q2faWdd3BrYGX88CNCE= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id D0718201AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1654482120; bh=Jj13ab1AvtAg4S+dh2pKbTaPpYCC8GOFSkvTKWXjDGc=; h=Date:To:From:Subject:From; b=hQMJkozPtnYEd3+r9h1nNl0rHn2Kwta3JSOgCbsAVkaVn1XJjofQ2Ms2R9ouUMKop H9TujmKKFq14L8s4qnsjmWsX273s3z2ZLpKOvvFJaR6NLdowOmF0fh/trRqACIJdvz Yc96/VhdPDBXQstcUI86DQ8gX0ZZeJkus60VHfYI= Content-Type: multipart/mixed; boundary="------------GIIlSDw95bYa075mDCrL8JGM" Message-ID: <3fc223d1-6dc0-6f59-1b27-d72dd8a3004e@rhansen.org> Date: Sun, 5 Jun 2022 22:22:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Richard Hansen Subject: [PATCH] bindat: Improve str, strz documentation Received-SPF: pass client-ip=2600:3c03:e000:66::1; envelope-from=rhansen@rhansen.org; helo=spork.scientician.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------GIIlSDw95bYa075mDCrL8JGM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Debbugs-CC: monnier@iro.umontreal.ca * doc/lispref/processes.texi (Bindat Types): Expand the documentation for the `str' and `strz' types to clarify expectations and explain edge case behavior. --- doc/lispref/processes.texi | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/doc/lispref/processes.texi b/doc/lispref/processes.texi index 668a577870..68621d32a8 100644 --- a/doc/lispref/processes.texi +++ b/doc/lispref/processes.texi @@ -3479,11 +3479,31 @@ Bindat Types @var{bitlen} has to be a multiple of 8. @item str @var{len} -String of bytes of length @var{len}. +String of length @var{len}. When packing, the first @var{len} bytes +of the input string are copied to the packed output. If the input +string is shorter than @var{len}, the remaining bytes are set to zero. +The input string must be unibyte (@pxref{Text Representations}). When +unpacking, any zero bytes in the packed input string will appear in +the unpacked output. @item strz &optional @var{len} -Zero-terminated string of bytes, can be of arbitrary length or in a fixed-size -field with length @var{len}. +If @var{len} is not provided: Variable-length null-terminated string. +When packing, the entire input string is copied to the packed output +followed by a zero byte (null terminator). The input string must be +unibyte (@pxref{Text Representations}) and must not contain any zero +bytes. When unpacking, the resulting string contains all bytes up to +(but excluding) the null terminator. + +If @var{len} is provided: @code{strz} behaves the same as @code{str} +with one difference. When unpacking, the first zero byte (null +terminator) encountered in the packed string and all subsequent bytes +are excluded from the unpacked result. + +@quotation Caution +The packed output will not be null-terminated unless the input string +is shorter than @var{len} or it contains a zero byte within the first +@var{len} bytes. +@end quotation @item vec @var{len} [@var{type}] Vector of @var{len} elements. The type of the elements is given by -- 2.36.1 --------------GIIlSDw95bYa075mDCrL8JGM Content-Type: text/x-patch; charset=UTF-8; name="0001-bindat-Improve-str-strz-documentation.patch" Content-Disposition: attachment; filename="0001-bindat-Improve-str-strz-documentation.patch" Content-Transfer-Encoding: base64 RnJvbSAzMjllYzM2NTBjMGNjYzhhMDFiZDYxOTY4MDVkNTEzNjIxOGVmMzkxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogVGh1LCAyIEp1biAyMDIyIDIxOjA1OjQwIC0wNDAwClN1YmplY3Q6IFtQ QVRDSF0gYmluZGF0OiBJbXByb3ZlIHN0ciwgc3RyeiBkb2N1bWVudGF0aW9uCgoqIGRvYy9s aXNwcmVmL3Byb2Nlc3Nlcy50ZXhpIChCaW5kYXQgVHlwZXMpOiBFeHBhbmQgdGhlIGRvY3Vt ZW50YXRpb24KZm9yIHRoZSBgc3RyJyBhbmQgYHN0cnonIHR5cGVzIHRvIGNsYXJpZnkgZXhw ZWN0YXRpb25zIGFuZCBleHBsYWluCmVkZ2UgY2FzZSBiZWhhdmlvci4KLS0tCiBkb2MvbGlz cHJlZi9wcm9jZXNzZXMudGV4aSB8IDI2ICsrKysrKysrKysrKysrKysrKysrKysrLS0tCiAx IGZpbGUgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9kb2MvbGlzcHJlZi9wcm9jZXNzZXMudGV4aSBiL2RvYy9saXNwcmVmL3Byb2Nl c3Nlcy50ZXhpCmluZGV4IDY2OGE1Nzc4NzAuLjY4NjIxZDMyYTggMTAwNjQ0Ci0tLSBhL2Rv Yy9saXNwcmVmL3Byb2Nlc3Nlcy50ZXhpCisrKyBiL2RvYy9saXNwcmVmL3Byb2Nlc3Nlcy50 ZXhpCkBAIC0zNDc5LDExICszNDc5LDMxIEBAIEJpbmRhdCBUeXBlcwogQHZhcntiaXRsZW59 IGhhcyB0byBiZSBhIG11bHRpcGxlIG9mIDguCiAKIEBpdGVtIHN0ciBAdmFye2xlbn0KLVN0 cmluZyBvZiBieXRlcyBvZiBsZW5ndGggQHZhcntsZW59LgorU3RyaW5nIG9mIGxlbmd0aCBA dmFye2xlbn0uICBXaGVuIHBhY2tpbmcsIHRoZSBmaXJzdCBAdmFye2xlbn0gYnl0ZXMKK29m IHRoZSBpbnB1dCBzdHJpbmcgYXJlIGNvcGllZCB0byB0aGUgcGFja2VkIG91dHB1dC4gIElm IHRoZSBpbnB1dAorc3RyaW5nIGlzIHNob3J0ZXIgdGhhbiBAdmFye2xlbn0sIHRoZSByZW1h aW5pbmcgYnl0ZXMgYXJlIHNldCB0byB6ZXJvLgorVGhlIGlucHV0IHN0cmluZyBtdXN0IGJl IHVuaWJ5dGUgKEBweHJlZntUZXh0IFJlcHJlc2VudGF0aW9uc30pLiAgV2hlbgordW5wYWNr aW5nLCBhbnkgemVybyBieXRlcyBpbiB0aGUgcGFja2VkIGlucHV0IHN0cmluZyB3aWxsIGFw cGVhciBpbgordGhlIHVucGFja2VkIG91dHB1dC4KIAogQGl0ZW0gc3RyeiAmb3B0aW9uYWwg QHZhcntsZW59Ci1aZXJvLXRlcm1pbmF0ZWQgc3RyaW5nIG9mIGJ5dGVzLCBjYW4gYmUgb2Yg YXJiaXRyYXJ5IGxlbmd0aCBvciBpbiBhIGZpeGVkLXNpemUKLWZpZWxkIHdpdGggbGVuZ3Ro IEB2YXJ7bGVufS4KK0lmIEB2YXJ7bGVufSBpcyBub3QgcHJvdmlkZWQ6IFZhcmlhYmxlLWxl bmd0aCBudWxsLXRlcm1pbmF0ZWQgc3RyaW5nLgorV2hlbiBwYWNraW5nLCB0aGUgZW50aXJl IGlucHV0IHN0cmluZyBpcyBjb3BpZWQgdG8gdGhlIHBhY2tlZCBvdXRwdXQKK2ZvbGxvd2Vk IGJ5IGEgemVybyBieXRlIChudWxsIHRlcm1pbmF0b3IpLiAgVGhlIGlucHV0IHN0cmluZyBt dXN0IGJlCit1bmlieXRlIChAcHhyZWZ7VGV4dCBSZXByZXNlbnRhdGlvbnN9KSBhbmQgbXVz dCBub3QgY29udGFpbiBhbnkgemVybworYnl0ZXMuICBXaGVuIHVucGFja2luZywgdGhlIHJl c3VsdGluZyBzdHJpbmcgY29udGFpbnMgYWxsIGJ5dGVzIHVwIHRvCisoYnV0IGV4Y2x1ZGlu ZykgdGhlIG51bGwgdGVybWluYXRvci4KKworSWYgQHZhcntsZW59IGlzIHByb3ZpZGVkOiBA Y29kZXtzdHJ6fSBiZWhhdmVzIHRoZSBzYW1lIGFzIEBjb2Rle3N0cn0KK3dpdGggb25lIGRp ZmZlcmVuY2UuIFdoZW4gdW5wYWNraW5nLCB0aGUgZmlyc3QgemVybyBieXRlIChudWxsCit0 ZXJtaW5hdG9yKSBlbmNvdW50ZXJlZCBpbiB0aGUgcGFja2VkIHN0cmluZyBhbmQgYWxsIHN1 YnNlcXVlbnQgYnl0ZXMKK2FyZSBleGNsdWRlZCBmcm9tIHRoZSB1bnBhY2tlZCByZXN1bHQu CisKK0BxdW90YXRpb24gQ2F1dGlvbgorVGhlIHBhY2tlZCBvdXRwdXQgd2lsbCBub3QgYmUg bnVsbC10ZXJtaW5hdGVkIHVubGVzcyB0aGUgaW5wdXQgc3RyaW5nCitpcyBzaG9ydGVyIHRo YW4gQHZhcntsZW59IG9yIGl0IGNvbnRhaW5zIGEgemVybyBieXRlIHdpdGhpbiB0aGUgZmly c3QKK0B2YXJ7bGVufSBieXRlcy4KK0BlbmQgcXVvdGF0aW9uCiAKIEBpdGVtIHZlYyBAdmFy e2xlbn0gW0B2YXJ7dHlwZX1dCiBWZWN0b3Igb2YgQHZhcntsZW59IGVsZW1lbnRzLiAgVGhl IHR5cGUgb2YgdGhlIGVsZW1lbnRzIGlzIGdpdmVuIGJ5Ci0tIAoyLjM2LjEKCg== --------------GIIlSDw95bYa075mDCrL8JGM-- ------------=_1654759862-12062-1--