GNU bug report logs - #55811
29.0.50; No flymake diagnostics for no-byte-compile files

Previous Next

Full log

View this message in rfc822 format

From: Ship Mints <shipmints <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, João Távora <joaotavora <at> gmail.com>, 55811 <at> debbugs.gnu.org
Subject: bug#55811: 29.0.50; No flymake diagnostics for no-byte-compile files
Date: Tue, 21 Jan 2025 20:16:49 -0500

[Message part 1 (text/plain, inline)]

Sorry I wasn't clear. Joao's suggestion will not work.

elisp-flymake--batch-compile-for-flymake invokes byte-compile-file in a
subprocess which loads the input file into a fresh buffer with reset buffer
locals, negating the parent-process call-site patch's intention.

Disabling no-byte-compile has to happen in
elisp-flymake--batch-compile-for-flymake to influence byte-compile-file.
I've used a new defvar to let bind in the spirit
of bytecomp--inhibit-lexical-cookie-warning.

I've attached a patch that works for me, along with an appropriate commit
log message.

-Stephane

On Tue, Jan 21, 2025 at 5:07 PM Stefan Monnier <monnier <at> iro.umontreal.ca>
wrote:

> > Would be great to adopt the simple flymake change in master,
>
> Do I understand correctly that you tried it and it worked for you?
>
>
>         Stefan
>
>

[Message part 2 (text/html, inline)]

[0001-elisp-flymake-batch-compile-for-flymake-ignore-no-by.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.