GNU bug report logs - #55782
[PATCH] Add support for the Grantha script

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55782 in the body.
You can then email your comments to 55782 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add support for the Grantha script
Date: Fri, 3 Jun 2022 18:21:08 +0530

[Message part 1 (text/plain, inline)]

This time the beautiful Grantha script is added to Emacs.

Please review the patch.
Thank You.

[Message part 2 (text/html, inline)]

[0001-Add-support-for-the-Grantha-script.patch (text/x-patch, attachment)]

Message #8 received at 55782 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 55782 <at> debbugs.gnu.org
Subject: Re: bug#55782: [PATCH] Add support for the Grantha script
Date: Fri, 03 Jun 2022 16:31:09 +0300

> From: समीर सिंह Sameer Singh
>  <lumarzeli30 <at> gmail.com>
> Date: Fri, 3 Jun 2022 18:21:08 +0530
> 
> Add tamil supplement codepoints to (tamil).
[...]
> -	(tamil #xB95)
> +	(tamil #xB95 #x11FC0 #x11FC6)

This part is IMO a mistake: since there are no known fonts that
support both the Tamil block and the Tamil Supplement block, adding
the characters from the Supplement block to
script-representative-chars might cause Emacs to reject a good Tamil
font because it doesn't support the character from the Supplement
block.  We could use a vector instead of a list, but even that could
cause undesired consequences, whereby Emacs selects a font for Tamil
characters when it only supports Tamil Supplement, or vice versa.

I think adding Noto Sans Tamil Supplement to the default fontset is
for now the most we can do about the Tamil Supplement block.

> +(set-language-info-alist
> + "Grantha" '((charset unicode)
> +             (coding-system utf-8)
> +             (coding-priority utf-8)
> +             (input-method . "grantha")
> +             (sample-text . "Grantha (𑌗𑍍𑌰𑌨𑍍𑌥)	𑌨𑌮𑌸𑍍𑌤𑍇")
> +             (documentation . "\
> +Languages such as Sanskrit and Manipravalam which uses the
                                                     ^^^^
"use", in plural.

Also, "which use" is slightly misleading, I think: at least Sanskrit
also uses other scripts, doesn't it?  If so, I'd suggest saying "when
they use the Grantha script" instead.

> +;; Grantha composition rules
> +(let ((consonant            "[\x11315-\x11339]")
> +      (nukta                "\x1133C")
> +      (independent-vowel    "[\x11305-\x11314\x11360\x11361]")
> +      (vowel                "[\x1133E-\x1134C\x11357\x11362\x11363]")
> +      (nasal                "[\x11300-\x11302]")
> +      (bindu                "\x1133B")
> +      (visarga              "\x11303")
> +      (virama               "\x1134D")
> +      (avagraha             "\x1133D")
> +      (modifier-above       "[\x11366-\x11374]"))
> +  (set-char-table-range composition-function-table
> +                        '(#x1133B . #x1134D)
> +                        (list (vector
> +                               ;; Consonant based syllables
> +                               (concat consonant nukta "?" "\\(?:" virama consonant nukta
> +                                       "?\\)*\\(?:" virama "\\|" vowel "*" nukta "?" nasal
> +                                       "?" bindu "?" visarga "?" modifier-above "?"
> +                                       avagraha "?\\)")
> +                               1 'font-shape-gstring)

Some sequences that match the regexp will not be composed, according
to this rule.  For example, the sequence

   consonant vowel

won't be composed, because its second character is not in the range
'(#x1133B . #x1134D).  Is that okay?  Or are you relying on the
default composition of combining characters?

Thanks.

Message #11 received at 55782 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55782 <at> debbugs.gnu.org
Subject: Re: bug#55782: [PATCH] Add support for the Grantha script
Date: Fri, 3 Jun 2022 19:40:30 +0530

[Message part 1 (text/plain, inline)]

>
> This part is IMO a mistake: since there are no known fonts that
> support both the Tamil block and the Tamil Supplement block, adding
> the characters from the Supplement block to
> script-representative-chars might cause Emacs to reject a good Tamil
> font because it doesn't support the character from the Supplement
> block.  We could use a vector instead of a list, but even that could
> cause undesired consequences, whereby Emacs selects a font for Tamil
> characters when it only supports Tamil Supplement, or vice versa.
>
> I think adding Noto Sans Tamil Supplement to the default fontset is
> for now the most we can do about the Tamil Supplement block.


Also, "which use" is slightly misleading, I think: at least Sanskrit
> also uses other scripts, doesn't it?  If so, I'd suggest saying "when
> they use the Grantha script" instead.
>

Corrected

Some sequences that match the regexp will not be composed, according
> to this rule.  For example, the sequence
>
>    consonant vowel
>
> won't be composed, because its second character is not in the range
> '(#x1133B . #x1134D).  Is that okay?  Or are you relying on the
> default composition of combining characters?
>

Yes, three vowel signs are not in the range, because they compose correctly
by default.

I have attached the new patch, please review this
Thank you

On Fri, Jun 3, 2022 at 7:00 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh
> >  <lumarzeli30 <at> gmail.com>
> > Date: Fri, 3 Jun 2022 18:21:08 +0530
> >
> > Add tamil supplement codepoints to (tamil).
> [...]
> > -     (tamil #xB95)
> > +     (tamil #xB95 #x11FC0 #x11FC6)
>
> This part is IMO a mistake: since there are no known fonts that
> support both the Tamil block and the Tamil Supplement block, adding
> the characters from the Supplement block to
> script-representative-chars might cause Emacs to reject a good Tamil
> font because it doesn't support the character from the Supplement
> block.  We could use a vector instead of a list, but even that could
> cause undesired consequences, whereby Emacs selects a font for Tamil
> characters when it only supports Tamil Supplement, or vice versa.
>
> I think adding Noto Sans Tamil Supplement to the default fontset is
> for now the most we can do about the Tamil Supplement block.
>
> > +(set-language-info-alist
> > + "Grantha" '((charset unicode)
> > +             (coding-system utf-8)
> > +             (coding-priority utf-8)
> > +             (input-method . "grantha")
> > +             (sample-text . "Grantha (𑌗𑍍𑌰𑌨𑍍𑌥)  𑌨𑌮𑌸𑍍𑌤𑍇")
> > +             (documentation . "\
> > +Languages such as Sanskrit and Manipravalam which uses the
>                                                      ^^^^
> "use", in plural.
>
> Also, "which use" is slightly misleading, I think: at least Sanskrit
> also uses other scripts, doesn't it?  If so, I'd suggest saying "when
> they use the Grantha script" instead.
>
> > +;; Grantha composition rules
> > +(let ((consonant            "[\x11315-\x11339]")
> > +      (nukta                "\x1133C")
> > +      (independent-vowel    "[\x11305-\x11314\x11360\x11361]")
> > +      (vowel                "[\x1133E-\x1134C\x11357\x11362\x11363]")
> > +      (nasal                "[\x11300-\x11302]")
> > +      (bindu                "\x1133B")
> > +      (visarga              "\x11303")
> > +      (virama               "\x1134D")
> > +      (avagraha             "\x1133D")
> > +      (modifier-above       "[\x11366-\x11374]"))
> > +  (set-char-table-range composition-function-table
> > +                        '(#x1133B . #x1134D)
> > +                        (list (vector
> > +                               ;; Consonant based syllables
> > +                               (concat consonant nukta "?" "\\(?:"
> virama consonant nukta
> > +                                       "?\\)*\\(?:" virama "\\|" vowel
> "*" nukta "?" nasal
> > +                                       "?" bindu "?" visarga "?"
> modifier-above "?"
> > +                                       avagraha "?\\)")
> > +                               1 'font-shape-gstring)
>
> Some sequences that match the regexp will not be composed, according
> to this rule.  For example, the sequence
>
>    consonant vowel
>
> won't be composed, because its second character is not in the range
> '(#x1133B . #x1134D).  Is that okay?  Or are you relying on the
> default composition of combining characters?
>
> Thanks.
>

[Message part 2 (text/html, inline)]

[0001-Add-support-for-the-Grantha-script.patch (text/x-patch, attachment)]

Message #14 received at 55782 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 55782 <at> debbugs.gnu.org
Subject: Re: bug#55782: [PATCH] Add support for the Grantha script
Date: Sat, 04 Jun 2022 11:32:10 +0300

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Fri, 3 Jun 2022 19:40:30 +0530
> Cc: 55782 <at> debbugs.gnu.org
> 
> I have attached the new patch, please review this

Thanks, installed.

I understand the two greetings you added are in two different
languages, is that right?

Message #17 received at 55782 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55782 <at> debbugs.gnu.org
Subject: Re: bug#55782: [PATCH] Add support for the Grantha script
Date: Sat, 4 Jun 2022 17:26:50 +0530

[Message part 1 (text/plain, inline)]

>Thanks, installed.

Thank you!

>I understand the two greetings you added are in two different
>languages, is that right?

No they are the same, both are Sanskrit. Adding Namaste to most of the
Indian languages was very boring, so this time I wrote Namaste and
Namaskaarah.

I could not find any dictionary for Manipravalam so was unable to get a
greeting for that (though it is a basically a mixture of Sanskrit and Old
Malayalam, so it does not make much difference)


शनि, 4 जून 2022, 2:02 pm को Eli Zaretskii <eliz <at> gnu.org> ने लिखा:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Fri, 3 Jun 2022 19:40:30 +0530
> > Cc: 55782 <at> debbugs.gnu.org
> >
> > I have attached the new patch, please review this
>
> Thanks, installed.
>
> I understand the two greetings you added are in two different
> languages, is that right?
>

[Message part 2 (text/html, inline)]

Message #22 received at 55782-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 55782-done <at> debbugs.gnu.org
Subject: Re: bug#55782: [PATCH] Add support for the Grantha script
Date: Sat, 04 Jun 2022 16:45:11 +0300

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Sat, 4 Jun 2022 17:26:50 +0530
> Cc: 55782 <at> debbugs.gnu.org
> 
> >I understand the two greetings you added are in two different
> >languages, is that right?
> 
> No they are the same, both are Sanskrit. Adding Namaste to most of the Indian languages was very boring,
> so this time I wrote Namaste and Namaskaarah.
> 
> I could not find any dictionary for Manipravalam so was unable to get a greeting for that (though it is a
> basically a mixture of Sanskrit and Old Malayalam, so it does not make much difference)

Ok, thanks.  So I'm closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.