GNU bug report logs - #55774
[PATCH] gnu: quodlibet: Add dependencies for plugins to work.

Previous Next

Full log

Message #11 received at 55774 <at> debbugs.gnu.org (full text, mbox):

From: "Wamm K. D." <jaft.r <at> outlook.com>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Cc: 55774 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: quodlibet: Add dependencies for plugins to work.
Date: Fri, 03 Jun 2022 08:13:00 -0500

On Fri. (Jun 03, 2022) at 08:04:10 AM +02, Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at> wrote:
> Am Freitag, dem 03.06.2022 um 00:02 -0500 schrieb Wamm K. D:
>> * gnu/packages/music.scm (quodlibet): Add dependencies for plugins to
>> work.
> Should be ... (quodlibet)[inputs]: Add ACTUAL_INPUTS...

👍; I'll get that updated.

> YMMV, but it's better for inputs to be sorted alphabetically.  Use line
> comments to demarcate specific features, e.g. 
>   keybinder-3.0 ; keybindings outside of GNOME
>   gtksourceview ; undo, redo, multiline text fields
>   ...
> Don't forget the 79 character limit; when in doubt claim less features.
> If possible, try to line up the comments.

Fair; I'll get those updated, as well. Yeah, I was trying to weigh what
to include vs. not but, due to the installation structure of Guix, you
wouldn't be able to use these features by just installing the
dependencies (leastwise, with just a naïve straightforward install, when
I tried) so I figured they were worth including, from that perspective.

> Also, comments like "musicbrainz plugin needs python-musicbrainz" are
> not as informative as you'd think and can probably be dropped :)

Haha; fair. While I could see repeating "musicbrainz" as being
repetitive, I was figuring it's easy to lose track that the dependency
was present specifically due to a plugin, for future developers who
might work on the package, and was mostly trying to capture it was
plugin-related. Thanks for pointing it out and I'll that adjusted.

I'll try making the updates later tonight; thanks a ton.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.