GNU bug report logs - #55763
[PATCH] Upgrade nyacc to 1.07.0

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#55763: closed ([PATCH] Upgrade nyacc to 1.07.0)
Date: Tue, 07 Jun 2022 16:24:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 07 Jun 2022 18:22:51 +0200
with message-id <878rq8a1es.fsf <at> gnu.org>
and subject line Re: bug#55763: [PATCH] Upgrade nyacc to 1.07.0
has caused the debbugs.gnu.org bug report #55763,
regarding [PATCH] Upgrade nyacc to 1.07.0
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
55763: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55763
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Felix Lechner <felix.lechner <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Upgrade nyacc to 1.07.0
Date: Thu, 2 Jun 2022 05:14:53 -0700

[Message part 3 (text/plain, inline)]

Control: tags -1 + patch

Hi,

For my work in making PAM configurable in Guile, I rely on the foreign
function interface (FFI). The automatic generation of that interface
requires the compile-ffi script in nyacc. Unfortunately, the highest
version we ship suffers from a bug that prevents the script from
running on the pam_client.h header in linux-pam.  This patch upgrades
nyacc to the version Matt Wette released after committing the fix.

The changes are further documented in the commit message.

I am new to Guix and already use the new version of linux-pam locally
(via Guix System) but I was unable to test the patch according to the
requirements and recommendations listed for this submission. [1]

This email was sent to -devel in lieu of -mentors, which does not
exist. Any guidance is much appreciated. Thanks for taking a look!

KInd regards
Felix Lechner

[1] https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html

[0001-Upgrade-nyacc-to-1.07.0.patch (application/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Felix Lechner <felix.lechner <at> gmail.com>
Cc: 55763-done <at> debbugs.gnu.org
Subject: Re: bug#55763: [PATCH] Upgrade nyacc to 1.07.0
Date: Tue, 07 Jun 2022 18:22:51 +0200

Hello,

Felix Lechner <felix.lechner <at> gmail.com> skribis:

> For my work in making PAM configurable in Guile, I rely on the foreign
> function interface (FFI). The automatic generation of that interface
> requires the compile-ffi script in nyacc. Unfortunately, the highest
> version we ship suffers from a bug that prevents the script from
> running on the pam_client.h header in linux-pam.  This patch upgrades
> nyacc to the version Matt Wette released after committing the fix.
>
> The changes are further documented in the commit message.
>
> I am new to Guix and already use the new version of linux-pam locally
> (via Guix System) but I was unable to test the patch according to the
> requirements and recommendations listed for this submission. [1]
>
> This email was sent to -devel in lieu of -mentors, which does not
> exist. Any guidance is much appreciated. Thanks for taking a look!

The patch is perfect; I only adjusted the commit log so that it follows
the ChangeLog convention, as Josselin pointed out:

  https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

I also check that dependents, as reported by ‘guix refresh -l nyacc’,
all build fine with the new version.

Thanks,
Ludo’.

PS: guix-mentors now exists!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.