From unknown Thu Sep 11 15:11:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55763] [PATCH] Upgrade nyacc to 1.07.0 Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Jun 2022 12:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55763 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55763@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165417215127382 (code B ref -1); Thu, 02 Jun 2022 12:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Jun 2022 12:15:51 +0000 Received: from localhost ([127.0.0.1]:53007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwjjz-00077Z-7R for submit@debbugs.gnu.org; Thu, 02 Jun 2022 08:15:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:57638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwjjy-00077S-4g for submit@debbugs.gnu.org; Thu, 02 Jun 2022 08:15:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwjjq-000757-Ul for guix-patches@gnu.org; Thu, 02 Jun 2022 08:15:43 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:45014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwjjm-0007xQ-Rq for guix-patches@gnu.org; Thu, 02 Jun 2022 08:15:41 -0400 Received: by mail-lj1-x229.google.com with SMTP id m25so1718924lji.11 for ; Thu, 02 Jun 2022 05:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=AOYXdz4B0vxkLEnWzL4i8o5crrFjun9TbDWWvElymPI=; b=JZRt84z/4K5JD+uwu0UKsxQbWuy2+Ks/96IxRnHK/km7pHt07aEuVbEUEknGtDMYq1 8QEF5H3p4psJgfCfWOIle267XfxhRFG4SDPDEDDbyU6guRCkHtSvbZsmqf/zO19PA6+e TgNHakzBWLpaP+k61tOzOvq2CdNaMs2hDs1mB1uDeU6/pYBqmUtewnJDsQEkqUndPz1i aXtfDdhUQ+J2mnQE12IBGe+TI7c+AamSmQJxpiYHjyEnrcjftbcdR30SFId7uHPB7PS9 RjAt4CcPavPIkzU80AwfUyA7m4NSnoy30lZ/axSY0wMcDHtTscoiw42H98wfgTThm/GJ TZjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=AOYXdz4B0vxkLEnWzL4i8o5crrFjun9TbDWWvElymPI=; b=8KO9/aNEWO7dwEe5hG3DJnMI7KWskCw85aTzQ5mW4javnOqGmBmaG4LMnMUQimQO/4 VH9XsJuuONxleqxFgO4K9kBMjmmxyGp6OqxcxNy3nsYj949wgljQVRFWf+IrIIFQhRYw xoloLOph0dnGMo4fUidBtYtjSXeyoHHDDmg4PQfbD2PGJWPGH0Ipqfz32pXwaJ1hvOkn OpBCQ5XRf+tZ5xLZmFPhqkuE2B65IPvAMw0kUTnP+PeeIYSK7QdR0Qu2IDCafRTlhBRp FcMPIg3BoAkQZx8f5KP9xOD8Fb6hn7IPxVdmNKtDP85jPXc2fm0l269Lm0mQqZh8gO4X Lc1w== X-Gm-Message-State: AOAM533B/y/JroAu/dCCiK4c074YSuDKRCOVdyXvxYzehXyJNe2LlDL8 EBAuknPBmwlNYphFAnFDTyLPC2WRUtFTBRECE44DLQaI X-Google-Smtp-Source: ABdhPJyjOOBMUx76IHtbATsRehdJa/PMc2cZ5rX53hRl8wrcm7bOpeTGBxUA2ty0/aN++NA5fW4CuiQF5tn6IbfewE0= X-Received: by 2002:a05:651c:12c5:b0:255:767b:8b80 with SMTP id 5-20020a05651c12c500b00255767b8b80mr1403481lje.321.1654172130229; Thu, 02 Jun 2022 05:15:30 -0700 (PDT) MIME-Version: 1.0 From: Felix Lechner Date: Thu, 2 Jun 2022 05:14:53 -0700 Message-ID: Content-Type: multipart/mixed; boundary="000000000000387ea805e075f6e8" Received-SPF: pass client-ip=2a00:1450:4864:20::229; envelope-from=felix.lechner@gmail.com; helo=mail-lj1-x229.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000387ea805e075f6e8 Content-Type: text/plain; charset="UTF-8" Control: tags -1 + patch Hi, For my work in making PAM configurable in Guile, I rely on the foreign function interface (FFI). The automatic generation of that interface requires the compile-ffi script in nyacc. Unfortunately, the highest version we ship suffers from a bug that prevents the script from running on the pam_client.h header in linux-pam. This patch upgrades nyacc to the version Matt Wette released after committing the fix. The changes are further documented in the commit message. I am new to Guix and already use the new version of linux-pam locally (via Guix System) but I was unable to test the patch according to the requirements and recommendations listed for this submission. [1] This email was sent to -devel in lieu of -mentors, which does not exist. Any guidance is much appreciated. Thanks for taking a look! KInd regards Felix Lechner [1] https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html --000000000000387ea805e075f6e8 Content-Type: application/x-patch; name="0001-Upgrade-nyacc-to-1.07.0.patch" Content-Disposition: attachment; filename="0001-Upgrade-nyacc-to-1.07.0.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l3wza6fp0 RnJvbSBlNWFmNWY0YmE1MWU3NGFjMTEwNjM0NGM3OWE3YTUzNjAyZWM3NzI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGZWxpeCBMZWNobmVyIDxmZWxpeC5sZWNobmVyQGxlYXNlLXVw LmNvbT4KRGF0ZTogV2VkLCAxIEp1biAyMDIyIDE1OjM3OjA0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gVXBncmFkZSBueWFjYyB0byAxLjA3LjAuCgpUaGlzIHZlcnNpb24gcmVzb2x2ZXMgYW4gaXNz dWUgaW4gJ2NvbXBpbGUtZmZpJyB3aGVuIGdlbmVyYXRpbmcgRkZJCmJpbmRpbmdzIGZyb20gcGFt X2NsaWVudC5oIGluIExpbnV4LVBBTS4gWzFdWzJdCgpbMV0gaHR0cHM6Ly9naXQuc2F2YW5uYWgu bm9uZ251Lm9yZy9jZ2l0L255YWNjLmdpdC9jb21taXQvP2g9bWFpbiZpZD0wOThlY2MxMmZmOTE4 MzlhOGNlOTYyMTZlMzAxZmMyMzc3OWU0OWVjClsyXSBodHRwczovL3NhdmFubmFoLm5vbmdudS5v cmcvYnVncy8/NjI1NDYKLS0tCiBnbnUvcGFja2FnZXMvbWVzLnNjbSB8IDQgKystLQogMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9n bnUvcGFja2FnZXMvbWVzLnNjbSBiL2dudS9wYWNrYWdlcy9tZXMuc2NtCmluZGV4IDE3YTU4ZmJm NjEuLjI4MjMyOTdlM2YgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9tZXMuc2NtCisrKyBiL2du dS9wYWNrYWdlcy9tZXMuc2NtCkBAIC05OCwxNCArOTgsMTQgQEAgKGRlZmluZS1wdWJsaWMgbnlh Y2MtMC45OQogKGRlZmluZS1wdWJsaWMgbnlhY2MKICAgKHBhY2thZ2UKICAgICAoaW5oZXJpdCBu eWFjYy0wLjk5KQotICAgICh2ZXJzaW9uICIxLjA2LjUiKQorICAgICh2ZXJzaW9uICIxLjA3LjAi KQogICAgIChzb3VyY2UgKG9yaWdpbgogICAgICAgICAgICAgICAobWV0aG9kIHVybC1mZXRjaCkK ICAgICAgICAgICAgICAgKHVyaSAoc3RyaW5nLWFwcGVuZCAibWlycm9yOi8vc2F2YW5uYWgvbnlh Y2MvbnlhY2MtIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZlcnNpb24gIi50 YXIuZ3oiKSkKICAgICAgICAgICAgICAgKHNoYTI1NgogICAgICAgICAgICAgICAgKGJhc2UzMgot ICAgICAgICAgICAgICAgICIxZmJ6ejlibTRta3o0ajQwbDJ6MDJ6amxicWo4MmRtdjJheXo4M3ps M2o4Z2o2ejNscGRnIikpCisgICAgICAgICAgICAgICAgIjAxcWI2aDZiazY4NHo4eGRhNWQ3MXE1 ZjVsMnozcTlqanozNmlmM2picGpjN2I4ZHhqYXAiKSkKICAgICAgICAgICAgICAgKG1vZHVsZXMg JygoZ3VpeCBidWlsZCB1dGlscykpKQogICAgICAgICAgICAgICAoc25pcHBldAogICAgICAgICAg ICAgICAgJyhzdWJzdGl0dXRlKiAiY29uZmlndXJlIgoKYmFzZS1jb21taXQ6IDU4MmI0YmI0Y2U4 MjM5YjMyMWFmOGI3NWU4NjY5OTJhZmYxNmI4YTkKLS0gCjIuMzYuMQoK --000000000000387ea805e075f6e8-- From unknown Thu Sep 11 15:11:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55763] [PATCH] Upgrade nyacc to 1.07.0 Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 Jun 2022 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55763 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Felix Lechner , 55763@debbugs.gnu.org Received: via spool by 55763-submit@debbugs.gnu.org id=B55763.165435946213778 (code B ref 55763); Sat, 04 Jun 2022 16:18:02 +0000 Received: (at 55763) by debbugs.gnu.org; 4 Jun 2022 16:17:42 +0000 Received: from localhost ([127.0.0.1]:59548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxWT8-0003a9-9Z for submit@debbugs.gnu.org; Sat, 04 Jun 2022 12:17:42 -0400 Received: from jpoiret.xyz ([206.189.101.64]:42998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxWT6-0003Zz-4Y for 55763@debbugs.gnu.org; Sat, 04 Jun 2022 12:17:41 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 3BF1A184F27; Sat, 4 Jun 2022 16:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1654359458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q0jP0Ei3y/hVT5Uv+W/NcR9F/OpaV3knlfRyS206rnE=; b=kiSnPhhuRxcqWMzQ0uwywcvhvlxDUfHTX2b9ciVuIxaKwh1NpszQIbxhA6HnH/SAN74c5c sVvzOGMTxOSxIOAHCtRQEFN6l+SUssiUeWzgVMJiQ2h7Qui1afBhYG+JzKg4P9wrSlZUTU iRdeGYkitsXUxWrOfddMywnJtcdOCVMk4mlMM26Nukqx53DNh0IFkq78ww6IejKrYt9E7q HVSglDsVqeSCxDbaqeOrab70NcK7MTr4DUSxh1EuO3iAE1yR8dMI+YigRf6utD/D3tE70q qCNTKOp/bi8dgoEfR+fF/5o5VjCmHcwsMTFiyvqZYqfCpq51Cf1GY4x+LJs1qQ== From: Josselin Poiret In-Reply-To: References: Date: Sat, 04 Jun 2022 18:17:37 +0200 Message-ID: <87leucwggu.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spamd-Bar: / X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello Felix, Felix Lechner writes: > Control: tags -1 + patch > > Hi, > > For my work in making PAM configurable in Guile, I rely on the foreign > function interface (FFI). The automatic generation of that interface > requires the comp [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.6 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello Felix, Felix Lechner writes: > Control: tags -1 + patch > > Hi, > > For my work in making PAM configurable in Guile, I rely on the foreign > function interface (FFI). The automatic generation of that interface > requires the comp [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.6 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Hello Felix, Felix Lechner writes: > Control: tags -1 + patch > > Hi, > > For my work in making PAM configurable in Guile, I rely on the foreign > function interface (FFI). The automatic generation of that interface > requires the compile-ffi script in nyacc. Unfortunately, the highest > version we ship suffers from a bug that prevents the script from > running on the pam_client.h header in linux-pam. This patch upgrades > nyacc to the version Matt Wette released after committing the fix. > > The changes are further documented in the commit message. > > I am new to Guix and already use the new version of linux-pam locally > (via Guix System) but I was unable to test the patch according to the > requirements and recommendations listed for this submission. [1] > > This email was sent to -devel in lieu of -mentors, which does not > exist. Any guidance is much appreciated. Thanks for taking a look! > > KInd regards > Felix Lechner > > [1] https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html While the contents of the patch look good, you're missing the standard ChangeLog format for the commit message, see "(standards)Change Logs". I would recommend something along --8<---------------cut here---------------start------------->8--- [Your message] * gnu/packages/mes.scm (nyacc): Update to 1.07.0. --8<---------------cut here---------------end--------------->8--- Also, I think that inline patches are preferred, even though the manual says that MIME is fine too. The usual advice is to just use git-send-email to send patch series, which will take care of everything itself (you can check out a tutorial at [1]). You could send a v2 patch, or maybe a maintainer will add the necessary format themselves and commit, whichever comes first :). In any case, thanks for your contribution! [1] https://git-send-email.io/ Best, -- Josselin Poiret From unknown Thu Sep 11 15:11:02 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Felix Lechner Subject: bug#55763: closed (Re: bug#55763: [PATCH] Upgrade nyacc to 1.07.0) Message-ID: References: <878rq8a1es.fsf@gnu.org> X-Gnu-PR-Message: they-closed 55763 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 55763@debbugs.gnu.org Date: Tue, 07 Jun 2022 16:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1654619042-24238-1" This is a multi-part message in MIME format... ------------=_1654619042-24238-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55763: [PATCH] Upgrade nyacc to 1.07.0 which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55763@debbugs.gnu.org. --=20 55763: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55763 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1654619042-24238-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55763-done) by debbugs.gnu.org; 7 Jun 2022 16:23:04 +0000 Received: from localhost ([127.0.0.1]:41230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nybyy-0006HK-G6 for submit@debbugs.gnu.org; Tue, 07 Jun 2022 12:23:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nybyt-0006GS-8u for 55763-done@debbugs.gnu.org; Tue, 07 Jun 2022 12:23:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40198) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nybyo-0007JJ-1v; Tue, 07 Jun 2022 12:22:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=mv3sezl8cHTr6Vh2NeiO+AmxiTjslnfqHrbchUjA9Sc=; b=FFADyF6tGrwbCpyTCpqv Sn6y/YyQqsp5vP26CDYziXnXqd6Itz7iJ8zNcdaV/Luhs8Drb3CIPKI9dY6zhp0ujsTd4x1Dg6VKQ cQevEWKFpyDdDegLtyBR38D/BzA/WdjfyXcoR37xvOlF3PpOCO1id8oR/LSQBrOljA3KnZD9gmecZ hg6izfQQu2/qB17a+P9Ti2JEmGY8l2sIycQXNz1//OsSAGnYRph7poCM1G73gf3Jq3N8iqZRAMPbZ QIN53NZvYJJznN2/KUC3MAQucz6vTZJDgWxfQBhKhc6f2t5cMFUKSW99NVm460QwefM2yc1bIrG1U GHrpAaT4lH4Drg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=56262 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nybyn-0003yZ-Id; Tue, 07 Jun 2022 12:22:53 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Felix Lechner Subject: Re: bug#55763: [PATCH] Upgrade nyacc to 1.07.0 References: Date: Tue, 07 Jun 2022 18:22:51 +0200 In-Reply-To: (Felix Lechner's message of "Thu, 2 Jun 2022 05:14:53 -0700") Message-ID: <878rq8a1es.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55763-done Cc: 55763-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Felix Lechner skribis: > For my work in making PAM configurable in Guile, I rely on the foreign > function interface (FFI). The automatic generation of that interface > requires the compile-ffi script in nyacc. Unfortunately, the highest > version we ship suffers from a bug that prevents the script from > running on the pam_client.h header in linux-pam. This patch upgrades > nyacc to the version Matt Wette released after committing the fix. > > The changes are further documented in the commit message. > > I am new to Guix and already use the new version of linux-pam locally > (via Guix System) but I was unable to test the patch according to the > requirements and recommendations listed for this submission. [1] > > This email was sent to -devel in lieu of -mentors, which does not > exist. Any guidance is much appreciated. Thanks for taking a look! The patch is perfect; I only adjusted the commit log so that it follows the ChangeLog convention, as Josselin pointed out: https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html I also check that dependents, as reported by =E2=80=98guix refresh -l nyacc= =E2=80=99, all build fine with the new version. Thanks, Ludo=E2=80=99. PS: guix-mentors now exists! ------------=_1654619042-24238-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Jun 2022 12:15:51 +0000 Received: from localhost ([127.0.0.1]:53007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwjjz-00077Z-7R for submit@debbugs.gnu.org; Thu, 02 Jun 2022 08:15:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:57638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwjjy-00077S-4g for submit@debbugs.gnu.org; Thu, 02 Jun 2022 08:15:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwjjq-000757-Ul for guix-patches@gnu.org; Thu, 02 Jun 2022 08:15:43 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:45014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwjjm-0007xQ-Rq for guix-patches@gnu.org; Thu, 02 Jun 2022 08:15:41 -0400 Received: by mail-lj1-x229.google.com with SMTP id m25so1718924lji.11 for ; Thu, 02 Jun 2022 05:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=AOYXdz4B0vxkLEnWzL4i8o5crrFjun9TbDWWvElymPI=; b=JZRt84z/4K5JD+uwu0UKsxQbWuy2+Ks/96IxRnHK/km7pHt07aEuVbEUEknGtDMYq1 8QEF5H3p4psJgfCfWOIle267XfxhRFG4SDPDEDDbyU6guRCkHtSvbZsmqf/zO19PA6+e TgNHakzBWLpaP+k61tOzOvq2CdNaMs2hDs1mB1uDeU6/pYBqmUtewnJDsQEkqUndPz1i aXtfDdhUQ+J2mnQE12IBGe+TI7c+AamSmQJxpiYHjyEnrcjftbcdR30SFId7uHPB7PS9 RjAt4CcPavPIkzU80AwfUyA7m4NSnoy30lZ/axSY0wMcDHtTscoiw42H98wfgTThm/GJ TZjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=AOYXdz4B0vxkLEnWzL4i8o5crrFjun9TbDWWvElymPI=; b=8KO9/aNEWO7dwEe5hG3DJnMI7KWskCw85aTzQ5mW4javnOqGmBmaG4LMnMUQimQO/4 VH9XsJuuONxleqxFgO4K9kBMjmmxyGp6OqxcxNy3nsYj949wgljQVRFWf+IrIIFQhRYw xoloLOph0dnGMo4fUidBtYtjSXeyoHHDDmg4PQfbD2PGJWPGH0Ipqfz32pXwaJ1hvOkn OpBCQ5XRf+tZ5xLZmFPhqkuE2B65IPvAMw0kUTnP+PeeIYSK7QdR0Qu2IDCafRTlhBRp FcMPIg3BoAkQZx8f5KP9xOD8Fb6hn7IPxVdmNKtDP85jPXc2fm0l269Lm0mQqZh8gO4X Lc1w== X-Gm-Message-State: AOAM533B/y/JroAu/dCCiK4c074YSuDKRCOVdyXvxYzehXyJNe2LlDL8 EBAuknPBmwlNYphFAnFDTyLPC2WRUtFTBRECE44DLQaI X-Google-Smtp-Source: ABdhPJyjOOBMUx76IHtbATsRehdJa/PMc2cZ5rX53hRl8wrcm7bOpeTGBxUA2ty0/aN++NA5fW4CuiQF5tn6IbfewE0= X-Received: by 2002:a05:651c:12c5:b0:255:767b:8b80 with SMTP id 5-20020a05651c12c500b00255767b8b80mr1403481lje.321.1654172130229; Thu, 02 Jun 2022 05:15:30 -0700 (PDT) MIME-Version: 1.0 From: Felix Lechner Date: Thu, 2 Jun 2022 05:14:53 -0700 Message-ID: Subject: [PATCH] Upgrade nyacc to 1.07.0 To: guix-patches@gnu.org Content-Type: multipart/mixed; boundary="000000000000387ea805e075f6e8" Received-SPF: pass client-ip=2a00:1450:4864:20::229; envelope-from=felix.lechner@gmail.com; helo=mail-lj1-x229.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000387ea805e075f6e8 Content-Type: text/plain; charset="UTF-8" Control: tags -1 + patch Hi, For my work in making PAM configurable in Guile, I rely on the foreign function interface (FFI). The automatic generation of that interface requires the compile-ffi script in nyacc. Unfortunately, the highest version we ship suffers from a bug that prevents the script from running on the pam_client.h header in linux-pam. This patch upgrades nyacc to the version Matt Wette released after committing the fix. The changes are further documented in the commit message. I am new to Guix and already use the new version of linux-pam locally (via Guix System) but I was unable to test the patch according to the requirements and recommendations listed for this submission. [1] This email was sent to -devel in lieu of -mentors, which does not exist. Any guidance is much appreciated. Thanks for taking a look! KInd regards Felix Lechner [1] https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html --000000000000387ea805e075f6e8 Content-Type: application/x-patch; name="0001-Upgrade-nyacc-to-1.07.0.patch" Content-Disposition: attachment; filename="0001-Upgrade-nyacc-to-1.07.0.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l3wza6fp0 RnJvbSBlNWFmNWY0YmE1MWU3NGFjMTEwNjM0NGM3OWE3YTUzNjAyZWM3NzI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGZWxpeCBMZWNobmVyIDxmZWxpeC5sZWNobmVyQGxlYXNlLXVw LmNvbT4KRGF0ZTogV2VkLCAxIEp1biAyMDIyIDE1OjM3OjA0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gVXBncmFkZSBueWFjYyB0byAxLjA3LjAuCgpUaGlzIHZlcnNpb24gcmVzb2x2ZXMgYW4gaXNz dWUgaW4gJ2NvbXBpbGUtZmZpJyB3aGVuIGdlbmVyYXRpbmcgRkZJCmJpbmRpbmdzIGZyb20gcGFt X2NsaWVudC5oIGluIExpbnV4LVBBTS4gWzFdWzJdCgpbMV0gaHR0cHM6Ly9naXQuc2F2YW5uYWgu bm9uZ251Lm9yZy9jZ2l0L255YWNjLmdpdC9jb21taXQvP2g9bWFpbiZpZD0wOThlY2MxMmZmOTE4 MzlhOGNlOTYyMTZlMzAxZmMyMzc3OWU0OWVjClsyXSBodHRwczovL3NhdmFubmFoLm5vbmdudS5v cmcvYnVncy8/NjI1NDYKLS0tCiBnbnUvcGFja2FnZXMvbWVzLnNjbSB8IDQgKystLQogMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9n bnUvcGFja2FnZXMvbWVzLnNjbSBiL2dudS9wYWNrYWdlcy9tZXMuc2NtCmluZGV4IDE3YTU4ZmJm NjEuLjI4MjMyOTdlM2YgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9tZXMuc2NtCisrKyBiL2du dS9wYWNrYWdlcy9tZXMuc2NtCkBAIC05OCwxNCArOTgsMTQgQEAgKGRlZmluZS1wdWJsaWMgbnlh Y2MtMC45OQogKGRlZmluZS1wdWJsaWMgbnlhY2MKICAgKHBhY2thZ2UKICAgICAoaW5oZXJpdCBu eWFjYy0wLjk5KQotICAgICh2ZXJzaW9uICIxLjA2LjUiKQorICAgICh2ZXJzaW9uICIxLjA3LjAi KQogICAgIChzb3VyY2UgKG9yaWdpbgogICAgICAgICAgICAgICAobWV0aG9kIHVybC1mZXRjaCkK ICAgICAgICAgICAgICAgKHVyaSAoc3RyaW5nLWFwcGVuZCAibWlycm9yOi8vc2F2YW5uYWgvbnlh Y2MvbnlhY2MtIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZlcnNpb24gIi50 YXIuZ3oiKSkKICAgICAgICAgICAgICAgKHNoYTI1NgogICAgICAgICAgICAgICAgKGJhc2UzMgot ICAgICAgICAgICAgICAgICIxZmJ6ejlibTRta3o0ajQwbDJ6MDJ6amxicWo4MmRtdjJheXo4M3ps M2o4Z2o2ejNscGRnIikpCisgICAgICAgICAgICAgICAgIjAxcWI2aDZiazY4NHo4eGRhNWQ3MXE1 ZjVsMnozcTlqanozNmlmM2picGpjN2I4ZHhqYXAiKSkKICAgICAgICAgICAgICAgKG1vZHVsZXMg JygoZ3VpeCBidWlsZCB1dGlscykpKQogICAgICAgICAgICAgICAoc25pcHBldAogICAgICAgICAg ICAgICAgJyhzdWJzdGl0dXRlKiAiY29uZmlndXJlIgoKYmFzZS1jb21taXQ6IDU4MmI0YmI0Y2U4 MjM5YjMyMWFmOGI3NWU4NjY5OTJhZmYxNmI4YTkKLS0gCjIuMzYuMQoK --000000000000387ea805e075f6e8-- ------------=_1654619042-24238-1--