GNU bug report logs - #55759
hard coded height value in manoj-dark theme causes problems when increasing default-face-height

Previous Next

Package: emacs;

Reported by: Yilkal Argaw <yilkalargawworkneh <at> gmail.com>

Date: Thu, 2 Jun 2022 04:40:01 UTC

Severity: normal

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55759 in the body.
You can then email your comments to 55759 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#55759; Package emacs. (Thu, 02 Jun 2022 04:40:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Yilkal Argaw <yilkalargawworkneh <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 02 Jun 2022 04:40:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yilkal Argaw <yilkalargawworkneh <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: hard coded height value in manoj-dark theme causes problems when
 increasing default-face-height
Date: Thu, 2 Jun 2022 07:38:59 +0300

If one uses fido-vertical-mode and temporarily increases the
default-font-hight by using the function (set-face-attribute 'default
nil :height 180) the completions will not scale properly. I've looked
into the source code for the theme and it shows that the
completions-common-part variable is hardcoded to a value of 81. It
should be changed to a relative value (something like 0.8) so that it
scales properly.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55759; Package emacs. (Thu, 02 Jun 2022 05:37:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yilkal Argaw <yilkalargawworkneh <at> gmail.com>
To: 55759 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: sending a patch for the bug #55759
Date: Thu, 2 Jun 2022 08:36:34 +0300

[Message part 1 (text/plain, inline)]


[0001-change-height-attribute-for-completions-common-part.patch (application/octet-stream, attachment)]







Information forwarded
to bug-gnu-emacs <at> gnu.org:

bug#55759; Package emacs.
 (Thu, 02 Jun 2022 05:37:02 GMT) Full text and rfc822 format available.







Information forwarded
to bug-gnu-emacs <at> gnu.org:

bug#55759; Package emacs.
 (Thu, 02 Jun 2022 09:31:01 GMT) Full text and rfc822 format available.



Message #14 received at 55759 <at> debbugs.gnu.org (full text, mbox):


From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Yilkal Argaw <yilkalargawworkneh <at> gmail.com>
Cc: 55759 <at> debbugs.gnu.org
Subject: Re: bug#55759: hard coded height value in manoj-dark theme causes
 problems when increasing default-face-height
Date: Thu, 02 Jun 2022 11:30:39 +0200



Yilkal Argaw <yilkalargawworkneh <at> gmail.com> writes:

> Subject: [PATCH] change height attribute for completions-common-part

Thanks; applied to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no












bug marked as fixed in version 29.1, send any further explanations to
55759 <at> debbugs.gnu.org and Yilkal Argaw <yilkalargawworkneh <at> gmail.com>
Request was from Lars Ingebrigtsen <larsi <at> gnus.org>
to control <at> debbugs.gnu.org.
 (Thu, 02 Jun 2022 09:31:02 GMT) Full text and rfc822 format available.











bug archived.
Request was from Debbugs Internal Request <help-debbugs <at> gnu.org>
to internal_control <at> debbugs.gnu.org.
 (Thu, 30 Jun 2022 11:24:09 GMT) Full text and rfc822 format available.





This bug report was last modified 3 years and 73 days ago.





Previous Next






GNU bug tracking system

Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.