From unknown Fri Jun 20 07:25:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#55674 <55674@debbugs.gnu.org> To: bug#55674 <55674@debbugs.gnu.org> Subject: Status: [PATCH 2/2] gnu: emacs-helpful: Update to 0.19. Reply-To: bug#55674 <55674@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:25:56 +0000 retitle 55674 [PATCH 2/2] gnu: emacs-helpful: Update to 0.19. reassign 55674 guix-patches submitter 55674 Erik =C5=A0abi=C4=8D severity 55674 normal tag 55674 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri May 27 08:52:58 2022 Received: (at submit) by debbugs.gnu.org; 27 May 2022 12:52:58 +0000 Received: from localhost ([127.0.0.1]:33080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuZSc-0001ZG-G8 for submit@debbugs.gnu.org; Fri, 27 May 2022 08:52:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:35748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuZSb-0001Z2-8N for submit@debbugs.gnu.org; Fri, 27 May 2022 08:52:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuZSV-0004Qz-L5 for guix-patches@gnu.org; Fri, 27 May 2022 08:52:55 -0400 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]:44948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuZSR-0003NU-Ce for guix-patches@gnu.org; Fri, 27 May 2022 08:52:50 -0400 Received: by mail-ej1-x62b.google.com with SMTP id f21so8493310ejh.11 for ; Fri, 27 May 2022 05:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=tj/V/jCr+KRBBXrc46bt+4P0qzvFzG0YzI3CtCUJkoQ=; b=A4XcYTPJ++L7Lsa8s3VbzNymQkRzYxlNBGzyTX0u4v9To8ydtCJhks6H14GkQItvCF YaTvm/vdubs93FHLa/rAymjXwazA1Su/MWx/vAOE3ku+n/xd1zaGb7TAICwWYUpW+ELF mczrap6G629N4FWuCzN2UGopwvfPEyYS27EhC34CtTz/vbvtDB52nL05Qvbmhs+QlVu+ pz+CISbSlOcWVL/va4jET/DDr7+HhhluCxn26hJO09QUmDC44muuRHsvBD4ylNmSSM0D 6Aau5QyPOvObR/sEgUtyQbLAa6J4vkoFlBFdcs8b5gGmZUAtO5QR0cgLynoltuAb8BiK NBIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tj/V/jCr+KRBBXrc46bt+4P0qzvFzG0YzI3CtCUJkoQ=; b=u3rfi0x78/K2j4OWLd5n0m2fu19zBkoipf7Kd32srbhxSX9xLZhdP0GmY8wpkr4CuY 6jUry7rLig1pdr4WKVYMFtmzrDbqZhjAPFTRz/xO0ula0MCaJ5fTT+UmL/Lf9G0PjRgn 3QEkpDY/Db9hrCliXjmDVHNDXX9ivFavtMvLPB04pbEdvWrgmsqzmeWz3ORfkpc3PcI8 U9AbLXriWTXrNre9RKWSzA9SdJAAdpuSyzhJOpWrFxdmY7MVltXW9SEDrjh1TCCKYZp9 grG3YXkcAsmD5m6TFQwynyUy7WrKv/mSYeoeTY9bWeeXx22sC74O9T0RUn4IOuJJOv0i nJLA== X-Gm-Message-State: AOAM531Xu+n/jcsZf2YU0b/Jr6HAAZxlG9dUxeBICmJ8N3r3Mp5ev0fc nAR5clgLMyDlk6qJ9SqSghXRH3z9Rfc= X-Google-Smtp-Source: ABdhPJxCgKxZFDdo6kw6W8V12847iSjPzZ+lWsC4HmVuDsGhfvPHmaRG9H4qC4W0uggcggzlNKEYIQ== X-Received: by 2002:a17:907:7202:b0:6fe:fcec:7b7b with SMTP id dr2-20020a170907720200b006fefcec7b7bmr19334999ejc.529.1653655964603; Fri, 27 May 2022 05:52:44 -0700 (PDT) Received: from localhost.localdomain ([2a01:261:45a:6400::c71]) by smtp.gmail.com with ESMTPSA id k2-20020a1709063e0200b006f3ef214e5bsm1389439eji.193.2022.05.27.05.52.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 05:52:44 -0700 (PDT) From: =?UTF-8?q?Erik=20=C5=A0abi=C4=8D?= To: guix-patches@gnu.org Subject: [PATCH 2/2] gnu: emacs-helpful: Update to 0.19. Date: Fri, 27 May 2022 14:52:42 +0200 Message-Id: <20220527125242.27817-2-erik.sab@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220527125242.27817-1-erik.sab@gmail.com> References: <20220527125242.27817-1-erik.sab@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=erik.sab@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.19. --- gnu/packages/emacs-xyz.scm | 39 ++++++++++++++++++++------------------ 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f62c733fb5..6a659fabf3 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -20126,27 +20126,29 @@ (define-public emacs-download-region (define-public emacs-helpful (package (name "emacs-helpful") - (version "0.18") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/Wilfred/helpful") - (commit version))) - (file-name (git-file-name name version)) - (sha256 - (base32 "0gdjxykqkal2x765mi51m99i5ql23i1fy909wy4mzj5ajhjfgqcc")))) + (version "0.19") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/Wilfred/helpful") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0qwsifzsjw95l83m7z07fr9h1sqbhggwmcps1qgbddpan2a8ab8a")))) (build-system emacs-build-system) - (propagated-inputs - (list emacs-elisp-refs emacs-dash emacs-s emacs-f emacs-shut-up)) - (native-inputs - (list emacs-ert-runner emacs-undercover)) + (propagated-inputs (list emacs-elisp-refs emacs-dash emacs-s emacs-f + emacs-shut-up)) + (native-inputs (list emacs-ert-runner emacs-undercover)) (arguments - `(#:tests? #t - #:test-command '("ert-runner"))) + ;; Tests are not passing; the author might not be using them anymore. + `(#:tests? #f + #:test-command + '("ert-runner"))) (home-page "https://github.com/Wilfred/helpful") (synopsis "More contextual information in Emacs help") - (description "@code{helpful} is an alternative to the built-in Emacs help + (description + "@code{helpful} is an alternative to the built-in Emacs help that provides much more contextual information. @itemize @@ -20164,7 +20166,8 @@ (define-public emacs-helpful @item Display any keybindings that apply to interactive functions. @item Trace, disassemble functions from inside Helpful. This is discoverable and doesn't require memorisation of commands. -@end itemize\n") +@end itemize +") (license license:gpl3+))) (define-public emacs-logview -- 2.36.1 From debbugs-submit-bounces@debbugs.gnu.org Fri May 27 09:12:35 2022 Received: (at 55674) by debbugs.gnu.org; 27 May 2022 13:12:35 +0000 Received: from localhost ([127.0.0.1]:33113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuZla-00024P-VA for submit@debbugs.gnu.org; Fri, 27 May 2022 09:12:35 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:54180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuZlY-00024G-Pq for 55674@debbugs.gnu.org; Fri, 27 May 2022 09:12:33 -0400 Received: from [172.20.10.5] ([188.188.246.167]) by albert.telenet-ops.be with bizsmtp id bpCW2700C3dS87Q06pCXbz; Fri, 27 May 2022 15:12:31 +0200 Message-ID: <7fa715e77a2f947b2104a3c578c001125842b01f.camel@telenet.be> Subject: Re: [bug#55674] [PATCH 2/2] gnu: emacs-helpful: Update to 0.19. From: Maxime Devos To: Erik =?UTF-8?Q?=C5=A0abi=C4=8D?= , 55674@debbugs.gnu.org Date: Fri, 27 May 2022 15:12:30 +0200 In-Reply-To: <20220527125242.27817-2-erik.sab@gmail.com> References: <20220527125242.27817-1-erik.sab@gmail.com> <20220527125242.27817-2-erik.sab@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-L+VNtcPzm0xOpRdNCJfw" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1653657151; bh=n5bOzujn9PI7xYmrj6zjYCLJCDd0AwKAp6Unu/xKE/k=; h=Subject:From:To:Date:In-Reply-To:References; b=UcQiLW9kz+J1iNIjJzivmAaZUKESIh/JTsdBGii2d7efh7Hd25MCIkoWj466g+NE8 LYdm9nAoOAhU6Q4SKtcLOZkyi1WNHCbH/VxFHx+eUIVTIv8rg0AqdwHWaD5aYnNuQc l8SGRoRfak8RmDWmqSGWYjH4M+0bjSNwYen/mk7c5nhtv0oaN7+U2cf5ETTKOb29Ns y6zy6WATm25rQRWybMIWoxkySZIdcYqFSXHzxN6q35BDeAqGjuK1M07gWhYmQCHlGR kQA5gmRIum9OGAXlVlZs9rm+JXE3gyIDHG1y1alMzpXMYrMjXe97/O84bvCCcF9ufV rk1z/4oFLwx8w== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55674 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-L+VNtcPzm0xOpRdNCJfw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Erik =C5=A0abi=C4=8D schreef op vr 27-05-2022 om 14:52 [+0200]: > +=C2=A0=C2=A0=C2=A0=C2=A0 ;; Tests are not passing; the author might not = be using them anymore. > +=C2=A0=C2=A0=C2=A0=C2=A0 `(#:tests? #f How do they fail? They might indicate a real problem in the code (that's what tests are for -- detecting problems before they are actually encountered). Greetings, Maxime. --=-L+VNtcPzm0xOpRdNCJfw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYpDOPhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7l+HAQDRNATWSBa4zcXjzvLnEe+1ykpb fL9N9R4CEH6cRFu8SAEAgwvNvEhxhJ6ac9umyHJUidysR3gYuy2KZA/Yq19hBA8= =vnE2 -----END PGP SIGNATURE----- --=-L+VNtcPzm0xOpRdNCJfw-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 27 10:58:26 2022 Received: (at 55674) by debbugs.gnu.org; 27 May 2022 14:58:27 +0000 Received: from localhost ([127.0.0.1]:35607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nubQ2-0005Ut-OY for submit@debbugs.gnu.org; Fri, 27 May 2022 10:58:26 -0400 Received: from mail-oi1-f171.google.com ([209.85.167.171]:37705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nubQ0-0005Uf-W9 for 55674@debbugs.gnu.org; Fri, 27 May 2022 10:58:25 -0400 Received: by mail-oi1-f171.google.com with SMTP id s188so5968239oie.4 for <55674@debbugs.gnu.org>; Fri, 27 May 2022 07:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=58VKQHY4JhE8/mK+f4KppJdHXYUF4lKU3hpWyjbRx7s=; b=QDhwSonQjavcdoZK7ZMzp3EOjA22lesN85drEnGIUQr2+LSmx8mRvw2nnKnAw/JyuP yny0KbNfbfnMM8vIMv/NpZ8qI1izG1vppeg0LVKRQDt6a011U5KV0xKV11BYerVGLMmY bfve3RimyoqTO5RnGWFmndwuFOKA9wQD7/2NzDFN0LWNy8ZLckFIw5PtY8kGufGZCtOx OnDjahaCbNEputS7ZVYFduo3PAzvmnJ15N5ArA11BC2foVIXmaYCyELjBLlmv92k1b1X dbKZrHtOo53iuGnFFO14AOGvfuMwJYFg7j2vpJL5TAgrPVGAaouk0Ykwf0Xt/gbe5M7J Qv9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=58VKQHY4JhE8/mK+f4KppJdHXYUF4lKU3hpWyjbRx7s=; b=2NRP9sYWY5kYYkUqPFIEUtugXeQTT+Hprdwz22fRvq2cBxdNAP/dJnCtpRQXc4mgsg DHiwRV4orw68nDXw2548i4IFWNNvYrsyeMupUMm6KGqLcX3iKyjFEcdvNhOuvWx3v1dt p0BfmOpOlS8J1P8Dc+2pCA1i0FelNaGmanj1pOxrdcmfuXUBOsE+XRbnJrWYfBaAL2Ri N9/enQa3oW3EM0ZfFQpZGzbHorQHAqS0J3GZg9G6Qb91A4HK8USpAa6kxGAgC69BJObx yBAZZk1MY3Mh83lWaz8jaMNFgZLOyjR959wCocS7rbqfWWoPAkzRGkZDgEfxArHDRoUe BnSA== X-Gm-Message-State: AOAM533PVcjrd1ujTOXcCMqiK2DmfZTzQbuXE6ZrhA5kCzFtD+TokXSp MuKzVCNNDyp8onryzUxPaok7eqJDa7h602P5I3QP/6Sr X-Google-Smtp-Source: ABdhPJwKOGGyKNyMD6/5MLk7ekIEn5+6NYM/Dptd29qJBEAbKzVO8JNG0eVAKBXAHtKiBbxxIEXo51zjM3aVlmaeIZs= X-Received: by 2002:a05:6808:1489:b0:32b:b9a8:e6c6 with SMTP id e9-20020a056808148900b0032bb9a8e6c6mr4033421oiw.50.1653663499150; Fri, 27 May 2022 07:58:19 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?B?RXJpayDFoGFiacSN?= Date: Fri, 27 May 2022 16:58:08 +0200 Message-ID: Subject: Broken tests To: 55674@debbugs.gnu.org Content-Type: multipart/alternative; boundary="00000000000071e90305dfff89ff" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55674 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000071e90305dfff89ff Content-Type: text/plain; charset="UTF-8" One of the tests fails. Looks like it's testing whether helpful--docstring and helpful--docstring-advice figure out that a function is advised. I've tried using helpful-* functions from this updated package in Emacs, and it works - advices are shown. So it looks like the tests are broken. (but I don't understand the ert tests, maybe someone else should look at this) --00000000000071e90305dfff89ff Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
One of the tests fails. Looks like it's testing w= hether helpful--docstring and=C2=A0
helpful--docstring-advice fig= ure out that a function is advised.

I've tried= using helpful-* functions from this updated package in Emacs,
an= d it works - advices are shown.

So it looks like t= he tests are broken.=C2=A0
(but I don't understand the ert te= sts, maybe someone else
should look at this)
--00000000000071e90305dfff89ff-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 27 13:23:43 2022 Received: (at 55674) by debbugs.gnu.org; 27 May 2022 17:23:43 +0000 Received: from localhost ([127.0.0.1]:35728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nudgZ-0002wk-15 for submit@debbugs.gnu.org; Fri, 27 May 2022 13:23:43 -0400 Received: from mail-oi1-f172.google.com ([209.85.167.172]:46625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nudgX-0002wW-7r for 55674@debbugs.gnu.org; Fri, 27 May 2022 13:23:37 -0400 Received: by mail-oi1-f172.google.com with SMTP id q8so6381951oif.13 for <55674@debbugs.gnu.org>; Fri, 27 May 2022 10:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=GBDygCzDyo+hUzZgQK63Y9MZQr3ATeWxIvDSEo/O+Zs=; b=C33xxITi31M52oUPvR0IKshOdzxAayft6f6gHRXVIQYpKbHVM43xBLXqX4Q0SX8kaI 99d2dSsDsoy7h5v3FbnJmE555NCXCNSibLqubrspjR++GEhr80pdSwrOM3ckhW7Dl+7V 59wyBIv9LVDFOmHQdUM3WnEvYdkLWL9sG9/gX+wbrr0gmAz/7kdnwol+K2EIDwSiA+81 Gvktrc33VqdrvorqNKb9nDJzshxFkUHY1tIFvfyEzab0nxHeKfCdQbE7WKrN8DVH7OKn S2cj2gSDd2Fo2M/N1qKMe+RBfbOrDqWHln+swQ8/WOEyVH9E7JAq5Z9Fsfe8AN4dDyT+ RLSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=GBDygCzDyo+hUzZgQK63Y9MZQr3ATeWxIvDSEo/O+Zs=; b=OSfXvSe4+lTDob3JdW3SUc2f/m/2PkZ8X/TmDgPDkYTrgzIQ4MLij9MI406QkXPvY6 q5KriHEXm5A3oSz6uhzTn71Lu3ZAky1uGh/mQanuehfCo4jvzd/THBUpDX01IwwxiWlw vCXQnOhckoF3qFlC06m8ynAiLRwjYH65NMj4BggsFSaXwJoYS9lSw+0OkHgF9AP6xX4I dULXNpJfpkARUNLvSyKrTk9+MwEdCDpcJ3LpRhRZ90I0sv6kiuQPaxtEY7s5KBWQd2Hq VzaP4QRfUVbdRr9rckcGNyadN6WiZH34MQ9RlGww5GnDtc3iV1ZcPkvcQVTiJEydMIne jDQQ== X-Gm-Message-State: AOAM533bfSX3gmJNfRN42GBHBsflTImUWq10JWEwqYxeuX5wNS0yvjzW yGeZNkcZDNSMkD1lBO0IRedOtEAeh5U/wCozIC8= X-Google-Smtp-Source: ABdhPJy+F+DOq8ydiAQnKH9cjQlaSUEctQI05ReXSlzYQ7+vstyWv44UubXJTCEK/KG3sCJ+Gti91zVIjRPK4UAHA2g= X-Received: by 2002:a05:6808:613:b0:32b:f27:2891 with SMTP id y19-20020a056808061300b0032b0f272891mr4520235oih.166.1653672211453; Fri, 27 May 2022 10:23:31 -0700 (PDT) MIME-Version: 1.0 References: <20220527125242.27817-1-erik.sab@gmail.com> <20220527125242.27817-2-erik.sab@gmail.com> <7fa715e77a2f947b2104a3c578c001125842b01f.camel@telenet.be> <56da0d503f04884a5b3e407c36db50c75517b90e.camel@telenet.be> In-Reply-To: <56da0d503f04884a5b3e407c36db50c75517b90e.camel@telenet.be> From: =?UTF-8?B?RXJpayDFoGFiacSN?= Date: Fri, 27 May 2022 19:23:20 +0200 Message-ID: Subject: Re: [bug#55674] [PATCH 2/2] gnu: emacs-helpful: Update to 0.19. To: Maxime Devos Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55674 Cc: 55674@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Okay, I figured it out. The test is indeed broken and it's an easy fix. I will try sending a PR on github. I have a lot to learn. I apologise for being a nuisance :) Please tell me if there's anything else I can improve on. Thank you! here's a diff for the test: diff --git a/test/helpful-unit-test.el b/test/helpful-unit-test.el index a07aa8e..1a61a6f 100644 --- a/test/helpful-unit-test.el +++ b/test/helpful-unit-test.el @@ -119,7 +119,7 @@ bar"))) (should (equal (helpful--docstring #'test-foo-advised t) - "Docstring here too."))) + "Docstring here too.\n\nThis function has :around advice: `ad-Advice-test-foo-advised'."))) (defun test-foo-no-docstring () nil) On Fri, May 27, 2022 at 3:48 PM Maxime Devos wrote= : > > [Please keep 55675@debbugs.gnu.org in CC] > > Erik =C5=A0abi=C4=8D schreef op vr 27-05-2022 om 15:32 [+0200]: > > Well it fails on a test defined like this: > > (ert-deftest helpful--docstring () > > "Basic docstring fetching." > > (should > > (equal > > (helpful--docstring #'test-foo t) > > "Docstring here."))) > > > > And fails like so: > > ...............s...s..Test helpful--docstring-advice backtrace: > > > > > > Test helpful--docstring-advice condition: > > > > (ert-test-failed > > ((should > > (equal > > (helpful--docstring ... t) > > "Docstring here too.")) > > :form > > (equal "Docstring here too.\n\nThis function has :around > > advice: `ad-Advice-test-foo-advised'." "Docstring here too.") > > :value nil :explanation > > (arrays-of-different-length 84 19 "Docstring here too.\n\nThis > > function has :around advice: `ad-Advice-test-foo-advised'." > > "Docstring here too." first-mismatch-at 19))) > > > > F............................................................s...... > > Looks like a bug. > > > I don't know anything about emacs-ert. And I wasn't able to > > figure out if it works for the upstream author. > > > > WDYT? > > I don't know if it fails for the upstream author, but I don't think > that's relevant to Guix. More relevant I think, is that this bug > appears in Guix, so it can cause problems for Guix users, so some > fixing might be necessary. > > I don't know much about Emacs though, so you might need to contact > upstream about the bug. > > Greetings, > Maxime. From debbugs-submit-bounces@debbugs.gnu.org Sun May 29 01:06:03 2022 Received: (at 55674) by debbugs.gnu.org; 29 May 2022 05:06:03 +0000 Received: from localhost ([127.0.0.1]:39237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvB7r-0002a3-4R for submit@debbugs.gnu.org; Sun, 29 May 2022 01:06:03 -0400 Received: from ip-15.mailobj.net ([213.182.54.15]:50090 helo=msg-4.mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvB7m-0002ZU-8c for 55674@debbugs.gnu.org; Sun, 29 May 2022 01:06:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailoo.org; s=mailo; t=1653800751; bh=LYLeOcwOO9LNV+kpwURw4MSq7wqEj/0GZqK+ZXzNT8Y=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: Content-Type; b=P3Zo8hs+gcS2sPYbX5bx8Wj9xyKyh285gq3u2H2Wkb6YTwdCuSkUkE4YW15AoO10H Zls14GyZnmvvPXo5dT24z2wNY1RXoP/Gpcy9c4Qu2vEaiaxRU4aOPwectc37mA0xm0 6NoXKATZjsapEvMAC7CA7YrfvjDLpNVBf5XqOmxo= Received: by www-7.mailo.com with http webmail; Sun, 29 May 2022 07:05:51 +0200 (CEST) X-EA-Auth: HymWPGb45nFK3sEHLKSawMyqR6APyNt/6lOGY+bR7yeHWaUSwYiCs8jgouc0MU9YnaDNfQyLQp5t4WDyshZuif6iIOpfQw7v From: yarl-baudig@mailoo.org To: 55674@debbugs.gnu.org Date: Sun, 29 May 2022 07:05:51 +0200 (CEST) Subject: PR accepted X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55674 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yes, your pull request have been accepted! Thank you. Mind if I update? I would like helpful to be fixed quickly. From debbugs-submit-bounces@debbugs.gnu.org Sun May 29 01:13:46 2022 Received: (at 55674) by debbugs.gnu.org; 29 May 2022 05:13:46 +0000 Received: from localhost ([127.0.0.1]:39242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvBFJ-0002tI-Rc for submit@debbugs.gnu.org; Sun, 29 May 2022 01:13:46 -0400 Received: from ip-15.mailobj.net ([213.182.54.15]:50164 helo=msg-4.mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvBFF-0002t1-LM for 55674@debbugs.gnu.org; Sun, 29 May 2022 01:13:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailoo.org; s=mailo; t=1653801215; bh=RzBwcHFa+oM2i8L3boWoh44jt2VcQHq2chJVx7GRLLM=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: Content-Type:Content-Transfer-Encoding; b=efJyNFkW8At5vrP9BM29fXwpu2mEqZtYLDrnJrj9xs8s0Bh2bLhTfqS00qNiY+Y6n dcbYai+WCZO6GDuQbfTmNM0KHY9agsR8KeK4iNblLkRDkrh4jz3AJ8GlIK0BesHcWg tcDsYxvlNR3eeNqqNAQD0svB4p2xwfX9mIxpKUG4= Received: by www-7.mailo.com with http webmail; Sun, 29 May 2022 07:13:35 +0200 (CEST) X-EA-Auth: 2dl2qRtSbpkQrgic23IyNeJ5mDaNmoyFY5qo3pruJOniFTzF+BKYkZvmtZY1cFEgtWulB6rDLc9USn0hYz8669g55TcSQQCE From: yarl-baudig@mailoo.org To: 55674@debbugs.gnu.org Date: Sun, 29 May 2022 07:13:35 +0200 (CEST) Subject: [PATCH] gnu: emacs-helpful: Update to 209971b X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55674 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 209971b Fixes Thanks to upstream pull request by Erik =C5=A0abi=C4=8D --- gnu/packages/emacs-xyz.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 31822dc641..90fd8a49d6 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -20131,7 +20131,7 @@ (define-public emacs-download-region (define-public emacs-helpful (package (name "emacs-helpful") - (version "0.18") + (version "209971ba9f576ba080352642cfbf25df5692b1d7") (source (origin (method git-fetch) @@ -20140,7 +20140,7 @@ (define-public emacs-helpful (commit version))) (file-name (git-file-name name version)) (sha256 - (base32 "0gdjxykqkal2x765mi51m99i5ql23i1fy909wy4mzj5ajhjfgqcc")))= ) + (base32 "1qrxr0ybvdvx6qw6akb1pv074bmffv4m57855kk8fr1vp4w07z0i")))= ) (build-system emacs-build-system) (propagated-inputs (list emacs-elisp-refs emacs-dash emacs-s emacs-f emacs-shut-up)) --=20 2.36.0 From debbugs-submit-bounces@debbugs.gnu.org Sun May 29 03:41:15 2022 Received: (at 55674) by debbugs.gnu.org; 29 May 2022 07:41:15 +0000 Received: from localhost ([127.0.0.1]:39307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvDY3-0006kY-3u for submit@debbugs.gnu.org; Sun, 29 May 2022 03:41:15 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:37497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvDY0-0006kK-IB for 55674@debbugs.gnu.org; Sun, 29 May 2022 03:41:14 -0400 Received: by mail-ej1-f65.google.com with SMTP id rq11so15674254ejc.4 for <55674@debbugs.gnu.org>; Sun, 29 May 2022 00:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=/bmqqo8cUtpe0fY3YWJlNk13vDy2OIO9eAIpvt9XVk8=; b=HysAC9D9BYuulmUByxag/QqDcnyOFC3bvS9OZHJVsCCYBB8R+lPyHToM7MGQGewA+W vNxYK2M2VofquKjrEWNNC1qPHCFIgkZyaxvVA+Y7/EPZM5gAfseL2HuQXMSVCLVgaO58 IN/vqByKrS3q2ffPq0lGE+XvcqteAU/+wiN/0hDPcMblgpZZkNr3H9ZgHt8O5olmf4OU LI6Z1XKHOZcBG0ebn+25zNf2RvI/pxAECijjNSQfj0mvau3sM9t3Ngluf9g6Wszkzh7b 7XXSOrFSWnKR3omnReN+gYEIwyUNFS+9cWqImWN5HXaAdh0eavp859svKEfm6f20TCzq 5A9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=/bmqqo8cUtpe0fY3YWJlNk13vDy2OIO9eAIpvt9XVk8=; b=jtCpe+24fdMwsI42EMilM1AgPlv5NZVQBaxZLcTK/lA9XLp7sdbiyX7CIecHKpmKu2 ySvpeL8yk91sTwoZ2OR+AWxeqt650qd5JDzGRm7iYeJsXTsKraJ+zZqyURM0YTV+sqmY w8RTNsxu980OdQwHy+HubQoizwmBgYjV6lrDRW/kgEfxIGOXcDyfTHukHw57/KH0jFCi B0jRfkSPq8Q9LL9d88q7Wl48WWAxeg3JEpU2WIzMOIRMnb7HNG+8vCoBvwq2w5rt9+A4 AT4A3fE0fvsWFKDVAL5StElztSEEuBzBecE7zgNrtYK3daFkWSkxXf4JnEzd5izcsEXr XLMA== X-Gm-Message-State: AOAM532/liDizpPCtplXURrjTzeATkY+H4Hzgjzf7bVC2FKzFIXvp6Gz rn5b+Ud9kD1bS9FImdWj+tQ= X-Google-Smtp-Source: ABdhPJydfal300X/jKg9YbaHH458XKOdMRF/c9APTqxXrYVUW+q9sPgi19jEf/FgEzepe92TJvJJPw== X-Received: by 2002:a17:906:eb15:b0:6fe:9dcc:be0a with SMTP id mb21-20020a170906eb1500b006fe9dccbe0amr41787157ejb.465.1653810066418; Sun, 29 May 2022 00:41:06 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id p21-20020a50cd95000000b0042dcbc3f302sm772784edi.36.2022.05.29.00.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 May 2022 00:41:06 -0700 (PDT) Message-ID: <2f5f0d333b8a15a52ba25468cc3d3402229083c2.camel@gmail.com> Subject: Re: [PATCH] gnu: emacs-helpful: Update to 209971b From: Liliana Marie Prikler To: yarl-baudig@mailoo.org, 55674@debbugs.gnu.org Date: Sun, 29 May 2022 09:41:05 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55674 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 29.05.2022 um 07:13 +0200 schrieb yarl-baudig@mailoo.org: > * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 209971b > > Fixes > Thanks to upstream pull request by Erik Šabič > --- >  gnu/packages/emacs-xyz.scm | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 31822dc641..90fd8a49d6 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -20131,7 +20131,7 @@ (define-public emacs-download-region >  (define-public emacs-helpful >    (package >      (name "emacs-helpful") > -    (version "0.18") > +    (version "209971ba9f576ba080352642cfbf25df5692b1d7") Commit hashes are not versions. Furthermore, there has been more than just that bugfix since – as a workaround I think it'd be more reasonable to just disable that one test until the next release. Cheers From debbugs-submit-bounces@debbugs.gnu.org Sun May 29 05:09:25 2022 Received: (at 55674) by debbugs.gnu.org; 29 May 2022 09:09:25 +0000 Received: from localhost ([127.0.0.1]:39381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvEvM-0000U8-U8 for submit@debbugs.gnu.org; Sun, 29 May 2022 05:09:25 -0400 Received: from ip-15.mailobj.net ([213.182.54.15]:56536 helo=msg-4.mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvEvH-0000To-Eb for 55674@debbugs.gnu.org; Sun, 29 May 2022 05:09:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailoo.org; s=mailo; t=1653815352; bh=AI95aLm6lPCWdxdLinFXrjsS7XF2QZDX2YtD3VhopD8=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=JrNk5bSy1LORpN8TZp6ANhSLM+b+Nda51wjSvSW10Xz5VJVYW+I3H/Th7OGDFO0K+ Mr/nhyb+BSzFiOYhXFRrjhtQo1DlZSTdcXlngFlPdvm76jIl83tcm5vScWyJe4sA9O S1l71ALfp+7TTYrRHGNUYpWeqNHstTXHoVQfx/ak= Received: by www-7.mailo.com with http webmail; Sun, 29 May 2022 11:09:12 +0200 (CEST) X-EA-Auth: WXDyGiAXS5+EYAA6ubFXhN4QJd5UdqcRvs+0X7YDAlmbmd2BH3Sl55RAN/YcJGuvrIu2ilYfyDFdqIJponfOKxjaGGerU++g From: yarl-baudig@mailoo.org To: liliana.prikler@gmail.com, 55674@debbugs.gnu.org Date: Sun, 29 May 2022 11:09:12 +0200 (CEST) Subject: Re: [PATCH] gnu: emacs-helpful: Update to 209971b X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: In-Reply-To: <2f5f0d333b8a15a52ba25468cc3d3402229083c2.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55674 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Commit hashes are not versions. Furthermore, there has been more than > just that bugfix since =E2=80=93 as a workaround I think it'd be more > reasonable to just disable that one test until the next release. Or Erik =C5=A0abi=C4=8D might try its patch against version 0.19 then add = it to the package definition and let a comment that as soon as it is update= d to 0.20, the patch can go away? From debbugs-submit-bounces@debbugs.gnu.org Sun May 29 06:13:06 2022 Received: (at 55674) by debbugs.gnu.org; 29 May 2022 10:13:06 +0000 Received: from localhost ([127.0.0.1]:39431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvFv0-00024P-FG for submit@debbugs.gnu.org; Sun, 29 May 2022 06:13:06 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:36436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvFux-00023t-64 for 55674@debbugs.gnu.org; Sun, 29 May 2022 06:13:05 -0400 Received: by mail-ed1-f67.google.com with SMTP id fd25so10200276edb.3 for <55674@debbugs.gnu.org>; Sun, 29 May 2022 03:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=MxZhWXfljwcKyYRDhuqovE86i+oKlaV0OPvfgdkRn9k=; b=Gt6J85YNDsH1kZwopJrsBrq4Q15D5ZtoBzrMDE8WE685lurzDOiJzlFL2iUUgbXWrf bgUvQYmlrqezWWrGgNOayicTvw4Si3B+c+jk6LgVkEGeRjDcp+Pv4yBluTfM/kCp5Ehm sa++qbnqhql3dNOLmj1RqKkTATfRn6bx9NZYgAJv9Poc5FWp+rsRdMjm18e6CgyxgXK0 phP7MTCgXkfgamZCXnecfq6/qdd3Wwrw4JDC0OiRCp6zZqTvrYfp+CbUQ7qF3NRpZYUs QA9+uRPI26IRigEtTs3c8eH/8D6oQKSAXNWHCpd3p7racslK70TwQ9LA+Gb1qpplRFJY MJXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=MxZhWXfljwcKyYRDhuqovE86i+oKlaV0OPvfgdkRn9k=; b=EsFSytTZTXGqGw2YedUwVUQKaNds+sV6AKo7qELAnDCIArD0XCrYIihiqV/XbUkcwL T2a66n0gFNQpkqMCeJ1fbSmStFezvMpDRgKlFmNlG86v8FyCjTf5iKfY0kLZrSSWI/MJ PXNczA4aHJmtJ87cZ5RBK+tfdJ3+0GELAugJkBr8vJVxmWmlGX570X8Qx0QkVOjRHQDS mAAAklkFfmQt8NSHmg8kEiC8Lo2U9v2gDqmtodNzn0F0+9GH7/LOrhIzlHm14C7qDSU3 Yw8HpXB9cLC3y1bj1FCZUXK3XhoTozLtE/ZDMP0B2lJu3ap0G5X2gkSWyHON36FLf1ah M3qA== X-Gm-Message-State: AOAM531uZ8eVrbwyiPMdIKdLWdqDi0NOwRVFYJi9w/CIIacUvOlwzwHn m/OgoaoRU9cMxLYxgJSoHCE= X-Google-Smtp-Source: ABdhPJyKWSmHrJF8ntS7/bFcrSMkc4YYjphLSVrWwYwuC/F5wwWb2IkqJ5gcMB1DuRjRyYoRGRt3yA== X-Received: by 2002:a05:6402:10cc:b0:428:90ee:2572 with SMTP id p12-20020a05640210cc00b0042890ee2572mr53786241edu.103.1653819177228; Sun, 29 May 2022 03:12:57 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id cd26-20020a170906b35a00b006fee526ed72sm3032431ejb.217.2022.05.29.03.12.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 May 2022 03:12:56 -0700 (PDT) Message-ID: <37d8fb49b31dd974ffc7c02689ddee2e3b9d98f9.camel@gmail.com> Subject: Re: [PATCH] gnu: emacs-helpful: Update to 209971b From: Liliana Marie Prikler To: yarl-baudig@mailoo.org, 55674@debbugs.gnu.org Date: Sun, 29 May 2022 12:12:56 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55674 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 29.05.2022 um 11:09 +0200 schrieb yarl-baudig@mailoo.org: > > Commit hashes are not versions.  Furthermore, there has been more > > than just that bugfix since – as a workaround I think it'd be more > > reasonable to just disable that one test until the next release. > > Or Erik Šabič might try [their] patch against version 0.19 then add > it to the package definition and let a comment that as soon as it is > updated to 0.20, the patch can go away? That'd work too, but it'd be a slightly larger patch to create :) From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 03:20:35 2022 Received: (at 55674) by debbugs.gnu.org; 30 May 2022 07:20:35 +0000 Received: from localhost ([127.0.0.1]:42602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvZha-0007Fs-KZ for submit@debbugs.gnu.org; Mon, 30 May 2022 03:20:34 -0400 Received: from msg-1.mailo.com ([213.182.54.11]:35018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvZhX-0007Fe-Sg for 55674@debbugs.gnu.org; Mon, 30 May 2022 03:20:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailoo.org; s=mailo; t=1653895224; bh=vbvWYfmLIBO9PSyfiCptEDySOSeeKCE2l9oGqMBNYv4=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=TVXigIsMSiRFnxmZKdvX5WzCP/JV7wk8QWOR2Si2PrWg3TZ74ZZEkH6qFqPCHMPSJ nsU3t0Aqka+9Ou0HP12GxQKYrTclJ+RiX4val+7f2lNvSPo9lbw6sTKhCneQMrSVuQ N6X/7G5cByq/BkUfwtGr/SdYsbVULQ2cWx/McQ/I= Received: by www-8.mailo.com with http webmail; Mon, 30 May 2022 09:20:24 +0200 (CEST) X-EA-Auth: V1fgJ0yJiODkK5R3GqtBySlC0ACBo9IvpmrY7x6w7upsbsJwex2ih9gn9MSuBOCbfQABsB+TL6mT+VA5ykByVp3pcAd3xXaw From: yarl-baudig@mailoo.org To: liliana.prikler@gmail.com, 55674@debbugs.gnu.org Date: Mon, 30 May 2022 09:20:24 +0200 (CEST) Subject: [PATCH] gnu: emacs-helpful: Update to 0.19 X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: In-Reply-To: <37d8fb49b31dd974ffc7c02689ddee2e3b9d98f9.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55674 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Includes fixe for test from Erik =C5=A0abi=C4=8D against upstream, see details in the patch file. * gnu/packages/patches/emacs-helpful-fix-0.19-test.patch: New file. * gnu/packages/emacs-xyz.scm: Update emacs-helpful to 0.19, use the patch. * gnu/local.mk: Update dist_patch_DATA. --- gnu/local.mk | 1 + gnu/packages/emacs-xyz.scm | 7 ++++-- .../patches/emacs-helpful-fix-0.19-test.patch | 23 +++++++++++++++++++ 3 files changed, 29 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/emacs-helpful-fix-0.19-test.patch= diff --git a/gnu/local.mk b/gnu/local.mk index bc82c5ba9f..71f6b7669a 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1029,6 +1029,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/emacs-git-email-missing-parens.patch \ %D%/packages/patches/emacs-fix-scheme-indent-function.patch \ %D%/packages/patches/emacs-json-reformat-fix-tests.patch \ + %D%/packages/patches/emacs-helpful-fix-0.19-test.patch \ %D%/packages/patches/emacs-highlight-stages-add-gexp.patch \ %D%/packages/patches/emacs-hyperbole-toggle-messaging.patch \ %D%/packages/patches/emacs-libgit-use-system-libgit2.patch \ diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 31822dc641..c5fa725bf5 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -20131,7 +20131,7 @@ (define-public emacs-download-region (define-public emacs-helpful (package (name "emacs-helpful") - (version "0.18") + (version "0.19") (source (origin (method git-fetch) @@ -20140,7 +20140,10 @@ (define-public emacs-helpful (commit version))) (file-name (git-file-name name version)) (sha256 - (base32 "0gdjxykqkal2x765mi51m99i5ql23i1fy909wy4mzj5ajhjfgqcc")))= ) + (base32 "0qwsifzsjw95l83m7z07fr9h1sqbhggwmcps1qgbddpan2a8ab8a")) + ;; TODO: remove this patch as soon as the package is updated to 0.= 20 + ;; See explanation in the patch file + (patches (search-patches "emacs-helpful-fix-0.19-test.patch")))) (build-system emacs-build-system) (propagated-inputs (list emacs-elisp-refs emacs-dash emacs-s emacs-f emacs-shut-up)) diff --git a/gnu/packages/patches/emacs-helpful-fix-0.19-test.patch b/gnu/= packages/patches/emacs-helpful-fix-0.19-test.patch new file mode 100644 index 0000000000..64000f2b73 --- /dev/null +++ b/gnu/packages/patches/emacs-helpful-fix-0.19-test.patch @@ -0,0 +1,23 @@ +Erik =C5=A0abi=C4=8D sent a pull request (patches 741b864 and 209971b) ag= ainst 2f91e79, +which is not a release. +This is a diff between 0.19 and those 2 patches applied against 0.19. + +So, when 0.20 will be released, this patch can be removed. + +The procedure should be as simple as reverting the commit including +this file then calling `guix refresh emacs-helpful`. +diff --git a/test/helpful-unit-test.el b/test/helpful-unit-test.el +index a07aa8e..8a95129 100644 +--- a/test/helpful-unit-test.el ++++ b/test/helpful-unit-test.el +@@ -119,7 +119,9 @@ bar"))) + (should + (equal + (helpful--docstring #'test-foo-advised t) +- "Docstring here too."))) ++ (if (version< emacs-version "28") ++ "Docstring here too." ++ "Docstring here too.\n\nThis function has :around advice: `ad-Advice= -test-foo-advised'.")))) +=20 + (defun test-foo-no-docstring () + nil) --=20 2.36.0 From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 15:41:42 2022 Received: (at 55674) by debbugs.gnu.org; 30 May 2022 19:41:42 +0000 Received: from localhost ([127.0.0.1]:46103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvlGo-0001Fr-Dg for submit@debbugs.gnu.org; Mon, 30 May 2022 15:41:42 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:34672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvlGm-0001FU-93 for 55674@debbugs.gnu.org; Mon, 30 May 2022 15:41:40 -0400 Received: by mail-ej1-f68.google.com with SMTP id q21so22730116ejm.1 for <55674@debbugs.gnu.org>; Mon, 30 May 2022 12:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=fsMa3ipl9F7ljS45ik99Cmts7lEVQW5ymdiNnFbgKyE=; b=el6bq+UgUtKbdR/mb9rX2t9/Jsi6YIz0aMTFRMsqMHU46n/pXzzcFuQIBk7oqH0+5R GiR6mzbMGVYbH3MHqmMGe/lExBxWyDtTUj2hxOLMZahiU5a5mdi/5IB6T5Pr9WEIHOjY 8OqdLNMZRwTc4gwTTd3uBRmGcX0qzBajmcp4lcrna4s/ouySzefhH/YWMDe6p0KJbWA6 oaedIBBzyhPXJbCmD1LXGF/zYTxOomvN0PvPW8TJWGPKvZm3Pxun0iFKfM7+KFVZZp3S XimK3Y2iEnGjetrFUubZoa7V17gqnJbEVjnqRKIt5NauH5zewkA5dBkGvpjeRms5I1mz wFFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=fsMa3ipl9F7ljS45ik99Cmts7lEVQW5ymdiNnFbgKyE=; b=hcPpbEV4dALUL53BC51Q52DsDnAz1/H+yiH6k2/bjDIWkKVDkcEBNav5v7KIYH/04J O6lhGM/VDwkIPVa7MkJls+Asf7XHEbCGy1MFoYIrkgH0cZoaZ7Pw2WbWVTtq9CJhhWNB BCmLQ18Rm+Sdi6Wgl9PqYvJJebjSRaI6iI4NHnadspXw/iqmupYTP2PIFdkKiCZW6A3H DvgVqg8hGd8LhcX90Va3d3DHNDefJybmWmJUjEDcHy1jQqFnZk8hH4KqcogthsC2DnfY P1SiXIDHZdZ2LQSQYZySxO7Ovddcs1jGSqtImAwumNXatbEmg5cH1y5597CYo/jzqd9X Zv/Q== X-Gm-Message-State: AOAM530y89tt+ZqrrBN9XBi8LtuyVwb7IBhnTOSTk+QrnldZ+HbWqTAJ oCC6QpCTyxyti0KG6xN1Ja4= X-Google-Smtp-Source: ABdhPJzQimdh6Wt8LkO3Zj8nhRvjnvsGHO3RTwp/vZTJ7WcQDyEnvv5kZ9zIgD9h/vIvr6Hc+9tx+w== X-Received: by 2002:a17:907:3d01:b0:6e0:c63b:1992 with SMTP id gm1-20020a1709073d0100b006e0c63b1992mr51846662ejc.422.1653939694241; Mon, 30 May 2022 12:41:34 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id y17-20020a17090614d100b006fec56c57e6sm4278268ejc.46.2022.05.30.12.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 12:41:33 -0700 (PDT) Message-ID: Subject: Re: [PATCH] gnu: emacs-helpful: Update to 0.19 From: Liliana Marie Prikler To: yarl-baudig@mailoo.org, 55674@debbugs.gnu.org Date: Mon, 30 May 2022 21:41:32 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55674 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Montag, dem 30.05.2022 um 09:20 +0200 schrieb yarl-baudig@mailoo.org: > Includes fixe for test from Erik Šabič against upstream, > see details in the patch file. > > * gnu/packages/patches/emacs-helpful-fix-0.19-test.patch: New file. > * gnu/packages/emacs-xyz.scm: Update emacs-helpful to 0.19, use > the patch. > * gnu/local.mk: Update dist_patch_DATA. I locally applied your changes and would be ready to push, but noticed your mail client is not really set up well ;) For the sake of attribution, should I set "Yarl Baudig" or something else as committer name? From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 17:12:10 2022 Received: (at 55674) by debbugs.gnu.org; 30 May 2022 21:12:10 +0000 Received: from localhost ([127.0.0.1]:46189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvmgL-0004gT-T0 for submit@debbugs.gnu.org; Mon, 30 May 2022 17:12:10 -0400 Received: from ip-15.mailobj.net ([213.182.54.15]:43366 helo=msg-4.mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvmgI-0004fq-3M for 55674@debbugs.gnu.org; Mon, 30 May 2022 17:12:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailoo.org; s=mailo; t=1653945119; bh=Ar7gIciKdFnjwSBWWkZdiJA1e/eMIiv3vKkC/MzrsTs=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=NkyRYFhuXUpN5Lzaj/JqkRETkCPHVTZvae/kdiSXVwhVjMDF6XbXcS/F4OpU4viht idZVTtVyuDU8pzTGY484U7CBbb73syyXsROyuubfmJxyI4zGKFPKcvEx397VoUEELs eFmfZoargEY3ywRipEBXKs9BPx/YaPPD6La5Yxtw= Received: by www-8.mailo.com with http webmail; Mon, 30 May 2022 23:11:59 +0200 (CEST) X-EA-Auth: Jq731EWVG6owx+2PoY0K1pYyrqwGgFgh6cYDXfC3gjqH6MMlGp18OaxhNkjabLPm9zzR/jLl3Kr45hhWYK3JIz6FjmoBFN59 From: "yarl baudig" To: liliana.prikler@gmail.com, 55674@debbugs.gnu.org Date: Mon, 30 May 2022 23:11:59 +0200 (CEST) Subject: Re: [PATCH] gnu: emacs-helpful: Update to 0.19 X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55674 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > your mail client is not really set up well ;) >=20 > For the sake of attribution, should I set "Yarl Baudig" or something > else as committer name? >=20 Yes, please. I will try to fix this. Thank you! From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 03:00:27 2022 Received: (at 55674-done) by debbugs.gnu.org; 4 Jun 2022 07:00:27 +0000 Received: from localhost ([127.0.0.1]:57518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxNlr-0004KI-8Q for submit@debbugs.gnu.org; Sat, 04 Jun 2022 03:00:27 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:41567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxNlo-0004K4-Se for 55674-done@debbugs.gnu.org; Sat, 04 Jun 2022 03:00:26 -0400 Received: by mail-ej1-f68.google.com with SMTP id u12so19698324eja.8 for <55674-done@debbugs.gnu.org>; Sat, 04 Jun 2022 00:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=3Id5k+jlgyqGH/ohl0j0wEDiM3KjAHeIkLTw8PJoSwE=; b=jdEFSp5AtHzUWBeK3T9pauzyAz2ioTrGA23d4EvZilhyZGypQTFFh5JZiowemy61Jw gJPcKCZp6kZY/WiGEoOVxbM4HP7BqUUAFQkmjd5o8Th7WhWf0+FVEyHP3Twwcda8rU2R +q8aUAcc+UfHjwy8upDkTxYmxnjt8tJ3wN8nGvQCqSTTWkhxCEkgBkm0yeHP7WV+eZLd uX0cU+ZPNAM0cx+5sG1W+/9uzyA0ZRUhVs+jfnPBEWnCUzQUJxhgIrBnc1NpwkiVkyKW cTzlxIghjNESFVh/zjJTx4WJdxULbDUoNY07aE6B7nl7aERDAntNLvQOCoRPbVK5bOal qF5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=3Id5k+jlgyqGH/ohl0j0wEDiM3KjAHeIkLTw8PJoSwE=; b=drXyUCOrx4HNJv7eOie6cPjZGz4nsEC7+15zQEoz3YhP4hQhZlF/rR3IVhzhA1LDKy wmDjiOG5krmTon/LcXlQ1vFEtpTq5ifxXe4A8sIPZN6UrGCYSRYkknV4zBcBvv5nAUep /zNbZZ/4K1aUj+DHM997erVYu76rNpjz0I3f+6mNypXi5KtDraGlEI5eLNsrim2lOW0K +zq0a2j5+t9+kjkigHohhiZY/9RIcqWPpyoim0PQ6c+RZ2R8j3b2BIPJJMnKfwmY0+OZ eULX2jGiI29pmITRDm1Zd85HWbIkkfdAJ263K5flhThvd9LzjZsgIGlAndghbsliPxKE IE4w== X-Gm-Message-State: AOAM530egJ10pmwWxuxDyi63E+xI7YMo2Po0eqQknpU+bgFJWaVjwX/g vLYj9ezssGxeJPV8RBih4j0= X-Google-Smtp-Source: ABdhPJzfxiSyKmcyrqeGq0fqU0bMhNRidvFLutITBNWJVkTJxjuQSjfEinsHpcTt4sjiRlUZXI567w== X-Received: by 2002:a17:907:6e1e:b0:6ff:47aa:1288 with SMTP id sd30-20020a1709076e1e00b006ff47aa1288mr11708670ejc.397.1654326018829; Sat, 04 Jun 2022 00:00:18 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id f22-20020a1709067f9600b006f3ef214db6sm3634109ejr.28.2022.06.04.00.00.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jun 2022 00:00:18 -0700 (PDT) Message-ID: <89a9bf5beee51afb4edb0a3ed39f5904421a9872.camel@gmail.com> Subject: Re: [PATCH] gnu: emacs-helpful: Update to 0.19 From: Liliana Marie Prikler To: yarl baudig , 55674-done@debbugs.gnu.org Date: Sat, 04 Jun 2022 09:00:17 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55674-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Montag, dem 30.05.2022 um 23:11 +0200 schrieb yarl baudig: > > your mail client is not really set up well ;) > > > > For the sake of attribution, should I set "Yarl Baudig" or > > something > > else as committer name? > > > > Yes, please. I will try to fix this. > Thank you! Used "yarl baudig" as per this mail. From unknown Fri Jun 20 07:25:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 02 Jul 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator