GNU bug report logs - #55663
[PATCH] Image API: add FAT32 support

Previous Next

Full log

View this message in rfc822 format

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Pavel Shlyak <p.shlyak <at> pantherx.org>
Cc: 55663 <at> debbugs.gnu.org
Subject: [bug#55663] [PATCH] Image API: add FAT32 support
Date: Mon, 30 May 2022 09:01:18 +0200

Hello Pavel,

>  gnu/build/image.scm  | 24 ++++++++++++++----------
>  gnu/system/image.scm |  9 +++++++--

Please write a commit message following the guidelines available here:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

> +(define* (make-vfat-image partition target root fs_bits)

s/fs_bits/fs-bits/

> +         ((or (string=? file-system "vfat") (string=? file-system "fat16")) "0x0E")

This line is longer than 78 characters you can break it between the two
strings comparisons.

> +         (
> +          (or (string=? file-system "vfat")

Merge those two lines.

> +              (string=? file-system "fat32")
> +              ) "F")

Ditto.

Can you please send a v2?

Thanks for your contribution,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.