GNU bug report logs - #55663
[PATCH] Image API: add FAT32 support

Previous Next

Full log

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pavel Shlyak <p.shlyak <at> pantherx.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: guix-patches <at> gnu.org, 55663 <at> debbugs.gnu.org
Subject: Re: [bug#55663] [PATCH] Image API: add FAT32 support
Date: Thu, 26 May 2022 23:54:45 +0300

[Message part 1 (text/plain, inline)]

Thank you for a quick response!
I have changed it according to your recommendations. I hope it’s better now.

[0001-Image-API-support-FAT32-partitions.patch (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

> 26 мая 2022 г., в 21:07, Tobias Geerinckx-Rice <me <at> tobias.gr> написал(а):
> 
> Hi Pavel,
> 
> Pavel Shlyak 写道：
>> I believe it is an important change as Raspberry PI (and I suppose some other boards) cannot boot with fat16 boot partitions. 
> 
> LGTM in principle.
> 
> The FS_BITS argument should be a regular number.  You can coerce it with number->string in the command line.
> 
> On the subject of being explicit is good: we should add "fat16" type and treat "vfat" as a softly deprecated alias.  But that can be done in a later patch.
> 
> Kind regards,
> 
> T G-R

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.