From unknown Thu Aug 14 22:24:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55663] [PATCH] Image API: add FAT32 support Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 May 2022 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55663@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165358815029842 (code B ref -1); Thu, 26 May 2022 18:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2022 18:02:30 +0000 Received: from localhost ([127.0.0.1]:59937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuHob-0007lF-Vr for submit@debbugs.gnu.org; Thu, 26 May 2022 14:02:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:48778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuHoa-0007l6-Hi for submit@debbugs.gnu.org; Thu, 26 May 2022 14:02:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuHoa-00041H-9V for guix-patches@gnu.org; Thu, 26 May 2022 14:02:28 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:55437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuHoY-0006yM-Eb for guix-patches@gnu.org; Thu, 26 May 2022 14:02:28 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CF0915C0184 for ; Thu, 26 May 2022 14:02:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 26 May 2022 14:02:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1653588145; x=1653674545; bh=cDVeun3lUPhbXR542NrmU5vSJNlVveVojLZ OwsVmalo=; b=RYt+MXLifizbp7Fc5waRoM73kZhI1LCR93L8i8KIcH1FZR7XZOP Z5wrkH+3xdcvOMwqlwxx/Kpn5C/qRBN4tCI/ZTiHFgnDV/+qC74TLASgRSV3y00W YfSeF3MSwzdi28PjGA9VXQz2mn38P3KQnpohAcsEG6eeeQqxcS3DMHSYgSFXUERd 65HQjH3cwxDokvp36md2eFQPA8wp0Tp6SlyTps+mkG52vdnBRz15fTxpvIz32Khz OqUNa+FcZWN9Bm2a2jji6oEhpuxSw1QTnH5CaIXzDyVcEkng86P1vcNLmaEzTbvc BTVUB/7XByAwn37iXirpiLNLMDjqnER6kOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653588145; x= 1653674545; bh=cDVeun3lUPhbXR542NrmU5vSJNlVveVojLZOwsVmalo=; b=B fCDrx8Thx4u9KL1+LI9E5l/F0ejwXyJwr8kbMTqjxODSZZLz4JhGHaWF+hWuwXWp nxBH/GxpBhpMF0lI9YOCp57qYIC6CpSS0YrwV9zTyeOTQfX3pKgrFkItBlGe9qfE I+0w41Bg4WZIV/Y9+KNHFQAy5JBW6sJPP1lBX7QF6FTzLiQ5BlO8ntkYLNlA09pr v6XkGMsK8Oi64MrRo8MfAD7uAGPYMVmZekuqI8MJ8VfnDjKoNEz6dm7TakDqzLJH 7AIHpVpOgY3IBaDj5sLH6efpCCY22xsT31899DU6xqX5Uy7cPu3k8M7b519xK3xn qW8yZnRSw3thiOTQQpKjA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeejgdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhtggguffkfffvofesmhdtmherhh dtvdenucfhrhhomheprfgrvhgvlhcuufhhlhihrghkuceophdrshhhlhihrghksehprghn thhhvghrgidrohhrgheqnecuggftrfgrthhtvghrnhepjeeiheefieevtefghfegveefhe duffekfeegkeegkefghfefleeljeegvdfhledunecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepphdrshhhlhihrghksehprghnthhhvghrgidroh hrgh X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 26 May 2022 14:02:24 -0400 (EDT) From: Pavel Shlyak Content-Type: multipart/mixed; boundary="Apple-Mail=_F2A75323-9AA7-4BAF-A554-A2E6B8C3D50F" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Message-Id: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> Date: Thu, 26 May 2022 21:02:22 +0300 X-Mailer: Apple Mail (2.3696.100.31) Received-SPF: pass client-ip=66.111.4.28; envelope-from=p.shlyak@pantherx.org; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --Apple-Mail=_F2A75323-9AA7-4BAF-A554-A2E6B8C3D50F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii I believe it is an important change as Raspberry PI (and I suppose some = other boards) cannot boot with fat16 boot partitions.=20 With this patch, "vfat" is treated as fat16 partition not to break = backward-compatibility. "fat32", on the other hand, creates a fat32 = partition. --Apple-Mail=_F2A75323-9AA7-4BAF-A554-A2E6B8C3D50F Content-Disposition: attachment; filename=0001-Image-API-support-FAT32-partitions.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Image-API-support-FAT32-partitions.patch" Content-Transfer-Encoding: quoted-printable =46rom=200700c443d9162ac4928ac8fee58278c1f0824736=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pavel=20Shlyak=20=0A= Date:=20Thu,=2026=20May=202022=2021:00:51=20+0300=0ASubject:=20[PATCH]=20= Image=20API:=20support=20FAT32=20partitions=0A=0A---=0A=20= gnu/build/image.scm=20=20|=208=20+++++---=0A=20gnu/system/image.scm=20|=20= 2=20++=0A=202=20files=20changed,=207=20insertions(+),=203=20deletions(-)=0A= =0Adiff=20--git=20a/gnu/build/image.scm=20b/gnu/build/image.scm=0Aindex=20= 3e8b94e2d6..804685c7fb=20100644=0A---=20a/gnu/build/image.scm=0A+++=20= b/gnu/build/image.scm=0A@@=20-95,12=20+95,12=20@@=20(define*=20= (make-ext-image=20partition=20target=20root=0A=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (estimate-partition-size=20root)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20size)))))))=0A=20=0A= -(define*=20(make-vfat-image=20partition=20target=20root)=0A+(define*=20= (make-vfat-image=20partition=20target=20root=20fs_bits)=0A=20=20=20= "Handle=20the=20creation=20of=20VFAT=20partition=20images.=20=20See=20= 'make-partition-image'."=0A=20=20=20(let=20((size=20(partition-size=20= partition))=0A=20=20=20=20=20=20=20=20=20(label=20(partition-label=20= partition)))=0A=20=20=20=20=20(invoke=20"fakeroot"=20"mkdosfs"=20"-n"=20= label=20"-C"=20target=0A-=20=20=20=20=20=20=20=20=20=20=20=20"-F"=20"16"=20= "-S"=20"1024"=0A+=20=20=20=20=20=20=20=20=20=20=20=20"-F"=20fs_bits=20= "-S"=20"1024"=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(size-in-kib=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(if=20(eq?=20size=20'guess)=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(estimate-partition-size=20= root)=0A@@=20-121,7=20+121,9=20@@=20(define*=20(make-partition-image=20= partition-sexp=20target=20root)=0A=20=20=20=20=20=20((string-prefix?=20= "ext"=20type)=0A=20=20=20=20=20=20=20(make-ext-image=20partition=20= target=20root))=0A=20=20=20=20=20=20((string=3D?=20type=20"vfat")=0A-=20=20= =20=20=20=20(make-vfat-image=20partition=20target=20root))=0A+=20=20=20=20= =20=20(make-vfat-image=20partition=20target=20root=20"16"))=0A+=20=20=20=20= =20((string=3D?=20type=20"fat32")=0A+=20=20=20=20=20=20(make-vfat-image=20= partition=20target=20root=20"32"))=0A=20=20=20=20=20=20(else=0A=20=20=20=20= =20=20=20(raise=20(condition=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(&message=0Adiff=20--git=20a/gnu/system/image.scm=20= b/gnu/system/image.scm=0Aindex=20dd32e58c2d..0dd16ed34e=20100644=0A---=20= a/gnu/system/image.scm=0A+++=20b/gnu/system/image.scm=0A@@=20-313,6=20= +313,7=20@@=20(define=20(partition->dos-type=20partition)=0A=20=20=20=20=20= =20=20=20=20=20((member=20'esp=20flags)=20"0xEF")=0A=20=20=20=20=20=20=20= =20=20=20((string-prefix?=20"ext"=20file-system)=20"0x83")=0A=20=20=20=20= =20=20=20=20=20=20((string=3D?=20file-system=20"vfat")=20"0x0E")=0A+=20=20= =20=20=20=20=20=20=20((string=3D?=20file-system=20"fat32")=20"0x0C")=0A=20= =20=20=20=20=20=20=20=20=20(else=0A=20=20=20=20=20=20=20=20=20=20=20= (raise=20(condition=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(&message=0A@@=20-330,6=20+331,7=20@@=20(define=20= (partition->gpt-type=20partition)=0A=20=20=20=20=20=20=20=20=20=20= ((member=20'esp=20flags)=20"U")=0A=20=20=20=20=20=20=20=20=20=20= ((string-prefix?=20"ext"=20file-system)=20"L")=0A=20=20=20=20=20=20=20=20= =20=20((string=3D?=20file-system=20"vfat")=20"F")=0A+=20=20=20=20=20=20=20= =20=20((string=3D?=20file-system=20"fat32")=20"F")=0A=20=20=20=20=20=20=20= =20=20=20(else=0A=20=20=20=20=20=20=20=20=20=20=20(raise=20(condition=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(&message=0A--=20=0A= 2.32.1=20(Apple=20Git-133)=0A=0A= --Apple-Mail=_F2A75323-9AA7-4BAF-A554-A2E6B8C3D50F-- From unknown Thu Aug 14 22:24:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55663] [PATCH] Image API: add FAT32 support Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 May 2022 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pavel Shlyak Cc: 55663@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 55663@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165358930231610 (code B ref -1); Thu, 26 May 2022 18:22:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2022 18:21:42 +0000 Received: from localhost ([127.0.0.1]:59956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuI7C-0008Dl-4j for submit@debbugs.gnu.org; Thu, 26 May 2022 14:21:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:57204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuI7A-0008De-Mn for submit@debbugs.gnu.org; Thu, 26 May 2022 14:21:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuI7A-0003c2-Hk for guix-patches@gnu.org; Thu, 26 May 2022 14:21:40 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:53548) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuI77-0001Sn-3u for guix-patches@gnu.org; Thu, 26 May 2022 14:21:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=NJV9QLX7QjIVe 0YsqMgo6f/QgV2CpTCTV2s2EhBIBSE=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=QmJDYetI825KZYJLtWtbZ/01AyOuNsv3NtE8EB NJ2j74sEldA6IHbvyQc+U/ZnLDucR/oHgAmwbGZHTIqmPO1nU740Er22p0OQ3aDcvdbvcL VuITN8uOokPFTsc0mX7J8rWRFl+kKV4j1X3YFmngeUIj7YLFHlf9Bxs6Gz28wLXu7OqY2u s/PhqgxP8GaE7gRDJGc0oWJqXNSYbFgW9yorXgkmKsVBwrVJ832JYb2gXAPmQnZLP4a0+a vek3M+E+x3LUXuSkZt2k4eZfNl/rrs5goDGMqpI2BTuYGC/qNSmYul7eZ3DCZFfMtrGH6A pThZxJHJUrlRpwlf/RKCZM0w== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 64dc39f4 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 26 May 2022 18:21:32 +0000 (UTC) References: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> From: Tobias Geerinckx-Rice Date: Thu, 26 May 2022 20:07:56 +0200 In-reply-to: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87bkvk6tp0@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Pavel, Pavel Shlyak =E5=86=99=E9=81=93=EF=BC=9A > I believe it is an important change as Raspberry PI (and I=20 > suppose some other boards) cannot boot with fat16 boot=20 > partitions.=20 LGTM in principle. The FS_BITS argument should be a regular number. You can coerce=20 it with number->string in the command line. On the subject of being explicit is good: we should add "fat16"=20 type and treat "vfat" as a softly deprecated alias. But that can=20 be done in a later patch. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYo/FKw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15v/oA/0mmvcJbt4k2Qt186TpOF7ig4VrZm+zMDIoOyjLV yC58AP4+iXSPi6tjXd8+Ya6adpJVdFx2Hz9xbpxJ9pv3M7F+BA== =jX82 -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Aug 14 22:24:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55663] [PATCH] Image API: add FAT32 support Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 May 2022 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 55663@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 55663@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165359849422537 (code B ref -1); Thu, 26 May 2022 20:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2022 20:54:54 +0000 Received: from localhost ([127.0.0.1]:60165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuKVR-0005rR-Tc for submit@debbugs.gnu.org; Thu, 26 May 2022 16:54:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:51958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuKVP-0005rD-QD for submit@debbugs.gnu.org; Thu, 26 May 2022 16:54:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuKVP-0007tM-D4 for guix-patches@gnu.org; Thu, 26 May 2022 16:54:51 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuKVN-0001kF-99 for guix-patches@gnu.org; Thu, 26 May 2022 16:54:51 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 760165C0193; Thu, 26 May 2022 16:54:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 26 May 2022 16:54:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1653598488; x=1653684888; bh=BxI/DT3j/7 clPswdEjlavrCB5aRbkD2pjWhBbT+aXgw=; b=mVts17JdIyClLSijnS2SmMyK04 XtPQnO09AB7KgWP/ao1/aVhf4rToHs/7KfqeZUJIbqefoLt+lWrz1VKOE8HSueSF 7aNLY6pTIjXd3qyAiiGjeuKYKwyj57EGGuIDmjDz4Faal4myq/URwkBvgymphTY8 Eb5GKoJQiPnCsbs6G3NkoYDcvzlt9fPMjqzm/6N4juVWARVyL7+Z54Xcanhuc4le GwmNpyO41JMFgw2I+AwyuNG7HcnLREW2rb7Ge7s/xkyPW3V57RcezztBedFZm/T9 F2AXE1QP7+zIGhswDpD0dgjVXvU3bGQrMnyF/qYB82PTKWIq8EiAFvSANaVw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653598488; x=1653684888; bh=BxI/DT3j/7clPswdEjlavrCB5aRb kD2pjWhBbT+aXgw=; b=DNYYi3dE1hRnDcc/lUff97mFaqpDI3Rs0eYBT/guSPPG 3/hQghpfwPMDgL9EMEdzqOIsTeQA4E+q5uoP1sudnXHkEiSek9RtuqG+TtAycOJa hpe7BBH8wCPJhAxaNsm+uiU2RVciNRz0UnNELgTTE4xfFEMRGVN9PEVzV8HmGkW5 t3BNq2oRdUwtnEwPl6BL8qv6py8o2sQfUKsnGLDyVs7HRVKJtUoggaqmdTCuiz1X oVOeZwi5+vqcDbBS7ynAeNsbq3cExGlky5VEnQaawKRiufrwXSHpIzeYq5P5ymni H/qzVOfnYxEkrlyyjO8dQzY1TczxhtxyLkjYFxqNxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeejgdduheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhkfgtggfuffgjvefvfhfosehmtd hmrehhtdejnecuhfhrohhmpefrrghvvghlucfuhhhlhigrkhcuoehprdhshhhlhigrkhes phgrnhhthhgvrhigrdhorhhgqeenucggtffrrghtthgvrhhnpeekgeekkeekfeetveekhe fhjedtudfgueelhefhueeghfefieduhfetlefgieefleenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehprdhshhhlhigrkhesphgrnhhthhgvrh igrdhorhhg X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 May 2022 16:54:47 -0400 (EDT) From: Pavel Shlyak Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_2E6922ED-680E-4C45-B1C2-6EEBB686F909" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Date: Thu, 26 May 2022 23:54:45 +0300 In-Reply-To: <87bkvk6tp0@nckx> References: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> <87bkvk6tp0@nckx> X-Mailer: Apple Mail (2.3696.100.31) Received-SPF: pass client-ip=66.111.4.25; envelope-from=p.shlyak@pantherx.org; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --Apple-Mail=_2E6922ED-680E-4C45-B1C2-6EEBB686F909 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Thank you for a quick response! I have changed it according to your recommendations. I hope it=E2=80=99s = better now. --Apple-Mail=_2E6922ED-680E-4C45-B1C2-6EEBB686F909 Content-Disposition: attachment; filename=0001-Image-API-support-FAT32-partitions.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Image-API-support-FAT32-partitions.patch" Content-Transfer-Encoding: quoted-printable =46rom=208128aa174f76646eedbf94c3f03cf1cff0f304d0=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pavel=20Shlyak=20=0A= Date:=20Thu,=2026=20May=202022=2021:00:51=20+0300=0ASubject:=20[PATCH]=20= Image=20API:=20support=20FAT32=20partitions=0A=0A---=0A=20= gnu/build/image.scm=20=20|=2010=20++++++----=0A=20gnu/system/image.scm=20= |=20=209=20+++++++--=0A=202=20files=20changed,=2013=20insertions(+),=206=20= deletions(-)=0A=0Adiff=20--git=20a/gnu/build/image.scm=20= b/gnu/build/image.scm=0Aindex=203e8b94e2d6..d1398144a5=20100644=0A---=20= a/gnu/build/image.scm=0A+++=20b/gnu/build/image.scm=0A@@=20-95,12=20= +95,12=20@@=20(define*=20(make-ext-image=20partition=20target=20root=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(estimate-partition-size=20root)=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20size)))))))=0A=20=0A= -(define*=20(make-vfat-image=20partition=20target=20root)=0A+(define*=20= (make-vfat-image=20partition=20target=20root=20fs_bits)=0A=20=20=20= "Handle=20the=20creation=20of=20VFAT=20partition=20images.=20=20See=20= 'make-partition-image'."=0A=20=20=20(let=20((size=20(partition-size=20= partition))=0A=20=20=20=20=20=20=20=20=20(label=20(partition-label=20= partition)))=0A=20=20=20=20=20(invoke=20"fakeroot"=20"mkdosfs"=20"-n"=20= label=20"-C"=20target=0A-=20=20=20=20=20=20=20=20=20=20=20=20"-F"=20"16"=20= "-S"=20"1024"=0A+=20=20=20=20=20=20=20=20=20=20=20=20"-F"=20= (number->string=20fs_bits)=20"-S"=20"1024"=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20(size-in-kib=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20(if=20= (eq?=20size=20'guess)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(estimate-partition-size=20root)=0A@@=20-120,8=20+120,10=20@@=20= (define*=20(make-partition-image=20partition-sexp=20target=20root)=0A=20=20= =20=20=20(cond=0A=20=20=20=20=20=20((string-prefix?=20"ext"=20type)=0A=20= =20=20=20=20=20=20(make-ext-image=20partition=20target=20root))=0A-=20=20= =20=20=20((string=3D?=20type=20"vfat")=0A-=20=20=20=20=20=20= (make-vfat-image=20partition=20target=20root))=0A+=20=20=20=20=20((or=20= (string=3D?=20type=20"vfat")=20(string=3D?=20type=20"fat16"))=0A+=20=20=20= =20=20=20(make-vfat-image=20partition=20target=20root=2016))=0A+=20=20=20= =20=20((string=3D?=20type=20"fat32")=0A+=20=20=20=20=20=20= (make-vfat-image=20partition=20target=20root=2032))=0A=20=20=20=20=20=20= (else=0A=20=20=20=20=20=20=20(raise=20(condition=0A=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(&message=0Adiff=20--git=20a/gnu/system/image.scm=20= b/gnu/system/image.scm=0Aindex=20dd32e58c2d..7e45f750d9=20100644=0A---=20= a/gnu/system/image.scm=0A+++=20b/gnu/system/image.scm=0A@@=20-312,7=20= +312,8=20@@=20(define=20(partition->dos-type=20partition)=0A=20=20=20=20=20= =20=20=20=20(cond=0A=20=20=20=20=20=20=20=20=20=20((member=20'esp=20= flags)=20"0xEF")=0A=20=20=20=20=20=20=20=20=20=20((string-prefix?=20= "ext"=20file-system)=20"0x83")=0A-=20=20=20=20=20=20=20=20=20((string=3D?=20= file-system=20"vfat")=20"0x0E")=0A+=20=20=20=20=20=20=20=20=20((or=20= (string=3D?=20file-system=20"vfat")=20(string=3D?=20file-system=20= "fat16"))=20"0x0E")=0A+=20=20=20=20=20=20=20=20=20((string=3D?=20= file-system=20"fat32")=20"0x0C")=0A=20=20=20=20=20=20=20=20=20=20(else=0A= =20=20=20=20=20=20=20=20=20=20=20(raise=20(condition=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(&message=0A@@=20-329,7=20+330,11=20= @@=20(define=20(partition->gpt-type=20partition)=0A=20=20=20=20=20=20=20=20= =20(cond=0A=20=20=20=20=20=20=20=20=20=20((member=20'esp=20flags)=20"U")=0A= =20=20=20=20=20=20=20=20=20=20((string-prefix?=20"ext"=20file-system)=20= "L")=0A-=20=20=20=20=20=20=20=20=20((string=3D?=20file-system=20"vfat")=20= "F")=0A+=20=20=20=20=20=20=20=20=20(=0A+=20=20=20=20=20=20=20=20=20=20= (or=20(string=3D?=20file-system=20"vfat")=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(string=3D?=20file-system=20"fat16")=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(string=3D?=20file-system=20"fat32")=0A+=20=20=20=20= =20=20=20=20=20=20=20=20=20=20)=20"F")=0A=20=20=20=20=20=20=20=20=20=20= (else=0A=20=20=20=20=20=20=20=20=20=20=20(raise=20(condition=0A=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(&message=0A--=20=0A2.32.1=20= (Apple=20Git-133)=0A=0A= --Apple-Mail=_2E6922ED-680E-4C45-B1C2-6EEBB686F909 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > 26 =D0=BC=D0=B0=D1=8F 2022 =D0=B3., =D0=B2 21:07, Tobias = Geerinckx-Rice =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0= =B0): >=20 > Hi Pavel, >=20 > Pavel Shlyak =E5=86=99=E9=81=93=EF=BC=9A >> I believe it is an important change as Raspberry PI (and I suppose = some other boards) cannot boot with fat16 boot partitions.=20 >=20 > LGTM in principle. >=20 > The FS_BITS argument should be a regular number. You can coerce it = with number->string in the command line. >=20 > On the subject of being explicit is good: we should add "fat16" type = and treat "vfat" as a softly deprecated alias. But that can be done in = a later patch. >=20 > Kind regards, >=20 > T G-R --Apple-Mail=_2E6922ED-680E-4C45-B1C2-6EEBB686F909-- From unknown Thu Aug 14 22:24:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55663] [PATCH] Image API: add FAT32 support Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 29 May 2022 11:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 55663@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 55663@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165382480525982 (code B ref -1); Sun, 29 May 2022 11:47:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 May 2022 11:46:45 +0000 Received: from localhost ([127.0.0.1]:39510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvHNd-0006l0-87 for submit@debbugs.gnu.org; Sun, 29 May 2022 07:46:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:54332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvHNa-0006kq-GC for submit@debbugs.gnu.org; Sun, 29 May 2022 07:46:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvHNY-0005CB-Hx for guix-patches@gnu.org; Sun, 29 May 2022 07:46:41 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:55403) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvHNU-0001iX-9Z for guix-patches@gnu.org; Sun, 29 May 2022 07:46:39 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7D0D35C00D0; Sun, 29 May 2022 07:46:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 29 May 2022 07:46:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1653824790; x= 1653911190; bh=ZeswJjVNNZZ26wInIJny3h3nnfEucuBDnrUXx+G45MU=; b=A 4G/Bbk2jmg200Q2HEyNydyskCpEBbxdu2Qh0ULwVE4L5NcPtGMHVQAkk1WFnxXB/ ONFh+d6J8X9XSdkAYzoMv+qaciRYPP9Db/N3y9N0g+HbT1KiIHb2DukTlvV743Nj K8wf4QtbR5kRbFXcXU/dOpadNVp6pRHtXYdcrz4hF1Rq6cmwbmKxKHtbMMo1vY41 dll06OO7OqfSowtfHM99p1JZaShc9Rv41pP8epUOSi6PDkW84VFzjgsIJA3YP58k VuqsAYQxSK/xDl4JyJMZMU2bIxZS9vOW4ERtBqo+1K80PXLN9duOOMP0VsN22hd9 MxitmL6nSHN4E0VsC6YdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653824790; x= 1653911190; bh=ZeswJjVNNZZ26wInIJny3h3nnfEucuBDnrUXx+G45MU=; b=i Um4F7LG47luOqwxV1S5M9O2chZIuQRdgi6J5PVViUmG4ISCd/5PRf0Y130uBaeER ucuq3mXiDyZVwKWctbJaIOoc2++UjZGk38EkNZN5HI0Hc1bYDAojBInFsHmIfDRU CeY7tU4zUDOfc1gAwVC+s5A9du7NGaKTB5eNj6wsxRblCem6beIJXylzHSXrki91 nyEnkJPofgaD4w2/28Px4O3EAIHT4caS5T0iK3NTqUYRKTu5f4zzrBvWkf1L9nXe rjJhGFTodkAmK0s3Psw2Cz22B4W2yGgKShAeR+7RzkDCiGVajMbU9D4kdMsZ0eVH /Z3YJ11zr18rRYjTousIQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrkeeggdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurheptggguffhjgffvefgkfhfvffosehtqh hmtdhhtdejnecuhfhrohhmpefrrghvvghlucfuhhhlhigrkhcuoehprdhshhhlhigrkhes phgrnhhthhgvrhigrdhorhhgqeenucggtffrrghtthgvrhhnpefhtdfhvdduffelueevff etteegleettdetvefgleevueeuudefhffhkedtvdevfeenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehprdhshhhlhigrkhesphgrnhhthhgvrh igrdhorhhg X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 29 May 2022 07:46:29 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) From: Pavel Shlyak In-Reply-To: Date: Sun, 29 May 2022 14:46:27 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <6C6B28B2-B753-4A55-9CCD-05AB16EDB733@pantherx.org> References: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> <87bkvk6tp0@nckx> X-Mailer: Apple Mail (2.3696.100.31) Received-SPF: pass client-ip=66.111.4.25; envelope-from=p.shlyak@pantherx.org; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Please, do not merge that until further notice. It looks like there=E2=80=99= s a problem with the code. From unknown Thu Aug 14 22:24:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55663] [PATCH] Image API: add FAT32 support References: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> In-Reply-To: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 29 May 2022 14:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55663@debbugs.gnu.org Received: via spool by 55663-submit@debbugs.gnu.org id=B55663.16538349614823 (code B ref 55663); Sun, 29 May 2022 14:36:01 +0000 Received: (at 55663) by debbugs.gnu.org; 29 May 2022 14:36:01 +0000 Received: from localhost ([127.0.0.1]:41587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvK1R-0001Fg-0H for submit@debbugs.gnu.org; Sun, 29 May 2022 10:36:01 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:57527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvK1O-0001FS-Dx for 55663@debbugs.gnu.org; Sun, 29 May 2022 10:35:59 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 119B25C0032 for <55663@debbugs.gnu.org>; Sun, 29 May 2022 10:35:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 29 May 2022 10:35:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1653834953; x=1653921353; bh=dhyh9nTIHJOXpUneHKRZceqbDcq78OlcQoA 7WpMqNhA=; b=qI1MpBgvZFnHVUS/c1+AlTin25dp7aHOqXjit9CZd5TvDqqF1p3 b5hIp7NI3Dghu4oDf7coxDo799ayLFbpteFyUp46Y3zJSpjeQ44EIduAOj1Jd7XS q4DkmWi+fuzk1lahljToqArl1v3hp4g4ikvJ5A/Z68t5glOVHk0luLgfNh+TBXiA 2qIMA0a780+iOPw1NKxcFH9qI0QyTNkV+W79k07nekDPrH63dKQPAK1AKtoBEfEj r1q8AH4Ypl4J5XolvQiAfVtIwqt67eAWMVJEUIiRQLa1zJvFmpeosqe1b3SSyj/p BVt5Ap4NQt0O8/MwCXj/SnX5F+b86W/iwWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653834953; x= 1653921353; bh=dhyh9nTIHJOXpUneHKRZceqbDcq78OlcQoA7WpMqNhA=; b=V +ER4wvyyd7EWiNXpgCg/KgsIQND9qJN1Ze4o7MZYd3cvmPO22M1IbebOK5KCTDF9 COef2JXnO6lAvPn1wbt7U86ryhFS1cWgHS6yZ7rXxHN1j8bP/P/271cYZ+469VMa 5sCoxoK4HnScxSc5owUjxNTzoA3gcNbJOzR81K8pUGjN5PC3LHr/vyg9tLniQu9C g+Lq5sjAznNvzKkB5e25VhYobOYPz5ul0LmGR6EnzVrGgVz236lAGZ0qgs3SKwtG xIvffqOVX7dHEFEzrJXmE3c9aFqmH5DUbk2F6eGKV4SN0VtSeFVRyteXIhfsx1Sl e/6FarVdMMDk3o878Sa5g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrkeeggdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephfgtggfukfffvffosehmtdhmrehhtd ejnecuhfhrohhmpefrrghvvghlucfuhhhlhigrkhcuoehprdhshhhlhigrkhesphgrnhht hhgvrhigrdhorhhgqeenucggtffrrghtthgvrhhnpeeivdeghfeuiefggeffffduveetff ffheetvddvfeeivefftdejlefftdffueejtdenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehprdhshhhlhigrkhesphgrnhhthhgvrhigrdhorh hg X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <55663@debbugs.gnu.org>; Sun, 29 May 2022 10:35:52 -0400 (EDT) From: Pavel Shlyak Content-Type: multipart/mixed; boundary="Apple-Mail=_0CDBBBED-619C-4690-AD60-07C682B9760C" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Message-Id: <4054081F-9D51-49E0-958F-C9B1BFA7FB24@pantherx.org> Date: Sun, 29 May 2022 17:35:50 +0300 X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_0CDBBBED-619C-4690-AD60-07C682B9760C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 I have updated the patch so now it automatically sets block size for = non-esp partitions. The previous behavior (for esp) was retained not to = break things I=E2=80=99m not quite aware of. Now I finally got correct/bootable partition layout with Raspberry PI4. --Apple-Mail=_0CDBBBED-619C-4690-AD60-07C682B9760C Content-Disposition: attachment; filename=0001-Image-API-support-FAT32-partitions.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Image-API-support-FAT32-partitions.patch" Content-Transfer-Encoding: quoted-printable =46rom=209049891a4fe9e9f4d66c78526fcdac9d5f0531bc=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pavel=20Shlyak=20=0A= Date:=20Thu,=2026=20May=202022=2021:00:51=20+0300=0ASubject:=20[PATCH]=20= Image=20API:=20support=20FAT32=20partitions=0A=0A---=0A=20= gnu/build/image.scm=20=20|=2024=20++++++++++++++----------=0A=20= gnu/system/image.scm=20|=20=209=20+++++++--=0A=202=20files=20changed,=20= 21=20insertions(+),=2012=20deletions(-)=0A=0Adiff=20--git=20= a/gnu/build/image.scm=20b/gnu/build/image.scm=0Aindex=20= 3e8b94e2d6..692fd1f28a=20100644=0A---=20a/gnu/build/image.scm=0A+++=20= b/gnu/build/image.scm=0A@@=20-95,16=20+95,18=20@@=20(define*=20= (make-ext-image=20partition=20target=20root=0A=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (estimate-partition-size=20root)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20size)))))))=0A=20=0A= -(define*=20(make-vfat-image=20partition=20target=20root)=0A+(define*=20= (make-vfat-image=20partition=20target=20root=20fs_bits)=0A=20=20=20= "Handle=20the=20creation=20of=20VFAT=20partition=20images.=20=20See=20= 'make-partition-image'."=0A=20=20=20(let=20((size=20(partition-size=20= partition))=0A-=20=20=20=20=20=20=20=20(label=20(partition-label=20= partition)))=0A-=20=20=20=20(invoke=20"fakeroot"=20"mkdosfs"=20"-n"=20= label=20"-C"=20target=0A-=20=20=20=20=20=20=20=20=20=20=20=20"-F"=20"16"=20= "-S"=20"1024"=0A-=20=20=20=20=20=20=20=20=20=20=20=20(size-in-kib=0A-=20=20= =20=20=20=20=20=20=20=20=20=20=20(if=20(eq?=20size=20'guess)=0A-=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(estimate-partition-size=20= root)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20size)))=0A+=20= =20=20=20=20=20=20=20(label=20(partition-label=20partition))=0A+=20=20=20= =20=20=20=20=20(flags=20(partition-flags=20partition)))=0A+=20=20=20=20= (apply=20invoke=20"fakeroot"=20"mkdosfs"=20"-n"=20label=20"-C"=20target=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20"-F"=20(number->string=20fs_bits)=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(size-in-kib=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (if=20(eq?=20size=20'guess)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (estimate-partition-size=20root)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20size))=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(if=20(member=20'esp=20= flags)=20(list=20"-S"=20"1024")=20'()))=0A=20=20=20=20=20(for-each=20= (lambda=20(file)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (unless=20(member=20file=20'("."=20".."))=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(invoke=20"mcopy"=20"-bsp"=20"-i"=20target=0A= @@=20-120,8=20+122,10=20@@=20(define*=20(make-partition-image=20= partition-sexp=20target=20root)=0A=20=20=20=20=20(cond=0A=20=20=20=20=20=20= ((string-prefix?=20"ext"=20type)=0A=20=20=20=20=20=20=20(make-ext-image=20= partition=20target=20root))=0A-=20=20=20=20=20((string=3D?=20type=20= "vfat")=0A-=20=20=20=20=20=20(make-vfat-image=20partition=20target=20= root))=0A+=20=20=20=20=20((or=20(string=3D?=20type=20"vfat")=20(string=3D?= =20type=20"fat16"))=0A+=20=20=20=20=20=20(make-vfat-image=20partition=20= target=20root=2016))=0A+=20=20=20=20=20((string=3D?=20type=20"fat32")=0A= +=20=20=20=20=20=20(make-vfat-image=20partition=20target=20root=2032))=0A= =20=20=20=20=20=20(else=0A=20=20=20=20=20=20=20(raise=20(condition=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(&message=0Adiff=20--git=20= a/gnu/system/image.scm=20b/gnu/system/image.scm=0Aindex=20= dd32e58c2d..7e45f750d9=20100644=0A---=20a/gnu/system/image.scm=0A+++=20= b/gnu/system/image.scm=0A@@=20-312,7=20+312,8=20@@=20(define=20= (partition->dos-type=20partition)=0A=20=20=20=20=20=20=20=20=20(cond=0A=20= =20=20=20=20=20=20=20=20=20((member=20'esp=20flags)=20"0xEF")=0A=20=20=20= =20=20=20=20=20=20=20((string-prefix?=20"ext"=20file-system)=20"0x83")=0A= -=20=20=20=20=20=20=20=20=20((string=3D?=20file-system=20"vfat")=20= "0x0E")=0A+=20=20=20=20=20=20=20=20=20((or=20(string=3D?=20file-system=20= "vfat")=20(string=3D?=20file-system=20"fat16"))=20"0x0E")=0A+=20=20=20=20= =20=20=20=20=20((string=3D?=20file-system=20"fat32")=20"0x0C")=0A=20=20=20= =20=20=20=20=20=20=20(else=0A=20=20=20=20=20=20=20=20=20=20=20(raise=20= (condition=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (&message=0A@@=20-329,7=20+330,11=20@@=20(define=20(partition->gpt-type=20= partition)=0A=20=20=20=20=20=20=20=20=20(cond=0A=20=20=20=20=20=20=20=20=20= =20((member=20'esp=20flags)=20"U")=0A=20=20=20=20=20=20=20=20=20=20= ((string-prefix?=20"ext"=20file-system)=20"L")=0A-=20=20=20=20=20=20=20=20= =20((string=3D?=20file-system=20"vfat")=20"F")=0A+=20=20=20=20=20=20=20=20= =20(=0A+=20=20=20=20=20=20=20=20=20=20(or=20(string=3D?=20file-system=20= "vfat")=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20(string=3D?=20= file-system=20"fat16")=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (string=3D?=20file-system=20"fat32")=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20)=20"F")=0A=20=20=20=20=20=20=20=20=20=20(else=0A=20=20=20=20=20= =20=20=20=20=20=20(raise=20(condition=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20(&message=0A--=20=0A2.32.1=20(Apple=20Git-133)=0A= =0A= --Apple-Mail=_0CDBBBED-619C-4690-AD60-07C682B9760C-- From unknown Thu Aug 14 22:24:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55663] [PATCH] Image API: add FAT32 support Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 May 2022 07:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pavel Shlyak Cc: 55663@debbugs.gnu.org Received: via spool by 55663-submit@debbugs.gnu.org id=B55663.165389408926107 (code B ref 55663); Mon, 30 May 2022 07:02:02 +0000 Received: (at 55663) by debbugs.gnu.org; 30 May 2022 07:01:29 +0000 Received: from localhost ([127.0.0.1]:42574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvZP7-0006n1-19 for submit@debbugs.gnu.org; Mon, 30 May 2022 03:01:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvZP5-0006mo-9w for 55663@debbugs.gnu.org; Mon, 30 May 2022 03:01:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60526) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvZOz-0003Ue-DA; Mon, 30 May 2022 03:01:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=McSCd3+vewy+ui27i2vnMU7KOy8mFWuO0P+xn9YOWX8=; b=HX5wIjM08pLzf58HHt/l VxKrZNoJ3EftiHxHA198FfFmqeCgO5jNxQu7zcm8OqAN4eNv9nJTSrVclkH+wAXXRkwJ0Y1dFW/PU fmUGQ8zx2C1QC7AY3JokMGSAN+OxExsdLVH3ki3bEbK2emzUw9FJZPGJf7RLjuHCUOrdj7CDfIUZS GjyFIUAe8FJGOaaCk5sRDVnksRHUH3e017KVRC0kS8zEoRRVid/yILJ0jFrEFdS7uX3UqY1V1MXm+ vRusHJ93KjkErSYSH4bj9YGCDVQK6qvCuZQ1Jk0LSPQQQeTX4Nqx8ZldpOPiMR6ilsuXcFty07FUb dX4rglbBlZtrJw==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:49110 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvZOz-0005lg-04; Mon, 30 May 2022 03:01:21 -0400 From: Mathieu Othacehe References: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> <4054081F-9D51-49E0-958F-C9B1BFA7FB24@pantherx.org> Date: Mon, 30 May 2022 09:01:18 +0200 In-Reply-To: <4054081F-9D51-49E0-958F-C9B1BFA7FB24@pantherx.org> (Pavel Shlyak's message of "Sun, 29 May 2022 17:35:50 +0300") Message-ID: <874k17ld1d.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Pavel, > gnu/build/image.scm | 24 ++++++++++++++---------- > gnu/system/image.scm | 9 +++++++-- Please write a commit message following the guidelines available here: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html > +(define* (make-vfat-image partition target root fs_bits) s/fs_bits/fs-bits/ > + ((or (string=? file-system "vfat") (string=? file-system "fat16")) "0x0E") This line is longer than 78 characters you can break it between the two strings comparisons. > + ( > + (or (string=? file-system "vfat") Merge those two lines. > + (string=? file-system "fat32") > + ) "F") Ditto. Can you please send a v2? Thanks for your contribution, Mathieu From unknown Thu Aug 14 22:24:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55663] [PATCH] Image API: add FAT32 support Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 May 2022 09:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 55663@debbugs.gnu.org Received: via spool by 55663-submit@debbugs.gnu.org id=B55663.16539013145490 (code B ref 55663); Mon, 30 May 2022 09:02:02 +0000 Received: (at 55663) by debbugs.gnu.org; 30 May 2022 09:01:54 +0000 Received: from localhost ([127.0.0.1]:42732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvbHb-0001QR-8e for submit@debbugs.gnu.org; Mon, 30 May 2022 05:01:54 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:36753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvbHM-0001Q0-RB for 55663@debbugs.gnu.org; Mon, 30 May 2022 05:01:50 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 88308320091E; Mon, 30 May 2022 05:01:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 30 May 2022 05:01:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1653901290; x=1653987690; bh=cQzp5kcACg b3iG2bHdx3FmGLXJMMX9o7sE0L0X04Kqo=; b=CwQeC0tmRKrFdww1J72ZQUkoDI afySv06A6eKDaNrSmc4q7YS9T4oHQcN8qFQjJk1yY+VmuynAgt/GR20lC5dFThs+ EY+H2YDC0IERLztV2Adk9wlNsARh7STptf+stqmxDWsUxrSjbcFH3eAdIGSddENc 8fXw6Me6lQ7UP0uyuWR4389j7kIhS6LlrKPmGizM6n85uvL/k/WsrsXs9XvQEP+o RsMgIM703bUVKYc0kxRON/IJqzBD3wy2i0HG9ZXFYOhNaYOgBrIUvefuwKmmEutB c53u8LHaqOkkahul16RwR9eLVJP//RHM31sD9CE3Gy/UgL4G1fQRJMQ+9CVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653901290; x=1653987690; bh=cQzp5kcACgb3iG2bHdx3FmGLXJMM X9o7sE0L0X04Kqo=; b=QNLNM5Pm3RxujNR6TX25PhiuvR6mzEjyBN0jyJt++yhu +PTqKer1Iv+ZSOH3S+z7+D86SDcZd2yy/txsVtlGqj18uyuTku4eFAqhVtDKgkma +4RdqavmX0YL77mD1XzZZr9XZ/5lyYqGoQDWfLnpydcqVVq0mMC6RiRXEw/c6/GB ZFahayqhbdyoLkBi7qEpiJ5voHyIsWodpxQfWmsOq6Cw/NAUHYZTsWlsd1kC3QQ+ +0pDaOhpw2aHXR+n7mP/rRWyVOy7BGESF855uu3u/I/b3z34Vwht2V0JhDfxO9dW +OuVKFvONFuYH0jy8g7DvlL+IOGAik29EygOFO4+qQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrkeeigddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhkfgtggfuffgjvefvfhfosehmtdhmrehhtdejnecuhfhrohhmpefrrghvvghl ucfuhhhlhigrkhcuoehprdhshhhlhigrkhesphgrnhhthhgvrhigrdhorhhgqeenucggtf frrghtthgvrhhnpeeikeefkeegvdduveelkeffveekhfelgfdtffeihffhgeetieehkeeg feeflefgueenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehprdhshhhlhigrkhesphgrnhhthhgvrhig rdhorhhg X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 30 May 2022 05:01:28 -0400 (EDT) From: Pavel Shlyak Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_78A8146E-2B17-4293-9C2A-9625C5B71C2D" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Date: Mon, 30 May 2022 12:01:27 +0300 In-Reply-To: <874k17ld1d.fsf_-_@gnu.org> References: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> <4054081F-9D51-49E0-958F-C9B1BFA7FB24@pantherx.org> <874k17ld1d.fsf_-_@gnu.org> X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_78A8146E-2B17-4293-9C2A-9625C5B71C2D Content-Disposition: attachment; filename=0001-guix-Image-API-support-FAT32-partitions.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-guix-Image-API-support-FAT32-partitions.patch" Content-Transfer-Encoding: quoted-printable =46rom=205ff7fcf80196111ab8d5f87a1d159ed0349153b4=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pavel=20Shlyak=20=0A= Date:=20Thu,=2026=20May=202022=2021:00:51=20+0300=0ASubject:=20[PATCH]=20= guix:=20Image=20API:=20support=20FAT32=20partitions=0A=0A*=20= gnu/build/image.scm=20(make-vfat-image):=20pass=20fs=20bits=20as=20= argument=20and=20force=201kb=20logical=20sector=20size=20only=20if=20= "ESP"=20flag=20is=20set.=0A=20=20(make-partition-image):=20add=20"fat32"=20= partition=20type,=20support=20explicit=20"fat16"=20type=20with=20vfat=20= alias.=0A*=20gnu/system/image.scm=20(partition->dos-type=20partition):=20= return=20file=20system=20IDs=20for=20"fat16"=20and=20"fat32"=20= partitions.=0A=20=20(partition->gpt-type=20partition):=20ditto.=0A---=0A=20= gnu/build/image.scm=20=20|=2024=20++++++++++++++----------=0A=20= gnu/system/image.scm=20|=20=208=20++++++--=0A=202=20files=20changed,=20= 20=20insertions(+),=2012=20deletions(-)=0A=0Adiff=20--git=20= a/gnu/build/image.scm=20b/gnu/build/image.scm=0Aindex=20= 3e8b94e2d6..ddfd34c111=20100644=0A---=20a/gnu/build/image.scm=0A+++=20= b/gnu/build/image.scm=0A@@=20-95,16=20+95,18=20@@=20(define*=20= (make-ext-image=20partition=20target=20root=0A=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (estimate-partition-size=20root)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20size)))))))=0A=20=0A= -(define*=20(make-vfat-image=20partition=20target=20root)=0A+(define*=20= (make-vfat-image=20partition=20target=20root=20fs-bits)=0A=20=20=20= "Handle=20the=20creation=20of=20VFAT=20partition=20images.=20=20See=20= 'make-partition-image'."=0A=20=20=20(let=20((size=20(partition-size=20= partition))=0A-=20=20=20=20=20=20=20=20(label=20(partition-label=20= partition)))=0A-=20=20=20=20(invoke=20"fakeroot"=20"mkdosfs"=20"-n"=20= label=20"-C"=20target=0A-=20=20=20=20=20=20=20=20=20=20=20=20"-F"=20"16"=20= "-S"=20"1024"=0A-=20=20=20=20=20=20=20=20=20=20=20=20(size-in-kib=0A-=20=20= =20=20=20=20=20=20=20=20=20=20=20(if=20(eq?=20size=20'guess)=0A-=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(estimate-partition-size=20= root)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20size)))=0A+=20= =20=20=20=20=20=20=20(label=20(partition-label=20partition))=0A+=20=20=20= =20=20=20=20=20(flags=20(partition-flags=20partition)))=0A+=20=20=20=20= (apply=20invoke=20"fakeroot"=20"mkdosfs"=20"-n"=20label=20"-C"=20target=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20"-F"=20(number->string=20fs-bits)=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(size-in-kib=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (if=20(eq?=20size=20'guess)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (estimate-partition-size=20root)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20size))=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(if=20(member=20'esp=20= flags)=20(list=20"-S"=20"1024")=20'()))=0A=20=20=20=20=20(for-each=20= (lambda=20(file)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (unless=20(member=20file=20'("."=20".."))=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(invoke=20"mcopy"=20"-bsp"=20"-i"=20target=0A= @@=20-120,8=20+122,10=20@@=20(define*=20(make-partition-image=20= partition-sexp=20target=20root)=0A=20=20=20=20=20(cond=0A=20=20=20=20=20=20= ((string-prefix?=20"ext"=20type)=0A=20=20=20=20=20=20=20(make-ext-image=20= partition=20target=20root))=0A-=20=20=20=20=20((string=3D?=20type=20= "vfat")=0A-=20=20=20=20=20=20(make-vfat-image=20partition=20target=20= root))=0A+=20=20=20=20=20((or=20(string=3D?=20type=20"vfat")=20(string=3D?= =20type=20"fat16"))=0A+=20=20=20=20=20=20(make-vfat-image=20partition=20= target=20root=2016))=0A+=20=20=20=20=20((string=3D?=20type=20"fat32")=0A= +=20=20=20=20=20=20(make-vfat-image=20partition=20target=20root=2032))=0A= =20=20=20=20=20=20(else=0A=20=20=20=20=20=20=20(raise=20(condition=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(&message=0Adiff=20--git=20= a/gnu/system/image.scm=20b/gnu/system/image.scm=0Aindex=20= dd32e58c2d..f02f6e0b8c=20100644=0A---=20a/gnu/system/image.scm=0A+++=20= b/gnu/system/image.scm=0A@@=20-312,7=20+312,9=20@@=20(define=20= (partition->dos-type=20partition)=0A=20=20=20=20=20=20=20=20=20(cond=0A=20= =20=20=20=20=20=20=20=20=20((member=20'esp=20flags)=20"0xEF")=0A=20=20=20= =20=20=20=20=20=20=20((string-prefix?=20"ext"=20file-system)=20"0x83")=0A= -=20=20=20=20=20=20=20=20=20((string=3D?=20file-system=20"vfat")=20= "0x0E")=0A+=20=20=20=20=20=20=20=20=20((or=20(string=3D?=20file-system=20= "vfat")=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20(string=3D?=20= file-system=20"fat16"))=20"0x0E")=0A+=20=20=20=20=20=20=20=20=20= ((string=3D?=20file-system=20"fat32")=20"0x0C")=0A=20=20=20=20=20=20=20=20= =20=20(else=0A=20=20=20=20=20=20=20=20=20=20=20(raise=20(condition=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(&message=0A@@=20= -329,7=20+331,9=20@@=20(define=20(partition->gpt-type=20partition)=0A=20=20= =20=20=20=20=20=20=20(cond=0A=20=20=20=20=20=20=20=20=20=20((member=20= 'esp=20flags)=20"U")=0A=20=20=20=20=20=20=20=20=20=20((string-prefix?=20= "ext"=20file-system)=20"L")=0A-=20=20=20=20=20=20=20=20=20((string=3D?=20= file-system=20"vfat")=20"F")=0A+=20=20=20=20=20=20=20=20=20((or=20= (string=3D?=20file-system=20"vfat")=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(string=3D?=20file-system=20"fat16")=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(string=3D?=20file-system=20"fat32"))=20"F")=0A=20=20=20=20= =20=20=20=20=20=20(else=0A=20=20=20=20=20=20=20=20=20=20=20(raise=20= (condition=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (&message=0A--=20=0A2.32.1=20(Apple=20Git-133)=0A=0A= --Apple-Mail=_78A8146E-2B17-4293-9C2A-9625C5B71C2D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > 30 =D0=BC=D0=B0=D1=8F 2022 =D0=B3., =D0=B2 10:01, Mathieu Othacehe = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >=20 >=20 > Hello Pavel, >=20 >> gnu/build/image.scm | 24 ++++++++++++++---------- >> gnu/system/image.scm | 9 +++++++-- >=20 > Please write a commit message following the guidelines available here: > https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html >=20 >> +(define* (make-vfat-image partition target root fs_bits) >=20 > s/fs_bits/fs-bits/ >=20 >> + ((or (string=3D? file-system "vfat") (string=3D? = file-system "fat16")) "0x0E") >=20 > This line is longer than 78 characters you can break it between the = two > strings comparisons. >=20 >> + ( >> + (or (string=3D? file-system "vfat") >=20 > Merge those two lines. >=20 >> + (string=3D? file-system "fat32") >> + ) "F") >=20 > Ditto. >=20 > Can you please send a v2? >=20 > Thanks for your contribution, >=20 > Mathieu --Apple-Mail=_78A8146E-2B17-4293-9C2A-9625C5B71C2D-- From unknown Thu Aug 14 22:24:36 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Pavel Shlyak Subject: bug#55663: closed (Re: bug#55663: [PATCH] Image API: add FAT32 support) Message-ID: References: <87a6axj1en.fsf_-_@gnu.org> <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> X-Gnu-PR-Message: they-closed 55663 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 55663@debbugs.gnu.org Date: Tue, 31 May 2022 13:08:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1654002482-28630-1" This is a multi-part message in MIME format... ------------=_1654002482-28630-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55663: [PATCH] Image API: add FAT32 support which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55663@debbugs.gnu.org. --=20 55663: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55663 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1654002482-28630-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55663-done) by debbugs.gnu.org; 31 May 2022 13:07:58 +0000 Received: from localhost ([127.0.0.1]:47093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nw1bK-0007RU-66 for submit@debbugs.gnu.org; Tue, 31 May 2022 09:07:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nw1bH-0007RD-4S for 55663-done@debbugs.gnu.org; Tue, 31 May 2022 09:07:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nw1bB-0006dR-PE; Tue, 31 May 2022 09:07:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=QaRhYTdsx1bSD1tJ2kRjBVLQQXcDp8K4x4EAjudhYIY=; b=lwG8M8+32ediB7bCZb2K wcVhdCOVbgNQu1wtUmWfxPZH3tzmMk5oXYrsX/JwiKvocATrnXmW86PaJoBRmiDMXr+07L34DHiC4 +ZN/ynRvustl9s8mHx3Nu5vz1eRLdrLnf3mh9y7/eNddn/5/SSjX2fQpB19e1lXt34g6WBPMZ+qyJ HRDWrB0nfw/jmPMr27ThB5UBGSs+iUXD4JdiMdwHTYB6zW+iOxL9vaBD413XFBIXseusSDpJnpukT zcEY1Xpa+M+mQM39awyHgOgB3BrmF9RvEqBVN4/f7OT2nmPKfIBZdkAbK3EhLZTg+D4QhrCH0LKpc 2Z3G69q+Bm8Qig==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:49132 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nw1b9-0003vb-Lr; Tue, 31 May 2022 09:07:49 -0400 From: Mathieu Othacehe To: Pavel Shlyak Subject: Re: bug#55663: [PATCH] Image API: add FAT32 support References: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> <4054081F-9D51-49E0-958F-C9B1BFA7FB24@pantherx.org> <874k17ld1d.fsf_-_@gnu.org> Date: Tue, 31 May 2022 15:07:44 +0200 In-Reply-To: (Pavel Shlyak's message of "Mon, 30 May 2022 12:01:27 +0300") Message-ID: <87a6axj1en.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55663-done Cc: 55663-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Pavel, Thanks for the v2, pushed on master. Mathieu ------------=_1654002482-28630-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 26 May 2022 18:02:30 +0000 Received: from localhost ([127.0.0.1]:59937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuHob-0007lF-Vr for submit@debbugs.gnu.org; Thu, 26 May 2022 14:02:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:48778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuHoa-0007l6-Hi for submit@debbugs.gnu.org; Thu, 26 May 2022 14:02:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuHoa-00041H-9V for guix-patches@gnu.org; Thu, 26 May 2022 14:02:28 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:55437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuHoY-0006yM-Eb for guix-patches@gnu.org; Thu, 26 May 2022 14:02:28 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CF0915C0184 for ; Thu, 26 May 2022 14:02:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 26 May 2022 14:02:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1653588145; x=1653674545; bh=cDVeun3lUPhbXR542NrmU5vSJNlVveVojLZ OwsVmalo=; b=RYt+MXLifizbp7Fc5waRoM73kZhI1LCR93L8i8KIcH1FZR7XZOP Z5wrkH+3xdcvOMwqlwxx/Kpn5C/qRBN4tCI/ZTiHFgnDV/+qC74TLASgRSV3y00W YfSeF3MSwzdi28PjGA9VXQz2mn38P3KQnpohAcsEG6eeeQqxcS3DMHSYgSFXUERd 65HQjH3cwxDokvp36md2eFQPA8wp0Tp6SlyTps+mkG52vdnBRz15fTxpvIz32Khz OqUNa+FcZWN9Bm2a2jji6oEhpuxSw1QTnH5CaIXzDyVcEkng86P1vcNLmaEzTbvc BTVUB/7XByAwn37iXirpiLNLMDjqnER6kOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653588145; x= 1653674545; bh=cDVeun3lUPhbXR542NrmU5vSJNlVveVojLZOwsVmalo=; b=B fCDrx8Thx4u9KL1+LI9E5l/F0ejwXyJwr8kbMTqjxODSZZLz4JhGHaWF+hWuwXWp nxBH/GxpBhpMF0lI9YOCp57qYIC6CpSS0YrwV9zTyeOTQfX3pKgrFkItBlGe9qfE I+0w41Bg4WZIV/Y9+KNHFQAy5JBW6sJPP1lBX7QF6FTzLiQ5BlO8ntkYLNlA09pr v6XkGMsK8Oi64MrRo8MfAD7uAGPYMVmZekuqI8MJ8VfnDjKoNEz6dm7TakDqzLJH 7AIHpVpOgY3IBaDj5sLH6efpCCY22xsT31899DU6xqX5Uy7cPu3k8M7b519xK3xn qW8yZnRSw3thiOTQQpKjA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeejgdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhtggguffkfffvofesmhdtmherhh dtvdenucfhrhhomheprfgrvhgvlhcuufhhlhihrghkuceophdrshhhlhihrghksehprghn thhhvghrgidrohhrgheqnecuggftrfgrthhtvghrnhepjeeiheefieevtefghfegveefhe duffekfeegkeegkefghfefleeljeegvdfhledunecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepphdrshhhlhihrghksehprghnthhhvghrgidroh hrgh X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 26 May 2022 14:02:24 -0400 (EDT) From: Pavel Shlyak Content-Type: multipart/mixed; boundary="Apple-Mail=_F2A75323-9AA7-4BAF-A554-A2E6B8C3D50F" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: [PATCH] Image API: add FAT32 support Message-Id: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> Date: Thu, 26 May 2022 21:02:22 +0300 To: guix-patches@gnu.org X-Mailer: Apple Mail (2.3696.100.31) Received-SPF: pass client-ip=66.111.4.28; envelope-from=p.shlyak@pantherx.org; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --Apple-Mail=_F2A75323-9AA7-4BAF-A554-A2E6B8C3D50F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii I believe it is an important change as Raspberry PI (and I suppose some = other boards) cannot boot with fat16 boot partitions.=20 With this patch, "vfat" is treated as fat16 partition not to break = backward-compatibility. "fat32", on the other hand, creates a fat32 = partition. --Apple-Mail=_F2A75323-9AA7-4BAF-A554-A2E6B8C3D50F Content-Disposition: attachment; filename=0001-Image-API-support-FAT32-partitions.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Image-API-support-FAT32-partitions.patch" Content-Transfer-Encoding: quoted-printable =46rom=200700c443d9162ac4928ac8fee58278c1f0824736=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pavel=20Shlyak=20=0A= Date:=20Thu,=2026=20May=202022=2021:00:51=20+0300=0ASubject:=20[PATCH]=20= Image=20API:=20support=20FAT32=20partitions=0A=0A---=0A=20= gnu/build/image.scm=20=20|=208=20+++++---=0A=20gnu/system/image.scm=20|=20= 2=20++=0A=202=20files=20changed,=207=20insertions(+),=203=20deletions(-)=0A= =0Adiff=20--git=20a/gnu/build/image.scm=20b/gnu/build/image.scm=0Aindex=20= 3e8b94e2d6..804685c7fb=20100644=0A---=20a/gnu/build/image.scm=0A+++=20= b/gnu/build/image.scm=0A@@=20-95,12=20+95,12=20@@=20(define*=20= (make-ext-image=20partition=20target=20root=0A=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (estimate-partition-size=20root)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20size)))))))=0A=20=0A= -(define*=20(make-vfat-image=20partition=20target=20root)=0A+(define*=20= (make-vfat-image=20partition=20target=20root=20fs_bits)=0A=20=20=20= "Handle=20the=20creation=20of=20VFAT=20partition=20images.=20=20See=20= 'make-partition-image'."=0A=20=20=20(let=20((size=20(partition-size=20= partition))=0A=20=20=20=20=20=20=20=20=20(label=20(partition-label=20= partition)))=0A=20=20=20=20=20(invoke=20"fakeroot"=20"mkdosfs"=20"-n"=20= label=20"-C"=20target=0A-=20=20=20=20=20=20=20=20=20=20=20=20"-F"=20"16"=20= "-S"=20"1024"=0A+=20=20=20=20=20=20=20=20=20=20=20=20"-F"=20fs_bits=20= "-S"=20"1024"=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(size-in-kib=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(if=20(eq?=20size=20'guess)=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(estimate-partition-size=20= root)=0A@@=20-121,7=20+121,9=20@@=20(define*=20(make-partition-image=20= partition-sexp=20target=20root)=0A=20=20=20=20=20=20((string-prefix?=20= "ext"=20type)=0A=20=20=20=20=20=20=20(make-ext-image=20partition=20= target=20root))=0A=20=20=20=20=20=20((string=3D?=20type=20"vfat")=0A-=20=20= =20=20=20=20(make-vfat-image=20partition=20target=20root))=0A+=20=20=20=20= =20=20(make-vfat-image=20partition=20target=20root=20"16"))=0A+=20=20=20=20= =20((string=3D?=20type=20"fat32")=0A+=20=20=20=20=20=20(make-vfat-image=20= partition=20target=20root=20"32"))=0A=20=20=20=20=20=20(else=0A=20=20=20=20= =20=20=20(raise=20(condition=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(&message=0Adiff=20--git=20a/gnu/system/image.scm=20= b/gnu/system/image.scm=0Aindex=20dd32e58c2d..0dd16ed34e=20100644=0A---=20= a/gnu/system/image.scm=0A+++=20b/gnu/system/image.scm=0A@@=20-313,6=20= +313,7=20@@=20(define=20(partition->dos-type=20partition)=0A=20=20=20=20=20= =20=20=20=20=20((member=20'esp=20flags)=20"0xEF")=0A=20=20=20=20=20=20=20= =20=20=20((string-prefix?=20"ext"=20file-system)=20"0x83")=0A=20=20=20=20= =20=20=20=20=20=20((string=3D?=20file-system=20"vfat")=20"0x0E")=0A+=20=20= =20=20=20=20=20=20=20((string=3D?=20file-system=20"fat32")=20"0x0C")=0A=20= =20=20=20=20=20=20=20=20=20(else=0A=20=20=20=20=20=20=20=20=20=20=20= (raise=20(condition=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(&message=0A@@=20-330,6=20+331,7=20@@=20(define=20= (partition->gpt-type=20partition)=0A=20=20=20=20=20=20=20=20=20=20= ((member=20'esp=20flags)=20"U")=0A=20=20=20=20=20=20=20=20=20=20= ((string-prefix?=20"ext"=20file-system)=20"L")=0A=20=20=20=20=20=20=20=20= =20=20((string=3D?=20file-system=20"vfat")=20"F")=0A+=20=20=20=20=20=20=20= =20=20((string=3D?=20file-system=20"fat32")=20"F")=0A=20=20=20=20=20=20=20= =20=20=20(else=0A=20=20=20=20=20=20=20=20=20=20=20(raise=20(condition=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(&message=0A--=20=0A= 2.32.1=20(Apple=20Git-133)=0A=0A= --Apple-Mail=_F2A75323-9AA7-4BAF-A554-A2E6B8C3D50F-- ------------=_1654002482-28630-1--