From unknown Fri Jun 20 07:18:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#55659 <55659@debbugs.gnu.org> To: bug#55659 <55659@debbugs.gnu.org> Subject: Status: [PATCH 1/2] services: ddclient: Fix extra-options serialization. Reply-To: bug#55659 <55659@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:18:21 +0000 retitle 55659 [PATCH 1/2] services: ddclient: Fix extra-options serializati= on. reassign 55659 guix-patches submitter 55659 Attila Lendvai severity 55659 normal tag 55659 wontfix patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 26 09:11:33 2022 Received: (at submit) by debbugs.gnu.org; 26 May 2022 13:11:33 +0000 Received: from localhost ([127.0.0.1]:57397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuDH3-0003rw-8F for submit@debbugs.gnu.org; Thu, 26 May 2022 09:11:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:45346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuDH1-0003rj-CK for submit@debbugs.gnu.org; Thu, 26 May 2022 09:11:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuDGy-0006A9-13 for guix-patches@gnu.org; Thu, 26 May 2022 09:11:31 -0400 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:44631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuDGw-0005Hd-DF for guix-patches@gnu.org; Thu, 26 May 2022 09:11:27 -0400 Received: by mail-ed1-x531.google.com with SMTP id q15so1739341edb.11 for ; Thu, 26 May 2022 06:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PVK9k6o7iD7ezZV5hNYYBdRbQJxrqn9y1anWpOM6eKw=; b=h93PSr2DChdjzPFsJ6Q4xSTfhotflsx27MUttcMAsHPPCr0jK2azw7byx2LS8drhbg aEo/GLF76jvnDf27l7XTY321bKDN3APhEs9beMrQxFhwyH9pTJnS5L3muy6Wgl/Qt0o0 bWsuD3Q3iOelgYB5yPfhhC6W+zDBBsI2TlrcH28OuBGryXpe1mnjnpyF98E/OWwfv+6C q+8aO4/r2irsicpWPQ6vDdOMVzn7Ky5NqmS7X3BqFsiWBDj9SP4tcuut1xFVPEkTlYXn v2QWXthuaQJgaLB1NDCoaJBJPezgwkd9gXQAgQv16f1te8QaTRc8QKtO5tm6iMoV7aEg fxRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=PVK9k6o7iD7ezZV5hNYYBdRbQJxrqn9y1anWpOM6eKw=; b=MxMhwGulNMvnDjpWnvYLgqv5/xjHPKnFsdt6DL6gd1lZUKQWFHT4k/IkC6MSwrjoju 7LQhKl2hFhlyYku+wBSzjMtrC/xJlDxFlPA7Tgd3SwLzKTYkfdDJjXk6Lo7N8PBnKv7K CViW5+LVTlKnjDOlbwmAh2+o4X+sR0r1orqJdU7+572pR5cwi0Qt4preAxf7bWv+ki5s 3rotQ+WFLTxFyNarEVEedMTQ+1JwrNMlemQN/MYhCJvHfrSyFkvO1oUVqoLuUbXUhf8I 4GKRqHAHtPmiCWso/LVwNLGAVsMGPj+k/No31fcL+czjVOg2kxQyPmwuZpHXqEQOe8AE XRnQ== X-Gm-Message-State: AOAM533ImV3lSfqRhhI2Cfgs5T1Q575BXtSQui8/VmqxKjA5jVEupKsJ dwvzn1DSyv0QpQXd9KJ52V7rNtBmo3E= X-Google-Smtp-Source: ABdhPJwK/VzZ3YHpiAVSzY3J4PGWWHZVKqbkzZfxLeNXjwtYgxroxxUon8fzOQ2y98lqSX9nUQtZjA== X-Received: by 2002:a05:6402:401b:b0:42b:5bbf:4b88 with SMTP id d27-20020a056402401b00b0042b5bbf4b88mr23986643eda.238.1653570684853; Thu, 26 May 2022 06:11:24 -0700 (PDT) Received: from lelap.local (catv-89-132-245-188.catv.fixed.vodafone.hu. [89.132.245.188]) by smtp.gmail.com with ESMTPSA id q29-20020a50aa9d000000b0042aad7448besm790100edc.18.2022.05.26.06.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 06:11:24 -0700 (PDT) From: Attila Lendvai To: guix-patches@gnu.org Subject: [PATCH 1/2] services: ddclient: Fix extra-options serialization. Date: Thu, 26 May 2022 15:09:12 +0200 Message-Id: <20220526130912.29483-1-attila@lendvai.name> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=attila.lendvai@gmail.com; helo=mail-ed1-x531.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit Cc: Attila Lendvai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Prior to this fix it has serialized "extra-options=..." into the ddclient.conf file. * gnu/services/dns.scm (serialize-field): Special case for extra-options. (serialize-extra-options): Deleted unused function. (ddclient-configuration): Change the type of the extra-options field to be a string, and emit it verbatime into the ddclient.conf file. Change docstring accordingly. --- please note that even though this does fix an issue, i have abandoned further work on ddclient. so, this is an improvement indeed, but i suspect that this does not fully fix ddclient. looks like the conf file format is different than what the current code emits. the next patch updates ddclient to an RC2 of the next version, which will be a major upgrade. gnu/services/dns.scm | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/gnu/services/dns.scm b/gnu/services/dns.scm index 50753b7ab6..c2ede312e8 100644 --- a/gnu/services/dns.scm +++ b/gnu/services/dns.scm @@ -904,8 +904,11 @@ (define (uglify-field-name field-name) (string-delete #\? (symbol->string field-name))) (define (serialize-field field-name val) - (when (not (member field-name '(group secret-file user))) - (format #t "~a=~a\n" (uglify-field-name field-name) val))) + (cond + ((eq? field-name 'extra-options) + (display val)) + ((not (member field-name '(group secret-file user))) + (format #t "~a=~a\n" (uglify-field-name field-name) val)))) (define (serialize-boolean field-name val) (serialize-field field-name (if val "yes" "no"))) @@ -921,9 +924,6 @@ (define (serialize-string field-name val) (define (serialize-list field-name val) (if (null? val) "" (serialize-field field-name (string-join val)))) -(define (serialize-extra-options extra-options) - (string-join extra-options "\n" 'suffix)) - (define-configuration ddclient-configuration (ddclient (file-like ddclient) @@ -959,8 +959,8 @@ (define-configuration ddclient-configuration file contains credentials for use by ddclient. You are expected to create it manually.") (extra-options - (list '()) - "Extra options will be appended to @file{ddclient.conf} file.")) + (string "") + "Extra options will be appended verbatim to the @file{ddclient.conf} file.")) (define (ddclient-account config) "Return the user accounts and user groups for CONFIG." -- 2.35.1 From debbugs-submit-bounces@debbugs.gnu.org Thu May 26 09:17:08 2022 Received: (at 55659) by debbugs.gnu.org; 26 May 2022 13:17:08 +0000 Received: from localhost ([127.0.0.1]:57420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuDMS-00041e-2l for submit@debbugs.gnu.org; Thu, 26 May 2022 09:17:08 -0400 Received: from mail-ej1-f46.google.com ([209.85.218.46]:34395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuDMO-00040y-Ij for 55659@debbugs.gnu.org; Thu, 26 May 2022 09:17:07 -0400 Received: by mail-ej1-f46.google.com with SMTP id q21so3013053ejm.1 for <55659@debbugs.gnu.org>; Thu, 26 May 2022 06:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9K6P1TcWjizrx8LKD08gFuuVFQh1PNZzfu/V1pdzh4A=; b=YRiqH/i3XV7z9/fmHXEMxq7x33rNRJQSn55YHRQtw7fMt2n2icK4cZouDX5N/iZyBQ 4ti3OXkHY4h6mBGw8lcQH6M/HVgHr3RQuwI8nNXPiQ7nLDwWrTqWcp+++EfOZ0JC9Own 3OU3vsD83H0cuTX5JulqSDL10Uo3jKfECQVWGeWEvTw7nEG+GSkfci17O8H9qqGNoYAt kpY0JtaS3ElCej5UlTavzXtCw3xEEf4+z8lCI/61/XR5Ex4+eXKK6LlBe4zR4eQio5dL BOowHEDWnhcL8+lJS/UM9D3SXJf6VZAD7Y6odKINhkhPNiF6ZpF7LfVlG1QAWYu+ELE3 DNsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=9K6P1TcWjizrx8LKD08gFuuVFQh1PNZzfu/V1pdzh4A=; b=tIYu4GWUS9j3rSNzpyFWmY7/VRLBlQKYEcs8ZZW5ToQ1aDeqtBDTFc1D+DQy6UBZnw LBsK/vr2nzvxLfoKiXhjqGtwNsX9RwNwfPn1VS2EN1wOiJ1bIc5V48tChsGd0TSWW30k 9Obq24ybcCvb8Li6Ve/evNUn6BNDR1SYSj1EgYVRHb2/kjm2QOLmtFsdx7I1IqunlTQ3 Php8mO2D2CWEU5xlMbktUZz5y6yk6i0HZ054LAWkdabF++GfcrZ0zMziiZnDk78tbkw0 PBdljAh9tkrWVq8qkyUqrbMs2MCbSxEksWw7VlN7crd0F3WlHDsHeTRKF1fO4LQbDPXQ bNoQ== X-Gm-Message-State: AOAM533FnSwS9hKTuyfGuExu2blkEYTVbBQkFCS5a4wlqIy83vnYqLjf sXDpejisCkkSo6YK+iOQARkPPm+adkQ= X-Google-Smtp-Source: ABdhPJwLdqDmooXeGZkaLGnOHcx8YX8DxUyGz6llyn7N9BSiwtL5CaF7FFVP9UBKfgFAYy1XDsfMGQ== X-Received: by 2002:a17:907:3e86:b0:6f5:917:10cc with SMTP id hs6-20020a1709073e8600b006f5091710ccmr32304642ejc.53.1653571018759; Thu, 26 May 2022 06:16:58 -0700 (PDT) Received: from lelap.local (catv-89-132-245-188.catv.fixed.vodafone.hu. [89.132.245.188]) by smtp.gmail.com with ESMTPSA id o3-20020a170906774300b006f3ef214db7sm523039ejn.29.2022.05.26.06.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 06:16:58 -0700 (PDT) From: Attila Lendvai To: 55659@debbugs.gnu.org Subject: [PATCH 2/2] gnu: ddclient: Update to 3.10.0_2 (RC2). Date: Thu, 26 May 2022 15:13:16 +0200 Message-Id: <20220526131315.30515-2-attila@lendvai.name> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55659 Cc: Attila Lendvai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --- note that this seems to work, but is not fully tested. i have abandoned the use of ddclient and with that this patchset. also note that i'm not sure why the use of wrap-program is needed, but without that it was missing some perl modules at runtime. gnu/packages/dns.scm | 76 ++++++++++++++++---------------------------- 1 file changed, 27 insertions(+), 49 deletions(-) diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm index fea255c930..0430415b3f 100644 --- a/gnu/packages/dns.scm +++ b/gnu/packages/dns.scm @@ -64,6 +64,7 @@ (define-module (gnu packages dns) #:use-module (gnu packages nettle) #:use-module (gnu packages networking) #:use-module (gnu packages perl) + #:use-module (gnu packages perl-check) #:use-module (gnu packages pkg-config) #:use-module (gnu packages protobuf) #:use-module (gnu packages python) @@ -1094,7 +1095,7 @@ (define-public knot-resolver (define-public ddclient (package (name "ddclient") - (version "3.9.1") + (version "3.10.0_2") (source (origin (method git-fetch) @@ -1103,62 +1104,39 @@ (define-public ddclient (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "0hf377g4j9r9sac75xp17nk2h58mazswz4vkg4g2gl2yyhvzq91w")))) - (build-system trivial-build-system) ; no Makefile.PL + (base32 "0jl658yr867y65hh054wg5gbzxsgpsf57qlc182ni4vwgqkrsrd1")))) + (build-system gnu-build-system) (native-inputs - (list bash perl)) + (list bash autoconf automake + perl + ;; For the tests. + perl-try-tiny perl-test-warnings perl-http-daemon-ssl + perl-io-socket-inet6 perl-test-www-mechanize-psgi + perl-test-mockmodule)) (inputs (list inetutils ; logger net-tools + perl perl-data-validate-ip perl-digest-sha1 perl-io-socket-ssl)) (arguments - `(#:modules ((guix build utils)) - #:builder - (begin - (use-modules (guix build utils) - (ice-9 match) - (srfi srfi-26)) - (setenv "PATH" (string-append - (assoc-ref %build-inputs "bash") "/bin" ":" - (assoc-ref %build-inputs "perl") "/bin")) - - ;; Copy the (read-only) source into the (writable) build directory. - (copy-recursively (assoc-ref %build-inputs "source") ".") - - ;; Install. - (let* ((out (assoc-ref %outputs "out")) - (bin (string-append out "/bin"))) - (let ((file "ddclient")) - (substitute* file - (("/usr/bin/perl") (which "perl")) - ;; Strictly use ‘/etc/ddclient/ddclient.conf’. - (("\\$\\{program\\}\\.conf") "/etc/ddclient/ddclient.conf") - (("\\$etc\\$program.conf") "/etc/ddclient/ddclient.conf") - ;; Strictly use ‘/var/cache/ddclient/ddclient.cache’ - (("\\$cachedir\\$program\\.cache") - "/var/cache/ddclient/ddclient.cache")) - (install-file file bin) - (wrap-program (string-append bin "/" file) - `("PATH" ":" = - ("$PATH" - ,@(map (lambda (input) - (match input - ((name . store) - (string-append store "/bin")))) - %build-inputs))) - `("PERL5LIB" ":" = - ,(delete - "" - (map (match-lambda - (((? (cut string-prefix? "perl-" <>) name) . dir) - (string-append dir "/lib/perl5/site_perl")) - (_ "")) - %build-inputs))))) - (for-each (cut install-file <> (string-append out - "/share/ddclient")) - (find-files "." "sample.*$")))))) + ;; The tests run mostly clean (6 failures), but I think they depend on + ;; the network config of the machine running them, so I turned them off. + `(#:tests? #f + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'change-dependencies + (lambda* (#:key native-inputs target #:allow-other-keys) + (substitute* "configure.ac" + (("HTTP::Daemon=6.12") "HTTP::Daemon=6.14")))) + (add-after 'install 'wrap-ddclient + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out"))) + (wrap-program (string-append out "/bin/ddclient") + `("PERL5LIB" ":" prefix + (,(getenv "PERL5LIB") + ,(string-append out "/lib/perl5/site_perl")))))))))) (home-page "https://ddclient.net/") (synopsis "Address updating utility for dynamic DNS services") (description "This package provides a client to update dynamic IP -- 2.35.1 From debbugs-submit-bounces@debbugs.gnu.org Fri May 27 07:41:04 2022 Received: (at 55659) by debbugs.gnu.org; 27 May 2022 11:41:04 +0000 Received: from localhost ([127.0.0.1]:32948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuYKu-0005vo-Fc for submit@debbugs.gnu.org; Fri, 27 May 2022 07:41:04 -0400 Received: from mail-40136.proton.ch ([185.70.40.136]:33303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuYKo-0005vW-5m for 55659@debbugs.gnu.org; Fri, 27 May 2022 07:40:55 -0400 Date: Fri, 27 May 2022 11:40:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail3; t=1653651643; x=1653910843; bh=OvZe7aValkHU6fYhPjrkarjP9GBZfMK+QRuGEHr+opE=; h=Date:To:From:Reply-To:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=KxblZ88O/2R9/KJqMEvqUlKKQyA6P5QIh81v01+W94yDqfNkYXvD/eR6yGIbpaGkQ Hic3ZrZd6TTKHLFUSObJJ700ySkUwbAYt/6m/qKmuZPRPeB71fbKSeYLtIFMsMDbBy O57PfjPQSz+/zbb2A9v290v1poULuVrphc8G+y5rr6UOPPd64KQ/t/fSfdSp5UdlXc +m/O12jnjqzwe6eYevuga6Sf0ORElnzK2wA0Lm7KF1/fJ0us76HOJwhviPcHjUW5dZ qC2VfCoidCh+JTkLdkjfVhn34FKqXadqPHUlpLihLOxsxxvflJrwTijSZuDOTr2DB8 WqbAEgBId09ug== To: 55659@debbugs.gnu.org From: Attila Lendvai Subject: Re: [PATCH 2/2] gnu: ddclient: Update to 3.10.0_2 (RC2). Message-ID: In-Reply-To: <20220526131315.30515-2-attila@lendvai.name> References: <20220526131315.30515-2-attila@lendvai.name> Feedback-ID: 28384833:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55659 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) note: this requires https://issues.guix.gnu.org/55656 -- =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CIn a democracy, mass opinion creates power. Power diverts funds to= the manufacturers of opinion, who manufacture more, etc. [=E2=80=A6] This = feedback loop generates a playing field on which the most competitive ideas= are not those which best correspond to reality, but those which produce th= e strongest feedback.=E2=80=9D =09=E2=80=94 Mencius Moldbug From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 16 17:12:04 2022 Received: (at 55659) by debbugs.gnu.org; 16 Jun 2022 21:12:04 +0000 Received: from localhost ([127.0.0.1]:43209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1wmY-0004Yl-0X for submit@debbugs.gnu.org; Thu, 16 Jun 2022 17:12:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1wmS-0004YR-UP for 55659@debbugs.gnu.org; Thu, 16 Jun 2022 17:12:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50322) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1wmM-0000QT-FR; Thu, 16 Jun 2022 17:11:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=tms1joojyKbZVGWAFmXmivD/rN5T122fWsN4rRlJFx4=; b=ZmuJJlUroKxO5fdZKq6N wihu1vGIAB8BTlFQ8gYBRIT/fowhABJlrmKNef7GliuvGseSx+BxsrCltPVK/v49sW46Q7k0K7Fwl GFaOTPNpmpNumSAb3CNlDteRgjUj7b2xAQgPoaa5nEuyyCK9UtzU+HynBmMc0LWaTdXb/W8ab0qtv v6gPcQVdpisGgn3tUXJinQAp/sxl1fSogZifkz3/R93NCHw53m2q2hXc8nCrbymD4j2xlOo09sxS6 YhIVxBMtyVGNuhoZU4q9RbBTXJ+YWHLRMpITujvZaTCJzoyGhSc/8brrs6K2VVa3YYrQ0pgLfA1my TtGwdVAN/gUq1Q==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:60958 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1wmM-0001Np-0W; Thu, 16 Jun 2022 17:11:50 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Attila Lendvai Subject: Re: bug#55659: [PATCH 1/2] services: ddclient: Fix extra-options serialization. References: <20220526130912.29483-1-attila@lendvai.name> Date: Thu, 16 Jun 2022 23:11:47 +0200 In-Reply-To: <20220526130912.29483-1-attila@lendvai.name> (Attila Lendvai's message of "Thu, 26 May 2022 15:09:12 +0200") Message-ID: <87mtecjoto.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55659 Cc: 55659@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Attila Lendvai skribis: > Prior to this fix it has serialized "extra-options=3D..." into the ddclie= nt.conf > file. [...] > (define (serialize-field field-name val) > - (when (not (member field-name '(group secret-file user))) > - (format #t "~a=3D~a\n" (uglify-field-name field-name) val))) > + (cond > + ((eq? field-name 'extra-options) > + (display val)) > + ((not (member field-name '(group secret-file user))) > + (format #t "~a=3D~a\n" (uglify-field-name field-name) val)))) >=20=20 > (define (serialize-boolean field-name val) > (serialize-field field-name (if val "yes" "no"))) > @@ -921,9 +924,6 @@ (define (serialize-string field-name val) > (define (serialize-list field-name val) > (if (null? val) "" (serialize-field field-name (string-join val)))) >=20=20 > -(define (serialize-extra-options extra-options) > - (string-join extra-options "\n" 'suffix)) > - > (define-configuration ddclient-configuration > (ddclient > (file-like ddclient) > @@ -959,8 +959,8 @@ (define-configuration ddclient-configuration > file contains credentials for use by ddclient. You are expected to crea= te it > manually.") > (extra-options > - (list '()) > - "Extra options will be appended to @file{ddclient.conf} file.")) > + (string "") > + "Extra options will be appended verbatim to the @file{ddclient.conf} = file.")) In other places, such as (gnu home services desktop), I=E2=80=99ve used an = extra =E2=80=98raw-configuration-string=E2=80=99 field type to handle this cases.= This might be clearer than adding the =E2=80=98cond=E2=80=99 above in =E2=80=98seriali= ze-field=E2=80=99. WDYT? The change above also changes the interface (from list to string), but I think that=E2=80=99s OK. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 01:38:24 2022 Received: (at 55659) by debbugs.gnu.org; 17 Jun 2022 05:38:25 +0000 Received: from localhost ([127.0.0.1]:43535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o24ga-0002E9-M9 for submit@debbugs.gnu.org; Fri, 17 Jun 2022 01:38:24 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:35508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o24gZ-0002Dw-3w for 55659@debbugs.gnu.org; Fri, 17 Jun 2022 01:38:23 -0400 Received: by mail-lf1-f41.google.com with SMTP id a29so5353519lfk.2 for <55659@debbugs.gnu.org>; Thu, 16 Jun 2022 22:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=oeLSFSOCqILo1xelgDpIgPcVqvoonh4Cmv5vd84Y/qg=; b=Ao+zGbQfluT8y+r/PSuijRffmCOa7yboZHhCV+DiITdFu/sblLUO+ltKmJje+bTmtH 36Zn+5/I5eGdn22iCp44Y62PceoWLoLqg5wyWCS7L5e2zUPRUwjpYSSLRoduaGQv3CrX irbFcI2dOdCzFYfm8QLuPncF0hlU43GBrUo8gMGL5Em1SftqQNV10bHrbLnItAsMWkPL RCVuri4bXa3UMq7GmNwHkuukYnfL4yEtQWmdAJUevT0ub1Uy2XJwvJcVH9yx6oWSL7iH KERHOcy3kM5J9i/Vbv6SJOiUP5IOXkAze2MZJu/HBJVHb0W7nzXtuUAfwORkBxOXDYpt bLcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=oeLSFSOCqILo1xelgDpIgPcVqvoonh4Cmv5vd84Y/qg=; b=oxcIZGKv1ENjVlC8Fi5fRi5CL/78zuQdY9gyaKyo2QPMpmenQh17cRIy4mcTaym35v bnfBs/C7fosfECLjWaPLy25JZo5O6zY1daNS+UyskNokYya7eZLoLfRrgFjxeSBawoxa 8psNsILBRywJsdq5nZ7T5ls4dyilmuEq/JlxwKQ8nlYcWIVpOCvPc5L4h4QbSrDkRZR0 o1gJrAFnmLnjQSKwW16p6KSKnA2PFTuE/4xCXrWq3JBXFeLcYKlE10lTBpQVThRV+trM OidiEkmo+OVuQ87JEj9aSYtCD6pUgZ2T1oEG0qniDwKofOPNgdQp080OoDqx1gwxaxqc ajSg== X-Gm-Message-State: AJIora+V/20wQfmwil4vrSt8+BvoSe5IH2acSN+xhBlIA3u4uxFY8Pf3 i9s/8XOLzIztehGawVMg7LU= X-Google-Smtp-Source: AGRyM1tNeO8L5nn94dn+Zs/ekCkZHykIJi9hxsOs62UqVtP7VUxBUL2CO7MX/x3zx+xf0QDP8ncg6w== X-Received: by 2002:a05:6512:39d2:b0:479:47ad:4e9a with SMTP id k18-20020a05651239d200b0047947ad4e9amr4498077lfu.379.1655444296740; Thu, 16 Jun 2022 22:38:16 -0700 (PDT) Received: from localhost ([88.201.161.72]) by smtp.gmail.com with ESMTPSA id t7-20020a056512208700b0047255d211cfsm502067lfr.254.2022.06.16.22.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 22:38:16 -0700 (PDT) From: Oleg Pykhalov To: Attila Lendvai Subject: Re: bug#55659: [PATCH 1/2] services: ddclient: Fix extra-options serialization. References: <20220526130912.29483-1-attila@lendvai.name> <20220526131315.30515-2-attila@lendvai.name> Date: Fri, 17 Jun 2022 08:38:14 +0300 In-Reply-To: <20220526131315.30515-2-attila@lendvai.name> (Attila Lendvai's message of "Thu, 26 May 2022 15:13:16 +0200") Message-ID: <87r13nkfy1.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55659 Cc: 55659@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Attila Lendvai writes: > note that this seems to work, but is not fully tested. i have > abandoned the use of ddclient and with that this patchset. I use it on my system, and could test it. [=E2=80=A6] > (native-inputs > - (list bash perl)) > + (list bash autoconf automake > + perl > + ;; For the tests. > + perl-try-tiny perl-test-warnings perl-http-daemon-ssl > + perl-io-socket-inet6 perl-test-www-mechanize-psgi > + perl-test-mockmodule)) Applied on current master 6fc33d91ba6b07beae8a9a38a5b768511bb79ced: =2D-8<---------------cut here---------------start------------->8--- oleg@guixsd ~/src/guix [env]$ ./pre-inst-env guix build ddclient gnu/packages/dns.scm:1113:44: In procedure native-inputs: error: perl-http-daemon-ssl: unbound variable hint: Did you forget a `use-modules' form? =2D-8<---------------cut here---------------end--------------->8--- Did you forget to attach a patch adding the perl-http-daemon-ssl? [=E2=80=A6] Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAmKsE0YUHGdvLndpZ3Vz dEBnbWFpbC5jb20ACgkQFn+OpQAa+pzPVxAAj8ciiNZpRfaTmjqzhRxbERQlrL9r eH0gjckxXY94KeoEoXA0DO6TJp/AORoQCvwMuhr+kekPwRt06wh6VWTgu+5tCk+N b5umjmUOGSoGd39rtp3Wa7WVBM1BqxKzeAEA8fNzOGVk4uskeC/O7O8noPBIW0yq 0So9trFgaL5429aD0vz8/2cMsyaA2W44c3waXxk/K8J7GaHQuNBWKRXtn4CK2nse G42gGsu9nOVdT1QFY+Of6UnHqAxH1CTvR946/KPa0W+sqK/hWZlecOqlF4ziO2Qi RLtWvw5fHaO/If+afu55z/G4vYTc3bxLjhD2P0XThmLQO24XDYF1XfE816jFHIVk NguRhdriIlpvHs7lRWdKJ4Lj/eFrv2Ik/NjMGUdeSAE3C60ZaiqRDahTPDqsqU4L 5T6W0PCVRRaAwvJQkDl8fq1H9TglKngPRAYA+IbCt0pq4baFtWtSlPWi2gKlIxtk sdq3AwVQSFpkrzxsSl4nsUEKtkC6aLz05px8+XCuL4LUA++gy7Gy2dqgvrK9Aab0 ZJ9dmo9IbvJOCvWYykgUS7Jrl/mHkDXB27zcmfpcjQxBrMeE9enXlUA+XbPSsMMZ Jbe+sdTAt+PW7VQnpWSh5luv/DoZ0OMeZ6TOJ0Kxcx4DTU035vils8KorYLquLKZ Cjyo+GYUZ/u18pA= =fPth -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 04:27:09 2022 Received: (at 55659) by debbugs.gnu.org; 17 Jun 2022 08:27:09 +0000 Received: from localhost ([127.0.0.1]:43643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o27Jt-0006UP-5V for submit@debbugs.gnu.org; Fri, 17 Jun 2022 04:27:09 -0400 Received: from mail-4317.proton.ch ([185.70.43.17]:24231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o27Jn-0006Th-Ld for 55659@debbugs.gnu.org; Fri, 17 Jun 2022 04:27:08 -0400 Date: Fri, 17 Jun 2022 08:26:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail; t=1655454416; x=1655713616; bh=H4OouvwnmmSS75akrDZfEtpMXJ8jrJG/LA2NXUpi07s=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=phGGH9njRUTZApFKiJRoBchVRjLcjegBBoD+gjpgV2HIJQMN50MbhnxKlVzbt/auX 9n0e4coYjvhsdBMMolea/KTwo87UwYIyQYF8Tiangf7AnJ8kfuvXXqQ7K33syAVyut Ec+QgkPIFxwBThR7a4i0ebHGqmJOx3cgchZazqSeO40CDKNLdTY5SJdovWhe9vHgv9 73TmTIf872DHjPHUGb3+s2YbkWVXV09gJHiV1V+F6eEf3oprOuRRpPAsRQf9gGsykb h8OqPpwCozG0lUOjUqWesYn57DXnlJX3IK0xHJwTEQVOko4Ptu0n89xTTHm7cT1BO9 V9pnCOdPHlufA== To: Oleg Pykhalov From: Attila Lendvai Subject: Re: bug#55659: [PATCH 1/2] services: ddclient: Fix extra-options serialization. Message-ID: In-Reply-To: <87r13nkfy1.fsf_-_@gmail.com> References: <20220526130912.29483-1-attila@lendvai.name> <20220526131315.30515-2-attila@lendvai.name> <87r13nkfy1.fsf_-_@gmail.com> Feedback-ID: 28384833:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55659 Cc: 55659@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Applied on current master 6fc33d91ba6b07beae8a9a38a5b768511bb79ced: > --8<---------------cut here---------------start------------->8--- > > oleg@guixsd ~/src/guix [env]$ ./pre-inst-env guix build ddclient > gnu/packages/dns.scm:1113:44: In procedure native-inputs: > error: perl-http-daemon-ssl: unbound variable > hint: Did you forget a `use-modules' form? > --8<---------------cut here---------------end--------------->8--- > > > Did you forget to attach a patch adding the perl-http-daemon-ssl? forgot to say that this depends on https://issues.guix.gnu.org/55656 i was advised to split patchsets, but i think i really shouldn't have in th= is case. sorry for the confusion, and thanks for testing it! -- =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CWithout love the acquisition of knowledge only increases confusion= and leads to self-destruction.=E2=80=9D =09=E2=80=94 Jiddu Krishnamurti (1895=E2=80=931986) From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 04:53:23 2022 Received: (at 55659) by debbugs.gnu.org; 17 Jun 2022 08:53:23 +0000 Received: from localhost ([127.0.0.1]:43674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o27jG-0007Dd-Sg for submit@debbugs.gnu.org; Fri, 17 Jun 2022 04:53:23 -0400 Received: from mail-4317.proton.ch ([185.70.43.17]:55688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o27jC-0007DL-Jb for 55659@debbugs.gnu.org; Fri, 17 Jun 2022 04:53:21 -0400 Date: Fri, 17 Jun 2022 08:53:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail; t=1655455992; x=1655715192; bh=a1wd8Rw9I+zzujbl33esdKvcJnkx9wEPj1l2xVcBong=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=fAqDErwVaXDi4POHr21FSSkZr1rIqBQNd9MdH6oETS1oABovHoIofizMuakx88/tO RZqAIjIyEI4F91Ghsx/SBlHONRB3cGRTPDQd5cHeMjdifHwAyVBBT/kzjf3Mh1KDro sLO2ebNmQ8hMs6pJRATWg8MNzAuKutdAi1NHgHIoKrE+2iG0W49RHFsE/zJi9BME6L A4gMyJv6zGc3Ad4uosBXbVUFRCyH/WOeu0LXcWz2vQLj2MA8Yae4E7eYOlMxhbPZq0 3GbSBk5VAWCuFo2VMV6x4VTF4bHsDC2EDGMOUlj7JNhCDuoA26O3vjkxaU+X5qKwZ5 ZOu43CSUYN6zA== To: =?utf-8?Q?Ludovic_Court=C3=A8s?= From: Attila Lendvai Subject: Re: bug#55659: [PATCH 1/2] services: ddclient: Fix extra-options serialization. Message-ID: <2S-Am7ZdiqFMMIq6yXdzPJWKxVzRAnpPSN1jxE3-ZzepKJLuXXjipZOJNzdCesft1R_JkjD3z6OcQ75_vNFY1alvPW03W88wOLtrH77w77c=@lendvai.name> In-Reply-To: <87mtecjoto.fsf@gnu.org> References: <20220526130912.29483-1-attila@lendvai.name> <87mtecjoto.fsf@gnu.org> Feedback-ID: 28384833:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55659 Cc: 55659@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > In other places, such as (gnu home services desktop), I=E2=80=99ve used a= n extra > =E2=80=98raw-configuration-string=E2=80=99 field type to handle this case= s. This might > be clearer than adding the =E2=80=98cond=E2=80=99 above in =E2=80=98seria= lize-field=E2=80=99. WDYT? i agree, it's a much better, more intuitive name. i'll use it from now on. (note that i'm not planning to work on this more. i hope someone will pick = this up who actually uses ddclient, and therefore has the ability to test i= t with little effort. feel free to close it, too.) -- =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CThere is no leader, there is no teacher, there is nobody to tell y= ou what to do. You are alone in this mad, brutal world.=E2=80=9D =09=E2=80=94 Jiddu Krishnamurti (1895=E2=80=931986) From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 03 06:00:47 2022 Received: (at control) by debbugs.gnu.org; 3 Aug 2022 10:00:47 +0000 Received: from localhost ([127.0.0.1]:46161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJBBH-0003X6-E3 for submit@debbugs.gnu.org; Wed, 03 Aug 2022 06:00:47 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:51035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJBBE-0003Wr-QO for control@debbugs.gnu.org; Wed, 03 Aug 2022 06:00:45 -0400 Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=ludo@gnu.org; dmarc=fail (p=none dis=none) d=gnu.org X-IronPort-AV: E=Sophos;i="5.93,213,1654552800"; d="scan'208";a="47832215" Received: from 91-160-117-201.subs.proxad.net (HELO ribbon) ([91.160.117.201]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2022 12:00:36 +0200 Date: Wed, 03 Aug 2022 12:00:36 +0200 Message-Id: <87fsidve7v.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #55659 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) tags 55659 wontfix close 55659 quit From unknown Fri Jun 20 07:18:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 31 Aug 2022 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator