Subject: [bug#55637] [PATCH] gnu: Add python-pylink-square.

From: Christopher Baines <[email-masked]>
Date: Fri, 27 May 2022 10:26:07 +0100

[email-masked] writes:

> From: Peter Polidoro <[email-masked]>
>
> * gnu/packages/embedded.scm (python-pylink-square): New variable.
> ---
>  gnu/packages/embedded.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm
> index 010f5b84d2..75675c2698 100644
> --- a/gnu/packages/embedded.scm
> +++ b/gnu/packages/embedded.scm
> @@ -1699,3 +1699,34 @@ (define-public mbed-tools
>  connected by USB, checkout Mbed projects and perform builds amongst other
>  operations.")
>      (license license:asl2.0)))
> +
> +(define-public python-pylink-square
> +  (package
> +    (name "python-pylink-square")
> +    (version "0.12.0")
> +    (source
> +     ;; The tests suite appears to be incomplete in the PyPI archive.
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "http://www.github.com/Square/pylink")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0w0pi91gvaw9k2r267kpc1ryd74v19iq5ysn4j7pf4g2069gbgxf"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'patch-setup
> +                    (lambda _
> +                      (substitute* "setup.py"
> +                        (("mock == 2.0.0") "mock")))))))
> +    (native-inputs (list python-mock))
> +    (propagated-inputs (list python-future
> +                             python-psutil
> +                             python-six
> +                             libjaylink))
> +    (home-page "http://www.github.com/Square/pylink")
> +    (synopsis "Python interface for SEGGER J-Link.")
> +    (description "Python interface for SEGGER J-Link.")
> +    (license license:asl2.0)))

The description here also looks like it could be improved a bit.

Are you able to send some updated patches?

Also, when sending a few related patches, it's helpful if you get git
send-email to send them as a series, so something like:

  git send-email HEAD~3

To send patches for the last 3 commits.