From debbugs-submit-bounces@debbugs.gnu.org Wed May 25 10:03:41 2022 Received: (at submit) by debbugs.gnu.org; 25 May 2022 14:03:41 +0000 Received: from localhost ([127.0.0.1]:56137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntrbq-0008JG-A4 for submit@debbugs.gnu.org; Wed, 25 May 2022 10:03:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:39608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntn0x-0007q4-IY for submit@debbugs.gnu.org; Wed, 25 May 2022 05:09:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntn0r-0006d3-Jm for bug-gnu-emacs@gnu.org; Wed, 25 May 2022 05:09:11 -0400 Received: from mout02.posteo.de ([185.67.36.66]:34267) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntn0l-0003xO-K4 for bug-gnu-emacs@gnu.org; Wed, 25 May 2022 05:09:05 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 972A0240108 for ; Wed, 25 May 2022 11:08:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.org; s=2017; t=1653469735; bh=7g7HUXBamKt6yrtTWT2ch2vPVqSFTyX0LK3OHi8HAHc=; h=From:To:Subject:Date:From; b=NeCRvKywCt1hOgpBAIzPhcl0R65EVPPfMtlN4bgpyMnh7pPviJdjiItTvRJ528uYd 7+cD7nQZvsLSdxeiJgOzyNqgK93oOEmBKepbbDjEvxSHl8spjLO8CqAHb3rd1MF4Hn 2Lf7JsNKJQf2RZ5cHQD+p3abyy+zNMk0beN6YTc0xRKBYrMN/4Bu+aVkLsGtzYCon+ hm9WwDbWCFfaZSqSE38MVERS8eHi4EPq5ZxMJXTFm+eEO4zM08FxpMAN/ZZj13jlvt J1U+hIONze39XinKg5FrK8XT1g1HDkC3NK0uuHVXF4bJMDQ3lulFIRm9IRtVgjdIFq kKl3jh/zIR38w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4L7QGv1FFnz9rxf for ; Wed, 25 May 2022 11:08:55 +0200 (CEST) From: =?utf-8?B?SmFuIFN5bsOhxI1law==?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add new user option project-vc-find-tracked-only Date: Wed, 25 May 2022 09:08:54 +0000 Message-ID: <87leuqkmhl.fsf@posteo.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=jan.synacek@posteo.org; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 25 May 2022 10:03:28 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch Tags: patch Currently, `project-find-file' always includes untracked files, which is not always the desired behavior. This patch adds a new user option to make only find the actual project files. By default, the variable is set to nil, which means the behavior is not changed. In GNU Emacs 28.1.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.17.6) of 2022-05-21 built on jsynacek-home Repository revision: 9e7c0cf57d522b50423880f3a846c52c5509fef9 Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12101003 System Description: Arch Linux Configured using: 'configure --with-imagemagick --with-json --with-native-compilation --prefix=/home/jsynacek/emacs' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Add-new-user-option-project-vc-find-tracked-only.patch >From e1562448ca0d95188c4dc9712c8aa4575a5a3bdd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Syn=C3=A1=C4=8Dek?= Date: Wed, 25 May 2022 10:53:55 +0200 Subject: [PATCH] Add new user option project-vc-find-tracked-only * doc/emacs/maintaining.texi (Projects): Document it. * lisp/progmodes/project.el (project--vc-list-files): Use it. --- doc/emacs/maintaining.texi | 6 ++++-- etc/NEWS | 5 +++++ lisp/progmodes/project.el | 16 +++++++++++----- 3 files changed, 20 insertions(+), 7 deletions(-) diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi index 3ddea0ae58..c33b649490 100644 --- a/doc/emacs/maintaining.texi +++ b/doc/emacs/maintaining.texi @@ -1664,8 +1664,10 @@ Projects support additional types of projects. Which files do or don't belong to a project is also determined by -the project back-end. For example, the VC back-end doesn't consider -``ignored'' files (@pxref{VC Ignore}) to be part of the project. +the project back-end. For example, the VC back-end only considers +``ignored'' files (@pxref{VC Ignore}) to be part of the project if +the value of the variable @code{project-vc-find-tracked-only} is +non-nil. @menu * Project File Commands:: Commands for handling project files. diff --git a/etc/NEWS b/etc/NEWS index 857f300384..abae05749c 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1678,6 +1678,11 @@ Enabling this minor mode turns on hiding header material, like 'elide-head' does; disabling it shows the header. The commands 'elide-head' and 'elide-head-show' are now obsolete. ++++ +*** New user option 'project-vc-find-tracked-only'. +If set to non-nil, 'project-find-file' only considers tracked, that is +not ignored, files. + --- ** The autoarg.el library is now marked obsolete. This library provides the 'autoarg-mode' and 'autoarg-kp-mode' minor diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 6c50135358..836d6a1574 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -382,6 +382,11 @@ project-vc-merge-submodules :package-version '(project . "0.2.0") :safe #'booleanp) +(defcustom project-vc-find-tracked-only nil + "Non-nil makes `project-find-file' consider only tracked files." + :type 'boolean + :safe #'booleanp) + ;; FIXME: Using the current approach, major modes are supposed to set ;; this variable to a buffer-local value. So we don't have access to ;; the "external roots" of language A from buffers of language B, which @@ -512,8 +517,9 @@ project--vc-list-files (args '("-z")) (vc-git-use-literal-pathspecs nil) files) - ;; Include unregistered. - (setq args (append args '("-c" "-o" "--exclude-standard"))) + (setq args (append args + '("-c" "--exclude-standard") + (unless project-vc-find-tracked-only '("-o")))) (when extra-ignores (setq args (append args (cons "--" @@ -565,9 +571,9 @@ project--vc-list-files (delete-consecutive-dups files))) (`Hg (let ((default-directory (expand-file-name (file-name-as-directory dir))) - args) - ;; Include unregistered. - (setq args (nconc args '("-mcardu" "--no-status" "-0"))) + (args (list (concat "-mcard" (unless project-vc-find-tracked-only "u")) + "--no-status" + "-0"))) (when extra-ignores (setq args (nconc args (mapcan -- 2.36.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 27 07:01:37 2022 Received: (at 55632) by debbugs.gnu.org; 27 May 2022 11:01:37 +0000 Received: from localhost ([127.0.0.1]:32899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuXir-0000cO-57 for submit@debbugs.gnu.org; Fri, 27 May 2022 07:01:37 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuXip-0000c9-G2 for 55632@debbugs.gnu.org; Fri, 27 May 2022 07:01:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6kVKTlTTcUghg2oXu0HbPpWa0jZxnoLmIKGoPUj0HSk=; b=NBngdWFipm81O9v4zrOKx2ikGg 3LKR7O/iq6932BRfDc5IowjjgR70O0i4F3Is/kpTSf/XPfsr5h61p2iDZPdpxvSRM6+ffjTdR4tbW 5xZYDybhfMRMfdMPcQ0l4SQDkq+gO4chNlOTQbmqt+ZxMjgApMoQJuJc1zRDQN0CIMu0=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuXig-0007AT-RX; Fri, 27 May 2022 13:01:29 +0200 From: Lars Ingebrigtsen To: Jan =?utf-8?B?U3luw6HEjWVr?= Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only References: <87leuqkmhl.fsf@posteo.org> X-Now-Playing: Cris Williamson's _The Changer and the Changed_: "Wild Things" Date: Fri, 27 May 2022 13:01:26 +0200 In-Reply-To: <87leuqkmhl.fsf@posteo.org> ("Jan =?utf-8?B?U3luw6HEjWVrIidz?= message of "Wed, 25 May 2022 09:08:54 +0000") Message-ID: <87pmjz6xyx.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jan Synáček writes: > Currently, `project-find-file' always includes untracked files, which is > not always the desired behavior. This patch adds a new user option to > make only find the actual project files. By default [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55632 Cc: 55632@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jan Syn=C3=A1=C4=8Dek writes: > Currently, `project-find-file' always includes untracked files, which is > not always the desired behavior. This patch adds a new user option to > make only find the actual project files. By default, the variable is set > to nil, which means the behavior is not changed. Makes sense to me, but perhaps Dmitry has some comments here -- added to the CCs. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri May 27 09:55:34 2022 Received: (at 55632) by debbugs.gnu.org; 27 May 2022 13:55:35 +0000 Received: from localhost ([127.0.0.1]:34437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuaRC-0003Wl-OP for submit@debbugs.gnu.org; Fri, 27 May 2022 09:55:34 -0400 Received: from mail-ej1-f42.google.com ([209.85.218.42]:40941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuaRB-0003Rk-Vq for 55632@debbugs.gnu.org; Fri, 27 May 2022 09:55:34 -0400 Received: by mail-ej1-f42.google.com with SMTP id wh22so8956596ejb.7 for <55632@debbugs.gnu.org>; Fri, 27 May 2022 06:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=rKzj8H0/VmF7QZOdB3IPY9My4an6Cp6TNhzFy2TdcK8=; b=bBZkMwQQ3q64eps2c7iO8KVTSk7RvWPc/w8G7II/0zDdRVmjkwFr7Hvaoo6epCH9xy t1IrZFHiEK9W7JssbM/zz1G8sxkYtwrOt62QE+wlu/nb6FsPrSzpScRJ6qpdIYNbvfWQ LZJqYLt4EcktNIQAX4mrvwIUhSPHnpucrBi0SfZhW2MjlA+nDVaXlqgdfJWoOsYDdx1i NvbfcEXlfePgLq5V7FvRBuhFSq+Hi3zCwC2B99JN6Sr7w9bZ81HA4id3ur2nQx8nS1Qx LXcNi1QFgOZlFkl7nLHnmUfgclVjXc7KGYEDVL73mt6B6unVpb3hq6dR/7JUoRTdeRZZ ZWAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=rKzj8H0/VmF7QZOdB3IPY9My4an6Cp6TNhzFy2TdcK8=; b=PndL4/FJj2O+1KaeojbXs/6PIMANY+PtCNT0SDaGo6MPC3xB7Z7Mtf+DD+qJTSZpjc F/4D6i0QOa8jK1qe65WLdGDBtk5nAD5XpgGeO3s2W5SX5ZT6G/DUDsprCeaVBJs2qNcs pGCz+Yh/koVhDuP0/r16qVK96x73DuSlI/NA260FAg7dmvDTDeY7sz//VKRJ5UcN67H3 IdRgmVcY/4x8qQytlmvAAs8IZcFMOerY1pmGL6fX7RbMGXqKfRXOz5m3s4BBM7MvEma1 RNeA0PRJeb1nQMLqE6xELMBaOkvx8kg3EmAoEH2IawZIEE9WuJW3cLbN8a1pP0wrqkdG davw== X-Gm-Message-State: AOAM531rzwGVFqMC/aFao16KVPdEpIw5jRVZG2DysIdqhxFNsmBPrqlZ B8Wpn3aVBhAGhyB1hHcKGBs= X-Google-Smtp-Source: ABdhPJyQ4V426QKYI+mjN10AKxrPKfLclCSsqbbmPttG7Hi24z0WccH8Jqlo0r/EUjtc8Chh1MTVAQ== X-Received: by 2002:a17:907:3e82:b0:6ff:1e04:a365 with SMTP id hs2-20020a1709073e8200b006ff1e04a365mr9121799ejc.617.1653659727722; Fri, 27 May 2022 06:55:27 -0700 (PDT) Received: from [192.168.236.48] ([173.237.64.48]) by smtp.googlemail.com with ESMTPSA id j12-20020a1709062a0c00b006fee28d459csm1498353eje.224.2022.05.27.06.55.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 May 2022 06:55:26 -0700 (PDT) Message-ID: <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> Date: Fri, 27 May 2022 16:55:24 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only Content-Language: en-US To: =?UTF-8?B?SmFuIFN5bsOhxI1law==?= , 55632@debbugs.gnu.org References: <87leuqkmhl.fsf@posteo.org> From: Dmitry Gutov In-Reply-To: <87leuqkmhl.fsf@posteo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55632 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 25.05.2022 12:08, Jan Synáček wrote: > Currently, `project-find-file' always includes untracked files, which is > not always the desired behavior. This patch adds a new user option to > make only find the actual project files. By default, the variable is set > to nil, which means the behavior is not changed. Sure, thanks. I'll review this soon-ish. As long as you are aware of the user option project-vc-ignores (which can be set directory-locally), and are certain that it doesn't satisfy your needs. From debbugs-submit-bounces@debbugs.gnu.org Sun May 29 17:41:31 2022 Received: (at 55632) by debbugs.gnu.org; 29 May 2022 21:41:31 +0000 Received: from localhost ([127.0.0.1]:42059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvQfD-0000u8-83 for submit@debbugs.gnu.org; Sun, 29 May 2022 17:41:31 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:35751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvQfB-0000tv-DY for 55632@debbugs.gnu.org; Sun, 29 May 2022 17:41:29 -0400 Received: by mail-wr1-f44.google.com with SMTP id q21so1131283wra.2 for <55632@debbugs.gnu.org>; Sun, 29 May 2022 14:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=+MKFrMRgQ+FphWyxDKgKRCWuKcqf2cqKBDdi+dyo6bs=; b=MH3QMeqguEXGyURlVwwbz77G31Ywmc1fU//Mt70WE9AceSQ0VlKSwP2qlPfCpgtOZd Ab5fUl4aY/zMQt1gAktIZ1WEaylLj9MRC4eGBEUEkpS7u1if2xc9ykmRO8doNvE4uKq+ tmlaPJCS0pVdVWdNnPpuY5ZpQ2o3Hkw7UmYT4rQND3tMh8IhmAMuN+/timiFmWgWscSP 7rarl5z5QLSYk7okM7TzYqeyd1IECtHGBYixf6Q9mJGTzIgg0KxQmKxmmIxWmZH8kbsu fXC3KcZQbon004kxcMyoiwBv8IkK/KvoM3LYAwjBkiiyJ7ntFYufybJDEbYoZl8XZpOD Cq7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=+MKFrMRgQ+FphWyxDKgKRCWuKcqf2cqKBDdi+dyo6bs=; b=SbV8m9tCy+M4kzM2I/aaCwVFVVH/zUaG1t8P078+OAS6yUjaf24MH+b+CslNajzlvE zC5gbx+P0NbIgWW6eA84R1JgHD3g7jz12RjbGZPRWXu2t5TAsu9ruU4c9LQXLQsZbw2q wYNuKxCdF9yFhkRUxHrPSrvDZWcO9p8obTsJ5RfpO/xNT1mejmKLHHkjqzmeDeArhFXA P0CG08fgl7DIAWh4/yh+j3PzC8sv575UXy+yEHUbxrQQ0tRSN74RFOYCwpRRSHPq7q/x ddqu//RklkFnJRDkeYh2pGWpZvRZPHEpzv55nxYnx/vNePTfhxzwqSqNS2C36wZsnJPn buxQ== X-Gm-Message-State: AOAM533mMIC5hsqvp1NVOZ+MVV1+6b1oTGRBAugzss0C6KVcdnYHARi1 SX4cgE8XTIde8pHynqZ1UpU= X-Google-Smtp-Source: ABdhPJwqul7OOUCeOlLcVrNnv5+IzynJ+70Z0WCcfUBuuoub3jpeOlXkpcyK3R+InQxdt8N1PtBtTA== X-Received: by 2002:adf:d08d:0:b0:20f:fb5a:6b43 with SMTP id y13-20020adfd08d000000b0020ffb5a6b43mr20709395wrh.637.1653860483393; Sun, 29 May 2022 14:41:23 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o12-20020a5d648c000000b0020e6c51f070sm7447365wri.112.2022.05.29.14.41.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 May 2022 14:41:22 -0700 (PDT) Message-ID: Date: Mon, 30 May 2022 00:41:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only Content-Language: en-US From: Dmitry Gutov To: =?UTF-8?B?SmFuIFN5bsOhxI1law==?= , 55632@debbugs.gnu.org References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> In-Reply-To: <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55632 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 27.05.2022 16:55, Dmitry Gutov wrote: > On 25.05.2022 12:08, Jan Synáček wrote: >> Currently, `project-find-file' always includes untracked files, which is >> not always the desired behavior. This patch adds a new user option to >> make only find the actual project files. By default, the variable is set >> to nil, which means the behavior is not changed. > > Sure, thanks. I'll review this soon-ish. The patch seems functional, thanks. Should also get you better performance, if this is the behavior you prefer. Regarding the naming and the docstring, though: unlike what the defcustom says, it will affect also 'project-find-regexp' (i.e. which files get searched by this command), and all other features that delegate to 'project-files' internally. So the docstring could use some generalizing. And consider these two options for rename: - project-vc-tracked-only (defaulting to nil, like in the patch) - project-vc-include-untracked (defaulting to t) The docstring could say something like: When non-nil, the VC project backend includes the untracked files. From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 06:09:02 2022 Received: (at 55632) by debbugs.gnu.org; 30 May 2022 10:09:02 +0000 Received: from localhost ([127.0.0.1]:42822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvcKb-0007U9-S9 for submit@debbugs.gnu.org; Mon, 30 May 2022 06:09:02 -0400 Received: from mout02.posteo.de ([185.67.36.66]:53933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvcKa-0007Th-7q for 55632@debbugs.gnu.org; Mon, 30 May 2022 06:09:01 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 4207E240108 for <55632@debbugs.gnu.org>; Mon, 30 May 2022 12:08:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.org; s=2017; t=1653905334; bh=JZzH+Ea1vJmEdsDvBhNHw9o1VUm5G1awWEw9xC0dtww=; h=Date:From:To:Cc:Subject:From; b=lBpcTqRcWgAuL6UB6KQM0zEBIchxEPnkxWdc3RgPwOSwyC8m4BKelCVBelsDIthjJ B4x0HUtrSjgnCh3yZV7oYkEXlCSq9nhE6KwXBNBT8Iqj/COslFvf3pPOU85c3iHoiA a09Ff5cTi0Q2C9LrcTq1OPpWo8aGyNjtYs6RzX3lNpBoYKiQ/Aq0JArc2bfzCkKNUe 35kgG0tngndka4dzDJnvnqUTgQP+WqnE0PkWcgB3h/cSCajopY8qv9BsHr2Ze6KIEc p/7eypijsZCy3NZyshaOmO9+uRFUtQks17x+dZ2aAeb7B+nZzlr1aXpEv/6JIF6a8s DHds5/R20ecNA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4LBWMn0z4dz6tmQ; Mon, 30 May 2022 12:08:53 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Date: Mon, 30 May 2022 10:08:52 +0000 From: jan.synacek@posteo.org To: Dmitry Gutov Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only In-Reply-To: <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> Message-ID: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55632 Cc: 55632@debbugs.gnu.org, DG X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 27.05.2022 15:55, Dmitry Gutov wrote: > On 25.05.2022 12:08, Jan Syn=C3=A1=C4=8Dek wrote: >> Currently, `project-find-file' always includes untracked files, which=20 >> is >> not always the desired behavior. This patch adds a new user option to >> make only find the actual project files. By default, the variable is=20 >> set >> to nil, which means the behavior is not changed. >=20 > Sure, thanks. I'll review this soon-ish. >=20 > As long as you are aware of the user option project-vc-ignores (which > can be set directory-locally), and are certain that it doesn't satisfy > your needs. Short answer: Yes, I'm aware, but that option is something different. I don't want to=20 add anything to ignore. Long answer: This mostly applies to the git and mercurial Emacs backends where the=20 untracked files are used by default now. I think that presenting a "project" as pretty much=20 everything in a folder (unless selectively ignored by using project-vc-ignores, for=20 example) only makes sense if there is no underlying VCS, otherwise it's pretty much=20 backwards. Because if there's already a repo that tracks files, the project should be, in my=20 opinion, just the files in that repo that the underlying VCS sees as tracked. That is the=20 default behavior in git and mercurial as far as I know (I don't use mercurial much, but=20 use git a lot). The VCS also has a mechanism for including untracked files in case the user=20 wants to see them in some operations, and ignoring additional files so that they don't=20 count towards those untracked files. These two options should map 1 to 1 to Emacs custom=20 variables, in my opinion. So, in summary, I would suggest to change the VC backends that support=20 this to behave by default as the underlying VCS would behave and use custom variables to=20 add additional tweaks for non-default stuff. Of course, that is out of scope for this=20 patch. From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 07:00:21 2022 Received: (at 55632) by debbugs.gnu.org; 30 May 2022 11:00:21 +0000 Received: from localhost ([127.0.0.1]:42905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvd8G-0000ae-SE for submit@debbugs.gnu.org; Mon, 30 May 2022 07:00:21 -0400 Received: from mout02.posteo.de ([185.67.36.66]:45687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvd8A-0000aC-St for 55632@debbugs.gnu.org; Mon, 30 May 2022 07:00:19 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9AD62240109 for <55632@debbugs.gnu.org>; Mon, 30 May 2022 13:00:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.org; s=2017; t=1653908408; bh=xP6l5JjR94KE3wal8EMNGwMbJcQ7F+sGefpR1eMMIXk=; h=Date:From:To:Cc:Subject:From; b=DPgg9MuqwY4GW8PUq8pCSIsbNEE0VZEAGuXpSqYRjzUD3n/DevJBiUmhWMwfUs3KU 9Uz+qDO/haVfFa8mwg8iro76C7GyyBHSI5aoBkFtkT/QT/SKvlA38kD4whXlG1+f9u LIolXdRXKHEn+1gGI5E2emFARsrumIQXSYQ/2SBOemx6gGyqTT/tS5QksXiSnenZM4 IUYj+B35djj+VDDk1xWG7l0vTOKITZyPISOemme+YK+mZbF2E7r92mW8B3KIw8uiGg PYXT0wb9OZ1UvBDqKqmOeYDtbPoI5k4/xrJynyEdz32kRCKkJhtc7MGoaCMPa/yK+H bFoI50Lw8FicA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4LBXVv4St9z6tm9; Mon, 30 May 2022 13:00:07 +0200 (CEST) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_c4b091c9e73cc44cc80cb6f924cd70b8" Date: Mon, 30 May 2022 11:00:07 +0000 From: jan.synacek@posteo.org To: Dmitry Gutov Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only In-Reply-To: References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> Message-ID: <43b5eada954e592cc0c747368a3dbdb7@posteo.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55632 Cc: 55632@debbugs.gnu.org, DG X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=_c4b091c9e73cc44cc80cb6f924cd70b8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=flowed On 29.05.2022 23:41, Dmitry Gutov wrote: > On 27.05.2022 16:55, Dmitry Gutov wrote: >> On 25.05.2022 12:08, Jan Syn=C3=A1=C4=8Dek wrote: >>> Currently, `project-find-file' always includes untracked files, which= =20 >>> is >>> not always the desired behavior. This patch adds a new user option to >>> make only find the actual project files. By default, the variable is=20 >>> set >>> to nil, which means the behavior is not changed. >>=20 >> Sure, thanks. I'll review this soon-ish. >=20 > The patch seems functional, thanks. Should also get you better > performance, if this is the behavior you prefer. >=20 > Regarding the naming and the docstring, though: unlike what the > defcustom says, it will affect also 'project-find-regexp' (i.e. which > files get searched by this command), and all other features that > delegate to 'project-files' internally. >=20 > So the docstring could use some generalizing. And consider these two > options for rename: >=20 > - project-vc-tracked-only (defaulting to nil, like in the patch) > - project-vc-include-untracked (defaulting to t) >=20 > The docstring could say something like: >=20 > When non-nil, the VC project backend includes the untracked files. Thank you for the review. I addressed your comments in the new version=20 of the patch. --=_c4b091c9e73cc44cc80cb6f924cd70b8 Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name=0001-Add-new-user-option-project-vc-include-untracked.patch Content-Disposition: attachment; filename=0001-Add-new-user-option-project-vc-include-untracked.patch; size=3437 RnJvbSBiZTM2ODY0Nzc4M2RhOGMxMmUyZWExNzU0MDFkZDdmODRkMGNkNGM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/SmFuPTIwU3luPUMzPUExPUM0PThEZWs/PSA8 amFuLnN5bmFjZWtAZ21haWwuY29tPgpEYXRlOiBXZWQsIDI1IE1heSAyMDIyIDEwOjUzOjU1ICsw MjAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIG5ldyB1c2VyIG9wdGlvbiBwcm9qZWN0LXZjLWluY2x1 ZGUtdW50cmFja2VkCgoqIGRvYy9lbWFjcy9tYWludGFpbmluZy50ZXhpIChQcm9qZWN0cyk6IERv Y3VtZW50IGl0LgoqIGxpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgKHByb2plY3QtLXZjLWxpc3Qt ZmlsZXMpOiBVc2UgaXQuCi0tLQogZG9jL2VtYWNzL21haW50YWluaW5nLnRleGkgfCAgMyArKysK IGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgIHwgIDQgKysrKwogbGlzcC9wcm9nbW9kZXMvcHJv amVjdC5lbCAgfCAxNiArKysrKysrKysrKy0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDE4IGluc2Vy dGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL21haW50YWlu aW5nLnRleGkgYi9kb2MvZW1hY3MvbWFpbnRhaW5pbmcudGV4aQppbmRleCAzZGRlYTBhZTU4Li42 ZjBkYTYzODM3IDEwMDY0NAotLS0gYS9kb2MvZW1hY3MvbWFpbnRhaW5pbmcudGV4aQorKysgYi9k b2MvZW1hY3MvbWFpbnRhaW5pbmcudGV4aQpAQCAtMTY2Niw2ICsxNjY2LDkgQEAgUHJvamVjdHMK ICAgV2hpY2ggZmlsZXMgZG8gb3IgZG9uJ3QgYmVsb25nIHRvIGEgcHJvamVjdCBpcyBhbHNvIGRl dGVybWluZWQgYnkKIHRoZSBwcm9qZWN0IGJhY2stZW5kLiAgRm9yIGV4YW1wbGUsIHRoZSBWQyBi YWNrLWVuZCBkb2Vzbid0IGNvbnNpZGVyCiBgYGlnbm9yZWQnJyBmaWxlcyAoQHB4cmVme1ZDIEln bm9yZX0pIHRvIGJlIHBhcnQgb2YgdGhlIHByb2plY3QuCitBbHNvLCBzb21lIFZDIGJhY2stZW5k cyBjb25zaWRlciBgYHVudHJhY2tlZCcnIGZpbGVzIGJ5IGRlZmF1bHQuCitUaGF0IGJlaGF2aW9y IGlzIGNvbnRyb2xsYWJsZSB3aXRoIHRoZSB2YXJpYWJsZQorQGNvZGV7cHJvamVjdC12Yy1pbmNs dWRlLXVudHJhY2tlZH0uCiAKIEBtZW51CiAqIFByb2plY3QgRmlsZSBDb21tYW5kczo6ICAgQ29t bWFuZHMgZm9yIGhhbmRsaW5nIHByb2plY3QgZmlsZXMuCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBi L2V0Yy9ORVdTCmluZGV4IDU5ODdhY2RhYzkuLmI2OTVkNjMwMjAgMTAwNjQ0Ci0tLSBhL2V0Yy9O RVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0xNjkzLDYgKzE2OTMsMTAgQEAgRW5hYmxpbmcgdGhpcyBt aW5vciBtb2RlIHR1cm5zIG9uIGhpZGluZyBoZWFkZXIgbWF0ZXJpYWwsIGxpa2UKICdlbGlkZS1o ZWFkJyBkb2VzOyBkaXNhYmxpbmcgaXQgc2hvd3MgdGhlIGhlYWRlci4gIFRoZSBjb21tYW5kcwog J2VsaWRlLWhlYWQnIGFuZCAnZWxpZGUtaGVhZC1zaG93JyBhcmUgbm93IG9ic29sZXRlLgogCisr KysKKyoqKiBOZXcgdXNlciBvcHRpb24gJ3Byb2plY3QtdmMtaW5jbHVkZS11bnRyYWNrZWQnLgor V2hlbiBub24tbmlsLCB0aGUgVkMgcHJvamVjdCBiYWNrZW5kIGluY2x1ZGVzIHRoZSB1bnRyYWNr ZWQgZmlsZXMuCisKIC0tLQogKiogVGhlIGF1dG9hcmcuZWwgbGlicmFyeSBpcyBub3cgbWFya2Vk IG9ic29sZXRlLgogVGhpcyBsaWJyYXJ5IHByb3ZpZGVzIHRoZSAnYXV0b2FyZy1tb2RlJyBhbmQg J2F1dG9hcmcta3AtbW9kZScgbWlub3IKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2pl Y3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9wcm9qZWN0LmVsCmluZGV4IDZjNTAxMzUzNTguLmU0ODhm YTE0NWUgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9w cm9nbW9kZXMvcHJvamVjdC5lbApAQCAtMzgyLDYgKzM4MiwxMSBAQCBwcm9qZWN0LXZjLW1lcmdl LXN1Ym1vZHVsZXMKICAgOnBhY2thZ2UtdmVyc2lvbiAnKHByb2plY3QgLiAiMC4yLjAiKQogICA6 c2FmZSAjJ2Jvb2xlYW5wKQogCisoZGVmY3VzdG9tIHByb2plY3QtdmMtaW5jbHVkZS11bnRyYWNr ZWQgdAorICAiV2hlbiBub24tbmlsLCB0aGUgVkMgcHJvamVjdCBiYWNrZW5kIGluY2x1ZGVzIHRo ZSB1bnRyYWNrZWQgZmlsZXMuIgorICA6dHlwZSAnYm9vbGVhbgorICA6c2FmZSAjJ2Jvb2xlYW5w KQorCiA7OyBGSVhNRTogVXNpbmcgdGhlIGN1cnJlbnQgYXBwcm9hY2gsIG1ham9yIG1vZGVzIGFy ZSBzdXBwb3NlZCB0byBzZXQKIDs7IHRoaXMgdmFyaWFibGUgdG8gYSBidWZmZXItbG9jYWwgdmFs dWUuICBTbyB3ZSBkb24ndCBoYXZlIGFjY2VzcyB0bwogOzsgdGhlICJleHRlcm5hbCByb290cyIg b2YgbGFuZ3VhZ2UgQSBmcm9tIGJ1ZmZlcnMgb2YgbGFuZ3VhZ2UgQiwgd2hpY2gKQEAgLTUxMiw4 ICs1MTcsOSBAQCBwcm9qZWN0LS12Yy1saXN0LWZpbGVzCiAgICAgICAgICAgIChhcmdzICcoIi16 IikpCiAgICAgICAgICAgICh2Yy1naXQtdXNlLWxpdGVyYWwtcGF0aHNwZWNzIG5pbCkKICAgICAg ICAgICAgZmlsZXMpCi0gICAgICAgOzsgSW5jbHVkZSB1bnJlZ2lzdGVyZWQuCi0gICAgICAgKHNl dHEgYXJncyAoYXBwZW5kIGFyZ3MgJygiLWMiICItbyIgIi0tZXhjbHVkZS1zdGFuZGFyZCIpKSkK KyAgICAgICAoc2V0cSBhcmdzIChhcHBlbmQgYXJncworICAgICAgICAgICAgICAgICAgICAgICAg ICAnKCItYyIgIi0tZXhjbHVkZS1zdGFuZGFyZCIpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICh3aGVuIHByb2plY3QtdmMtaW5jbHVkZS11bnRyYWNrZWQgJygiLW8iKSkpKQogICAgICAgICh3 aGVuIGV4dHJhLWlnbm9yZXMKICAgICAgICAgIChzZXRxIGFyZ3MgKGFwcGVuZCBhcmdzCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKGNvbnMgIi0tIgpAQCAtNTY1LDkgKzU3MSw5IEBAIHBy b2plY3QtLXZjLWxpc3QtZmlsZXMKICAgICAgICAoZGVsZXRlLWNvbnNlY3V0aXZlLWR1cHMgZmls ZXMpKSkKICAgICAoYEhnCiAgICAgIChsZXQgKChkZWZhdWx0LWRpcmVjdG9yeSAoZXhwYW5kLWZp bGUtbmFtZSAoZmlsZS1uYW1lLWFzLWRpcmVjdG9yeSBkaXIpKSkKLSAgICAgICAgICAgYXJncykK LSAgICAgICA7OyBJbmNsdWRlIHVucmVnaXN0ZXJlZC4KLSAgICAgICAoc2V0cSBhcmdzIChuY29u YyBhcmdzICcoIi1tY2FyZHUiICItLW5vLXN0YXR1cyIgIi0wIikpKQorICAgICAgICAgICAoYXJn cyAobGlzdCAoY29uY2F0ICItbWNhcmQiICh3aGVuIHByb2plY3QtdmMtaW5jbHVkZS11bnRyYWNr ZWQgInUiKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIi0tbm8tc3RhdHVzIgorICAgICAgICAg ICAgICAgICAgICAgICAiLTAiKSkpCiAgICAgICAgKHdoZW4gZXh0cmEtaWdub3JlcwogICAgICAg ICAgKHNldHEgYXJncyAobmNvbmMgYXJncwogICAgICAgICAgICAgICAgICAgICAgICAgICAgKG1h cGNhbgotLSAKMi4zNi4xCgo= --=_c4b091c9e73cc44cc80cb6f924cd70b8-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 31 18:49:21 2022 Received: (at 55632) by debbugs.gnu.org; 31 May 2022 22:49:21 +0000 Received: from localhost ([127.0.0.1]:49105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwAfx-00057c-DR for submit@debbugs.gnu.org; Tue, 31 May 2022 18:49:21 -0400 Received: from mail-ed1-f44.google.com ([209.85.208.44]:42518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwAft-00057L-Io for 55632@debbugs.gnu.org; Tue, 31 May 2022 18:49:19 -0400 Received: by mail-ed1-f44.google.com with SMTP id n28so10619319edb.9 for <55632@debbugs.gnu.org>; Tue, 31 May 2022 15:49:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=jSGpYHGZpfGFcZknDzMJ/6kwDvOjiSzkhwD9c2VxA3A=; b=XxN3Wgh7vGGsETXLjRbwVJfDJkxXNSnARvTfIyh3wQT30x3Y2BSkzw8po2Xzjey591 ATXJXR/+x/SzncCqG+so6RqcLUnJtwbUtVLDuxluOn7L9Mpw9AxsFoIfkj0J00JejITw GusyG8+Bl0WVkysirRZMpGxAmbnRaP9QeLtWumH+xxyjBJWAkUG2slbnvAlOUEhr54TQ 37bj4QB99Nzw3hT73UlcoTQUznhAzFJZY0o3s5Kbt2LejIw/EQJMmTZzJf1hNoABZFmr X/TIJVzWYKgKfuyRSlVR7YDVa7/T8RNeaFZ0viuCe5THIf5eefptND+p4Be0BZhMBsCl Z18g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=jSGpYHGZpfGFcZknDzMJ/6kwDvOjiSzkhwD9c2VxA3A=; b=DCi0ZLB7dzFET0gsfwIPf+zsvdKX/QgLsImwYSBj4faybCl5poj9eFqbx1Z7Cdaav0 OeTF0TXWZ1Usl2t4r6MPM4+BJGRD9E7Xy/f1O8V65ae0hw+3LwCHD01KSvp5SFLCq4wh zMAxiJMV5CyG/83hcSb1An4P2IkWIapsoCwqtKe9RHWg6MQoQGhDQ943a4LSefUKpXES X+FZgAV9Ca5/EO4DFf7nYbXtsx5tax1iduuPXuO6aEYWUCWYS+crZpY9sFomVAiVTpFG vmzzb5c7vsR+U2ifsiX1d82/UaiIDOVkfaOFm/mYN/w8NekBknAfK2fcqoHlrWK5M0fv 2+6w== X-Gm-Message-State: AOAM533FPhObjbiDxFtIr17ffdJBUFTMRG8jJ0BF+dYonhnS/KuMC0DB AO8Al5hFbpimvwAvsFonK8U= X-Google-Smtp-Source: ABdhPJwSjcC0sGVFln+AT1rpDjPPEzD/FcxlywGlTy5YAfcQmEITKPP5flaDYhmZEK4uDDFqfGr3SQ== X-Received: by 2002:a05:6402:1c91:b0:42d:c9b6:506b with SMTP id cy17-20020a0564021c9100b0042dc9b6506bmr17230479edb.166.1654037351619; Tue, 31 May 2022 15:49:11 -0700 (PDT) Received: from [192.168.236.48] ([173.237.64.48]) by smtp.googlemail.com with ESMTPSA id u18-20020a170906069200b006f3ef214e13sm20978ejb.121.2022.05.31.15.49.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 15:49:10 -0700 (PDT) Message-ID: <437b78f7-f4a9-670d-9b74-69ae8a565767@yandex.ru> Date: Wed, 1 Jun 2022 01:49:08 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only Content-Language: en-US To: jan.synacek@posteo.org References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> <43b5eada954e592cc0c747368a3dbdb7@posteo.de> From: Dmitry Gutov In-Reply-To: <43b5eada954e592cc0c747368a3dbdb7@posteo.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55632 Cc: 55632@debbugs.gnu.org, DG X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 30.05.2022 14:00, jan.synacek@posteo.org wrote: > Thank you for the review. I addressed your comments in the new version > of the patch. Thanks. One last thing here. The manual addition says: +Also, some VC back-ends consider ``untracked'' files by default. +That behavior is controllable with the variable +@code{project-vc-include-untracked}. Should that say "some Project back-ends ..."? Or better yet, "the VC Project back-end". Because that's the only one in the core that has any notion of "untracked files". And that behavior is so for all VC backends, with Git and Hg simply having custom file listing code (for better performance). The rest delegate to 'find', only picking up the list of ignores (like bzrignore, svnignore, etc). Consequently, the new variable will only affect the VC Project backend's behavior only with Hg and Git. From debbugs-submit-bounces@debbugs.gnu.org Tue May 31 18:57:55 2022 Received: (at 55632) by debbugs.gnu.org; 31 May 2022 22:57:55 +0000 Received: from localhost ([127.0.0.1]:49109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwAoF-0005Kg-9R for submit@debbugs.gnu.org; Tue, 31 May 2022 18:57:55 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:35476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwAoA-0005KH-KG for 55632@debbugs.gnu.org; Tue, 31 May 2022 18:57:54 -0400 Received: by mail-ed1-f41.google.com with SMTP id t5so19470247edc.2 for <55632@debbugs.gnu.org>; Tue, 31 May 2022 15:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vdtnPN/j4kPDWrwCYA1eyoiwDQjQxi26c50sJZR78Xc=; b=oeoyAgfPJFkYuZCyA3NtagldmeOk0SJYdZJGLm7SeMF0P2mltVLxZl8411XYL1ITVb RlbCOq5ymOjgFpvEC4wD6pLVOLUeuXfS0Xpe8szmH1LZV5XIkh+tNkuowhXTSLCDvZ8/ lscKrElaXUoQ+Q1pUTZjz2Fe0XqCR/9viNGuhK3orSwkxoACKfeg0D4p4x1jC4/H892G EQiAI7fLo4aeqZRoqCPQ8eNjT5AmWotcIQE1Xq0qgH17qc2xcuCgpGbdsEr+siht5NI0 NQleJ57oS6ikS1Qem0sgszTlvqwLplJPcL98FXzL+EcmEIq5+PYQZRJ5+vI/kHAB7ksL l6qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vdtnPN/j4kPDWrwCYA1eyoiwDQjQxi26c50sJZR78Xc=; b=4IINmImNzEWH8LN5K4PB6/crhEq560kbgRD+OAmj+Kb6ltEj3f2vhn8gEtDBFkR3Qt R/weL5Ae/HVEeES792CIKBTErvbcqvF0Qs3wtiel4b2swMfwwZNwm0I5gauLLbYt0slM U8wD+yf7YLNOObhT4Lx6FnGEaoKXJRnYxU4qUUSEjMI/LejthXP9u9lNOTWW+dXvCfgz QPqD/xAJwnxU8az9JzkqalWJdRLr68Sz6lZNBVeQoUqNuj2vvtBHyPeNtesNwCbtSznL UPfkbeyk2Mqy4/aiIQUDD7HamkFu5fr+8wBi0/hR3G4da1Wxq3A17AlGrnZiZXWCQIm2 lCrg== X-Gm-Message-State: AOAM533GRXDQc1UWIIr4kkjnKWoaJEJGXnddrvHjAwm1OPH0u1H59Cn/ vZVLqzwd2fmS7G/78YaWyqE= X-Google-Smtp-Source: ABdhPJw4DTbdTmEmK75Lc57FHhAFvodxzeodHvokrJNOMeVjk5AgFYdfNbBhqDbz0XCd0NVELjrI7A== X-Received: by 2002:a05:6402:28a2:b0:42d:e116:de8f with SMTP id eg34-20020a05640228a200b0042de116de8fmr6771629edb.305.1654037864443; Tue, 31 May 2022 15:57:44 -0700 (PDT) Received: from [192.168.236.48] ([173.237.64.48]) by smtp.googlemail.com with ESMTPSA id a11-20020a056402236b00b0042dd4ccccf5sm3897491eda.82.2022.05.31.15.57.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 15:57:43 -0700 (PDT) Message-ID: Date: Wed, 1 Jun 2022 01:57:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only Content-Language: en-US To: jan.synacek@posteo.org References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55632 Cc: 55632@debbugs.gnu.org, DG X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 30.05.2022 13:08, jan.synacek@posteo.org wrote: > On 27.05.2022 15:55, Dmitry Gutov wrote: >> On 25.05.2022 12:08, Jan Synáček wrote: >>> Currently, `project-find-file' always includes untracked files, which is >>> not always the desired behavior. This patch adds a new user option to >>> make only find the actual project files. By default, the variable is set >>> to nil, which means the behavior is not changed. >> >> Sure, thanks. I'll review this soon-ish. >> >> As long as you are aware of the user option project-vc-ignores (which >> can be set directory-locally), and are certain that it doesn't satisfy >> your needs. > > Short answer: > Yes, I'm aware, but that option is something different. I don't want to > add anything to ignore. That's cool. > Long answer: > This mostly applies to the git and mercurial Emacs backends where the > untracked files are > used by default now. I think that presenting a "project" as pretty much > everything in a > folder (unless selectively ignored by using project-vc-ignores, for > example) ^^^or included in .gitignore or .hgignore > only makes > sense if there is no underlying VCS, otherwise it's pretty much > backwards. Because if > there's already a repo that tracks files, the project should be, in my > opinion, just the > files in that repo that the underlying VCS sees as tracked. That is the > default behavior > in git and mercurial as far as I know (I don't use mercurial much, but > use git a lot). The > VCS also has a mechanism for including untracked files in case the user > wants to see them > in some operations, and ignoring additional files so that they don't > count towards those > untracked files. These two options should map 1 to 1 to Emacs custom > variables, in my > opinion. > So, in summary, I would suggest to change the VC backends that support > this to behave by > default as the underlying VCS would behave and use custom variables to > add additional > tweaks for non-default stuff. Of course, that is out of scope for this > patch. Here's the reasoning I used: - Almost everyone works with a VCS. Let's use Git in this example. - You start working on a new feature to your project. You add a couple of new source files, write tests for them. Haven't checked them in yet. - To switch between the project files you probably use 'project-find-file'. You are likely to use that function (or 'project-find-regexp'), etc, during the initial phase of developing a new feature as well, and to jump between the newly created files, and their tests, etc. - That creates expectation that new files should be considered part of the project. And overall, false positive is usually better for this kind of thing than false negative (not finding something that you expect to be there). Using .xyzignore files to list files that are junk/unimportant/etc is par for the course when using a VCS. Until a file is added there (or checked in), it's very visible in 'git status'. Having them omitted from the list of project files would make them much less "visible", contradicting Git's (or Mercurial or etc) behavior. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 01 11:21:22 2022 Received: (at 55632) by debbugs.gnu.org; 1 Jun 2022 15:21:22 +0000 Received: from localhost ([127.0.0.1]:51584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwQ9y-0000pd-7d for submit@debbugs.gnu.org; Wed, 01 Jun 2022 11:21:22 -0400 Received: from mout02.posteo.de ([185.67.36.66]:42571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwQ9w-0000pN-Ao for 55632@debbugs.gnu.org; Wed, 01 Jun 2022 11:21:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 33C8D240109 for <55632@debbugs.gnu.org>; Wed, 1 Jun 2022 17:21:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.org; s=2017; t=1654096874; bh=iogyGNtwZO9ojH88nnBZ/X9crSGXZoKQOBCGpCd3Z/c=; h=Date:From:To:Cc:Subject:From; b=FkDYY2ae4bCkmUy+dsga30nW8wGVuh3k46LMlLV8MbeCbYw+nqyDLsWuoPHYq+s1Z t6Ini60K6Yed522ra3phSUuALgBlJ1d5PAO0o+u5xwI9/kqaEms/MdMBhrXjjTMGOf 5XTSuFRzQdtdsajKNOkClF2C5PUx7UngrVfPNTymZbjhuTICZBxNAqLsxsvHsZq9Mg HAwguAlaryCWwsEmUV1QWRWJe0ak+A7HE/vyXhctS/nJPQWu0b449zAEaf6x1Z2eUu K+dek/OZUpEVTPdfk2O2T6zkf/+TrbSDswN+8K0fOAhPp9wftCbOJ5Hzdp25mJob+c J+jvwT9x+MrhQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4LCtCF0SSFz6tm6; Wed, 1 Jun 2022 17:21:12 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 01 Jun 2022 15:21:12 +0000 From: jan.synacek@posteo.org To: Dmitry Gutov Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only In-Reply-To: References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> Message-ID: <0ee006ddcfc864ad34d111f17b95f8d0@posteo.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55632 Cc: 55632@debbugs.gnu.org, DG X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 01.06.2022 00:57, Dmitry Gutov wrote: > Here's the reasoning I used: > > - Almost everyone works with a VCS. Let's use Git in this example. > - You start working on a new feature to your project. You add a couple > of new source files, write tests for them. Haven't checked them in > yet. > - To switch between the project files you probably use > 'project-find-file'. You are likely to use that function (or > 'project-find-regexp'), etc, during the initial phase of developing a > new feature as well, and to jump between the newly created files, and > their tests, etc. > - That creates expectation that new files should be considered part of > the project. And overall, false positive is usually better for this > kind of thing than false negative (not finding something that you > expect to be there). > > Using .xyzignore files to list files that are junk/unimportant/etc is > par for the course when using a VCS. Until a file is added there (or > checked in), it's very visible in 'git status'. Having them omitted > from the list of project files would make them much less "visible", > contradicting Git's (or Mercurial or etc) behavior. Ok, fair enough. I guess this makes sense as well. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 02 15:02:06 2022 Received: (at 55632) by debbugs.gnu.org; 2 Jun 2022 19:02:06 +0000 Received: from localhost ([127.0.0.1]:54622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwq57-0002C0-V1 for submit@debbugs.gnu.org; Thu, 02 Jun 2022 15:02:06 -0400 Received: from mout01.posteo.de ([185.67.36.65]:50171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwq52-0002BQ-Ci for 55632@debbugs.gnu.org; Thu, 02 Jun 2022 15:02:04 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 644F7240026 for <55632@debbugs.gnu.org>; Thu, 2 Jun 2022 21:01:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.org; s=2017; t=1654196514; bh=9gKHryshabkjti5JiE9VTOuP2BEhK/Ze//UDuT40Th0=; h=Date:From:To:Cc:Subject:From; b=gWHX/2wAK4LPTfbqpYQyw5A+myVt0CUFfFOncmgyf4bzX2JDlNvexN4QzvnflRsYZ Dmeg4cwiZL6Df+nHgVsFEr/iYeBaeVmtNFhL4i7QLu9teqV+StbXcVWenjoXmwuTlG jTU6cLzOLFsGrkFKD2HOaSloizCaGoN/foheniW4z+LnbsL43Ot2IGhGt18Z0YG6os 3Jfg5ZBYdEKJjC3J1JyDsnHqE5uqSxBnFb7qJTEo6lbatSiz9qNS0CoMpOFKsTwwDh dGOgsxY+x4nr8Y2J4BsTiYv4K+RP8xP8y0GXW5YvCYGHf7t0ayTkjNbqzmgvjmYU11 Q4ptTRBBi6SWA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4LDb3P1pTRz9rxF; Thu, 2 Jun 2022 21:01:53 +0200 (CEST) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_8d4e42d97f6b2b415e1cdbdafddc471e" Date: Thu, 02 Jun 2022 19:01:53 +0000 From: jan.synacek@posteo.org To: Dmitry Gutov Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only In-Reply-To: <437b78f7-f4a9-670d-9b74-69ae8a565767@yandex.ru> References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> <43b5eada954e592cc0c747368a3dbdb7@posteo.de> <437b78f7-f4a9-670d-9b74-69ae8a565767@yandex.ru> Message-ID: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55632 Cc: 55632@debbugs.gnu.org, DG X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=_8d4e42d97f6b2b415e1cdbdafddc471e Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed >> Thank you for the review. I addressed your comments in the new version >> of the patch. > > Thanks. > > One last thing here. The manual addition says: > > +Also, some VC back-ends consider ``untracked'' files by default. > +That behavior is controllable with the variable > +@code{project-vc-include-untracked}. > > Should that say "some Project back-ends ..."? Or better yet, "the VC > Project back-end". Because that's the only one in the core that has > any notion of "untracked files". > > And that behavior is so for all VC backends, with Git and Hg simply > having custom file listing code (for better performance). The rest > delegate to 'find', only picking up the list of ignores (like > bzrignore, svnignore, etc). > > Consequently, the new variable will only affect the VC Project > backend's behavior only with Hg and Git. Fixed. --=_8d4e42d97f6b2b415e1cdbdafddc471e Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name=0001-Add-new-user-option-project-vc-include-untracked.patch Content-Disposition: attachment; filename=0001-Add-new-user-option-project-vc-include-untracked.patch; size=3443 RnJvbSBmZjdlYjY1MjkwMTllOThlYWUzMjBjOTA3YzFlOTY4M2EyMWQ2MjdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/SmFuPTIwU3luPUMzPUExPUM0PThEZWs/PSA8 amFuLnN5bmFjZWtAZ21haWwuY29tPgpEYXRlOiBUaHUsIDIgSnVuIDIwMjIgMjA6NTk6NTMgKzAy MDAKU3ViamVjdDogW1BBVENIXSBBZGQgbmV3IHVzZXIgb3B0aW9uIHByb2plY3QtdmMtaW5jbHVk ZS11bnRyYWNrZWQKCiogZG9jL2VtYWNzL21haW50YWluaW5nLnRleGkgKFByb2plY3RzKTogRG9j dW1lbnQgaXQuCiogbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbCAocHJvamVjdC0tdmMtbGlzdC1m aWxlcyk6IFVzZSBpdC4KLS0tCiBkb2MvZW1hY3MvbWFpbnRhaW5pbmcudGV4aSB8ICAzICsrKwog ZXRjL05FV1MgICAgICAgICAgICAgICAgICAgfCAgNCArKysrCiBsaXNwL3Byb2dtb2Rlcy9wcm9q ZWN0LmVsICB8IDE2ICsrKysrKysrKysrLS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0 aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2MvZW1hY3MvbWFpbnRhaW5p bmcudGV4aSBiL2RvYy9lbWFjcy9tYWludGFpbmluZy50ZXhpCmluZGV4IDNkZGVhMGFlNTguLmVk YzVhY2JkNjUgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9tYWludGFpbmluZy50ZXhpCisrKyBiL2Rv Yy9lbWFjcy9tYWludGFpbmluZy50ZXhpCkBAIC0xNjY2LDYgKzE2NjYsOSBAQCBQcm9qZWN0cwog ICBXaGljaCBmaWxlcyBkbyBvciBkb24ndCBiZWxvbmcgdG8gYSBwcm9qZWN0IGlzIGFsc28gZGV0 ZXJtaW5lZCBieQogdGhlIHByb2plY3QgYmFjay1lbmQuICBGb3IgZXhhbXBsZSwgdGhlIFZDIGJh Y2stZW5kIGRvZXNuJ3QgY29uc2lkZXIKIGBgaWdub3JlZCcnIGZpbGVzIChAcHhyZWZ7VkMgSWdu b3JlfSkgdG8gYmUgcGFydCBvZiB0aGUgcHJvamVjdC4KK0Fsc28sIHRoZSBWQyBQcm9qZWN0IGJh Y2stZW5kIGNvbnNpZGVycyBgYHVudHJhY2tlZCcnIGZpbGVzIGJ5IGRlZmF1bHQuCitUaGF0IGJl aGF2aW9yIGlzIGNvbnRyb2xsYWJsZSB3aXRoIHRoZSB2YXJpYWJsZQorQGNvZGV7cHJvamVjdC12 Yy1pbmNsdWRlLXVudHJhY2tlZH0uCiAKIEBtZW51CiAqIFByb2plY3QgRmlsZSBDb21tYW5kczo6 ICAgQ29tbWFuZHMgZm9yIGhhbmRsaW5nIHByb2plY3QgZmlsZXMuCmRpZmYgLS1naXQgYS9ldGMv TkVXUyBiL2V0Yy9ORVdTCmluZGV4IDcxYzE5YzA2YjQuLjM4NjdmYzg4MjkgMTAwNjQ0Ci0tLSBh L2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0xNzA3LDYgKzE3MDcsMTAgQEAgRW5hYmxpbmcg dGhpcyBtaW5vciBtb2RlIHR1cm5zIG9uIGhpZGluZyBoZWFkZXIgbWF0ZXJpYWwsIGxpa2UKICdl bGlkZS1oZWFkJyBkb2VzOyBkaXNhYmxpbmcgaXQgc2hvd3MgdGhlIGhlYWRlci4gIFRoZSBjb21t YW5kcwogJ2VsaWRlLWhlYWQnIGFuZCAnZWxpZGUtaGVhZC1zaG93JyBhcmUgbm93IG9ic29sZXRl LgogCisrKysKKyoqKiBOZXcgdXNlciBvcHRpb24gJ3Byb2plY3QtdmMtaW5jbHVkZS11bnRyYWNr ZWQnLgorV2hlbiBub24tbmlsLCB0aGUgVkMgcHJvamVjdCBiYWNrZW5kIGluY2x1ZGVzIHRoZSB1 bnRyYWNrZWQgZmlsZXMuCisKIC0tLQogKiogVGhlIGF1dG9hcmcuZWwgbGlicmFyeSBpcyBub3cg bWFya2VkIG9ic29sZXRlLgogVGhpcyBsaWJyYXJ5IHByb3ZpZGVzIHRoZSAnYXV0b2FyZy1tb2Rl JyBhbmQgJ2F1dG9hcmcta3AtbW9kZScgbWlub3IKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVz L3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9wcm9qZWN0LmVsCmluZGV4IDRkYzQ3NjIxNzYu LjQ5ZTA3ZmU4NDAgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIv bGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAtMzgyLDYgKzM4MiwxMSBAQCBwcm9qZWN0LXZj LW1lcmdlLXN1Ym1vZHVsZXMKICAgOnBhY2thZ2UtdmVyc2lvbiAnKHByb2plY3QgLiAiMC4yLjAi KQogICA6c2FmZSAjJ2Jvb2xlYW5wKQogCisoZGVmY3VzdG9tIHByb2plY3QtdmMtaW5jbHVkZS11 bnRyYWNrZWQgdAorICAiV2hlbiBub24tbmlsLCB0aGUgVkMgcHJvamVjdCBiYWNrZW5kIGluY2x1 ZGVzIHRoZSB1bnRyYWNrZWQgZmlsZXMuIgorICA6dHlwZSAnYm9vbGVhbgorICA6c2FmZSAjJ2Jv b2xlYW5wKQorCiA7OyBGSVhNRTogVXNpbmcgdGhlIGN1cnJlbnQgYXBwcm9hY2gsIG1ham9yIG1v ZGVzIGFyZSBzdXBwb3NlZCB0byBzZXQKIDs7IHRoaXMgdmFyaWFibGUgdG8gYSBidWZmZXItbG9j YWwgdmFsdWUuICBTbyB3ZSBkb24ndCBoYXZlIGFjY2VzcyB0bwogOzsgdGhlICJleHRlcm5hbCBy b290cyIgb2YgbGFuZ3VhZ2UgQSBmcm9tIGJ1ZmZlcnMgb2YgbGFuZ3VhZ2UgQiwgd2hpY2gKQEAg LTUxMiw4ICs1MTcsOSBAQCBwcm9qZWN0LS12Yy1saXN0LWZpbGVzCiAgICAgICAgICAgIChhcmdz ICcoIi16IikpCiAgICAgICAgICAgICh2Yy1naXQtdXNlLWxpdGVyYWwtcGF0aHNwZWNzIG5pbCkK ICAgICAgICAgICAgZmlsZXMpCi0gICAgICAgOzsgSW5jbHVkZSB1bnJlZ2lzdGVyZWQuCi0gICAg ICAgKHNldHEgYXJncyAoYXBwZW5kIGFyZ3MgJygiLWMiICItbyIgIi0tZXhjbHVkZS1zdGFuZGFy ZCIpKSkKKyAgICAgICAoc2V0cSBhcmdzIChhcHBlbmQgYXJncworICAgICAgICAgICAgICAgICAg ICAgICAgICAnKCItYyIgIi0tZXhjbHVkZS1zdGFuZGFyZCIpCisgICAgICAgICAgICAgICAgICAg ICAgICAgICh3aGVuIHByb2plY3QtdmMtaW5jbHVkZS11bnRyYWNrZWQgJygiLW8iKSkpKQogICAg ICAgICh3aGVuIGV4dHJhLWlnbm9yZXMKICAgICAgICAgIChzZXRxIGFyZ3MgKGFwcGVuZCBhcmdz CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNvbnMgIi0tIgpAQCAtNTY1LDkgKzU3MSw5 IEBAIHByb2plY3QtLXZjLWxpc3QtZmlsZXMKICAgICAgICAoZGVsZXRlLWNvbnNlY3V0aXZlLWR1 cHMgZmlsZXMpKSkKICAgICAoYEhnCiAgICAgIChsZXQgKChkZWZhdWx0LWRpcmVjdG9yeSAoZXhw YW5kLWZpbGUtbmFtZSAoZmlsZS1uYW1lLWFzLWRpcmVjdG9yeSBkaXIpKSkKLSAgICAgICAgICAg YXJncykKLSAgICAgICA7OyBJbmNsdWRlIHVucmVnaXN0ZXJlZC4KLSAgICAgICAoc2V0cSBhcmdz IChuY29uYyBhcmdzICcoIi1tY2FyZHUiICItLW5vLXN0YXR1cyIgIi0wIikpKQorICAgICAgICAg ICAoYXJncyAobGlzdCAoY29uY2F0ICItbWNhcmQiICh3aGVuIHByb2plY3QtdmMtaW5jbHVkZS11 bnRyYWNrZWQgInUiKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIi0tbm8tc3RhdHVzIgorICAg ICAgICAgICAgICAgICAgICAgICAiLTAiKSkpCiAgICAgICAgKHdoZW4gZXh0cmEtaWdub3Jlcwog ICAgICAgICAgKHNldHEgYXJncyAobmNvbmMgYXJncwogICAgICAgICAgICAgICAgICAgICAgICAg ICAgKG1hcGNhbgotLSAKMi4zNi4xCgo= --=_8d4e42d97f6b2b415e1cdbdafddc471e-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 02 15:19:25 2022 Received: (at 55632) by debbugs.gnu.org; 2 Jun 2022 19:19:25 +0000 Received: from localhost ([127.0.0.1]:54642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwqLs-0002cp-MP for submit@debbugs.gnu.org; Thu, 02 Jun 2022 15:19:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwqLp-0002cL-Ne for 55632@debbugs.gnu.org; Thu, 02 Jun 2022 15:19:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38280) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwqLj-0005A3-3x; Thu, 02 Jun 2022 15:19:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kI5Raw4+5k1J91RLwIje8MAsQseR5VV1oKpQTV6qWOA=; b=bPZvVBF6E2qT KUrjXEXpCbgBWaW+2im9oeq4cW4FthMIQ0bQyTs9kWBe9wev5bsTUcocwCvZeNBafoGeP2xNtd6cv nnzvWzshCd4EEN6oqbo/SMca1xFXpTY+jfBJCl+etg9z2I2kw27DTjhpQ5J7wc/S+DYXKQj7jDVPy QoWbZLp2uT3wjyFy/C/+sXeu/hUDejduYIqVwak2TdNvQfcN/+tTydKpdutDzlv2OtvGivb5gvcKL yTvU+AgYp0fXaXjlhqgqHHs/M3a4q967xi5GZ0cyFvXIY1K+TY1z7WUTog+N9icIRJEatczdft5Xe 20lh4yjtoSYYo+Kn0ZPF6w==; Received: from [87.69.77.57] (port=2889 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwqLi-0007Ob-KC; Thu, 02 Jun 2022 15:19:14 -0400 Date: Thu, 02 Jun 2022 22:19:24 +0300 Message-Id: <83ee06euv7.fsf@gnu.org> From: Eli Zaretskii To: jan.synacek@posteo.org In-Reply-To: (jan.synacek@posteo.org) Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> <43b5eada954e592cc0c747368a3dbdb7@posteo.de> <437b78f7-f4a9-670d-9b74-69ae8a565767@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55632 Cc: 55632@debbugs.gnu.org, raaahh@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 55632@debbugs.gnu.org, DG > Date: Thu, 02 Jun 2022 19:01:53 +0000 > From: jan.synacek@posteo.org > > ++++ > +*** New user option 'project-vc-include-untracked'. > +When non-nil, the VC project backend includes the untracked files. Can we please tell more about what does "include untracked files" mean? Include where and in what sense? Bonus points for explaining this without ever alluding to "backend", as that is not necessarily a user-level concept in this case. Also, is it "VC project backend" or "Project's VC backend"? > +(defcustom project-vc-include-untracked t > + "When non-nil, the VC project backend includes the untracked files." > + :type 'boolean > + :safe #'booleanp) Same here. And new defcustom's should have a :version tag. > - ;; Include unregistered. > - (setq args (append args '("-c" "-o" "--exclude-standard"))) > + (setq args (append args > + '("-c" "--exclude-standard") > + (when project-vc-include-untracked '("-o")))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I think 'when' is overkill here, because 'if' will do the job. > - ;; Include unregistered. > - (setq args (nconc args '("-mcardu" "--no-status" "-0"))) > + (args (list (concat "-mcard" (when project-vc-include-untracked "u")) > + "--no-status" > + "-0"))) Likewise here. Thank you for working on this. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 02 19:45:33 2022 Received: (at 55632) by debbugs.gnu.org; 2 Jun 2022 23:45:33 +0000 Received: from localhost ([127.0.0.1]:54782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwuVR-0003EQ-FB for submit@debbugs.gnu.org; Thu, 02 Jun 2022 19:45:33 -0400 Received: from mail-ed1-f52.google.com ([209.85.208.52]:41918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwuVM-0003E9-7L for 55632@debbugs.gnu.org; Thu, 02 Jun 2022 19:45:32 -0400 Received: by mail-ed1-f52.google.com with SMTP id 25so7899067edw.8 for <55632@debbugs.gnu.org>; Thu, 02 Jun 2022 16:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rbtBBVr7d523n6BiHXzPCCiTjYJZfHvuPRtsu/HPsVg=; b=ZptHWugHPBvI2og12XCMmBLnf1R+AoIohNwNetoV1hYhYYfMXE7e5eFeAXscjXZfet W6hpkC+f8/mkiINY4pgmO5dN1HQ7aM7jbDLiyo7YY/Pby4FXCWZyg/1NR4PlQtien1Vg zIqI6KGA46PmYhFJDdOltQqfvYZkZhG0Dd3Ccv5im9yWWpLKjILimvWJdeazo7Y5MG1A krAzC4p+Fsk1ZjCbSpdEQvNhgyEmkAdGWU97kvvi91HceoEIqoaDGnu9asX1D7j4vVTk U2LAbYVmdD6Jg7CLwtkfZVclAbcBrerczsv49ca2wnQmcZ0QHtMhsTBDWoVTYiaBMol5 IQkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rbtBBVr7d523n6BiHXzPCCiTjYJZfHvuPRtsu/HPsVg=; b=Enzo2+27eXEd4phIM80+o830wU6Dy2jXjNNvSOZ1i5jRF5g9jSsXPfyPidXuCJYrBV zQ9gunWz50Gqz1uFbRlIpf58+07a7XjtYIpi3wbu675YntQDb4hX5+Dfe6girZoHNVtE 4LKba9AgDRC8Tur1+f3N6IbjtRjVHVYzfFkkICPyJF2QUwoGbmzi1DxMrMFNYUZI+L5S 6GQP9e2jAJSLn89qEYazPZWa2KF6WQer0ZDV8Vjz3N48Vkv6wwJdbaEt7JxeMVQm/XA7 FMYr6WhCok2TNseHvIFn6B3ra+pjmE+lzqgeDlPRcpnYkefyQvkAjINETgJZR7/CO1Me 5fgA== X-Gm-Message-State: AOAM530YNgqM32ZrdwIX/FWx8KQbSa4tvwPScDxDJJZo3ml32ph0Rj1c r8zhvkPvwLkmseWQNWQqsp0= X-Google-Smtp-Source: ABdhPJwbzYgRRzW9uxXRT4XE2h8gvNFqnAELC4fXzBGE3DcfagCfRJrpG3EKT/EpRUN+qh+hmS28sg== X-Received: by 2002:a05:6402:d05:b0:425:b5c8:faeb with SMTP id eb5-20020a0564020d0500b00425b5c8faebmr7978162edb.273.1654213522000; Thu, 02 Jun 2022 16:45:22 -0700 (PDT) Received: from [192.168.236.48] ([173.237.64.48]) by smtp.googlemail.com with ESMTPSA id si8-20020a170906cec800b00706ed5afdc0sm2224292ejb.120.2022.06.02.16.45.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 16:45:21 -0700 (PDT) Message-ID: <859e155c-c71c-87f0-0363-f5682fe3d697@yandex.ru> Date: Fri, 3 Jun 2022 02:45:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only Content-Language: en-US To: Eli Zaretskii , jan.synacek@posteo.org References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> <43b5eada954e592cc0c747368a3dbdb7@posteo.de> <437b78f7-f4a9-670d-9b74-69ae8a565767@yandex.ru> <83ee06euv7.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83ee06euv7.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55632 Cc: 55632@debbugs.gnu.org, raaahh@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 02.06.2022 22:19, Eli Zaretskii wrote: > Can we please tell more about what does "include untracked files" > mean? Include where and in what sense? Has them considered to be part of the project. Which in practice means including them in a project's list of files. For the purposes for project-find-file, project-find-regexp, and all other commands that build on top of 'project-files'. How would you phrase that better? > Bonus points for explaining > this without ever alluding to "backend", as that is not necessarily a > user-level concept in this case. The variable only affects a particular backend. It's only meaningful when there is a VCS anyway. > Also, is it "VC project backend" or "Project's VC backend"? I would say both mean the same thing, but the latter seems to be more unambiguous. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 03 01:44:04 2022 Received: (at 55632) by debbugs.gnu.org; 3 Jun 2022 05:44:04 +0000 Received: from localhost ([127.0.0.1]:54999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nx06N-0000vm-Un for submit@debbugs.gnu.org; Fri, 03 Jun 2022 01:44:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nx06L-0000v5-Ph for 55632@debbugs.gnu.org; Fri, 03 Jun 2022 01:44:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nx06G-0001Ri-73; Fri, 03 Jun 2022 01:43:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=caNW3nTeczywmYCC8YaT/+VS3blpmYXQUvMADX/0dKU=; b=ltul8nNKZqus G6jiO/w5hfn2FTCYWT9mis66s4WHl59CtsvybzSqtB+EQ5CwqQbe2qYYPaRHjPWZ961sjLA4XLqT/ IhxRNPiMI7TkTxDJQzft60UCq9I7hWscYQdMKAKZo4b2qIvRjVfr1Rd6gmOksvwSMILmpNdcJKipe xsfJ6gctKRqnU1/vLzU3IU1lODQ//73Uq84NONNnt577gnfooHi6P5gbmfGF4KlmIgPFc+c4z475/ TbQCGJ/J0z2KSLIoX3tNgH7gNdV0P3nG+rTvZyipcAcLdK6vqoBWTSrU1YuKvRgnDV4BiuiQTc7Pb txVloVEmgaJ/Oo2f0PopMQ==; Received: from [87.69.77.57] (port=1349 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nx06F-0000nk-DO; Fri, 03 Jun 2022 01:43:55 -0400 Date: Fri, 03 Jun 2022 08:44:05 +0300 Message-Id: <83a6aue1y2.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <859e155c-c71c-87f0-0363-f5682fe3d697@yandex.ru> (message from Dmitry Gutov on Fri, 3 Jun 2022 02:45:19 +0300) Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> <43b5eada954e592cc0c747368a3dbdb7@posteo.de> <437b78f7-f4a9-670d-9b74-69ae8a565767@yandex.ru> <83ee06euv7.fsf@gnu.org> <859e155c-c71c-87f0-0363-f5682fe3d697@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55632 Cc: jan.synacek@posteo.org, 55632@debbugs.gnu.org, raaahh@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 3 Jun 2022 02:45:19 +0300 > Cc: 55632@debbugs.gnu.org, raaahh@gmail.com > From: Dmitry Gutov > > On 02.06.2022 22:19, Eli Zaretskii wrote: > > Can we please tell more about what does "include untracked files" > > mean? Include where and in what sense? > > Has them considered to be part of the project. Which in practice means > including them in a project's list of files. For the purposes for > project-find-file, project-find-regexp, and all other commands that > build on top of 'project-files'. > > How would you phrase that better? Something like this: If non-nil, files untracked by a VCS are considered to be part of the project by a VC project based on that VCS. > > Bonus points for explaining > > this without ever alluding to "backend", as that is not necessarily a > > user-level concept in this case. > > The variable only affects a particular backend. It's only meaningful > when there is a VCS anyway. I understand. My point was to avoid using the word "backend" in user-level documentation, as much as possible. > > Also, is it "VC project backend" or "Project's VC backend"? > > I would say both mean the same thing, but the latter seems to be more > unambiguous. Well, if you are okay with my alternative wording above, it solves this problem as well. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 03 20:37:32 2022 Received: (at 55632-done) by debbugs.gnu.org; 4 Jun 2022 00:37:32 +0000 Received: from localhost ([127.0.0.1]:57250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxHnI-00039z-6K for submit@debbugs.gnu.org; Fri, 03 Jun 2022 20:37:32 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:36385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxHnF-00039l-RO for 55632-done@debbugs.gnu.org; Fri, 03 Jun 2022 20:37:30 -0400 Received: by mail-wr1-f50.google.com with SMTP id u3so12289227wrg.3 for <55632-done@debbugs.gnu.org>; Fri, 03 Jun 2022 17:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fCxwz2+FD7e2pXAPiB2SrVRbGhXHUprcirLibr1I6gI=; b=ojaLpo5n3VfVSHmB1zwl45egKtJ5o6a7KczZBDcJdWWAfJmUrie181tEifqL2rR0re MwcyRySk2GHFTi6bImdTVxs737qNovohvqw2PfQI3Z/APW1MltEpq2OwOHJu2gT4OHZg 3LwbZ3VNlikNsQAp26RdWGE2FwPzpdixaKjmVShaWNzZBleuMFzR4uilJXHKvglncwMW QIEWCt0jtXpuGSzNDFvsTRFt9iZE2V+i0A4eQvumLBcu92o7FmmWrOuMBVDv13tCVGUH UHU7fU+TT3uQZh932uLjl5gw2Nxk4+MqrDaj6VmaiqTZkHlPoB0b9QTXlPKFaOBjlji9 v6qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fCxwz2+FD7e2pXAPiB2SrVRbGhXHUprcirLibr1I6gI=; b=TGc7T3g+CgQDkPzkkxfLtZ5mjeSGHZ0sVhs+T8U5aCivU6QpIAWE1ME/U1lY4b5n0T ljPl4SmMliaxu3nzXu+8Wrj9bzTI3g+wsuqLFkqkdFZpqBni5Caxno5UcezBuy0XufcI K1SKOAAd4rAdMT+SdptAjBWRBR8c9b1B8UOi/JaOyWfEqtGWdEwT/DwvxPMtF76tTqm9 ilJlj5LB1a+n7n4WkjqHFyeV49+NorEDhyYibM+TugUcM9/Y4W3fkJQeXXZYEsAxOyOv cy6cdttOqHXZ/snaDJMDYxeQrjYTEJpcIZ9+OwNMwxJga+oXYHWdqFSaBJZHhKMcFd+N d0Jw== X-Gm-Message-State: AOAM532DH4vs+d9DD2eJX5IX9oHXgnQzBCCZGE/bqVGPPSeicKKizqBk CTftna+P0LqmVg2MDrqQCF8= X-Google-Smtp-Source: ABdhPJyDB2y4NA206hfFPIRBkQacCNHKTdM2p+gaqxeLydfeWf/+8FaE7/MPeXSBnAKjNJNuOWTxTA== X-Received: by 2002:a05:6000:1c2:b0:213:3b79:bd7 with SMTP id t2-20020a05600001c200b002133b790bd7mr8710468wrx.634.1654303044009; Fri, 03 Jun 2022 17:37:24 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id t15-20020a05600c198f00b003942a244f40sm15045054wmq.25.2022.06.03.17.37.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jun 2022 17:37:23 -0700 (PDT) Message-ID: Date: Sat, 4 Jun 2022 03:37:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only Content-Language: en-US To: Eli Zaretskii References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> <43b5eada954e592cc0c747368a3dbdb7@posteo.de> <437b78f7-f4a9-670d-9b74-69ae8a565767@yandex.ru> <83ee06euv7.fsf@gnu.org> <859e155c-c71c-87f0-0363-f5682fe3d697@yandex.ru> <83a6aue1y2.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83a6aue1y2.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Version: 29.1 On 03.06.2022 08:44, Eli Zaretskii wrote: >> Date: Fri, 3 Jun 2022 02:45:19 +0300 >> Cc: 55632@debbugs.gnu.org, raaahh@gmail.com >> From: Dmitry Gutov >> >> On 02.06.2022 22:19, Eli Zaretskii wrote: [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.50 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.50 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 T_SCC_BODY_TEXT_LINE No description available. -0.0 NICE_REPLY_A Looks like a legit reply (A) 1.0 FREEMAIL_REPLY From and body contain different freemails X-Debbugs-Envelope-To: 55632-done Cc: jan.synacek@posteo.org, 55632-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Version: 29.1 On 03.06.2022 08:44, Eli Zaretskii wrote: >> Date: Fri, 3 Jun 2022 02:45:19 +0300 >> Cc: 55632@debbugs.gnu.org, raaahh@gmail.com >> From: Dmitry Gutov >> >> On 02.06.2022 22:19, Eli Zaretskii wrote: >>> Can we please tell more about what does "include untracked files" >>> mean? Include where and in what sense? >> >> Has them considered to be part of the project. Which in practice means >> including them in a project's list of files. For the purposes for >> project-find-file, project-find-regexp, and all other commands that >> build on top of 'project-files'. >> >> How would you phrase that better? > > Something like this: > > If non-nil, files untracked by a VCS are considered to be part of > the project by a VC project based on that VCS. A bit unwieldy IMHO, but I don't mind. As long as you only objected to the NEWS entry. The addition to the manual, which is also usually considered user-level text, only continues the style of the preceding sentence. And the docstring has to be precise either way. >>> Bonus points for explaining >>> this without ever alluding to "backend", as that is not necessarily a >>> user-level concept in this case. >> >> The variable only affects a particular backend. It's only meaningful >> when there is a VCS anyway. > > I understand. My point was to avoid using the word "backend" in > user-level documentation, as much as possible. > >>> Also, is it "VC project backend" or "Project's VC backend"? >> >> I would say both mean the same thing, but the latter seems to be more >> unambiguous. > > Well, if you are okay with my alternative wording above, it solves > this problem as well. Amended and pushed, thank you both. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 02:29:28 2022 Received: (at 55632) by debbugs.gnu.org; 4 Jun 2022 06:29:29 +0000 Received: from localhost ([127.0.0.1]:57478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxNHs-0003WM-MU for submit@debbugs.gnu.org; Sat, 04 Jun 2022 02:29:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxNHq-0003W6-PB for 55632@debbugs.gnu.org; Sat, 04 Jun 2022 02:29:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxNHl-0003HA-5O; Sat, 04 Jun 2022 02:29:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TLJDEjZ65W5h4ZgFNfgkf4sAFjJuahOsW4mV+RlwjXY=; b=ZgAsgZt6HW6j A+6veAVFCcfkesSSHTuCqVhQXFu/76NgGafj34sJae7R4Tm8PMsSmRN5WRMvf0GNE3XqL6tBvRuzM rNQujL6XOJQL/MXlLXD5khjNHvE4NFyj0gPkc3bnvh2ABTEIrwwPwj2kkbp0t/1Uo5teFf3eqdEZ/ ANiuhWFxL+xYnzWdjRiuDRqUYFgqfkH/xU8JpJCUC9hYHtQf2mWOlXzIbLKA7c2ztANpOy/eyVkdS //X4p9CqBNAaQCbQh2q96h50m5/ngu1prnemtOM302t6sP/YUQpmV7p/R+oOKcHd+B5fFOvaWh/lk HWaIZuqlLST/Pn+iNYw01Q==; Received: from [87.69.77.57] (port=1299 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxNHk-0008L0-CW; Sat, 04 Jun 2022 02:29:20 -0400 Date: Sat, 04 Jun 2022 09:29:34 +0300 Message-Id: <83leudaqlt.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: (message from Dmitry Gutov on Sat, 4 Jun 2022 03:37:21 +0300) Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> <43b5eada954e592cc0c747368a3dbdb7@posteo.de> <437b78f7-f4a9-670d-9b74-69ae8a565767@yandex.ru> <83ee06euv7.fsf@gnu.org> <859e155c-c71c-87f0-0363-f5682fe3d697@yandex.ru> <83a6aue1y2.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55632 Cc: jan.synacek@posteo.org, 55632@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 4 Jun 2022 03:37:21 +0300 > Cc: jan.synacek@posteo.org, 55632-done@debbugs.gnu.org > From: Dmitry Gutov > > > If non-nil, files untracked by a VCS are considered to be part of > > the project by a VC project based on that VCS. > > A bit unwieldy IMHO, but I don't mind. What is unwieldy there? > As long as you only objected to the NEWS entry. > > The addition to the manual, which is also usually considered user-level > text, only continues the style of the preceding sentence. The manual explains what a back-end is, including what is the VC back-end, so I didn't mind to using it there. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 05:40:41 2022 Received: (at 55632) by debbugs.gnu.org; 4 Jun 2022 09:40:41 +0000 Received: from localhost ([127.0.0.1]:57661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxQGv-0000N2-Iw for submit@debbugs.gnu.org; Sat, 04 Jun 2022 05:40:41 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:33390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxQGt-0000Mi-Qj for 55632@debbugs.gnu.org; Sat, 04 Jun 2022 05:40:40 -0400 Received: by mail-wr1-f44.google.com with SMTP id h5so13254011wrb.0 for <55632@debbugs.gnu.org>; Sat, 04 Jun 2022 02:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BGl9SZk6TQuPMC4KOHBfZWRE9wn1aEdCupF2JWazlWQ=; b=M0UO/KLsi0eETQbN2dWxZn4iG8mp19/V/qe/bH0xu3wMjfMacTxAFMyb2cYYV5EFCo dYzDO+9gv1epO0esifmc41Su94OaSRUt6P2wBWFFahH9+1msgkXrtFmd8xHI7uyUSldy ErZVTrlDo3QDDElix0u7jX0rayraXNUOc5VQqXPb3jKVaMVhIWNytpzGJFT3Zdbh0D2D OMKIBsymTfOx6JS7hdKXCHTXOZ1LWNsK2NcD8/n8wNAfm8y2RYh3fjQUdG9UOT6HboLe wmlH1OTcxPGXcDnOuCa/luElrgHmQ9ZC6KcdLllcbB8k8phtaMCbZt5Q4h99IW977CJc 8xUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BGl9SZk6TQuPMC4KOHBfZWRE9wn1aEdCupF2JWazlWQ=; b=GDLuxqEETe8FXEpjXa5I2uij5hkGBl05aDvjOSR/sJINZ6SAJjYWSqn/JgK0qT/dB8 x/O6SDtQDMR06SY51xwmSveQblhLwaLAKiYEsEKu1d/sxwpY+RnUYsvEeaW0v1KdDpP1 V+kvoEDPR5k4mLancJQQ8tDe+uwP52rNO7CzVBMUjtLx6mneVjuQAyn4+Ig3O0gB4afG suBcIFaHnvb8hjMXCn2Y/u9dsVMHkRYplLlklRybhZrqjB1M+NEZuWcuiry4OYXyMgHJ QztuF5LM9GR0M78rVcjHig/SVuOlVA7eOxIIL8ESnV7AqtZ38Ne9vHIk4OB71gurY78M 07zg== X-Gm-Message-State: AOAM530GM+7Okjj5dJaPFZUBe8dMk2XqwV5sufQJsWSjhvCa4MbgLGnQ OfE90RsnWF/3FmkR3ap5e/0= X-Google-Smtp-Source: ABdhPJzkMa2xHiZhKo5+k1sxoMxRRs+aZYenssije7vUrSJ+HPv7OozS5xe4SVQOiCe2IEYrb5kwfg== X-Received: by 2002:adf:db8b:0:b0:20f:fb4f:c3da with SMTP id u11-20020adfdb8b000000b0020ffb4fc3damr12259160wri.163.1654335633713; Sat, 04 Jun 2022 02:40:33 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f6-20020a1c3806000000b003942a244f57sm14537501wma.48.2022.06.04.02.40.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Jun 2022 02:40:33 -0700 (PDT) Message-ID: <8b4e7307-e2ce-d8aa-abf5-77e7964c1d08@yandex.ru> Date: Sat, 4 Jun 2022 12:40:31 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only Content-Language: en-US To: Eli Zaretskii References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> <43b5eada954e592cc0c747368a3dbdb7@posteo.de> <437b78f7-f4a9-670d-9b74-69ae8a565767@yandex.ru> <83ee06euv7.fsf@gnu.org> <859e155c-c71c-87f0-0363-f5682fe3d697@yandex.ru> <83a6aue1y2.fsf@gnu.org> <83leudaqlt.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83leudaqlt.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55632 Cc: jan.synacek@posteo.org, 55632@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04.06.2022 09:29, Eli Zaretskii wrote: >> Date: Sat, 4 Jun 2022 03:37:21 +0300 >> Cc: jan.synacek@posteo.org, 55632-done@debbugs.gnu.org >> From: Dmitry Gutov >> >>> If non-nil, files untracked by a VCS are considered to be part of >>> the project by a VC project based on that VCS. >> >> A bit unwieldy IMHO, but I don't mind. > > What is unwieldy there? I had to re-read it a couple of times to understand and verify its meaning. While the original was shorter and just as informative. Not something I want to argue about. If the present entry looks easy to understand to you, then it's fine by me. >> As long as you only objected to the NEWS entry. >> >> The addition to the manual, which is also usually considered user-level >> text, only continues the style of the preceding sentence. > > The manual explains what a back-end is, including what is the VC > back-end, so I didn't mind to using it there. Cool. From unknown Fri Jun 20 07:23:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 02 Jul 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator