From unknown Sun Jun 22 00:19:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55628: debug-timer-check fails on macOS 11.6.6 Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 May 2022 10:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 55628@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16534756117603 (code B ref -1); Wed, 25 May 2022 10:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 May 2022 10:46:51 +0000 Received: from localhost ([127.0.0.1]:54397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntoXT-0001yY-1s for submit@debbugs.gnu.org; Wed, 25 May 2022 06:46:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:37808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntoXR-0001yR-6Q for submit@debbugs.gnu.org; Wed, 25 May 2022 06:46:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntoXP-0003hO-Li for bug-gnu-emacs@gnu.org; Wed, 25 May 2022 06:46:47 -0400 Received: from mail236c50.megamailservers.eu ([91.136.10.246]:54676 helo=mail56c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntoXN-0003MG-74 for bug-gnu-emacs@gnu.org; Wed, 25 May 2022 06:46:47 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1653475602; bh=FztWrf0ZgESMnSevdpZakYSHIkhguCMQ1nwnTr+qGz0=; h=From:Subject:Date:To:From; b=Q6IB8aDaMXSc/OjRkQoHbIEl61jSmT7qskYVtXMLRi2XojSBRFY0pk7lKrK0pbT8B 2MkHcsEXnvAefXJvP+GDfvkEDgG47NnpETOiFjC6iypbxEhKtj/M7z8QJMr7YF3Z+0 y7P0NT70KNsloPlnfUQn/uvFS/URL0jt8fgCyknE= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 24PAke9J013119 for ; Wed, 25 May 2022 10:46:41 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Message-Id: Date: Wed, 25 May 2022 12:46:39 +0200 X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F20.628E0912.000A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.10.246; envelope-from=mattiase@acm.org; helo=mail56c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Built with enable-checking, (debug-timer-check) returns nil. It turns out that debug_timer_callback is never actually called, but I = haven't dug further than that. This is on macOS 11.6.6 and HAVE_TIMERFD is not defined. Does this code = path work on other systems? From unknown Sun Jun 22 00:19:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55628: debug-timer-check fails on macOS 11.6.6 Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 May 2022 12:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 55628@debbugs.gnu.org Received: via spool by 55628-submit@debbugs.gnu.org id=B55628.16534812172147 (code B ref 55628); Wed, 25 May 2022 12:21:01 +0000 Received: (at 55628) by debbugs.gnu.org; 25 May 2022 12:20:17 +0000 Received: from localhost ([127.0.0.1]:54565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntpzt-0000YZ-Fu for submit@debbugs.gnu.org; Wed, 25 May 2022 08:20:17 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntpzs-0000YD-3c for 55628@debbugs.gnu.org; Wed, 25 May 2022 08:20:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gGvTxBYI7LMxEnqBZ9xDx+uZWe4tlLzb7fdQrMRQ37g=; b=hiufZbvwg3+U9prgLESOr2SkT3 NJoRIxvm2q4eYP6Vw0wNvcrd5NrkD3yKObtDhMYAbK/LPKVRLjEJVFBH1qB2z1oBZJQQdvxLidHjN HvCyqINmsDOMJxEzQt92TpgTsP/i291VU1e9VVJeYPfDxBFhtREKyu6mRDFZOlPfJqGE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntpzk-0001Gb-4R; Wed, 25 May 2022 14:20:10 +0200 From: Lars Ingebrigtsen References: X-Now-Playing: Nils Petter =?UTF-8?Q?Molv=C3=A6r's?= _Solid Ether_: "Trip" Date: Wed, 25 May 2022 14:20:07 +0200 In-Reply-To: ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Wed, 25 May 2022 12:46:39 +0200") Message-ID: <87sfoxdcso.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= writes: > Built with enable-checking, (debug-timer-check) returns nil. > It turns out that debug_timer_callback is never actually called, but I > haven't dug further than that. > > This is on macOS 11.6.6 and [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mattias Engdeg=C3=A5rd writes: > Built with enable-checking, (debug-timer-check) returns nil. > It turns out that debug_timer_callback is never actually called, but I > haven't dug further than that. > > This is on macOS 11.6.6 and HAVE_TIMERFD is not defined. Does this > code path work on other systems? I tried this on Debian/bookworm (with nativecomp, but that probably doesn't make a difference), and I got nil there, too. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 00:19:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55628: debug-timer-check fails on macOS 11.6.6 Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 May 2022 13:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 55628@debbugs.gnu.org Received: via spool by 55628-submit@debbugs.gnu.org id=B55628.165348394415774 (code B ref 55628); Wed, 25 May 2022 13:06:01 +0000 Received: (at 55628) by debbugs.gnu.org; 25 May 2022 13:05:44 +0000 Received: from localhost ([127.0.0.1]:54613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntqhs-00046M-Gv for submit@debbugs.gnu.org; Wed, 25 May 2022 09:05:44 -0400 Received: from mail239c50.megamailservers.eu ([91.136.10.249]:36014 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntqhp-000462-J7 for 55628@debbugs.gnu.org; Wed, 25 May 2022 09:05:42 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1653483934; bh=NPWMx6T/jSGTznFjWnzE3RuItRvxgKS2wRCGrxfr6mk=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=DfCHkEG0BdjXcQ81/vnHk2vU0vtqIp9TPvcdS8CCo9ABdeaNShej4uzC9VnouJLUE YHM91DE35rat/ffKMLJYgXKs5Rcgd/M12kD+ap/jF8Cu4X0tRL3nghagbLTwtLv7PV /sHn820TFTztn+ZoJEJOMZM7BpDrL8uitxtFghvM= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 24PD5WAB015484; Wed, 25 May 2022 13:05:34 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_103CCC85-70B7-46C8-87B6-1A68D8DB0085" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Date: Wed, 25 May 2022 15:05:32 +0200 In-Reply-To: <87sfoxdcso.fsf@gnus.org> References: <87sfoxdcso.fsf@gnus.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F28.628E299E.00A5, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 25 maj 2022 kl. 14.20 skrev Lars Ingebrigtsen : > > Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= writes: > >> Built with enable-checking, (debug-timer-check) returns nil. >> It turns out that [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_103CCC85-70B7-46C8-87B6-1A68D8DB0085 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 25 maj 2022 kl. 14.20 skrev Lars Ingebrigtsen : >=20 > Mattias Engdeg=C3=A5rd writes: >=20 >> Built with enable-checking, (debug-timer-check) returns nil. >> It turns out that debug_timer_callback is never actually called, but = I >> haven't dug further than that. >>=20 >> This is on macOS 11.6.6 and HAVE_TIMERFD is not defined. Does this >> code path work on other systems? >=20 > I tried this on Debian/bookworm (with nativecomp, but that probably > doesn't make a difference), and I got nil there, too. Thanks for checking. Apparently pending_signals is never set; = handle_alarm_signal is never called. More digging shows that set_alarm always sets the interval timer to at = least 1 ms in the future even if the timer has expired. The attached patch makes set_alarm signal SIGALRM immediately if the = timer is due. We could call the signal handler directly but this way it = should work correctly if the signal is masked at the moment. What do you = think? --Apple-Mail=_103CCC85-70B7-46C8-87B6-1A68D8DB0085 Content-Disposition: attachment; filename=set_alarm.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="set_alarm.diff" Content-Transfer-Encoding: 7bit diff --git a/src/atimer.c b/src/atimer.c index 1c6c881fc0..c26904e1f0 100644 --- a/src/atimer.c +++ b/src/atimer.c @@ -297,11 +297,6 @@ set_alarm (void) { if (atimers) { -#ifdef HAVE_SETITIMER - struct itimerval it; -#endif - struct timespec now, interval; - #ifdef HAVE_ITIMERSPEC if (0 <= timerfd || alarm_timer_ok) { @@ -337,20 +332,24 @@ set_alarm (void) } #endif - /* Determine interval till the next timer is ripe. - Don't set the interval to 0; this disables the timer. */ - now = current_timespec (); - interval = (timespec_cmp (atimers->expiration, now) <= 0 - ? make_timespec (0, 1000 * 1000) - : timespec_sub (atimers->expiration, now)); + /* Determine interval till the next timer is ripe. */ + struct timespec now = current_timespec (); + if (timespec_cmp (atimers->expiration, now) <= 0) + { + /* Timer is (over)due -- just trigger the signal right way. */ + raise (SIGALRM); + } + else + { + struct timespec interval = timespec_sub (atimers->expiration, now); #ifdef HAVE_SETITIMER - - memset (&it, 0, sizeof it); - it.it_value = make_timeval (interval); - setitimer (ITIMER_REAL, &it, 0); -#endif /* not HAVE_SETITIMER */ - alarm (max (interval.tv_sec, 1)); + struct itimerval it = {.it_value = make_timeval (interval)}; + setitimer (ITIMER_REAL, &it, 0); +#else + alarm (max (interval.tv_sec, 1)); +#endif + } } } --Apple-Mail=_103CCC85-70B7-46C8-87B6-1A68D8DB0085-- From unknown Sun Jun 22 00:19:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55628: debug-timer-check fails on macOS 11.6.6 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 May 2022 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 55628@debbugs.gnu.org, larsi@gnus.org Received: via spool by 55628-submit@debbugs.gnu.org id=B55628.165348734531816 (code B ref 55628); Wed, 25 May 2022 14:03:02 +0000 Received: (at 55628) by debbugs.gnu.org; 25 May 2022 14:02:25 +0000 Received: from localhost ([127.0.0.1]:56130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntrai-0008H6-NS for submit@debbugs.gnu.org; Wed, 25 May 2022 10:02:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntrae-0008Gk-6l for 55628@debbugs.gnu.org; Wed, 25 May 2022 10:02:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33544) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntraY-0006mZ-Nr; Wed, 25 May 2022 10:02:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=i5DCOke52je4nb2WtfC7Lm0fKdSF8dFP92r7eWoXG1E=; b=KBFOtSHuX1eHlYp4ZleY H/I5x/tx7xXzZ2KLGzuKC92ktOdKeQ5hfn3Ry59EG158d1FqiSBe0KYkugkuEXBFikQVGvdNsc3If t8vUZMVPWCWDqnFw1Uuh1oLcePa7oF13Ibf8t+6pqmO28oenzjPMIy97VrJankOBy7GQVu4+deB3B jxR3mcHfEVnouuI5IRqsbSAcMpjSGkAMD1Z8ij+PEC6IaTT89uMK7exR1slJZYtVIaZtA5tWJJUM4 R+iUIVal4j1kufTn4pRKVrQj/b4LKV5Q1/h+Mkb11c3jOjVePfoUKSn4CCOCpWDCpqlSTUaCXRZpb QpM5PXv9y1IB8A==; Received: from [87.69.77.57] (port=3994 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntraW-0000cd-Ao; Wed, 25 May 2022 10:02:14 -0400 Date: Wed, 25 May 2022 17:02:03 +0300 Message-Id: <83h75d4so4.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 25 May 2022 15:05:32 +0200) References: <87sfoxdcso.fsf@gnus.org> <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 55628@debbugs.gnu.org > From: Mattias Engdegård > Date: Wed, 25 May 2022 15:05:32 +0200 > > Thanks for checking. Apparently pending_signals is never set; handle_alarm_signal is never called. > More digging shows that set_alarm always sets the interval timer to at least 1 ms in the future even if the timer has expired. > > The attached patch makes set_alarm signal SIGALRM immediately if the timer is due. We could call the signal handler directly but this way it should work correctly if the signal is masked at the moment. What do you think? I'd prefer not to change the logic of set_alarm just to have a debugging aid working. Can we come up with a more compatible change, which doesn't affect calls to set_alarm except during this test? Thanks. From unknown Sun Jun 22 00:19:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55628: debug-timer-check fails on macOS 11.6.6 Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 May 2022 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 55628@debbugs.gnu.org Received: via spool by 55628-submit@debbugs.gnu.org id=B55628.16534929109751 (code B ref 55628); Wed, 25 May 2022 15:36:02 +0000 Received: (at 55628) by debbugs.gnu.org; 25 May 2022 15:35:10 +0000 Received: from localhost ([127.0.0.1]:56283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntt2U-0002X9-1Q for submit@debbugs.gnu.org; Wed, 25 May 2022 11:35:10 -0400 Received: from mail1463c50.megamailservers.eu ([91.136.14.63]:33450 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntt2R-0002WY-5h for 55628@debbugs.gnu.org; Wed, 25 May 2022 11:35:08 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1653492900; bh=pCKA3XRMlKuIij4417B6tE1o8SXoVUwvfqTJz+xSUek=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=qjlog9E3rpmde+ajgvrzFJF86MgF15aIyMfLMaMz2kKWxKoskQt4ZM0aQ0LYLVmeb ZImX97ZFABawRFxIFso9CCs88Y7qDz2z+JPf2tmqM+nPTNebFggBaouGMFND6uJ4q4 ieW2thc2HhijAn2lvvuiajT9BGmsGicyqSPtXNgw= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 24PFYwvX009557; Wed, 25 May 2022 15:34:59 +0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> Date: Wed, 25 May 2022 17:34:57 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <87D17F2F-BA51-45E3-BD81-A8CF9044C3BE@acm.org> References: <87sfoxdcso.fsf@gnus.org> <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F1C.628E4CA4.0015, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 25 maj 2022 kl. 15.05 skrev Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= : > More digging shows that set_alarm always sets the interval timer to at least 1 ms in the future even if the timer has expired. In fact it was even worse than that: because of a second bug, the timer was then immediately reset to at least 1 s in the future. The proposed patch fixes both flaws. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 25 maj 2022 kl. 15.05 skrev Mattias Engdeg=C3=A5rd : > More digging shows that set_alarm always sets the interval timer to at = least 1 ms in the future even if the timer has expired. In fact it was even worse than that: because of a second bug, the timer = was then immediately reset to at least 1 s in the future. The proposed = patch fixes both flaws. Good to have a test for it -- maybe it should always be enabled, not = just with enable-checking? People don't always reconfigure, rebuild and = re-run the tests with enable-checking, nor do any of the build bots. From unknown Sun Jun 22 00:19:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55628: debug-timer-check fails on macOS 11.6.6 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 May 2022 17:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 55628@debbugs.gnu.org, larsi@gnus.org Received: via spool by 55628-submit@debbugs.gnu.org id=B55628.165349869820586 (code B ref 55628); Wed, 25 May 2022 17:12:01 +0000 Received: (at 55628) by debbugs.gnu.org; 25 May 2022 17:11:38 +0000 Received: from localhost ([127.0.0.1]:56353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntuXm-0005Lu-RW for submit@debbugs.gnu.org; Wed, 25 May 2022 13:11:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntuXj-0005Lc-2U for 55628@debbugs.gnu.org; Wed, 25 May 2022 13:11:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46434) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntuXd-0007Rl-He; Wed, 25 May 2022 13:11:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=aPDpfrhjr+x5mDxRUrOBl3o+Kq3DK4lkd1S8b6XWGUk=; b=Vy3p6pjSttzwDUyMOzxk OKDlC6PmhUJJX9zw9jtn0Cok2ZVgs8L9xKGDNpckZfCiQHdXmo2YpjLs0nU/0lvLonxmyrEysDNG4 0T244X5byTUoHjk+eebO57A+Duwny7E/+e6G11yLikt/8nZMx/8VzCW03EbA4a7Yea2uFnWcIMYAO 8JQytJg2juJYN6QBXphcGp7k6OS2Sl5hQKpcfCpas6kU2zTi+jjETTc9pViSgyklM93N2/jxpom2Y QhfOmqJO+j1wdqlfhOux54MXMMD1QpJ4N8l4itkMK+mVlAbdwKKF9POcXtOLXeW/XuA7T0ums2e3P 7UVIOmwKnNE1Ig==; Received: from [87.69.77.57] (port=3142 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntuXd-0002dt-0w; Wed, 25 May 2022 13:11:25 -0400 Date: Wed, 25 May 2022 20:11:16 +0300 Message-Id: <83sfoxpmff.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87D17F2F-BA51-45E3-BD81-A8CF9044C3BE@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 25 May 2022 17:34:57 +0200) References: <87sfoxdcso.fsf@gnus.org> <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> <87D17F2F-BA51-45E3-BD81-A8CF9044C3BE@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Resent-From: Mattias Engdegård > Original-Sender: "Debbugs-submit" > Resent-CC: bug-gnu-emacs@gnu.org > Resent-Sender: help-debbugs@gnu.org > Cc: 55628@debbugs.gnu.org > From: Mattias Engdegård > Date: Wed, 25 May 2022 17:34:57 +0200 > > 25 maj 2022 kl. 15.05 skrev Mattias Engdegård : > > > More digging shows that set_alarm always sets the interval timer to at least 1 ms in the future even if the timer has expired. > > In fact it was even worse than that: because of a second bug, the timer was then immediately reset to at least 1 s in the future. The proposed patch fixes both flaws. Btw, this test will never work on a platform that only has setitimer, because only one ITIMER_REAL timer is guaranteed to exist, and the function attempts to arm 10 timers at the same time. > Good to have a test for it -- maybe it should always be enabled, not just with enable-checking? People don't always reconfigure, rebuild and re-run the tests with enable-checking, nor do any of the build bots. We don't usually have testing code in a production build, so why make an exception here? Especially since atimers are an obscure feature used internally by Emacs. From unknown Sun Jun 22 00:19:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55628: debug-timer-check fails on macOS 11.6.6 Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 May 2022 09:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 55628@debbugs.gnu.org, larsi@gnus.org Received: via spool by 55628-submit@debbugs.gnu.org id=B55628.165355908726252 (code B ref 55628); Thu, 26 May 2022 09:59:02 +0000 Received: (at 55628) by debbugs.gnu.org; 26 May 2022 09:58:07 +0000 Received: from localhost ([127.0.0.1]:57094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuAFq-0006pL-Ln for submit@debbugs.gnu.org; Thu, 26 May 2022 05:58:06 -0400 Received: from mail211c50.megamailservers.eu ([91.136.10.221]:51820 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuAFn-0006ow-LS for 55628@debbugs.gnu.org; Thu, 26 May 2022 05:58:05 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1653559081; bh=NIOZUm0peryCf7gDyM3qBe6uPumK2VOnlmnK3ygT5L8=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=H3ROulOIk8XhvmVuAWyIzNkd2efjSP6tV6vSxRUPZZ4tkv+f0qI+Dv7BXob8Mu410 w11ZXjhitDdMzjuhpQ6XGvc7U7G2b66ZhxSqVQnvgHnGMVw93S+dE4XuO/cbwZVy1i TNZZvsDVp/M/gXvAF0pw+bJpDmbw4ivEtP9BcEhs= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 24Q9vxQ8002102; Thu, 26 May 2022 09:58:00 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <83sfoxpmff.fsf@gnu.org> Date: Thu, 26 May 2022 11:57:58 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <87sfoxdcso.fsf@gnus.org> <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> <87D17F2F-BA51-45E3-BD81-A8CF9044C3BE@acm.org> <83sfoxpmff.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F29.628F4F29.002D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 25 maj 2022 kl. 19.11 skrev Eli Zaretskii : > Btw, this test will never work on a platform that only has setitimer, > because only one ITIMER_REAL timer is guaranteed to exist, and the > function attempts to arm 10 timers at the same time. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 25 maj 2022 kl. 19.11 skrev Eli Zaretskii : > Btw, this test will never work on a platform that only has setitimer, > because only one ITIMER_REAL timer is guaranteed to exist, and the > function attempts to arm 10 timers at the same time. That's not how the code works. `setitimer` will only be called for the = first timer to expire. (The test works correctly on this computer, that only has setitimer, = after applying the patch.) Another demonstration of this bug: (funcall-with-delayed-message 0.1 "haha" (lambda () (sit-for 3))) will, on this machine, display "haha" after 1 s if unpatched, but after = 0.1 s if patched. (This is with -nw because the NS backend seems to be slow handling async = events on its own, but that's a different bug.) > We don't usually have testing code in a production build, so why make > an exception here? Especially since atimers are an obscure feature > used internally by Emacs. There's nothing bad or even unusual about including interfaces for = internal testing in production builds, as long as it doesn't unduly = reduce performance or cause significant bloat. It's always a trade-off, = of course. From unknown Sun Jun 22 00:19:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55628: debug-timer-check fails on macOS 11.6.6 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 May 2022 11:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 55628@debbugs.gnu.org, larsi@gnus.org Received: via spool by 55628-submit@debbugs.gnu.org id=B55628.165356505212322 (code B ref 55628); Thu, 26 May 2022 11:38:01 +0000 Received: (at 55628) by debbugs.gnu.org; 26 May 2022 11:37:32 +0000 Received: from localhost ([127.0.0.1]:57139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuBo4-0003Cf-0Y for submit@debbugs.gnu.org; Thu, 26 May 2022 07:37:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuBnz-0003CQ-8b for 55628@debbugs.gnu.org; Thu, 26 May 2022 07:37:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuBnt-0000xP-Vc; Thu, 26 May 2022 07:37:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=I7qSu9HKhnKjV7wlwnYEd+Zo7QTcI5QAScG55ngkiOs=; b=dldLBVUX0qwwrRniaqFS vXLSmrCZY3PaOKXKwdEr6NCoWqsTtBH5KoGbbsNCsZ8nhTTkRTkBgzjXeerftG3EVJTWHk66d/FUD oR4bzYhomElWlR5L7RQvC4vpIhpUicT6CWjXtE6E2JcXMlwtGLTv6e6rN1py3qPfThRLZaNdJM0YP p87dz/O+SZE4J0rRRUxDAEhN89FmtPj9BINV8M47zqGoWe29GWf0iq4CnQHCfrEdWlGIQYRPs7RxJ WaazgP0FSF99hGHUZHGv5ThAz+O0OnApxGTf9x+YSc7JUmDDV4BJ4WxKlNBVCZJUV/R6SH/JQeZjh O9mJdDeUOvm52Q==; Received: from [87.69.77.57] (port=3361 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuBnt-0006UI-F0; Thu, 26 May 2022 07:37:21 -0400 Date: Thu, 26 May 2022 14:37:15 +0300 Message-Id: <837d68plsk.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Thu, 26 May 2022 11:57:58 +0200) References: <87sfoxdcso.fsf@gnus.org> <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> <87D17F2F-BA51-45E3-BD81-A8CF9044C3BE@acm.org> <83sfoxpmff.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Thu, 26 May 2022 11:57:58 +0200 > Cc: larsi@gnus.org, 55628@debbugs.gnu.org > > 25 maj 2022 kl. 19.11 skrev Eli Zaretskii : > > > Btw, this test will never work on a platform that only has setitimer, > > because only one ITIMER_REAL timer is guaranteed to exist, and the > > function attempts to arm 10 timers at the same time. > > That's not how the code works. `setitimer` will only be called for the first timer to expire. Maybe I've misread the code, then. Apologies. > > We don't usually have testing code in a production build, so why make > > an exception here? Especially since atimers are an obscure feature > > used internally by Emacs. > > There's nothing bad or even unusual about including interfaces for internal testing in production builds, as long as it doesn't unduly reduce performance or cause significant bloat. It's always a trade-off, of course. Not in principle, but we in this project don't do that. E.g., there are several debug-related functions and commands in xdisp.c that are only compiled in under ENABLE_CHECKING. So if we are going to make an exception for this case, we should have some good reason. From unknown Sun Jun 22 00:19:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55628: debug-timer-check fails on macOS 11.6.6 Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 May 2022 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 55628@debbugs.gnu.org, Lars Ingebrigtsen Received: via spool by 55628-submit@debbugs.gnu.org id=B55628.165357097215382 (code B ref 55628); Thu, 26 May 2022 13:17:02 +0000 Received: (at 55628) by debbugs.gnu.org; 26 May 2022 13:16:12 +0000 Received: from localhost ([127.0.0.1]:57416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuDLX-000401-Nu for submit@debbugs.gnu.org; Thu, 26 May 2022 09:16:11 -0400 Received: from mail1440c50.megamailservers.eu ([91.136.14.40]:47026 helo=mail264c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuDLS-0003zJ-MA for 55628@debbugs.gnu.org; Thu, 26 May 2022 09:16:10 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1653570959; bh=594Duc4u6HrMuLG6BJSeMO/4TYBK10WHUy7v6WoMgKM=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=RQ8wgwMUTMLjqw/q83aBQvO/gYsJEyutufPFjsyfu64z+uzc0j+1l4t8kmRQIawPN dC3FoFW2w+w+Zvtzo2BenpDH3Z5eKoMoaac8LwhYLjnrnnU3ulT92cShDix4ggKZuX 43ZDGTtj+Fn1Ca5PDajYYNBvMmfxevM0COcu3/gM= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 24QDFve1012969; Thu, 26 May 2022 13:15:58 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <2508D80D-E65A-4407-A09C-8E1A2E8E80AF@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_E25A00F3-9D13-4F03-A77C-585DF49FCCA5" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Date: Thu, 26 May 2022 15:15:56 +0200 In-Reply-To: <837d68plsk.fsf@gnu.org> References: <87sfoxdcso.fsf@gnus.org> <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> <87D17F2F-BA51-45E3-BD81-A8CF9044C3BE@acm.org> <83sfoxpmff.fsf@gnu.org> <837d68plsk.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F16.628F7D8F.0066, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 26 maj 2022 kl. 13.37 skrev Eli Zaretskii : > Not in principle, but we in this project don't do that. E.g., there > are several debug-related functions and commands in xdisp.c that are > only compiled in under ENABLE_CHECKING. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_E25A00F3-9D13-4F03-A77C-585DF49FCCA5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 26 maj 2022 kl. 13.37 skrev Eli Zaretskii : > Not in principle, but we in this project don't do that. E.g., there > are several debug-related functions and commands in xdisp.c that are > only compiled in under ENABLE_CHECKING. I don't think that not having done it in the past is justification = enough for not doing it now, but I agree that it would be preferable to = have it covered by a test that doesn't need a special interface. It looks like funcall-with-delayed-message could be used for this = purpose. I came up with the attached test, which also has the benefit of = extending test coverage to that function which previously had none. --Apple-Mail=_E25A00F3-9D13-4F03-A77C-585DF49FCCA5 Content-Disposition: attachment; filename=funcall-with-delayed-message-test.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="funcall-with-delayed-message-test.diff" Content-Transfer-Encoding: 7bit diff --git a/test/src/eval-tests.el b/test/src/eval-tests.el index e4230c10ef..1b2ad99360 100644 --- a/test/src/eval-tests.el +++ b/test/src/eval-tests.el @@ -240,4 +240,31 @@ eval-tests/backtrace-in-batch-mode/demoted-errors (should (equal (string-trim (buffer-string)) "Error: (error \"Boo\")"))))) +(ert-deftest eval-tests/funcall-with-delayed-message () + ;; Check that `funcall-with-delayed-message' displays its message before + ;; its function terminates iff the timeout is short enough. + + ;; This also serves as regression test for bug#55628 where a short + ;; timeout was rounded up to the next whole second. + (dolist (params '((0.8 0.4) + (0.1 0.8))) + (let ((timeout (nth 0 params)) + (work-time (nth 1 params))) + (ert-info ((prin1-to-string params) :prefix "params: ") + (with-current-buffer "*Messages*" + (let ((inhibit-read-only t)) + (erase-buffer)) + (let ((stop (+ (float-time) work-time))) + (funcall-with-delayed-message + timeout "timed out" + (lambda () + (while (< (float-time) stop)) + (message "finished")))) + (let ((expected-messages + (if (< timeout work-time) + "timed out\nfinished" + "finished"))) + (should (equal (string-trim (buffer-string)) + expected-messages)))))))) + ;;; eval-tests.el ends here --Apple-Mail=_E25A00F3-9D13-4F03-A77C-585DF49FCCA5-- From unknown Sun Jun 22 00:19:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55628: debug-timer-check fails on macOS 11.6.6 Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 May 2022 10:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 55628@debbugs.gnu.org, Lars Ingebrigtsen Received: via spool by 55628-submit@debbugs.gnu.org id=B55628.165390745832752 (code B ref 55628); Mon, 30 May 2022 10:45:02 +0000 Received: (at 55628) by debbugs.gnu.org; 30 May 2022 10:44:18 +0000 Received: from localhost ([127.0.0.1]:42875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvcsV-0008Vw-QG for submit@debbugs.gnu.org; Mon, 30 May 2022 06:44:18 -0400 Received: from mail1454c50.megamailservers.eu ([91.136.14.54]:52046 helo=mail266c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvcsQ-0008VG-3t for 55628@debbugs.gnu.org; Mon, 30 May 2022 06:44:02 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1653907431; bh=+63EsicEU9e2SBQwlKuoRNdIkLSMkMCTuRVOJB2zx44=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=gf0lO40khJUtyCpyODvks86ZXNTcG7YN9oeTLHRSryjgIQnbWYxrneyTOJoYIoJel XkPXZW91w/YtwoQhNekmkzoZDPgdNqHivV67MggRRrMJrspvtz5IT9QSf2gczkLvBf EYbys+jMQVNEcLTk8oqNNkmzeE1mhmgete0TsIQI= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail266c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 24UAhmOr028170; Mon, 30 May 2022 10:43:50 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <98860231-7C5C-433E-8704-24E4BDF860A9@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_6A171A20-867E-4DC8-96DF-ED39201CD774" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Date: Mon, 30 May 2022 12:43:48 +0200 In-Reply-To: <2508D80D-E65A-4407-A09C-8E1A2E8E80AF@acm.org> References: <87sfoxdcso.fsf@gnus.org> <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> <87D17F2F-BA51-45E3-BD81-A8CF9044C3BE@acm.org> <83sfoxpmff.fsf@gnu.org> <837d68plsk.fsf@gnu.org> <2508D80D-E65A-4407-A09C-8E1A2E8E80AF@acm.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F25.62949FE7.0019, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attached is the final patch (just the two previously combined with a commit message). Would someone please double-check that it works on a platform other than macOS before I push it? Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_6A171A20-867E-4DC8-96DF-ED39201CD774 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Attached is the final patch (just the two previously combined with a = commit message). Would someone please double-check that it works on a platform other than = macOS before I push it? --Apple-Mail=_6A171A20-867E-4DC8-96DF-ED39201CD774 Content-Disposition: attachment; filename=0001-Fix-atimer-setting-and-overdue-expiration-bug-55628.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-atimer-setting-and-overdue-expiration-bug-55628.patch" Content-Transfer-Encoding: quoted-printable =46rom=20671716186fc6d2506d06e85485faad405a365e6a=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Mon,=2030=20May=202022=2012:25:19=20+0200=0A= Subject:=20[PATCH]=20Fix=20atimer=20setting=20and=20overdue=20expiration=20= (bug#55628)=0A=0A*=20src/atimer.c=20(set_alarm):=20If=20the=20atimer=20= has=20already=20expired,=20signal=0Ait=20right=20away=20instead=20of=20= postponing=20it=20further.=20=20Previously=20this=20could=0Aoccur=20= repeatedly,=20blocking=20atimers=20indefinitely.=0AAlso=20only=20use=20= `alarm`=20as=20fallback=20if=20`setitimer`=20is=20unavailable,=20not=0A= both=20at=20the=20same=20time=20(which=20makes=20no=20sense,=20and=20= they=20both=20typically=0Ause=20the=20same=20mechanism=20behind=20the=20= curtains).=0A=0A*=20test/src/eval-tests.el=20= (eval-tests/funcall-with-delayed-message):=0ANew=20test,=20verifying=20= proper=20functioning=20of=20funcall-with-delayed-message=0Awhich=20also=20= serves=20as=20test=20for=20this=20bug=20(which=20also=20caused=0A= debug-timer-check=20to=20fail,=20but=20that=20test=20is=20only=20run=20= when=20Emacs=20is=0Abuilt=20with=20enable-checking).=0A---=0A=20= src/atimer.c=20=20=20=20=20=20=20=20=20=20=20|=2033=20= ++++++++++++++++-----------------=0A=20test/src/eval-tests.el=20|=2027=20= +++++++++++++++++++++++++++=0A=202=20files=20changed,=2043=20= insertions(+),=2017=20deletions(-)=0A=0Adiff=20--git=20a/src/atimer.c=20= b/src/atimer.c=0Aindex=201c6c881fc0..c26904e1f0=20100644=0A---=20= a/src/atimer.c=0A+++=20b/src/atimer.c=0A@@=20-297,11=20+297,6=20@@=20= set_alarm=20(void)=0A=20{=0A=20=20=20if=20(atimers)=0A=20=20=20=20=20{=0A= -#ifdef=20HAVE_SETITIMER=0A-=20=20=20=20=20=20struct=20itimerval=20it;=0A= -#endif=0A-=20=20=20=20=20=20struct=20timespec=20now,=20interval;=0A-=0A=20= #ifdef=20HAVE_ITIMERSPEC=0A=20=20=20=20=20=20=20if=20(0=20<=3D=20timerfd=20= ||=20alarm_timer_ok)=0A=20=09{=0A@@=20-337,20=20+332,24=20@@=20set_alarm=20= (void)=0A=20=09}=0A=20#endif=0A=20=0A-=20=20=20=20=20=20/*=20Determine=20= interval=20till=20the=20next=20timer=20is=20ripe.=0A-=09=20Don't=20set=20= the=20interval=20to=200;=20this=20disables=20the=20timer.=20=20*/=0A-=20=20= =20=20=20=20now=20=3D=20current_timespec=20();=0A-=20=20=20=20=20=20= interval=20=3D=20(timespec_cmp=20(atimers->expiration,=20now)=20<=3D=200=0A= -=09=09=20=20?=20make_timespec=20(0,=201000=20*=201000)=0A-=09=09=20=20:=20= timespec_sub=20(atimers->expiration,=20now));=0A+=20=20=20=20=20=20/*=20= Determine=20interval=20till=20the=20next=20timer=20is=20ripe.=20=20*/=0A= +=20=20=20=20=20=20struct=20timespec=20now=20=3D=20current_timespec=20= ();=0A+=20=20=20=20=20=20if=20(timespec_cmp=20(atimers->expiration,=20= now)=20<=3D=200)=0A+=09{=0A+=09=20=20/*=20Timer=20is=20(over)due=20--=20= just=20trigger=20the=20signal=20right=20way.=20=20*/=0A+=09=20=20raise=20= (SIGALRM);=0A+=09}=0A+=20=20=20=20=20=20else=0A+=09{=0A+=09=20=20struct=20= timespec=20interval=20=3D=20timespec_sub=20(atimers->expiration,=20now);=0A= =20=0A=20#ifdef=20HAVE_SETITIMER=0A-=0A-=20=20=20=20=20=20memset=20(&it,=20= 0,=20sizeof=20it);=0A-=20=20=20=20=20=20it.it_value=20=3D=20make_timeval=20= (interval);=0A-=20=20=20=20=20=20setitimer=20(ITIMER_REAL,=20&it,=200);=0A= -#endif=20/*=20not=20HAVE_SETITIMER=20*/=0A-=20=20=20=20=20=20alarm=20= (max=20(interval.tv_sec,=201));=0A+=09=20=20struct=20itimerval=20it=20=3D=20= {.it_value=20=3D=20make_timeval=20(interval)};=0A+=09=20=20setitimer=20= (ITIMER_REAL,=20&it,=200);=0A+#else=0A+=09=20=20alarm=20(max=20= (interval.tv_sec,=201));=0A+#endif=0A+=09}=0A=20=20=20=20=20}=0A=20}=0A=20= =0Adiff=20--git=20a/test/src/eval-tests.el=20b/test/src/eval-tests.el=0A= index=20e4230c10ef..1b2ad99360=20100644=0A---=20a/test/src/eval-tests.el=0A= +++=20b/test/src/eval-tests.el=0A@@=20-240,4=20+240,31=20@@=20= eval-tests/backtrace-in-batch-mode/demoted-errors=0A=20=20=20=20=20=20=20= (should=20(equal=20(string-trim=20(buffer-string))=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"Error:=20(error=20= \"Boo\")")))))=0A=20=0A+(ert-deftest=20= eval-tests/funcall-with-delayed-message=20()=0A+=20=20;;=20Check=20that=20= `funcall-with-delayed-message'=20displays=20its=20message=20before=0A+=20= =20;;=20its=20function=20terminates=20iff=20the=20timeout=20is=20short=20= enough.=0A+=0A+=20=20;;=20This=20also=20serves=20as=20regression=20test=20= for=20bug#55628=20where=20a=20short=0A+=20=20;;=20timeout=20was=20= rounded=20up=20to=20the=20next=20whole=20second.=0A+=20=20(dolist=20= (params=20'((0.8=200.4)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(0.1=200.8)))=0A+=20=20=20=20(let=20((timeout=20(nth=200=20= params))=0A+=20=20=20=20=20=20=20=20=20=20(work-time=20(nth=201=20= params)))=0A+=20=20=20=20=20=20(ert-info=20((prin1-to-string=20params)=20= :prefix=20"params:=20")=0A+=20=20=20=20=20=20=20=20(with-current-buffer=20= "*Messages*"=0A+=20=20=20=20=20=20=20=20=20=20(let=20((inhibit-read-only=20= t))=0A+=20=20=20=20=20=20=20=20=20=20=20=20(erase-buffer))=0A+=20=20=20=20= =20=20=20=20=20=20(let=20((stop=20(+=20(float-time)=20work-time)))=0A+=20= =20=20=20=20=20=20=20=20=20=20=20(funcall-with-delayed-message=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20timeout=20"timed=20out"=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20(lambda=20()=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(while=20(<=20(float-time)=20stop))=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(message=20"finished"))))=0A+=20=20=20=20=20=20=20=20=20= =20(let=20((expected-messages=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(if=20(<=20timeout=20work-time)=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20"timed=20out\nfinished"=0A+=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20"finished")))=0A+=20=20=20=20=20= =20=20=20=20=20=20=20(should=20(equal=20(string-trim=20(buffer-string))=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20expected-messages))))))))=0A+=0A=20;;;=20eval-tests.el=20ends=20= here=0A--=20=0A2.32.0=20(Apple=20Git-132)=0A=0A= --Apple-Mail=_6A171A20-867E-4DC8-96DF-ED39201CD774-- From unknown Sun Jun 22 00:19:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55628: debug-timer-check fails on macOS 11.6.6 Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 May 2022 13:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 55628@debbugs.gnu.org, Eli Zaretskii Received: via spool by 55628-submit@debbugs.gnu.org id=B55628.165391818931004 (code B ref 55628); Mon, 30 May 2022 13:44:02 +0000 Received: (at 55628) by debbugs.gnu.org; 30 May 2022 13:43:09 +0000 Received: from localhost ([127.0.0.1]:43433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvffo-00083y-Nc for submit@debbugs.gnu.org; Mon, 30 May 2022 09:43:09 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvffm-00083E-SA for 55628@debbugs.gnu.org; Mon, 30 May 2022 09:43:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5kPJObLTbo7k6/IOhI5F7M89ME+3qRQoToTDAMxD87w=; b=PIP0rg5PZF9aYaX4bF78T167/C OQMDUl2aP0ncpiiqtjpSx8xAf76s4i2DTyXjINL7g8cEUj2qQPVkZxIOX+ay2jCcdrgUMMRCUZ20I jdh8uYL55E2XyP+V1vsPIfkGqHMPsYjwNQiQ/UknMxBcudeDc3TpYXVT9h+zq+x5GSYY=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nvffc-0004Wq-6w; Mon, 30 May 2022 15:42:59 +0200 From: Lars Ingebrigtsen References: <87sfoxdcso.fsf@gnus.org> <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> <87D17F2F-BA51-45E3-BD81-A8CF9044C3BE@acm.org> <83sfoxpmff.fsf@gnu.org> <837d68plsk.fsf@gnu.org> <2508D80D-E65A-4407-A09C-8E1A2E8E80AF@acm.org> <98860231-7C5C-433E-8704-24E4BDF860A9@acm.org> X-Now-Playing: Hermine's _Lonery At The Top bis_: "That's The Way It Goes" Date: Mon, 30 May 2022 15:42:53 +0200 In-Reply-To: <98860231-7C5C-433E-8704-24E4BDF860A9@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Mon, 30 May 2022 12:43:48 +0200") Message-ID: <87sforw2zm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= writes: > Attached is the final patch (just the two previously combined with a > commit message). > > Would someone please double-check that it works on a platform other > than macOS before I push it? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mattias Engdeg=C3=A5rd writes: > Attached is the final patch (just the two previously combined with a > commit message). > > Would someone please double-check that it works on a platform other > than macOS before I push it? Works for me on Debian/bullseye (that is, no compilation warnings and the tests pass). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 00:19:36 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Subject: bug#55628: closed (Re: bug#55628: debug-timer-check fails on macOS 11.6.6) Message-ID: References: <5D859557-FCD1-46AA-83F1-7E4E924EE32B@acm.org> X-Gnu-PR-Message: they-closed 55628 X-Gnu-PR-Package: emacs Reply-To: 55628@debbugs.gnu.org Date: Mon, 30 May 2022 13:57:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1653919022-2580-1" This is a multi-part message in MIME format... ------------=_1653919022-2580-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55628: debug-timer-check fails on macOS 11.6.6 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55628@debbugs.gnu.org. --=20 55628: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55628 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1653919022-2580-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55628-done) by debbugs.gnu.org; 30 May 2022 13:56:09 +0000 Received: from localhost ([127.0.0.1]:45569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvfsO-0000dx-T5 for submit@debbugs.gnu.org; Mon, 30 May 2022 09:56:09 -0400 Received: from mail1467c50.megamailservers.eu ([91.136.14.67]:42068 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvfsJ-0000dW-QS for 55628-done@debbugs.gnu.org; Mon, 30 May 2022 09:56:07 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1653918956; bh=3J6ihDNRdKI8R1uPLd0rfZAZTczrqN3NNpcWSgHHij4=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=rFmkI+nGV+qV1PIEpLlaPNCfQTs5OI+Tah0k7UFKSmYZ5OcO8yeodZ+vXtGxtr5MY w5h34JG1Li8I6o7JofYXyN725NcDA5NueJ/r97OLo53Ugu739pqFhIMdDFGEYcmx28 M98cD99K26Ch8DvIAAfzQ8I2J63xLS+cG3Szus1k= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 24UDtsQe009101; Mon, 30 May 2022 13:55:55 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: bug#55628: debug-timer-check fails on macOS 11.6.6 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87sforw2zm.fsf@gnus.org> Date: Mon, 30 May 2022 15:55:53 +0200 Content-Transfer-Encoding: 7bit Message-Id: <5D859557-FCD1-46AA-83F1-7E4E924EE32B@acm.org> References: <87sfoxdcso.fsf@gnus.org> <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> <87D17F2F-BA51-45E3-BD81-A8CF9044C3BE@acm.org> <83sfoxpmff.fsf@gnu.org> <837d68plsk.fsf@gnu.org> <2508D80D-E65A-4407-A09C-8E1A2E8E80AF@acm.org> <98860231-7C5C-433E-8704-24E4BDF860A9@acm.org> <87sforw2zm.fsf@gnus.org> To: Lars Ingebrigtsen X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F21.6294CCEC.004A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 30 maj 2022 kl. 15.42 skrev Lars Ingebrigtsen : > Works for me on Debian/bullseye (that is, no compilation warnings and > the tests pass). Thank you, now pushed to master. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 55628-done Cc: Eli Zaretskii , 55628-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 30 maj 2022 kl. 15.42 skrev Lars Ingebrigtsen : > Works for me on Debian/bullseye (that is, no compilation warnings and > the tests pass). Thank you, now pushed to master. ------------=_1653919022-2580-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 May 2022 10:46:51 +0000 Received: from localhost ([127.0.0.1]:54397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntoXT-0001yY-1s for submit@debbugs.gnu.org; Wed, 25 May 2022 06:46:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:37808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntoXR-0001yR-6Q for submit@debbugs.gnu.org; Wed, 25 May 2022 06:46:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntoXP-0003hO-Li for bug-gnu-emacs@gnu.org; Wed, 25 May 2022 06:46:47 -0400 Received: from mail236c50.megamailservers.eu ([91.136.10.246]:54676 helo=mail56c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntoXN-0003MG-74 for bug-gnu-emacs@gnu.org; Wed, 25 May 2022 06:46:47 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1653475602; bh=FztWrf0ZgESMnSevdpZakYSHIkhguCMQ1nwnTr+qGz0=; h=From:Subject:Date:To:From; b=Q6IB8aDaMXSc/OjRkQoHbIEl61jSmT7qskYVtXMLRi2XojSBRFY0pk7lKrK0pbT8B 2MkHcsEXnvAefXJvP+GDfvkEDgG47NnpETOiFjC6iypbxEhKtj/M7z8QJMr7YF3Z+0 y7P0NT70KNsloPlnfUQn/uvFS/URL0jt8fgCyknE= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 24PAke9J013119 for ; Wed, 25 May 2022 10:46:41 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: debug-timer-check fails on macOS 11.6.6 Message-Id: Date: Wed, 25 May 2022 12:46:39 +0200 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F20.628E0912.000A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.10.246; envelope-from=mattiase@acm.org; helo=mail56c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Built with enable-checking, (debug-timer-check) returns nil. It turns out that debug_timer_callback is never actually called, but I = haven't dug further than that. This is on macOS 11.6.6 and HAVE_TIMERFD is not defined. Does this code = path work on other systems? ------------=_1653919022-2580-1--