From debbugs-submit-bounces@debbugs.gnu.org Wed May 25 00:01:02 2022 Received: (at submit) by debbugs.gnu.org; 25 May 2022 04:01:03 +0000 Received: from localhost ([127.0.0.1]:54048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntiCg-00069G-SS for submit@debbugs.gnu.org; Wed, 25 May 2022 00:01:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:54710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntgJo-000102-S1 for submit@debbugs.gnu.org; Tue, 24 May 2022 22:00:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntgJo-0007F9-J5 for bug-coreutils@gnu.org; Tue, 24 May 2022 22:00:12 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:34467) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ntgJm-0004DT-Ot for bug-coreutils@gnu.org; Tue, 24 May 2022 22:00:12 -0400 Received: by mail-pj1-x1035.google.com with SMTP id ob14-20020a17090b390e00b001dff2a43f8cso2830049pjb.1 for ; Tue, 24 May 2022 19:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:to:content-language:from :subject; bh=4Yriio53B8O1WqYcSte7BAXuONdbbbzDH7zmsVh9nbo=; b=Pe8IIHdHTZvvMEoygu6j4UDTck1vmN4h+y5pzDPBdfVVbY9u8r0GWBYVRy7xhSCYa4 kYdKDiqSAJPl7VqgAdJwxSNkKFKvAeEJHc4b1U+ioYKfzLzGoboatCT8T3X+8w9PeEZr IKNIiXMk4tCLy0k9wV2sNwCnvEtHZ0RMSyTSYJSkdyhbFAN3zUFOUnMgzwW3I2LEeIfg Wa3/HTGTL5KVwnHoYBjqch0ZFuYHzOw+VozW2WkgAUnp6GGRjg2jvEDNJ/yBGbCcYyzG 8M5BIsSqFuFP6+X5Yyc15H80fqJ5sXRYAjaWw6BnRdh/lL4gE873ouszRkYcDoz9Mdk0 73Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:to :content-language:from:subject; bh=4Yriio53B8O1WqYcSte7BAXuONdbbbzDH7zmsVh9nbo=; b=s5HYJFafzknoGkeSPwfCLL7MkBQ6JVvb2b7uWtyw+RKtTRcyleze3l1rTu0bv3bOYV QBHpeXeNfPyEUpPWImCZ+VLlRS2QDSpT1VWAfPuvnHts0Vc3e4Ff6o34/Ah5GMuiM4+O tDsoO5ZmhbTr93i0n9OTxc8nffaZp+qaoNwLB2mHE35crLFEYRviUCBeUjVTAxnWDJJA 4IN2VmH+QI0Ff5pGB1s88xRPIXN5bC31rrUmIK3ZnhZtkMvZcI0a2+ns6jjkC47FGYyA EskPu9WYzbhajomhHT+OR6ABKCN3HfwdEIZMhDfGauR63byjgulBL3BXzMoa3YqdKvDK i2NA== X-Gm-Message-State: AOAM530LlKfZhEKYfXai8t1HODI4ViMxUD55gP5bmZ39u5wWSkmPhE/j aTHddA8KLm7YWhwMtyqO1xOaXshu2I0= X-Google-Smtp-Source: ABdhPJzbht02Os9gQ/iTKTc3KFRDv6KZx6cBsaO68m6dwtv6G642LFdLQU5JOy87NJbSrRAW2UPz4Q== X-Received: by 2002:a17:90b:240e:b0:1e0:775b:f8fc with SMTP id nr14-20020a17090b240e00b001e0775bf8fcmr6379802pjb.132.1653444008806; Tue, 24 May 2022 19:00:08 -0700 (PDT) Received: from ?IPV6:2601:646:9e00:b40:81e7:21f4:86cc:c54b? ([2601:646:9e00:b40:81e7:21f4:86cc:c54b]) by smtp.gmail.com with ESMTPSA id h3-20020a170902748300b00161929fb1adsm7861382pll.54.2022.05.24.19.00.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 19:00:08 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------b0pUnafS8NVbN0lyOl0PNrsu" Message-ID: <27734698-c170-a2c3-dbee-e96e4b4f8386@gmail.com> Date: Tue, 24 May 2022 19:00:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 To: bug-coreutils@gnu.org Content-Language: en-US From: Larry Ploetz Subject: Bug in sort with keys and reverse, and version-sort and reverse Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=lploetz@gmail.com; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 25 May 2022 00:00:57 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------b0pUnafS8NVbN0lyOl0PNrsu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I think I've found a bug in sort (git branch master). The --reverse flag seems to be ignored when --keys are supplied. larryp-MBP:bin larry$ ./sort --version sort (GNU coreutils) 9.1.17-a351f Copyright (C) 2022 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Mike Haertel and Paul Eggert. larryp-MBP:bin larry$ ./sort -r <<< $'a\nb' b a larryp-MBP:bin larry$ ./sort -rk1,1 <<< $'a\nb' a b This may be related to a bug reported in February where --version-sort sorted incorrectly. larryp-MBP:bin larry$ ./sort -Vr <<< $'1\n2' 1 2 larryp-MBP:bin larry$ ./sort -V <<< $'1\n2' 1 2 Current version: larryp-MBP:bin larry$ sort --version sort (GNU coreutils) 9.1 Copyright (C) 2022 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Mike Haertel and Paul Eggert. larryp-MBP:bin larry$ sort -rk1,1 <<< $'a\nb' b a Thanks, · Larry --------------b0pUnafS8NVbN0lyOl0PNrsu Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

I think I've found a bug in sort (git branch master). The --reverse flag seems to be ignored when --keys are supplied.

larryp-MBP:bin larry$ ./sort --version
sort (GNU coreutils) 9.1.17-a351f
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Mike Haertel and Paul Eggert.
larryp-MBP:bin larry$ ./sort -r <<< $'a\nb'
b
a
larryp-MBP:bin larry$ ./sort -rk1,1 <<< $'a\nb'
a
b

This may be related to a bug reported in February where --version-sort sorted incorrectly.

larryp-MBP:bin larry$ ./sort -Vr <<< $'1\n2'
1
2
larryp-MBP:bin larry$ ./sort -V <<< $'1\n2'
1
2

Current version:

larryp-MBP:bin larry$ sort --version
sort (GNU coreutils) 9.1
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Mike Haertel and Paul Eggert.
larryp-MBP:bin larry$ sort -rk1,1 <<< $'a\nb'
b
a

Thanks,
· Larry


--------------b0pUnafS8NVbN0lyOl0PNrsu-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 25 04:53:22 2022 Received: (at 55622-done) by debbugs.gnu.org; 25 May 2022 08:53:22 +0000 Received: from localhost ([127.0.0.1]:54324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntmle-0007Rv-GD for submit@debbugs.gnu.org; Wed, 25 May 2022 04:53:22 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:35804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntmlY-0007Re-R1 for 55622-done@debbugs.gnu.org; Wed, 25 May 2022 04:53:20 -0400 Received: by mail-wr1-f44.google.com with SMTP id x12so4874878wrg.2 for <55622-done@debbugs.gnu.org>; Wed, 25 May 2022 01:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=pbbK2nfZoqukE+h62Fs1Kz2M16yIAMj1905/fFZdfl4=; b=ZZRIOsZkqKJdApKOcKIFJdLl5akegc7hPSL3HGPDO9Q37F4UtIzL0lnhQobRa4TQWc I2HctnMTHssvM0/w9mzEPraIpBqvE8tHeQ/aU0uALfut0F+DVmyoyI/vp3KZOI60AWKy drz+0cBh6skVcOZNZD1bhI6bl5GT5/BQHswwbDfuGdm0ka5vHkSsry0+wB6uBonePZdm hBPyXY7H5WT5S3Od9UmziipFILCfKkHUhKmC56VE+1ew6hos2Cyhn2YBSBwuTPkQLBcR KqZSiroDxRGg8s+IbDLlJTdEY7CpJNEd+53yDAkbcLY5KjwGJ7/2yIrZY1mKNnLeTKEH 0VEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=pbbK2nfZoqukE+h62Fs1Kz2M16yIAMj1905/fFZdfl4=; b=8JXrJRO+bkyloRZo+kMD0F6xSKKegr56O4/etWZA0RUO2tJ2yxwrCzT3e1G+XZABbX 9v5imZePxNef3EvFGUIzoDgnT1RXf9RYmHOGwdAgXlNPn7JApTPfh9U5L8QTXZPts6tm YsA2FmyhNgZErmju6p7K+NjHQO8xvQA1bk9NY6nweoccHZPy6lc6N+XD607HOyQokwTK 2/ZgnUcw6TqvGO3ARu/IFG6tHlXvTzFNOYJn3v3Y9ToLxOHYcXSuftQpB3cjIOESIF1P 1rQOxIPyHAd/xL+KeFXERhBOJq2H9nf4XJ5i0kGfdn0J7dw9IIiJQ7HsTsw4fd4MRCbL Xvqg== X-Gm-Message-State: AOAM532VGn/najKDL3vv4a7spgCAm4SIjAT/TDo3HHgygdTRq3x4fqeu CFUs1jAuTDkZ9gRE7i/mqUE= X-Google-Smtp-Source: ABdhPJzoxkrTF8p/B6LXaPAjSWz0YDsiV8uNStuWO1rz15IGNdHcVFeQ/52ygANzSfqf/LVo5zQ0Fw== X-Received: by 2002:a5d:47af:0:b0:20f:eb21:245f with SMTP id 15-20020a5d47af000000b0020feb21245fmr8338091wrb.6.1653468790761; Wed, 25 May 2022 01:53:10 -0700 (PDT) Received: from [192.168.1.9] (95-44-90-175-dynamic.agg2.lod.rsl-rtd.eircom.net. [95.44.90.175]) by smtp.googlemail.com with ESMTPSA id 2-20020a056000154200b0020d106c0386sm1498458wry.89.2022.05.25.01.53.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 01:53:10 -0700 (PDT) Message-ID: <5180ddf7-dc90-1b15-db00-9a070f42cf1b@draigBrady.com> Date: Wed, 25 May 2022 09:53:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Thunderbird/98.0 Subject: Re: bug#55622: Bug in sort with keys and reverse, and version-sort and reverse Content-Language: en-US To: Larry Ploetz , 55622-done@debbugs.gnu.org References: <27734698-c170-a2c3-dbee-e96e4b4f8386@gmail.com> From: =?UTF-8?Q?P=c3=a1draig_Brady?= In-Reply-To: <27734698-c170-a2c3-dbee-e96e4b4f8386@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55622-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 25/05/2022 03:00, Larry Ploetz wrote: > I think I've found a bug in sort (git branch master). The --reverse flag > seems to be ignored when --keys are supplied. > > larryp-MBP:bin larry$ ./sort --version > sort (GNU coreutils) 9.1.17-a351f > Copyright (C) 2022 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later. > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > > Written by Mike Haertel and Paul Eggert. > larryp-MBP:bin larry$ ./sort -r <<< $'a\nb' > b > a > larryp-MBP:bin larry$ ./sort -rk1,1 <<< $'a\nb' > a > b Thanks for the report. I pushed the following to address this https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=4e0167ea1 The existing tests are sufficient to catch this. thanks! Pádraig From debbugs-submit-bounces@debbugs.gnu.org Wed May 25 14:28:32 2022 Received: (at 55622) by debbugs.gnu.org; 25 May 2022 18:28:32 +0000 Received: from localhost ([127.0.0.1]:56439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntvkG-0007Yc-Cg for submit@debbugs.gnu.org; Wed, 25 May 2022 14:28:32 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:32832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntvkD-0007YK-ET for 55622@debbugs.gnu.org; Wed, 25 May 2022 14:28:30 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 47F37160145; Wed, 25 May 2022 11:28:23 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id nGH_gFmHAHsH; Wed, 25 May 2022 11:28:22 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5691A16016E; Wed, 25 May 2022 11:28:22 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id fl7DJ4wAINKS; Wed, 25 May 2022 11:28:22 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 2AB4B160145; Wed, 25 May 2022 11:28:22 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------HTLf8GYjuy5BN9nmPJRjw04V" Message-ID: <373a951f-5696-cd87-0521-926cf3dca10d@cs.ucla.edu> Date: Wed, 25 May 2022 11:28:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: 55622@debbugs.gnu.org, P@draigBrady.com, lploetz@gmail.com References: <27734698-c170-a2c3-dbee-e96e4b4f8386@gmail.com> <5180ddf7-dc90-1b15-db00-9a070f42cf1b@draigBrady.com> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: bug#55622: Bug in sort with keys and reverse, and version-sort and reverse In-Reply-To: <5180ddf7-dc90-1b15-db00-9a070f42cf1b@draigBrady.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55622 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------HTLf8GYjuy5BN9nmPJRjw04V Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Thanks, P=C3=A1draig, for fixing that. And thanks, Larry, for reporting t= hat. > The existing tests are sufficient to catch this. Yes, evidently I forgot to run 'make check', which I usually do. I'll=20 try to not forget next time.... I installed the attached further patches to (1) coalesce duplicate code=20 and explain why it's needed and (2) tweak performance a tiny bit. --------------HTLf8GYjuy5BN9nmPJRjw04V Content-Type: text/x-patch; charset=UTF-8; name="0001-sort-refactor-tricky-diff-reversal.patch" Content-Disposition: attachment; filename="0001-sort-refactor-tricky-diff-reversal.patch" Content-Transfer-Encoding: base64 RnJvbSAxNTYyNzc5NDQ1OTkzM2QyOTM1NDdjMmJmN2Q3N2FiMTk2YWU3M2EzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDI1IE1heSAyMDIyIDExOjE5OjA4IC0wNzAwClN1YmplY3Q6IFtQQVRD SCAxLzJdIHNvcnQ6IHJlZmFjdG9yIHRyaWNreSBkaWZmIHJldmVyc2FsCgoqIHNyYy9zb3J0 LmMgKGRpZmZfcmV2ZXJzZWQpOiBOZXcgZnVuY3Rpb24sIHRvIG1ha2UgdGhlIGludGVudCBj bGVhcmVyLgooa2V5Y29tcGFyZSwgY29tcGFyZSk6IFVzZSBpdC4KLS0tCiBzcmMvc29ydC5j IHwgMTcgKysrKysrKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25z KCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9zb3J0LmMgYi9zcmMvc29y dC5jCmluZGV4IGRiZTQ1NjAzOC4uMGNkMjJmOTMxIDEwMDY0NAotLS0gYS9zcmMvc29ydC5j CisrKyBiL3NyYy9zb3J0LmMKQEAgLTI2MDEsNiArMjYwMSwxNSBAQCBrZXlfd2FybmluZ3Mg KHN0cnVjdCBrZXlmaWVsZCBjb25zdCAqZ2tleSwgYm9vbCBna2V5X29ubHkpCiAgICAgZXJy b3IgKDAsIDAsIF8oIm9wdGlvbiAnLXInIG9ubHkgYXBwbGllcyB0byBsYXN0LXJlc29ydCBj b21wYXJpc29uIikpOwogfQogCisvKiBSZXR1cm4gZWl0aGVyIHRoZSBzZW5zZSBvZiBESUZG IG9yIGl0cyByZXZlcnNlLCBkZXBuZGluZyBvbiBSRVZFUlNFRC4KKyAgIElmIFJFVkVSU0VE LCBkbyBub3Qgc2ltcGx5IG5lZ2F0ZSBESUZGIGFzIHRoYXQgY2FuIG1pc2hhbmRsZSBJTlRf TUlOLiAgKi8KKworc3RhdGljIGludAorZGlmZl9yZXZlcnNlZCAoaW50IGRpZmYsIGJvb2wg cmV2ZXJzZWQpCit7CisgIHJldHVybiByZXZlcnNlZCA/IChkaWZmIDwgMCA/IDEgOiAtZGlm ZikgOiBkaWZmOworfQorCiAvKiBDb21wYXJlIHR3byBsaW5lcyBBIGFuZCBCIHRyeWluZyBl dmVyeSBrZXkgaW4gc2VxdWVuY2UgdW50aWwgdGhlcmUKICAgIGFyZSBubyBtb3JlIGtleXMg b3IgYSBkaWZmZXJlbmNlIGlzIGZvdW5kLiAqLwogCkBAIC0yNzkzLDkgKzI4MDIsNyBAQCBr ZXljb21wYXJlIChzdHJ1Y3QgbGluZSBjb25zdCAqYSwgc3RydWN0IGxpbmUgY29uc3QgKmIp CiAgICAgICAgIH0KICAgICB9CiAKLSAgaWYgKGtleS0+cmV2ZXJzZSkKLSAgICBkaWZmID0g ZGlmZiA8IDAgPyAxIDogLWRpZmY7Ci0gIHJldHVybiBkaWZmOworICByZXR1cm4gZGlmZl9y ZXZlcnNlZCAoZGlmZiwga2V5LT5yZXZlcnNlKTsKIH0KIAogLyogQ29tcGFyZSB0d28gbGlu ZXMgQSBhbmQgQiwgcmV0dXJuaW5nIG5lZ2F0aXZlLCB6ZXJvLCBvciBwb3NpdGl2ZQpAQCAt Mjg0MCw5ICsyODQ3LDcgQEAgY29tcGFyZSAoc3RydWN0IGxpbmUgY29uc3QgKmEsIHN0cnVj dCBsaW5lIGNvbnN0ICpiKQogICAgICAgICBkaWZmID0gKGFsZW4gPiBibGVuKSAtIChhbGVu IDwgYmxlbik7CiAgICAgfQogCi0gIGlmIChyZXZlcnNlKQotICAgIGRpZmYgPSBkaWZmIDwg MCA/IDEgOiAtZGlmZjsKLSAgcmV0dXJuIGRpZmY7CisgIHJldHVybiBkaWZmX3JldmVyc2Vk IChkaWZmLCByZXZlcnNlKTsKIH0KIAogLyogV3JpdGUgTElORSB0byBvdXRwdXQgc3RyZWFt IEZQOyB0aGUgb3V0cHV0IGZpbGUncyBuYW1lIGlzCi0tIAoyLjM0LjEKCg== --------------HTLf8GYjuy5BN9nmPJRjw04V Content-Type: text/x-patch; charset=UTF-8; name="0002-sort-tune-diff_reversed.patch" Content-Disposition: attachment; filename="0002-sort-tune-diff_reversed.patch" Content-Transfer-Encoding: base64 RnJvbSA4NWRkZGUyMzExNmU1Nzg3NjhmOTBiYWQ2ODk5MzQwZGE1Mzk0Yjc1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDI1IE1heSAyMDIyIDExOjIzOjM5IC0wNzAwClN1YmplY3Q6IFtQQVRD SCAyLzJdIHNvcnQ6IHR1bmUgZGlmZl9yZXZlcnNlZAoKKiBzcmMvc29ydC5jIChkaWZmX3Jl dmVyc2VkKTogVHVuZS4gIE9uIHg4Ni02NCB3aXRoIEdDQywgdGhpcwpzYXZlcyBhIGNvbmRp dGlvbmFsIGJyYW5jaCBhbmQgc2hvcnRlbnMgdGhlIGdlbmVyYXRlZCBtYWNoaW5lIGNvZGUu Ci0tLQogc3JjL3NvcnQuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9zb3J0LmMgYi9zcmMvc29ydC5j CmluZGV4IDBjZDIyZjkzMS4uMGE2YjU1N2FjIDEwMDY0NAotLS0gYS9zcmMvc29ydC5jCisr KyBiL3NyYy9zb3J0LmMKQEAgLTI2MDcsNyArMjYwNyw3IEBAIGtleV93YXJuaW5ncyAoc3Ry dWN0IGtleWZpZWxkIGNvbnN0ICpna2V5LCBib29sIGdrZXlfb25seSkKIHN0YXRpYyBpbnQK IGRpZmZfcmV2ZXJzZWQgKGludCBkaWZmLCBib29sIHJldmVyc2VkKQogewotICByZXR1cm4g cmV2ZXJzZWQgPyAoZGlmZiA8IDAgPyAxIDogLWRpZmYpIDogZGlmZjsKKyAgcmV0dXJuIHJl dmVyc2VkID8gKGRpZmYgPCAwKSAtIChkaWZmID4gMCkgOiBkaWZmOwogfQogCiAvKiBDb21w YXJlIHR3byBsaW5lcyBBIGFuZCBCIHRyeWluZyBldmVyeSBrZXkgaW4gc2VxdWVuY2UgdW50 aWwgdGhlcmUKLS0gCjIuMzQuMQoK --------------HTLf8GYjuy5BN9nmPJRjw04V-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 25 14:50:47 2022 Received: (at 55622) by debbugs.gnu.org; 25 May 2022 18:50:47 +0000 Received: from localhost ([127.0.0.1]:56455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntw5n-0008Dk-Cx for submit@debbugs.gnu.org; Wed, 25 May 2022 14:50:47 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntw5k-0008DS-Lb for 55622@debbugs.gnu.org; Wed, 25 May 2022 14:50:46 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9F629160158; Wed, 25 May 2022 11:50:38 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id c379Yu_8EYmo; Wed, 25 May 2022 11:50:37 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E1E6416016E; Wed, 25 May 2022 11:50:37 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id S2kzvB1Pvx-A; Wed, 25 May 2022 11:50:37 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B666E160145; Wed, 25 May 2022 11:50:37 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------c6QGy4vLiV9FnAU7tVQDvbCc" Message-ID: <628d5f72-676f-87be-8407-ea0b46da9698@cs.ucla.edu> Date: Wed, 25 May 2022 11:50:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#55622: Bug in sort with keys and reverse, and version-sort and reverse Content-Language: en-US From: Paul Eggert To: 55622@debbugs.gnu.org, P@draigBrady.com, lploetz@gmail.com References: <27734698-c170-a2c3-dbee-e96e4b4f8386@gmail.com> <5180ddf7-dc90-1b15-db00-9a070f42cf1b@draigBrady.com> <373a951f-5696-cd87-0521-926cf3dca10d@cs.ucla.edu> Organization: UCLA Computer Science Department In-Reply-To: <373a951f-5696-cd87-0521-926cf3dca10d@cs.ucla.edu> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55622 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------c6QGy4vLiV9FnAU7tVQDvbCc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I installed the attached spelling fix to a comment in my previous patch. --------------c6QGy4vLiV9FnAU7tVQDvbCc Content-Type: text/x-patch; charset=UTF-8; name="0001-maint-spelling-fix.patch" Content-Disposition: attachment; filename="0001-maint-spelling-fix.patch" Content-Transfer-Encoding: base64 RnJvbSA4YzFhNDQ3YTM3OTBlYzc0ZWY5MTljNjBkNDY2NzNlN2JlMDYxYzcyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDI1IE1heSAyMDIyIDExOjQ5OjEzIC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gbWFpbnQ6IHNwZWxsaW5nIGZpeAoKLS0tCiBzcmMvc29ydC5jIHwgMiArLQogMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEv c3JjL3NvcnQuYyBiL3NyYy9zb3J0LmMKaW5kZXggMGE2YjU1N2FjLi5jODUwNjU2ZWYgMTAw NjQ0Ci0tLSBhL3NyYy9zb3J0LmMKKysrIGIvc3JjL3NvcnQuYwpAQCAtMjYwMSw3ICsyNjAx LDcgQEAga2V5X3dhcm5pbmdzIChzdHJ1Y3Qga2V5ZmllbGQgY29uc3QgKmdrZXksIGJvb2wg Z2tleV9vbmx5KQogICAgIGVycm9yICgwLCAwLCBfKCJvcHRpb24gJy1yJyBvbmx5IGFwcGxp ZXMgdG8gbGFzdC1yZXNvcnQgY29tcGFyaXNvbiIpKTsKIH0KIAotLyogUmV0dXJuIGVpdGhl ciB0aGUgc2Vuc2Ugb2YgRElGRiBvciBpdHMgcmV2ZXJzZSwgZGVwbmRpbmcgb24gUkVWRVJT RUQuCisvKiBSZXR1cm4gZWl0aGVyIHRoZSBzZW5zZSBvZiBESUZGIG9yIGl0cyByZXZlcnNl LCBkZXBlbmRpbmcgb24gUkVWRVJTRUQuCiAgICBJZiBSRVZFUlNFRCwgZG8gbm90IHNpbXBs eSBuZWdhdGUgRElGRiBhcyB0aGF0IGNhbiBtaXNoYW5kbGUgSU5UX01JTi4gICovCiAKIHN0 YXRpYyBpbnQKLS0gCjIuMzQuMQoK --------------c6QGy4vLiV9FnAU7tVQDvbCc-- From unknown Tue Jun 24 05:12:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 Jun 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator