From debbugs-submit-bounces@debbugs.gnu.org Tue May 24 22:21:05 2022 Received: (at submit) by debbugs.gnu.org; 25 May 2022 02:21:05 +0000 Received: from localhost ([127.0.0.1]:53950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntge1-0003XC-CO for submit@debbugs.gnu.org; Tue, 24 May 2022 22:21:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:59534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntge0-0003X4-2A for submit@debbugs.gnu.org; Tue, 24 May 2022 22:21:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntgdz-0003ED-K7 for bug-gnu-emacs@gnu.org; Tue, 24 May 2022 22:21:03 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:45729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ntgdy-0007l7-0p for bug-gnu-emacs@gnu.org; Tue, 24 May 2022 22:21:03 -0400 Received: by mail-pl1-x62a.google.com with SMTP id q18so17382095pln.12 for ; Tue, 24 May 2022 19:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:message-id:date:mime-version:content-language :content-transfer-encoding; bh=hig71wbuHBqOYY3ITyLLXct3+skWjJfmFlLYx6ir5VI=; b=mzYoby5W60suDVZKOCDpT0GW8rRMajKQPGHwDSaj7ikRyPJ+XWMQaJLcWxBjiKsZi3 HoyCgAmMeYY8uNeU4MRxGpiMvXNpbO8SmsoVnESAc965Circ/4UkIB6mCUaAsC9P6j/Q 9hroYcUEoFPZOmMaXCVSR82iCKsYIPZY6BWGPqM4zopB6jQtpviEjHkPHXsWQOe8wLzt LBiw4/B6/U9AKCSPxtH7WZd8wu83IJBsvulgn5ecU/qvUGQZ0RbPqzE7mlgAwLnUabAh Jlvnz0JinEza0Jn6HBPawguV1SqP6rhXuVXrW7mbcKFNsv7keiLDZrHGiZa7lptT2NNh M2YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:message-id:date:mime-version :content-language:content-transfer-encoding; bh=hig71wbuHBqOYY3ITyLLXct3+skWjJfmFlLYx6ir5VI=; b=7QS9AC/DypXsdrVnjHpoK029vGv9q6sZkEikQ28ke4XZU/WmpIhLvMhHxhwsLe8dXe WikYaVoHs1vpzOgpd0hjR1O9it8cwJH9WBht+C9zKUGw8DHZYBBL/keuZXBH2Z8KyTWV +FWVXjIwZUnotGG4tIrUhutdvrZBl9P90f7akrYIUD/BneSQY1M+C1vGrGDilf9oO9l/ 9MXnJDdpLofp9QZpNvcgNU29PZ24HK6jViWCyxv4vGVJGA6YMaE0xoCpgHi5GOwP/0LC 4oEip4IpaUztubI3TfVJER3YIKRjULvANboLOkmjCZZ7DpZ9XQTHjNJlHyXgGkEITWK6 3XtQ== X-Gm-Message-State: AOAM533uofFK4YujfS6BrEP1ffF4zknsJQXw3Ymk8Ce8th70zEGoy3R5 4UnkysCVe/3+U9yRz39PDajsFcxea34= X-Google-Smtp-Source: ABdhPJwTE9Y6jzt10UtQ8owSYl5IqB2F4fICgPOaHuNWXlJNHQc++QFzj66gueqKMmbmtS9Ek8X7EQ== X-Received: by 2002:a17:902:6b03:b0:161:51d6:61b with SMTP id o3-20020a1709026b0300b0016151d6061bmr6227736plk.23.1653445260130; Tue, 24 May 2022 19:21:00 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a8-20020a656408000000b003db141a5f26sm7258565pgv.1.2022.05.24.19.20.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 19:20:59 -0700 (PDT) X-Mozilla-News-Host: news://news.gmane.org:119 From: Jim Porter Subject: 29.0.50; Eshell doesn't reset `eshell-in-pipeline-p' in subcommands To: bug-gnu-emacs@gnu.org Message-ID: Date: Tue, 24 May 2022 19:20:59 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) From `emacs -Q -f eshell': ~ $ echo $eshell-in-pipeline-p ;; no output ~ $ echo ${echo $eshell-in-pipeline-p} ;; no output ~ $ echo ${echo $eshell-in-pipeline-p} | cat first (Note: in the first two cases, `eshell-in-pipeline-p' is nil, so there's no output.) The last case is surprising: it's true that the inner `echo' invocation is in a pipeline, but the pipeline is a level above it (`first' means that when `eshell-in-pipeline-p' was evaluated, it was the first command in a pipeline). Since the inner `echo' is effectively in a subshell, it makes more sense for the value of `eshell-in-pipeline-p' to be nil for the last case. While this is a seemingly-obscure issue, there is one practical effect that might bite users: currently, the Eshell implementation of `cat' only works when *not* in a pipeline. Usually, it'll just fall back to using the real system `cat' program if the Eshell version doesn't work, but on systems without `cat' (e.g. MS Windows), you get the following error: ~ $ echo ${cat file.txt} | echo Eshell’s ‘cat’ does not work in pipelines Patch forthcoming momentarily; just getting a bug number... From debbugs-submit-bounces@debbugs.gnu.org Tue May 24 23:37:09 2022 Received: (at 55620) by debbugs.gnu.org; 25 May 2022 03:37:09 +0000 Received: from localhost ([127.0.0.1]:54036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nthpd-0005WI-EI for submit@debbugs.gnu.org; Tue, 24 May 2022 23:37:09 -0400 Received: from mail-pj1-f49.google.com ([209.85.216.49]:52807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nthpc-0005W3-AM for 55620@debbugs.gnu.org; Tue, 24 May 2022 23:37:08 -0400 Received: by mail-pj1-f49.google.com with SMTP id gz24so573317pjb.2 for <55620@debbugs.gnu.org>; Tue, 24 May 2022 20:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:references:message-id:date:mime-version:in-reply-to :content-language; bh=fH0VDp+u3NvZuxah+Jsfzp6oXGoNaMT+EclLKVhSZOM=; b=GLThtLgkHQUEeLnZcS8dtqA6OkaDRmkIkh9oti2raQBp8GcaGL+j9cixpfXqtW6b/2 nqL5Wq15vhjSGtejChdV2WhHnSef4/ZQVVo6LXAst0KbXlK2ARpTlciq9rwsMDcXI7Vo wRTO5luC73nYmnSSKmf690S33vomN4PXOZwDN7hJJgQh3p6j40jot7jJMjWDPii75qrO D7R0KK4snurSqQz7Tw/sRxZcNiv5yYzfBns9LlKJ56vosIjzn8/sNEgG55lwe/Kqy6hb M9vBLno/vvQr0dP5C/jyDDgW9STKHwlDAuekxHUiXNCBw9sL8fbrth6LouGVytbeQcfw sXUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-language; bh=fH0VDp+u3NvZuxah+Jsfzp6oXGoNaMT+EclLKVhSZOM=; b=B+y6Rx81wbbtlYE72KG9vdgh/H2m33CzRFVZRyEzUKjFewPIhfajfSH10+BH+4RqT6 0ZjtJavdW6POW/e9fQmsiOrgGHDTKuDR61TVVnf5XGJcThW+rt+9KLnSae/nvTPmqpae SEpz3qOjhcWfs9LXBYQibipiacnH17Yuqrwa+sxFzMnKWqRBsWPJBPyTbBPvt6hwjeLG 2qQHHyi5JUvqOH49P0wfT5g1JfKMZ4SML7A8gVQffaxCF0Reim99q8w20neyufopsPQU 1bx99MkvD+uR0qoXpJjU3+7EDpcuK2zASzE8LEpR0Cy4l/ZEoXb03SMZUYVSJrmanFgT wo6w== X-Gm-Message-State: AOAM532wfXL7FkR6RESdzKTeyDplnMPvjQd5NxoUglGtpYNSYc2lR5AX qS+0132PcqWldH5E2xphQuCLvtiu5wY= X-Google-Smtp-Source: ABdhPJyyOOvKZCiNyvHTiPSeMupMj5WbzGUasfQf3hWFKD9yRvG0vKaVhbdbkIJSQqPAo59XV6nJ8A== X-Received: by 2002:a17:902:ea57:b0:15a:6173:87dd with SMTP id r23-20020a170902ea5700b0015a617387ddmr31140370plg.147.1653449822077; Tue, 24 May 2022 20:37:02 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id i124-20020a62c182000000b0050dc762816dsm8394985pfg.71.2022.05.24.20.37.01 for <55620@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 20:37:01 -0700 (PDT) Subject: Re: bug#55620: [PATCH] 29.0.50; Eshell doesn't reset `eshell-in-pipeline-p' in subcommands From: Jim Porter To: 55620@debbugs.gnu.org References: Message-ID: Date: Tue, 24 May 2022 20:37:01 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------4081FB3F3431423B9D88C44E" Content-Language: en-US X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55620 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------4081FB3F3431423B9D88C44E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit (Originally mis-sent with the wrong email address.) Attached is a patch with tests to fix this. Note that I reset `eshell-in-pipeline-p' in two places: 1. `eshell-subcommand-bindings': This handles any case where a subcommand is invoked. This can happen with the following syntaxes: {CMD}, ${CMD}, and $. 2. `eshell-command-to-value': This handles cases where a command is run synchronously. This can happen with some of the syntaxes mentioned above: {CMD} and ${CMD}. However, it can also happen for Lisp forms like (LISP) and $(LISP). (Most Lisp forms aren't likely to consult `eshell-in-pipeline-p', but if you were calling an Eshell built-in command using Lisp syntax, you might run into this issue.) --------------4081FB3F3431423B9D88C44E Content-Type: text/plain; charset=UTF-8; name="0001-Reset-eshell-in-pipeline-p-when-interpolating-comman.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Reset-eshell-in-pipeline-p-when-interpolating-comman.pa"; filename*1="tch" RnJvbSAzYTE4MTk5ZmNjODkxOTIyMDg5MmMyNWM2NDk3MGM3MzQzYzllNjNmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMjQgTWF5IDIwMjIgMTg6NTY6NTAgLTA3MDAKU3ViamVjdDogW1BB VENIXSBSZXNldCAnZXNoZWxsLWluLXBpcGVsaW5lLXAnIHdoZW4gaW50ZXJwb2xhdGluZyBj b21tYW5kcwoKKiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsIChlc2hlbGwtc3ViY29tbWFuZC1i aW5kaW5ncykKKGVzaGVsbC1jb21tYW5kLXRvLXZhbHVlKTogU2V0ICdlc2hlbGwtaW4tcGlw ZWxpbmUtcCcgdG8gbmlsLgoKKiB0ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbAoo ZXNoZWxsLXRlc3Qvc3ViY29tbWFuZC1yZXNldC1pbi1waXBlbGluZSkKKGVzaGVsbC10ZXN0 L2xpc3AtcmVzZXQtaW4tcGlwZWxpbmUpOiBOZXcgdGVzdHMgKGJ1ZyM1NTYyMCkuCi0tLQog bGlzcC9lc2hlbGwvZXNoLWNtZC5lbCAgICAgICAgICAgfCAgNCArKystCiB0ZXN0L2xpc3Av ZXNoZWxsL2VzaGVsbC10ZXN0cy5lbCB8IDI5ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrCiAyIGZpbGVzIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gtY21kLmVsIGIvbGlzcC9lc2hlbGwvZXNo LWNtZC5lbAppbmRleCA3M2MyNTA2MzJjLi43NzVlNGMxMDU3IDEwMDY0NAotLS0gYS9saXNw L2VzaGVsbC9lc2gtY21kLmVsCisrKyBiL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKQEAgLTI1 Niw2ICsyNTYsNyBAQCBlc2hlbGwtZGVmZXJyYWJsZS1jb21tYW5kcwogCiAoZGVmY3VzdG9t IGVzaGVsbC1zdWJjb21tYW5kLWJpbmRpbmdzCiAgICcoKGVzaGVsbC1pbi1zdWJjb21tYW5k LXAgdCkKKyAgICAoZXNoZWxsLWluLXBpcGVsaW5lLXAgbmlsKQogICAgIChkZWZhdWx0LWRp cmVjdG9yeSBkZWZhdWx0LWRpcmVjdG9yeSkKICAgICAocHJvY2Vzcy1lbnZpcm9ubWVudCAo ZXNoZWxsLWNvcHktZW52aXJvbm1lbnQpKSkKICAgIkEgbGlzdCBvZiBgbGV0JyBiaW5kaW5n cyBmb3Igc3ViY29tbWFuZCBlbnZpcm9ubWVudHMuIgpAQCAtOTA3LDcgKzkwOCw4IEBAIGVz aGVsbC1kby1jb21tYW5kLXRvLXZhbHVlCiAoZGVmbWFjcm8gZXNoZWxsLWNvbW1hbmQtdG8t dmFsdWUgKG9iamVjdCkKICAgIlJ1biBPQkpFQ1Qgc3luY2hyb25vdXNseSwgcmV0dXJuaW5n IGl0cyByZXN1bHQgYXMgYSBzdHJpbmcuCiBSZXR1cm5zIGEgc3RyaW5nIGNvbXByaXNpbmcg dGhlIG91dHB1dCBmcm9tIHRoZSBjb21tYW5kLiIKLSAgYChsZXQgKCh2YWx1ZSAobWFrZS1z eW1ib2wgImVzaGVsbC10ZW1wIikpKQorICBgKGxldCAoKHZhbHVlIChtYWtlLXN5bWJvbCAi ZXNoZWxsLXRlbXAiKSkKKyAgICAgICAgIChlc2hlbGwtaW4tcGlwZWxpbmUtcCBuaWwpKQog ICAgICAoZXNoZWxsLWRvLWNvbW1hbmQtdG8tdmFsdWUgLG9iamVjdCkpKQogCiA7OztfKiBJ dGVyYXRpdmUgZXZhbHVhdGlvbgpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VzaGVsbC9lc2hl bGwtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbAppbmRleCBj MGFmZmVkODBhLi5hYjVkNzNkNDc5IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2Vz aGVsbC10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbApA QCAtMTMwLDYgKzEzMCwzNSBAQCBlc2hlbGwtdGVzdC9waXBlLXN1YmNvbW1hbmQtd2l0aC1w aXBlCiAgICAoZXNoZWxsLWNvbW1hbmQtcmVzdWx0LXAgImVjaG8gJHsqZWNobyBoaSB8ICpj YXR9IHwgKmNhdCIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiaGkiKSkpCiAKKyhl cnQtZGVmdGVzdCBlc2hlbGwtdGVzdC9zdWJjb21tYW5kLXJlc2V0LWluLXBpcGVsaW5lICgp CisgICJDaGVjayB0aGF0IHN1YmNvbW1hbmRzIHJlc2V0IGBlc2hlbGwtaW4tcGlwZWxpbmUt cCcuIgorICAoc2tpcC11bmxlc3MgKGV4ZWN1dGFibGUtZmluZCAiY2F0IikpCisgIChkb2xp c3QgKHRlbXBsYXRlICcoImVjaG8geyVzfSB8ICpjYXQiCisgICAgICAgICAgICAgICAgICAg ICAgImVjaG8gJHslc30gfCAqY2F0IgorICAgICAgICAgICAgICAgICAgICAgICIqY2F0ICQ8 JXM+IHwgKmNhdCIpKQorICAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtdGVzdC1jb21tYW5k LXJlc3VsdAorICAgICAgICAgICAgICAgICAgICAoZm9ybWF0IHRlbXBsYXRlICJlY2hvICRl c2hlbGwtaW4tcGlwZWxpbmUtcCIpKQorICAgICAgICAgICAgICAgICAgIG5pbCkpCisgICAg KHNob3VsZCAoZXF1YWwgKGVzaGVsbC10ZXN0LWNvbW1hbmQtcmVzdWx0CisgICAgICAgICAg ICAgICAgICAgIChmb3JtYXQgdGVtcGxhdGUgImVjaG8gfCBlY2hvICRlc2hlbGwtaW4tcGlw ZWxpbmUtcCIpKQorICAgICAgICAgICAgICAgICAgICJsYXN0IikpCisgICAgKHNob3VsZCAo ZXF1YWwgKGVzaGVsbC10ZXN0LWNvbW1hbmQtcmVzdWx0CisgICAgICAgICAgICAgICAgICAg IChmb3JtYXQgdGVtcGxhdGUgImVjaG8gJGVzaGVsbC1pbi1waXBlbGluZS1wIHwgZWNobyIp KQorICAgICAgICAgICAgICAgICAgICJmaXJzdCIpKQorICAgIChzaG91bGQgKGVxdWFsIChl c2hlbGwtdGVzdC1jb21tYW5kLXJlc3VsdAorICAgICAgICAgICAgICAgICAgICAoZm9ybWF0 IHRlbXBsYXRlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgImVjaG8gfCBlY2hvICRl c2hlbGwtaW4tcGlwZWxpbmUtcCB8IGVjaG8iKSkKKyAgICAgICAgICAgICAgICAgICAidCIp KSkpCisKKyhlcnQtZGVmdGVzdCBlc2hlbGwtdGVzdC9saXNwLXJlc2V0LWluLXBpcGVsaW5l ICgpCisgICJDaGVjayB0aGF0IGludGVycG9sYXRlZCBMaXNwIGZvcm1zIHJlc2V0IGBlc2hl bGwtaW4tcGlwZWxpbmUtcCcuIgorICAoc2tpcC11bmxlc3MgKGV4ZWN1dGFibGUtZmluZCAi Y2F0IikpCisgIChkb2xpc3QgKHRlbXBsYXRlICcoImVjaG8gKCVzKSB8ICpjYXQiCisgICAg ICAgICAgICAgICAgICAgICAgImVjaG8gJCglcykgfCAqY2F0IikpCisgICAgKHNob3VsZCAo ZXF1YWwgKGVzaGVsbC10ZXN0LWNvbW1hbmQtcmVzdWx0CisgICAgICAgICAgICAgICAgICAg IChmb3JtYXQgdGVtcGxhdGUgImZvcm1hdCBcIiVzXCIgZXNoZWxsLWluLXBpcGVsaW5lLXAi KSkKKyAgICAgICAgICAgICAgICAgICAibmlsIikpKSkKKwogKGVydC1kZWZ0ZXN0IGVzaGVs bC10ZXN0L3JlZGlyZWN0LWJ1ZmZlciAoKQogICAiQ2hlY2sgdGhhdCBwaXBpbmcgdG8gYSBi dWZmZXIgd29ya3MiCiAgICh3aXRoLXRlbXAtYnVmZmVyCi0tIAoyLjI1LjEKCg== --------------4081FB3F3431423B9D88C44E-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 25 08:13:55 2022 Received: (at 55620) by debbugs.gnu.org; 25 May 2022 12:13:55 +0000 Received: from localhost ([127.0.0.1]:54531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntptj-0006as-2d for submit@debbugs.gnu.org; Wed, 25 May 2022 08:13:55 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntpth-0006aa-KY for 55620@debbugs.gnu.org; Wed, 25 May 2022 08:13:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Pc8chrOk2VWv/nhTeAt0vnKI8LeSKdZjSGOiL9KfEfs=; b=JyLWMix2S/ABYf/jVrGDEBrQqe Vm+nBQklOnR+h48Y508PqpO9ZHdpN4G+r4OzH1OoGL1NU59FWh5OjGiVlKyDR4GqNCp1T41TSRaHx OwLwMyQM9WpYT4KUjCNHil0+bO1rA6s4ujfhypsGN+zwrg1Ds8zfz42SFsVYSGYZW6l0=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntptZ-0001CI-FY; Wed, 25 May 2022 14:13:47 +0200 From: Lars Ingebrigtsen To: Jim Porter Subject: Re: bug#55620: 29.0.50; Eshell doesn't reset `eshell-in-pipeline-p' in subcommands References: X-Now-Playing: Nils Petter =?utf-8?Q?Molv=C3=A6r's?= _Solid Ether_: "Ligotage" Date: Wed, 25 May 2022 14:13:44 +0200 In-Reply-To: (Jim Porter's message of "Tue, 24 May 2022 20:37:01 -0700") Message-ID: <87ee0hernr.fsf_-_@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > Attached is a patch with tests to fix this. Note that I reset > `eshell-in-pipeline-p' in two places: Thanks; pushed to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55620 Cc: 55620@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > Attached is a patch with tests to fix this. Note that I reset > `eshell-in-pipeline-p' in two places: Thanks; pushed to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 25 08:13:59 2022 Received: (at control) by debbugs.gnu.org; 25 May 2022 12:13:59 +0000 Received: from localhost ([127.0.0.1]:54534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntptn-0006b9-93 for submit@debbugs.gnu.org; Wed, 25 May 2022 08:13:59 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntptl-0006ak-UE for control@debbugs.gnu.org; Wed, 25 May 2022 08:13:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hdhwfvHrk8Y4I6q28Pyohb3IRF8MgTklZo6g1rShckE=; b=FpaGKuy523t7sczkAZLUGYnWZV zP4ZhtMnou6q4Z2Jbmp3nwPKp0VLlNIfmXKm50dfPRsVFuPl1v1rfLEkBB826/wTcuEIvNnVfsRWL NgvGA6cQZwQOKj0VbCdSMVjB9oJSD+LsTXi8dTQAunajO5j2tBgOLuC80bxhyrejRH3Q=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntpte-0001CQ-7Q for control@debbugs.gnu.org; Wed, 25 May 2022 14:13:52 +0200 Date: Wed, 25 May 2022 14:13:49 +0200 Message-Id: <87czg1ernm.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #55620 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 55620 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 55620 29.1 quit From unknown Mon Jun 23 18:33:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 Jun 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator