From unknown Mon Jun 23 13:09:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#55619 <55619@debbugs.gnu.org> To: bug#55619 <55619@debbugs.gnu.org> Subject: Status: [PATCH] gnu: smlnj: Fix use of Ctrl-c in sml REPL. Reply-To: bug#55619 <55619@debbugs.gnu.org> Date: Mon, 23 Jun 2025 20:09:05 +0000 retitle 55619 [PATCH] gnu: smlnj: Fix use of Ctrl-c in sml REPL. reassign 55619 guix-patches submitter 55619 Foo Chuan Wei severity 55619 normal tag 55619 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue May 24 21:45:20 2022 Received: (at submit) by debbugs.gnu.org; 25 May 2022 01:45:20 +0000 Received: from localhost ([127.0.0.1]:53920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntg5Q-0000Pq-5R for submit@debbugs.gnu.org; Tue, 24 May 2022 21:45:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:51946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntg5L-0000Pg-8d for submit@debbugs.gnu.org; Tue, 24 May 2022 21:45:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntg5I-0002zi-Hm for guix-patches@gnu.org; Tue, 24 May 2022 21:45:14 -0400 Received: from mail-tyzapc01olkn2077.outbound.protection.outlook.com ([40.92.107.77]:2690 helo=APC01-TYZ-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntg5E-0001vj-HQ for guix-patches@gnu.org; Tue, 24 May 2022 21:45:11 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q6QzP+zK2q+NTKYTVc2ScXTRjzX2ADNzfmrRCWv7yCvxxzzvZ2sHbZqE+fcaVAG3XSs2AEIvPdeccJkRffb/Tg7Rez1ttcx0l8R8x4diH2KhjryL47w8j/6nqkAcECW0leXWttShDJt5O/kAcb4ZGgbGTxauT70wBDUJOkHDRUOdbyouU2p6O0ReSAEgJey6KFz3NXyUrRPxaL0eoKM0feHe3LsBg7Hw086opwv524WK2GNrt53mQsZDjXOJQohlgcIOpj/AKDdKtkunBDSOx6wMwGZilSOEBEvZKLD54u7etgqrrq8btZcBAauLsWdfpRsWxydRiIHBA8POqY0D8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q/tqM25bi0EscSULi+VoACp2rEtTF4rL2QfwCuzxtHo=; b=M2OWu+mBLsJrDXedAc96n9xGB+G9TuqIGAFun2UgGfNpqAJLoZKTLPIOfMTDTh9XCNrKaMBkq18p9Cqy5yjf3tvI5Wcgiei4EFVxlHTMt5C58OjqIrvA9q9RbGXYUHRCnbRCyygbQF2NOC2V2EC/+oNxJCfxI8CEjnNd7c7fZjze4lMl6G/PeZM1A+QZDa1CnXsawKa+AHr+tNTLt2qRjHSOJlc5TsHBPQbQL0/QM38lF72K941lbyqP4FMGD6peDE3dokfPR6TEz/BcDTRdDHqaaYV5DW1ygE4duljxkZiJhkz1etd1nPHlOW8q0qWtsXiv5dATrag0C/xENLXixQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q/tqM25bi0EscSULi+VoACp2rEtTF4rL2QfwCuzxtHo=; b=dL3E5ILZGrP3qnhDoMlHE3q7lbcvHqJIn1a8zR2J4ezpgqzzWnd2ZidADcvoonh0jf3c7/ga6Y4OkfJDWAQCYIoLCTWCfb9D6HL3bCedOzHSadOSbogGBtV3/VAueOIIwH5rFZchiBfXqh6Cif0SBQ9XvUDVN3KaqHLUXW2JAAW486KdTr7Tr9cMM94maBYrG1bkn5BnMjbPHCwLDPauWanErEGQ7YHqSz01R7gJfFYEyT6fXuzLzDUN4Wc2yUgWZK+5ssxCD7zNpne5QWDURPsgn4d1cpfde461DRpxAFWPU5FAOEYUPuTYNqZnYQLHUXQUDsaqFsxEzc/TrKEM1Q== Received: from PU1PR01MB2155.apcprd01.prod.exchangelabs.com (2603:1096:803:1c::21) by TY2PR0101MB3568.apcprd01.prod.exchangelabs.com (2603:1096:404:8007::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 01:45:04 +0000 Received: from PU1PR01MB2155.apcprd01.prod.exchangelabs.com ([fe80::fc2a:6e5a:d929:f3a7]) by PU1PR01MB2155.apcprd01.prod.exchangelabs.com ([fe80::fc2a:6e5a:d929:f3a7%6]) with mapi id 15.20.5273.023; Wed, 25 May 2022 01:45:04 +0000 Date: Wed, 25 May 2022 01:44:59 +0000 From: Foo Chuan Wei To: guix-patches@gnu.org Subject: [PATCH] gnu: smlnj: Fix use of Ctrl-c in sml REPL. Message-ID: Mail-Followup-To: guix-patches@gnu.org Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-TMN: [aVNKVe0aeLcf7oyGci1kYOhLkutNmfqs] X-ClientProxiedBy: SG2PR06CA0188.apcprd06.prod.outlook.com (2603:1096:4:1::20) To PU1PR01MB2155.apcprd01.prod.exchangelabs.com (2603:1096:803:1c::21) X-Microsoft-Original-Message-ID: <20220525014459.rut6k23lhrvnwe4k@main> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ebf5ef70-7005-4b79-b8f8-08da3df02f22 X-MS-TrafficTypeDiagnostic: TY2PR0101MB3568:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C39QraMgM3lZPy5h41y7n/Bojf5VX9pm+BRZK+eVYlF/5CdWtB+6GjljrNDXfpUxZ3LRs0nDcPt+ZhMXXxKsT4zc42insGNGvNqOOe6ZRxTgesLg7bKcJq9Kz/uWhFle4saXVLXayQ3UmxWqTAVUi2exm+ziqGzfQ+thiJCDB7XplCB9BpdWZ2HsJo6Wt51TM2Ucj3fKvG+sAqIgwusAqb3w7WdpmkAKDso2ymVOvAcX9+GwLBjQps42ZH3XE5KuRM0Jr4QBeY5huLJsJbxmtNqbjwrAjgiIfouaXzrCnNQjpf3Tftvwc/w9o60ok2AzQvh4o+oznA5kmjzCHy2xW90t7IDq7nzIxZfSkTPiw2Mt4bvavvNJTPz3PMeOty+RWdrtVovm6lZsADTtigLVOOy9c+Fr8T3GZc84qbpQ4DXn3ISEoKioGLE5aaxaLkEOvCF5arp0EL54syg2q7Lt5pHitS4/GmrAsMaUUZZj/VqE7d0ubaBxBpRcmRI+6rXs5glAaA/uSgEKJlf90/tZ3Ib3GGVOXcqzAUq7LbjRmzR7IrU3RI2VPyqtyDEl2pyauSFqvA6FbV5e0n8TMVLMAn350OPMlBRbJZNpYZkThIc6Qogmsr7agA78iKK1vQ2I X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akdKSHpIREcxVVp5WVVjSW1zZ1pPcDlsRVEwZlF6QzlzRDlFblBOR213aUdH?= =?utf-8?B?ZEZvZGZDUER1VmJwY2F2cHZINHpRaldacGZaR0J2bUtwRHVRTHlQUU9YdTNF?= =?utf-8?B?WUVUR0ZRQzZkaHFoM1ZQTHBSVkt2UW5YT0h3dTlwYjlGRnQ5TFpoWkJhQytT?= =?utf-8?B?ZllvQU1qTytEVWtsMGEvMFB2aGhJeHo0cFV6emtHRXI4bEkvVmpJeGs1aGky?= =?utf-8?B?UWFONEVkMkt6WUVQQnZVcjJZTm0rTlhRQVlHeFdweFc0dzNCcHltWXE3UmQ5?= =?utf-8?B?WVF4clVYNEI1ekdvSlRhVFdDNWVqTExOekRoREs3T0c3MlJueTNYMEc5OWRE?= =?utf-8?B?ZjJPTDkvcGhFekNvQUZCaHY4QXRleGJxelc5UWY0KzR0cEkyMW1EUlZrakEy?= =?utf-8?B?UmIvTlEzM2hhMzVINjJNcjUxYU9oUS9aajBObGl3MmZxWm9YekR2R0JqZ3o2?= =?utf-8?B?WkwzRXFJZENyb1RaOXRydlNrUlVVZUZxYnZUNXJqVDRMMUxnZkJLS1Yzd0V2?= =?utf-8?B?bXV0OG9KY2xWdVpuWmJjb09OMjVkWi9CZ2ZmU0tsV2x0U1VCZTBRdDhyZjAz?= =?utf-8?B?MTloVC9JMVE0ajcrYUNDTTVqRGkvZU11dzhWK0crWGtBL3NRQndZUWFqMVJ4?= =?utf-8?B?MkltWExyb1BXbUtwRzAvK1F1Rmk5bDBTZHZTQzgyQmloZ1lzQm5yY1BLUDBH?= =?utf-8?B?MlVFTnRNTnlweVc2WFBqWU9JVDRxYjVKdk5EWHdSUHRFQjArUnhKT3Bsb1Nw?= =?utf-8?B?cGZTaW5vcVJXWFVNUnpvSGk1RkNDRG1sKzJJT3lMbTFvSi9zVEUrWTZSMlVG?= =?utf-8?B?MjhyR0p4dUp3eTRVL3NJVDIySlR4bTNyL3poNzA5Tmp2TVhqTXBscmJvTGlt?= =?utf-8?B?eFJwRDVmUmNoeGhraVhYMXhjTGE0MmxjYkRNbTA3UWp3MjFST0dyNExmZjZZ?= =?utf-8?B?bTNJZVBKVjNHR2hVL1F4UUhVQnBuWlcra0M3dVZDOFJxT1FLb2pQREhNZWt0?= =?utf-8?B?TVY2MndHYzB2NCtKdk53eWxMWWRodDh6aEtEeUtWZkxwelpsR2lta0pVNmhO?= =?utf-8?B?L0p5SVdkdmxrdnBkN0U2MDFvMnFGVVQzWks3NEF2eEJLZ0hoL01sK3hrZzRJ?= =?utf-8?B?TS9NSVB1cFIxOXhTVTFDaWxWRllpMDhuSnNVWTIxTENrRjJmbThQRzQzbG1O?= =?utf-8?B?UHRsamxoKzBjTDRoYU1TeVVWK2RhV1VFbUQwaVA3YjRyTGVGck1GWWJMcklZ?= =?utf-8?B?dzRLSjVmZEVHQzc4RjhPZUQyMzJGYWNoUElyNDBEL2xwdFZ5RHNMd21KTXBC?= =?utf-8?B?SHdMTUZvUnN1bTdSNC9HanpNcFJKVm9FT3RNOGgyZXZJeURRRysyNURkTGZY?= =?utf-8?B?aUtqR3FaWlRmancxZ0FyM2s1cUZGdWxvT3Y3dUtzM09IV3RleTBkam1OSEtr?= =?utf-8?B?b3QzWEMveVRzWXV1Umg2Z1p5aFVUNHNqMGFBKzd2YnF6VlV6WTJBcTViZ3R6?= =?utf-8?B?ekRYQ3dKZG0vMUJES3d0L0pHR1VxNEQ4U256YTJzWGdxdnhQQWdFTGRZVUV4?= =?utf-8?B?dERVWWt1N2lFQkV2bFN5OU1Ib0YrSWtBY3lFYnpLWlJXbnlBNVBpVVpldmtx?= =?utf-8?B?Q1JsVWYzdHlnOCtuU3ZUQlUzV1RMNTlaMUlKMEhsOHBtS1RYdTZ3L1VER3dJ?= =?utf-8?B?V0hvSVRDZzg3bEsvY1V1MG5jMFFMTWVSNXVrSTE1M3k3cEdTZ1NsNW4yUlFi?= =?utf-8?B?NWR2VGtBNEZRMFJSa2ptcUxSNWJEUEdFZXB1ejJBV2pUUHo0dGJibjgrK203?= =?utf-8?B?d0UwVndCa1BvL0MyTU8xV1RIaHdsZW9qZk90TWltNVlZZndWZ1Zsa2g4Mmpq?= =?utf-8?B?dkxmU3hySHZsd01WcStUUlZJTkVaM0cvMjgwcE80ZkQxUk1NUENidm9qVmNL?= =?utf-8?Q?o6F5/5bv4TeAf83B8GcGS0Jvbqyumys9?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-d8e84.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: ebf5ef70-7005-4b79-b8f8-08da3df02f22 X-MS-Exchange-CrossTenant-AuthSource: PU1PR01MB2155.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 01:45:03.7657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR0101MB3568 Received-SPF: pass client-ip=40.92.107.77; envelope-from=chuanwei.foo@hotmail.com; helo=APC01-TYZ-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/sml.scm (smlnj): Fix use of Ctrl-c in sml REPL. --- Related mailing list thread: https://lists.gnu.org/archive/html/guix-devel/2022-05/msg00209.html ("Why does sh in the build environment ignore SIGINT and SIGQUIT?") gnu/packages/sml.scm | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/gnu/packages/sml.scm b/gnu/packages/sml.scm index 04411c02c3..94a65961d6 100644 --- a/gnu/packages/sml.scm +++ b/gnu/packages/sml.scm @@ -175,10 +175,22 @@ function interface, and a symbolic debugger.") "sml.boot.amd64-unix/SMLNJ-BASIS/.cm/amd64-unix/basis-common.cm")) ;; Build. - (invoke "./config/install.sh" "-default" - (if (string=? "i686-linux" ,(%current-system)) - "32" - "64")) + ;; The `sml` executable built by this package somehow inherits the + ;; signal dispositions of the shell where it was built. If SIGINT + ;; is ignored in the shell, the resulting `sml` will also ignore + ;; SIGINT. This will break the use of Ctrl-c for interrupting + ;; execution in the SML/NJ REPL. + ;; Here, we use Guile's `system` procedure instead of Guix's + ;; `invoke` because `invoke` uses Guile's `system*`, which causes + ;; SIGINT and SIGQUIT to be ignored. + (let ((exit-code + (system (string-append "./config/install.sh -default " + (if (string=? "i686-linux" + ,(%current-system)) + "32" + "64"))))) + (unless (zero? exit-code) + (error (format #f "Exit code: ~a" exit-code)))) ;; Undo the binary patch. (for-each base-commit: d129d962e437fd215c5e9428fc1b26e2d72ffbda -- 2.25.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 21:19:37 2022 Received: (at 55619-done) by debbugs.gnu.org; 5 Jun 2022 01:19:37 +0000 Received: from localhost ([127.0.0.1]:59839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxevY-0002xR-Sl for submit@debbugs.gnu.org; Sat, 04 Jun 2022 21:19:37 -0400 Received: from tobias.gr ([80.241.217.52]:56284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxevT-0002xD-7j for 55619-done@debbugs.gnu.org; Sat, 04 Jun 2022 21:19:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=KCxPGlYkZI/Hw OzwvtEQyKoSBREu+wZ3RQWBysjVA6k=; h=date:subject:to:from; d=tobias.gr; b=CzYrOFIdFHRI8zn8BvZJ9NKK/O/WDiUY1eebnzpWVcxszQ1+XZpw5vhRKK5RwFaWom7I VivJI0b04G77QZzXO2P7LiXZ91EKMZ+jWjmbQ0XNZjtX9gpZgpSm5wfnV0j8gKTaUMNIoo lzZOWI/McR5n1awM1WnzfbboMyAG7Rn5r6U6rv04gswWYrMfkAE3yTI0rruAhdZ6hOi28X eqDH0qW1xBz584IPVKs79IDlgtIo/q95VfpeM0KaCit7CXu1eYYj1Jsb0lXM5DTDYQ2KOR VuKq3FFqH8miNOw/u72xMerQbO1YwL6VvEo78VGV/ShKJ6NacstVa5acafMIC4eA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id d9574946 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for <55619-done@debbugs.gnu.org>; Sun, 5 Jun 2022 01:19:28 +0000 (UTC) From: Tobias Geerinckx-Rice To: 55619-done@debbugs.gnu.org Subject: Re: [PATCH] gnu: smlnj: Fix use of Ctrl-c in sml REPL. Date: Sun, 05 Jun 2022 03:12:06 +0200 BIMI-Selector: v=BIMI1; s=default; Message-ID: <87tu8zhpnu@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55619-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi! Thanks for the patch and the perfect comment. The only thing I tweaked was the commit message, to reflect the=20 =E2=80=98what=E2=80=99 rather than (just) the =E2=80=98why=E2=80=99: * gnu/packages/sml.scm (smlnj): Replace INVOKE with SYSTEM which has more favourable signal dispositions. Tested on a Guix System that could reproduce the original bug &=20 pushed as 62da327848311a75723f16642c20d2925919237e. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYpwE1Q0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW155vwBAJecdxeov2MqL00C+tjxkQ5fw3wJaNq3sYUGBm2E 3xuqAQCrqCk06Q93oKJz6XzMz3lc/S9Tmv4Q79gtNoKLSFB9Bg== =93Ai -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Jun 23 13:09:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Jul 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator