GNU bug report logs - #55602
[PATCH 0/2] Move (gnu platform) and friends to guix, and fix linux module build system.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#55602: closed ([PATCH 0/2] Move (gnu platform) and friends to
 guix, and fix linux module build system.)
Date: Wed, 25 May 2022 07:32:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 25 May 2022 09:31:07 +0200
with message-id <877d6axe4k.fsf <at> gnu.org>
and subject line Re: bug#55602: [PATCH 0/2] Move (gnu platform) and friends to guix, and fix linux module build system.
has caused the debbugs.gnu.org bug report #55602,
regarding [PATCH 0/2] Move (gnu platform) and friends to guix, and fix linux module build system.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
55602: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55602
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: guix-patches <at> gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH 0/2] Move (gnu platform) and friends to guix,
 and fix linux module build system.
Date: Mon, 23 May 2022 22:29:02 +0200

Hi everyone,

The linux-module-build-system broke because we're now using platform
records, and the accessor platform-glibc-dynamic-linker is syntax.
The build system cannot invoke it through module-ref shenanigans (done
previously to avoid some circular dependencies), because as everyone
knows syntax expands at compile/expand-time only.  Since the platform
code has moved to its own cozy (gnu platform) in the meantime, I
figured that it could very well be simply use-module'd, but then it'd
have to end up in (guix ...) to follow the rule that guix modules
should never directly use-module gnu modules.  Hence this quite big
patchset.

This addresses the same issue as [1].

[1] https://issues.guix.gnu.org/55591

Best,
Josselin Poiret (2):
  Move (gnu platform) and (gnu platforms ...) to guix/.
  build-system: linux-module: Directly use-module (guix platform).

 doc/guix.texi                       | 2 +-
 etc/release-manifest.scm            | 2 +-
 gnu/ci.scm                          | 2 +-
 gnu/image.scm                       | 2 +-
 gnu/local.mk                        | 8 --------
 gnu/packages/bioinformatics.scm     | 2 +-
 gnu/packages/bootstrap.scm          | 2 +-
 gnu/packages/cross-base.scm         | 2 +-
 gnu/packages/instrumentation.scm    | 2 +-
 gnu/packages/linux.scm              | 2 +-
 gnu/system/image.scm                | 2 +-
 gnu/system/images/hurd.scm          | 2 +-
 gnu/system/images/novena.scm        | 2 +-
 gnu/system/images/pine64.scm        | 2 +-
 gnu/system/images/pinebook-pro.scm  | 2 +-
 gnu/system/images/rock64.scm        | 2 +-
 guix/build-system/linux-module.scm  | 4 ++--
 {gnu => guix}/platform.scm          | 4 ++--
 {gnu => guix}/platforms/arm.scm     | 5 ++---
 {gnu => guix}/platforms/hurd.scm    | 5 ++---
 {gnu => guix}/platforms/mips.scm    | 5 ++---
 {gnu => guix}/platforms/powerpc.scm | 5 ++---
 {gnu => guix}/platforms/riscv.scm   | 5 ++---
 {gnu => guix}/platforms/s390.scm    | 5 ++---
 {gnu => guix}/platforms/x86.scm     | 5 ++---
 guix/scripts/build.scm              | 2 +-
 guix/scripts/system.scm             | 2 +-
 guix/self.scm                       | 2 +-
 28 files changed, 36 insertions(+), 51 deletions(-)
 rename {gnu => guix}/platform.scm (98%)
 rename {gnu => guix}/platforms/arm.scm (92%)
 rename {gnu => guix}/platforms/hurd.scm (90%)
 rename {gnu => guix}/platforms/mips.scm (90%)
 rename {gnu => guix}/platforms/powerpc.scm (92%)
 rename {gnu => guix}/platforms/riscv.scm (91%)
 rename {gnu => guix}/platforms/s390.scm (90%)
 rename {gnu => guix}/platforms/x86.scm (94%)

-- 
2.36.0

[Message part 3 (message/rfc822, inline)]

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 55602-done <at> debbugs.gnu.org
Subject: Re: bug#55602: [PATCH 0/2] Move (gnu platform) and friends to guix,
 and fix linux module build system.
Date: Wed, 25 May 2022 09:31:07 +0200

Hello,

> knows syntax expands at compile/expand-time only.  Since the platform
> code has moved to its own cozy (gnu platform) in the meantime, I
> figured that it could very well be simply use-module'd, but then it'd
> have to end up in (guix ...) to follow the rule that guix modules
> should never directly use-module gnu modules.  Hence this quite big
> patchset.

Oops sorry for not noticing it, pushed!

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.