From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 22:01:23 2010 Received: (at submit) by debbugs.gnu.org; 11 Feb 2010 03:01:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NfPIw-00072n-Ui for submit@debbugs.gnu.org; Wed, 10 Feb 2010 22:01:23 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NfPIu-00072e-PL for submit@debbugs.gnu.org; Wed, 10 Feb 2010 22:01:21 -0500 Received: from mx10.gnu.org ([199.232.76.166]:52800) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NfPIt-0002ct-Nk for submit@debbugs.gnu.org; Wed, 10 Feb 2010 22:01:19 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NfPIs-00067S-3j for submit@debbugs.gnu.org; Wed, 10 Feb 2010 22:01:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00, DNS_FROM_RFC_POST,UNPARSEABLE_RELAY autolearn=no version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:47402) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NfPIr-00067O-S4 for submit@debbugs.gnu.org; Wed, 10 Feb 2010 22:01:17 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NfPIr-0000W6-8k for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2010 22:01:17 -0500 Received: from [199.232.76.173] (port=57036 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NfPIq-0000Vy-Vn for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2010 22:01:17 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NfPIp-00067C-5t for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2010 22:01:16 -0500 Received: from mail-vw0-f41.google.com ([209.85.212.41]:48736) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NfPIo-000678-Qp for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2010 22:01:15 -0500 Received: by vws4 with SMTP id 4so279269vws.0 for ; Wed, 10 Feb 2010 19:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:content-type :content-transfer-encoding:subject:date:message-id:to:mime-version :x-pgp-agent:x-mailer; bh=DldseJDldri//Igq7+SJyKHihxRqcvVFspzrrtE0Xvc=; b=IiubIwZHrygAytGIMIzB2p/lJXOvc41OHmxnBfE9YXlVVjOxujBj/kSqb38B7oFOEc KkqQge/xg7tZoFTblulfCPX7sYm5dT/sAnJgzA92D+bs21ebm6PXDrQ02YOMihoiYozt AygFm7CyMGbehNHFyfkWrcSSCyx5BNqInW9A0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:content-type:content-transfer-encoding:subject:date:message-id :to:mime-version:x-pgp-agent:x-mailer; b=Zv7oaA63sypVNH3vbAwoVmZwX8IoXQJhxX3/8zw5c9FVfBfCxKBcE2hz1uXxbAYORH B0mDKTAYy4jF+Q+dR4pQ0MG6c5dg/HQy4rm/bvVHsgKvLeAQp740Eej6quVd2FJyMkvJ 93Z4GTYhD9iz7/80m7vpoixBK/HiFQB660C+Y= Received: by 10.220.107.228 with SMTP id c36mr742840vcp.191.1265857273177; Wed, 10 Feb 2010 19:01:13 -0800 (PST) Received: from ?192.168.1.42? (pool-96-236-181-152.pitbpa.east.verizon.net [96.236.181.152]) by mx.google.com with ESMTPS id 24sm829705vws.16.2010.02.10.19.01.10 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 10 Feb 2010 19:01:11 -0800 (PST) From: David Reitter Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-86--212743485" Content-Transfer-Encoding: 7bit Subject: 23.1.92; parens matching in c-mode broken Date: Wed, 10 Feb 2010 22:01:05 -0500 Message-Id: <4B60ED87-9CF5-464A-AE3F-C948ADB1C4D2@gmail.com> To: Bug-Gnu-Emacs Mime-Version: 1.0 (Apple Message framework v1077) X-Pgp-Agent: GPGMail 1.2.3 X-Mailer: Apple Mail (2.1077) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.8 (----) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-86--212743485 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Parens matching in C mode is sometimes surprising. In the example below, double-clicking on either of the first two opening parentheses=20 will mark the text until the " hyper_modifier : 0)", but that is = correct only for the second paren, while the first one is unmatched due to a = space following the backslash. #define EV_MODIFIERS(e) \ ((([e modifierFlags] & NSHelpKeyMask) ? \=20 hyper_modifier : 0) \ =20 ... It would be more useful if an "unmatched parentheses" was shown, or if = the region up to the end of the scan process (i.e. the space+newline) = was marked. In GNU Emacs 23.1.92.86 (x86_64-apple-darwin10.2.0, NS = apple-appkit-1038.25) of 2010-02-08 on scarlett.local - Aquamacs Distribution 2.0dev Windowing system distributor `Apple', version 10.3.1038 configured using `configure '--with-ns' 'CFLAGS=3D-O0 -g'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: ObjC/l Minor modes in effect: diff-auto-refine-mode: t which-function-mode: t savehist-mode: t smart-frame-positioning-mode: t aquamacs-autoface-mode: t recentf-mode: t osx-key-mode: t tabbar-mwheel-mode: t tabbar-mode: t show-paren-mode: t delete-selection-mode: t pc-selection-mode: t cua-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: =20 =20 =20 =20 =20 =20 =20 =20 =20 =20 =20 | =20 | =20 | =20 =20 =20 =20 =20 =E2=8C=98X =20 =E2=8C=98V =20 =20 =20 SPC \ =20 SPC \ =20 =20 ) =20 =20 =20 =20 =20 =20 =20 =20 =20 =20 =20 ) =20 =20 =20 =20 =20 =20 =20 =20 =20 =E2=8C=98S =20 X C - M O D E =20 =20 X O B =E2=8C=98S =20 =E2=8C=98C =20 Recent messages: Auto-saving... Mark set [4 times] Auto-saving...done Auto-saving...done Mark set Auto-saving...done Auto-saving...done Saving file /Users/dr/ae.git/src/nsterm.m... Wrote /Users/dr/ae.git/src/nsterm.m (No changes need to be saved) Load-path shadows: /Users/dr/Library/Preferences/Aquamacs Emacs/Recent Files hides = /Users/dr/Library/Preferences/Aquamacs Emacs/Aquamacs Emacs2/Recent = Files /Users/dr/Library/Preferences/Aquamacs Emacs/Preferences hides = /Users/dr/Library/Preferences/Aquamacs Emacs/Aquamacs Emacs2/Preferences /Users/dr/Library/Preferences/Aquamacs Emacs/places hides = /Users/dr/Library/Preferences/Aquamacs Emacs/Aquamacs Emacs2/places /Users/dr/Library/Preferences/Aquamacs Emacs/minibuffer-history hides = /Users/dr/Library/Preferences/Aquamacs Emacs/Aquamacs = Emacs2/minibuffer-history /Users/dr/Library/Preferences/Aquamacs Emacs/frame-positions hides = /Users/dr/Library/Preferences/Aquamacs Emacs/Aquamacs = Emacs2/frame-positions /Users/dr/Library/Preferences/Aquamacs Emacs/customizations hides = /Users/dr/Library/Preferences/Aquamacs Emacs/Aquamacs = Emacs2/customizations /Library/Application Support/Aquamacs Emacs/JDEE/site-start hides = /Library/Application Support/Aquamacs Emacs/SLIME/site-start /Library/Application Support/Aquamacs Emacs/JDEE/cedet/speedbar/speedbar = hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/speedbar /Library/Application Support/Aquamacs Emacs/JDEE/cedet/speedbar/sb-image = hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/sb-image /Library/Application Support/Aquamacs Emacs/JDEE/cedet/common/ezimage = hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/ezimage /Library/Application Support/Aquamacs Emacs/JDEE/cedet/speedbar/dframe = hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/dframe /Library/Application Support/Aquamacs Emacs/JDEE/cedet/eieio/eieio hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs-lisp/= eieio /Library/Application Support/Aquamacs = Emacs/JDEE/cedet/eieio/eieio-speedbar hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs-lisp/= eieio-speedbar /Library/Application Support/Aquamacs Emacs/JDEE/cedet/eieio/eieio-opt = hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs-lisp/= eieio-opt /Library/Application Support/Aquamacs = Emacs/JDEE/cedet/eieio/eieio-custom hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs-lisp/= eieio-custom /Library/Application Support/Aquamacs Emacs/JDEE/cedet/eieio/eieio-comp = hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs-lisp/= eieio-comp /Library/Application Support/Aquamacs Emacs/JDEE/cedet/eieio/eieio-base = hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs-lisp/= eieio-base /Library/Application Support/Aquamacs Emacs/JDEE/cedet/eieio/chart hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs-lisp/= chart /Library/Application Support/Aquamacs Emacs/JDEE/cedet/semantic/semantic = hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/cedet/seman= tic /Library/Application Support/Aquamacs Emacs/JDEE/cedet/common/mode-local = hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/cedet/mode-= local /Library/Application Support/Aquamacs Emacs/JDEE/cedet/common/inversion = hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/cedet/inver= sion /Library/Application Support/Aquamacs Emacs/JDEE/cedet/ede/ede hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/cedet/ede /Library/Application Support/Aquamacs Emacs/JDEE/cedet/common/cedet = hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/cedet/cedet= /Library/Application Support/Aquamacs = Emacs/JDEE/cedet/common/cedet-files hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/cedet/cedet= -files /Library/Application Support/Aquamacs Emacs/JDEE/site-start hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/aquamacs/si= te-start Features: (shadow sort mail-extr message ecomplete rfc822 mml mml-sec password-cache mm-decode mm-bodies mm-encode mailabbrev nnheader gnus-util netrc gmm-utils mailheader canlock sha1 hex-util hashcash emacsbug cc-mode cc-fonts cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs log-edit ring pcvs-util add-log diff-mode vc vc-dispatcher cl-specs edebug multi-isearch jka-compr find-func vc-git url-http tls url-auth mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums url-gw url-cache url url-proxy url-privacy url-expand url-methods url-history url-cookie url-util url-parse url-vars mm-util mail-prsvr mailcap mail-utils which-func imenu slime-autoloads load-emacs-plugins aquamacs-mode-defaults auctex-config server tex-site smart-dnd aquamacs-aux savehist mouse-sel one-buffer-one-frame smart-frame-positioning drews_init color-theme-autoloads saveplace visual-line aquamacs-bug aquamacs-autoface-mode aquamacs-editing sendmail recentf tree-widget cus-edit osxkeys emulate-mac-keyboard-mode frame-cmds strings misc-fns thingatpt+ thingatpt frame-fns avoid aquamacs-mac-fontsets fit-frame aquamacs-frame-setup aquamacs-tabbar tabbar-window cl cl-19 tabbar easy-mmode cus-start cus-load load-emacs-pre-plugins aquamacs-site-start cocoa-compatibility filladapt aquamacs-redo check-for-updates aquamacs-menu osx_defaults aquamacs-tool-bar aquamacs mac-extra-functions aquamacs-tools aquamacs-macros parse-time timezone time-date paren delsel pc-select cua-base wid-edit regexp-opt advice advice-preload byte-opt bytecomp byte-compile debug help-fns help-mode view image-file disp-table tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win easymenu tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process ns multi-tty emacs) --Apple-Mail-86--212743485 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.12 (Darwin) iEYEARECAAYFAktzcvUACgkQYotoJUVQB4JSOACfYchiBaEz8P3db6tg/87+efPs nkIAn1VLr7wwemJKR5JuVqfLByE/1Xdj =9b0C -----END PGP SIGNATURE----- --Apple-Mail-86--212743485-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 11 14:29:11 2010 Received: (at control) by debbugs.gnu.org; 11 Feb 2010 19:29:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nfeit-0001uK-N8 for submit@debbugs.gnu.org; Thu, 11 Feb 2010 14:29:11 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nfeir-0001uB-T8 for control@debbugs.gnu.org; Thu, 11 Feb 2010 14:29:10 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1Nfeim-0007Oo-Gy; Thu, 11 Feb 2010 14:29:04 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19316.23168.372147.151260@fencepost.gnu.org> Date: Thu, 11 Feb 2010 14:29:04 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: magenta X-Ran: 1Hf|U,W~l\t]h.H!nS(6cnj?24jmDInFr5KXjK6/dN5&9ExgegG@fhUE;j1)?S:%82-p>p X-Debbugs-No-Ack: yes X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) close 5545 tags 5554 moreinfo tags 5556 patch reassign 5560 emacs,cc-mode reassign 5563 emacs,erc severity 5563 minor From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 16 22:56:45 2016 Received: (at 5560) by debbugs.gnu.org; 17 Feb 2016 03:56:45 +0000 Received: from localhost ([127.0.0.1]:38746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVtEK-0004gY-He for submit@debbugs.gnu.org; Tue, 16 Feb 2016 22:56:45 -0500 Received: from mail-qg0-f54.google.com ([209.85.192.54]:33305) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVtEI-0004gL-L6 for 5560@debbugs.gnu.org; Tue, 16 Feb 2016 22:56:43 -0500 Received: by mail-qg0-f54.google.com with SMTP id b35so3532481qge.0 for <5560@debbugs.gnu.org>; Tue, 16 Feb 2016 19:56:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=sAs39a5zxw4iNAaN0pJbh/+RF8cUhPrvvYYh1Elja4A=; b=IhFYMJs9DqbS5QeUdSI6Q2BiIKcgiYrAFOpcw5tfQJmiIYN580ujkEp4qQb33d4M7P tu9Dty4eq7QBd2C2F0PQ0g2kdD98KG7QbMaw4uiB9hmN/wGujfMkdJH1hl1im1ZzcOCx 2mfQgT4g7mR4t+ECqiyN4/zcNmF+VIxkI/1cfUmKIa0A1lHHJyI0e3x8JHpl8gp6VsoK pkVLMONxl2YmTHBqL0Mchgn5TUIpnuhAr/W8eGLWoLKgB/6kx/1KpyJPLkN28yRjuO0D cRqd9P9KC3AZt8LkgWTBz0JszBn/zigqbr8OSwxk14rlBcEeK6gP851YQu6SF+kHS6xy MGxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=sAs39a5zxw4iNAaN0pJbh/+RF8cUhPrvvYYh1Elja4A=; b=SVAN0txs4thoEwPoYg1x+SkNlDxFyVzzUITEpG7lKxni30cJnakfBfCqyFHSEhG6bz n+MuFhWjZS1oS83/YzVlwEpiSvfRztOJuF8sMTtU5gNUfObY7Vt5/1OgWNSpuL/EmMLC BAkAfLL/6T93cQi1y4rfjm2SCuHoBs8oDZfOVntBFyOjqrqnTVuPY2Gt6G1RrsoscI2Z ZZluPQdGO+Swun8lXsjB20KI01aLzED0od6bW1chSWVGk5jYj2n1sPRwwCDzzkftS1i+ FoylzOYQZGI2aIPgd8Xd+iVQAsqpM1VUK5Wwm1YlcyHKFbc4Y7bkMcWWrBQU7F55dlDt EwqQ== X-Gm-Message-State: AG10YOR40GHQqDSd0fUFkTF7rCSpRwM/SjLQSHcmuSTAisVSm5hFqdCowhe8eqMKSBC8uw== X-Received: by 10.140.157.214 with SMTP id d205mr34211455qhd.3.1455681397177; Tue, 16 Feb 2016 19:56:37 -0800 (PST) Received: from Andrews-MacBook-Pro.local.ahyatt-laptop (cpe-74-73-128-199.nyc.res.rr.com. [74.73.128.199]) by smtp.gmail.com with ESMTPSA id 139sm14516968qho.2.2016.02.16.19.56.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Feb 2016 19:56:35 -0800 (PST) From: Andrew Hyatt To: David Reitter Subject: Re: bug#5560: 23.1.92; parens matching in c-mode broken References: <4B60ED87-9CF5-464A-AE3F-C948ADB1C4D2@gmail.com> Date: Tue, 16 Feb 2016 22:56:34 -0500 In-Reply-To: <4B60ED87-9CF5-464A-AE3F-C948ADB1C4D2@gmail.com> (David Reitter's message of "Wed, 10 Feb 2010 22:01:05 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 5560 Cc: 5560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I can confirm this still doesn't work right in Emacs 25. However, I get a slightly different experience, with clicking on all 3 left parens highlighting until the first right paren only. Similarly, that right paren seems to be the matching paren for all 3 left parens. David Reitter writes: > Parens matching in C mode is sometimes surprising. In the example > below, double-clicking on either of the first two opening parentheses=20 > will mark the text until the " hyper_modifier : 0)", but that is corr= ect > only for the second paren, while the first one is unmatched due to a space > following the backslash. > > #define EV_MODIFIERS(e) \ > ((([e modifierFlags] & NSHelpKeyMask) ? \=20 > hyper_modifier : 0) \=20=20=20=20 > ... > > > It would be more useful if an "unmatched parentheses" was shown, or if th= e region up to the end of the scan process (i.e. the space+newline) was mar= ked. > > > > > In GNU Emacs 23.1.92.86 (x86_64-apple-darwin10.2.0, NS apple-appkit-1038.= 25) > of 2010-02-08 on scarlett.local - Aquamacs Distribution 2.0dev > Windowing system distributor `Apple', version 10.3.1038 > configured using `configure '--with-ns' 'CFLAGS=3D-O0 -g'' > > Important settings: > value of $LC_ALL: nil > value of $LC_COLLATE: nil > value of $LC_CTYPE: nil > value of $LC_MESSAGES: nil > value of $LC_MONETARY: nil > value of $LC_NUMERIC: nil > value of $LC_TIME: nil > value of $LANG: en_US.UTF-8 > value of $XMODIFIERS: nil > locale-coding-system: utf-8-unix > default enable-multibyte-characters: t > > Major mode: ObjC/l > > Minor modes in effect: > diff-auto-refine-mode: t > which-function-mode: t > savehist-mode: t > smart-frame-positioning-mode: t > aquamacs-autoface-mode: t > recentf-mode: t > osx-key-mode: t > tabbar-mwheel-mode: t > tabbar-mode: t > show-paren-mode: t > delete-selection-mode: t > pc-selection-mode: t > cua-mode: t > tooltip-mode: t > mouse-wheel-mode: t > tool-bar-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > auto-encryption-mode: t > auto-compression-mode: t > column-number-mode: t > line-number-mode: t > transient-mark-mode: t > abbrev-mode: t > > Recent input: > =20 > =20 > =20 > =20 > =20 > =20 > =20 > =20 > =20 > =20 > =20 > | =20 > | =20 > | =20 > =20 > =20 > =20 > =20 > =E2=8C=98X =20 > =E2=8C=98V =20 > =20 > =20 > SPC \ =20 > SPC \ =20 > =20 > ) =20 > =20 > =20 > =20 > =20 > =20 > =20 > =20 > =20 > =20 > =20 > ) =20 > =20 > =20 > =20 > =20 > =20 > =20 > =20 > =20 > =E2=8C=98S =20 > X C - M O D E =20 > =20 > X O B =E2=8C=98S =20 > =E2=8C=98C =20 > > > Recent messages: > Auto-saving... > Mark set [4 times] > Auto-saving...done > Auto-saving...done > Mark set > Auto-saving...done > Auto-saving...done > Saving file /Users/dr/ae.git/src/nsterm.m... > Wrote /Users/dr/ae.git/src/nsterm.m > (No changes need to be saved) > > Load-path shadows: > /Users/dr/Library/Preferences/Aquamacs Emacs/Recent Files hides /Users/dr= /Library/Preferences/Aquamacs Emacs/Aquamacs Emacs2/Recent Files > /Users/dr/Library/Preferences/Aquamacs Emacs/Preferences hides /Users/dr/= Library/Preferences/Aquamacs Emacs/Aquamacs Emacs2/Preferences > /Users/dr/Library/Preferences/Aquamacs Emacs/places hides /Users/dr/Libra= ry/Preferences/Aquamacs Emacs/Aquamacs Emacs2/places > /Users/dr/Library/Preferences/Aquamacs Emacs/minibuffer-history hides /Us= ers/dr/Library/Preferences/Aquamacs Emacs/Aquamacs Emacs2/minibuffer-history > /Users/dr/Library/Preferences/Aquamacs Emacs/frame-positions hides /Users= /dr/Library/Preferences/Aquamacs Emacs/Aquamacs Emacs2/frame-positions > /Users/dr/Library/Preferences/Aquamacs Emacs/customizations hides /Users/= dr/Library/Preferences/Aquamacs Emacs/Aquamacs Emacs2/customizations > /Library/Application Support/Aquamacs Emacs/JDEE/site-start hides /Librar= y/Application Support/Aquamacs Emacs/SLIME/site-start > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/speedbar/speedbar = hides /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/speedb= ar > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/speedbar/sb-image = hides /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/sb-ima= ge > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/common/ezimage hid= es /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/ezimage > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/speedbar/dframe hi= des /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/dframe > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/eieio/eieio hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs-lisp/e= ieio > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/eieio/eieio-speedb= ar hides /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/ema= cs-lisp/eieio-speedbar > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/eieio/eieio-opt hi= des /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs-li= sp/eieio-opt > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/eieio/eieio-custom= hides /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs= -lisp/eieio-custom > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/eieio/eieio-comp h= ides /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs-l= isp/eieio-comp > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/eieio/eieio-base h= ides /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs-l= isp/eieio-base > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/eieio/chart hides = /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/emacs-lisp/c= hart > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/semantic/semantic = hides /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/cedet/= semantic > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/common/mode-local = hides /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/cedet/= mode-local > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/common/inversion h= ides /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/cedet/i= nversion > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/ede/ede hides /Use= rs/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/cedet/ede > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/common/cedet hides= /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/cedet/cedet > /Library/Application Support/Aquamacs Emacs/JDEE/cedet/common/cedet-files= hides /Users/dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/cedet= /cedet-files > /Library/Application Support/Aquamacs Emacs/JDEE/site-start hides /Users/= dr/ae.git/nextstep/Aquamacs.app/Contents/Resources/lisp/aquamacs/site-start > > Features: > (shadow sort mail-extr message ecomplete rfc822 mml mml-sec > password-cache mm-decode mm-bodies mm-encode mailabbrev nnheader > gnus-util netrc gmm-utils mailheader canlock sha1 hex-util hashcash > emacsbug cc-mode cc-fonts cc-menus cc-cmds cc-styles cc-align cc-engine > cc-vars cc-defs log-edit ring pcvs-util add-log diff-mode vc > vc-dispatcher cl-specs edebug multi-isearch jka-compr find-func vc-git > url-http tls url-auth mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums > url-gw url-cache url url-proxy url-privacy url-expand url-methods > url-history url-cookie url-util url-parse url-vars mm-util mail-prsvr > mailcap mail-utils which-func imenu slime-autoloads load-emacs-plugins > aquamacs-mode-defaults auctex-config server tex-site smart-dnd > aquamacs-aux savehist mouse-sel one-buffer-one-frame > smart-frame-positioning drews_init color-theme-autoloads saveplace > visual-line aquamacs-bug aquamacs-autoface-mode aquamacs-editing > sendmail recentf tree-widget cus-edit osxkeys emulate-mac-keyboard-mode > frame-cmds strings misc-fns thingatpt+ thingatpt frame-fns avoid > aquamacs-mac-fontsets fit-frame aquamacs-frame-setup aquamacs-tabbar > tabbar-window cl cl-19 tabbar easy-mmode cus-start cus-load > load-emacs-pre-plugins aquamacs-site-start cocoa-compatibility filladapt > aquamacs-redo check-for-updates aquamacs-menu osx_defaults > aquamacs-tool-bar aquamacs mac-extra-functions aquamacs-tools > aquamacs-macros parse-time timezone time-date paren delsel pc-select > cua-base wid-edit regexp-opt advice advice-preload byte-opt bytecomp > byte-compile debug help-fns help-mode view image-file disp-table tooltip > ediff-hook vc-hooks lisp-float-type mwheel ns-win easymenu tool-bar dnd > fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer > select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu > font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan > thai tai-viet lao korean japanese hebrew greek romanian slovak czech > european ethiopic indian cyrillic chinese case-table epa-hook > jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces > cus-face files text-properties overlay md5 base64 format env code-pages > mule custom widget hashtable-print-readable backquote > make-network-process ns multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 20 17:55:01 2016 Received: (at 5560) by debbugs.gnu.org; 20 Feb 2016 22:55:01 +0000 Received: from localhost ([127.0.0.1]:35667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXGQX-0004Rl-4p for submit@debbugs.gnu.org; Sat, 20 Feb 2016 17:55:01 -0500 Received: from mail.muc.de ([193.149.48.3]:61383) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXGQV-0004Rb-8L for 5560@debbugs.gnu.org; Sat, 20 Feb 2016 17:54:59 -0500 Received: (qmail 6476 invoked by uid 3782); 20 Feb 2016 22:54:57 -0000 Received: from acm.muc.de (p548A46B3.dip0.t-ipconnect.de [84.138.70.179]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 20 Feb 2016 23:54:56 +0100 Received: (qmail 18716 invoked by uid 1000); 20 Feb 2016 22:57:23 -0000 Date: Sat, 20 Feb 2016 22:57:23 +0000 To: Andrew Hyatt Subject: Re: bug#5560: 23.1.92; parens matching in c-mode broken Message-ID: <20160220225723.GA10801@acm.fritz.box> References: <4B60ED87-9CF5-464A-AE3F-C948ADB1C4D2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 5560 Cc: David Reitter , 5560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, David and Andrew. On Tue, Feb 16, 2016 at 10:56:34PM -0500, Andrew Hyatt wrote: > I can confirm this still doesn't work right in Emacs 25. However, I get > a slightly different experience, with clicking on all 3 left parens > highlighting until the first right paren only. Similarly, that right > paren seems to be the matching paren for all 3 left parens. What is (now) happening is this: the C Preprocessor construct ends at the end of the second line (due to the space after the \ there). The first two open parentheses on that line are unmatched. In such circumstances, CC Mode splats the syntax of such characters by setting syntax-table text properties on them. This is to prevent them spuriously matching parens outside the CPP construct. When you double click on one of the non-matching parens, the critical piece of code reached is in `mouse-start-end'. Instead of checking the syntax of the character in its context (i.e. respecting syntax-table text properties), it simply checks the syntax of the bare character '(', and finds it's an open paren. It then does (forward-sexp) to try and find the matching ')'. This ignores the two "dummy" parens and then scans over the real paren pair remaining. One solution would be to replace the (obsolete) form in mouse.el: (char-syntax (char-after start)) with the modern (and correct) form (syntax-after start) . A small problem with this is that `syntax-after' returns a cons of raw numbers rather than the more picturesque character descriptors like ?\(. A bigger problem is that there are still approximately 164 uses of `char-syntax' in our sources, all (or most) of which need superseding by `syntax-after'. If this were to be done, double clicking on one of these unmatched parens would attempt to match the "word it is in". I don't know exactly what would happen. Probably not very much. In fact, I'm going to try it. (A bit later): Double clicking on a "dummy paren" would mark the sequence of three parens. I think this is better than marking up to the single close paren, but not by much. > David Reitter writes: > > Parens matching in C mode is sometimes surprising. In the example > > below, double-clicking on either of the first two opening parentheses > > will mark the text until the " hyper_modifier : 0)", but that is correct > > only for the second paren, while the first one is unmatched due to a space > > following the backslash. > > #define EV_MODIFIERS(e) \ > > ((([e modifierFlags] & NSHelpKeyMask) ? \ > > hyper_modifier : 0) \ > > ... > > It would be more useful if an "unmatched parentheses" was shown, or > > if the region up to the end of the scan process (i.e. the > > space+newline) was marked. Giving a decent error message here would be difficult. We're down in the depths of the mouse code, but the strategem of giving syntax-table text properties to parentheses is a pure CC Mode one. Signaling an error if a paren has other than paren syntax is liable to have unforseen side effects somewhere, somehow, some time. Do you (plural) think it is worth while fixing the mouse code, as detailed above, or do you have any other ideas for a fix? > > In GNU Emacs 23.1.92.86 (x86_64-apple-darwin10.2.0, NS apple-appkit-1038.25) > > of 2010-02-08 on scarlett.local - Aquamacs Distribution 2.0dev > > Windowing system distributor `Apple', version 10.3.1038 > > configured using `configure '--with-ns' 'CFLAGS=-O0 -g'' > > Major mode: ObjC/l -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 21 07:33:15 2016 Received: (at 5560) by debbugs.gnu.org; 21 Feb 2016 12:33:15 +0000 Received: from localhost ([127.0.0.1]:35879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXTCN-0001w4-Ep for submit@debbugs.gnu.org; Sun, 21 Feb 2016 07:33:15 -0500 Received: from mail.muc.de ([193.149.48.3]:31185) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXTCM-0001vv-5f for 5560@debbugs.gnu.org; Sun, 21 Feb 2016 07:33:14 -0500 Received: (qmail 2460 invoked by uid 3782); 21 Feb 2016 12:33:13 -0000 Received: from acm.muc.de (p579E8505.dip0.t-ipconnect.de [87.158.133.5]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 21 Feb 2016 13:33:12 +0100 Received: (qmail 3361 invoked by uid 1000); 21 Feb 2016 12:35:39 -0000 Date: Sun, 21 Feb 2016 12:35:39 +0000 To: Andrew Hyatt Subject: Re: bug#5560: 23.1.92; parens matching in c-mode broken Message-ID: <20160221123539.GA2220@acm.fritz.box> References: <4B60ED87-9CF5-464A-AE3F-C948ADB1C4D2@gmail.com> <20160220225723.GA10801@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160220225723.GA10801@acm.fritz.box> User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 5560 Cc: David Reitter , 5560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello again, David and Andrew. On Sat, Feb 20, 2016 at 10:57:23PM +0000, Alan Mackenzie wrote: > On Tue, Feb 16, 2016 at 10:56:34PM -0500, Andrew Hyatt wrote: > > I can confirm this still doesn't work right in Emacs 25. However, I get > > a slightly different experience, with clicking on all 3 left parens > > highlighting until the first right paren only. Similarly, that right > > paren seems to be the matching paren for all 3 left parens. > > David Reitter writes: > > > Parens matching in C mode is sometimes surprising. In the example > > > below, double-clicking on either of the first two opening parentheses > > > will mark the text until the " hyper_modifier : 0)", but that is correct > > > only for the second paren, while the first one is unmatched due to a space > > > following the backslash. > > > #define EV_MODIFIERS(e) \ > > > ((([e modifierFlags] & NSHelpKeyMask) ? \ > > > hyper_modifier : 0) \ > > > ... > > > It would be more useful if an "unmatched parentheses" was shown, or > > > if the region up to the end of the scan process (i.e. the > > > space+newline) was marked. > Giving a decent error message here would be difficult. We're down in the > depths of the mouse code, but the strategem of giving syntax-table text > properties to parentheses is a pure CC Mode one. Signaling an error if > a paren has other than paren syntax is liable to have unforseen side > effects somewhere, somehow, some time. After a night's sleep, I've changed my mind about the advisability of such a fix. So, here is a fix. It works as indicated last night: if a character whose normal syntax is open/close-paren has a different syntax due to syntax-table text properties, a 'scan-error error is signaled: either "Containing expression ends prematurely" for an open paren, or "Unbalanced parentheses" for a close paren. Here's the patch. Please try it out and let me know if there's anything amiss about it. Otherwise, I'll commit it. diff --git a/lisp/mouse.el b/lisp/mouse.el index 85ffc43..22c5b48 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -931,20 +931,29 @@ mouse-start-end (= start end) (char-after start) (= (char-syntax (char-after start)) ?\()) - (list start - (save-excursion - (goto-char start) - (forward-sexp 1) - (point)))) + (if (/= (car (syntax-after start)) 4) + ;; This happens in CC Mode when unbalanced parens in CPP + ;; constructs are given punctuation syntax with + ;; syntax-table text properties. (2016-02-21). + (signal 'scan-error (list "Containing expression ends prematurely" + start start)) + (list start + (save-excursion + (goto-char start) + (forward-sexp 1) + (point))))) ((and (= mode 1) (= start end) (char-after start) (= (char-syntax (char-after start)) ?\))) - (list (save-excursion - (goto-char (1+ start)) - (backward-sexp 1) - (point)) - (1+ start))) + (if (/= (car (syntax-after start)) 5) + ;; See above comment about CC Mode. + (signal 'scan-error (list "Unbalanced parentheses" start start)) + (list (save-excursion + (goto-char (1+ start)) + (backward-sexp 1) + (point)) + (1+ start)))) ((and (= mode 1) (= start end) (char-after start) -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 21 16:40:11 2016 Received: (at 5560) by debbugs.gnu.org; 21 Feb 2016 21:40:11 +0000 Received: from localhost ([127.0.0.1]:36630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXbje-0006Yk-Uf for submit@debbugs.gnu.org; Sun, 21 Feb 2016 16:40:11 -0500 Received: from mail-qg0-f53.google.com ([209.85.192.53]:34621) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXbje-0006YY-0f for 5560@debbugs.gnu.org; Sun, 21 Feb 2016 16:40:10 -0500 Received: by mail-qg0-f53.google.com with SMTP id b67so99246759qgb.1 for <5560@debbugs.gnu.org>; Sun, 21 Feb 2016 13:40:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=izG5x2rmEPH/YXD2LfsMXw0yomDN71S/dujWb/gM4Ew=; b=smcmF+I38wov9zGFrWftLMHXqOKbi4IN8ebXsDJZnvDGo1o3uLI4BIDowFggCpXk85 8QRKuRm5Bp3cf1ZM1ycai8OpLIz1Z/tqPhHeFWeZDqwRBo3LT+mpR3HA6PPnUOHGYR6a rN10r8teC1Ggp4A2TTo8OrDJdWtV7cZQ0/F3chFLlDayl4nt7uPc0v3GM0uWI9JXuOp5 7bjcKPDBqdcxvJd0c0GHPR0oytn03aaL9tneXzu+Fu1mdA0sNGPgBM/KoH16v60wSN+z 97NvFYhQTP1nrhSl7tTOuCG28q58eUgi+x4G6usFAp7vxYdmj1f3/oC0og247bUAquXd +bmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=izG5x2rmEPH/YXD2LfsMXw0yomDN71S/dujWb/gM4Ew=; b=RmDR4uwfrHOTK1/IOfP/COExyHOwph1EPsKuuU5dH039mtdN0FNdCpvko09pLvAeey 29TQGbzhcERDxqsldKTVLsUcHich7p0L+uUrnPlFF7JLROVPTG4gqOfCI4oZJYt8iYgq +QiVQuTbHIb47UWwEuSGYhDXOkPnQGHZEE0qjj8sLdHlR2VXJmEGbbxzaYRSNykE1aLB PIIZdbHQtGSy5g1Ql46IFmXAbH0/Xqfb2eMPClchRl90C2Toj7t2lJlCsm3qOAzeX3ze sRX1cLrD/1hsI60S4/bX98OcEpwqz5sZfDRsu62WnO8em6feMbhzSoKy6U22xSSKozWu I+Rw== X-Gm-Message-State: AG10YOQMA2W9A7OV7dfNIm9NybgHHc/5c9KbXD5VY9hjVCoBabOgskrAgOygBhTApCXJfA== X-Received: by 10.140.128.21 with SMTP id 21mr29281956qha.36.1456090804502; Sun, 21 Feb 2016 13:40:04 -0800 (PST) Received: from [10.0.1.7] (c-71-58-212-112.hsd1.pa.comcast.net. [71.58.212.112]) by smtp.gmail.com with ESMTPSA id a102sm5388574qgf.21.2016.02.21.13.40.02 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 21 Feb 2016 13:40:02 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Subject: Re: bug#5560: 23.1.92; parens matching in c-mode broken From: David Reitter In-Reply-To: <20160221123539.GA2220@acm.fritz.box> Date: Sun, 21 Feb 2016 16:40:09 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <00B53025-4477-4BBC-961A-0B8DF4234C19@gmail.com> References: <4B60ED87-9CF5-464A-AE3F-C948ADB1C4D2@gmail.com> <20160220225723.GA10801@acm.fritz.box> <20160221123539.GA2220@acm.fritz.box> To: Alan Mackenzie X-Mailer: Apple Mail (2.3112) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 5560 Cc: Andrew Hyatt , 5560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Alan, Your patch works as advertised for my test case. It=E2=80=99s certainly = better to error out than to do the wrong thing. I think you are catching the right situations, but my confidence is low = because of the readability of the code (what is 4, 5?). I think the question is whether that fix is appropriate for the 25.1 = release. If you want to apply it there, I would probably test a whole = lot of cases in modes that are derivates of c-mode. - David > On Feb 21, 2016, at 7:35 AM, Alan Mackenzie wrote: >=20 > Hello again, David and Andrew. >=20 > On Sat, Feb 20, 2016 at 10:57:23PM +0000, Alan Mackenzie wrote: >> On Tue, Feb 16, 2016 at 10:56:34PM -0500, Andrew Hyatt wrote: >=20 >>> I can confirm this still doesn't work right in Emacs 25. However, I = get >>> a slightly different experience, with clicking on all 3 left parens >>> highlighting until the first right paren only. Similarly, that = right >>> paren seems to be the matching paren for all 3 left parens. >=20 >>> David Reitter writes: >=20 >>>> Parens matching in C mode is sometimes surprising. In the example >>>> below, double-clicking on either of the first two opening = parentheses=20 >>>> will mark the text until the " hyper_modifier : 0)", but that = is correct >>>> only for the second paren, while the first one is unmatched due to = a space >>>> following the backslash. >=20 >>>> #define EV_MODIFIERS(e) \ >>>> ((([e modifierFlags] & NSHelpKeyMask) ? \=20 >>>> hyper_modifier : 0) \ =20 >>>> ... >=20 >=20 >>>> It would be more useful if an "unmatched parentheses" was shown, or >>>> if the region up to the end of the scan process (i.e. the >>>> space+newline) was marked. >=20 >> Giving a decent error message here would be difficult. We're down in = the >> depths of the mouse code, but the strategem of giving syntax-table = text >> properties to parentheses is a pure CC Mode one. Signaling an error = if >> a paren has other than paren syntax is liable to have unforseen side >> effects somewhere, somehow, some time. >=20 > After a night's sleep, I've changed my mind about the advisability of > such a fix. So, here is a fix. It works as indicated last night: if = a > character whose normal syntax is open/close-paren has a different = syntax > due to syntax-table text properties, a 'scan-error error is signaled: > either "Containing expression ends prematurely" for an open paren, or > "Unbalanced parentheses" for a close paren. >=20 > Here's the patch. Please try it out and let me know if there's = anything > amiss about it. Otherwise, I'll commit it. >=20 >=20 >=20 > diff --git a/lisp/mouse.el b/lisp/mouse.el > index 85ffc43..22c5b48 100644 > --- a/lisp/mouse.el > +++ b/lisp/mouse.el > @@ -931,20 +931,29 @@ mouse-start-end > (=3D start end) > (char-after start) > (=3D (char-syntax (char-after start)) ?\()) > - (list start > - (save-excursion > - (goto-char start) > - (forward-sexp 1) > - (point)))) > + (if (/=3D (car (syntax-after start)) 4) > + ;; This happens in CC Mode when unbalanced parens in CPP > + ;; constructs are given punctuation syntax with > + ;; syntax-table text properties. (2016-02-21). > + (signal 'scan-error (list "Containing expression ends = prematurely" > + start start)) > + (list start > + (save-excursion > + (goto-char start) > + (forward-sexp 1) > + (point))))) > ((and (=3D mode 1) > (=3D start end) > (char-after start) > (=3D (char-syntax (char-after start)) ?\))) > - (list (save-excursion > - (goto-char (1+ start)) > - (backward-sexp 1) > - (point)) > - (1+ start))) > + (if (/=3D (car (syntax-after start)) 5) > + ;; See above comment about CC Mode. > + (signal 'scan-error (list "Unbalanced parentheses" start = start)) > + (list (save-excursion > + (goto-char (1+ start)) > + (backward-sexp 1) > + (point)) > + (1+ start)))) > ((and (=3D mode 1) > (=3D start end) > (char-after start) >=20 >=20 >=20 > --=20 > Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 21 18:22:56 2016 Received: (at 5560) by debbugs.gnu.org; 21 Feb 2016 23:22:56 +0000 Received: from localhost ([127.0.0.1]:36688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXdL6-0000Zh-Ep for submit@debbugs.gnu.org; Sun, 21 Feb 2016 18:22:56 -0500 Received: from mail-ig0-f169.google.com ([209.85.213.169]:38199) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXdL4-0000ZV-JG for 5560@debbugs.gnu.org; Sun, 21 Feb 2016 18:22:55 -0500 Received: by mail-ig0-f169.google.com with SMTP id y8so69325123igp.1 for <5560@debbugs.gnu.org>; Sun, 21 Feb 2016 15:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:reply-to:mime-version; bh=DLhbbhIHcnRzIc+oI6wNWiCmG/5GE0JeQWBQHkLuxZU=; b=tCUfQvNDllw764F+qI9aDTDOGFCF3S9r99b6d6oVSO53+vklTper5AQZ9j1JMiDMgb eE+UK6kagJzZ3F2hu7gKVItr5T/M1qFYQRbb0IbOmTJ/l62fBvEL7pzk0aRPVLH0auuc xWhvR9sCEtH4S9EaWqW375zrI4XMxXMN1EUiKQzP+DBKBGVO+Ar/ty8HGW5E8m541+yR j9TEsj5wE7pIU5x09rtm7mUsenMeDviYRE3rwLd8tWTLt14jOc1sEKTxQrDff8h0Dj9i flZiln7KENoWD+ZE3QYW2cyL4DgmoAYtfy2kckFKp+0g39tYDfeEGkvR6g/m9xaG4NzU 89xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:reply-to:mime-version; bh=DLhbbhIHcnRzIc+oI6wNWiCmG/5GE0JeQWBQHkLuxZU=; b=CBeB6BhmCSYLh3RKr4Bd1J3pV79czDdAq9UWEQ7OOCUdWz/lEnK2TIWV0Si7e51H7g zvvoC2lDUHUMiv5PzN93o/iiFKF8wMXzOFP0JH93o+bEPxyNVX8o5C4a+WqXfxMrVO3s HpbUPPHV9xZ8DWyroTsJpUKKXEzJ+Qsv2x8mgTdXh4I96APmyXlyLrc33bi+u63TUbx2 dteBHjdxJz/21nFXN3wSwAxZp2laV1Ca+2I7I2DuBrB2dCIktOap7+rmxzTlIRdfbsEj 8jiU+S4I4Lp/TXX3VXaQWtlDSAtWLP7GrSulE8jlFIca2UeJMWn3VWasp8MyYf4QMuaW SzNQ== X-Gm-Message-State: AG10YOR5wsGy09tzhYcPn8e48pzE6HoKnIsq+LznKnLCXyiPSVEdpI1YeniP27aFYHlM5w== X-Received: by 10.50.73.161 with SMTP id m1mr2058784igv.48.1456096969102; Sun, 21 Feb 2016 15:22:49 -0800 (PST) Received: from Hermes.local (mail.johnwiegley.com. [208.82.103.192]) by smtp.gmail.com with ESMTPSA id k103sm10440139iod.29.2016.02.21.15.22.47 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 21 Feb 2016 15:22:47 -0800 (PST) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Hermes.local (Postfix, from userid 501) id 0E5A94E61458; Sun, 21 Feb 2016 15:22:46 -0800 (PST) To: David Reitter Subject: Re: bug#5560: 23.1.92; parens matching in c-mode broken In-Reply-To: <00B53025-4477-4BBC-961A-0B8DF4234C19@gmail.com> (David Reitter's message of "Sun, 21 Feb 2016 16:40:09 -0500") Date: Sun, 21 Feb 2016 15:21:52 -0800 Message-ID: References: <4B60ED87-9CF5-464A-AE3F-C948ADB1C4D2@gmail.com> <20160220225723.GA10801@acm.fritz.box> <20160221123539.GA2220@acm.fritz.box> <00B53025-4477-4BBC-961A-0B8DF4234C19@gmail.com> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 5560 Cc: Alan Mackenzie , Andrew Hyatt , 5560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: John Wiegley Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >>>>> David Reitter writes: > I think the question is whether that fix is appropriate for the 25.1 > release. If you want to apply it there, I would probably test a whole lot of > cases in modes that are derivates of c-mode. Does this change past behavior? We still have room for fixes in 25.1, but if it changes past behavior it will need sufficient testing. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 05:33:32 2016 Received: (at 5560) by debbugs.gnu.org; 22 Feb 2016 10:33:32 +0000 Received: from localhost ([127.0.0.1]:36848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXno4-00017L-Jo for submit@debbugs.gnu.org; Mon, 22 Feb 2016 05:33:32 -0500 Received: from mail.muc.de ([193.149.48.3]:58314) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXno2-00017C-PN for 5560@debbugs.gnu.org; Mon, 22 Feb 2016 05:33:31 -0500 Received: (qmail 11297 invoked by uid 3782); 22 Feb 2016 10:33:29 -0000 Received: from acm.muc.de (p548A53D7.dip0.t-ipconnect.de [84.138.83.215]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 22 Feb 2016 11:33:27 +0100 Received: (qmail 2633 invoked by uid 1000); 22 Feb 2016 10:35:55 -0000 Date: Mon, 22 Feb 2016 10:35:55 +0000 To: David Reitter Subject: Re: bug#5560: 23.1.92; parens matching in c-mode broken Message-ID: <20160222103555.GA1984@acm.fritz.box> References: <4B60ED87-9CF5-464A-AE3F-C948ADB1C4D2@gmail.com> <20160220225723.GA10801@acm.fritz.box> <20160221123539.GA2220@acm.fritz.box> <00B53025-4477-4BBC-961A-0B8DF4234C19@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <00B53025-4477-4BBC-961A-0B8DF4234C19@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 5560 Cc: Andrew Hyatt , 5560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, David. On Sun, Feb 21, 2016 at 04:40:09PM -0500, David Reitter wrote: > Alan, > Your patch works as advertised for my test case. It’s certainly > better to error out than to do the wrong thing. > I think you are catching the right situations, but my confidence is > low because of the readability of the code (what is 4, 5?). 4 and 5 are the low level codes for "open paren" and "close paren" syntax. I don't like them much either, but `syntax-after' is the only interface available which returns the syntax of a character in a buffer, taking account of syntax-table text properties. 4 and 5 (or, more precisely, (4 . ?\)), (5 . ?\()) are what we have to work with. One way would be to create two constants with fancy names with values 4 and 5, but I don't think that helps much - anybody debugging and suspicious of the values still has to find the page in the elisp manual to check, but has an extra irritating indirection to cope with. How would you feel about explanatory comments on the two lines - something like: + (if (/= (car (syntax-after start)) 4) ; low-level code for ?\( ? What we really need is a better interface. Perhaps `char-syntax-after', which would actually return ?\( and ?\). In fact, I think I'll raise a bug report for this. > I think the question is whether that fix is appropriate for the 25.1 > release. If you want to apply it there, I would probably test a whole > lot of cases in modes that are derivates of c-mode. I think the fix should go into 25.1. I'm confident enough about the mechanism of the bug that I'm not sure extensive testing is warranted. > - David -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 05:48:41 2016 Received: (at 5560) by debbugs.gnu.org; 22 Feb 2016 10:48:41 +0000 Received: from localhost ([127.0.0.1]:36858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXo2i-0001U3-RW for submit@debbugs.gnu.org; Mon, 22 Feb 2016 05:48:41 -0500 Received: from mail.muc.de ([193.149.48.3]:34556) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXo2f-0001Tr-QW for 5560@debbugs.gnu.org; Mon, 22 Feb 2016 05:48:39 -0500 Received: (qmail 14498 invoked by uid 3782); 22 Feb 2016 10:48:36 -0000 Received: from acm.muc.de (p548A53D7.dip0.t-ipconnect.de [84.138.83.215]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 22 Feb 2016 11:48:36 +0100 Received: (qmail 2679 invoked by uid 1000); 22 Feb 2016 10:51:04 -0000 Date: Mon, 22 Feb 2016 10:51:04 +0000 To: John Wiegley Subject: Re: bug#5560: 23.1.92; parens matching in c-mode broken Message-ID: <20160222105104.GB1984@acm.fritz.box> References: <4B60ED87-9CF5-464A-AE3F-C948ADB1C4D2@gmail.com> <20160220225723.GA10801@acm.fritz.box> <20160221123539.GA2220@acm.fritz.box> <00B53025-4477-4BBC-961A-0B8DF4234C19@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 5560 Cc: David Reitter , Andrew Hyatt , 5560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, John. On Sun, Feb 21, 2016 at 03:21:52PM -0800, John Wiegley wrote: > >>>>> David Reitter writes: > > I think the question is whether that fix is appropriate for the 25.1 > > release. If you want to apply it there, I would probably test a whole lot of > > cases in modes that are derivates of c-mode. > Does this change past behavior? We still have room for fixes in 25.1, but if > it changes past behavior it will need sufficient testing. The fix doesn't change past behaviour, beyond fixing the actual bug. What is amazing is that on doing a triple click with mouse-1 on such an unmatched paren, an error is signaled after the second click, but Emacs then goes on to mark the line correctly after the third click. > -- > John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F > http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 07:09:09 2016 Received: (at 5560) by debbugs.gnu.org; 22 Feb 2016 12:09:09 +0000 Received: from localhost ([127.0.0.1]:36912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXpIb-00059q-GN for submit@debbugs.gnu.org; Mon, 22 Feb 2016 07:09:09 -0500 Received: from mail-qk0-f174.google.com ([209.85.220.174]:36579) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXpIZ-00059d-Mx for 5560@debbugs.gnu.org; Mon, 22 Feb 2016 07:09:08 -0500 Received: by mail-qk0-f174.google.com with SMTP id s68so54362106qkh.3 for <5560@debbugs.gnu.org>; Mon, 22 Feb 2016 04:09:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=iVEfTfq/3DynwZEUvYfD7paWns1eIdv2lTONLs9UUQM=; b=CcClpmER5bXYXg8HMePhevxUZ7ZIGCkNQsbzA+xIjsj1GXv0gTvHtbK5iLFJeIBr8U ugOMJ9GfpW6OSQZssnI7xvrJNla+exF57DdQ8jwsucEjyCkCpPHxIAAeBZebV2HX17lj xl3BPz8mB9HiZgrFiBpa60qPK3hEDsbyFuLUnY1GSben5IrrFytPX+87e1zhOOrW3aVF 2IZiTWmO+7/e80KCthYEvu4ceDxGdVO4FPiK5puhCvWzsfKXktTNP0jIO1XN5y34G650 O147bYxyEFGI5iSOLqpcI8V1pXaMxvLuDPOOgOKGWg9pl36+FYeuYFCTDNX0pwHiH7yt gDFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=iVEfTfq/3DynwZEUvYfD7paWns1eIdv2lTONLs9UUQM=; b=WtVtudCmJO+pjJNMGgaW017JwLswCKCpxyvW/bzdL2x1r6q1HIcwCaTspsQvNdqwNd WzgsDLNOtApIr4d3m98JHbTUiyaxR6r6YraCKlRj1b6hdR/dOuGRAXHTwfrdOSCw89Up UU9EyNUAVgMlPuMDKIRq5AHMovjvCmTmI83M41A9/+RRAY9cPsK1ztuCgjfZIxS+BoUz mfDZAtHQz7V4FimspYPRdVufxVxOvbVgMWZSDhO+qI5lHq5YFAx4EZH4pAC0x88smSPD vVKJYr+BF9/KQkNwnDiH0fHO954LGeytiy2u45/bNMHc+8FPQ6mxEwvSo6KFZtgIfjfp V+iQ== X-Gm-Message-State: AG10YOR9Y5orkqFM4yBnOChn1oFT1Jcco3m5e5Q+68HgBhuf3+EJzHFVMFJ4ccU5mp0Y7Q== X-Received: by 10.55.80.9 with SMTP id e9mr33278494qkb.94.1456142942413; Mon, 22 Feb 2016 04:09:02 -0800 (PST) Received: from [10.0.1.7] (c-71-58-212-112.hsd1.pa.comcast.net. [71.58.212.112]) by smtp.gmail.com with ESMTPSA id u202sm9832246qka.43.2016.02.22.04.09.00 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 22 Feb 2016 04:09:01 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Subject: Re: bug#5560: 23.1.92; parens matching in c-mode broken From: David Reitter In-Reply-To: <20160222103555.GA1984@acm.fritz.box> Date: Mon, 22 Feb 2016 07:09:00 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <94147C57-FF72-46AF-A6F5-0403F577C947@gmail.com> References: <4B60ED87-9CF5-464A-AE3F-C948ADB1C4D2@gmail.com> <20160220225723.GA10801@acm.fritz.box> <20160221123539.GA2220@acm.fritz.box> <00B53025-4477-4BBC-961A-0B8DF4234C19@gmail.com> <20160222103555.GA1984@acm.fritz.box> To: Alan Mackenzie X-Mailer: Apple Mail (2.3112) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 5560 Cc: Andrew Hyatt , 5560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Feb 22, 2016, at 5:35 AM, Alan Mackenzie wrote: > How would you feel about explanatory comments on the two lines - > something like That would help. I didn=E2=80=99t mean to criticize your patch in this = sense, as this is a more general interface problem as you point out. What you are explaining though makes more sense to me. So yes, perhaps = this needs to be in 25.1. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 25 04:52:27 2016 Received: (at 5560-done) by debbugs.gnu.org; 25 Feb 2016 09:52:27 +0000 Received: from localhost ([127.0.0.1]:44797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYsax-0002DH-JT for submit@debbugs.gnu.org; Thu, 25 Feb 2016 04:52:27 -0500 Received: from mail.muc.de ([193.149.48.3]:27812) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYsav-0002D8-Uh for 5560-done@debbugs.gnu.org; Thu, 25 Feb 2016 04:52:26 -0500 Received: (qmail 6121 invoked by uid 3782); 25 Feb 2016 09:52:24 -0000 Received: from acm.muc.de (p548A4868.dip0.t-ipconnect.de [84.138.72.104]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 25 Feb 2016 10:52:21 +0100 Received: (qmail 20640 invoked by uid 1000); 25 Feb 2016 09:54:51 -0000 Date: Thu, 25 Feb 2016 09:54:51 +0000 To: David Reitter , 5560-done@debbugs.gnu.org Subject: Re: bug#5560: 23.1.92; parens matching in c-mode broken Message-ID: <20160225095451.GA19742@acm.fritz.box> References: <4B60ED87-9CF5-464A-AE3F-C948ADB1C4D2@gmail.com> <20160220225723.GA10801@acm.fritz.box> <20160221123539.GA2220@acm.fritz.box> <00B53025-4477-4BBC-961A-0B8DF4234C19@gmail.com> <20160222103555.GA1984@acm.fritz.box> <94147C57-FF72-46AF-A6F5-0403F577C947@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <94147C57-FF72-46AF-A6F5-0403F577C947@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 5560-done Cc: Andrew Hyatt , John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, David. On Mon, Feb 22, 2016 at 07:09:00AM -0500, David Reitter wrote: > On Feb 22, 2016, at 5:35 AM, Alan Mackenzie wrote: > > How would you feel about explanatory comments on the two lines - > > something like > That would help. I didn’t mean to criticize your patch in this sense, > as this is a more general interface problem as you point out. OK. I've added these comments. > What you are explaining though makes more sense to me. So yes, > perhaps this needs to be in 25.1. I've committed the fix to the emacs-25 branch, and am closing the bug. Sorry it took so long to fix. -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Aug 15 18:10:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 24 Mar 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator