From debbugs-submit-bounces@debbugs.gnu.org Mon May 23 04:33:42 2022 Received: (at submit) by debbugs.gnu.org; 23 May 2022 08:33:42 +0000 Received: from localhost ([127.0.0.1]:47237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt3VW-000872-Hx for submit@debbugs.gnu.org; Mon, 23 May 2022 04:33:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:55614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt3VV-00086v-1X for submit@debbugs.gnu.org; Mon, 23 May 2022 04:33:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt3VU-00016K-Lc for guix-patches@gnu.org; Mon, 23 May 2022 04:33:40 -0400 Received: from mira.cbaines.net ([212.71.252.8]:36344) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nt3VP-0006BS-Qp for guix-patches@gnu.org; Mon, 23 May 2022 04:33:37 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id C569827BBE9 for ; Mon, 23 May 2022 09:33:32 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id d72e496c for ; Mon, 23 May 2022 08:33:32 +0000 (UTC) From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] WIP: fix the linux build system Date: Mon, 23 May 2022 09:33:32 +0100 Message-Id: <20220523083332.21626-1-mail@cbaines.net> X-Mailer: git-send-email 2.36.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --- gnu/platform.scm | 6 +++++- guix/build-system/linux-module.scm | 3 ++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gnu/platform.scm b/gnu/platform.scm index fdc3685e7c..91a1854e68 100644 --- a/gnu/platform.scm +++ b/gnu/platform.scm @@ -66,10 +66,14 @@ (define-record-type* platform make-platform platform? (target platform-target) (system platform-system) - (linux-architecture platform-linux-architecture + (linux-architecture platform-linux-architecture* (default #f)) (glibc-dynamic-linker platform-glibc-dynamic-linker)) +;; Provide a procedure so this can be used via module-ref +(define (platform-linux-architecture platform) + (platform-linux-architecture* platform)) + ;;; ;;; Platforms. diff --git a/guix/build-system/linux-module.scm b/guix/build-system/linux-module.scm index 761ebe25b1..78a3ba95b2 100644 --- a/guix/build-system/linux-module.scm +++ b/guix/build-system/linux-module.scm @@ -51,7 +51,8 @@ (define (default-linux) (define (system->arch system) (let ((module (resolve-interface '(gnu platform)))) - ((module-ref module 'lookup-platform-by-target-or-system) system))) + ((module-ref module 'platform-linux-architecture) + ((module-ref module 'lookup-platform-by-target-or-system) system)))) (define (make-linux-module-builder linux) (package -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Tue May 24 03:09:51 2022 Received: (at 55591) by debbugs.gnu.org; 24 May 2022 07:09:51 +0000 Received: from localhost ([127.0.0.1]:50841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntOfv-0004QU-JH for submit@debbugs.gnu.org; Tue, 24 May 2022 03:09:51 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:52781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntOfq-0004QH-6v for 55591@debbugs.gnu.org; Tue, 24 May 2022 03:09:50 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4L6lgq578jz1DPhf; Tue, 24 May 2022 09:09:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4L6lgq578jz1DPhf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1653376183; bh=PYg+Ufu9rJS78tUlHZ5Zz/A7ihl7j6bWSXxCWBoAaTE=; h=Subject:From:To:Date:In-Reply-To:References:From; b=KidhNsaS3U+2UUHtrnD4aRJ6xvHccEdqbVO+OgSgc3OhCWaQT+1GTtiSdMwmoACSu 60Uy7dF9xMnHFVFI8Z14loMLgEeJ9+dCxV7Tl08SbWqvFLcZ+lOtEzQiXYKemO8ePX sYdAwh0hv2RmORC2ft+5EzrAppmPv39hOjGpYgzs= Message-ID: <6bcd4de97c04b3ced47a573eaeade3f9e0284d3b.camel@ist.tugraz.at> Subject: Re: [PATCH] WIP: fix the linux build system From: Liliana Marie Prikler To: Christopher Baines , 55591@debbugs.gnu.org Date: Tue, 24 May 2022 09:09:42 +0200 In-Reply-To: <20220523083332.21626-1-mail@cbaines.net> References: <20220523083332.21626-1-mail@cbaines.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55591 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Montag, dem 23.05.2022 um 09:33 +0100 schrieb Christopher Baines: > --- >  gnu/platform.scm                   | 6 +++++- >  guix/build-system/linux-module.scm | 3 ++- >  2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/gnu/platform.scm b/gnu/platform.scm > index fdc3685e7c..91a1854e68 100644 > --- a/gnu/platform.scm > +++ b/gnu/platform.scm > @@ -66,10 +66,14 @@ (define-record-type* platform make- > platform >    platform? >    (target               platform-target) >    (system               platform-system) > -  (linux-architecture   platform-linux-architecture > +  (linux-architecture   platform-linux-architecture* >                          (default #f)) >    (glibc-dynamic-linker platform-glibc-dynamic-linker)) >   > +;; Provide a procedure so this can be used via module-ref > +(define (platform-linux-architecture platform) > +  (platform-linux-architecture* platform)) > + I'd use a percent prefix if the problem is that platform-linux- architecture can not be called. >  ;;; >  ;;; Platforms. > diff --git a/guix/build-system/linux-module.scm b/guix/build- > system/linux-module.scm > index 761ebe25b1..78a3ba95b2 100644 > --- a/guix/build-system/linux-module.scm > +++ b/guix/build-system/linux-module.scm > @@ -51,7 +51,8 @@ (define (default-linux) >   >  (define (system->arch system) >    (let ((module (resolve-interface '(gnu platform)))) > -    ((module-ref module 'lookup-platform-by-target-or-system) > system))) > +    ((module-ref module 'platform-linux-architecture) > +     ((module-ref module 'lookup-platform-by-target-or-system) > system)))) Why not add a helper function named lookup-platform-architecture-by- target-or-system to (gnu platform), which performs the lookup followed by the platform-linux-architecture accessor? Cheers From debbugs-submit-bounces@debbugs.gnu.org Tue May 24 16:11:53 2022 Received: (at control) by debbugs.gnu.org; 24 May 2022 20:11:53 +0000 Received: from localhost ([127.0.0.1]:53555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntasd-0006au-4c for submit@debbugs.gnu.org; Tue, 24 May 2022 16:11:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntasN-0006aO-Ab for control@debbugs.gnu.org; Tue, 24 May 2022 16:11:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntasI-0002kQ-2t for control@debbugs.gnu.org; Tue, 24 May 2022 16:11:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=6MddRHNFvsb5GYecdF/csislASS5GjN8E4zWsxxJteA=; b=OzvVmsrox6pCNU Mr8vjESFhoOSb4nqgpWyfNO6HtMEONnmNtFxRnerPCO7TfuhZviHlG+MQ0L/u6S0yF6rYm0SZMwFS 89qQz/QsKyzk/01jysV6VV0Y178p+kb221Ol/PSxXNm4oJ5CP9OTxkUrc5X8CrM8d4EahmX2IiOAZ eYsIy0AWR5pYrUVz3X+ZesZjIEKRzv8/5yzq6RgKV51VYiHNka/lWuZ9NC6EhzuykTugJQwNASA6f aMQ91hfrgWTS6fc55JqSqq/TMwpa4NOEmRXYUPVvqrynZYRFJm+/mioQ2O48VFe/JVHrq8Jy5eRYC uI2+Y2oa8Jwz/C/7x1YQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:52461 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntasH-00049i-Mh for control@debbugs.gnu.org; Tue, 24 May 2022 16:11:25 -0400 Date: Tue, 24 May 2022 22:11:23 +0200 Message-Id: <87r14iitck.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #55591 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) severity 55591 important quit From debbugs-submit-bounces@debbugs.gnu.org Wed May 25 03:37:25 2022 Received: (at 55591-done) by debbugs.gnu.org; 25 May 2022 07:37:25 +0000 Received: from localhost ([127.0.0.1]:54219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntla8-0003Le-PW for submit@debbugs.gnu.org; Wed, 25 May 2022 03:37:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntla6-0003LF-36 for 55591-done@debbugs.gnu.org; Wed, 25 May 2022 03:37:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntla0-0006Nq-RN; Wed, 25 May 2022 03:37:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=w6+FUUPUnRKAfswdXwwpTvzBDlQ1ONIWYJ65JSs3MSg=; b=CrTBTClZFET5AP7fo8mQ pPcTpGNbMqMEgE6pwXEJrY/7xGJq/wxoOTjjp4ZOAkn/nc5OQoWGK7jPqQ6I6gtFyDZmcr8mlaYlH WrMIFq5DBbmO4BB0YlSWixM8CjRAGP8CCmpJEJVf7hlAghItv7+JgAaCfqNFof8r3GvOJNj07BkOM pi7+3RqRQRxuwuCUA7IN5R7vLI/pwGS8MJ5/QwsxYtZvi+KYD+i7R/+0TloN3VhL8ncvdht5Dsqrc AddXEjfUW1eC8vzMSvBJzHPp8akEYIv8+3sm1JBZeXaK2Amv8sL76OxCDOnmqYy2cgxPLC7vfObLw DVZd7G+RKULAKw==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2774.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2774]:36492 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntla0-0005x7-5B; Wed, 25 May 2022 03:37:16 -0400 From: Mathieu Othacehe To: Christopher Baines Subject: Re: bug#55591: [PATCH] WIP: fix the linux build system References: <20220523083332.21626-1-mail@cbaines.net> Date: Wed, 25 May 2022 09:37:13 +0200 In-Reply-To: <20220523083332.21626-1-mail@cbaines.net> (Christopher Baines's message of "Mon, 23 May 2022 09:33:32 +0100") Message-ID: <874k1exdue.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55591-done Cc: 55591-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Chris, > +;; Provide a procedure so this can be used via module-ref > +(define (platform-linux-architecture platform) > + (platform-linux-architecture* platform)) Thanks for the patch! I guess it could have been a way to fix the issue. Josselin proposed to move the platform part to (guix platform) instead in the merged 55602 ticket. Closing that one as it is not needed anymore. Thanks, Mathieu From unknown Sat Aug 16 12:46:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Jun 2022 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator