From unknown Tue Aug 19 05:10:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#55590 <55590@debbugs.gnu.org> To: bug#55590 <55590@debbugs.gnu.org> Subject: Status: 29.0.50; Eshell subcommands clobber pipelines and produce incorrect output Reply-To: bug#55590 <55590@debbugs.gnu.org> Date: Tue, 19 Aug 2025 12:10:18 +0000 retitle 55590 29.0.50; Eshell subcommands clobber pipelines and produce inc= orrect output reassign 55590 emacs submitter 55590 Jim Porter severity 55590 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun May 22 23:35:03 2022 Received: (at submit) by debbugs.gnu.org; 23 May 2022 03:35:03 +0000 Received: from localhost ([127.0.0.1]:46793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsyqV-0007kv-2S for submit@debbugs.gnu.org; Sun, 22 May 2022 23:35:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:55348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsyqT-0007kn-S0 for submit@debbugs.gnu.org; Sun, 22 May 2022 23:35:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsyqT-0003hl-M9 for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 23:35:01 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:44580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nsyqR-0000em-Ut for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 23:35:01 -0400 Received: by mail-pg1-x52d.google.com with SMTP id v10so12557498pgl.11 for ; Sun, 22 May 2022 20:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:message-id:date:mime-version:content-language :content-transfer-encoding; bh=d3niCdxi+cFmV0C5EygKLVztfQ8mhaV9KIpOE73flVk=; b=OIsr6X8bEcfHRg2M4VO5zT4cZ24s84rnbTSgNg+do9iirRCZjSkIQH+drTth+CQ4Tf KdeJvvBjo72HZCka4PHo0TKk7quAQjEgG4Jhsf1bEy+CBHnZJJj4G+p6QyMjwMw27Xvq c0GnROBHq+6rj8sJTrN0MeZczmeW0tS33NfsxagBg/VfHtfghz/EY0B/WGw4WZvuqFoh h0JjBWBXQjp7vIwgnMFGuJ6THghmhMxV5bhANY2WMspwD2FQBwX8/WqHIn13j2jsHT+f Rqz5SSkb5fS3EZQtZQzdPI5C0YxOR+a4nyR1EfAcSMa9zhb6tjJubAo4AA9n9UpUfnl6 pCsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:message-id:date:mime-version :content-language:content-transfer-encoding; bh=d3niCdxi+cFmV0C5EygKLVztfQ8mhaV9KIpOE73flVk=; b=ZT+wEWVRqPRRLeEqUK8ywoWlDzbMWCYLFmPxbnLDw0wmvu3hPq8xhG3sA1HdSGybWe VPX2J7sZ3vLRSmjAPA0JqYmb1VDdsHjVxSvL2QOBnX2Mgarlp6+GWxbHP5eztC+HFJZZ 3HLDfChswM+Smn7wrRM7bNBhLQgYy2B8M3stf7fKKkt5hS7PnMnjGSaoD5RbcXb7qT+W hbNWSTdjFH4oJyPkuPhWb/xABvvERcH7Hdq7j4/RjBrfEQ2+4TJ5AxNiEhZA/xrH7oKw +09oQJr7MnbE8L9g4mR04BcUjg80omK+BOF8wBUdBg6XkHBxfn4otHeFO1qJs9sU2JXJ 9lEQ== X-Gm-Message-State: AOAM530hLxoRBfBgcE0jj2UWE3pPs/MxmLW+xuH7/rdZsAdplvt6kbnP t+MjiaKK23Jluen00sSBeOL9lroriLw= X-Google-Smtp-Source: ABdhPJyfDGvHa9hmJUiaI7Uu7XC1p1wlBDOOo4knluxCrD6d4JWbrlNYg1HL1SnAfkoJRH4h7qiW/Q== X-Received: by 2002:a05:6a00:1a08:b0:510:a1db:1a91 with SMTP id g8-20020a056a001a0800b00510a1db1a91mr21593577pfv.69.1653276898174; Sun, 22 May 2022 20:34:58 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id f18-20020aa79692000000b00512d13016d0sm5921030pfk.159.2022.05.22.20.34.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 May 2022 20:34:57 -0700 (PDT) X-Mozilla-News-Host: news://news.gmane.org:119 From: Jim Porter Subject: 29.0.50; Eshell subcommands clobber pipelines and produce incorrect output To: bug-gnu-emacs@gnu.org Message-ID: <6cc569a4-3512-d546-3f39-76f3d61436ac@gmail.com> Date: Sun, 22 May 2022 20:34:57 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=jporterbugs@gmail.com; helo=mail-pg1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Starting from `emacs -Q -f eshell', enter the following command: echo ${*echo hi} | rev The output is: ~ $ ih That is, the output of the command ended up *after* the prompt, when it should be before. This usually happens in cases where Eshell thinks all the subprocesses in a command have finished, but there's actually one still running. In this case, it's because the ${SUBCOMMAND} clobbers the headproc/tailproc values being recorded for the (outer) pipeline. Both the top-level command and the subcommand call `eshell-execute-pipeline', and the function isn't properly reentrant. Patch forthcoming momentarily. I'm just getting a bug number first. From debbugs-submit-bounces@debbugs.gnu.org Sun May 22 23:43:37 2022 Received: (at 55590) by debbugs.gnu.org; 23 May 2022 03:43:37 +0000 Received: from localhost ([127.0.0.1]:46807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsyyn-0007yJ-Go for submit@debbugs.gnu.org; Sun, 22 May 2022 23:43:37 -0400 Received: from mail-pj1-f47.google.com ([209.85.216.47]:53800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsyyl-0007y3-3i for 55590@debbugs.gnu.org; Sun, 22 May 2022 23:43:35 -0400 Received: by mail-pj1-f47.google.com with SMTP id z11so3035004pjc.3 for <55590@debbugs.gnu.org>; Sun, 22 May 2022 20:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:references:message-id:date:mime-version:in-reply-to :content-language; bh=dOPg67erk1/PJFbeP5RjTeXD0WmtWlndShy22rLoIwg=; b=VO2kPG1x5qnV22UvFUyI9XFSdjC9tZVKERkS8Uhkbp/J7hSLrVzSPVTRZfPRzxcUOv fkYoy60N5wVHQS6NX8whSZNQtMy6qC2UrrRk1U97ZUX0i4WdLfKzo3MvTxqzV5rm3vLA F2ge8Iuo4ANO77C4gFNvu3wcTKtCZvcy5ZDvuI/nIqT5voDfOeFK7Q5lJZxtJTgycFwS WXdNE7oNpdZvIxxpuk30f1fjljsLtA38CEcgc0L0lI59C/3QEHavSb7MetX/S1see78G ChCwFjQJWKXZNINw1o8kZC5iAl+EP6cDLzuiespFCimQEB7CgWNhNlwSDygfmFILdrQL d3IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-language; bh=dOPg67erk1/PJFbeP5RjTeXD0WmtWlndShy22rLoIwg=; b=RwY5mADqBp2aQvcJR4KZ0hufUrw3GKoCSup1EQR8m83S29PH/UV4fCvdeu2bjoCDey 0ftQL7jUdQxyIEbUJUfY9Kpso58bPcCeoORkc4jp5k/Zdi6kAedRnnAE1JG/VNztMSCc uIJi42yZlIFgqEfv7zDQRpwkf6WYboaqMSZHIX2fo5vVUd14zDHEZ68CrgLq1ATsKBF1 t3iDrTxGeVbaH5iy662TG98Fs9dmIz+tGhlcYof/SOkcudRuP/OwV4tf1T47QJ+y54xi z8KB12la+rs1gA4LuEqG/0IsJJpEZBTjvOcKd2LSKUa76MS8PqA8a8hUAMwiEBfhXh6M Z64Q== X-Gm-Message-State: AOAM533gD5w2PJMvp9AFquVwoHB9gtENRzex+SkLaga6esUsKNcjQJoP z0W5ZZx486/QzuoTfrQgqBcKEDvX6cs= X-Google-Smtp-Source: ABdhPJye9RwglO2acyDyCV9mqNdR03fUE4EmKAQgMEYhlWmrFc/T7n/uTlIC70mXG6GEK728qJExHw== X-Received: by 2002:a17:90a:dd46:b0:1b8:8:7303 with SMTP id u6-20020a17090add4600b001b800087303mr24711219pjv.197.1653277408902; Sun, 22 May 2022 20:43:28 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id p29-20020a63951d000000b003c265b7d4f6sm3705038pgd.44.2022.05.22.20.43.28 for <55590@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 May 2022 20:43:28 -0700 (PDT) Subject: Re: bug#55590: [PATCH] 29.0.50; Eshell subcommands clobber pipelines and produce incorrect output From: Jim Porter To: 55590@debbugs.gnu.org References: <6cc569a4-3512-d546-3f39-76f3d61436ac@gmail.com> Message-ID: <788e86e0-9358-2018-caae-71862d3b2442@gmail.com> Date: Sun, 22 May 2022 20:43:28 -0700 MIME-Version: 1.0 In-Reply-To: <6cc569a4-3512-d546-3f39-76f3d61436ac@gmail.com> Content-Type: multipart/mixed; boundary="------------282F1387BD09E1F66DBA6806" Content-Language: en-US X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55590 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------282F1387BD09E1F66DBA6806 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 5/22/2022 8:34 PM, Jim Porter wrote: > Starting from `emacs -Q -f eshell', enter the following command: > >   echo ${*echo hi} | rev > > The output is: > >   ~ $ ih > > That is, the output of the command ended up *after* the prompt, when it > should be before. The attached patch fixes this issue. It might not be the *best* way to do it, but it's the least-invasive I could come up with. The `make-symbol' dance is a bit awkward, but Eshell already uses it for `eshell-command-to-value' / `eshell-do-command-to-value', so hopefully it's ok. I'm open to other solutions though. It's possible the bug is really in `eshell-do-eval', since I'd expect the original code to work, but `eshell-do-eval' is pretty tricky, and I don't want to poke at it too hard for fear that other things will break. Long-term, the best way to fix this might be to rip out `eshell-do-eval' entirely, which iteratively evaluates parts of Eshell commands (so as not to hang Emacs) and use the generator.el machinery instead. I looked into that briefly, and it seems like it would be quite a bit of work. And I don't fully understand generator.el's implementation yet anyway... --------------282F1387BD09E1F66DBA6806 Content-Type: text/plain; charset=UTF-8; name="0001-Keep-subcommands-in-pipelines-from-clobbering-the-he.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Keep-subcommands-in-pipelines-from-clobbering-the-he.pa"; filename*1="tch" RnJvbSA5NWQ2YmNjMzcwYjA5OGI1MjRmZmRlMjUxMDFmNjg0ZDMyN2E3NTg0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjIgTWF5IDIwMjIgMTc6Mjc6NDggLTA3MDAKU3ViamVjdDogW1BB VENIXSBLZWVwIHN1YmNvbW1hbmRzIGluIHBpcGVsaW5lcyBmcm9tIGNsb2JiZXJpbmcgdGhl IGhlYWQvdGFpbAogcHJvY2Vzc2VzCgoqIGxpc3AvZXNoZWxsL2VzaC1jbWQuZWwgKGVzaGVs bC1leGVjdXRlLXBpcGVsaW5lKTogVXNlICdtYWtlLXN5bWJvbCcKZm9yIGhlYWRwcm9jIGFu ZCB0YWlscHJvYy4KKGVzaGVsbC1kby1waXBlbGluZXMsIGVzaGVsbC1kby1waXBlbGluZXMt c3luY2hyb25vdXNseSk6IEFkYXB0IHRvIHRoZQphYm92ZS4KCiogdGVzdC9saXNwL2VzaGVs bC9lc2hlbGwtdGVzdHMuZWwgKGVzaGVsbC10ZXN0L3BpcGUtc3ViY29tbWFuZCk6IE5ldwp0 ZXN0IChidWcjNTU1OTApLgotLS0KIGxpc3AvZXNoZWxsL2VzaC1jbWQuZWwgICAgICAgICAg IHwgMTUgKysrKysrKysrKy0tLS0tCiB0ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5l bCB8ICA4ICsrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDUg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbCBiL2xp c3AvZXNoZWxsL2VzaC1jbWQuZWwKaW5kZXggNDI2MTZlNzAzNy4uNzNjMjUwNjMyYyAxMDA2 NDQKLS0tIGEvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbAorKysgYi9saXNwL2VzaGVsbC9lc2gt Y21kLmVsCkBAIC04MjcsOCArODI3LDggQEAgZXNoZWxsLWRvLXBpcGVsaW5lcwogCQkgICAg ICAoKGNkciBwaXBlbGluZSkgdCkKIAkJICAgICAgKHQgKHF1b3RlICdsYXN0KSkpKSkKICAg ICAgICAgICAobGV0ICgocHJvYyAsKGNhciBwaXBlbGluZSkpKQotICAgICAgICAgICAgKHNl dHEgaGVhZHByb2MgKG9yIHByb2MgaGVhZHByb2MpKQotICAgICAgICAgICAgKHNldHEgdGFp bHByb2MgKG9yIHRhaWxwcm9jIHByb2MpKQorICAgICAgICAgICAgKHNldCBoZWFkcHJvYyAo b3IgcHJvYyAoc3ltYm9sLXZhbHVlIGhlYWRwcm9jKSkpCisgICAgICAgICAgICAoc2V0IHRh aWxwcm9jIChvciAoc3ltYm9sLXZhbHVlIHRhaWxwcm9jKSBwcm9jKSkKICAgICAgICAgICAg IHByb2MpKSkpKSkKIAogKGRlZm1hY3JvIGVzaGVsbC1kby1waXBlbGluZXMtc3luY2hyb25v dXNseSAocGlwZWxpbmUpCkBAIC04NjEsNyArODYxLDcgQEAgZXNoZWxsLWRvLXBpcGVsaW5l cy1zeW5jaHJvbm91c2x5CiAgICAgICAgKGxldCAoKHJlc3VsdCAsKGNhciBwaXBlbGluZSkp KQogICAgICAgICAgOzsgdGFpbHByb2MgZ2V0cyB0aGUgcmVzdWx0IG9mIHRoZSBsYXN0IHN1 Y2Nlc3NmdWwgcHJvY2VzcyBpbgogICAgICAgICAgOzsgdGhlIHBpcGVsaW5lLgotICAgICAg ICAgKHNldHEgdGFpbHByb2MgKG9yIHJlc3VsdCB0YWlscHJvYykpCisgICAgICAgICAoc2V0 IHRhaWxwcm9jIChvciByZXN1bHQgKHN5bWJvbC12YWx1ZSB0YWlscHJvYykpKQogICAgICAg ICAgLChpZiAoY2RyIHBpcGVsaW5lKQogICAgICAgICAgICAgICBgKGVzaGVsbC1kby1waXBl bGluZXMtc3luY2hyb25vdXNseSAocXVvdGUgLChjZHIgcGlwZWxpbmUpKSkpCiAgICAgICAg ICByZXN1bHQpKSkpCkBAIC04NzAsNyArODcwLDExIEBAICdlc2hlbGwtcHJvY2Vzcy1pZGVu dGl0eQogCiAoZGVmbWFjcm8gZXNoZWxsLWV4ZWN1dGUtcGlwZWxpbmUgKHBpcGVsaW5lKQog ICAiRXhlY3V0ZSB0aGUgY29tbWFuZHMgaW4gUElQRUxJTkUsIGNvbm5lY3RpbmcgZWFjaCB0 byBvbmUgYW5vdGhlci4iCi0gIGAobGV0ICgoZXNoZWxsLWluLXBpcGVsaW5lLXAgdCkgaGVh ZHByb2MgdGFpbHByb2MpCisgIGAobGV0ICgoZXNoZWxsLWluLXBpcGVsaW5lLXAgdCkKKyAg ICAgICAgIChoZWFkcHJvYyAobWFrZS1zeW1ib2wgImhlYWRwcm9jIikpCisgICAgICAgICAo dGFpbHByb2MgKG1ha2Utc3ltYm9sICJ0YWlscHJvYyIpKSkKKyAgICAgKHNldCBoZWFkcHJv YyBuaWwpCisgICAgIChzZXQgdGFpbHByb2MgbmlsKQogICAgICAocHJvZ24KICAgICAgICAs KGlmIChmYm91bmRwICdtYWtlLXByb2Nlc3MpCiAJICAgIGAoZXNoZWxsLWRvLXBpcGVsaW5l cyAscGlwZWxpbmUpCkBAIC04ODAsNyArODg0LDggQEAgZXNoZWxsLWV4ZWN1dGUtcGlwZWxp bmUKIAkJCQkoY2FyIChhcmVmIGVzaGVsbC1jdXJyZW50LWhhbmRsZXMKIAkJCQkJICAgLGVz aGVsbC1lcnJvci1oYW5kbGUpKSBuaWwpKSkKIAkgICAgIChlc2hlbGwtZG8tcGlwZWxpbmVz LXN5bmNocm9ub3VzbHkgLHBpcGVsaW5lKSkpCi0gICAgICAgKGVzaGVsbC1wcm9jZXNzLWlk ZW50aXR5IChjb25zIGhlYWRwcm9jIHRhaWxwcm9jKSkpKSkKKyAgICAgICAoZXNoZWxsLXBy b2Nlc3MtaWRlbnRpdHkgKGNvbnMgKHN5bWJvbC12YWx1ZSBoZWFkcHJvYykKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN5bWJvbC12YWx1ZSB0YWlscHJvYykp KSkpKQogCiAoZGVmbWFjcm8gZXNoZWxsLWFzLXN1YmNvbW1hbmQgKGNvbW1hbmQpCiAgICJF eGVjdXRlIENPTU1BTkQgdXNpbmcgYSB0ZW1wIGJ1ZmZlci4KZGlmZiAtLWdpdCBhL3Rlc3Qv bGlzcC9lc2hlbGwvZXNoZWxsLXRlc3RzLmVsIGIvdGVzdC9saXNwL2VzaGVsbC9lc2hlbGwt dGVzdHMuZWwKaW5kZXggN2NkZWIwMTdlNC4uZGNiNzAzYzczZiAxMDA2NDQKLS0tIGEvdGVz dC9saXNwL2VzaGVsbC9lc2hlbGwtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9l c2hlbGwtdGVzdHMuZWwKQEAgLTExNCw2ICsxMTQsMTQgQEAgZXNoZWxsLXRlc3QvcGlwZS1o ZWFkcHJvYy1zdGRpbgogICAgKGVzaGVsbC13YWl0LWZvci1zdWJwcm9jZXNzKQogICAgKGVz aGVsbC1tYXRjaC1yZXN1bHQgIk9MTEVIXG4iKSkpCiAKKyhlcnQtZGVmdGVzdCBlc2hlbGwt dGVzdC9waXBlLXN1YmNvbW1hbmQgKCkKKyAgIkNoZWNrIHRoYXQgcGlwaW5nIHdpdGggYXN5 bmNocm9ub3VzIHN1YmNvbW1hbmRzIHdvcmtzIgorICAoc2tpcC11bmxlc3MgKGFuZCAoZXhl Y3V0YWJsZS1maW5kICJlY2hvIikKKyAgICAgICAgICAgICAgICAgICAgKGV4ZWN1dGFibGUt ZmluZCAiY2F0IikpKQorICAod2l0aC10ZW1wLWVzaGVsbAorICAgKGVzaGVsbC1jb21tYW5k LXJlc3VsdC1wICJlY2hvICR7KmVjaG8gaGl9IHwgKmNhdCIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAiaGkiKSkpCisKIChlcnQtZGVmdGVzdCBlc2hlbGwtdGVzdC9yZWRpcmVj dC1idWZmZXIgKCkKICAgIkNoZWNrIHRoYXQgcGlwaW5nIHRvIGEgYnVmZmVyIHdvcmtzIgog ICAod2l0aC10ZW1wLWJ1ZmZlcgotLSAKMi4yNS4xCgo= --------------282F1387BD09E1F66DBA6806-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 23 01:39:29 2022 Received: (at 55590) by debbugs.gnu.org; 23 May 2022 05:39:29 +0000 Received: from localhost ([127.0.0.1]:47055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt0mv-0005D7-0R for submit@debbugs.gnu.org; Mon, 23 May 2022 01:39:29 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt0mr-0005Cq-Mh for 55590@debbugs.gnu.org; Mon, 23 May 2022 01:39:28 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 68EDB5C008B; Mon, 23 May 2022 01:39:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 23 May 2022 01:39:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1653284359; x= 1653370759; bh=LNLvSsrOu0YTxGs27duAAgVFqM8Z2XzOkteAXGGu980=; b=N 5LUl/68LYDYYOio0ztooMAd1P9uW7q+ehIOkTTaZq41OFgE+tIBAtZZfVclHW88T EOSc1gdQGNPCSJWrDIu9FOlrapGPJGZQrVVlVy2zw0NdVF5SEMKtz6HvHSkjfpv+ XgpsRhEqEFEZETy51sZly4uV8AMNchdCV+7k36xTOcPImE/T129D3n9BUWqwVeB/ OGMj08hdtR8Ely8UBCjcCk/4DRly5BR0gwqDWyj3bXjR8TozHPIR2301QKm2SmJD EZVpDzEd8xY8g8WVDNbN792XmEHa1pYCdu5xCHADnzkIz5SMm+dDSzyXJgdIbDnM D8mZPp3OsH441/izCnSAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1653284359; x=1653370759; bh=L NLvSsrOu0YTxGs27duAAgVFqM8Z2XzOkteAXGGu980=; b=vbX2vIkMTSHN6qQC6 ICEKDYYhH0a5vTiOL545iKGB8F0/BrBFK81O7O1SLNoiTZgjN5jv1qPyRMp9hG8f NPTPXpw3AVjgqhPGXzMwDD150y3Iw7OGZZpY0pIYniyZsMy9wXBTAewdvdA2Ho8c dbeKSOncDYac/TikhBT66Jqv//ADT+YtQP6mHlZXZRvpQ4ICdg7Cvt33TEQ22mOZ Z2Bu0Ab/+643OCdC5vvIKJix7JcnBLwuCQrlqLQ/LhE1A/23hsAdKTv0jmb+mFRB QehAbfdioRvo0Il8P/YQ/8q3s8P/xzQuy/fPdpEcQ7Pd4MMpq3kNpM6QRv0h8ZFT L6GVA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieelgdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtgfesthhqtd dttderjeenucfhrhhomhepufgvrghnucghhhhithhtohhnuceoshhpfihhihhtthhonhes shhpfihhihhtthhonhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeelgfffjeevleelhe ekuedvkedtvddufeffueejgeeihfekjeegfefftdegheekffenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhh hithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 May 2022 01:39:19 -0400 (EDT) Received: by athena.silentflame.com (Postfix, from userid 1000) id 17A851B5F4C; Mon, 23 May 2022 05:39:18 +0000 (UTC) From: Sean Whitton To: Jim Porter , 55590@debbugs.gnu.org Subject: Re: bug#55590: [PATCH] 29.0.50; Eshell subcommands clobber pipelines and produce incorrect output In-Reply-To: <788e86e0-9358-2018-caae-71862d3b2442@gmail.com> References: <6cc569a4-3512-d546-3f39-76f3d61436ac@gmail.com> <788e86e0-9358-2018-caae-71862d3b2442@gmail.com> User-Agent: Notmuch/0.36 Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Sun, 22 May 2022 22:39:18 -0700 Message-ID: <87v8twx0xl.fsf@athena.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55590 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Jim, On Sun 22 May 2022 at 08:43pm -07, Jim Porter wrote: > On 5/22/2022 8:34 PM, Jim Porter wrote: >> Starting from `emacs -Q -f eshell', enter the following command: >> >> =C2=A0 echo ${*echo hi} | rev >> >> The output is: >> >> =C2=A0 ~ $ ih >> >> That is, the output of the command ended up *after* the prompt, when it >> should be before. > > The attached patch fixes this issue. It might not be the *best* way to > do it, but it's the least-invasive I could come up with. The > `make-symbol' dance is a bit awkward, but Eshell already uses it for > `eshell-command-to-value' / `eshell-do-command-to-value', so hopefully > it's ok. Couldn't you just defvar a couple of vars for this purpose? --=20 Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Mon May 23 11:41:21 2022 Received: (at 55590) by debbugs.gnu.org; 23 May 2022 15:41:21 +0000 Received: from localhost ([127.0.0.1]:50052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntABN-0007UI-41 for submit@debbugs.gnu.org; Mon, 23 May 2022 11:41:21 -0400 Received: from mail-pl1-f182.google.com ([209.85.214.182]:42694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntABM-0007U3-0O for 55590@debbugs.gnu.org; Mon, 23 May 2022 11:41:20 -0400 Received: by mail-pl1-f182.google.com with SMTP id d22so13443346plr.9 for <55590@debbugs.gnu.org>; Mon, 23 May 2022 08:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:references:from:message-id:date:mime-version:in-reply-to :content-language; bh=dwr3cIFa14wPOxmUtpgbE76EqGPhkIVEMlyUfrSMyhI=; b=CUjDHanyV31n2pmcwzPGkK2k+KlVVEZ1r2cmW0mZoe0W+CzgSbfdyY8GqMbJcgfoYZ vYRu+it1+XbmL/DHz15ImBSQZ6/l4AjpmyacFiCn98Ebxhne4roQpGZKyMIY4xUReBHQ PubPDVnbra0Ce3qdY2SZaxffwDgP1Sy//IgcAoVBXAZks98jclCvGjq92wHDX2TQU7QO eZlszi2xBKZL2JNQNM/JYSy1scmUU2MWLcYenAL0AXLjTbpS/spVD4ntJhEj86fvRU5+ RPUFv34wOBYqo43KG89bg0AFXd995q/QAdfK0p0zY3QcNSTsbZ7gNxm6ZggRhy9tnQ/N ZqoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=dwr3cIFa14wPOxmUtpgbE76EqGPhkIVEMlyUfrSMyhI=; b=hp82Vy9WEG0V58eeHiXqxae5U/VFow5P5KsLne0rqUiyagrjyVTKA02qrRsUMgc2+S baO+bRWBx5gUssEExUpUTjTSvrSjbkCIP7up9QeKp8wAXQadmzPzP8yJTetwONy5y9E8 w8K3Nihq3oPqI6u3P+YulM2PSMKAwfRMCyX3P/eRV/uBD47Zv6rRI9jBUuDbnvpDlAIJ i6+X7AnrTMq2J4AE7alWO6URQdYR0HySNfMaLdfxUo+rqDgaAZ1ctwb2jlIu/ELeRfZV UX9d1IarJ4dhRYcMIhcnvcrhpRpsIzO9MUwgRTkDrSrGvHrJt8DfAg8TERMEFIXc7Xpk w3vw== X-Gm-Message-State: AOAM532gsb7F2JMvd3NHdwjSA49qfuMfSql8SmAq+p9XQiyN2Pg8+bNz zFyACKdttX1TRp05An10V00MU4I8TSs= X-Google-Smtp-Source: ABdhPJx9wFlZxXizpPljNgeR1eKSAc5D/2KBpLxZSHfuqNQC6a0aOgT5363xfTFUHQI7K9V2o5e9pg== X-Received: by 2002:a17:90a:3e81:b0:1df:4c26:1786 with SMTP id k1-20020a17090a3e8100b001df4c261786mr26694262pjc.126.1653320473991; Mon, 23 May 2022 08:41:13 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a9-20020a62bd09000000b0051827128aeasm7334128pff.131.2022.05.23.08.41.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 08:41:13 -0700 (PDT) Subject: Re: bug#55590: [PATCH v2] 29.0.50; Eshell subcommands clobber pipelines and produce incorrect output To: Sean Whitton , 55590@debbugs.gnu.org References: <6cc569a4-3512-d546-3f39-76f3d61436ac@gmail.com> <788e86e0-9358-2018-caae-71862d3b2442@gmail.com> <87v8twx0xl.fsf@athena.silentflame.com> From: Jim Porter Message-ID: Date: Mon, 23 May 2022 08:41:14 -0700 MIME-Version: 1.0 In-Reply-To: <87v8twx0xl.fsf@athena.silentflame.com> Content-Type: multipart/mixed; boundary="------------F080509A770D2816A1DFDE76" Content-Language: en-US X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55590 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------F080509A770D2816A1DFDE76 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 5/22/2022 10:39 PM, Sean Whitton wrote: > On Sun 22 May 2022 at 08:43pm -07, Jim Porter wrote: >> On 5/22/2022 8:34 PM, Jim Porter wrote: >>> Starting from `emacs -Q -f eshell', enter the following command: >>> >>>   echo ${*echo hi} | rev >>> >>> The output is: >>> >>>   ~ $ ih >>> >>> That is, the output of the command ended up *after* the prompt, when it >>> should be before. [snip] > > Couldn't you just defvar a couple of vars for this purpose? Do you mean just defvar-ing `headproc' and `tailproc' (and renaming them, of course)? That works for my example above, but falls apart for more complex cases such as: echo ${*echo hi | rev} | tr a-z A-Z The Eshell manual also says the following command is broken (output comes after the prompt). It works correctly with my patch, but just adding defvars isn't enough: for i in 1 2 3 { grep -q a b && *echo hi } | wc -l The "Command evaluation macros" comment section in lisp/eshell/esh-cmd.el indicates that there are some odd limitations on these macros, so that might be part of the issue. I'm still a bit confused as to why the dance in my patch is necessary, but I'm ok with any implementation that passes the tests. Attached is an updated patch with an additional test for the more-complex case and the manual entry about this bug removed. --------------F080509A770D2816A1DFDE76 Content-Type: text/plain; charset=UTF-8; name="0001-Keep-subcommands-in-pipelines-from-clobbering-the-he.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Keep-subcommands-in-pipelines-from-clobbering-the-he.pa"; filename*1="tch" RnJvbSA4NDY3NzIzN2FmMmI4ZmI3NDcwMmI0MjBjNGY5MjE0Y2E1MzczMzliIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjIgTWF5IDIwMjIgMTc6Mjc6NDggLTA3MDAKU3ViamVjdDogW1BB VENIXSBLZWVwIHN1YmNvbW1hbmRzIGluIHBpcGVsaW5lcyBmcm9tIGNsb2JiZXJpbmcgdGhl IGhlYWQvdGFpbAogcHJvY2Vzc2VzCgoqIGxpc3AvZXNoZWxsL2VzaC1jbWQuZWwgKGVzaGVs bC1leGVjdXRlLXBpcGVsaW5lKTogVXNlICdtYWtlLXN5bWJvbCcKZm9yIGhlYWRwcm9jIGFu ZCB0YWlscHJvYy4KKGVzaGVsbC1kby1waXBlbGluZXMsIGVzaGVsbC1kby1waXBlbGluZXMt c3luY2hyb25vdXNseSk6IEFkYXB0IHRvIHRoZQphYm92ZS4KCiogdGVzdC9saXNwL2VzaGVs bC9lc2hlbGwtdGVzdHMuZWwgKGVzaGVsbC10ZXN0L3BpcGUtc3ViY29tbWFuZCkKKGVzaGVs bC10ZXN0L3BpcGUtc3ViY29tbWFuZC13aXRoLXBpcGUpOiBOZXcgdGVzdC4KCiogZG9jL21p c2MvZXNoZWxsLnRleGkgKEJ1Z3MgYW5kIGlkZWFzKTogUmVtb3ZlIGl0ZW0gYWJvdXQgcGlw aW5nIHRvCnByb2Nlc3MgZnJvbSBsb29wOyB0aGlzIGNvbW1pdCBmaXhlcyBpdCAoYnVnIzU1 NTkwKS4KLS0tCiBkb2MvbWlzYy9lc2hlbGwudGV4aSAgICAgICAgICAgICB8ICA4IC0tLS0t LS0tCiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsICAgICAgICAgICB8IDE1ICsrKysrKysrKyst LS0tLQogdGVzdC9saXNwL2VzaGVsbC9lc2hlbGwtdGVzdHMuZWwgfCAxNiArKysrKysrKysr KysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2RvYy9taXNjL2VzaGVsbC50ZXhpIGIvZG9jL21pc2MvZXNo ZWxsLnRleGkKaW5kZXggZDM1YTY0MmI2Mi4uODVlNWE0OTMzZiAxMDA2NDQKLS0tIGEvZG9j L21pc2MvZXNoZWxsLnRleGkKKysrIGIvZG9jL21pc2MvZXNoZWxsLnRleGkKQEAgLTE3NTgs MTQgKzE3NTgsNiBAQCBCdWdzIGFuZCBpZGVhcwogZnVuY3Rpb24gYXJnICgpIEB7IGJsYWgg JCogQH0KIEBlbmQgZXhhbXBsZQogCi1AaXRlbSBAc2FtcHtmb3IgaSBpbiAxIDIgMyBAeyBn cmVwIC1xIGEgYiAmJiAqZWNobyBoYXMgaXQgQH0gfCB3YyAtbH0gb3V0cHV0cyByZXN1bHQg YWZ0ZXIgcHJvbXB0Ci0KLUluIGZhY3QsIHBpcGluZyB0byBhIHByb2Nlc3MgZnJvbSBhIGxv b3BpbmcgY29uc3RydWN0IGRvZXNuJ3Qgd29yayBpbgotZ2VuZXJhbC4gIElmIEkgY2hhbmdl IHRoZSBjYWxsIHRvIEBjb2Rle2VzaGVsbC1jb3B5LWhhbmRsZXN9IGluCi1AY29kZXtlc2hl bGwtcmV3cml0ZS1mb3ItY29tbWFuZH0gdG8gdXNlIEBjb2Rle2VzaGVsbC1wcm90ZWN0fSwg aXQgc2VlbXMKLXRvIHdvcmssIGJ1dCB0aGUgb3V0cHV0IG9jY3VycyBhZnRlciB0aGUgcHJv bXB0IGlzIGRpc3BsYXllZC4gIFRoZSB3aG9sZQotc3RydWN0dXJlZCBjb21tYW5kIHRoaW5n IGlzIHRvbyBjb21wbGljYXRlZCBhdCBwcmVzZW50LgotCiBAaXRlbSBQY29tcGxldGUgc29t ZXRpbWVzIGdldHMgc3R1Y2sKIAogWW91IHByZXNzIEBrZXl7VEFCfSwgYnV0IG5vIGNvbXBs ZXRpb25zIGFwcGVhciwgZXZlbiB0aG91Z2ggdGhlCmRpZmYgLS1naXQgYS9saXNwL2VzaGVs bC9lc2gtY21kLmVsIGIvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbAppbmRleCA0MjYxNmU3MDM3 Li43M2MyNTA2MzJjIDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9lc2gtY21kLmVsCisrKyBi L2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKQEAgLTgyNyw4ICs4MjcsOCBAQCBlc2hlbGwtZG8t cGlwZWxpbmVzCiAJCSAgICAgICgoY2RyIHBpcGVsaW5lKSB0KQogCQkgICAgICAodCAocXVv dGUgJ2xhc3QpKSkpKQogICAgICAgICAgIChsZXQgKChwcm9jICwoY2FyIHBpcGVsaW5lKSkp Ci0gICAgICAgICAgICAoc2V0cSBoZWFkcHJvYyAob3IgcHJvYyBoZWFkcHJvYykpCi0gICAg ICAgICAgICAoc2V0cSB0YWlscHJvYyAob3IgdGFpbHByb2MgcHJvYykpCisgICAgICAgICAg ICAoc2V0IGhlYWRwcm9jIChvciBwcm9jIChzeW1ib2wtdmFsdWUgaGVhZHByb2MpKSkKKyAg ICAgICAgICAgIChzZXQgdGFpbHByb2MgKG9yIChzeW1ib2wtdmFsdWUgdGFpbHByb2MpIHBy b2MpKQogICAgICAgICAgICAgcHJvYykpKSkpKQogCiAoZGVmbWFjcm8gZXNoZWxsLWRvLXBp cGVsaW5lcy1zeW5jaHJvbm91c2x5IChwaXBlbGluZSkKQEAgLTg2MSw3ICs4NjEsNyBAQCBl c2hlbGwtZG8tcGlwZWxpbmVzLXN5bmNocm9ub3VzbHkKICAgICAgICAobGV0ICgocmVzdWx0 ICwoY2FyIHBpcGVsaW5lKSkpCiAgICAgICAgICA7OyB0YWlscHJvYyBnZXRzIHRoZSByZXN1 bHQgb2YgdGhlIGxhc3Qgc3VjY2Vzc2Z1bCBwcm9jZXNzIGluCiAgICAgICAgICA7OyB0aGUg cGlwZWxpbmUuCi0gICAgICAgICAoc2V0cSB0YWlscHJvYyAob3IgcmVzdWx0IHRhaWxwcm9j KSkKKyAgICAgICAgIChzZXQgdGFpbHByb2MgKG9yIHJlc3VsdCAoc3ltYm9sLXZhbHVlIHRh aWxwcm9jKSkpCiAgICAgICAgICAsKGlmIChjZHIgcGlwZWxpbmUpCiAgICAgICAgICAgICAg IGAoZXNoZWxsLWRvLXBpcGVsaW5lcy1zeW5jaHJvbm91c2x5IChxdW90ZSAsKGNkciBwaXBl bGluZSkpKSkKICAgICAgICAgIHJlc3VsdCkpKSkKQEAgLTg3MCw3ICs4NzAsMTEgQEAgJ2Vz aGVsbC1wcm9jZXNzLWlkZW50aXR5CiAKIChkZWZtYWNybyBlc2hlbGwtZXhlY3V0ZS1waXBl bGluZSAocGlwZWxpbmUpCiAgICJFeGVjdXRlIHRoZSBjb21tYW5kcyBpbiBQSVBFTElORSwg Y29ubmVjdGluZyBlYWNoIHRvIG9uZSBhbm90aGVyLiIKLSAgYChsZXQgKChlc2hlbGwtaW4t cGlwZWxpbmUtcCB0KSBoZWFkcHJvYyB0YWlscHJvYykKKyAgYChsZXQgKChlc2hlbGwtaW4t cGlwZWxpbmUtcCB0KQorICAgICAgICAgKGhlYWRwcm9jIChtYWtlLXN5bWJvbCAiaGVhZHBy b2MiKSkKKyAgICAgICAgICh0YWlscHJvYyAobWFrZS1zeW1ib2wgInRhaWxwcm9jIikpKQor ICAgICAoc2V0IGhlYWRwcm9jIG5pbCkKKyAgICAgKHNldCB0YWlscHJvYyBuaWwpCiAgICAg IChwcm9nbgogICAgICAgICwoaWYgKGZib3VuZHAgJ21ha2UtcHJvY2VzcykKIAkgICAgYChl c2hlbGwtZG8tcGlwZWxpbmVzICxwaXBlbGluZSkKQEAgLTg4MCw3ICs4ODQsOCBAQCBlc2hl bGwtZXhlY3V0ZS1waXBlbGluZQogCQkJCShjYXIgKGFyZWYgZXNoZWxsLWN1cnJlbnQtaGFu ZGxlcwogCQkJCQkgICAsZXNoZWxsLWVycm9yLWhhbmRsZSkpIG5pbCkpKQogCSAgICAgKGVz aGVsbC1kby1waXBlbGluZXMtc3luY2hyb25vdXNseSAscGlwZWxpbmUpKSkKLSAgICAgICAo ZXNoZWxsLXByb2Nlc3MtaWRlbnRpdHkgKGNvbnMgaGVhZHByb2MgdGFpbHByb2MpKSkpKQor ICAgICAgIChlc2hlbGwtcHJvY2Vzcy1pZGVudGl0eSAoY29ucyAoc3ltYm9sLXZhbHVlIGhl YWRwcm9jKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3ltYm9s LXZhbHVlIHRhaWxwcm9jKSkpKSkpCiAKIChkZWZtYWNybyBlc2hlbGwtYXMtc3ViY29tbWFu ZCAoY29tbWFuZCkKICAgIkV4ZWN1dGUgQ09NTUFORCB1c2luZyBhIHRlbXAgYnVmZmVyLgpk aWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VzaGVsbC9lc2hlbGwtdGVzdHMuZWwgYi90ZXN0L2xp c3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbAppbmRleCA3Y2RlYjAxN2U0Li5jMGFmZmVkODBh IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbAorKysgYi90 ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbApAQCAtMTE0LDYgKzExNCwyMiBAQCBl c2hlbGwtdGVzdC9waXBlLWhlYWRwcm9jLXN0ZGluCiAgICAoZXNoZWxsLXdhaXQtZm9yLXN1 YnByb2Nlc3MpCiAgICAoZXNoZWxsLW1hdGNoLXJlc3VsdCAiT0xMRUhcbiIpKSkKIAorKGVy dC1kZWZ0ZXN0IGVzaGVsbC10ZXN0L3BpcGUtc3ViY29tbWFuZCAoKQorICAiQ2hlY2sgdGhh dCBwaXBpbmcgd2l0aCBhbiBhc3luY2hyb25vdXMgc3ViY29tbWFuZCB3b3JrcyIKKyAgKHNr aXAtdW5sZXNzIChhbmQgKGV4ZWN1dGFibGUtZmluZCAiZWNobyIpCisgICAgICAgICAgICAg ICAgICAgIChleGVjdXRhYmxlLWZpbmQgImNhdCIpKSkKKyAgKHdpdGgtdGVtcC1lc2hlbGwK KyAgIChlc2hlbGwtY29tbWFuZC1yZXN1bHQtcCAiZWNobyAkeyplY2hvIGhpfSB8ICpjYXQi CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgImhpIikpKQorCisoZXJ0LWRlZnRlc3Qg ZXNoZWxsLXRlc3QvcGlwZS1zdWJjb21tYW5kLXdpdGgtcGlwZSAoKQorICAiQ2hlY2sgdGhh dCBwaXBpbmcgd2l0aCBhbiBhc3luY2hyb25vdXMgc3ViY29tbWFuZCB3aXRoIGl0cyBvd24g cGlwZSB3b3JrcyIKKyAgKHNraXAtdW5sZXNzIChhbmQgKGV4ZWN1dGFibGUtZmluZCAiZWNo byIpCisgICAgICAgICAgICAgICAgICAgIChleGVjdXRhYmxlLWZpbmQgImNhdCIpKSkKKyAg KHdpdGgtdGVtcC1lc2hlbGwKKyAgIChlc2hlbGwtY29tbWFuZC1yZXN1bHQtcCAiZWNobyAk eyplY2hvIGhpIHwgKmNhdH0gfCAqY2F0IgorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICJoaSIpKSkKKwogKGVydC1kZWZ0ZXN0IGVzaGVsbC10ZXN0L3JlZGlyZWN0LWJ1ZmZlciAo KQogICAiQ2hlY2sgdGhhdCBwaXBpbmcgdG8gYSBidWZmZXIgd29ya3MiCiAgICh3aXRoLXRl bXAtYnVmZmVyCi0tIAoyLjI1LjEKCg== --------------F080509A770D2816A1DFDE76-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 24 08:58:36 2022 Received: (at 55590) by debbugs.gnu.org; 24 May 2022 12:58:36 +0000 Received: from localhost ([127.0.0.1]:51279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntU7Q-0007HT-NO for submit@debbugs.gnu.org; Tue, 24 May 2022 08:58:36 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntU7M-0007H5-5u for 55590@debbugs.gnu.org; Tue, 24 May 2022 08:58:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P7HbXAFlZYp3BxlnZQ2Os70O73Gq1rFi15hBgXTNdtA=; b=MxebgLUjR1bXaHBR4HHy/+QHuM ie3uel2cf8+zSilbgz1q3g0kTt8kyf9KM2XGZhueOMJng/92j8EX96bW3diHxG45Nu4LIYVxZcGsL x6KjdFMICMlZow86VHOxNPrQ6HDZAy8cgVT1bBPdwESWECS8lw7Vq/1BEQyGHvM4ifUM=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntU7C-0006vq-Ni; Tue, 24 May 2022 14:58:25 +0200 From: Lars Ingebrigtsen To: Jim Porter Subject: Re: bug#55590: 29.0.50; Eshell subcommands clobber pipelines and produce incorrect output References: <6cc569a4-3512-d546-3f39-76f3d61436ac@gmail.com> <788e86e0-9358-2018-caae-71862d3b2442@gmail.com> <87v8twx0xl.fsf@athena.silentflame.com> X-Now-Playing: Cris Williamson's _The Changer and the Changed_: "Shooting Star" Date: Tue, 24 May 2022 14:58:22 +0200 In-Reply-To: (Jim Porter's message of "Mon, 23 May 2022 08:41:14 -0700") Message-ID: <87fskzhytt.fsf_-_@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > Attached is an updated patch with an additional test for the > more-complex case and the manual entry about this bug removed. Thanks; pushed to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55590 Cc: 55590@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > Attached is an updated patch with an additional test for the > more-complex case and the manual entry about this bug removed. Thanks; pushed to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 24 08:58:41 2022 Received: (at control) by debbugs.gnu.org; 24 May 2022 12:58:41 +0000 Received: from localhost ([127.0.0.1]:51281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntU7U-0007He-Ta for submit@debbugs.gnu.org; Tue, 24 May 2022 08:58:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntU7P-0007HB-NC for control@debbugs.gnu.org; Tue, 24 May 2022 08:58:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pddi3Ux87cmKFGORoA4exKTo3Iv3sFXxmWGeN56EC2Y=; b=bjAG0/rSHhTyNV+ONIgzl0nE/g vXj4DTo76uKBGVe3BRLtDBuI7/78lQiL8z8DIe68VFWSJelknFcSZPNlx/o5kkOYb4bFTlKHqCTqK mHOqvkzgAxZHPafiaF7bkZx1HIfry7t3tB0OiRLxOavBtS5SWg2lsqErssdL5MwaVT7o=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntU7I-0006vx-1J for control@debbugs.gnu.org; Tue, 24 May 2022 14:58:30 +0200 Date: Tue, 24 May 2022 14:58:27 +0200 Message-Id: <87ee0jhyto.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #55590 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 55590 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 55590 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue May 24 22:27:39 2022 Received: (at 55590) by debbugs.gnu.org; 25 May 2022 02:27:39 +0000 Received: from localhost ([127.0.0.1]:53960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntgkN-0003hI-KA for submit@debbugs.gnu.org; Tue, 24 May 2022 22:27:39 -0400 Received: from mail-pj1-f53.google.com ([209.85.216.53]:35410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntgkL-0003h5-Og for 55590@debbugs.gnu.org; Tue, 24 May 2022 22:27:38 -0400 Received: by mail-pj1-f53.google.com with SMTP id o10-20020a17090a4e8a00b001df2fcdc165so485113pjh.0 for <55590@debbugs.gnu.org>; Tue, 24 May 2022 19:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=YVhPrfwJBY8jEnxuTKoOd9BtU9grFnUh8ReGGcKVPyM=; b=UdYgkDAguZ59nG2IyK/hhi2gZZ7JvlIz63vHREUII8UYYEIP/BNyMW4FkT2A9kyZLy AkwGELRK93wNDTVRA2jFXajgjZqv8XB/dfFs/QspHdEL8NcijrHqc+XgUIEYi2LPH6A8 yeXDZLbG+DAyVicKY3vKS6URyk9HRuReIzuSsmEjUNsvfXsuA15JOk4hRaVw9W/b16lg 1F4uMScfwKpleuUv/3exE0FIXhp7iMN/RoOkFrea7dsSpp87dVjj75AvGdhdSNaaNrb6 jhbh/2JtURm3jweKwHFEYbJ4q82GrDWlWusoQ6UzCyLKru6qeWARKwgUxfTC/BWTYVsu tm5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YVhPrfwJBY8jEnxuTKoOd9BtU9grFnUh8ReGGcKVPyM=; b=RWVUu0ApPOjXWVJSpvQaTaLi/qXnvDRDdP154LuijTlOV+GZfYU2XrBcN0zJjWL8mb 1xOydeuKS6p/6TL0yfNWR36DYcKvHCiZbtIBzOz4Bs50IG8b/LxRnqnc2T+r+jE8EEW4 JplYLTCRH6NwjdMImc84nbDxGuAQBhGQE/6cjSBtEuvPdse9zy13uqzYGbU0q8qloLBi LcEbfbkZxDhy8KqFq+DuUUcTmAyFt+PKj/K8IROfiEemgo/vMSCCuNWd28RgtLa3zvTh It2mQ2P0Wt/KHdpNUhfU6byuz+nbfWxgazjuCyJr/vMRQj4NCq1+PQgponbGu3+8c9uz 7vZQ== X-Gm-Message-State: AOAM530NSVVrbWehcRMqsQ2uO3dMpRaMGGhsTCI10hKKKR5a6n9JOH0r CgOYJecJS5UdP1ZXG2Jxz0Q= X-Google-Smtp-Source: ABdhPJz/kiOdGORYO+DMdPGtNTHNOiB/iN1vKMELT2FEsfZ8L2HFKn6aodqY17zuRx/mpOnUbWv2kg== X-Received: by 2002:a17:902:aa87:b0:162:39b5:3ba3 with SMTP id d7-20020a170902aa8700b0016239b53ba3mr7832817plr.158.1653445651713; Tue, 24 May 2022 19:27:31 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b196-20020a621bcd000000b0050dc762818dsm9974321pfb.103.2022.05.24.19.27.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 19:27:31 -0700 (PDT) Subject: Re: bug#55590: 29.0.50; Eshell subcommands clobber pipelines and produce incorrect output To: Lars Ingebrigtsen References: <6cc569a4-3512-d546-3f39-76f3d61436ac@gmail.com> <788e86e0-9358-2018-caae-71862d3b2442@gmail.com> <87v8twx0xl.fsf@athena.silentflame.com> <87fskzhytt.fsf_-_@gnus.org> From: Jim Porter Message-ID: <4c93090b-d398-cc9d-c1b5-a03480f9861f@gmail.com> Date: Tue, 24 May 2022 19:27:31 -0700 MIME-Version: 1.0 In-Reply-To: <87fskzhytt.fsf_-_@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55590 Cc: Sean Whitton , 55590@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 5/24/2022 5:58 AM, Lars Ingebrigtsen wrote: > Jim Porter writes: > >> Attached is an updated patch with an additional test for the >> more-complex case and the manual entry about this bug removed. > > Thanks; pushed to Emacs 29. Thanks for merging; of course, if anyone has a cleaner implementation that passes the tests, I'd be happy to see that merge too. I don't quite understand all the intricacies of Eshell's command evaluation macros... From unknown Tue Aug 19 05:10:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Jun 2022 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator