GNU bug report logs - #55588
pgtk: child-frame-border-width cannot be set to nil

Previous Next

Package: emacs;

Reported by: Florian Rommel <mail <at> florommel.de>

Date: Mon, 23 May 2022 01:49:02 UTC

Severity: normal

Tags: moreinfo

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Florian Rommel <mail <at> florommel.de>
To: 55588 <at> debbugs.gnu.org
Subject: bug#55588: pgtk: child-frame-border-width cannot be set to nil
Date: Mon, 23 May 2022 00:03:23 +0200
[Message part 1 (text/plain, inline)]
In pgtk, child-frame-border-width is set to 0 by default, and it cannot
be set to nil.
According to the manual it should be possible for child-frame-border-
width to be nil. In such cases, the value of internal-border-width is
used as the border width (see 30.4.3.4 "Layout Parameters"; and
function FRAME_INTERNAL_BORDER_WIDTH in frame.h).

The problem causes missing child-frame borders for code that depends on
this behavior (e.g., lsp-doc-ui in the lsp-ui package), and it will
cause errors for code that tries to set child-frame-border-width to
nil.

The attached patch fixes this. It essentially replicates the respective
behavior of xfns.c.

[0001-pgtk-Allow-child-frame-border-width-to-be-nil.patch (text/x-patch, attachment)]

This bug report was last modified 2 years and 335 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.