From unknown Sat Sep 13 06:04:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#55562 <55562@debbugs.gnu.org> To: bug#55562 <55562@debbugs.gnu.org> Subject: Status: 28.1.50; Wrong hash table return values in Elisp manual Reply-To: bug#55562 <55562@debbugs.gnu.org> Date: Sat, 13 Sep 2025 13:04:32 +0000 retitle 55562 28.1.50; Wrong hash table return values in Elisp manual reassign 55562 emacs submitter 55562 "Basil L. Contovounesios" severity 55562 minor tag 55562 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 16:29:19 2022 Received: (at submit) by debbugs.gnu.org; 21 May 2022 20:29:20 +0000 Received: from localhost ([127.0.0.1]:43036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsVix-0004i4-H8 for submit@debbugs.gnu.org; Sat, 21 May 2022 16:29:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:36838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsVis-0004hu-Rr for submit@debbugs.gnu.org; Sat, 21 May 2022 16:29:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsVis-0002MC-L8 for bug-gnu-emacs@gnu.org; Sat, 21 May 2022 16:29:14 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:38682) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nsViq-0005rO-2n for bug-gnu-emacs@gnu.org; Sat, 21 May 2022 16:29:13 -0400 Received: by mail-wm1-x336.google.com with SMTP id h205-20020a1c21d6000000b003972dda143eso2792504wmh.3 for ; Sat, 21 May 2022 13:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:subject:date:message-id:mime-version; bh=tc+5Hv4NfYxM0MFoMsgpU3vZnMD3N9+JFYeGoBLYLTU=; b=V7pzkvABUgXT1oznFI+XBInz4qwett/+ZBUwwEOx6OOgL3nyPexhc1RNDUjeldwSUE LS97axRX3OCl5mlY906XsdEQYXFari4ciYC1ju31Oqel2G5n+L3nkToER7cIEDv3aNCq pfZAEyrPJYtqxBereyIDOuDjXk8h/wplw2NbYoe1kPOlPgtdAOE5CsNOGxDDz2hViW+s v0ieBu3IV1UFWhheBvCeJCkpu4Uu4U8n9Otos9uQ8ucPjE6S0ZgwCr1Q4kYi+WwQ0Ie6 st56pn5qIZqvw8LN7SWphfRdRAUD/4eIwtSIFb9PJepBkgQ6EWc0xSSLwvpeUXZ08UXG TmgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=tc+5Hv4NfYxM0MFoMsgpU3vZnMD3N9+JFYeGoBLYLTU=; b=NhUuwxpuZ1/ZHrxMzzKpYPLop+hTATwXFD2zclL7dQ3trTS/pwKmmJiJmT2uK6WybR ydegLVQO1T3/8sfYBlsrsSmhD2FJm7zBKwiB2myDbsGM8QcnCw+NYDODuStR9sDwwcJb j8Sy8mWYaOQEvy3m6BCnLKCRoQmg1Oaac87OdTykrEGMObm8XYZERdaXsgwsnr1xsCTq EiaZaAsMDwl1mJDciUK5bns2q3gOWXczf5xU8SbbUKEpUnnvtBcZnarI27THLv52oLPY YKkLMndabDUqRM640dKBIpSJs8c634sw83Qph70SRTvXKeRQe9KJ21lPRfgwdlBdXsXh dJBQ== X-Gm-Message-State: AOAM5313m2g5oDAhw0t7F/wnMSX1vQQcQljTcvozaYNBMBqxQjSrW9G/ 43jSsFPTW9PVRhZHWm38NaAS6n5Kpwojzw== X-Google-Smtp-Source: ABdhPJy9E07edrwFC7uYazgiLMlRHlpJTlZEyxSGHmBMEXzJY85RiPzijC/4OuGvV4e3i3qt9HDjKg== X-Received: by 2002:a05:600c:1992:b0:394:826a:d40d with SMTP id t18-20020a05600c199200b00394826ad40dmr13725776wmq.146.1653164948041; Sat, 21 May 2022 13:29:08 -0700 (PDT) Received: from localhost ([2a02:587:3222:c5cf:d3e:f15b:b576:eb37]) by smtp.gmail.com with ESMTPSA id s26-20020adfa29a000000b0020d069148bcsm5979762wra.110.2022.05.21.13.29.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 13:29:06 -0700 (PDT) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 28.1.50; Wrong hash table return values in Elisp manual Date: Sat, 21 May 2022 23:29:04 +0300 Message-ID: <87czg6635b.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=contovob@tcd.ie; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Severity: minor Tags: patch 0. emacs -Q 1. C-h f clrhash RET > Clear hash table TABLE and return it. 2. C-h S clrhash RET > Common Lisp note: In Common Lisp, =E2=80=98clrhash=E2=80=99 returns the e= mpty > TABLE. In Emacs Lisp, it returns =E2=80=98nil=E2=80=99. It seems the following changes never propagated to the manual: (Fputhash): Return `value' rather than nil. d9c4f922fb 2000-07-03 06:59:05 +0000 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3Dd9c4f922fb * fns.c (Fputhash): Document return value. a54e348216 2011-06-06 18:39:26 -0700 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3Da54e348216 And the following change wasn't announced in etc/NEWS either: (Fclrhash): Return TABLE. ccd8f7fe14 2008-01-25 10:01:15 +0000 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3Dccd8f7fe14 Is there any point in announcing the status quo, or can we just update the manual, e.g. as follows? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-hash-table-function-return-values-in-manual.patch >From b63ec2658f1c8782620c7418c8282f29249333cd Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sat, 21 May 2022 23:11:33 +0300 Subject: [PATCH] Fix hash table function return values in manual * doc/lispref/hash.texi (Hash Access): Reconcile documented return values of puthash and clrhash with their respective docstrings. --- doc/lispref/hash.texi | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/doc/lispref/hash.texi b/doc/lispref/hash.texi index a566d89824..34eda45b23 100644 --- a/doc/lispref/hash.texi +++ b/doc/lispref/hash.texi @@ -203,7 +203,8 @@ Hash Access @defun puthash key value table This function enters an association for @var{key} in @var{table}, with value @var{value}. If @var{key} already has an association in -@var{table}, @var{value} replaces the old associated value. +@var{table}, @var{value} replaces the old associated value. This +function always returns @var{value}. @end defun @defun remhash key table @@ -219,10 +220,7 @@ Hash Access @defun clrhash table This function removes all the associations from hash table @var{table}, so that it becomes empty. This is also called @dfn{clearing} the hash -table. - -@b{Common Lisp note:} In Common Lisp, @code{clrhash} returns the empty -@var{table}. In Emacs Lisp, it returns @code{nil}. +table. @code{clrhash} returns the empty @var{table}. @end defun @defun maphash function table -- 2.35.1 --=-=-= Content-Type: text/plain Thanks, -- Basil In GNU Emacs 28.1.50 (build 1, x86_64-pc-linux-gnu) of 2022-05-21 built on tia Repository revision: 139bfa1a0884dbd2600fc1bd11d11f41d3f9ef94 Repository branch: wt/emacs-28-nox System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure CC=gcc-12 'CFLAGS=-O2 -march=native' --prefix=/home/blc/.local --program-suffix=-28-nox --with-file-notification=yes --with-x-toolkit=no --without-x' Configured features: ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER SECCOMP SOUND THREADS XIM ZLIB --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 22 01:11:00 2022 Received: (at 55562) by debbugs.gnu.org; 22 May 2022 05:11:00 +0000 Received: from localhost ([127.0.0.1]:43445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsdrn-00014P-UO for submit@debbugs.gnu.org; Sun, 22 May 2022 01:11:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsdrm-00014C-9I for 55562@debbugs.gnu.org; Sun, 22 May 2022 01:10:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35776) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsdrg-000164-3v; Sun, 22 May 2022 01:10:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HugUB54sLtyFk6zBYi+89S7SpYMl/gThxDeEhrx3RXQ=; b=pVVaCRTt8sXIu9GLNKHk amMA5c8gvhpggtQ3eSlLraJw0J878yUf+Kjnr+Qcjb2vUK7l3zRRPcRe+3q0U+O2sAvhr/VD9XHY3 WUrZwEJYMa/GNoGQjMomh0dYMNelmFqbaOjwfZubS6gep0VBweFCpNS7Jr/y1CPeLqqOoq3EuPRTq bqBJjuziytwNAYMyj0AJIFQdV1Vo1JhWMB+WKMrrgAMvNJ0//nNOMsuqwPAMJyA9K8e4tIyvjnlJe prFSWWJe/9XeQX0NlrwxmRPy70MFZKioOCLztK6Uub5BAVFV/UhKwJN9QoTTDkYjXFlfI8bCylVqE ScBzeuYRJR7TwQ==; Received: from [87.69.77.57] (port=1220 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsdrf-0000de-JR; Sun, 22 May 2022 01:10:51 -0400 Date: Sun, 22 May 2022 08:10:33 +0300 Message-Id: <835yly8852.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" , Stefan Monnier , Daniel Colascione In-Reply-To: <87czg6635b.fsf@tcd.ie> (bug-gnu-emacs@gnu.org) Subject: Re: bug#55562: 28.1.50; Wrong hash table return values in Elisp manual References: <87czg6635b.fsf@tcd.ie> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55562 Cc: 55562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [Adding Stefan and Daniel to the CC.] > Date: Sat, 21 May 2022 23:29:04 +0300 > From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Severity: minor > Tags: patch > > 0. emacs -Q > 1. C-h f clrhash RET > > > Clear hash table TABLE and return it. > > 2. C-h S clrhash RET > > > Common Lisp note: In Common Lisp, ‘clrhash’ returns the empty > > TABLE. In Emacs Lisp, it returns ‘nil’. > > It seems the following changes never propagated to the manual: > > (Fputhash): Return `value' rather than nil. > d9c4f922fb 2000-07-03 06:59:05 +0000 > https://git.sv.gnu.org/cgit/emacs.git/commit/?id=d9c4f922fb > > * fns.c (Fputhash): Document return value. > a54e348216 2011-06-06 18:39:26 -0700 > https://git.sv.gnu.org/cgit/emacs.git/commit/?id=a54e348216 > > And the following change wasn't announced in etc/NEWS either: > > (Fclrhash): Return TABLE. > ccd8f7fe14 2008-01-25 10:01:15 +0000 > https://git.sv.gnu.org/cgit/emacs.git/commit/?id=ccd8f7fe14 > > Is there any point in announcing the status quo, or can we just update > the manual, e.g. as follows? > > > >From b63ec2658f1c8782620c7418c8282f29249333cd Mon Sep 17 00:00:00 2001 > From: "Basil L. Contovounesios" > Date: Sat, 21 May 2022 23:11:33 +0300 > Subject: [PATCH] Fix hash table function return values in manual > > * doc/lispref/hash.texi (Hash Access): Reconcile documented return > values of puthash and clrhash with their respective docstrings. > --- > doc/lispref/hash.texi | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/doc/lispref/hash.texi b/doc/lispref/hash.texi > index a566d89824..34eda45b23 100644 > --- a/doc/lispref/hash.texi > +++ b/doc/lispref/hash.texi > @@ -203,7 +203,8 @@ Hash Access > @defun puthash key value table > This function enters an association for @var{key} in @var{table}, with > value @var{value}. If @var{key} already has an association in > -@var{table}, @var{value} replaces the old associated value. > +@var{table}, @var{value} replaces the old associated value. This > +function always returns @var{value}. > @end defun > > @defun remhash key table > @@ -219,10 +220,7 @@ Hash Access > @defun clrhash table > This function removes all the associations from hash table @var{table}, > so that it becomes empty. This is also called @dfn{clearing} the hash > -table. > - > -@b{Common Lisp note:} In Common Lisp, @code{clrhash} returns the empty > -@var{table}. In Emacs Lisp, it returns @code{nil}. > +table. @code{clrhash} returns the empty @var{table}. > @end defun > > @defun maphash function table > -- > 2.35.1 > > Thanks, > > -- > Basil > > In GNU Emacs 28.1.50 (build 1, x86_64-pc-linux-gnu) > of 2022-05-21 built on tia > Repository revision: 139bfa1a0884dbd2600fc1bd11d11f41d3f9ef94 > Repository branch: wt/emacs-28-nox > System Description: Debian GNU/Linux bookworm/sid > > Configured using: > 'configure CC=gcc-12 'CFLAGS=-O2 -march=native' > --prefix=/home/blc/.local --program-suffix=-28-nox > --with-file-notification=yes --with-x-toolkit=no --without-x' > > Configured features: > ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES > NOTIFY INOTIFY PDUMPER SECCOMP SOUND THREADS XIM ZLIB From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 16:44:12 2022 Received: (at 55562) by debbugs.gnu.org; 27 Jun 2022 20:44:12 +0000 Received: from localhost ([127.0.0.1]:53397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5vad-0005uz-RZ for submit@debbugs.gnu.org; Mon, 27 Jun 2022 16:44:12 -0400 Received: from mail-ej1-f52.google.com ([209.85.218.52]:45947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5vab-0005ui-41 for 55562@debbugs.gnu.org; Mon, 27 Jun 2022 16:44:10 -0400 Received: by mail-ej1-f52.google.com with SMTP id h23so21524465ejj.12 for <55562@debbugs.gnu.org>; Mon, 27 Jun 2022 13:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=4mAsNRbtDdMAOMTBTmMV1J/hDgdRMDpZtd0Ij5Ptims=; b=aco7BBSCrPE3gIDixf62ljqkyo6/TJCtUAXtB5af8LTeRn3N0HUCxoozZMJUW+ChY5 Fnf4QcsdcJoXIk+PtqCIzhFKHg/W1GaF0M/r9PS7EtR8eMDEz20Z+LASWpqPXJZJMqN/ 9X3eN0DTL9/j2xXCoik3lIIBZAKrjYPz8oDjPUDUQLjMV54Y8bRz2qE0Lv95TRznp7oq /HEN9NnG6IsgTYbTqwAX9y+ZCZUiAFgHestlKqwavbZfVuMr1sJiZRHkql9D9Te5YIdu GMYiCg8PaaXCtEUOr/Im4V4y+6XtJHO9NY/caMUN5/tGseFp9K4PIkUGa2NKkBgKNM+2 7TKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=4mAsNRbtDdMAOMTBTmMV1J/hDgdRMDpZtd0Ij5Ptims=; b=ZEt7Gmjxik6APmWfj2FdLX3ZEymlYm8MC09Mr3qGRpvQn9KmiPilDb/qNJkGmrmLrF oUdW65dqRqHRuZ7YAoRF/9I97P4YHkgEk9uCxYry/v5MoYroV3PrqmuP3MRraapkY2Sq op6ol1/Xv/19UT9iU26ZZbE2jQV8SOazktd0UCP5K9v2+NuEBksYlogewQOllosPREcn AJC07beq7QqaxZMVYtIFmaCg5mDfJbvkWbIu4albmIyg5AW9jDEiFbyRjJTxDe1MeE5f qKbpL16MYNBNyu7ZURb4sVahA3HaZthHuKmDo3s7TUOMHMA76iXj5u9pRHWUbZpvP2Z8 gLgQ== X-Gm-Message-State: AJIora84Ds0HXeRDM3aXbLpCJFLLDo12SV8bFUAk6fn6KqPFBKO2Mbok qT59cUiYHAAbALlbSf48VM77Jg== X-Google-Smtp-Source: AGRyM1sboQjaNsdu+jfKjTuJDclNxxL619bkqOx3u2PGDwoRB7kxkrVJ9kITjUxJnJduFjaJgIWaPg== X-Received: by 2002:a17:907:6d1d:b0:726:363e:cca3 with SMTP id sa29-20020a1709076d1d00b00726363ecca3mr14390405ejc.713.1656362643222; Mon, 27 Jun 2022 13:44:03 -0700 (PDT) Received: from localhost ([2a02:587:322b:6f5e:dc92:136a:a7c4:dc8c]) by smtp.gmail.com with ESMTPSA id t17-20020a1709067c1100b00711d5baae0esm5489838ejo.145.2022.06.27.13.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 13:44:02 -0700 (PDT) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#55562: 28.1.50; Wrong hash table return values in Elisp manual References: <87czg6635b.fsf@tcd.ie> <835yly8852.fsf@gnu.org> Date: Mon, 27 Jun 2022 23:43:59 +0300 In-Reply-To: <835yly8852.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 May 2022 01:10:52 -0400") Message-ID: <8735fpkfao.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55562 Cc: 55562@debbugs.gnu.org, Daniel Colascione , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii [2022-05-22 01:10 -0400] wrote: > [Adding Stefan and Daniel to the CC.] > >> Date: Sat, 21 May 2022 23:29:04 +0300 >> From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> Severity: minor >> Tags: patch >>=20 >> 0. emacs -Q >> 1. C-h f clrhash RET >>=20 >> > Clear hash table TABLE and return it. >>=20 >> 2. C-h S clrhash RET >>=20 >> > Common Lisp note: In Common Lisp, =E2=80=98clrhash=E2=80=99 returns th= e empty >> > TABLE. In Emacs Lisp, it returns =E2=80=98nil=E2=80=99. >>=20 >> It seems the following changes never propagated to the manual: >>=20 >> (Fputhash): Return `value' rather than nil. >> d9c4f922fb 2000-07-03 06:59:05 +0000 >> https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3Dd9c4f922fb >>=20 >> * fns.c (Fputhash): Document return value. >> a54e348216 2011-06-06 18:39:26 -0700 >> https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3Da54e348216 >>=20 >> And the following change wasn't announced in etc/NEWS either: >>=20 >> (Fclrhash): Return TABLE. >> ccd8f7fe14 2008-01-25 10:01:15 +0000 >> https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3Dccd8f7fe14 >>=20 >> Is there any point in announcing the status quo, or can we just update >> the manual, e.g. as follows? >>=20 >> >From b63ec2658f1c8782620c7418c8282f29249333cd Mon Sep 17 00:00:00 2001 >> From: "Basil L. Contovounesios" >> Date: Sat, 21 May 2022 23:11:33 +0300 >> Subject: [PATCH] Fix hash table function return values in manual >>=20 >> * doc/lispref/hash.texi (Hash Access): Reconcile documented return >> values of puthash and clrhash with their respective docstrings. >> --- >> doc/lispref/hash.texi | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >>=20 >> diff --git a/doc/lispref/hash.texi b/doc/lispref/hash.texi >> index a566d89824..34eda45b23 100644 >> --- a/doc/lispref/hash.texi >> +++ b/doc/lispref/hash.texi >> @@ -203,7 +203,8 @@ Hash Access >> @defun puthash key value table >> This function enters an association for @var{key} in @var{table}, with >> value @var{value}. If @var{key} already has an association in >> -@var{table}, @var{value} replaces the old associated value. >> +@var{table}, @var{value} replaces the old associated value. This >> +function always returns @var{value}. >> @end defun >>=20=20 >> @defun remhash key table >> @@ -219,10 +220,7 @@ Hash Access >> @defun clrhash table >> This function removes all the associations from hash table @var{table}, >> so that it becomes empty. This is also called @dfn{clearing} the hash >> -table. >> - >> -@b{Common Lisp note:} In Common Lisp, @code{clrhash} returns the empty >> -@var{table}. In Emacs Lisp, it returns @code{nil}. >> +table. @code{clrhash} returns the empty @var{table}. >> @end defun >>=20=20 >> @defun maphash function table >> --=20 >> 2.35.1 Is this suitable for Emacs 28? Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 22:36:07 2022 Received: (at 55562) by debbugs.gnu.org; 28 Jun 2022 02:36:07 +0000 Received: from localhost ([127.0.0.1]:53689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o615D-0001xU-FI for submit@debbugs.gnu.org; Mon, 27 Jun 2022 22:36:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6158-0001wx-TB for 55562@debbugs.gnu.org; Mon, 27 Jun 2022 22:36:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49306) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6151-0005lG-Jg; Mon, 27 Jun 2022 22:35:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SYcwG5KVcIEIGeax7feN+FBnMAG1yKkD729jjIkrba0=; b=C1pWWpaGMI9Z 6ccqF5SZOCPzwtlDeQEY1cHdiFpA8RNhdgP8djoRqQ/6c9TJi6/cBJjVx2B8IgP3ox5GMgTOJXIfA g1JFRaWM1Pm0jlRrXBXVXli6pWPgoJIe3FdeoNQ0oJ8Z8TO2AcERkqccsYRhQjDtNBIxXKdzcHS7z U4IUPLdR53K4mXL+m/Nz9waOWmoya72RGBezDEFC3h1MZaAXrJ12PXXQGlQCPWqUBnowbzKGKklpN Akj/eP35k5x7rc7dvV9/a41bJrSijr0MfHFFV0fGozuRj0THO48yS9Tgf5V1fhXxvnhjl+53KlU2q h4+Xo8ve5OrRSH9CIbhOXg==; Received: from [87.69.77.57] (port=3961 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6151-0007qu-3m; Mon, 27 Jun 2022 22:35:55 -0400 Date: Tue, 28 Jun 2022 05:35:57 +0300 Message-Id: <83wnd17bw2.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-Reply-To: <8735fpkfao.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#55562: 28.1.50; Wrong hash table return values in Elisp manual References: <87czg6635b.fsf@tcd.ie> <835yly8852.fsf@gnu.org> <8735fpkfao.fsf@tcd.ie> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55562 Cc: 55562@debbugs.gnu.org, dancol@dancol.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "Basil L. Contovounesios" > Cc: Stefan Monnier , Daniel Colascione > , 55562@debbugs.gnu.org > Date: Mon, 27 Jun 2022 23:43:59 +0300 > > Is this suitable for Emacs 28? If the behavior is the same there, yes. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 28 03:07:01 2022 Received: (at control) by debbugs.gnu.org; 28 Jun 2022 07:07:01 +0000 Received: from localhost ([127.0.0.1]:53848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o65JM-0000QX-Lh for submit@debbugs.gnu.org; Tue, 28 Jun 2022 03:07:00 -0400 Received: from mail-ej1-f48.google.com ([209.85.218.48]:40686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o65JH-0000Q4-WA for control@debbugs.gnu.org; Tue, 28 Jun 2022 03:06:59 -0400 Received: by mail-ej1-f48.google.com with SMTP id ge10so23760087ejb.7 for ; Tue, 28 Jun 2022 00:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iW/wpx5sJacNNUMKYp+9Bhd2tp3QyUxuoCIyikDzV6g=; b=S+b/D/3r/RIdtzqMpaV6T6dgkp8kTV1f0LY4ujWvJitF00EDmNwpXXyUeHvweO9V0J Ep813pxekqwlNFEhocKgdZfLS76NdKIAK8LyH4rTX7OGeTj9ZwrrGadSocB95x8Gk+Q6 +bgMogTKVoHaLuR0w+jszweii7GThV2kzAS6hnmg/d4QKNOrfh58TWR5OZVAx/d83uCb sP50A1ocPb5iCIJl55aFwrS0Qxs39ApzGPkwoTCzvi0RCqU/O5xPUEDOHYKo+QtDRfCf uiSEkojJHdbSjhZC4CilxYmzOaVCpsDCHYe+db645hU+9kihe9pNfXJgXU5PIkhbev4Q NARw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iW/wpx5sJacNNUMKYp+9Bhd2tp3QyUxuoCIyikDzV6g=; b=QB+ZTWps0l6w/Uzf/HB2AuIZbMID6wNstroQlw1tiMSNJFgPsCUSmOAy7SafeHuyuy U9Vs7LtVi1SQGvTEJyrMM4yZV8r9ZgEGJ2FIy1ar1kCb7uG25sGCIieRiqB0r/7U2Ak8 bcUN1X258ux+Y0KPtpuu7bPVJu4xy3GCNrU/EM+RZU1k8TXVysuHUecIbhGxOgliVnf+ e70vehfvNRFv76pIpc433B2jm+7RLGmUnBwZS74HJHg1xqh85YGChKxwMKb0Lyoikjkl X8ctYZyZfm4jiMEKlES1Ef/rosjr8o1Y5HyrAL+sa8dRiCra8fOI8rP188lyPioe3JfA fbBg== X-Gm-Message-State: AJIora8iqONIYHpJY9jZf0XoLRP5KmolsPXpT+0e60HpLzIgF4BfHz8z bD2uiGvR96remsEKofV6UVbS2Q== X-Google-Smtp-Source: AGRyM1sLFLTMJtPGqBInVqZ1aB/PFoRSONG5yyX+chH9p0bSGwBDueltdbIpHL8QpBwKVB9D/nwgbA== X-Received: by 2002:a17:907:1b14:b0:6ef:a5c8:afbd with SMTP id mp20-20020a1709071b1400b006efa5c8afbdmr16343556ejc.151.1656400010152; Tue, 28 Jun 2022 00:06:50 -0700 (PDT) Received: from localhost ([2a02:587:322b:6f5e:dc92:136a:a7c4:dc8c]) by smtp.gmail.com with ESMTPSA id p21-20020a1709060dd500b006f3ef214e63sm5421026eji.201.2022.06.28.00.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 00:06:48 -0700 (PDT) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#55562: 28.1.50; Wrong hash table return values in Elisp manual References: <87czg6635b.fsf@tcd.ie> <835yly8852.fsf@gnu.org> <8735fpkfao.fsf@tcd.ie> <83wnd17bw2.fsf@gnu.org> Date: Tue, 28 Jun 2022 10:06:46 +0300 In-Reply-To: <83wnd17bw2.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 27 Jun 2022 22:35:56 -0400") Message-ID: <87h745i7w9.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: 55562-done@debbugs.gnu.org, dancol@dancol.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) found 55562 24.1 close 55562 28.2 quit Eli Zaretskii [2022-06-27 22:35 -0400] wrote: >> From: "Basil L. Contovounesios" >> Cc: Stefan Monnier , Daniel Colascione >> , 55562@debbugs.gnu.org >> Date: Mon, 27 Jun 2022 23:43:59 +0300 >> >> Is this suitable for Emacs 28? > > If the behavior is the same there, yes. The puthash behaviour has been with us since Emacs 22, and the clrhash behaviour since Emacs 24, it's just the Elisp manual that was never updated accordingly. So I've now updated the manual in emacs-28, and I'm closing this report. Fix hash table function return values in manual 091b22cb12 2022-06-28 10:03:53 +0300 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=091b22cb12 Thanks, -- Basil From unknown Sat Sep 13 06:04:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 26 Jul 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator