GNU bug report logs - #55558
[PATCH] gnu: emacs-list-utils: update to latest commit

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#55558: closed ([PATCH] gnu: emacs-list-utils: update to
 latest commit)
Date: Thu, 26 May 2022 20:04:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 26 May 2022 21:49:22 +0200
with message-id <877d686oyv <at> nckx>
and subject line Re: [bug#55558] [PATCH] gnu: emacs-list-utils: update to latest commit
has caused the debbugs.gnu.org bug report #55558,
regarding [PATCH] gnu: emacs-list-utils: update to latest commit
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
55558: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55558
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Erik Šabič <erik.sab <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-list-utils: update to latest commit
Date: Sat, 21 May 2022 12:01:17 +0200

* gnu/packages/emacs-xyz.scm (emacs-list-utils): [version] The latest
commit (0dec8c02962d2591766739e37c5714ba21133093) contains both the
patch-require-cl, which I removed, and calls to define-obsolete-function-alias
are made with 3 arguments instead of 2, which is necessary to compile with
Emacs 28.1
---
 gnu/packages/emacs-xyz.scm | 44 ++++++++++++++++----------------------
 1 file changed, 19 insertions(+), 25 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ae81f4e395..944597139a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -18730,31 +18730,25 @@ (define-public emacs-helm-gtags
     (license license:gpl3+)))
 
 (define-public emacs-list-utils
-  (package
-    (name "emacs-list-utils")
-    (version "0.4.6")
-    (source
-     (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://github.com/rolandwalker/list-utils")
-             (commit (string-append "v" version))))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "07hbz2md52ccy95gv4d5n6szrfmpfqf3w4kwqdg2cf54c7kgf7hw"))))
-    (build-system emacs-build-system)
-    (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'patch-require-cl
-           (lambda _
-             (substitute* "list-utils.el"
-               (("\\(require 'cl\\)") "(require 'cl-lib)"))
-             #t)))))
-    (home-page "https://github.com/rolandwalker/list-utils")
-    (synopsis "List-manipulation utility functions")
-    (description "This package provides a list manipulation library for Emacs.")
-    (license license:gpl3+)))
+  (let ((commit "0dec8c02962d2591766739e37c5714ba21133093") (revision "1"))
+    (package
+      (name "emacs-list-utils")
+      (version (git-version "0.4.6" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/rolandwalker/list-utils")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "11nm8649a131bn2kwj4fxkiijdx2d4f1byx7a985zlb3bzdwnaw8"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/rolandwalker/list-utils")
+      (synopsis "List-manipulation utility functions")
+      (description
+       "This package provides a list manipulation library for Emacs.")
+      (license license:gpl3+))))
 
 (define-public emacs-parsec
   (package

base-commit: 94b28247d1b976e9c01c75794663603b7b81eaeb
-- 
2.36.1

[Message part 3 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Erik Šabič <erik.sab <at> gmail.com>
Cc: 55558-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#55558] [PATCH] gnu: emacs-list-utils: update to latest commit
Date: Thu, 26 May 2022 21:49:22 +0200

[Message part 4 (text/plain, inline)]

Erik,

Thank you!

This build failure was bugging a lot of people, so I pushed your 
fix as commit c5d68c6d12e691bceba60bc9537ea499bb50273d, with a 
message matching out conventions.
Please take a look.

For example, we use a specific ‘gnu: foo: Update to $VERSION.’ 
title, and again in the changelog section.

Erik Šabič 写道：
> * gnu/packages/emacs-xyz.scm (emacs-list-utils): [version] The 
> latest
> commit (0dec8c02962d2591766739e37c5714ba21133093) contains both 
> the
> patch-require-cl, which I removed, and calls to 
> define-obsolete-function-alias
> are made with 3 arguments instead of 2, which is necessary to 
> compile with
> Emacs 28.1

I moved this comment to the code.  Comments like this almost 
*never* belong in commit messages.  Who reads those — in context — 
after a week?

Thanks again!

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.