GNU bug report logs - #55551
[PATCH] gnu: Add emacs-corfu-doc.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55551 in the body.
You can then email your comments to 55551 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add emacs-corfu-doc.
Date: Fri, 20 May 2022 18:13:47 -0500

* gnu/packages/emacs-xyz.scm (emacs-corfu-doc): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b2e2cffffe..e21c4f4308 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3134,6 +3134,32 @@ (define-public emacs-corfu
 @code{completion-in-region} counterpart of the Vertico minibuffer UI.")
     (license license:gpl3+)))
 
+(define-public emacs-corfu-doc
+  ;; There are no tagged version releases.
+  (let ((commit "96b5de8cced0f2c2069748305bb72cf2db77200e")
+        (revision "0"))
+    (package
+      (name "emacs-corfu-doc")
+      (version (git-version "0.5.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/galeo/corfu-doc")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "18xgm8jjppdq43i4wa36pbwlh4jxdgkmfbj13w5q4c7b9cy7r3mf"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-corfu))
+      (home-page "https://github.com/galeo/corfu-doc")
+      (synopsis "Documentation popup for Corfu")
+      (description
+"The @code{corfu-doc} package provides a way to display a documentation
+popup for completion candidates when using @code{emacs-corfu}.  It can
+be regarded as @code{emacs-company-quickhelp} for @code{emacs-corfu}.")
+      (license license:gpl3+))))
+
 (define-public emacs-cape
   (package
     (name "emacs-cape")
-- 
2.35.3

Message #8 received at 55551 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: jgart <jgart <at> dismail.de>, 55551 <at> debbugs.gnu.org
Subject: Re: [bug#55551] [PATCH] gnu: Add emacs-corfu-doc.
Date: Sat, 21 May 2022 14:43:51 +0200

[Message part 1 (text/plain, inline)]

jgart via Guix-patches via schreef op vr 20-05-2022 om 18:13 [-0500]:
> +(define-public emacs-corfu-doc
> +  ;; There are no tagged version releases.
> +  (let ((commit "96b5de8cced0f2c2069748305bb72cf2db77200e")
> +        (revision "0"))
> +    (package
> +      (name "emacs-corfu-doc")
> +      (version (git-version "0.5.1" revision commit))

That commit says: ‘Version 0.5.1’, so it seems a proper version /
formal release to me, with no need for git-version.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 55551 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 55551 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH v2] gnu: Add emacs-corfu-doc.
Date: Sat, 21 May 2022 19:19:31 -0500

* gnu/packages/emacs-xyz.scm (emacs-corfu-doc): New variable.

Hi Maxime,

Here's a version 2 of the original patch with your suggestions.

Thank you for the code review.

all best,

jgart
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b2e2cffffe..c271d0521c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3134,6 +3134,31 @@ (define-public emacs-corfu
 @code{completion-in-region} counterpart of the Vertico minibuffer UI.")
     (license license:gpl3+)))
 
+(define-public emacs-corfu-doc
+  (let ((commit "96b5de8cced0f2c2069748305bb72cf2db77200e")
+        (revision "0"))
+    (package
+      (name "emacs-corfu-doc")
+      (version "0.5.1")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/galeo/corfu-doc")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "18xgm8jjppdq43i4wa36pbwlh4jxdgkmfbj13w5q4c7b9cy7r3mf"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-corfu))
+      (home-page "https://github.com/galeo/corfu-doc")
+      (synopsis "Documentation popup for Corfu")
+      (description
+"The @code{corfu-doc} package provides a way to display a documentation
+popup for completion candidates when using @code{emacs-corfu}.  It can
+be regarded as @code{emacs-company-quickhelp} for @code{emacs-corfu}.")
+      (license license:gpl3+))))
+
 (define-public emacs-cape
   (package
     (name "emacs-cape")
-- 
2.35.3

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: jgart <jgart <at> dismail.de>
Cc: 55551-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#55551] [PATCH v2] gnu: Add emacs-corfu-doc.
Date: Sun, 05 Jun 2022 18:10:17 +0200

[Message part 1 (text/plain, inline)]

jgart via Guix-patches via 写道：
> Here's a version 2 of the original patch with [Maxime's] 
> suggestions.

I bumped it further to 0.6.3, and removed the revision & 
let-binding entirely.

Pushed to master; thanks!

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.