GNU bug report logs - #55545
[PATCH] Get ~emacs-promise~ to build in emacs 28

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andrew Patterson <andrewpatt7 <at> gmail.com>
Subject: bug#55545: closed (Re: [bug#55545] [PATCH] Get ~emacs-promise~ to
 build in emacs 28)
Date: Tue, 25 Mar 2025 09:30:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#55545: [PATCH] Get ~emacs-promise~ to build in emacs 28

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 55545 <at> debbugs.gnu.org.

-- 
55545: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55545
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Cayetano Santos <csantosb <at> inventati.org>
To: 55545-done <at> debbugs.gnu.org
Cc: othacehe <at> gnu.org, 55545 <at> debbugs.gnu.org, andrewpatt7 <at> gmail.com
Subject: Re: [bug#55545] [PATCH] Get ~emacs-promise~ to build in emacs 28
Date: Tue, 25 Mar 2025 10:28:56 +0100

[Message part 3 (text/plain, inline)]

Closing.

We have now latest (as for today) emacs-promise in the repos, and emacs
29.4.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Andrew Patterson <andrewpatt7 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Get ~emacs-promise~ to build in emacs 28
Date: Fri, 20 May 2022 15:55:10 -0400

[0001-Get-emacs-promise-to-build-in-emacs-28.patch (text/x-patch, inline)]

From 0df304239efa6dc480e87d2ad833195d15011053 Mon Sep 17 00:00:00 2001
From: Andrew Patterson <andrewpatt7 <at> gmail.com>
Date: Fri, 20 May 2022 15:06:07 -0400
Subject: [PATCH] Get ~emacs-promise~ to build in emacs 28

Emacs 28 added a third required argument to ~define-obsolete-function-alias~
and friends.  Upstream has removed the aliases, but hasn't released a new version.
---
 gnu/packages/emacs-xyz.scm | 33 ++++++++++++++++++++++-----------
 1 file changed, 22 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ae81f4e395..ca4dec7795 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30347,19 +30347,29 @@ (define-public emacs-promise
   (package
     (name "emacs-promise")
     (version "1.1")
-    (source
-     (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://github.com/chuntaro/emacs-promise")
-             (commit version)))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "1xb34zdbwjvahfhycjphdkm925kgd22dr298c57hwxza4ljc2hxj"))))
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/chuntaro/emacs-promise")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1xb34zdbwjvahfhycjphdkm925kgd22dr298c57hwxza4ljc2hxj"))))
     (build-system emacs-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (add-after 'unpack 'patch-obsolete
+                    (lambda* _
+                      (substitute* "promise.el"
+                        (("\\(define-obsolete-function-alias (.*) (.*)\\)" _
+                          obsolete cur) (format #f
+                                         "(define-obsolete-function-alias ~a ~a ~a)"
+                                         obsolete cur "\"2020-01-10\""))))))))
     (home-page "https://github.com/chuntaro/emacs-promise")
     (synopsis "Promises/A+ for Emacs")
-    (description "This is a simple implementation of Promises/A+.
+    (description
+     "This is a simple implementation of Promises/A+.
 
 This implementation ports the following Promises/A+ features
 faithfully.  See @url{https://github.com/then/promise}.
@@ -30371,7 +30381,8 @@ (define-public emacs-promise
 @item It supports \"thenable\".
 @item It supports \"Inheritance of Promise\".
 @item It supports \"rejection-tracking\".
-@end itemize\n")
+@end itemize
+")
     (license license:gpl3+)))
 
 (define-public emacs-async-await

base-commit: 598f7289db9955584457ffc11c8504f3938a1618
-- 
2.36.1

[Message part 7 (text/plain, inline)]

-- 
Andrew Patterson

John H. Cochrane is a professor of economics at Chicago, which is 
like being a professor of economics but more so.
   --<https://putanumonit.com/2018/12/14/defense-of-finance/>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.