Subject: Re: bug#55539: 28.1; Support for the Kharoṣṭhī Script

From: Eli Zaretskii <[email-masked]>
Date: Fri, 20 May 2022 19:18:45 +0300

> From: Stefan Baums <[email-masked]>
> Date: Fri, 20 May 2022 11:48:15 +0200
> 
> Please find attached the necessary code for inclusion in Emacs 29.
> The file “kharoshthi.el” is for the lisp/language folder, the file
> “kharoshthi-input.el” (to be renamed to simple “kharoshthi.el”)
> for the lisp/leim/quail folder.

Thanks, please see a few comments below.

> ;;; kharoshthi.el --- support for the Kharoṣṭhī script

Please place this part in lisp/language/misc.el, not on a separate
file.

> (let ((consonant     "[\U00010A00\U00010A10-\U00010A35]")
>       (vowel         "[\U00010A01-\U00010A06]")
>       (virama        "\U00010A3F")
>       (modifier      "[\U00010A0C-\U00010A0F\U00010A38-\U00010A3A]"))
>   (set-char-table-range composition-function-table
> 		                ;; '(#x10A00 . #x10A5F)

This last line should be removed, no?

> 		                '(#x10A3F . #x10A3F)
>                         (list
>                          (vector
>                           (concat consonant
>                                   "\\(?:" virama consonant "\\)*"
>                                   modifier "*"
>                                   virama "?"
>                                   vowel "*"
>                                   modifier "*")
>                           1 'font-shape-gstring))))

Note that according to the rule above, a sequence

  consonant modifier vowel

will not be composed, although it matches the regexp, because its
second character is not a virama.  Is this okay?

> (quail-define-package
>  "kharoshthi" "Kharoṣṭhī" "𐨑" nil
>  "Kharoṣṭhī input method." nil t t t t nil nil nil nil nil t)
> 
> (quail-define-rules
> 
>  ("a" ["𐨀"]) ("i" ["𐨀𐨁"]) ("u" ["𐨀𐨂"]) ("R" ["𐨀𐨃"]) ("e" ["𐨀𐨅"]) ("o" ["𐨀𐨆"])

Can you please reformat this to have just one rule per line?  It will
make that easier to read and maintain.

Last, but not least: these changes are too large for us to accept
without a copyright assignment.  Would you be willing to start the
legal paperwork of the copyright assignment at this time?  If yes, I
will send you the form to fill and the instructions to email the form.

Thank you for your interest in Emacs.