GNU bug report logs - #55517
[PATCH]: gnu: emacs-magit: Drop the libgit backend.

Previous Next

Full log

Message #17 received at 55517 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 55517 <at> debbugs.gnu.org
Subject: Re: bug#55517: Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the
 libgit backend.)
Date: Fri, 20 May 2022 08:04:41 +0200

Am Freitag, dem 20.05.2022 um 11:52 +0800 schrieb Zhu Zihao:
> -     `(#:emacs ,emacs-no-x             ;module support is required

> +     (list
> +      #:emacs emacs-no-x
You do drop that argument in the second commit, but I think we ought to
still keep the comment in this one.  Do add a space between ';' and
"module", though.

> gnu: emacs-magit: Drop the libgit backend.
> 
> Drop the libgit backend for following reasons:
> 
> 1. The libgit backend of Magitis very incomplete. There's almost no
> benefits, but extra maintenance efforts.
> 
> 2. The libgit backend of Magit can be considered as an extra package.
> And it's still in Proof-Of-Concept status so its quaility doesn't
> satisfy the requirement of Guix package.
I'd rather write this as follows:

> gnu: emacs-magit: Drop the libgit backend.
> 
> The libgit backend currently provides next to no features, but
> demands extra maintenance overhead.  It is in fact not a usable
> backend; thus let's not use it.

The "extra package" thing is imho not so correct from observing the
Makefile (even if there's an extra -pkg.el), so let's wait until
upstream makes that clearer.

Other than that LGTM.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.