From debbugs-submit-bounces@debbugs.gnu.org Thu May 19 01:09:44 2022 Received: (at submit) by debbugs.gnu.org; 19 May 2022 05:09:44 +0000 Received: from localhost ([127.0.0.1]:34188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrYPr-0008Uu-VN for submit@debbugs.gnu.org; Thu, 19 May 2022 01:09:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:51136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrYPp-0008Ul-Oy for submit@debbugs.gnu.org; Thu, 19 May 2022 01:09:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrYPp-0000LS-91 for guix-patches@gnu.org; Thu, 19 May 2022 01:09:37 -0400 Received: from mail-m974.mail.163.com ([123.126.97.4]:7290) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrYPl-0004Mk-5b for guix-patches@gnu.org; Thu, 19 May 2022 01:09:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=U2OU+ ir8IFhRYg7eEeh+qvukjleUynQqeS76ZAxkORQ=; b=ghhjElhDrpPeOLLiZUjR+ gcCTRzeqIlsUDTyoaJP0B8Jv/85A83qpQ828l2qlkTzOUMpY13AQ1D4Mrydmt5Cy dvdpzmRikF2UG4F1cRJa/DKxHYWlPwjrBbit46KoPAqEKGl1I8/AipBNyry48rTB ecx6G8zSTiCwwR9/cIutyc= Received: from asus-laptop (unknown [27.38.118.8]) by smtp4 (Coremail) with SMTP id HNxpCgDnCtME0YVi4XbQDA--.11765S2; Thu, 19 May 2022 13:09:24 +0800 (CST) User-agent: mu4e 1.6.10; emacs 27.2 From: Zhu Zihao To: guix-patches@gnu.org Subject: [PATCH]: gnu: emacs-magit: Drop the libgit backend. Date: Thu, 19 May 2022 13:08:41 +0800 Message-ID: <868rqykt19.fsf@163.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-CM-TRANSID: HNxpCgDnCtME0YVi4XbQDA--.11765S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUbNVkUUUUU X-Originating-IP: [27.38.118.8] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/1tbiTwQGr1sGa-3j9QAAs- Received-SPF: pass client-ip=123.126.97.4; envelope-from=all_but_last@163.com; helo=mail-m974.mail.163.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain Also see the discussions in https://issues.guix.gnu.org/55427 --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIsEARYIADMWIQRefA5qkqvnKdl/GTlmOX+E92aT+QUCYoXRAhUcYWxsX2J1dF9s YXN0QDE2My5jb20ACgkQZjl/hPdmk/nblwD/SQ7307SKoMsurHNhiqAK/Z4ObKdi vgJvPgfBZ+afLvwBAMemijTFpt2ssbE7KjVFAOWNnAyd4X3u8/nqbtjM+10G =Hby8 -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-emacs-magit-Drop-the-libgit-backend.patch >From 5299123e8acbfb89fb307d8bbb260501c258724a Mon Sep 17 00:00:00 2001 From: Zhu Zihao Date: Thu, 19 May 2022 13:01:46 +0800 Subject: [PATCH] gnu: emacs-magit: Drop the libgit backend. Drop the libgit backend for following reasons: 1. The libgit backend of Magitis very incomplete. There's almost no benefits, but extra maintenance efforts. 2. The libgit backend of Magit can be considered as an extra package. And it's still in Proof-Of-Concept status so its quaility doesn't satifised the requirement of Guix package. * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]: Use G-expressions. : Remove this argument. : Exclude the magit-libgit.el and magit-libgit-pkg.el. : In phase 'patch-exec-paths', use search-input-file for perl executable. [inputs]: Remove emacs-libgit. --- gnu/packages/emacs-xyz.scm | 95 ++++++++++++++++++++------------------ 1 file changed, 49 insertions(+), 46 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index eed2f4b71c..d3ca00475e 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -869,57 +869,60 @@ (define-public emacs-magit (base32 "0cxyvp2aav27znc7mf6c83q5pddpdniaqkrxn1r8dbgr540qmnpn")))) (build-system emacs-build-system) (arguments - `(#:emacs ,emacs-no-x ;module support is required - #:tests? #t - #:test-command '("make" "test") - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'build-info-manual - (lambda _ - (invoke "make" "info") - ;; Copy info files to the lisp directory, which acts as - ;; the root of the project for the emacs-build-system. - (for-each (lambda (f) - (install-file f "lisp")) - (find-files "Documentation" "\\.info$")) - (chdir "lisp"))) - (add-after 'build-info-manual 'set-magit-version - (lambda _ - (make-file-writable "magit.el") - (emacs-substitute-variables "magit.el" - ("magit-version" ,version)))) - (add-after 'set-magit-version 'patch-exec-paths - (lambda* (#:key inputs #:allow-other-keys) - (let ((perl (assoc-ref inputs "perl"))) - (make-file-writable "magit-sequence.el") - (emacs-substitute-variables "magit-sequence.el" - ("magit-perl-executable" (string-append perl "/bin/perl")))))) - (add-before 'check 'configure-git - (lambda _ - ;; Otherwise some tests fail with error "unable to auto-detect - ;; email address". - (setenv "HOME" (getcwd)) - (invoke "git" "config" "--global" "user.name" "toto") - (invoke "git" "config" "--global" "user.email" - "toto@toto.com"))) - (add-after 'configure-git 'disable-tramp-test - (lambda _ - ;; There is an issue causing TRAMP to fail in the build - ;; environment. Setting the tramp-remote-shell parameter of - ;; the sudo-method to the file name of the shell didn't help. - (chdir "..") - (substitute* "t/magit-tests.el" - (("^\\(ert-deftest magit-toplevel:tramp.*" all) - (string-append all " (skip-unless nil)"))))) - (add-before 'install 'enter-lisp-directory - (lambda _ - (chdir "lisp")))))) + (list + #:tests? #t + #:test-command #~(list "make" "test") + #:exclude #~(cons* "magit-libgit.el" + "magit-libgit-pkg.el" + %default-exclude) + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'build-info-manual + (lambda _ + (invoke "make" "info") + ;; Copy info files to the lisp directory, which acts as + ;; the root of the project for the emacs-build-system. + (for-each (lambda (f) + (install-file f "lisp")) + (find-files "Documentation" "\\.info$")) + (chdir "lisp"))) + (add-after 'build-info-manual 'set-magit-version + (lambda _ + (make-file-writable "magit.el") + (emacs-substitute-variables "magit.el" + ("magit-version" #$version)))) + (add-after 'set-magit-version 'patch-exec-paths + (lambda* (#:key inputs #:allow-other-keys) + (let ((perl (search-input-file inputs "/bin/perl"))) + (make-file-writable "magit-sequence.el") + (emacs-substitute-variables "magit-sequence.el" + ("magit-perl-executable" perl))))) + (add-before 'check 'configure-git + (lambda _ + ;; Otherwise some tests fail with error "unable to auto-detect + ;; email address". + (setenv "HOME" (getcwd)) + (invoke "git" "config" "--global" "user.name" "toto") + (invoke "git" "config" "--global" "user.email" + "toto@toto.com"))) + (add-after 'configure-git 'disable-tramp-test + (lambda _ + ;; There is an issue causing TRAMP to fail in the build + ;; environment. Setting the tramp-remote-shell parameter of + ;; the sudo-method to the file name of the shell didn't help. + (chdir "..") + (substitute* "t/magit-tests.el" + (("^\\(ert-deftest magit-toplevel:tramp.*" all) + (string-append all " (skip-unless nil)"))))) + (add-before 'install 'enter-lisp-directory + (lambda _ + (chdir "lisp")))))) (native-inputs (list texinfo)) (inputs (list git perl)) (propagated-inputs - (list emacs-dash emacs-libgit emacs-transient emacs-with-editor)) + (list emacs-dash emacs-transient emacs-with-editor)) (home-page "https://magit.vc/") (synopsis "Emacs interface for the Git version control system") (description -- 2.36.0 --=-=-= Content-Type: text/plain -- Retrieve my PGP public key: gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F Zihao --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 19 01:14:07 2022 Received: (at 55517) by debbugs.gnu.org; 19 May 2022 05:14:07 +0000 Received: from localhost ([127.0.0.1]:34199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrYUA-0000D8-Qg for submit@debbugs.gnu.org; Thu, 19 May 2022 01:14:07 -0400 Received: from mail-m972.mail.163.com ([123.126.97.2]:43000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrYU8-0000CU-7m for 55517@debbugs.gnu.org; Thu, 19 May 2022 01:14:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=dNgXp faqWOMYBg8k0qJxaeI3wqlPyUSF5jOndg6xK84=; b=pgPKRxujg/3IXJyYhQ3Mk tgNX1/B/N/YxSS/sC5ls3B2WplMngLQRs8R1tpyPSWiFSMpOaVx/JPbGI3Sg10cy kzYk+zWRQKtRpADjGacSM5KqusMOf7cMRVfID2pnc4eQjlRqNLEjaCELoLXDVSyj D2VeUtjwXnFSFCT5PSUL2A= Received: from asus-laptop (unknown [27.38.118.8]) by smtp2 (Coremail) with SMTP id GtxpCgDXV_oS0oVizhHIDQ--.12701S2; Thu, 19 May 2022 13:13:55 +0800 (CST) References: <868rqykt19.fsf@163.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Zhu Zihao To: 55517@debbugs.gnu.org Subject: Re: bug#55517: Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) Date: Thu, 19 May 2022 13:13:36 +0800 In-reply-to: Message-ID: <86sfp6je99.fsf@163.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-CM-TRANSID: GtxpCgDXV_oS0oVizhHIDQ--.12701S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvj4Rq1vaDUUUU X-Originating-IP: [27.38.118.8] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/xtbBLxMGr2Hmmv+pSwAAsV X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55517 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain Fix the typo in commit message --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIsEARYIADMWIQRefA5qkqvnKdl/GTlmOX+E92aT+QUCYoXSEhUcYWxsX2J1dF9s YXN0QDE2My5jb20ACgkQZjl/hPdmk/myigEA2WeKmyYoPqh6wQ35sL4g3dBEN71H rxPJISTUYNOQ/hQA/iFSwLub62Lb6jaZlieYFUhN8OtnnMOzZ4lq3h33HnkA =/ccW -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-emacs-magit-Drop-the-libgit-backend.patch >From 8a2de5764a67bea1cbf789c8d6ce0ab0878ec40b Mon Sep 17 00:00:00 2001 From: Zhu Zihao Date: Thu, 19 May 2022 13:01:46 +0800 Subject: [PATCH] gnu: emacs-magit: Drop the libgit backend. Drop the libgit backend for following reasons: 1. The libgit backend of Magitis very incomplete. There's almost no benefits, but extra maintenance efforts. 2. The libgit backend of Magit can be considered as an extra package. And it's still in Proof-Of-Concept status so its quaility doesn't satisfy the requirement of Guix package. * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]: Use G-expressions. : Remove this argument. : Exclude the magit-libgit.el and magit-libgit-pkg.el. : In phase 'patch-exec-paths', use search-input-file for perl executable. [inputs]: Remove emacs-libgit. --- gnu/packages/emacs-xyz.scm | 95 ++++++++++++++++++++------------------ 1 file changed, 49 insertions(+), 46 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index eed2f4b71c..d3ca00475e 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -869,57 +869,60 @@ (define-public emacs-magit (base32 "0cxyvp2aav27znc7mf6c83q5pddpdniaqkrxn1r8dbgr540qmnpn")))) (build-system emacs-build-system) (arguments - `(#:emacs ,emacs-no-x ;module support is required - #:tests? #t - #:test-command '("make" "test") - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'build-info-manual - (lambda _ - (invoke "make" "info") - ;; Copy info files to the lisp directory, which acts as - ;; the root of the project for the emacs-build-system. - (for-each (lambda (f) - (install-file f "lisp")) - (find-files "Documentation" "\\.info$")) - (chdir "lisp"))) - (add-after 'build-info-manual 'set-magit-version - (lambda _ - (make-file-writable "magit.el") - (emacs-substitute-variables "magit.el" - ("magit-version" ,version)))) - (add-after 'set-magit-version 'patch-exec-paths - (lambda* (#:key inputs #:allow-other-keys) - (let ((perl (assoc-ref inputs "perl"))) - (make-file-writable "magit-sequence.el") - (emacs-substitute-variables "magit-sequence.el" - ("magit-perl-executable" (string-append perl "/bin/perl")))))) - (add-before 'check 'configure-git - (lambda _ - ;; Otherwise some tests fail with error "unable to auto-detect - ;; email address". - (setenv "HOME" (getcwd)) - (invoke "git" "config" "--global" "user.name" "toto") - (invoke "git" "config" "--global" "user.email" - "toto@toto.com"))) - (add-after 'configure-git 'disable-tramp-test - (lambda _ - ;; There is an issue causing TRAMP to fail in the build - ;; environment. Setting the tramp-remote-shell parameter of - ;; the sudo-method to the file name of the shell didn't help. - (chdir "..") - (substitute* "t/magit-tests.el" - (("^\\(ert-deftest magit-toplevel:tramp.*" all) - (string-append all " (skip-unless nil)"))))) - (add-before 'install 'enter-lisp-directory - (lambda _ - (chdir "lisp")))))) + (list + #:tests? #t + #:test-command #~(list "make" "test") + #:exclude #~(cons* "magit-libgit.el" + "magit-libgit-pkg.el" + %default-exclude) + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'build-info-manual + (lambda _ + (invoke "make" "info") + ;; Copy info files to the lisp directory, which acts as + ;; the root of the project for the emacs-build-system. + (for-each (lambda (f) + (install-file f "lisp")) + (find-files "Documentation" "\\.info$")) + (chdir "lisp"))) + (add-after 'build-info-manual 'set-magit-version + (lambda _ + (make-file-writable "magit.el") + (emacs-substitute-variables "magit.el" + ("magit-version" #$version)))) + (add-after 'set-magit-version 'patch-exec-paths + (lambda* (#:key inputs #:allow-other-keys) + (let ((perl (search-input-file inputs "/bin/perl"))) + (make-file-writable "magit-sequence.el") + (emacs-substitute-variables "magit-sequence.el" + ("magit-perl-executable" perl))))) + (add-before 'check 'configure-git + (lambda _ + ;; Otherwise some tests fail with error "unable to auto-detect + ;; email address". + (setenv "HOME" (getcwd)) + (invoke "git" "config" "--global" "user.name" "toto") + (invoke "git" "config" "--global" "user.email" + "toto@toto.com"))) + (add-after 'configure-git 'disable-tramp-test + (lambda _ + ;; There is an issue causing TRAMP to fail in the build + ;; environment. Setting the tramp-remote-shell parameter of + ;; the sudo-method to the file name of the shell didn't help. + (chdir "..") + (substitute* "t/magit-tests.el" + (("^\\(ert-deftest magit-toplevel:tramp.*" all) + (string-append all " (skip-unless nil)"))))) + (add-before 'install 'enter-lisp-directory + (lambda _ + (chdir "lisp")))))) (native-inputs (list texinfo)) (inputs (list git perl)) (propagated-inputs - (list emacs-dash emacs-libgit emacs-transient emacs-with-editor)) + (list emacs-dash emacs-transient emacs-with-editor)) (home-page "https://magit.vc/") (synopsis "Emacs interface for the Git version control system") (description -- 2.36.0 --=-=-= Content-Type: text/plain -- Retrieve my PGP public key: gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F Zihao --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 19 02:01:13 2022 Received: (at 55517) by debbugs.gnu.org; 19 May 2022 06:01:13 +0000 Received: from localhost ([127.0.0.1]:34233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrZDl-0001Tm-2v for submit@debbugs.gnu.org; Thu, 19 May 2022 02:01:13 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:64463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrZDj-0001Td-M6 for 55517@debbugs.gnu.org; Thu, 19 May 2022 02:01:12 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4L3fNz53f9z1LBRv; Thu, 19 May 2022 08:01:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4L3fNz53f9z1LBRv DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1652940067; bh=LkQUFUw17uGemFYooiP9vpDk6817KQb4O26lj4ByCa8=; h=Subject:From:To:Date:In-Reply-To:References:From; b=DwfjCW15aYLdk/blGznAcT+whshf3GidVuEf65oMZaWNCfW9edb5ounQrwStYjIv7 8sagYso5KseHtFs4awye3qYhSmtaXLNdWLSggO1gs8wxwF/SMOTWvNf7YwgjXFxdXn JY8Pp2yUmNkvjsroersSo4XAVc2CxQByb85pw3KA= Message-ID: Subject: Re: bug#55517: Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) From: Liliana Marie Prikler To: Zhu Zihao , 55517@debbugs.gnu.org Date: Thu, 19 May 2022 08:01:08 +0200 In-Reply-To: <86sfp6je99.fsf@163.com> References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55517 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) For easier reading I suggest doing Am Donnerstag, dem 19.05.2022 um 13:13 +0800 schrieb Zhu Zihao: > * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]: Use G- > expressions. this in an extra commit and > : Remove this argument. > : Exclude the magit-libgit.el and magit-libgit-pkg.el. > : In phase 'patch-exec-paths', use search-input-file for perl > executable. > [inputs]: Remove emacs-libgit. this either before or after it. Also don't forget the "#:" in the arguments. Cheers From debbugs-submit-bounces@debbugs.gnu.org Thu May 19 23:53:33 2022 Received: (at 55517) by debbugs.gnu.org; 20 May 2022 03:53:33 +0000 Received: from localhost ([127.0.0.1]:37171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrthl-0001Kg-6u for submit@debbugs.gnu.org; Thu, 19 May 2022 23:53:33 -0400 Received: from mail-m973.mail.163.com ([123.126.97.3]:64826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrthg-0001KP-5u for 55517@debbugs.gnu.org; Thu, 19 May 2022 23:53:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=UlElh fLAEHncYc4v9shzD5S9wy9VoPhZyEtXUqk86Xw=; b=K54yFpeSc3bFZCWXrbNbX pMitrUStONbqCD2R5OeJUfK3L8CFGm05eeFSpnkkLI1bC2nv2vm5DmqRV1GeguPO U6tnPV3mxQwqx/gDfiICBEL4PfcIZUDmd3KjCy2v0SVi3X5UFYGmkW+7KbrqaEph TCbeeTolOZH92XxPM95bBI= Received: from asus-laptop (unknown [27.38.118.8]) by smtp3 (Coremail) with SMTP id G9xpCgDn_XWtEIdi8qicDg--.1002S2; Fri, 20 May 2022 11:53:19 +0800 (CST) References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Zhu Zihao To: Liliana Marie Prikler Subject: Re: bug#55517: Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) Date: Fri, 20 May 2022 11:52:51 +0800 In-reply-to: Message-ID: <86leuw507n.fsf@163.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-CM-TRANSID: G9xpCgDn_XWtEIdi8qicDg--.1002S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUj18BDUUUU X-Originating-IP: [27.38.118.8] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/xtbBLw8Hr2HmmxbObgAAsi X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55517 Cc: 55517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIsEARYIADMWIQRefA5qkqvnKdl/GTlmOX+E92aT+QUCYocQrBUcYWxsX2J1dF9s YXN0QDE2My5jb20ACgkQZjl/hPdmk/lvpAEAq9xOazY7oteVizCXnK2jEnrWB+26 RP9XEFckVpXVOPIA/34CHdNUO3OrpzeQ53ub8Bje+mkrdjyZczh9SNrZlD4N =CTG0 -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-emacs-magit-Use-G-expressions.patch >From ee433f6bfa5a1cde74deff864934a2e00bf21a0c Mon Sep 17 00:00:00 2001 From: Zhu Zihao Date: Fri, 20 May 2022 11:49:10 +0800 Subject: [PATCH 1/2] gnu: emacs-magit: Use G-expressions. * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]: Use G-expressions. : In phase 'patch-exec-paths', use search-input-file for perl executable. --- gnu/packages/emacs-xyz.scm | 91 +++++++++++++++++++------------------- 1 file changed, 46 insertions(+), 45 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index eed2f4b71c..8198638c13 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -869,51 +869,52 @@ (define-public emacs-magit (base32 "0cxyvp2aav27znc7mf6c83q5pddpdniaqkrxn1r8dbgr540qmnpn")))) (build-system emacs-build-system) (arguments - `(#:emacs ,emacs-no-x ;module support is required - #:tests? #t - #:test-command '("make" "test") - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'build-info-manual - (lambda _ - (invoke "make" "info") - ;; Copy info files to the lisp directory, which acts as - ;; the root of the project for the emacs-build-system. - (for-each (lambda (f) - (install-file f "lisp")) - (find-files "Documentation" "\\.info$")) - (chdir "lisp"))) - (add-after 'build-info-manual 'set-magit-version - (lambda _ - (make-file-writable "magit.el") - (emacs-substitute-variables "magit.el" - ("magit-version" ,version)))) - (add-after 'set-magit-version 'patch-exec-paths - (lambda* (#:key inputs #:allow-other-keys) - (let ((perl (assoc-ref inputs "perl"))) - (make-file-writable "magit-sequence.el") - (emacs-substitute-variables "magit-sequence.el" - ("magit-perl-executable" (string-append perl "/bin/perl")))))) - (add-before 'check 'configure-git - (lambda _ - ;; Otherwise some tests fail with error "unable to auto-detect - ;; email address". - (setenv "HOME" (getcwd)) - (invoke "git" "config" "--global" "user.name" "toto") - (invoke "git" "config" "--global" "user.email" - "toto@toto.com"))) - (add-after 'configure-git 'disable-tramp-test - (lambda _ - ;; There is an issue causing TRAMP to fail in the build - ;; environment. Setting the tramp-remote-shell parameter of - ;; the sudo-method to the file name of the shell didn't help. - (chdir "..") - (substitute* "t/magit-tests.el" - (("^\\(ert-deftest magit-toplevel:tramp.*" all) - (string-append all " (skip-unless nil)"))))) - (add-before 'install 'enter-lisp-directory - (lambda _ - (chdir "lisp")))))) + (list + #:emacs emacs-no-x + #:tests? #t + #:test-command #~(list "make" "test") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'build-info-manual + (lambda _ + (invoke "make" "info") + ;; Copy info files to the lisp directory, which acts as + ;; the root of the project for the emacs-build-system. + (for-each (lambda (f) + (install-file f "lisp")) + (find-files "Documentation" "\\.info$")) + (chdir "lisp"))) + (add-after 'build-info-manual 'set-magit-version + (lambda _ + (make-file-writable "magit.el") + (emacs-substitute-variables "magit.el" + ("magit-version" #$version)))) + (add-after 'set-magit-version 'patch-exec-paths + (lambda* (#:key inputs #:allow-other-keys) + (let ((perl (search-input-file inputs "/bin/perl"))) + (make-file-writable "magit-sequence.el") + (emacs-substitute-variables "magit-sequence.el" + ("magit-perl-executable" perl))))) + (add-before 'check 'configure-git + (lambda _ + ;; Otherwise some tests fail with error "unable to auto-detect + ;; email address". + (setenv "HOME" (getcwd)) + (invoke "git" "config" "--global" "user.name" "toto") + (invoke "git" "config" "--global" "user.email" + "toto@toto.com"))) + (add-after 'configure-git 'disable-tramp-test + (lambda _ + ;; There is an issue causing TRAMP to fail in the build + ;; environment. Setting the tramp-remote-shell parameter of + ;; the sudo-method to the file name of the shell didn't help. + (chdir "..") + (substitute* "t/magit-tests.el" + (("^\\(ert-deftest magit-toplevel:tramp.*" all) + (string-append all " (skip-unless nil)"))))) + (add-before 'install 'enter-lisp-directory + (lambda _ + (chdir "lisp")))))) (native-inputs (list texinfo)) (inputs -- 2.36.0 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-gnu-emacs-magit-Drop-the-libgit-backend.patch >From 983a23d9ae1fde345e9ad92f49dbb30e73cc8498 Mon Sep 17 00:00:00 2001 From: Zhu Zihao Date: Fri, 20 May 2022 11:51:02 +0800 Subject: [PATCH 2/2] gnu: emacs-magit: Drop the libgit backend. Drop the libgit backend for following reasons: 1. The libgit backend of Magitis very incomplete. There's almost no benefits, but extra maintenance efforts. 2. The libgit backend of Magit can be considered as an extra package. And it's still in Proof-Of-Concept status so its quaility doesn't satisfy the requirement of Guix package. * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments] : Remove this argument. : Exclude the magit-libgit.el and magit-libgit-pkg.el. [inputs]: Remove emacs-libgit. --- gnu/packages/emacs-xyz.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 8198638c13..d3ca00475e 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -870,9 +870,11 @@ (define-public emacs-magit (build-system emacs-build-system) (arguments (list - #:emacs emacs-no-x #:tests? #t #:test-command #~(list "make" "test") + #:exclude #~(cons* "magit-libgit.el" + "magit-libgit-pkg.el" + %default-exclude) #:phases #~(modify-phases %standard-phases (add-after 'unpack 'build-info-manual @@ -920,7 +922,7 @@ (define-public emacs-magit (inputs (list git perl)) (propagated-inputs - (list emacs-dash emacs-libgit emacs-transient emacs-with-editor)) + (list emacs-dash emacs-transient emacs-with-editor)) (home-page "https://magit.vc/") (synopsis "Emacs interface for the Git version control system") (description -- 2.36.0 --=-=-= Content-Type: text/plain -- Retrieve my PGP public key: gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F Zihao --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 20 02:04:46 2022 Received: (at 55517) by debbugs.gnu.org; 20 May 2022 06:04:46 +0000 Received: from localhost ([127.0.0.1]:37311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrvkk-0004tm-5m for submit@debbugs.gnu.org; Fri, 20 May 2022 02:04:46 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:8926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrvki-0004td-6S for 55517@debbugs.gnu.org; Fri, 20 May 2022 02:04:45 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4L4GQc29Dxz3xqF; Fri, 20 May 2022 08:04:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1653026680; bh=qXWiS+3uD7WthKDWZMH032M28Q//Avd8lbFlcRwpnao=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=HFyGcUl8fhBCa7z7Pze75ZN+37x2wCvqMnmqxDjXi52F6EdMd6+CXyyUZWUXqrKg8 zUzyF/EOpDIBuJyo9CZjeK/cVq9MCv5tRXaUqNV3gQMZYx9PhP6f6gpYTVs0Fvhf0b oNQGE4mehleDXdAu3Wy0dXbgVNz/Wy8DBVq/LnaM= Message-ID: <07286c2df8ffb434e353bdde7bf8d427e9d7d9b2.camel@ist.tugraz.at> Subject: Re: bug#55517: Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) From: Liliana Marie Prikler To: Zhu Zihao Date: Fri, 20 May 2022 08:04:41 +0200 In-Reply-To: <86leuw507n.fsf@163.com> References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> <86leuw507n.fsf@163.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55517 Cc: 55517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Freitag, dem 20.05.2022 um 11:52 +0800 schrieb Zhu Zihao: > - `(#:emacs ,emacs-no-x ;module support is required > + (list > + #:emacs emacs-no-x You do drop that argument in the second commit, but I think we ought to still keep the comment in this one. Do add a space between ';' and "module", though. > gnu: emacs-magit: Drop the libgit backend. > > Drop the libgit backend for following reasons: > > 1. The libgit backend of Magitis very incomplete. There's almost no > benefits, but extra maintenance efforts. > > 2. The libgit backend of Magit can be considered as an extra package. > And it's still in Proof-Of-Concept status so its quaility doesn't > satisfy the requirement of Guix package. I'd rather write this as follows: > gnu: emacs-magit: Drop the libgit backend. > > The libgit backend currently provides next to no features, but > demands extra maintenance overhead. It is in fact not a usable > backend; thus let's not use it. The "extra package" thing is imho not so correct from observing the Makefile (even if there's an extra -pkg.el), so let's wait until upstream makes that clearer. Other than that LGTM. From debbugs-submit-bounces@debbugs.gnu.org Fri May 20 22:13:42 2022 Received: (at 55517) by debbugs.gnu.org; 21 May 2022 02:13:42 +0000 Received: from localhost ([127.0.0.1]:40420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsEcf-0003vj-V8 for submit@debbugs.gnu.org; Fri, 20 May 2022 22:13:42 -0400 Received: from mail-qk1-f178.google.com ([209.85.222.178]:46900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsEce-0003vW-7g for 55517@debbugs.gnu.org; Fri, 20 May 2022 22:13:41 -0400 Received: by mail-qk1-f178.google.com with SMTP id c1so9126615qkf.13 for <55517@debbugs.gnu.org>; Fri, 20 May 2022 19:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=MbH8glulQebkzbmblFOJwGc6/rmve0o7YKQmbDHtFa0=; b=DfWMkIfS7jX1DpGRe7QMc9uagETPxLyV6AK7jcxQvLM9ptInYUczEqrcpuo5q3ZJ5g OqfCCUObuDdm/DrGIYO6PDhwAtgEKPMY284FWWF/QBSlWEAf/6j3bUJxVn+Kqoxq6swl 7R0gA19zdP0FdFarQFvI45Mpn+beCQ89XL3poPh2y4mqSJeX7xP9InNYJYyeCNk5I7pF dRUvDffzoIX3/k/SxCDIVuBEs3VZX7VT3dReEsrgaNZnzX+VgWzcsRFtqDMf8RQjfoem MlojMrbERWkqe7ogn9/wrOy/GrxcrJ3CYWFi435UZNjD27nXgeF0WN5CYdczJPFbbi1U bY0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=MbH8glulQebkzbmblFOJwGc6/rmve0o7YKQmbDHtFa0=; b=z/ZAC1B+MewJhZ8MICT8GQtUuuaKKv6TJ+sKYZJWPxzDHzcJTYef3StOyX6n8FhniB jbH+D8wrlGAO0Df3FgmP3jv6lanX4gPpL1cJ8QAplwpVdgyzHK2HMM2AkZTVOX9sY3sU ou5kEN4LC7M7luYBi9HVk6tqnheMsHbi7eexHbk5bnypwmBJWaPX/cIpYnoi0RZ6e+QQ drwwm50QJ8cvQARtVvOXrTjTTxGZqkVwOSEdMhffIPO693t6nklKnfL5K0XOuRZagPT/ 4CMpsk7EzNCvFMso976EOwKnrlokLvibUSwnIZr9SdRT0Vfn4bZQpik+cOttiXzPQuxf y76A== X-Gm-Message-State: AOAM531LmuMH5lTie/eii9w0BgSZV15Dl7BjaaGfioAQrS9TQPMErR8B uyafZqajbNc+X7m5hTBMc1+K/dN0OIA6kw== X-Google-Smtp-Source: ABdhPJwjXZJ3njQWARv+38HK6NT9x+s5SVLadoasL0V2ExlpLuoRpcGtDTGCQqBrzAQQaZvPnURdzA== X-Received: by 2002:a05:620a:c46:b0:67e:1559:559a with SMTP id u6-20020a05620a0c4600b0067e1559559amr7898689qki.437.1653099214567; Fri, 20 May 2022 19:13:34 -0700 (PDT) Received: from hurd (dsl-10-148-238.b2b2c.ca. [72.10.148.238]) by smtp.gmail.com with ESMTPSA id n5-20020a37bd05000000b006a0462eb091sm648481qkf.80.2022.05.20.19.13.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 19:13:34 -0700 (PDT) From: Maxim Cournoyer To: Zhu Zihao Subject: Re: bug#55517: [PATCH]: gnu: emacs-magit: Drop the libgit backend. References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> Date: Fri, 20 May 2022 22:13:32 -0400 In-Reply-To: <86sfp6je99.fsf@163.com> (Zhu Zihao's message of "Thu, 19 May 2022 13:13:36 +0800") Message-ID: <87tu9jbpkj.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55517 Cc: 55517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Zhu, Zhu Zihao writes: > Fix the typo in commit message > >>>From 8a2de5764a67bea1cbf789c8d6ce0ab0878ec40b Mon Sep 17 00:00:00 2001 > From: Zhu Zihao > Date: Thu, 19 May 2022 13:01:46 +0800 > Subject: [PATCH] gnu: emacs-magit: Drop the libgit backend. > > Drop the libgit backend for following reasons: > > 1. The libgit backend of Magitis very incomplete. There's almost no benefits, > but extra maintenance efforts. Could you elaborate about "almost no benefits"? Even if it's a small benefit, if it makes it faster, I'd still keep it since Magit is at times excruciatingly slow. > 2. The libgit backend of Magit can be considered as an extra package. And it's > still in Proof-Of-Concept status so its quaility doesn't satisfy the > requirement of Guix package. There's not really any "quality requirements" for Guix package; we package stable releases when they're available; the rest is up to us Guix users. Do you happen to have a link to some exchange where Magit authors would recommend against using the libgit library at this point in time to speed up Magit? Otherwise, I'm not convinced. Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 00:00:54 2022 Received: (at 55517) by debbugs.gnu.org; 21 May 2022 04:00:54 +0000 Received: from localhost ([127.0.0.1]:40460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsGIP-0000S5-IY for submit@debbugs.gnu.org; Sat, 21 May 2022 00:00:54 -0400 Received: from mail-m972.mail.163.com ([123.126.97.2]:63593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsGIJ-0000Rd-4L for 55517@debbugs.gnu.org; Sat, 21 May 2022 00:00:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=BHHZ0 akO4FFvZX8VJXdstofCBndVQGZZzxNDG6r+xrA=; b=GPIQZGrLyCoFDy0Ewickp wIIRKlcrSuCqhOcZb58wysA1gcbx6caA0AJrBrtUat/22yjd2o45Plxo/GcUCK1X 4lwoTF7bBreyMIYZif/V/KM6Tk7zN3IO90rNJzn92D+lxsaW1F5daXGjJ3n4evcs cKdGTPeBUI9v5FaPtbdvpQ= Received: from asus-laptop (unknown [27.38.118.8]) by smtp2 (Coremail) with SMTP id GtxpCgDH8M3fY4hisMEtDw--.13590S2; Sat, 21 May 2022 12:00:32 +0800 (CST) References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> <87tu9jbpkj.fsf_-_@gmail.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Zhu Zihao To: Maxim Cournoyer Subject: Re: bug#55517: [PATCH]: gnu: emacs-magit: Drop the libgit backend. Date: Sat, 21 May 2022 11:45:46 +0800 In-reply-to: <87tu9jbpkj.fsf_-_@gmail.com> Message-ID: <865ylzy1pr.fsf@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-CM-TRANSID: GtxpCgDH8M3fY4hisMEtDw--.13590S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ur4rGr4kCrWruFyxKw45KFg_yoW8trWfpF WrW3yjkr18Xr10vwnrGF4Svr10ya1rtry3t3WrurWrAa1DWwnaq34qkrs8Wa4UGr97Kayj qw4j9w1qgF15ZaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zR53k_UUUUU= X-Originating-IP: [27.38.118.8] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/xtbBawAIr1et45O60QAAst X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55517 Cc: 55517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Maxim Cournoyer writes: > Hi Zhu, > > Zhu Zihao writes: > >> Fix the typo in commit message >> >>>>From 8a2de5764a67bea1cbf789c8d6ce0ab0878ec40b Mon Sep 17 00:00:00 2001 >> From: Zhu Zihao >> Date: Thu, 19 May 2022 13:01:46 +0800 >> Subject: [PATCH] gnu: emacs-magit: Drop the libgit backend. >> >> Drop the libgit backend for following reasons: >> >> 1. The libgit backend of Magitis very incomplete. There's almost no bene= fits, >> but extra maintenance efforts. > > Could you elaborate about "almost no benefits"? Even if it's a small > benefit, if it makes it faster, I'd still keep it since Magit is at > times excruciatingly slow. It's slow? AFAIK magit user always complain that magit on Windows system is slow. The process creation on *nix is much cheaper than Windows, so Magit is not slow on *nix. I've elaborated the reason in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55427. The libgit backend of Magit is almost nothing, only one function is implemented. `magit-bare-repo-p` will be used in magit-toplevel which is called frequently in the magit source code. But this function is cached. You can still say it's faster, but it's fair to say the libgit backend doesn't worth the maintenance effort due to the inactive status of upstream. >> 2. The libgit backend of Magit can be considered as an extra package. An= d it's >> still in Proof-Of-Concept status so its quaility doesn't satisfy the >> requirement of Guix package. > > There's not really any "quality requirements" for Guix package; we > package stable releases when they're available; the rest is up to us > Guix users. If you really wants to keep the libgit backend. I'd suggest to make it a dedicated package. If emacs-libgit is broken (again), magit is still usable= .=20 > Do you happen to have a link to some exchange where Magit authors would > recommend against using the libgit library at this point in time to > speed up Magit? Otherwise, I'm not convinced. No, I've said above. The libgit backend is very very very imcomplete. > > Thanks, > > Maxim =2D-=20 Retrieve my PGP public key: gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F Zihao --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIsEARYIADMWIQRefA5qkqvnKdl/GTlmOX+E92aT+QUCYohj0BUcYWxsX2J1dF9s YXN0QDE2My5jb20ACgkQZjl/hPdmk/l1dwEA7Lx3vw5Qe6deTnxgi4+9s/laiwVF zcCuENu6uLilTfYBAOsENZP5vOTBfMcOzD/vJ45XDtDWBYSwl2gRETebu2EM =S2bE -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 20:46:42 2022 Received: (at 55517) by debbugs.gnu.org; 22 May 2022 00:46:43 +0000 Received: from localhost ([127.0.0.1]:43217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsZk2-0002eX-Kh for submit@debbugs.gnu.org; Sat, 21 May 2022 20:46:42 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:46888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsZjx-0002eH-5b for 55517@debbugs.gnu.org; Sat, 21 May 2022 20:46:40 -0400 Received: by mail-qt1-f179.google.com with SMTP id u35so10407727qtc.13 for <55517@debbugs.gnu.org>; Sat, 21 May 2022 17:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BfgmRvo3EwcIPx+jkMjtyTDleGQlXaQQ++QDInxS5WU=; b=GN5R5sVhyVjgxgreuLZi2arA1SF6vUxYIu5FLTRYijS/ry3GIt1EmkdrsNR50OaaHm gQZI566ETSqrBte4fjvPZUgWim6Bs6UdZTRGvOiCfMF8U12NdRq7mfwNoZ8FGb9uyD/2 ZBU6nWVYoW34tyPENUhotJGZwuPODfrih+mjyC4CHZQT2ziR/j0Wk/vh9H6r7QyiYqWH 1MRfgQtyngvWgMY4Ov3tmqn6+3JoT+TlwF0c/Vsv6IZxWUhM0rATiRrndQuN8nUslUMP dY5ER01ttpIPozLtqg/L9dlAjrdpOOJDcC05l7I4Puo+oQaiH6Q1/nwFeVIIXD0nYgYR ns0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BfgmRvo3EwcIPx+jkMjtyTDleGQlXaQQ++QDInxS5WU=; b=yAK2e5G/5rXKQrah8mbjXGUIreQC5BWFvrkUCPnSx4J8bUEwgQzrok9nZV+fes3T2Z SHJ2rbUlwS+ayccjtrRR0oB697wtdZV7JjEqhozosRmPGLAtmkGqtOPE6UmSG0c5rpaB tiahp4R+s45U5bjN/+agC0jfwy5dybYBgqv44OowxoiEZ4ccgAVjys1hc3kNC97NnB4M DWoSOcwcu5IB+ipWJGqY5PcRy1nbmGvZtRBAujXJXWt+uyOm+LH8gTCHeWyL5zdNJHZF 9iRDSEcJrzqO6YMhu/7ITUqdugRvE0FcTFYgWDoI/W/ttyfIU4DBakczuNbkzELLXLek 1IGA== X-Gm-Message-State: AOAM531i9oHkPGDwWHeK4dS/flb/edIZK2ACGfUFoxyLqCPEz0vDjwf1 j9LvXm4lBSY7uv/gz8fzsnLfvkkfuuBIpA== X-Google-Smtp-Source: ABdhPJxM3+UV6MFGDhgxAWYRbiRtQkNvN63fLl/LjJwtn/C+GjcbruvmB7rPhv2o9ZwPRwkxx9LYvA== X-Received: by 2002:a05:622a:514:b0:2f4:5f66:7025 with SMTP id l20-20020a05622a051400b002f45f667025mr12395460qtx.141.1653180391431; Sat, 21 May 2022 17:46:31 -0700 (PDT) Received: from hurd (dsl-152-80.b2b2c.ca. [66.158.152.80]) by smtp.gmail.com with ESMTPSA id l127-20020a37a285000000b0069fc13ce1f3sm2156206qke.36.2022.05.21.17.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 17:46:31 -0700 (PDT) From: Maxim Cournoyer To: Zhu Zihao Subject: Re: bug#55517: [PATCH]: gnu: emacs-magit: Drop the libgit backend. References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> <87tu9jbpkj.fsf_-_@gmail.com> <865ylzy1pr.fsf@163.com> Date: Sat, 21 May 2022 20:46:13 -0400 In-Reply-To: <865ylzy1pr.fsf@163.com> (Zhu Zihao's message of "Sat, 21 May 2022 11:45:46 +0800") Message-ID: <87tu9i9yy2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55517 Cc: 55517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Zhu Zihao writes: > Maxim Cournoyer writes: > >> Hi Zhu, >> >> Zhu Zihao writes: >> >>> Fix the typo in commit message >>> >>>>>From 8a2de5764a67bea1cbf789c8d6ce0ab0878ec40b Mon Sep 17 00:00:00 2001 >>> From: Zhu Zihao >>> Date: Thu, 19 May 2022 13:01:46 +0800 >>> Subject: [PATCH] gnu: emacs-magit: Drop the libgit backend. >>> >>> Drop the libgit backend for following reasons: >>> >>> 1. The libgit backend of Magitis very incomplete. There's almost no benefits, >>> but extra maintenance efforts. >> >> Could you elaborate about "almost no benefits"? Even if it's a small >> benefit, if it makes it faster, I'd still keep it since Magit is at >> times excruciatingly slow. > > It's slow? AFAIK magit user always complain that magit on Windows system > is slow. The process creation on *nix is much cheaper than Windows, so > Magit is not slow on *nix. I've never used it on Windows, but yes, when working with hundred of commits it's quite slow; just refreshing the status buffer takes ages. > I've elaborated the reason in > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55427. > > The libgit backend of Magit is almost nothing, only one function is > implemented. `magit-bare-repo-p` will be used in magit-toplevel which is > called frequently in the magit source code. But this function is cached. Thanks for that; I've looked at magit-libgit.el and it indeed doesn't appear to provide much of anything yet. I guess we could drop the dependency for now and revisit it in the future if/when development picks up again on the magit/libgit integration. Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun May 22 05:46:37 2022 Received: (at 55517) by debbugs.gnu.org; 22 May 2022 09:46:37 +0000 Received: from localhost ([127.0.0.1]:43663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsiAW-0004YW-RU for submit@debbugs.gnu.org; Sun, 22 May 2022 05:46:37 -0400 Received: from mail-m975.mail.163.com ([123.126.97.5]:9391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsiAR-0004Xw-HY for 55517@debbugs.gnu.org; Sun, 22 May 2022 05:46:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=ZzRMF EEPhC86GHto0cv1a9KJ85lmJKlt3/fVd9k1gK4=; b=YtweWfBSiKKeT+fKXzD8U In9XkY9KaheD7vylyVLLX4YTvEVmO9s+sxWTYXsqNUH/uzDGd+MQcIH0huOxAl+b uURxhQXESAuqmspzDGVWjcw1wmez0QN36CBpjr0sweskipCRGzw200mH4geWVqgP SK7E5f4GNaDL+ZnyTriQds= Received: from asus-laptop (unknown [163.125.202.234]) by smtp5 (Coremail) with SMTP id HdxpCgBH0QhqBopiYPfCDg--.12411S2; Sun, 22 May 2022 17:46:19 +0800 (CST) References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> <86leuw507n.fsf@163.com> <07286c2df8ffb434e353bdde7bf8d427e9d7d9b2.camel@ist.tugraz.at> User-agent: mu4e 1.6.10; emacs 27.2 From: Zhu Zihao To: Liliana Marie Prikler Subject: Re: bug#55517: Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) Date: Sun, 22 May 2022 17:46:01 +0800 In-reply-to: <07286c2df8ffb434e353bdde7bf8d427e9d7d9b2.camel@ist.tugraz.at> Message-ID: <86o7zpaoih.fsf@163.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-CM-TRANSID: HdxpCgBH0QhqBopiYPfCDg--.12411S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUbBTYDUUUU X-Originating-IP: [163.125.202.234] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/xtbBPQsJr2AZAoMv-wAAs4 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55517 Cc: 55517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIsEARYIADMWIQRefA5qkqvnKdl/GTlmOX+E92aT+QUCYooGZhUcYWxsX2J1dF9s YXN0QDE2My5jb20ACgkQZjl/hPdmk/lKXwEArTGTFgl4ZwH8NSLCtE6uOVul+9gG NZ3CWhtQFFlLekkA/Aj/A9GJFvXT5m+ncvVDr87FUplp0YN8MIRSTZ3YNCQF =C94O -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-emacs-magit-Use-G-expressions.patch >From e1d5e1da9229fc317f96e75d4e07e230fa6988fe Mon Sep 17 00:00:00 2001 From: Zhu Zihao Date: Sun, 22 May 2022 17:43:42 +0800 Subject: [PATCH 1/2] gnu: emacs-magit: Use G-expressions. * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]: Use G-expressions. : In phase 'patch-exec-paths', use search-input-file for perl executable. --- gnu/packages/emacs-xyz.scm | 91 +++++++++++++++++++------------------- 1 file changed, 46 insertions(+), 45 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index eed2f4b71c..8970b2d350 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -869,51 +869,52 @@ (define-public emacs-magit (base32 "0cxyvp2aav27znc7mf6c83q5pddpdniaqkrxn1r8dbgr540qmnpn")))) (build-system emacs-build-system) (arguments - `(#:emacs ,emacs-no-x ;module support is required - #:tests? #t - #:test-command '("make" "test") - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'build-info-manual - (lambda _ - (invoke "make" "info") - ;; Copy info files to the lisp directory, which acts as - ;; the root of the project for the emacs-build-system. - (for-each (lambda (f) - (install-file f "lisp")) - (find-files "Documentation" "\\.info$")) - (chdir "lisp"))) - (add-after 'build-info-manual 'set-magit-version - (lambda _ - (make-file-writable "magit.el") - (emacs-substitute-variables "magit.el" - ("magit-version" ,version)))) - (add-after 'set-magit-version 'patch-exec-paths - (lambda* (#:key inputs #:allow-other-keys) - (let ((perl (assoc-ref inputs "perl"))) - (make-file-writable "magit-sequence.el") - (emacs-substitute-variables "magit-sequence.el" - ("magit-perl-executable" (string-append perl "/bin/perl")))))) - (add-before 'check 'configure-git - (lambda _ - ;; Otherwise some tests fail with error "unable to auto-detect - ;; email address". - (setenv "HOME" (getcwd)) - (invoke "git" "config" "--global" "user.name" "toto") - (invoke "git" "config" "--global" "user.email" - "toto@toto.com"))) - (add-after 'configure-git 'disable-tramp-test - (lambda _ - ;; There is an issue causing TRAMP to fail in the build - ;; environment. Setting the tramp-remote-shell parameter of - ;; the sudo-method to the file name of the shell didn't help. - (chdir "..") - (substitute* "t/magit-tests.el" - (("^\\(ert-deftest magit-toplevel:tramp.*" all) - (string-append all " (skip-unless nil)"))))) - (add-before 'install 'enter-lisp-directory - (lambda _ - (chdir "lisp")))))) + (list + #:emacs emacs-no-x ;module support is required + #:tests? #t + #:test-command #~(list "make" "test") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'build-info-manual + (lambda _ + (invoke "make" "info") + ;; Copy info files to the lisp directory, which acts as + ;; the root of the project for the emacs-build-system. + (for-each (lambda (f) + (install-file f "lisp")) + (find-files "Documentation" "\\.info$")) + (chdir "lisp"))) + (add-after 'build-info-manual 'set-magit-version + (lambda _ + (make-file-writable "magit.el") + (emacs-substitute-variables "magit.el" + ("magit-version" #$version)))) + (add-after 'set-magit-version 'patch-exec-paths + (lambda* (#:key inputs #:allow-other-keys) + (let ((perl (search-input-file inputs "/bin/perl"))) + (make-file-writable "magit-sequence.el") + (emacs-substitute-variables "magit-sequence.el" + ("magit-perl-executable" perl))))) + (add-before 'check 'configure-git + (lambda _ + ;; Otherwise some tests fail with error "unable to auto-detect + ;; email address". + (setenv "HOME" (getcwd)) + (invoke "git" "config" "--global" "user.name" "toto") + (invoke "git" "config" "--global" "user.email" + "toto@toto.com"))) + (add-after 'configure-git 'disable-tramp-test + (lambda _ + ;; There is an issue causing TRAMP to fail in the build + ;; environment. Setting the tramp-remote-shell parameter of + ;; the sudo-method to the file name of the shell didn't help. + (chdir "..") + (substitute* "t/magit-tests.el" + (("^\\(ert-deftest magit-toplevel:tramp.*" all) + (string-append all " (skip-unless nil)"))))) + (add-before 'install 'enter-lisp-directory + (lambda _ + (chdir "lisp")))))) (native-inputs (list texinfo)) (inputs -- 2.36.0 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-gnu-emacs-magit-Drop-the-libgit-backend.patch >From d2f9cc135e51cdde0623b5ffc453efa11f30a5eb Mon Sep 17 00:00:00 2001 From: Zhu Zihao Date: Fri, 20 May 2022 11:51:02 +0800 Subject: [PATCH 2/2] gnu: emacs-magit: Drop the libgit backend. The libgit backend currently provides next to no features, but demands extra maintenance overhead. It is in fact not a usable backend; thus let's not use it. * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments] : Remove this argument. : Exclude the magit-libgit.el and magit-libgit-pkg.el. [inputs]: Remove emacs-libgit. --- gnu/packages/emacs-xyz.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 8970b2d350..d3ca00475e 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -870,9 +870,11 @@ (define-public emacs-magit (build-system emacs-build-system) (arguments (list - #:emacs emacs-no-x ;module support is required #:tests? #t #:test-command #~(list "make" "test") + #:exclude #~(cons* "magit-libgit.el" + "magit-libgit-pkg.el" + %default-exclude) #:phases #~(modify-phases %standard-phases (add-after 'unpack 'build-info-manual @@ -920,7 +922,7 @@ (define-public emacs-magit (inputs (list git perl)) (propagated-inputs - (list emacs-dash emacs-libgit emacs-transient emacs-with-editor)) + (list emacs-dash emacs-transient emacs-with-editor)) (home-page "https://magit.vc/") (synopsis "Emacs interface for the Git version control system") (description -- 2.36.0 --=-=-= Content-Type: text/plain -- Retrieve my PGP public key: gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F Zihao --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 23 02:46:36 2022 Received: (at 55517) by debbugs.gnu.org; 23 May 2022 06:46:36 +0000 Received: from localhost ([127.0.0.1]:47112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt1ps-00071v-A6 for submit@debbugs.gnu.org; Mon, 23 May 2022 02:46:36 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:6768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt1pr-00071j-2L for 55517@debbugs.gnu.org; Mon, 23 May 2022 02:46:35 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4L67CW1m5bz3xgK; Mon, 23 May 2022 08:46:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1653288391; bh=+wMDVsuog0pI+J4PtIEbSk+PS6hN06iTisXVR2HTQA8=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=RvLN+aOt/MTYtgBRjyWZ/wT0YWK46PJy9Imuu+Ltyuo1Xie9pzMhlEFfq8vOMmnSj 67Z/mKQ7Azfw4E72YlotJW3iF4aUbpOpRwfLRjpVpdQxvAt9gb30l7Y6bvaSGw0TdT 0XJmsRrBT1APPR0lsFPFQVvhHka3HjokWjsB/Gjk= Message-ID: Subject: Re: bug#55517: Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) From: Liliana Marie Prikler To: Zhu Zihao Date: Mon, 23 May 2022 08:46:31 +0200 In-Reply-To: <86o7zpaoih.fsf@163.com> References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> <86leuw507n.fsf@163.com> <07286c2df8ffb434e353bdde7bf8d427e9d7d9b2.camel@ist.tugraz.at> <86o7zpaoih.fsf@163.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55517 Cc: 55517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Sonntag, dem 22.05.2022 um 17:46 +0800 schrieb Zhu Zihao: > + (add-after 'set-magit-version 'patch-exec-paths > + (lambda* (#:key inputs #:allow-other-keys) > + (let ((perl (search-input-file inputs "/bin/perl"))) > + (make-file-writable "magit-sequence.el") > + (emacs-substitute-variables "magit-sequence.el" > + ("magit-perl-executable" perl))))) You do not need to let-bind perl here. Other than that LGTM. From debbugs-submit-bounces@debbugs.gnu.org Fri May 27 22:12:04 2022 Received: (at 55517) by debbugs.gnu.org; 28 May 2022 02:12:04 +0000 Received: from localhost ([127.0.0.1]:36136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nulvv-0003jC-QR for submit@debbugs.gnu.org; Fri, 27 May 2022 22:12:04 -0400 Received: from mail-m975.mail.163.com ([123.126.97.5]:44784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nulvq-0003ib-Ln for 55517@debbugs.gnu.org; Fri, 27 May 2022 22:12:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=wN3S2 99/bqyjH/HzzafqmQZZmTjdkDQnUnnNIfO43Rg=; b=F048hy9AoWEolQxBBjwn2 hDOxuKnVhWMDD3raPGRyoH3irroRllK0PDe0/RtmnG1ad2eIuJFpk973+gokCKHx 61krE0Rke9m6UppdvlL2SRkJ4eAJa+jFlvTt5/u0ezxbIX8ZvZmpjmhLQnzM6+wr ovqzger462Nm/UhrnyXog0= Received: from asus-laptop (unknown [163.125.202.234]) by smtp5 (Coremail) with SMTP id HdxpCgDncCbkhJFixMiaEg--.9102S2; Sat, 28 May 2022 10:11:49 +0800 (CST) References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> <86leuw507n.fsf@163.com> <07286c2df8ffb434e353bdde7bf8d427e9d7d9b2.camel@ist.tugraz.at> <86o7zpaoih.fsf@163.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Zhu Zihao To: Liliana Marie Prikler Subject: Re: bug#55517: Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) Date: Sat, 28 May 2022 10:11:27 +0800 In-reply-to: Message-ID: <8635gu9zj5.fsf@163.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-CM-TRANSID: HdxpCgDncCbkhJFixMiaEg--.9102S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUj18BDUUUU X-Originating-IP: [163.125.202.234] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/1tbiTwYPr1sGbMr7lQAAs8 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55517 Cc: 55517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIsEARYIADMWIQRefA5qkqvnKdl/GTlmOX+E92aT+QUCYpGE3hUcYWxsX2J1dF9s YXN0QDE2My5jb20ACgkQZjl/hPdmk/kx9QD+Kg0Dun5hT+EGxLf/H60ClAbavWkY U1nroWG5oQ7E3bcBAJFp5Uuntz9Jj0EtdMO8tGCPMGkqsZ6YN7us2BpazTsP =JcKD -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-emacs-magit-Use-G-expressions.patch >From 74cf2719131d2ebaa23c042fc2d3b5aeddc2be5c Mon Sep 17 00:00:00 2001 From: Zhu Zihao Date: Sun, 22 May 2022 17:43:42 +0800 Subject: [PATCH 1/2] gnu: emacs-magit: Use G-expressions. * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]: Use G-expressions. : In phase 'patch-exec-paths', use search-input-file for perl executable. --- gnu/packages/emacs-xyz.scm | 91 +++++++++++++++++++------------------- 1 file changed, 46 insertions(+), 45 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index eed2f4b71c..a9dc687af4 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -869,51 +869,52 @@ (define-public emacs-magit (base32 "0cxyvp2aav27znc7mf6c83q5pddpdniaqkrxn1r8dbgr540qmnpn")))) (build-system emacs-build-system) (arguments - `(#:emacs ,emacs-no-x ;module support is required - #:tests? #t - #:test-command '("make" "test") - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'build-info-manual - (lambda _ - (invoke "make" "info") - ;; Copy info files to the lisp directory, which acts as - ;; the root of the project for the emacs-build-system. - (for-each (lambda (f) - (install-file f "lisp")) - (find-files "Documentation" "\\.info$")) - (chdir "lisp"))) - (add-after 'build-info-manual 'set-magit-version - (lambda _ - (make-file-writable "magit.el") - (emacs-substitute-variables "magit.el" - ("magit-version" ,version)))) - (add-after 'set-magit-version 'patch-exec-paths - (lambda* (#:key inputs #:allow-other-keys) - (let ((perl (assoc-ref inputs "perl"))) - (make-file-writable "magit-sequence.el") - (emacs-substitute-variables "magit-sequence.el" - ("magit-perl-executable" (string-append perl "/bin/perl")))))) - (add-before 'check 'configure-git - (lambda _ - ;; Otherwise some tests fail with error "unable to auto-detect - ;; email address". - (setenv "HOME" (getcwd)) - (invoke "git" "config" "--global" "user.name" "toto") - (invoke "git" "config" "--global" "user.email" - "toto@toto.com"))) - (add-after 'configure-git 'disable-tramp-test - (lambda _ - ;; There is an issue causing TRAMP to fail in the build - ;; environment. Setting the tramp-remote-shell parameter of - ;; the sudo-method to the file name of the shell didn't help. - (chdir "..") - (substitute* "t/magit-tests.el" - (("^\\(ert-deftest magit-toplevel:tramp.*" all) - (string-append all " (skip-unless nil)"))))) - (add-before 'install 'enter-lisp-directory - (lambda _ - (chdir "lisp")))))) + (list + #:emacs emacs-no-x ;module support is required + #:tests? #t + #:test-command #~(list "make" "test") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'build-info-manual + (lambda _ + (invoke "make" "info") + ;; Copy info files to the lisp directory, which acts as + ;; the root of the project for the emacs-build-system. + (for-each (lambda (f) + (install-file f "lisp")) + (find-files "Documentation" "\\.info$")) + (chdir "lisp"))) + (add-after 'build-info-manual 'set-magit-version + (lambda _ + (make-file-writable "magit.el") + (emacs-substitute-variables "magit.el" + ("magit-version" #$version)))) + (add-after 'set-magit-version 'patch-exec-paths + (lambda* (#:key inputs #:allow-other-keys) + (make-file-writable "magit-sequence.el") + (emacs-substitute-variables "magit-sequence.el" + ("magit-perl-executable" + (search-input-file inputs "/bin/perl"))))) + (add-before 'check 'configure-git + (lambda _ + ;; Otherwise some tests fail with error "unable to auto-detect + ;; email address". + (setenv "HOME" (getcwd)) + (invoke "git" "config" "--global" "user.name" "toto") + (invoke "git" "config" "--global" "user.email" + "toto@toto.com"))) + (add-after 'configure-git 'disable-tramp-test + (lambda _ + ;; There is an issue causing TRAMP to fail in the build + ;; environment. Setting the tramp-remote-shell parameter of + ;; the sudo-method to the file name of the shell didn't help. + (chdir "..") + (substitute* "t/magit-tests.el" + (("^\\(ert-deftest magit-toplevel:tramp.*" all) + (string-append all " (skip-unless nil)"))))) + (add-before 'install 'enter-lisp-directory + (lambda _ + (chdir "lisp")))))) (native-inputs (list texinfo)) (inputs -- 2.36.1 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-gnu-emacs-magit-Drop-the-libgit-backend.patch >From 259d81469127306c4f345598f487122659a55c9c Mon Sep 17 00:00:00 2001 From: Zhu Zihao Date: Sat, 28 May 2022 10:10:31 +0800 Subject: [PATCH 2/2] gnu: emacs-magit: Drop the libgit backend. The libgit backend currently provides next to no features, but demands extra maintenance overhead. It is in fact not a usable backend; thus let's not use it. * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments] : Remove this argument. : Exclude the magit-libgit.el and magit-libgit-pkg.el. [inputs]: Remove emacs-libgit. --- gnu/packages/emacs-xyz.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index a9dc687af4..21359882ad 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -870,9 +870,11 @@ (define-public emacs-magit (build-system emacs-build-system) (arguments (list - #:emacs emacs-no-x ;module support is required #:tests? #t #:test-command #~(list "make" "test") + #:exclude #~(cons* "magit-libgit.el" + "magit-libgit-pkg.el" + %default-exclude) #:phases #~(modify-phases %standard-phases (add-after 'unpack 'build-info-manual @@ -920,7 +922,7 @@ (define-public emacs-magit (inputs (list git perl)) (propagated-inputs - (list emacs-dash emacs-libgit emacs-transient emacs-with-editor)) + (list emacs-dash emacs-transient emacs-with-editor)) (home-page "https://magit.vc/") (synopsis "Emacs interface for the Git version control system") (description -- 2.36.1 --=-=-= Content-Type: text/plain -- Retrieve my PGP public key: gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F Zihao --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 28 02:56:37 2022 Received: (at 55517-done) by debbugs.gnu.org; 28 May 2022 06:56:37 +0000 Received: from localhost ([127.0.0.1]:36307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuqNI-0004hZ-SU for submit@debbugs.gnu.org; Sat, 28 May 2022 02:56:36 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:38769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuqNH-0004hB-1B for 55517-done@debbugs.gnu.org; Sat, 28 May 2022 02:56:35 -0400 Received: by mail-ed1-f65.google.com with SMTP id n22so4788779eda.5 for <55517-done@debbugs.gnu.org>; Fri, 27 May 2022 23:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=SotaWDyk5C/0d9fRJzSQPZd/S4AdbC72rSWlXVo+Wec=; b=V7psuPPLy/6LiBiC7UrTxK+RTPZ4zqxNOKxyAw2rvWTPraBk+QAJGfLPTCgaEzJtcT MOOailSpe/B+nl+zWqQasUfRtKqLgGkAEPv9W3LZxqZT76YFpUNreaq9aRbh0eljDVPc 7+8FXzcB381rxDiQeB9eNLb5EQ+pj80F+7nB/21RpqdfppePQKFq8+KPg+Kbx5aw9u60 FlT9tJGXoIGn1CkLT3VlEX7OLltnCyBppDoBFqv3lImOaLPJ7nSaKPsD7crTeoTgXZ4b ZvucVV7jWJ861KlAjeuLIWvrcVnpeSQb4OV489gKIBNeLFPVm7T/rJzej8MEihSBGuXL kOYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=SotaWDyk5C/0d9fRJzSQPZd/S4AdbC72rSWlXVo+Wec=; b=k5NJQHpZqBp56yw3LiLRbXSxhpz6KCd4x5pGCgN4x51NEAEW4WHda96mU/bQBmrwLg z3p4QeC34R2mTJl01fiO2omBnd/nuy/Dxih+ksk2UboIeSzKqJW9vhy85krfOhKi/HQ5 nAMpxQmOwFnaiLshf8Nu819czYlWRCE6szPiTUCEdH5Ccu4R5LYx7q2JnhM2UxfMb667 +oRzwZQ6CUzIMZ+pii0ar5iFqQQZ3YeUNPUu17stotUwZAc7mVB/E24iLksFVsmY1CqB znUhB5bySWvs0dB+uYXam9AspiCm7jry8/yxNjz2xhyI6lgZXtiTqo3BPCEJy/ZbPrp0 ySkA== X-Gm-Message-State: AOAM53323KXZrVyA8pL62XjxmVOQdcrqiefJgD4JbRakG8soWED9z6s6 oN4UMb8jKbpmHlS0m7MmLNU= X-Google-Smtp-Source: ABdhPJwKq9W41dVL4rsP1YQVnnYp6qP+cdcwUs/hxqSlIVu3dYzW1GpWRC2pLi9aa/MUcs9gMjrMjA== X-Received: by 2002:aa7:d2d0:0:b0:42b:c56b:c619 with SMTP id k16-20020aa7d2d0000000b0042bc56bc619mr18551863edr.157.1653720989074; Fri, 27 May 2022 23:56:29 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id k8-20020a170906a38800b006f3ef214de7sm2093107ejz.77.2022.05.27.23.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 23:56:28 -0700 (PDT) Message-ID: Subject: Re: bug#55517: Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) From: Liliana Marie Prikler To: Zhu Zihao Date: Sat, 28 May 2022 08:56:27 +0200 In-Reply-To: <8635gu9zj5.fsf@163.com> References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> <86leuw507n.fsf@163.com> <07286c2df8ffb434e353bdde7bf8d427e9d7d9b2.camel@ist.tugraz.at> <86o7zpaoih.fsf@163.com> <8635gu9zj5.fsf@163.com> Content-Type: text/plain User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55517-done Cc: 55517-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pushed with some slight rewordings in the commit message. Thanks From unknown Fri Jun 20 07:28:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 25 Jun 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator