GNU bug report logs - #55494
[PATCH] daemon: runChild() is forbidden to talk during environment set up

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: yarl-baudig <at> mailoo.org
Subject: bug#55494: closed (Re: bug#55494: [PATCH] daemon: runChild() is
 forbidden to talk during environment  set up)
Date: Thu, 19 May 2022 14:49:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#55494: [PATCH] daemon: runChild() is forbidden to talk during environment  set up

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 55494 <at> debbugs.gnu.org.

-- 
55494: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55494
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: yarl-baudig <at> mailoo.org
Cc: 55324-done <at> debbugs.gnu.org, 55494-done <at> debbugs.gnu.org
Subject: Re: bug#55494: [PATCH] daemon: runChild() is forbidden to talk
 during environment  set up
Date: Thu, 19 May 2022 16:48:09 +0200

Hi,

yarl-baudig <at> mailoo.org skribis:

> DerivationGoal::startBuilder() is waiting for an empty line as a check that
> the environment set up is fine.
>
> Fixes <https://issues.guix.gnu.org/55324>

Oh, good catch!

I tweaked the commit log and applied it.

Thank you!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: yarl-baudig <at> mailoo.org
To: guix-patches <at> gnu.org
Subject: [PATCH] daemon: runChild() is forbidden to talk during
 environment  set up
Date: Tue, 17 May 2022 23:08:54 +0200 (CEST)

DerivationGoal::startBuilder() is waiting for an empty line as a check that
the environment set up is fine.

Fixes <https://issues.guix.gnu.org/55324>
---
 nix/libstore/build.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc
index f6431bb726..9305208009 100644
--- a/nix/libstore/build.cc
+++ b/nix/libstore/build.cc
@@ -2057,7 +2057,6 @@ void DerivationGoal::runChild()
                 Path source = i->second;
                 Path target = chrootRootDir + i->first;
                 if (source == "/proc") continue; // backwards compatibility
-                debug(format("bind mounting `%1%' to `%2%'") % source % target);
                 if (stat(source.c_str(), &st) == -1)
                     throw SysError(format("getting attributes of path `%1%'") % source);
                 if (S_ISDIR(st.st_mode))
-- 
2.36.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.