GNU bug report logs - #55466
[PATCH 0/2] Fix emacs packages failing to build

Previous Next

Package: guix-patches;

Reported by: luishgh <luishenriquegh2701 <at> gmail.com>

Date: Mon, 16 May 2022 23:47:02 UTC

Severity: normal

Tags: patch

Merged with 55467, 55468

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: luishgh <luishenriquegh2701 <at> gmail.com>
Subject: bug#55467: closed (Re: [bug#55466] [PATCH 0/2] Fix emacs packages
 failing to build)
Date: Tue, 17 May 2022 07:19:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#55466: [PATCH 1/2] gnu: emacs-racer: Update to 1e63e98.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 55467 <at> debbugs.gnu.org.

-- 
55466: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55466
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: luishgh <luishenriquegh2701 <at> gmail.com>
Cc: 55466-done <at> debbugs.gnu.org
Subject: Re: [bug#55466] [PATCH 0/2] Fix emacs packages failing to build
Date: Tue, 17 May 2022 09:18:27 +0200
Hello,

luishgh <luishenriquegh2701 <at> gmail.com> writes:

> this patch series fix a couple of emacs packages that are currently
> failing to build.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

[Message part 3 (message/rfc822, inline)]
From: luishgh <luishenriquegh2701 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: luishgh <51053603+luishgh <at> users.noreply.github.com>
Subject: [PATCH 1/2] gnu: emacs-racer: Update to 1e63e98.
Date: Mon, 16 May 2022 20:45:52 -0300
From: luishgh <51053603+luishgh <at> users.noreply.github.com>

* gnu/packages/emacs-xyz.scm (emacs-racer): Update to 1e63e98.
---
 gnu/packages/emacs-xyz.scm | 87 +++++++++++++++++++-------------------
 1 file changed, 44 insertions(+), 43 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8d66278b8f..590330ac4f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22487,52 +22487,53 @@ (define-public emacs-adoc-mode
     (license license:gpl2+)))
 
 (define-public emacs-racer
-  (package
-    (name "emacs-racer")
-    (version "1.2")
-    (source
-     (origin
-       (method git-fetch)
-       (uri
-        (git-reference
-         (url "https://github.com/racer-rust/emacs-racer")
-         (commit version)))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "0xj5iki10cg8j8vvqjlw6lfx97k3agwirhchcjnzbnkry48x9qi6"))))
-    (arguments
-     `(#:tests? #t
-       #:test-command '("make" "test")
-       #:phases
-       (modify-phases %standard-phases
-         (add-before 'check 'fix-makefile
-           (lambda _
-             (substitute* "Makefile"
-               (("\\$\\{CASK\\} exec ") ""))
-             #t))
-         ;; Two tests are failing with Emacs 27, as reported here:
-         ;; <https://github.com/racer-rust/emacs-racer/issues/136>.  Disable
-         ;; them.
-         (add-before 'check 'fix-failing-tests
-           (lambda _
-             (substitute* "test/racer-test.el"
-               (("`Write`") "Write")
-               (("^\\\\\\[`str\\]:.*") "")
-               ((" \\[`str`\\]") " str"))
-             #t)))))
-    (native-inputs
-     (list emacs-ert-runner emacs-undercover))
-    (propagated-inputs
-     (list emacs-dash emacs-f emacs-pos-tip emacs-rust-mode emacs-s))
-    (build-system emacs-build-system)
-    (home-page "https://github.com/racer-rust/emacs-racer")
-    (synopsis "Racer support for Emacs")
-    (description
-     "This is the official Emacs package for Racer.  It supports code
+  (let ((commit "1e63e98626737ea9b662d4a9b1ffd6842b1c648c")
+        (revision "0"))
+    (package
+      (name "emacs-racer")
+      (version (git-version "1.2" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/racer-rust/emacs-racer")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "12a429lajk09qp1jxgig54p8z6wndfgr4jwdmgkc9s2df9sw02d3"))))
+      (arguments
+       `(#:tests? #t
+         #:test-command '("ert-runner")
+         #:phases
+         (modify-phases %standard-phases
+           ;; Two tests are failing with Emacs 27, as reported here:
+           ;; <https://github.com/racer-rust/emacs-racer/issues/136>.  Disable
+           ;; them.
+           (add-before 'check 'fix-failing-tests
+             (lambda _
+               (substitute* "test/racer-test.el"
+                 (("`Write`") "Write")
+                 (("^\\\\\\[`str\\]:.*") "")
+                 ((" \\[`str`\\]") " str"))
+               #t))
+           ;; Added to replicate original behavior of "make test"
+           (add-after 'build 'test-after-build
+             (lambda _
+               (invoke "ert-runner"))))))
+      (native-inputs
+       (list emacs-ert-runner emacs-undercover))
+      (propagated-inputs
+       (list emacs-dash emacs-f emacs-pos-tip emacs-rust-mode emacs-s))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/racer-rust/emacs-racer")
+      (synopsis "Racer support for Emacs")
+      (description
+       "This is the official Emacs package for Racer.  It supports code
 completion of variables, functions and modules.  It can also jump to
 definition of functions and types, and show a help buffer based on the
 docstring of the thing at point.")
-    (license license:expat)))
+      (license license:expat))))
 
 (define-public emacs-rust-mode
   (package
-- 
2.36.0




This bug report was last modified 3 years and 62 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.