GNU bug report logs - #55463
[PATCH] Fix font options compilation with gsettings disabled

Previous Next

Full log

Message #8 received at 55463 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl>
Cc: wilde <at> sha-bang.de, 55463 <at> debbugs.gnu.org
Subject: Re: bug#55463: [PATCH] Fix font options compilation with gsettings
 disabled
Date: Tue, 17 May 2022 09:05:10 +0800

Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl> writes:

> Hello All,
>
> This is a small patch to make the recent gsettings font rendering
> changes compile when pgtk is configured but gsettings is not.

Thanks.

> -/* Return the cairo font options, updated from the gsettings font
> -   config entries.  The caller should call cairo_font_options_destroy
> -   on the result.  */
> +/* Return the cairo font options, optionally updated from the gsettings
> +   font config entries.  The caller should call
> +   cairo_font_options_destroy on the result.  */

I think this change is extraneous.  That comment doesn't have to be so
detailed, since building Emacs without GSettings support is a rather
oddball configuration, and it obviously cannot be used without support
being built-in.

Otherwise, LGTM.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.