GNU bug report logs - #55439
[PATCH] Add support for the Modi script

Previous Next

Full log

View this message in rfc822 format

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55439 <at> debbugs.gnu.org
Subject: bug#55439: [PATCH] Add support for the Modi script
Date: Tue, 17 May 2022 04:55:42 +0530

[Message part 1 (text/plain, inline)]

>
> Can you tell how many more old scripts you intend to add?  I'm
> thinking perhaps we should make a separate section for them in NEWS,
> instead of basically repeating the same text over and over and over
> again


I am planning to add about 31 more scripts.

I'm okay with the change, but please add the same sample-text to the
> Devanagari language environment in indian.el.
>

Done.

I have also:
    1. added sample texts to other scripts which didn't have them.
    2. replaced the spaces with a tab in the sample texts which I had added.
    3. renamed Punjabi to Gurmukhi in its set-language-info-alist.

In etc/HELLO
I have:
    1. added a Gurumukhi greeting.
    2. replaced the Odia greeting, it was ଶୁଣିବେ (tl. Listen) earlier,
which I don't think is a greeting, therefore I have replaced it with
ନମସ୍କାର (namaskaar)

The "Hindi" greeting had a character at its end, U+0964, which
> disappeared when you moved the line to Devanagari.  Is that
> intentional?
>

Yes, that was intentional, it was a full stop. I didn't think that it was
necessary, the other greetings also did not have it.

Period missing at the end of this line.
>

Oops. Fixed it.  The earlier news entry about Syloti Nagri did not have it
too, so I have also added it there.

On Mon, May 16, 2022 at 5:04 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh
> >  <lumarzeli30 <at> gmail.com>
> > Date: Mon, 16 May 2022 05:03:59 +0530
> >
> > I have added the modi script to Emacs this time.
>
> Thanks.
>
> Can you tell how many more old scripts you intend to add?  I'm
> thinking perhaps we should make a separate section for them in NEWS,
> instead of basically repeating the same text over and over and over
> again.
>
> > I have also renamed Hindi to Devanagari in etc/HELLO, since this
> > script is also used by languages other than Hindi, like: Marathi and
> > Nepali.
>
> I'm okay with the change, but please add the same sample-text to the
> Devanagari language environment in indian.el.
>
> > Please review the patch.
> > diff --git a/etc/HELLO b/etc/HELLO
> > index 16a38b59d3..04014e8dea 100644
> > --- a/etc/HELLO
> > +++ b/etc/HELLO
> > @@ -38,6 +38,7 @@ Comanche /kəˈmæntʃiː/       Haa marʉ́awe
> >  Cree (ᓀᐦᐃᔭᐍᐏᐣ)       ᑕᓂᓯ / ᐙᒋᔮ
> >  Czech (čeština)      Dobrý den
> >  Danish (dansk)       Hej / Goddag / Halløj
> > +Devanagari (देवनागरी)        नमस्ते / नमस्कार
> >  Dutch (Nederlands)   Hallo / Dag
> >  Efik  /ˈɛfɪk/        Mɔkɔm
> >  Egyptian Hieroglyphs (𓂋𓏤𓈖𓆎𓅓‌𓏏𓊖)       𓅓𓊵𓏏𓊪, 𓇍𓇋𓂻𓍘𓇋
> > @@ -55,7 +57,6 @@ Greek, ancient (ἑλληνική)   Οὖλέ τε καὶ μέγα χαῖρε
> >  Gujarati (ગુજરાતી)   નમસ્તે
> >  Hebrew (עִבְרִית)    שָׁלוֹם
> >  Hungarian (magyar)   Szép jó napot!
> > -Hindi (हिंदी)        नमस्ते / नमस्कार ।
>
> The "Hindi" greeting had a character at its end, U+0964, which
> disappeared when you moved the line to Devanagari.  Is that
> intentional?
>
> > +*** New language environment "Modi"
>
> Period missing at the end of this line.
>

[Message part 2 (text/html, inline)]

[0001-Add-support-for-the-Modi-script.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.