From unknown Sat Jun 21 10:45:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55433] [PATCH] gnu: emacs-ledger-mode: Update to 4.0.0-0.11e8503. Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 May 2022 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55433 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55433@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165264010225927 (code B ref -1); Sun, 15 May 2022 18:42:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 May 2022 18:41:42 +0000 Received: from localhost ([127.0.0.1]:50734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqJBW-0006k6-9d for submit@debbugs.gnu.org; Sun, 15 May 2022 14:41:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:55818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqJBF-0006jk-Sj for submit@debbugs.gnu.org; Sun, 15 May 2022 14:41:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqJBF-0005Fs-LZ for guix-patches@gnu.org; Sun, 15 May 2022 14:41:25 -0400 Received: from out0.migadu.com ([2001:41d0:2:267::]:31592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqJBB-0000ul-NW for guix-patches@gnu.org; Sun, 15 May 2022 14:41:25 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1652640078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+mcQbUa9ADlW8xMn9VsTPGszo4IA1LrcM57ldu+E8DM=; b=ZE0XNhwruaAz9ZC6CoPtZtOBJvbQk1KLKldogeU7ea9KZQfIjLOtYTfeCZQihp9zaqeog3 CnZK9FA8Jga4wYz0QFnstAYNTa1uOkyfsdD/Gzs3zzIyI+X1y7MpgHdujqaZOn8qFJgVbf cRDw5j9q+epOujOXBizj6h2tOBx9DHwcCRa/xikhRcl4/fkF//fGJEzJJmExm8HlTDav/H D6FByy1vD2/UxzoX33NaK7B6mqTtkliucSFZlYM47aRht2h7l/zZHiCWvwmutaCt/oly1h s+/mtppyDoYNeW3QDMAagFp+9Qgd8JyMzixvBlDYTuBim2tksSFScGkBN84eQg== From: Kyle Meyer Date: Sun, 15 May 2022 14:41:14 -0400 Message-Id: <20220515184114.146101-1-kyle@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: kyleam.com Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) With the Emacs 28 update, building emacs-ledger-mode fails with complete-test.el:29:1: Error: Wrong number of arguments: (3 . 4), 2 This error is not present the latest commit on upstream's master branch. * gnu/packages/finance.scm (emacs-ledger-mode): Update to 4.0.0-0.11e8503. --- gnu/packages/finance.scm | 96 +++++++++++++++++++++------------------- 1 file changed, 50 insertions(+), 46 deletions(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index b5ab051a1f..ed7202b17e 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -26,6 +26,7 @@ ;;; Copyright © 2021 François J ;;; Copyright © 2021 Foo Chuan Wei ;;; Copyright © 2021 John Kehayias +;;; Copyright © 2022 Kyle Meyer ;;; ;;; This file is part of GNU Guix. ;;; @@ -395,51 +396,54 @@ (define-public ledger "See src/wcwidth.cc in the distribution."))))) (define-public emacs-ledger-mode - (package - (name "emacs-ledger-mode") - (version "4.0.0") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/ledger/ledger-mode") - (commit (string-append "v" version)))) - (file-name (git-file-name name version)) - (sha256 - (base32 "1r5rcyxd6d1rqwamzpvqdbkbdf1zbj75aaciqijrklnm59ps244y")))) - (build-system emacs-build-system) - (arguments - `(;; ledger-test.el is needed at runtime (but probably not for a good reason). - #:exclude '() - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'patch-path - (lambda* (#:key inputs #:allow-other-keys) - (let ((ledger (assoc-ref inputs "ledger"))) - (make-file-writable "ledger-exec.el") - (emacs-substitute-variables "ledger-exec.el" - ("ledger-binary-path" (string-append ledger "/bin/ledger")))) - #t)) - (add-after 'build 'build-doc - (lambda* (#:key outputs #:allow-other-keys) - (let ((target (string-append (assoc-ref outputs "out") - "/share/info"))) - (mkdir-p target) - (invoke "makeinfo" "-o" target - "../source/doc/ledger-mode.texi")) - #t)) - (replace 'check - (lambda _ - (with-directory-excursion "../source/test" - (invoke "make" "test-batch"))))))) - (inputs - (list ledger)) - (native-inputs - (list texinfo)) - (home-page "https://ledger-cli.org/") - (synopsis "Command-line double-entry accounting program") - (description - "Ledger is a powerful, double-entry accounting system that is + ;; The last release was on Nov 8, 2019 and doesn't build with Emacs 28. + (let ((commit "11e850395448ee7012dba16bd6df103f5552ebfb") + (revision "0")) + (package + (name "emacs-ledger-mode") + (version (git-version "4.0.0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/ledger/ledger-mode") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0hzky36vrlb7kvpyz4gy3zn01zdlmlx0s58w6ggk5djbcvjc2rfx")))) + (build-system emacs-build-system) + (arguments + `(;; ledger-test.el is needed at runtime (but probably not for a good reason). + #:exclude '() + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-path + (lambda* (#:key inputs #:allow-other-keys) + (let ((ledger (assoc-ref inputs "ledger"))) + (make-file-writable "ledger-exec.el") + (emacs-substitute-variables "ledger-exec.el" + ("ledger-binary-path" (string-append ledger "/bin/ledger")))) + #t)) + (add-after 'build 'build-doc + (lambda* (#:key outputs #:allow-other-keys) + (let ((target (string-append (assoc-ref outputs "out") + "/share/info"))) + (mkdir-p target) + (invoke "makeinfo" "-o" target + "../source/doc/ledger-mode.texi")) + #t)) + (replace 'check + (lambda _ + (with-directory-excursion "../source/test" + (invoke "make" "test-batch"))))))) + (inputs + (list ledger)) + (native-inputs + (list texinfo)) + (home-page "https://ledger-cli.org/") + (synopsis "Command-line double-entry accounting program") + (description + "Ledger is a powerful, double-entry accounting system that is accessed from the UNIX command-line. This may put off some users, since there is no flashy UI, but for those who want unparalleled reporting access to their data there are few alternatives. @@ -453,7 +457,7 @@ (define-public emacs-ledger-mode in ability, and easy to use. This package provides the Emacs mode.") - (license license:gpl2+))) + (license license:gpl2+)))) (define-public geierlein (package base-commit: ebb43029506d994bee0c2b890881fd61a0b0c202 -- 2.36.0 From unknown Sat Jun 21 10:45:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55433] [PATCH] gnu: emacs-ledger-mode: Update to 4.0.0-0-11e85039. References: <20220515184114.146101-1-kyle@kyleam.com> In-Reply-To: <20220515184114.146101-1-kyle@kyleam.com> Resent-From: Aleksandr Vityazev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 May 2022 11:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55433 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55433@debbugs.gnu.org Received: via spool by 55433-submit@debbugs.gnu.org id=B55433.165269907629053 (code B ref 55433); Mon, 16 May 2022 11:05:01 +0000 Received: (at 55433) by debbugs.gnu.org; 16 May 2022 11:04:36 +0000 Received: from localhost ([127.0.0.1]:51859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqYWd-0007YL-9O for submit@debbugs.gnu.org; Mon, 16 May 2022 07:04:35 -0400 Received: from mout01.posteo.de ([185.67.36.65]:57093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqYWa-0007Y1-N2 for 55433@debbugs.gnu.org; Mon, 16 May 2022 07:04:29 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8708324002D for <55433@debbugs.gnu.org>; Mon, 16 May 2022 13:04:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.org; s=2017; t=1652699062; bh=MQlQIlu8huWTkJzbuP88t7K1fokrSWTYGUN40KY9p04=; h=From:To:Subject:Date:From; b=nlCxqgPQZtJ4OYjjjFeBgsf7qQ+03cQ7w3//o72K2Jj5XJAqtKywVSR8cJ5KX1bjT aSqyoSYejJUCVrsNB2SJI9acVlDNQe5U8wzZ4qeKa0HupKCmsbIIJhtFLi376AqLY8 WOBecV+t4e4T/QMllo+jyoHrkIMSPxhwgAcQhFznyR+9HHrdNXKBXnCBG2CaCkdDA+ C8w6eDMY5fTc45QzbuwbDvEB8Hq82Ed6DA2dDMtNBuajZB2LLlzxinifZm1mr40ti0 YAZiTMoPncjzD21C9toivT0z3TCnkJtpmwMnMgfmplYicK5mtfxc70zHyyelFfwefm Xm46FMOhT+ghA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4L1xGF4Kj7z9rxR for <55433@debbugs.gnu.org>; Mon, 16 May 2022 13:04:21 +0200 (CEST) From: Aleksandr Vityazev Message-Id: Date: Mon, 16 May 2022 11:04:14 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, I just went ahead and made changes to the arguments. * gnu/packages/finance.scm (emacs-ledger-mode): Update to 4.0.0-0-11e85039. [arguments]: Convert to list of G-Expressions. Use =E2=80=98search-input-fi= le=E2=80=99 where possible. Drop trailing =E2=80=98#t=E2=80=99s. While here, respect TESTS? in check p= hase. Co-authored-by: Aleksandr Vityazev --- gnu/packages/finance.scm | 96 +++++++++++++++++++++------------------- 1 file changed, 50 insertions(+), 46 deletions(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index b5ab051a1f..09b979899d 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -26,6 +26,8 @@ ;;; Copyright =C2=A9 2021 Fran=C3=A7ois J ;;; Copyright =C2=A9 2021 Foo Chuan Wei ;;; Copyright =C2=A9 2021 John Kehayias +;;; Copyright =C2=A9 2022 Kyle Meyer +;;; Copyright =C2=A9 2022 Aleksandr Vityazev ;;; ;;; This file is part of GNU Guix. ;;; @@ -395,51 +397,53 @@ (define-public ledger "See src/wcwidth.cc in the distribution."))))) =20 (define-public emacs-ledger-mode - (package - (name "emacs-ledger-mode") - (version "4.0.0") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/ledger/ledger-mode") - (commit (string-append "v" version)))) - (file-name (git-file-name name version)) - (sha256 - (base32 "1r5rcyxd6d1rqwamzpvqdbkbdf1zbj75aaciqijrklnm59ps244y")))) - (build-system emacs-build-system) - (arguments - `(;; ledger-test.el is needed at runtime (but probably not for a good= reason). - #:exclude '() - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'patch-path - (lambda* (#:key inputs #:allow-other-keys) - (let ((ledger (assoc-ref inputs "ledger"))) - (make-file-writable "ledger-exec.el") - (emacs-substitute-variables "ledger-exec.el" - ("ledger-binary-path" (string-append ledger "/bin/ledger"= )))) - #t)) - (add-after 'build 'build-doc - (lambda* (#:key outputs #:allow-other-keys) - (let ((target (string-append (assoc-ref outputs "out") - "/share/info"))) - (mkdir-p target) - (invoke "makeinfo" "-o" target - "../source/doc/ledger-mode.texi")) - #t)) - (replace 'check - (lambda _ - (with-directory-excursion "../source/test" - (invoke "make" "test-batch"))))))) - (inputs - (list ledger)) - (native-inputs - (list texinfo)) - (home-page "https://ledger-cli.org/") - (synopsis "Command-line double-entry accounting program") - (description - "Ledger is a powerful, double-entry accounting system that is + ;; The last release was on Nov 8, 2019 and doesn't build with Emacs 28. + (let ((commit "11e850395448ee7012dba16bd6df103f5552ebfb") + (revision "0")) + (package + (name "emacs-ledger-mode") + (version (git-version "4.0.0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/ledger/ledger-mode") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0hzky36vrlb7kvpyz4gy3zn01zdlmlx0s58w6ggk5djbcvjc2rfx"))= )) + (build-system emacs-build-system) + (arguments + (list + ;; ledger-test.el is needed at runtime (but probably not for a goo= d reason). + #:exclude #~'() + #:tests? #t + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'patch-path + (lambda* (#:key inputs #:allow-other-keys) + (make-file-writable "ledger-exec.el") + (emacs-substitute-variables "ledger-exec.el" + ("ledger-binary-path" (search-input-file inputs "/bin/le= dger"))))) + (add-after 'build 'build-doc + (lambda _ + (let ((target (string-append #$output "/share/info"))) + (mkdir-p target) + (invoke "makeinfo" "-o" target + "../source/doc/ledger-mode.texi")))) + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (with-directory-excursion "../source/test" + (invoke "make" "test-batch")))))))) + (inputs + (list ledger)) + (native-inputs + (list texinfo)) + (home-page "https://ledger-cli.org/") + (synopsis "Command-line double-entry accounting program") + (description + "Ledger is a powerful, double-entry accounting system that is accessed from the UNIX command-line. This may put off some users, since there is no flashy UI, but for those who want unparalleled reporting access to their data there are few alternatives. @@ -453,7 +457,7 @@ (define-public emacs-ledger-mode in ability, and easy to use. =20 This package provides the Emacs mode.") - (license license:gpl2+))) + (license license:gpl2+)))) =20 (define-public geierlein (package --=20 2.36.0 --=20 Best regards,=20 Aleksandr Vityazev From unknown Sat Jun 21 10:45:06 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kyle Meyer Subject: bug#55433: closed (Re: bug#55433: [PATCH] gnu: emacs-ledger-mode: Update to 4.0.0-0.11e8503.) Message-ID: References: <87wnej1n3z.fsf_-_@gmail.com> <20220515184114.146101-1-kyle@kyleam.com> X-Gnu-PR-Message: they-closed 55433 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 55433@debbugs.gnu.org Date: Wed, 18 May 2022 04:28:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1652848082-15728-1" This is a multi-part message in MIME format... ------------=_1652848082-15728-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55433: [PATCH] gnu: emacs-ledger-mode: Update to 4.0.0-0.11e8503. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55433@debbugs.gnu.org. --=20 55433: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55433 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1652848082-15728-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55433-done) by debbugs.gnu.org; 18 May 2022 04:27:52 +0000 Received: from localhost ([127.0.0.1]:58560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrBHs-00045L-GU for submit@debbugs.gnu.org; Wed, 18 May 2022 00:27:52 -0400 Received: from mail-qk1-f174.google.com ([209.85.222.174]:37723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrBHr-000457-7X for 55433-done@debbugs.gnu.org; Wed, 18 May 2022 00:27:51 -0400 Received: by mail-qk1-f174.google.com with SMTP id 126so692416qkm.4 for <55433-done@debbugs.gnu.org>; Tue, 17 May 2022 21:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=ufFaTx5c3PXOvcXDzg9BxlCowoemBMAVpZIPAlnFP7c=; b=BgWv6jaLjQ8sS7PZteBxxdYYhL4OXBGb8+HD5zK8PxG5L97EQ3GAe8BT+Rk0SMPYdP ZaaXWeU1T17sn4d50U8acc1FAxrHmjA4yjiyci+8p+pn2pkggu0rqdUSsre0DOpkY6n1 OI1KgYuUxZPzAOeNJCxnl0H+wy5nRuRVilMkbQ3Z2mxSdjizKR+3Qw+oIcFx3o9AJpe0 Xs/+fpRY0vN+RX0HPlaQVfbYtI7ApgFILM2yE8it22yLaCj1EnUY+wt7bhHpGsA+B1rU 7etQThjAIUKWbp+/iyTjvALnfU8iD0R4NIjGkO2d2nQj+4N/JhUmAxXn5rks2kumX+wu FMYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=ufFaTx5c3PXOvcXDzg9BxlCowoemBMAVpZIPAlnFP7c=; b=3qDxMMNbmgfLrsiCwcMdXHxdbhOMxwxtDWrvRbJoRwHl4dqAiN7QzrOiu3rE1upTpG dgvIbmhtMGbOcEjtQWZQk/cALowNtZDcXZxbaBT3moOwuVKbVZuxU4boL5hVw2kvb7iW BFHFgXD7Qfh2v8ymzIamCDyglg6HboDRGIAvp+26zGHyV3OiXf22eDY528RyTXKPWie/ O5k9SeKSFCfi+jVsPcBFkqnpMgtthJnete2TKWP/9dSUouhj5hN9m1J/nUhxpf6va42G T4IJ9N9brqWjbQcwLbeQ8VANOiV0CyyMFtsHtOQjPi7FIntcVGaYcyb0tJKUfci4rtrY 303A== X-Gm-Message-State: AOAM533FKsUs9vhLqgMY5Tl43eqMQdsErGjZpG5zmInPQFtDTv7rQN26 ynSLlPIgCh4x31Lo0eLKzC4vkTjF2/eucw== X-Google-Smtp-Source: ABdhPJxGWqCrvVLLB3W5XySnoxrSlR8TbuMHhidlLZGSXceBA26A7TrO8HX6LIj4ZTXT4YJgWzIZiQ== X-Received: by 2002:a05:620a:4086:b0:6a0:23d8:d496 with SMTP id f6-20020a05620a408600b006a023d8d496mr18062322qko.389.1652848065599; Tue, 17 May 2022 21:27:45 -0700 (PDT) Received: from hurd (dsl-205-233-124-104.b2b2c.ca. [205.233.124.104]) by smtp.gmail.com with ESMTPSA id p5-20020a37bf05000000b0069fc13ce228sm781984qkf.89.2022.05.17.21.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 21:27:45 -0700 (PDT) From: Maxim Cournoyer To: Aleksandr Vityazev Subject: Re: bug#55433: [PATCH] gnu: emacs-ledger-mode: Update to 4.0.0-0.11e8503. References: <20220515184114.146101-1-kyle@kyleam.com> Date: Wed, 18 May 2022 00:27:44 -0400 In-Reply-To: (Aleksandr Vityazev's message of "Mon, 16 May 2022 11:04:14 +0000") Message-ID: <87wnej1n3z.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55433-done Cc: 55433-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Aleksandr Vityazev writes: > Hi, I just went ahead and made changes to the arguments. > > * gnu/packages/finance.scm (emacs-ledger-mode): Update to 4.0.0-0-11e8503= 9. > [arguments]: Convert to list of G-Expressions. Use =E2=80=98search-input-= file=E2=80=99 where possible. > Drop trailing =E2=80=98#t=E2=80=99s. While here, respect TESTS? in check= phase. > > Co-authored-by: Aleksandr Vityazev > --- > gnu/packages/finance.scm | 96 +++++++++++++++++++++------------------- > 1 file changed, 50 insertions(+), 46 deletions(-) > > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm > index b5ab051a1f..09b979899d 100644 > --- a/gnu/packages/finance.scm > +++ b/gnu/packages/finance.scm > @@ -26,6 +26,8 @@ > ;;; Copyright =C2=A9 2021 Fran=C3=A7ois J > ;;; Copyright =C2=A9 2021 Foo Chuan Wei > ;;; Copyright =C2=A9 2021 John Kehayias > +;;; Copyright =C2=A9 2022 Kyle Meyer > +;;; Copyright =C2=A9 2022 Aleksandr Vityazev Nice collaboration here :-) Applied as 5a2b9fc2e6fe868e838ae3865e4a2d2c22cda91d. Thanks, Maxim ------------=_1652848082-15728-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 May 2022 18:41:42 +0000 Received: from localhost ([127.0.0.1]:50734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqJBW-0006k6-9d for submit@debbugs.gnu.org; Sun, 15 May 2022 14:41:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:55818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqJBF-0006jk-Sj for submit@debbugs.gnu.org; Sun, 15 May 2022 14:41:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqJBF-0005Fs-LZ for guix-patches@gnu.org; Sun, 15 May 2022 14:41:25 -0400 Received: from out0.migadu.com ([2001:41d0:2:267::]:31592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqJBB-0000ul-NW for guix-patches@gnu.org; Sun, 15 May 2022 14:41:25 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1652640078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+mcQbUa9ADlW8xMn9VsTPGszo4IA1LrcM57ldu+E8DM=; b=ZE0XNhwruaAz9ZC6CoPtZtOBJvbQk1KLKldogeU7ea9KZQfIjLOtYTfeCZQihp9zaqeog3 CnZK9FA8Jga4wYz0QFnstAYNTa1uOkyfsdD/Gzs3zzIyI+X1y7MpgHdujqaZOn8qFJgVbf cRDw5j9q+epOujOXBizj6h2tOBx9DHwcCRa/xikhRcl4/fkF//fGJEzJJmExm8HlTDav/H D6FByy1vD2/UxzoX33NaK7B6mqTtkliucSFZlYM47aRht2h7l/zZHiCWvwmutaCt/oly1h s+/mtppyDoYNeW3QDMAagFp+9Qgd8JyMzixvBlDYTuBim2tksSFScGkBN84eQg== From: Kyle Meyer To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs-ledger-mode: Update to 4.0.0-0.11e8503. Date: Sun, 15 May 2022 14:41:14 -0400 Message-Id: <20220515184114.146101-1-kyle@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: kyleam.com Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) With the Emacs 28 update, building emacs-ledger-mode fails with complete-test.el:29:1: Error: Wrong number of arguments: (3 . 4), 2 This error is not present the latest commit on upstream's master branch. * gnu/packages/finance.scm (emacs-ledger-mode): Update to 4.0.0-0.11e8503. --- gnu/packages/finance.scm | 96 +++++++++++++++++++++------------------- 1 file changed, 50 insertions(+), 46 deletions(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index b5ab051a1f..ed7202b17e 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -26,6 +26,7 @@ ;;; Copyright © 2021 François J ;;; Copyright © 2021 Foo Chuan Wei ;;; Copyright © 2021 John Kehayias +;;; Copyright © 2022 Kyle Meyer ;;; ;;; This file is part of GNU Guix. ;;; @@ -395,51 +396,54 @@ (define-public ledger "See src/wcwidth.cc in the distribution."))))) (define-public emacs-ledger-mode - (package - (name "emacs-ledger-mode") - (version "4.0.0") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/ledger/ledger-mode") - (commit (string-append "v" version)))) - (file-name (git-file-name name version)) - (sha256 - (base32 "1r5rcyxd6d1rqwamzpvqdbkbdf1zbj75aaciqijrklnm59ps244y")))) - (build-system emacs-build-system) - (arguments - `(;; ledger-test.el is needed at runtime (but probably not for a good reason). - #:exclude '() - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'patch-path - (lambda* (#:key inputs #:allow-other-keys) - (let ((ledger (assoc-ref inputs "ledger"))) - (make-file-writable "ledger-exec.el") - (emacs-substitute-variables "ledger-exec.el" - ("ledger-binary-path" (string-append ledger "/bin/ledger")))) - #t)) - (add-after 'build 'build-doc - (lambda* (#:key outputs #:allow-other-keys) - (let ((target (string-append (assoc-ref outputs "out") - "/share/info"))) - (mkdir-p target) - (invoke "makeinfo" "-o" target - "../source/doc/ledger-mode.texi")) - #t)) - (replace 'check - (lambda _ - (with-directory-excursion "../source/test" - (invoke "make" "test-batch"))))))) - (inputs - (list ledger)) - (native-inputs - (list texinfo)) - (home-page "https://ledger-cli.org/") - (synopsis "Command-line double-entry accounting program") - (description - "Ledger is a powerful, double-entry accounting system that is + ;; The last release was on Nov 8, 2019 and doesn't build with Emacs 28. + (let ((commit "11e850395448ee7012dba16bd6df103f5552ebfb") + (revision "0")) + (package + (name "emacs-ledger-mode") + (version (git-version "4.0.0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/ledger/ledger-mode") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0hzky36vrlb7kvpyz4gy3zn01zdlmlx0s58w6ggk5djbcvjc2rfx")))) + (build-system emacs-build-system) + (arguments + `(;; ledger-test.el is needed at runtime (but probably not for a good reason). + #:exclude '() + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-path + (lambda* (#:key inputs #:allow-other-keys) + (let ((ledger (assoc-ref inputs "ledger"))) + (make-file-writable "ledger-exec.el") + (emacs-substitute-variables "ledger-exec.el" + ("ledger-binary-path" (string-append ledger "/bin/ledger")))) + #t)) + (add-after 'build 'build-doc + (lambda* (#:key outputs #:allow-other-keys) + (let ((target (string-append (assoc-ref outputs "out") + "/share/info"))) + (mkdir-p target) + (invoke "makeinfo" "-o" target + "../source/doc/ledger-mode.texi")) + #t)) + (replace 'check + (lambda _ + (with-directory-excursion "../source/test" + (invoke "make" "test-batch"))))))) + (inputs + (list ledger)) + (native-inputs + (list texinfo)) + (home-page "https://ledger-cli.org/") + (synopsis "Command-line double-entry accounting program") + (description + "Ledger is a powerful, double-entry accounting system that is accessed from the UNIX command-line. This may put off some users, since there is no flashy UI, but for those who want unparalleled reporting access to their data there are few alternatives. @@ -453,7 +457,7 @@ (define-public emacs-ledger-mode in ability, and easy to use. This package provides the Emacs mode.") - (license license:gpl2+))) + (license license:gpl2+)))) (define-public geierlein (package base-commit: ebb43029506d994bee0c2b890881fd61a0b0c202 -- 2.36.0 ------------=_1652848082-15728-1-- From unknown Sat Jun 21 10:45:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#55433] [PATCH] gnu: emacs-ledger-mode: Update to 4.0.0-0.11e8503. Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 May 2022 22:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55433 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , Aleksandr Vityazev Cc: 55433@debbugs.gnu.org Received: via spool by 55433-submit@debbugs.gnu.org id=B55433.165291236625050 (code B ref 55433); Wed, 18 May 2022 22:20:01 +0000 Received: (at 55433) by debbugs.gnu.org; 18 May 2022 22:19:26 +0000 Received: from localhost ([127.0.0.1]:33852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrS0r-0006Vy-OA for submit@debbugs.gnu.org; Wed, 18 May 2022 18:19:25 -0400 Received: from out2.migadu.com ([188.165.223.204]:52530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrS0q-0006Vo-0h for 55433@debbugs.gnu.org; Wed, 18 May 2022 18:19:25 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1652912362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6yenWo3vc6bmOQx0lhqXYVeA+fYE2rqzVMq2BTPSPoY=; b=j18z7cSjps6nI2QEuUqbL9+dwZj4UEBK2bF0P2sYeHgXa+jORkdlu7exxbAXNYzzGU2lRO xStNVUPK+18sJrNXtWZ2vuH6krXf13Kfau7LaQNniDir/+BknJxM//M94dt3tnxnzG+V3S fZxBbnCmhOW6H9Q2d5LeXp/oxgFaYxX1ClhF608WQB74QCjT7IvQ5TGgAlHeh0Dwwk8+IM yK+s2rjcZElfMXrqu5MwqUwZu61zdnqn2jbSV6iVZV7bjYkpiFwvsiHMCVfJUI+L+JLquZ SCaK33LLJSLuZKYk10ObDhck4E5U+fMSvyXSfSgrnLF88rT658eg+amyewEmsw== From: Kyle Meyer In-Reply-To: <87wnej1n3z.fsf_-_@gmail.com> References: <20220515184114.146101-1-kyle@kyleam.com> <87wnej1n3z.fsf_-_@gmail.com> Date: Wed, 18 May 2022 18:19:18 -0400 Message-ID: <87pmka7ac9.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: kyleam.com X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 05/18/22 00:27:44 -0400, Maxim Cournoyer wrote: > Hello, > > Aleksandr Vityazev writes: > >> Hi, I just went ahead and made changes to the arguments. > [...] > Nice collaboration here :-) > > Applied as 5a2b9fc2e6fe868e838ae3865e4a2d2c22cda91d. Great, thanks for the improvements, Aleksandr. (And thanks for reviewing, Maxim.)