GNU bug report logs - #55426
[PATCH] Add option to kill a shell buffer when the process ends

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#55426: closed ([PATCH] Add option to kill a shell buffer when
 the process ends)
Date: Fri, 20 May 2022 08:24:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 20 May 2022 08:23:51 +0000
with message-id <87mtfc1ujs.fsf <at> posteo.net>
and subject line Re: bug#55426: [PATCH] Add option to kill a shell buffer when the process ends
has caused the debbugs.gnu.org bug report #55426,
regarding [PATCH] Add option to kill a shell buffer when the process ends
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
55426: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55426
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add option to kill a shell buffer when the process ends
Date: Sun, 15 May 2022 08:13:49 +0000

[Message part 3 (text/plain, inline)]

Tags: patch


The below patch adds an option that has a *shell* buffer automatically
killed when a shell process terminates.  I find this useful, because it
helps to avoid re-activating old shell buffers in the wrong
`default-directory'.  Eshell has a "similar" behaviour (setting aside
that it doesn't have an inferior process), but term doesn't.  If this
patch is merged, perhaps something similar for term could be done too?`

In GNU Emacs 29.0.50 (build 12, x86_64-pc-linux-gnu, GTK+ Version 2.24.33, cairo version 1.16.0)
 of 2022-05-11 built on icterid
Repository revision: 474241f356c638bfd8d4eecb7138e3af76a8c036
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-tree-sitter'

[0001-Add-option-to-kill-a-shell-buffer-when-the-process-e.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55426-done <at> debbugs.gnu.org
Subject: Re: bug#55426: [PATCH] Add option to kill a shell buffer when the
 process ends
Date: Fri, 20 May 2022 08:23:51 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Cc: 55426 <at> debbugs.gnu.org
>> Date: Sun, 15 May 2022 11:51:53 +0000
>> 
>> +*** New user option 'shell-kill-buffer-on-exit'
>
> This should end with a period, to be a full sentence.
>
> Otherwise, LGTM, thanks.

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Cc: 55426 <at> debbugs.gnu.org
>> Date: Wed, 18 May 2022 23:13:05 +0000
>> 
>> 
>> So is the patch fine?  May I push it?
>
> Sorry for the delay.  I've posted a response just now with a small
> correction; feel free to install after fixing that nit.

Done.

> Thanks.

Thank you for your help.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.