Subject: bug#55418: closed (Re: [PATCH] gnu: emacs-dash: Fix build with emacs28.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 14 May 2022 23:39:01 +0000

Your bug report

#55418: [PATCH] gnu: emacs-dash: Fix build with emacs28.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
55418: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55418
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [PATCH] gnu: emacs-dash: Fix build with emacs28.
From: Liliana Marie Prikler <[email-masked]>
To: Michael Rohleder <[email-masked]>, [email-masked]
Date: Sun, 15 May 2022 01:38:01 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Am Samstag, dem 14.05.2022 um 23:39 +0200 schrieb Michael Rohleder:
> * gnu/packages/emacs-xyz.scm (emacs-dash)[phase]:
> Add phase 'disable-byte-compile-error-on-warn.
> ---
Applied with a small fix in the commit message.

Thanks

Subject: [PATCH] gnu: emacs-dash: Fix build with emacs28.
From: Michael Rohleder <[email-masked]>
To: [email-masked]
Cc: Michael Rohleder <[email-masked]>
Date: Sat, 14 May 2022 23:39:57 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/emacs-xyz.scm (emacs-dash)[phase]:
Add phase 'disable-byte-compile-error-on-warn.
---
 gnu/packages/emacs-xyz.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c18505a681..928ca1c120 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3677,7 +3677,14 @@ (define-public emacs-dash
                (base32
                 "0z6f8y1m9amhg427iz1d4xcyr6n0kj5w7kmiz134p320ixsdnzd8"))))
     (build-system emacs-build-system)
-    (arguments `(#:tests? #t))
+    (arguments `(#:tests? #t
+                 #:phases
+                 (modify-phases %standard-phases
+                   (add-after 'unpack 'disable-byte-compile-error-on-warn
+                     (lambda _
+                       (substitute* "Makefile"
+                         (("\\(setq byte-compile-error-on-warn t\\)")
+                          "(setq byte-compile-error-on-warn nil)")))))))
     (home-page "https://github.com/magnars/dash.el")
     (synopsis "Modern list library for Emacs")
     (description "This package provides a modern list API library for Emacs.")
-- 
2.36.0