From debbugs-submit-bounces@debbugs.gnu.org Sat May 14 11:45:43 2022 Received: (at submit) by debbugs.gnu.org; 14 May 2022 15:45:43 +0000 Received: from localhost ([127.0.0.1]:47316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nptxe-0003QO-OL for submit@debbugs.gnu.org; Sat, 14 May 2022 11:45:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:54174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nptxc-0003OO-WB for submit@debbugs.gnu.org; Sat, 14 May 2022 11:45:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nptxT-0004lh-AG for bug-gnu-emacs@gnu.org; Sat, 14 May 2022 11:45:40 -0400 Received: from mx0.gg32.com ([168.119.248.232]:29464) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nptxQ-0008SK-Q2 for bug-gnu-emacs@gnu.org; Sat, 14 May 2022 11:45:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=20220427; bh=x62G9wqnc3x HXc0uyaxR6RW/GfdFBhfOEAi3ZipdQlw=; h=from:to:subject:date:reply-to; d=gg32.com; b=ksPA/OEpjVDw4ULAsbhyyzv3sP+SkpsAoJRgYu5NbjVHqUEXgtqSKSqT /7AbkekhXuUFkmdbjdEoEaGjDxAKyOCeH3DLy7qU/ZkjDxsAYcJxdaNSfYanVtYLocnqui 7mVKFdgQ6ic5FLMPmm9YQi7OdmxOBALJgqLAkuaIpJVHs= Received: by mx0.gg32.com (OpenSMTPD) with ESMTPSA id b3305085 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sat, 14 May 2022 16:45:12 +0100 (WEST) Content-Type: text/plain; charset="utf-8" Date: Sat, 14 May 2022 15:45:10 -0000 Mime-Version: 1.0 Content-transfer-encoding: 8bit Subject: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly To: bug-gnu-emacs@gnu.org From: Christian Tanzer Message-Id: Received-SPF: pass client-ip=168.119.248.232; envelope-from=tanzer@swing.co.at; helo=mx0.gg32.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: tanzer@swing.co.at Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) ============================================================================= ;;; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work like it ;;; used to in Emacs 27 and earlier. In fact, it is completely broken, if one ;;; uses a frame-parameter in ':eval'. ;;; ;;; The following elisp snippet demonstrates the problem in an Emacs 28.1 ;;; instance started with 'emacs -Q' (defun title-suffix () (cdr (assoc 'title-suffix (frame-parameters (selected-frame))))) (defvar title-prefix "Test") (setq frame-title-format (list title-prefix '(:eval (title-suffix)) " %b")) ;;; The original frame should show a frame title of 'Test *scratch*' (set-frame-parameter (selected-frame) 'title-suffix "") ;;; The next frame created should show a frame title of 'Test-xxx *scratch*' (make-frame-command) (set-frame-parameter (selected-frame) 'title-suffix "-xxx") ;;; The third frame created should show a frame title of 'Test-yyy *scratch*' (make-frame-command) (set-frame-parameter (selected-frame) 'title-suffix "-yyy") ;;; In Emacs 27 and earlier, that is exactly what happens. Selecting a ;;; different frame doesn't change the titles of all other frames. ;;; In Emacs 28.1, all frames show the same frame title, with the last one ;;; selected determining which one is shown for the bunch of them. Changing to ;;; a different frame changes the titles of all frames to the title of the ;;; newly selected one. ========================================================================== In GNU Emacs 28.1 (build 1, aarch64-apple-darwin21.1.0, NS appkit-2113.00 Version 12.0.1 (Build 21A559)) of 2022-04-04 built on armbob.lan Windowing system distributor 'Apple', version 10.3.2113 System Description: macOS 12.3.1 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: ACL GMP GNUTLS JSON LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER THREADS TOOLKIT_SCROLL_BARS ZLIB Important settings: value of $EMACSLOADPATH: /Users/tanzer/.emacs.lib::/Applications/Emacs.app/Contents/Resources/site-lisp: value of $LC_CTYPE: UTF-8 value of $LC_MESSAGES: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: /Users/tanzer/.emacs.lib/custom hides /Applications/Emacs-28.1.app/Contents/Resources/lisp/custom /Users/tanzer/.emacs.lib/iso-transl hides /Applications/Emacs-28.1.app/Contents/Resources/lisp/international/iso-transl Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 51129 6052) (symbols 48 6554 1) (strings 32 18387 2569) (string-bytes 1 613674) (vectors 16 14168) (vector-slots 8 205987 11758) (floats 8 33 51) (intervals 56 234 0) (buffers 992 10)) From debbugs-submit-bounces@debbugs.gnu.org Sat May 14 12:58:42 2022 Received: (at 55412) by debbugs.gnu.org; 14 May 2022 16:58:43 +0000 Received: from localhost ([127.0.0.1]:47436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npv6I-00077M-I0 for submit@debbugs.gnu.org; Sat, 14 May 2022 12:58:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npv6G-000778-Jg for 55412@debbugs.gnu.org; Sat, 14 May 2022 12:58:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57226) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npv62-0003gO-Mm; Sat, 14 May 2022 12:58:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pJMaGHDKuI3PIG0JntY1zS6kKCnWp6XFyeEpCrRE6o8=; b=Rm1G3OyMN2nh uIBTCvRyDBUJb19aMPzSYTBqc259GkM7I0nptWt3uiet3/xB6DWehE2znAHZTkl6X4lpXblynisD1 E9ZYgL8fMF2YO35a+vuJuw8DZP4QS2zi2h+2qisZsP/ePlWX57e456AGZw2I+yhe3Hq26eU57RlUJ Hah3yhti/chk/Q3yDF4Mt+W0nphefvN4MXcWJ9h/hNMMZ3gt9ZTVHfQ5uoC94DCEgSa2h6fsrWUqT TQ9Jdxn7tZnWQzyQ3/PrK/Xx1kpb0S5sH06ScAoVfGOQekNQTCpCTJ7cfGFqPfubCkstL1UU4SOdP fDyDb/7TQWyVgfJNct+/dg==; Received: from [87.69.77.57] (port=4826 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npv61-0004Y4-Qw; Sat, 14 May 2022 12:58:26 -0400 Date: Sat, 14 May 2022 19:58:13 +0300 Message-Id: <838rr4kq56.fsf@gnu.org> From: Eli Zaretskii To: tanzer@swing.co.at, Alan Mackenzie In-Reply-To: (message from Christian Tanzer on Sat, 14 May 2022 15:45:10 -0000) Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 14 May 2022 15:45:10 -0000 > From: Christian Tanzer > > ;;; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work like it > ;;; used to in Emacs 27 and earlier. In fact, it is completely broken, if one > ;;; uses a frame-parameter in ':eval'. > ;;; > ;;; The following elisp snippet demonstrates the problem in an Emacs 28.1 > ;;; instance started with 'emacs -Q' > > (defun title-suffix () > (cdr (assoc 'title-suffix (frame-parameters (selected-frame))))) > > (defvar title-prefix "Test") > (setq frame-title-format (list title-prefix '(:eval (title-suffix)) " %b")) > > ;;; The original frame should show a frame title of 'Test *scratch*' > (set-frame-parameter (selected-frame) 'title-suffix "") > > ;;; The next frame created should show a frame title of 'Test-xxx *scratch*' > (make-frame-command) > (set-frame-parameter (selected-frame) 'title-suffix "-xxx") > > ;;; The third frame created should show a frame title of 'Test-yyy *scratch*' > (make-frame-command) > (set-frame-parameter (selected-frame) 'title-suffix "-yyy") > > ;;; In Emacs 27 and earlier, that is exactly what happens. Selecting a > ;;; different frame doesn't change the titles of all other frames. > > ;;; In Emacs 28.1, all frames show the same frame title, with the last one > ;;; selected determining which one is shown for the bunch of them. Changing to > ;;; a different frame changes the titles of all frames to the title of the > ;;; newly selected one. Thank you for your report. Alan, this is due to one of the changes introduced for the minibuffer-follows-selected-frame feature. Specifically, commit 7c2ebf6 made a change in gui_consider_frame_title which causes this regression. If I revert a part of that commit shown below: diff --git a/src/xdisp.c b/src/xdisp.c index 6963935..9740e6b 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -12796,8 +12796,9 @@ gui_consider_frame_title (Lisp_Object frame) mode_line_noprop_buf; then display the title. */ record_unwind_protect (unwind_format_mode_line, format_mode_line_unwind_data - (NULL, current_buffer, Qnil, false)); + (f, current_buffer, selected_window, false)); + Fselect_window (f->selected_window, Qt); set_buffer_internal_1 (XBUFFER (XWINDOW (f->selected_window)->contents)); fmt = FRAME_ICONIFIED_P (f) ? Vicon_title_format : Vframe_title_format; then the problem goes away. The log message of that commit says about this part: * src/xdisp.c (gui_consider_frame_title): Remove redundant Fselect_window, which caused an unwanted frame switch. Amend the arguments to format_mode_line_unwind_data to match. As you see, the call to select-window is not redundant, because without it the frame's title cannot reference the frame-parameters of that frame. Do you remember why the frame switch here was "unwanted"? What bad things happen if we restore the removed code? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat May 14 13:08:08 2022 Received: (at 55412) by debbugs.gnu.org; 14 May 2022 17:08:08 +0000 Received: from localhost ([127.0.0.1]:47444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npvFQ-0007Oq-IJ for submit@debbugs.gnu.org; Sat, 14 May 2022 13:08:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npvFP-0007Oa-8A for 55412@debbugs.gnu.org; Sat, 14 May 2022 13:08:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57340) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npvFJ-0005rz-9V; Sat, 14 May 2022 13:08:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pAB12dU9ngkdhnvp9+a7frv9o+PNDY2rX6cEld48fyE=; b=hw5/KwEcxBhA TfAHU5Wl436nf5L38LDdFJI8FegSumqrNdf366ghhu6AS4WlhskjL6aJE4CUtPFEusvLjmEiqBd7z o2utb+Dugy8qi9y5MV4WeP2i0Dp2xM8KXqcPmWQ+XTnhK2YhXI39OCsavi87CG9Gj6RQkickdogu8 1zs37he44VUylzqVNDFtqTseHVKEjbUlKBchndqWo/zCg3F6XPdF/6+Krxln4IXF7hiJsGTeGCFnf Fs7R1ru0yH6fZUusRWGpljEBOP0Y7RK3u4YZLmkcImF0ITQPzbeLx9ZNOgWg1/G/LJrk/3quoba6x 1G3CEcVT9SeOlh/8ToTarQ==; Received: from [87.69.77.57] (port=1437 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npvFI-00073G-PJ; Sat, 14 May 2022 13:08:01 -0400 Date: Sat, 14 May 2022 20:07:48 +0300 Message-Id: <837d6okpp7.fsf@gnu.org> From: Eli Zaretskii To: acm@muc.de In-Reply-To: <838rr4kq56.fsf@gnu.org> (message from Eli Zaretskii on Sat, 14 May 2022 19:58:13 +0300) Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly References: <838rr4kq56.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 55412@debbugs.gnu.org > Date: Sat, 14 May 2022 19:58:13 +0300 > From: Eli Zaretskii > > If I revert a part of that commit shown below: Sorry for confusing wording. I meant to say If I revert a part of that commit _as_ shown below: That is, what was "shown below" was the _reverse_ of what commit 7c2ebf6 did. From debbugs-submit-bounces@debbugs.gnu.org Sun May 15 05:28:38 2022 Received: (at 55412) by debbugs.gnu.org; 15 May 2022 09:28:38 +0000 Received: from localhost ([127.0.0.1]:48545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqAYH-0002Os-Og for submit@debbugs.gnu.org; Sun, 15 May 2022 05:28:38 -0400 Received: from mout.gmx.net ([212.227.15.19]:35481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqAYF-0002Od-6q for 55412@debbugs.gnu.org; Sun, 15 May 2022 05:28:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1652606898; bh=uC4rVpK/KPGfqL2CB3DeNBaZ+xzGubAo66y0xHuG4MQ=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=Q7Z5lVp42buxwHeibtchAxexizKstk5q/7vB9tby1ODyaCQHpdESsD3B6KIunwpjd 3Un5DRGuq1yDgcxkvl8Gli3A0qZUgXZ2GtX6t41Fpn0fVF5kwa0KdXVdhTd/v3Y4gN GfpP6pYApX0CtC4AXBM43bIDvzSCjolMg3DbJviY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([46.125.249.75]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MNbkv-1oF99G2Xn9-00P1Vg; Sun, 15 May 2022 11:28:17 +0200 Content-Type: multipart/mixed; boundary="------------U1TOTRQrhAsQi4bQPbUlFGBU" Message-ID: <3e9955b5-ac61-c4ab-b1a3-c64ab3c3b1a7@gmx.at> Date: Sun, 15 May 2022 11:28:16 +0200 MIME-Version: 1.0 Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Content-Language: en-US To: tanzer@swing.co.at, 55412@debbugs.gnu.org References: From: martin rudalics In-Reply-To: X-Provags-ID: V03:K1:Tlk4J4D3EBOZU35tTkZSTXZnaWB7QpqlOzV/JQ9Ph0xGseMtQFk vYmB9T6E3W10H7tRC/XCunww4StsK/kWwHM9T1XCe3j6e9RnKChSZlHai1G8GcxfoG6EGgi p5G2jhh3XdVN0CLlJKADeWSFI0/UosFrTsuj67jczEVAPc0RkTLbpv+jPx4vNs4J8FVYlFj UU/sVD4Y2++LDDjT63Ghw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:1ci3zmohFQ4=:nDD/TyUVCavagMjzZwv8t5 DGkkFOEOaL/XpzwS+bK39ddsePZBJ39lYZphsdJsURkfKu//GVYq1juzOYazUmBakLrqBvJwX HefupVEcykqXJXc1xmnEBMfeGAX1DacdvDrPGf85S3jdaEqMYZIG64uBkXRPFW2vYBYx1ID2l P6knI0PByddySZbUcAN/4eg9obo3cM+7Q4Y4ta78FWRDyTaCkHTP9EEiI9oOal87eZAl2eWW8 YQdCcmU3B3xPbluz6isK+kIpaCXnlmn1IahFyVnIuh7AF7NZ1G3NUmQ/WZjt+He5z4j2Auu/V 0/SPPBudv/3khODn1jD11jI8fbvEb3YwJJRhJKLHiOJoYzSuC34qrhD1x+uO3ehk1KHtFOCFM h5uaCVt1AgBPfHe1gKpP3Ba0JniihSAGSVxVOotFJTHeOs7vGSlop9AYZC/O+QM0uvmaJyZML h5FotSV6+wtJnp20e5oIbIhtiHvG2jP9NjwzLrAnA+R8M+UnNOvOPuEnOwSq6yuxH2swBnIAX Ij6M3Yw1RS2YrJvJdlxiIxHBVEnDXbg9ofqKu4CQ6MB1Q8NyFF2agSs4m95TNE3npGJ0/Yk9z zv3HlfAUzw9YU3q4sAtY9Y8fWGBWQhvY0BANabIc9x2VH3cBB26yPsjsg4dkr7DQJkeCoMWoC DricIKHfzujpj8za484/EfI8sG5R+siO42k14K7qz+gDBLJtiFq7S6l3P9UvqC5u2PFRomjqF 3XqAKtcaQAj7gPJfbXcVfB/YeubITlW8BtS3JhkfaFVuELX+3Rl/977BBhE88izZqOxwVwYgA 93qwXdFujVEpgZkAwUrozx4Ofi53sJ8eAUKAYQEpManS6dNYQCGHC1ndL1CVOktrUehYfEd5t 4WhKqaY2E++FryT71nOfkt8iX6c0cLZyLvd7iaqMGRtuzNSeU4x0xRrjmO2kwuti46yDJ8vWT dWWJ/aJIbLV8RJQ110B8PKCKOPDBBLdj49V2/L914N9isGCIvU/I7EAgocdr4Q3HyL8TvXFi2 SqNVnxycKSh1pyRHIJ5h3fwD6sl3kdB7ysBa4JOaBSrP1eaG00v/BTac/u62UA7DfeEQ2965a haFPAA+I+PRYr4= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55412 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------U1TOTRQrhAsQi4bQPbUlFGBU Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > ;;; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work like it > ;;; used to in Emacs 27 and earlier. In fact, it is completely broken, if one > ;;; uses a frame-parameter in ':eval'. > ;;; > ;;; The following elisp snippet demonstrates the problem in an Emacs 28.1 > ;;; instance started with 'emacs -Q' > > (defun title-suffix () > (cdr (assoc 'title-suffix (frame-parameters (selected-frame))))) > > (defvar title-prefix "Test") > (setq frame-title-format (list title-prefix '(:eval (title-suffix)) " %b")) > > ;;; The original frame should show a frame title of 'Test *scratch*' > (set-frame-parameter (selected-frame) 'title-suffix "") > > ;;; The next frame created should show a frame title of 'Test-xxx *scratch*' > (make-frame-command) > (set-frame-parameter (selected-frame) 'title-suffix "-xxx") > > ;;; The third frame created should show a frame title of 'Test-yyy *scratch*' > (make-frame-command) > (set-frame-parameter (selected-frame) 'title-suffix "-yyy") > > ;;; In Emacs 27 and earlier, that is exactly what happens. Selecting a > ;;; different frame doesn't change the titles of all other frames. > > ;;; In Emacs 28.1, all frames show the same frame title, with the last one > ;;; selected determining which one is shown for the bunch of them. Changing to > ;;; a different frame changes the titles of all frames to the title of the > ;;; newly selected one. Could you try the attached patch? Its purpose is to solve a more general problem in this area and I had to scrape it out from my sources so there are most likely dragons around. But AFAICT it does not exhibit the problem you see, tested with a GNUstep build on old stable Debian. Thanks, martin --------------U1TOTRQrhAsQi4bQPbUlFGBU Content-Type: text/x-patch; charset=UTF-8; name="with-window-selected.diff" Content-Disposition: attachment; filename="with-window-selected.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy93aW5kb3cuYyBiL3NyYy93aW5kb3cuYwppbmRleCBhODdiNDgz NGFhLi43ZjYxNmJjNWFjIDEwMDY0NAotLS0gYS9zcmMvd2luZG93LmMKKysrIGIvc3JjL3dp bmRvdy5jCkBAIC02MDcsNiArNjA3LDEyMSBAQCBzZWxlY3Rfd2luZG93XzEgKExpc3BfT2Jq ZWN0IHdpbmRvdywgYm9vbCBpbmhpYml0X3BvaW50X3N3YXApCiAgIHNldF9wb2ludF9mcm9t X21hcmtlciAoWFdJTkRPVyAod2luZG93KS0+cG9pbnRtKTsKIH0KIAorCisvKiogVGVtcG9y YXJpbHkgc2VsZWN0IGEgd2luZG93IHdpdGggbWluaW11bSBvdmVyaGVhZC4gICovCisKK3N0 YXRpYyBMaXNwX09iamVjdCBWd2l0aF93aW5kb3dfc2VsZWN0ZWRfdmVjdG9yOworCitzdGF0 aWMgTGlzcF9PYmplY3QKK3dpdGhfd2luZG93X3NlbGVjdGVkX3Vud2luZF9kYXRhIChMaXNw X09iamVjdCB3aW5kb3cpCit7CisgIExpc3BfT2JqZWN0IHZlY3RvciwgYnVmZmVyOworICBz dHJ1Y3QgZnJhbWUgKmYgPSBXSU5ET1dfWEZSQU1FIChYV0lORE9XICh3aW5kb3cpKTsKKwor ICB2ZWN0b3IgPSBWd2l0aF93aW5kb3dfc2VsZWN0ZWRfdmVjdG9yOworICBWd2l0aF93aW5k b3dfc2VsZWN0ZWRfdmVjdG9yID0gUW5pbDsKKworICBpZiAoTklMUCAodmVjdG9yKSkKKyAg ICB2ZWN0b3IgPSBtYWtlX25pbF92ZWN0b3IgKDQpOworCisgIC8qIEN1cnJlbnQgYnVmZmVy LiAgVG8gYmUgcmVzdG9yZWQgaWYgc3RpbGwgYWxpdmUuICAqLworICBYU0VUQlVGRkVSIChi dWZmZXIsIGN1cnJlbnRfYnVmZmVyKTsKKyAgQVNFVCAodmVjdG9yLCAwLCBidWZmZXIpOwor ICAvKiBTZWxlY3RlZCB3aW5kb3cuICBUbyBiZSByZXN0b3JlZCBpZiBzdGlsbCBhbGl2ZS4g ICovCisgIEFTRVQgKHZlY3RvciwgMSwgc2VsZWN0ZWRfd2luZG93KTsKKyAgLyogU2VsZWN0 ZWQgd2luZG93IG9mIFdJTkRPVydzIGZyYW1lLiAgVG8gYmUgcmVzdG9yZWQgaWYgc3RpbGwK KyAgICAgYWxpdmUuICAqLworICBBU0VUICh2ZWN0b3IsIDIsIGYtPnNlbGVjdGVkX3dpbmRv dyk7CisgIC8qIEZvciBhIFRUWSBmcmFtZSBzYXZlIGl0cyB0b3AtZnJhbWUuICBUbyBiZSBy ZXN0b3JlZCBpZiBzdGlsbAorICAgICBhbGl2ZS4gICovCisgIGlmIChGUkFNRV9URVJNQ0FQ X1AgKGYpIHx8IEZSQU1FX01TRE9TX1AgKGYpKQorICAgIEFTRVQgKHZlY3RvciwgMywgRlJB TUVfVFRZIChmKS0+dG9wX2ZyYW1lKTsKKyAgZWxzZQorICAgIEFTRVQgKHZlY3RvciwgMywg UW5pbCk7CisKKyAgcmV0dXJuIHZlY3RvcjsKK30KKworCitzdGF0aWMgdm9pZAordW53aW5k X3dpdGhfd2luZG93X3NlbGVjdGVkIChMaXNwX09iamVjdCB2ZWN0b3IpCit7CisgIExpc3Bf T2JqZWN0IGJ1ZmZlciA9IEFSRUYgKHZlY3RvciwgMCk7CisgIExpc3BfT2JqZWN0IHdpbmRv dyA9IEFSRUYgKHZlY3RvciwgMSk7CisgIExpc3BfT2JqZWN0IGZyYW1lX3NlbGVjdGVkX3dp bmRvdyA9IEFSRUYgKHZlY3RvciwgMik7CisgIExpc3BfT2JqZWN0IHRvcF9mcmFtZSA9IEFS RUYgKHZlY3RvciwgMyk7CisKKyAgLyogUmVzdG9yZSB0aGluZ3MgaWZmIHRoZSB3aW5kb3cg aXMgc3RpbGwgYWxpdmUuICAqLworICBpZiAoV0lORE9XX0xJVkVfUCAod2luZG93KSkKKyAg ICB7CisgICAgICBzdHJ1Y3Qgd2luZG93ICp3ID0gWFdJTkRPVyAod2luZG93KTsKKyAgICAg IExpc3BfT2JqZWN0IGZyYW1lID0gV0lORE9XX0ZSQU1FICh3KTsKKyAgICAgIHN0cnVjdCBm cmFtZSAqZiA9IFhGUkFNRSAoZnJhbWUpOworCisgICAgICAvKiBSZXN0b3JlIHRoZSBmcmFt ZSdzIHNlbGVjdGVkIHdpbmRvdyBpZiBpdCdzIHN0aWxsIGFsaXZlLiAgKi8KKyAgICAgIGlm IChXSU5ET1dfTElWRV9QIChmcmFtZV9zZWxlY3RlZF93aW5kb3cpKQorCVdJTkRPV19YRlJB TUUgKFhXSU5ET1cgKGZyYW1lX3NlbGVjdGVkX3dpbmRvdykpLT5zZWxlY3RlZF93aW5kb3cK KwkgID0gZnJhbWVfc2VsZWN0ZWRfd2luZG93OworCisgICAgICAvKiBNYWtlIHctPmNvbnRl bnRzIGN1cnJlbnQgYmVmb3JlIGNhbGxpbmcgc2VsZWN0X3dpbmRvd18xIGJlY2F1c2UKKwkg dGhlIGxhdHRlciBzZXRzIFBUIGZyb20gdy0+cG9pbnRtLiAgKi8KKyAgICAgIHNldF9idWZm ZXJfaW50ZXJuYWxfMSAoWEJVRkZFUiAody0+Y29udGVudHMpKTsKKyAgICAgIHNlbGVjdF93 aW5kb3dfMSAod2luZG93LCBmYWxzZSk7CisKKyAgICAgIGlmIChGUkFNRVAgKHRvcF9mcmFt ZSkgJiYgRlJBTUVfTElWRV9QIChYRlJBTUUgKHRvcF9mcmFtZSkpKQorCXNlbGVjdGVkX2Zy YW1lID0gdG9wX2ZyYW1lOworICAgICAgZWxzZQorCXNlbGVjdGVkX2ZyYW1lID0gZnJhbWU7 CisKKyAgICAgIGYtPnNlbGVjdGVkX3dpbmRvdyA9IHdpbmRvdzsKKyAgICB9CisKKyAgLyog UmVzdG9yZSBjdXJyZW50IGJ1ZmZlciBpZiBpdCdzIHN0aWxsIGFsaXZlLiAgKi8KKyAgaWYg KEJVRkZFUl9MSVZFX1AgKFhCVUZGRVIgKGJ1ZmZlcikpKQorICAgIHNldF9idWZmZXJfaW50 ZXJuYWxfMSAoWEJVRkZFUiAoYnVmZmVyKSk7CisKKyAgVndpdGhfd2luZG93X3NlbGVjdGVk X3ZlY3RvciA9IHZlY3RvcjsKK30KKworCisvKiogIENhbm9uaWNhbCBmb3JtIHRvIHJ1biBz b21ldGhpbmcgd2l0aCBXSU5ET1cgdGVtcG9yYXJpbHkgc2VsZWN0ZWQuCisgICAgIE5vdGU6 IFRoaXMgZG9lcyBub3QgcG9wIHRoZSB1bndpbmQtcHJvdGVjdCBzdGFjayBhbmQgc3Vic2Vx dWVudGx5CisgICAgIGNhbGwgdW53aW5kX3dpdGhfd2luZG93X3NlbGVjdGVkLiAgQ2FsbGVy cyBoYXZlIHRvIHByb3ZpZGUgdGhlCisgICAgIGNvcnJlc3BvbmRpbmcgdW5iaW5kX3RvIGZv cm0gdGhlbXNlbHZlcy4gICoqLwordm9pZAord2l0aF93aW5kb3dfc2VsZWN0ZWQgKExpc3Bf T2JqZWN0IHdpbmRvdykKK3sKKyAgaWYgKCFFUSAod2luZG93LCBzZWxlY3RlZF93aW5kb3cp CisgICAgICB8fCBjdXJyZW50X2J1ZmZlciAhPSBYQlVGRkVSIChYV0lORE9XIChzZWxlY3Rl ZF93aW5kb3cpLT5jb250ZW50cykpCisgICAgeworICAgICAgc3RydWN0IHdpbmRvdyAqdyA9 IFhXSU5ET1cgKHdpbmRvdyk7CisgICAgICBMaXNwX09iamVjdCBmcmFtZSA9IFdJTkRPV19G UkFNRSAodyk7CisgICAgICBzdHJ1Y3QgZnJhbWUgKmYgPSBYRlJBTUUgKGZyYW1lKTsKKyAg ICAgIHN0cnVjdCB3aW5kb3cgKm93ID0gWFdJTkRPVyAoc2VsZWN0ZWRfd2luZG93KTsKKwor ICAgICAgcmVjb3JkX3Vud2luZF9wcm90ZWN0ICh1bndpbmRfd2l0aF93aW5kb3dfc2VsZWN0 ZWQsCisJCQkgICAgIHdpdGhfd2luZG93X3NlbGVjdGVkX3Vud2luZF9kYXRhICh3aW5kb3cp KTsKKworICAgICAgc2V0X2J1ZmZlcl9pbnRlcm5hbF8xIChYQlVGRkVSICh3LT5jb250ZW50 cykpOworCisgICAgICBpZiAoQlVGRkVSUCAob3ctPmNvbnRlbnRzKSkKKwlzZXRfbWFya2Vy X2JvdGggKG93LT5wb2ludG0sIG93LT5jb250ZW50cywKKwkJCSBCVUZfUFQgKFhCVUZGRVIg KG93LT5jb250ZW50cykpLAorCQkJIEJVRl9QVF9CWVRFIChYQlVGRkVSIChvdy0+Y29udGVu dHMpKSk7CisKKyAgICAgIHNlbGVjdGVkX3dpbmRvdyA9IHdpbmRvdzsKKworICAgICAgaWYg KCFOSUxQIChYV0lORE9XICh3aW5kb3cpLT5wb2ludG0pKQorCXNldF9wb2ludF9mcm9tX21h cmtlciAoWFdJTkRPVyAod2luZG93KS0+cG9pbnRtKTsKKworICAgICAgc2VsZWN0ZWRfZnJh bWUgPSBmcmFtZTsKKyAgICAgIGYtPnNlbGVjdGVkX3dpbmRvdyA9IHdpbmRvdzsKKyAgICAg IGlmIChGUkFNRV9URVJNQ0FQX1AgKGYpIHx8IEZSQU1FX01TRE9TX1AgKGYpKQorCUZSQU1F X1RUWSAoZiktPnRvcF9mcmFtZSA9IGZyYW1lOworICAgIH0KK30KKworCiBERUZVTiAoInNl bGVjdC13aW5kb3ciLCBGc2VsZWN0X3dpbmRvdywgU3NlbGVjdF93aW5kb3csIDEsIDIsIDAs CiAgICAgICAgZG9jOiAvKiBTZWxlY3QgV0lORE9XIHdoaWNoIG11c3QgYmUgYSBsaXZlIHdp bmRvdy4KIEFsc28gbWFrZSBXSU5ET1cncyBmcmFtZSB0aGUgc2VsZWN0ZWQgZnJhbWUgYW5k IFdJTkRPVyB0aGF0IGZyYW1lJ3MKQEAgLTgxNTEsNiArODI2Niw5IEBAIGluaXRfd2luZG93 X29uY2UgKHZvaWQpCiAgIG1pbmlidWZfc2VsZWN0ZWRfd2luZG93ID0gUW5pbDsKICAgc3Rh dGljcHJvICgmbWluaWJ1Zl9zZWxlY3RlZF93aW5kb3cpOwogCisgIFZ3aXRoX3dpbmRvd19z ZWxlY3RlZF92ZWN0b3IgPSBRbmlsOworICBzdGF0aWNwcm8gKCZWd2l0aF93aW5kb3dfc2Vs ZWN0ZWRfdmVjdG9yKTsKKwogICBwZHVtcGVyX2RvX25vd19hbmRfYWZ0ZXJfbGF0ZV9sb2Fk IChpbml0X3dpbmRvd19vbmNlX2Zvcl9wZHVtcGVyKTsKIH0KIApkaWZmIC0tZ2l0IGEvc3Jj L3dpbmRvdy5oIGIvc3JjL3dpbmRvdy5oCmluZGV4IDdmN2RlNTg4NDYuLjY3ZjRiYmQ5ZTAg MTAwNjQ0Ci0tLSBhL3NyYy93aW5kb3cuaAorKysgYi9zcmMvd2luZG93LmgKQEAgLTExOTIs NiArMTE5Miw3IEBAICNkZWZpbmUgQ0hFQ0tfTElWRV9XSU5ET1coV0lORE9XKQkJCQlcCiBl eHRlcm4gdm9pZCB0ZW1wX291dHB1dF9idWZmZXJfc2hvdyAoTGlzcF9PYmplY3QpOwogZXh0 ZXJuIHZvaWQgcmVwbGFjZV9idWZmZXJfaW5fd2luZG93cyAoTGlzcF9PYmplY3QpOwogZXh0 ZXJuIHZvaWQgcmVwbGFjZV9idWZmZXJfaW5fd2luZG93c19zYWZlbHkgKExpc3BfT2JqZWN0 KTsKK2V4dGVybiB2b2lkIHdpdGhfd2luZG93X3NlbGVjdGVkIChMaXNwX09iamVjdCk7CiAv KiBUaGlzIGxvb2tzIGxpa2UgYSBzZXR0ZXIsIGJ1dCBpdCBpcyBhIGJpdCBzcGVjaWFsLiAg Ki8KIGV4dGVybiB2b2lkIHdzZXRfYnVmZmVyIChzdHJ1Y3Qgd2luZG93ICosIExpc3BfT2Jq ZWN0KTsKIGV4dGVybiBib29sIHdpbmRvd19vdXRkYXRlZCAoc3RydWN0IHdpbmRvdyAqKTsK ZGlmZiAtLWdpdCBhL3NyYy94ZGlzcC5jIGIvc3JjL3hkaXNwLmMKaW5kZXggNWZmNTRiMjg4 NC4uODQwNDM3Zjc2YSAxMDA2NDQKLS0tIGEvc3JjL3hkaXNwLmMKKysrIGIvc3JjL3hkaXNw LmMKQEAgLTEyOTY3LDIwICsxMjk2NywxNyBAQCAjZGVmaW5lIE1PREVfTElORV9OT1BST1Bf TEVOKHN0YXJ0KSBcCiBzdGF0aWMgTGlzcF9PYmplY3QgVm1vZGVfbGluZV91bndpbmRfdmVj dG9yOwogCiBzdGF0aWMgTGlzcF9PYmplY3QKLWZvcm1hdF9tb2RlX2xpbmVfdW53aW5kX2Rh dGEgKHN0cnVjdCBmcmFtZSAqdGFyZ2V0X2ZyYW1lLAotCQkJICAgICAgc3RydWN0IGJ1ZmZl ciAqb2J1ZiwKLQkJCSAgICAgIExpc3BfT2JqZWN0IG93aW4sCi0JCQkgICAgICBib29sIHNh dmVfcHJvcHRyYW5zKQorZm9ybWF0X21vZGVfbGluZV91bndpbmRfZGF0YSAoYm9vbCBzYXZl X3Byb3B0cmFucykKIHsKLSAgTGlzcF9PYmplY3QgdmVjdG9yLCB0bXA7CisgIExpc3BfT2Jq ZWN0IHZlY3RvcjsKIAogICAvKiBSZWR1Y2UgY29uc2luZyBieSBrZWVwaW5nIG9uZSB2ZWN0 b3IgaW4KLSAgICAgVndpdGhfZWNob19hcmVhX3NhdmVfdmVjdG9yLiAgKi8KKyAgICAgVm1v ZGVfbGluZV91bndpbmRfdmVjdG9yLiAgKi8KICAgdmVjdG9yID0gVm1vZGVfbGluZV91bndp bmRfdmVjdG9yOwogICBWbW9kZV9saW5lX3Vud2luZF92ZWN0b3IgPSBRbmlsOwogCiAgIGlm IChOSUxQICh2ZWN0b3IpKQotICAgIHZlY3RvciA9IG1ha2VfbmlsX3ZlY3RvciAoMTIpOwor ICAgIHZlY3RvciA9IG1ha2VfbmlsX3ZlY3RvciAoNik7CiAKICAgQVNFVCAodmVjdG9yLCAw LCBtYWtlX2ZpeG51bSAobW9kZV9saW5lX3RhcmdldCkpOwogICBBU0VUICh2ZWN0b3IsIDEs IG1ha2VfZml4bnVtIChNT0RFX0xJTkVfTk9QUk9QX0xFTiAoMCkpKTsKQEAgLTEyOTg5LDQ0 ICsxMjk4NiwxMiBAQCBmb3JtYXRfbW9kZV9saW5lX3Vud2luZF9kYXRhIChzdHJ1Y3QgZnJh bWUgKnRhcmdldF9mcmFtZSwKICAgQVNFVCAodmVjdG9yLCA0LCBtb2RlX2xpbmVfc3RyaW5n X2ZhY2UpOwogICBBU0VUICh2ZWN0b3IsIDUsIG1vZGVfbGluZV9zdHJpbmdfZmFjZV9wcm9w KTsKIAotICBpZiAob2J1ZikKLSAgICBYU0VUQlVGRkVSICh0bXAsIG9idWYpOwotICBlbHNl Ci0gICAgdG1wID0gUW5pbDsKLSAgQVNFVCAodmVjdG9yLCA2LCB0bXApOwotICBBU0VUICh2 ZWN0b3IsIDcsIG93aW4pOwotICBpZiAodGFyZ2V0X2ZyYW1lKQotICAgIHsKLSAgICAgIExp c3BfT2JqZWN0IGJ1ZmZlciA9IFhXSU5ET1cgKHRhcmdldF9mcmFtZS0+c2VsZWN0ZWRfd2lu ZG93KS0+Y29udGVudHM7Ci0gICAgICBzdHJ1Y3QgYnVmZmVyICpiID0gWEJVRkZFUiAoYnVm ZmVyKTsKLSAgICAgIHN0cnVjdCBidWZmZXIgKmNiID0gY3VycmVudF9idWZmZXI7Ci0KLSAg ICAgIC8qIFNpbWlsYXJseSB0byBgd2l0aC1zZWxlY3RlZC13aW5kb3cnLCBpZiB0aGUgb3Bl cmF0aW9uIHNlbGVjdHMKLQkgYSB3aW5kb3cgb24gYW5vdGhlciBmcmFtZSwgd2UgbXVzdCBy ZXN0b3JlIHRoYXQgZnJhbWUncwotCSBzZWxlY3RlZCB3aW5kb3csIGFuZCAoZm9yIGEgdHR5 KSB0aGUgdG9wLWZyYW1lLiAgKi8KLSAgICAgIEFTRVQgKHZlY3RvciwgOCwgdGFyZ2V0X2Zy YW1lLT5zZWxlY3RlZF93aW5kb3cpOwotICAgICAgaWYgKEZSQU1FX1RFUk1DQVBfUCAodGFy Z2V0X2ZyYW1lKSkKLQlBU0VUICh2ZWN0b3IsIDksIEZSQU1FX1RUWSAodGFyZ2V0X2ZyYW1l KS0+dG9wX2ZyYW1lKTsKLQotICAgICAgLyogSWYgd2Ugc2VsZWN0IGEgd2luZG93IG9uIGFu b3RoZXIgZnJhbWUsIG1ha2Ugc3VyZSB0aGF0IHRoYXQKLQkgc2VsZWN0aW9uIGRvZXMgbm90 IGxlYXZlIGl0cyBidWZmZXIncyBwb2ludCBtb2RpZmllZCB3aGVuCi0JIHVud2luZGluZyAo QnVnIzMyNzc3KS4gICovCi0gICAgICBBU0VUICh2ZWN0b3IsIDEwLCBidWZmZXIpOwotICAg ICAgY3VycmVudF9idWZmZXIgPSBiOwotICAgICAgQVNFVCAodmVjdG9yLCAxMSwgYnVpbGRf bWFya2VyIChjdXJyZW50X2J1ZmZlciwgUFQsIFBUX0JZVEUpKTsKLSAgICAgIGN1cnJlbnRf YnVmZmVyID0gY2I7Ci0gICAgfQotCiAgIHJldHVybiB2ZWN0b3I7CiB9CiAKIHN0YXRpYyB2 b2lkCiB1bndpbmRfZm9ybWF0X21vZGVfbGluZSAoTGlzcF9PYmplY3QgdmVjdG9yKQogewot ICBMaXNwX09iamVjdCBvbGRfd2luZG93ID0gQVJFRiAodmVjdG9yLCA3KTsKLSAgTGlzcF9P YmplY3QgdGFyZ2V0X2ZyYW1lX3dpbmRvdyA9IEFSRUYgKHZlY3RvciwgOCk7Ci0gIExpc3Bf T2JqZWN0IG9sZF90b3BfZnJhbWUgPSBBUkVGICh2ZWN0b3IsIDkpOwotCiAgIG1vZGVfbGlu ZV90YXJnZXQgPSBYRklYTlVNIChBUkVGICh2ZWN0b3IsIDApKTsKICAgbW9kZV9saW5lX25v cHJvcF9wdHIgPSBtb2RlX2xpbmVfbm9wcm9wX2J1ZiArIFhGSVhOVU0gKEFSRUYgKHZlY3Rv ciwgMSkpOwogICBtb2RlX2xpbmVfc3RyaW5nX2xpc3QgPSBBUkVGICh2ZWN0b3IsIDIpOwpA QCAtMTMwMzUsNTUgKzEzMDAwLDkgQEAgdW53aW5kX2Zvcm1hdF9tb2RlX2xpbmUgKExpc3Bf T2JqZWN0IHZlY3RvcikKICAgbW9kZV9saW5lX3N0cmluZ19mYWNlID0gQVJFRiAodmVjdG9y LCA0KTsKICAgbW9kZV9saW5lX3N0cmluZ19mYWNlX3Byb3AgPSBBUkVGICh2ZWN0b3IsIDUp OwogCi0gIC8qIFNlbGVjdCB3aW5kb3cgYmVmb3JlIGJ1ZmZlciwgc2luY2UgaXQgbWF5IGNo YW5nZSB0aGUgYnVmZmVyLiAgKi8KLSAgaWYgKFdJTkRPV19MSVZFX1AgKG9sZF93aW5kb3cp KQotICAgIHsKLSAgICAgIC8qIElmIHRoZSBvcGVyYXRpb24gdGhhdCB3ZSBhcmUgdW53aW5k aW5nIGhhZCBzZWxlY3RlZCBhIHdpbmRvdwotCSBvbiBhIGRpZmZlcmVudCBmcmFtZSwgcmVz ZXQgaXRzIGZyYW1lLXNlbGVjdGVkLXdpbmRvdy4gIEZvciBhCi0JIHRleHQgdGVybWluYWws IHJlc2V0IGl0cyB0b3AtZnJhbWUgaWYgbmVjZXNzYXJ5LiAgKi8KLSAgICAgIGlmIChXSU5E T1dfTElWRV9QICh0YXJnZXRfZnJhbWVfd2luZG93KSkKLQl7Ci0JICBMaXNwX09iamVjdCBm cmFtZQotCSAgICA9IFdJTkRPV19GUkFNRSAoWFdJTkRPVyAodGFyZ2V0X2ZyYW1lX3dpbmRv dykpOwotCi0JICBpZiAoIUVRIChmcmFtZSwgV0lORE9XX0ZSQU1FIChYV0lORE9XIChvbGRf d2luZG93KSkpKQotCSAgICBGc2VsZWN0X3dpbmRvdyAodGFyZ2V0X2ZyYW1lX3dpbmRvdywg UXQpOwotCi0JICBpZiAoIU5JTFAgKG9sZF90b3BfZnJhbWUpICYmICFFUSAob2xkX3RvcF9m cmFtZSwgZnJhbWUpKQotCSAgICBGc2VsZWN0X2ZyYW1lIChvbGRfdG9wX2ZyYW1lLCBRdCk7 Ci0JfQotCi0gICAgICBGc2VsZWN0X3dpbmRvdyAob2xkX3dpbmRvdywgUXQpOwotCi0gICAg ICAvKiBSZXN0b3JlIHBvaW50IG9mIHRhcmdldF9mcmFtZV93aW5kb3cncyBidWZmZXIgKEJ1 ZyMzMjc3NykuCi0JIEJ1dCBkbyB0aGlzIG9ubHkgYWZ0ZXIgb2xkX3dpbmRvdyBoYXMgYmVl biByZXNlbGVjdGVkIHRvCi0JIGF2b2lkIHRoYXQgdGhlIHdpbmRvdyBwb2ludCBvZiB0YXJn ZXRfZnJhbWVfd2luZG93IG1vdmVzLiAgKi8KLSAgICAgIGlmIChXSU5ET1dfTElWRV9QICh0 YXJnZXRfZnJhbWVfd2luZG93KSkKLQl7Ci0JICBMaXNwX09iamVjdCBidWZmZXIgPSBBUkVG ICh2ZWN0b3IsIDEwKTsKLQotCSAgaWYgKEJVRkZFUl9MSVZFX1AgKFhCVUZGRVIgKGJ1ZmZl cikpKQotCSAgICB7Ci0JICAgICAgc3RydWN0IGJ1ZmZlciAqY2IgPSBjdXJyZW50X2J1ZmZl cjsKLQotCSAgICAgIGN1cnJlbnRfYnVmZmVyID0gWEJVRkZFUiAoYnVmZmVyKTsKLQkgICAg ICBzZXRfcG9pbnRfZnJvbV9tYXJrZXIgKEFSRUYgKHZlY3RvciwgMTEpKTsKLQkgICAgICBB U0VUICh2ZWN0b3IsIDExLCBRbmlsKTsKLQkgICAgICBjdXJyZW50X2J1ZmZlciA9IGNiOwot CSAgICB9Ci0JfQotICAgIH0KLQotICBpZiAoIU5JTFAgKEFSRUYgKHZlY3RvciwgNikpKQot ICAgIHsKLSAgICAgIHNldF9idWZmZXJfaW50ZXJuYWxfMSAoWEJVRkZFUiAoQVJFRiAodmVj dG9yLCA2KSkpOwotICAgICAgQVNFVCAodmVjdG9yLCA2LCBRbmlsKTsKLSAgICB9Ci0KICAg Vm1vZGVfbGluZV91bndpbmRfdmVjdG9yID0gdmVjdG9yOwogfQogCi0KIC8qIFN0b3JlIGEg c2luZ2xlIGNoYXJhY3RlciBDIGZvciB0aGUgZnJhbWUgdGl0bGUgaW4gbW9kZV9saW5lX25v cHJvcF9idWYuCiAgICBSZS1hbGxvY2F0ZSBtb2RlX2xpbmVfbm9wcm9wX2J1ZiBpZiBuZWNl c3NhcnkuICAqLwogCkBAIC0xMzE5NSwxNSArMTMxMTQsMTEgQEAgZ3VpX2NvbnNpZGVyX2Zy YW1lX3RpdGxlIChMaXNwX09iamVjdCBmcmFtZSkKIAkgQnVnIzM0MzE3LiAgKi8KICAgICAg IHNwZWNiaW5kIChRaW5oaWJpdF9yZWRpc3BsYXksIFF0KTsKIAotICAgICAgLyogU3dpdGNo IHRvIHRoZSBidWZmZXIgb2Ygc2VsZWN0ZWQgd2luZG93IG9mIHRoZSBmcmFtZS4gIFNldCB1 cAotCSBtb2RlX2xpbmVfdGFyZ2V0IHNvIHRoYXQgZGlzcGxheV9tb2RlX2VsZW1lbnQgd2ls bCBvdXRwdXQgaW50bwotCSBtb2RlX2xpbmVfbm9wcm9wX2J1ZjsgdGhlbiBkaXNwbGF5IHRo ZSB0aXRsZS4gICovCisgICAgICB3aXRoX3dpbmRvd19zZWxlY3RlZCAoZi0+c2VsZWN0ZWRf d2luZG93KTsKKwogICAgICAgcmVjb3JkX3Vud2luZF9wcm90ZWN0ICh1bndpbmRfZm9ybWF0 X21vZGVfbGluZSwKLQkJCSAgICAgZm9ybWF0X21vZGVfbGluZV91bndpbmRfZGF0YQotCQkJ ICAgICAoTlVMTCwgY3VycmVudF9idWZmZXIsIFFuaWwsIGZhbHNlKSk7CisJCQkgICAgIGZv cm1hdF9tb2RlX2xpbmVfdW53aW5kX2RhdGEgKGZhbHNlKSk7CiAKLSAgICAgIHNldF9idWZm ZXJfaW50ZXJuYWxfMQotCShYQlVGRkVSIChYV0lORE9XIChmLT5zZWxlY3RlZF93aW5kb3cp LT5jb250ZW50cykpOwogICAgICAgZm10ID0gRlJBTUVfSUNPTklGSUVEX1AgKGYpID8gVmlj b25fdGl0bGVfZm9ybWF0IDogVmZyYW1lX3RpdGxlX2Zvcm1hdDsKIAogICAgICAgbW9kZV9s aW5lX3RhcmdldCA9IE1PREVfTElORV9USVRMRTsKQEAgLTEzNDk3LDY5ICsxMzQxMiw2IEBA IHVwZGF0ZV9tZW51X2JhciAoc3RydWN0IGZyYW1lICpmLCBib29sIHNhdmVfbWF0Y2hfZGF0 YSwgYm9vbCBob29rc19ydW4pCiAJCQkgICAgICAgVGFiLWJhcnMKICAqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKi8KIAotLyogUmVzdG9yZSBXSU5ET1cgYXMgdGhlIHNlbGVjdGVkIHdpbmRvdyBhbmQg aXRzIGZyYW1lIGFzIHRoZSBzZWxlY3RlZAotICAgZnJhbWUuICBJZiBXSU5ET1cgaXMgZGVh ZCBidXQgdGhlIHNlbGVjdGVkIGZyYW1lIGlzIGxpdmUsIG1ha2UgdGhlCi0gICBsYXR0ZXIn cyBzZWxlY3RlZCB3aW5kb3cgdGhlIHNlbGVjdGVkIHdpbmRvdy4gIElmIGJvdGgsIFdJTkRP VyBhbmQKLSAgIHRoZSBzZWxlY3RlZCBmcmFtZSwgYXJlIGRlYWQsIGFzc2lnbiBzZWxlY3Rl ZCBmcmFtZSBhbmQgd2luZG93IGZyb20KLSAgIHNvbWUgYXJiaXRyYXJ5IGxpdmUgZnJhbWUu ICBBYm9ydCBpZiBubyBzdWNoIGZyYW1lIGNhbiBiZSBmb3VuZC4gICovCi1zdGF0aWMgdm9p ZAotcmVzdG9yZV9zZWxlY3RlZF93aW5kb3cgKExpc3BfT2JqZWN0IHdpbmRvdykKLXsKLSAg aWYgKFdJTkRPV19MSVZFX1AgKHdpbmRvdykpCi0gICAgLyogSWYgV0lORE9XIGlzIGxpdmUs IG1ha2UgaXQgdGhlIHNlbGVjdGVkIHdpbmRvdyBhbmQgaXRzIGZyYW1lJ3MKLSAgICAgICBz ZWxlY3RlZCB3aW5kb3cgYW5kIHNldCB0aGUgc2VsZWN0ZWQgZnJhbWUgdG8gaXRzIGZyYW1l LiAgKi8KLSAgICB7Ci0gICAgICBzZWxlY3RlZF93aW5kb3cgPSB3aW5kb3c7Ci0gICAgICBz ZWxlY3RlZF9mcmFtZSA9IFhXSU5ET1cgKHdpbmRvdyktPmZyYW1lOwotICAgICAgRlJBTUVf U0VMRUNURURfV0lORE9XIChYRlJBTUUgKHNlbGVjdGVkX2ZyYW1lKSkgPSB3aW5kb3c7Ci0g ICAgfQotICBlbHNlIGlmIChGUkFNRVAgKHNlbGVjdGVkX2ZyYW1lKSAmJiBGUkFNRV9MSVZF X1AgKFhGUkFNRSAoc2VsZWN0ZWRfZnJhbWUpKSkKLSAgICAvKiBJZiBXSU5ET1cgaXMgZGVh ZCBidXQgdGhlIHNlbGVjdGVkIGZyYW1lIGlzIHN0aWxsIGxpdmUsIG1ha2UgdGhlCi0gICAg ICAgbGF0dGVyJ3Mgc2VsZWN0ZWQgd2luZG93IHRoZSBzZWxlY3RlZCBvbmUuICAqLwotICAg IHNlbGVjdGVkX3dpbmRvdyA9IEZSQU1FX1NFTEVDVEVEX1dJTkRPVyAoWEZSQU1FIChzZWxl Y3RlZF9mcmFtZSkpOwotICBlbHNlCi0gICAgLyogSWYgV0lORE9XIGFuZCB0aGUgc2VsZWN0 ZWQgZnJhbWUgYXJlIGRlYWQsIGNob29zZSBzb21lIGxpdmUsCi0gICAgICAgbm9uLWNoaWxk IGFuZCBub24tdG9vbHRpcCBmcmFtZSBhcyB0aGUgbmV3IHNlbGVjdGVkIGZyYW1lIGFuZAot ICAgICAgIG1ha2UgaXRzIHNlbGVjdGVkIHdpbmRvdyB0aGUgc2VsZWN0ZWQgd2luZG93LiAg Ki8KLSAgICB7Ci0gICAgICBMaXNwX09iamVjdCB0YWlsOwotICAgICAgTGlzcF9PYmplY3Qg ZnJhbWUgVU5JTklUOwotCi0gICAgICBGT1JfRUFDSF9GUkFNRSAodGFpbCwgZnJhbWUpCi0J ewotCSAgc3RydWN0IGZyYW1lICpmID0gWEZSQU1FIChmcmFtZSk7Ci0KLQkgIGlmICghRlJB TUVfUEFSRU5UX0ZSQU1FIChmKSAmJiAhRlJBTUVfVE9PTFRJUF9QIChmKSkKLQkgICAgewot CSAgICAgIHNlbGVjdGVkX2ZyYW1lID0gZnJhbWU7Ci0JICAgICAgc2VsZWN0ZWRfd2luZG93 ID0gRlJBTUVfU0VMRUNURURfV0lORE9XIChmKTsKLQotCSAgICAgIHJldHVybjsKLQkgICAg fQotCX0KLQotICAgICAgLyogQWJvcnQgaWYgd2UgY2Fubm90IGZpbmQgYSBsaXZlIGZyYW1l LiAgKi8KLSAgICAgIGVtYWNzX2Fib3J0ICgpOwotICAgIH0KLX0KLQotLyogUmVzdG9yZSBX SU5ET1csIGlmIGxpdmUsIGFzIGl0cyBmcmFtZSdzIHNlbGVjdGVkIHdpbmRvdy4gICovCi1z dGF0aWMgdm9pZAotcmVzdG9yZV9mcmFtZV9zZWxlY3RlZF93aW5kb3cgKExpc3BfT2JqZWN0 IHdpbmRvdykKLXsKLSAgaWYgKFdJTkRPV19MSVZFX1AgKHdpbmRvdykpCi0gICAgLyogSWYg V0lORE9XIGlzIGxpdmUsIG1ha2UgaXQgaXRzIGZyYW1lJ3Mgc2VsZWN0ZWQgd2luZG93LiAg SWYgdGhhdAotICAgICAgIGZyYW1lIGlzIHRoZSBzZWxlY3RlZCBmcmFtZSwgbWFrZSBXSU5E T1cgdGhlIHNlbGVjdGVkIHdpbmRvdyBhcwotICAgICAgIHdlbGwuICAqLwotICAgIHsKLSAg ICAgIExpc3BfT2JqZWN0IGZyYW1lID0gWFdJTkRPVyAod2luZG93KS0+ZnJhbWU7Ci0KLSAg ICAgIEZSQU1FX1NFTEVDVEVEX1dJTkRPVyAoWEZSQU1FIChmcmFtZSkpID0gd2luZG93Owot ICAgICAgaWYgKEVRIChmcmFtZSwgc2VsZWN0ZWRfZnJhbWUpKQotCXNlbGVjdGVkX3dpbmRv dyA9IHdpbmRvdzsKLSAgICB9Ci19Ci0KIC8qIFVwZGF0ZSB0aGUgdGFiLWJhciBpdGVtIGxp c3QgZm9yIGZyYW1lIEYuICBUaGlzIGhhcyB0byBiZSBkb25lCiAgICBiZWZvcmUgd2Ugc3Rh cnQgdG8gZmlsbCBpbiBhbnkgZGlzcGxheSBsaW5lcy4gIENhbGxlZCBmcm9tCiAgICBwcmVw YXJlX21lbnVfYmFycy4gIElmIFNBVkVfTUFUQ0hfREFUQSwgd2UgbXVzdCBzYXZlCkBAIC0x MzU4MiwxMSArMTM0MzQsOCBAQCB1cGRhdGVfdGFiX2JhciAoc3RydWN0IGZyYW1lICpmLCBi b29sIHNhdmVfbWF0Y2hfZGF0YSkKIAogICBpZiAoZG9fdXBkYXRlKQogICAgIHsKLSAgICAg IExpc3BfT2JqZWN0IHdpbmRvdzsKLSAgICAgIHN0cnVjdCB3aW5kb3cgKnc7Ci0KLSAgICAg IHdpbmRvdyA9IEZSQU1FX1NFTEVDVEVEX1dJTkRPVyAoZik7Ci0gICAgICB3ID0gWFdJTkRP VyAod2luZG93KTsKKyAgICAgIExpc3BfT2JqZWN0IHdpbmRvdyA9IEZSQU1FX1NFTEVDVEVE X1dJTkRPVyAoZik7CisgICAgICBzdHJ1Y3Qgd2luZG93ICp3ID0gWFdJTkRPVyAod2luZG93 KTsKIAogICAgICAgLyogSWYgdGhlIHVzZXIgaGFzIHN3aXRjaGVkIGJ1ZmZlcnMgb3Igd2lu ZG93cywgd2UgbmVlZCB0bwogCSByZWNvbXB1dGUgdG8gcmVmbGVjdCB0aGUgbmV3IGJpbmRp bmdzLiAgQnV0IHdlJ2xsCkBAIC0xMzYwMCwxNiArMTM0NDksMTAgQEAgdXBkYXRlX3RhYl9i YXIgKHN0cnVjdCBmcmFtZSAqZiwgYm9vbCBzYXZlX21hdGNoX2RhdGEpCiAJICB8fCB1cGRh dGVfbW9kZV9saW5lcwogCSAgfHwgd2luZG93X2J1ZmZlcl9jaGFuZ2VkICh3KSkKIAl7Ci0J ICBzdHJ1Y3QgYnVmZmVyICpwcmV2ID0gY3VycmVudF9idWZmZXI7CiAJICBzcGVjcGRsX3Jl ZiBjb3VudCA9IFNQRUNQRExfSU5ERVggKCk7CiAJICBMaXNwX09iamVjdCBuZXdfdGFiX2Jh cjsKICAgICAgICAgICBpbnQgbmV3X25fdGFiX2JhcjsKIAotCSAgLyogU2V0IGN1cnJlbnRf YnVmZmVyIHRvIHRoZSBidWZmZXIgb2YgdGhlIHNlbGVjdGVkCi0JICAgICB3aW5kb3cgb2Yg dGhlIGZyYW1lLCBzbyB0aGF0IHdlIGdldCB0aGUgcmlnaHQgbG9jYWwKLQkgICAgIGtleW1h cHMuICAqLwotCSAgc2V0X2J1ZmZlcl9pbnRlcm5hbF8xIChYQlVGRkVSICh3LT5jb250ZW50 cykpOwotCiAJICAvKiBTYXZlIG1hdGNoIGRhdGEsIGlmIHdlIG11c3QuICAqLwogCSAgaWYg KHNhdmVfbWF0Y2hfZGF0YSkKIAkgICAgcmVjb3JkX3Vud2luZF9zYXZlX21hdGNoX2RhdGEg KCk7CkBAIC0xMzYyMSwyMCArMTM0NjQsOCBAQCB1cGRhdGVfdGFiX2JhciAoc3RydWN0IGZy YW1lICpmLCBib29sIHNhdmVfbWF0Y2hfZGF0YSkKIAkgICAgICBzcGVjYmluZCAoUW92ZXJy aWRpbmdfbG9jYWxfbWFwLCBRbmlsKTsKIAkgICAgfQogCi0JICAvKiBXZSBtdXN0IHRlbXBv cmFyaWx5IHNldCB0aGUgc2VsZWN0ZWQgZnJhbWUgdG8gdGhpcyBmcmFtZQotCSAgICAgYmVm b3JlIGNhbGxpbmcgdGFiX2Jhcl9pdGVtcywgYmVjYXVzZSB0aGUgY2FsY3VsYXRpb24gb2YK LQkgICAgIHRoZSB0YWItYmFyIGtleW1hcCB1c2VzIHRoZSBzZWxlY3RlZCBmcmFtZSAoc2Vl Ci0JICAgICBgdGFiLWJhci1tYWtlLWtleW1hcCcgaW4gdGFiLWJhci5lbCkuICAqLwotCSAg ZWFzc2VydCAoRVEgKHNlbGVjdGVkX3dpbmRvdywKLQkJICAgICAgIC8qIFNpbmNlIHdlIG9u bHkgZXhwbGljaXRseSBwcmVzZXJ2ZSBzZWxlY3RlZF9mcmFtZSwKLQkJCSAgY2hlY2sgdGhh dCBzZWxlY3RlZF93aW5kb3cgd291bGQgYmUgcmVkdW5kYW50LiAgKi8KLQkJICAgICAgIFhG UkFNRSAoc2VsZWN0ZWRfZnJhbWUpLT5zZWxlY3RlZF93aW5kb3cpKTsKICNpZmRlZiBIQVZF X1dJTkRPV19TWVNURU0KLQkgIExpc3BfT2JqZWN0IGZyYW1lOwotCSAgcmVjb3JkX3Vud2lu ZF9wcm90ZWN0IChyZXN0b3JlX3NlbGVjdGVkX3dpbmRvdywgc2VsZWN0ZWRfd2luZG93KTsK LQkgIFhTRVRGUkFNRSAoZnJhbWUsIGYpOwotCSAgc2VsZWN0ZWRfZnJhbWUgPSBmcmFtZTsK LQkgIHNlbGVjdGVkX3dpbmRvdyA9IEZSQU1FX1NFTEVDVEVEX1dJTkRPVyAoZik7CisJICB3 aXRoX3dpbmRvd19zZWxlY3RlZCAod2luZG93KTsKICNlbmRpZgogCiAJICAvKiBCdWlsZCBk ZXNpcmVkIHRhYi1iYXIgaXRlbXMgZnJvbSBrZXltYXBzLiAgKi8KQEAgLTEzNjU3LDcgKzEz NDg4LDYgQEAgdXBkYXRlX3RhYl9iYXIgKHN0cnVjdCBmcmFtZSAqZiwgYm9vbCBzYXZlX21h dGNoX2RhdGEpCiAgICAgICAgICAgICB9CiAKIAkgIHVuYmluZF90byAoY291bnQsIFFuaWwp OwotCSAgc2V0X2J1ZmZlcl9pbnRlcm5hbF8xIChwcmV2KTsKIAl9CiAgICAgfQogfQpAQCAt MTQ0OTUsMTEgKzE0MzI1LDggQEAgdXBkYXRlX3Rvb2xfYmFyIChzdHJ1Y3QgZnJhbWUgKmYs IGJvb2wgc2F2ZV9tYXRjaF9kYXRhKQogCiAgIGlmIChkb191cGRhdGUpCiAgICAgewotICAg ICAgTGlzcF9PYmplY3Qgd2luZG93OwotICAgICAgc3RydWN0IHdpbmRvdyAqdzsKLQotICAg ICAgd2luZG93ID0gRlJBTUVfU0VMRUNURURfV0lORE9XIChmKTsKLSAgICAgIHcgPSBYV0lO RE9XICh3aW5kb3cpOworICAgICAgTGlzcF9PYmplY3Qgd2luZG93ID0gRlJBTUVfU0VMRUNU RURfV0lORE9XIChmKTsKKyAgICAgIHN0cnVjdCB3aW5kb3cgKncgPSBYV0lORE9XICh3aW5k b3cpOwogCiAgICAgICAvKiBJZiB0aGUgdXNlciBoYXMgc3dpdGNoZWQgYnVmZmVycyBvciB3 aW5kb3dzLCB3ZSBuZWVkIHRvCiAJIHJlY29tcHV0ZSB0byByZWZsZWN0IHRoZSBuZXcgYmlu ZGluZ3MuICBCdXQgd2UnbGwKQEAgLTE0NTEzLDE2ICsxNDM0MCwxMCBAQCB1cGRhdGVfdG9v bF9iYXIgKHN0cnVjdCBmcmFtZSAqZiwgYm9vbCBzYXZlX21hdGNoX2RhdGEpCiAJICB8fCB1 cGRhdGVfbW9kZV9saW5lcwogCSAgfHwgd2luZG93X2J1ZmZlcl9jaGFuZ2VkICh3KSkKIAl7 Ci0JICBzdHJ1Y3QgYnVmZmVyICpwcmV2ID0gY3VycmVudF9idWZmZXI7CiAJICBzcGVjcGRs X3JlZiBjb3VudCA9IFNQRUNQRExfSU5ERVggKCk7Ci0JICBMaXNwX09iamVjdCBmcmFtZSwg bmV3X3Rvb2xfYmFyOworCSAgTGlzcF9PYmplY3QgbmV3X3Rvb2xfYmFyOwogICAgICAgICAg IGludCBuZXdfbl90b29sX2JhcjsKIAotCSAgLyogU2V0IGN1cnJlbnRfYnVmZmVyIHRvIHRo ZSBidWZmZXIgb2YgdGhlIHNlbGVjdGVkCi0JICAgICB3aW5kb3cgb2YgdGhlIGZyYW1lLCBz byB0aGF0IHdlIGdldCB0aGUgcmlnaHQgbG9jYWwKLQkgICAgIGtleW1hcHMuICAqLwotCSAg c2V0X2J1ZmZlcl9pbnRlcm5hbF8xIChYQlVGRkVSICh3LT5jb250ZW50cykpOwotCiAJICAv KiBTYXZlIG1hdGNoIGRhdGEsIGlmIHdlIG11c3QuICAqLwogCSAgaWYgKHNhdmVfbWF0Y2hf ZGF0YSkKIAkgICAgcmVjb3JkX3Vud2luZF9zYXZlX21hdGNoX2RhdGEgKCk7CkBAIC0xNDUz NCwxOCArMTQzNTUsNyBAQCB1cGRhdGVfdG9vbF9iYXIgKHN0cnVjdCBmcmFtZSAqZiwgYm9v bCBzYXZlX21hdGNoX2RhdGEpCiAJICAgICAgc3BlY2JpbmQgKFFvdmVycmlkaW5nX2xvY2Fs X21hcCwgUW5pbCk7CiAJICAgIH0KIAotCSAgLyogV2UgbXVzdCB0ZW1wb3JhcmlseSBzZXQg dGhlIHNlbGVjdGVkIGZyYW1lIHRvIHRoaXMgZnJhbWUKLQkgICAgIGJlZm9yZSBjYWxsaW5n IHRvb2xfYmFyX2l0ZW1zLCBiZWNhdXNlIHRoZSBjYWxjdWxhdGlvbiBvZgotCSAgICAgdGhl IHRvb2wtYmFyIGtleW1hcCB1c2VzIHRoZSBzZWxlY3RlZCBmcmFtZSAoc2VlCi0JICAgICBg dG9vbC1iYXItbWFrZS1rZXltYXAnIGluIHRvb2wtYmFyLmVsKS4gICovCi0JICBlYXNzZXJ0 IChFUSAoc2VsZWN0ZWRfd2luZG93LAotCQkgICAgICAgLyogU2luY2Ugd2Ugb25seSBleHBs aWNpdGx5IHByZXNlcnZlIHNlbGVjdGVkX2ZyYW1lLAotCQkJICBjaGVjayB0aGF0IHNlbGVj dGVkX3dpbmRvdyB3b3VsZCBiZSByZWR1bmRhbnQuICAqLwotCQkgICAgICAgWEZSQU1FIChz ZWxlY3RlZF9mcmFtZSktPnNlbGVjdGVkX3dpbmRvdykpOwotCSAgcmVjb3JkX3Vud2luZF9w cm90ZWN0IChyZXN0b3JlX3NlbGVjdGVkX3dpbmRvdywgc2VsZWN0ZWRfd2luZG93KTsKLQkg IFhTRVRGUkFNRSAoZnJhbWUsIGYpOwotCSAgc2VsZWN0ZWRfZnJhbWUgPSBmcmFtZTsKLQkg IHNlbGVjdGVkX3dpbmRvdyA9IEZSQU1FX1NFTEVDVEVEX1dJTkRPVyAoZik7CisJICB3aXRo X3dpbmRvd19zZWxlY3RlZCAod2luZG93KTsKIAogCSAgLyogQnVpbGQgZGVzaXJlZCB0b29s LWJhciBpdGVtcyBmcm9tIGtleW1hcHMuICAqLwogICAgICAgICAgIG5ld190b29sX2JhcgpA QCAtMTQ1NjcsNyArMTQzNzcsNiBAQCB1cGRhdGVfdG9vbF9iYXIgKHN0cnVjdCBmcmFtZSAq ZiwgYm9vbCBzYXZlX21hdGNoX2RhdGEpCiAgICAgICAgICAgICB9CiAKIAkgIHVuYmluZF90 byAoY291bnQsIFFuaWwpOwotCSAgc2V0X2J1ZmZlcl9pbnRlcm5hbF8xIChwcmV2KTsKIAl9 CiAgICAgfQogfQpAQCAtMjYwNzUsMTUgKzI1ODg0LDggQEAgcmVkaXNwbGF5X21vZGVfbGlu ZXMgKExpc3BfT2JqZWN0IHdpbmRvdywgYm9vbCBmb3JjZSkKIHN0YXRpYyBpbnQKIGRpc3Bs YXlfbW9kZV9saW5lcyAoc3RydWN0IHdpbmRvdyAqdykKIHsKLSAgTGlzcF9PYmplY3Qgb2xk X3NlbGVjdGVkX3dpbmRvdyA9IHNlbGVjdGVkX3dpbmRvdzsKLSAgTGlzcF9PYmplY3QgbmV3 X2ZyYW1lID0gdy0+ZnJhbWU7Ci0gIHNwZWNwZGxfcmVmIGNvdW50ID0gU1BFQ1BETF9JTkRF WCAoKTsKICAgaW50IG4gPSAwOwogCi0gIHJlY29yZF91bndpbmRfcHJvdGVjdCAocmVzdG9y ZV9zZWxlY3RlZF93aW5kb3csIHNlbGVjdGVkX3dpbmRvdyk7Ci0gIHJlY29yZF91bndpbmRf cHJvdGVjdAotICAgIChyZXN0b3JlX2ZyYW1lX3NlbGVjdGVkX3dpbmRvdywgWEZSQU1FIChu ZXdfZnJhbWUpLT5zZWxlY3RlZF93aW5kb3cpOwotCiAgIGlmICh3aW5kb3dfd2FudHNfbW9k ZV9saW5lICh3KSkKICAgICB7CiAgICAgICBMaXNwX09iamVjdCB3aW5kb3c7CkBAIC0yNjEw MSwxMiArMjU5MDMsNiBAQCBkaXNwbGF5X21vZGVfbGluZXMgKHN0cnVjdCB3aW5kb3cgKncp CiAJd3NldF9tb2RlX2xpbmVfaGVscF9lY2hvICh3LCBRbmlsKTsKICAgICB9CiAKLSAgc2Vs ZWN0ZWRfZnJhbWUgPSBuZXdfZnJhbWU7Ci0gIC8qIEZJWE1FOiBJZiB3ZSB3ZXJlIHRvIGFs bG93IHRoZSBtb2RlLWxpbmUncyBjb21wdXRhdGlvbiBjaGFuZ2luZyB0aGUgYnVmZmVyCi0g ICAgIG9yIHdpbmRvdydzIHBvaW50LCB0aGVuIHdlJ2QgbmVlZCBzZWxlY3Rfd2luZG93XzEg aGVyZSBhcyB3ZWxsLiAgKi8KLSAgWFNFVFdJTkRPVyAoc2VsZWN0ZWRfd2luZG93LCB3KTsK LSAgWEZSQU1FIChuZXdfZnJhbWUpLT5zZWxlY3RlZF93aW5kb3cgPSBzZWxlY3RlZF93aW5k b3c7Ci0KICAgLyogVGhlc2Ugd2lsbCBiZSBzZXQgd2hpbGUgdGhlIG1vZGUgbGluZSBzcGVj cyBhcmUgcHJvY2Vzc2VkLiAgKi8KICAgbGluZV9udW1iZXJfZGlzcGxheWVkID0gZmFsc2U7 CiAgIHctPmNvbHVtbl9udW1iZXJfZGlzcGxheWVkID0gLTE7CkBAIC0yNjExNSw3ICsyNTkx MSw3IEBAIGRpc3BsYXlfbW9kZV9saW5lcyAoc3RydWN0IHdpbmRvdyAqdykKICAgICB7CiAg ICAgICBMaXNwX09iamVjdCB3aW5kb3dfbW9kZV9saW5lX2Zvcm1hdAogCT0gd2luZG93X3Bh cmFtZXRlciAodywgUW1vZGVfbGluZV9mb3JtYXQpOwotICAgICAgc3RydWN0IHdpbmRvdyAq c2VsX3cgPSBYV0lORE9XIChvbGRfc2VsZWN0ZWRfd2luZG93KTsKKyAgICAgIHN0cnVjdCB3 aW5kb3cgKnNlbF93ID0gWFdJTkRPVyAoc2VsZWN0ZWRfd2luZG93KTsKIAogICAgICAgLyog U2VsZWN0IG1vZGUgbGluZSBmYWNlIGJhc2VkIG9uIHRoZSByZWFsIHNlbGVjdGVkIHdpbmRv dy4gICovCiAgICAgICBkaXNwbGF5X21vZGVfbGluZSAodywKQEAgLTI2MTUwLDggKzI1OTQ2 LDYgQEAgZGlzcGxheV9tb2RlX2xpbmVzIChzdHJ1Y3Qgd2luZG93ICp3KQogICAgICAgKytu OwogICAgIH0KIAotICB1bmJpbmRfdG8gKGNvdW50LCBRbmlsKTsKLQogICBpZiAobiA+IDAp CiAgICAgdy0+bXVzdF9iZV91cGRhdGVkX3AgPSB0cnVlOwogICByZXR1cm4gbjsKQEAgLTI2 MTY3LDYgKzI1OTYxLDcgQEAgZGlzcGxheV9tb2RlX2xpbmVzIChzdHJ1Y3Qgd2luZG93ICp3 KQogc3RhdGljIGludAogZGlzcGxheV9tb2RlX2xpbmUgKHN0cnVjdCB3aW5kb3cgKncsIGVu dW0gZmFjZV9pZCBmYWNlX2lkLCBMaXNwX09iamVjdCBmb3JtYXQpCiB7CisgIExpc3BfT2Jq ZWN0IHdpbmRvdzsKICAgc3RydWN0IGl0IGl0OwogICBzdHJ1Y3QgZmFjZSAqZmFjZTsKICAg c3BlY3BkbF9yZWYgY291bnQgPSBTUEVDUERMX0lOREVYICgpOwpAQCAtMjYxOTEsOSArMjU5 ODYsMTEgQEAgZGlzcGxheV9tb2RlX2xpbmUgKHN0cnVjdCB3aW5kb3cgKncsIGVudW0gZmFj ZV9pZCBmYWNlX2lkLCBMaXNwX09iamVjdCBmb3JtYXQpCiAgICAgIG1hZGUgdXAgb2YgbWFu eSBzZXBhcmF0ZSBzdHJpbmdzLiAgKi8KICAgaXQucGFyYWdyYXBoX2VtYmVkZGluZyA9IEwy UjsKIAorICBYU0VUV0lORE9XICh3aW5kb3csIHcpOworICB3aXRoX3dpbmRvd19zZWxlY3Rl ZCAod2luZG93KTsKKwogICByZWNvcmRfdW53aW5kX3Byb3RlY3QgKHVud2luZF9mb3JtYXRf bW9kZV9saW5lLAotCQkJIGZvcm1hdF9tb2RlX2xpbmVfdW53aW5kX2RhdGEgKE5VTEwsIE5V TEwsCi0JCQkJCQkgICAgICAgUW5pbCwgZmFsc2UpKTsKKwkJCSBmb3JtYXRfbW9kZV9saW5l X3Vud2luZF9kYXRhIChmYWxzZSkpOwogCiAgIC8qIFRlbXBvcmFyaWx5IG1ha2UgZnJhbWUn cyBrZXlib2FyZCB0aGUgY3VycmVudCBrYm9hcmQgc28gdGhhdAogICAgICBrYm9hcmQtbG9j YWwgdmFyaWFibGVzIGluIHRoZSBtb2RlX2xpbmVfZm9ybWF0IHdpbGwgZ2V0IHRoZSByaWdo dApAQCAtMjY5MzEsNyArMjY3MjgsNiBAQCBERUZVTiAoImZvcm1hdC1tb2RlLWxpbmUiLCBG Zm9ybWF0X21vZGVfbGluZSwgU2Zvcm1hdF9tb2RlX2xpbmUsCiAgIHN0cnVjdCBpdCBpdDsK ICAgaW50IGxlbjsKICAgc3RydWN0IHdpbmRvdyAqdzsKLSAgc3RydWN0IGJ1ZmZlciAqb2xk X2J1ZmZlciA9IE5VTEw7CiAgIGludCBmYWNlX2lkOwogICBib29sIG5vX3Byb3BzID0gRklY TlVNUCAoZmFjZSk7CiAgIHNwZWNwZGxfcmVmIGNvdW50ID0gU1BFQ1BETF9JTkRFWCAoKTsK QEAgLTI2OTY0LDE3ICsyNjc2MCwxNSBAQCBERUZVTiAoImZvcm1hdC1tb2RlLWxpbmUiLCBG Zm9ybWF0X21vZGVfbGluZSwgU2Zvcm1hdF9tb2RlX2xpbmUsCiAgICAgOiBFUSAoZmFjZSwg UXRvb2xfYmFyKSA/IFRPT0xfQkFSX0ZBQ0VfSUQKICAgICA6IERFRkFVTFRfRkFDRV9JRDsK IAotICBvbGRfYnVmZmVyID0gY3VycmVudF9idWZmZXI7CisgIHdpdGhfd2luZG93X3NlbGVj dGVkICh3aW5kb3cpOwogCiAgIC8qIFNhdmUgdGhpbmdzIGluY2x1ZGluZyBtb2RlX2xpbmVf cHJvcHRyYW5zX2FsaXN0LAogICAgICBhbmQgc2V0IHRoYXQgdG8gbmlsIHNvIHRoYXQgd2Ug ZG9uJ3QgYWx0ZXIgdGhlIG91dGVyIHZhbHVlLiAgKi8KICAgcmVjb3JkX3Vud2luZF9wcm90 ZWN0ICh1bndpbmRfZm9ybWF0X21vZGVfbGluZSwKLQkJCSBmb3JtYXRfbW9kZV9saW5lX3Vu d2luZF9kYXRhCi0JCQkgICAoWEZSQU1FIChXSU5ET1dfRlJBTUUgKHcpKSwKLQkJCSAgICBv bGRfYnVmZmVyLCBzZWxlY3RlZF93aW5kb3csIHRydWUpKTsKKwkJCSBmb3JtYXRfbW9kZV9s aW5lX3Vud2luZF9kYXRhICh0cnVlKSk7CiAgIG1vZGVfbGluZV9wcm9wdHJhbnNfYWxpc3Qg PSBRbmlsOwogCi0gIEZzZWxlY3Rfd2luZG93ICh3aW5kb3csIFF0KTsKKyAgLyogVGhpcyBz aG91bGQgYmUgY292ZXJlZCBieSAndW53aW5kX3dpdGhfd2luZG93X3NlbGVjdGVkJy4gICov CiAgIHNldF9idWZmZXJfaW50ZXJuYWxfMSAoWEJVRkZFUiAoYnVmZmVyKSk7CiAKICAgaW5p dF9pdGVyYXRvciAoJml0LCB3LCAtMSwgLTEsIE5VTEwsIGZhY2VfaWQpOwo= --------------U1TOTRQrhAsQi4bQPbUlFGBU-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 15 05:48:48 2022 Received: (at 55412) by debbugs.gnu.org; 15 May 2022 09:48:48 +0000 Received: from localhost ([127.0.0.1]:48564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqArn-0002vY-VR for submit@debbugs.gnu.org; Sun, 15 May 2022 05:48:48 -0400 Received: from colin.muc.de ([193.149.48.1]:38126 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1nqArk-0002vJ-Ud for 55412@debbugs.gnu.org; Sun, 15 May 2022 05:48:46 -0400 Received: (qmail 1355 invoked by uid 3782); 15 May 2022 09:48:38 -0000 Received: from acm.muc.de (p4fe157eb.dip0.t-ipconnect.de [79.225.87.235]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 15 May 2022 11:48:38 +0200 Received: (qmail 4178 invoked by uid 1000); 15 May 2022 09:48:37 -0000 Date: Sun, 15 May 2022 09:48:37 +0000 To: Eli Zaretskii Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Message-ID: References: <838rr4kq56.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <838rr4kq56.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, May 14, 2022 at 19:58:13 +0300, Eli Zaretskii wrote: > > Date: Sat, 14 May 2022 15:45:10 -0000 > > From: Christian Tanzer > > ;;; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work like it > > ;;; used to in Emacs 27 and earlier. In fact, it is completely broken, if one > > ;;; uses a frame-parameter in ':eval'. > > ;;; > > ;;; The following elisp snippet demonstrates the problem in an Emacs 28.1 > > ;;; instance started with 'emacs -Q' > > (defun title-suffix () > > (cdr (assoc 'title-suffix (frame-parameters (selected-frame))))) > > (defvar title-prefix "Test") > > (setq frame-title-format (list title-prefix '(:eval (title-suffix)) " %b")) > > ;;; The original frame should show a frame title of 'Test *scratch*' > > (set-frame-parameter (selected-frame) 'title-suffix "") > > ;;; The next frame created should show a frame title of 'Test-xxx *scratch*' > > (make-frame-command) > > (set-frame-parameter (selected-frame) 'title-suffix "-xxx") > > ;;; The third frame created should show a frame title of 'Test-yyy *scratch*' > > (make-frame-command) > > (set-frame-parameter (selected-frame) 'title-suffix "-yyy") > > ;;; In Emacs 27 and earlier, that is exactly what happens. Selecting a > > ;;; different frame doesn't change the titles of all other frames. > > ;;; In Emacs 28.1, all frames show the same frame title, with the last one > > ;;; selected determining which one is shown for the bunch of them. Changing to > > ;;; a different frame changes the titles of all frames to the title of the > > ;;; newly selected one. > Thank you for your report. > Alan, this is due to one of the changes introduced for the > minibuffer-follows-selected-frame feature. Specifically, commit > 7c2ebf6 made a change in gui_consider_frame_title which causes this > regression. If I revert a part of that commit [as] shown below: > diff --git a/src/xdisp.c b/src/xdisp.c > index 6963935..9740e6b 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -12796,8 +12796,9 @@ gui_consider_frame_title (Lisp_Object frame) > mode_line_noprop_buf; then display the title. */ > record_unwind_protect (unwind_format_mode_line, > format_mode_line_unwind_data > - (NULL, current_buffer, Qnil, false)); > + (f, current_buffer, selected_window, false)); > + Fselect_window (f->selected_window, Qt); > set_buffer_internal_1 > (XBUFFER (XWINDOW (f->selected_window)->contents)); > fmt = FRAME_ICONIFIED_P (f) ? Vicon_title_format : Vframe_title_format; > then the problem goes away. > The log message of that commit says about this part: > * src/xdisp.c (gui_consider_frame_title): Remove redundant Fselect_window, > which caused an unwanted frame switch. Amend the arguments to > format_mode_line_unwind_data to match. > As you see, the call to select-window is not redundant, because > without it the frame's title cannot reference the frame-parameters of > that frame. > Do you remember why the frame switch here was "unwanted"? What > bad things happen if we restore the removed code? I remember vaguely that that call to Fselect_window caused minibuffers to be switched between frames in an unwanted fashion. I've got detailed notes of what I did, still. I'll probably not have much chance to look at the bug today, but should do over the next few days. > Thanks. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sun May 15 06:17:10 2022 Received: (at 55412) by debbugs.gnu.org; 15 May 2022 10:17:10 +0000 Received: from localhost ([127.0.0.1]:48579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqBJG-0003bD-0f for submit@debbugs.gnu.org; Sun, 15 May 2022 06:17:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqBJD-0003au-TG for 55412@debbugs.gnu.org; Sun, 15 May 2022 06:17:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqBJ6-0002TI-Lw; Sun, 15 May 2022 06:17:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9axV6v4QuVWUh6NNIpqolH0RrkP0XIH/AJD2ZnOJ724=; b=DFiJrGjaiX7k XdJZ3xWsLgXvP6a21Ai9xUERnoR1osaBju2jhjuRqSL+cJOh91z3jr2ejDo/4/oea8nCjqVmVgANW sydIidQWZngIKc0JOCByMEhHMeyJ36874XxLE1h17mlDqdSJNTPdjVDpHuNCy95+4TvZgLNJYFRsa io3ENQXxKb8EHQWESjs64472yVnjIXd3G+5esJpncg8EGCWJavn4lscqQm2sCsaEMzImMm06VDqEh xn0Dagpuo9U1zsi9p92dJA6pE60ny+UTTXSioqHoC8XLoFoql9evk3QJevw2scqmfeIjgV+mIrzn8 S6VMpBoiEaebe3Y4popq4w==; Received: from [87.69.77.57] (port=4551 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqBJ5-0007fV-5q; Sun, 15 May 2022 06:17:00 -0400 Date: Sun, 15 May 2022 13:16:45 +0300 Message-Id: <83mtfjje2a.fsf@gnu.org> From: Eli Zaretskii To: Alan Mackenzie In-Reply-To: (message from Alan Mackenzie on Sun, 15 May 2022 09:48:37 +0000) Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly References: <838rr4kq56.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 15 May 2022 09:48:37 +0000 > Cc: tanzer@swing.co.at, 55412@debbugs.gnu.org > From: Alan Mackenzie > > > Do you remember why the frame switch here was "unwanted"? What > > bad things happen if we restore the removed code? > > I remember vaguely that that call to Fselect_window caused minibuffers to > be switched between frames in an unwanted fashion. If that is the problem, we could perhaps countermand it by binding some variable across the call. > I've got detailed notes of what I did, still. I'll probably not > have much chance to look at the bug today, but should do over the > next few days. TIA. From debbugs-submit-bounces@debbugs.gnu.org Mon May 16 16:52:52 2022 Received: (at 55412) by debbugs.gnu.org; 16 May 2022 20:52:52 +0000 Received: from localhost ([127.0.0.1]:55134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqhhz-0005Dn-QZ for submit@debbugs.gnu.org; Mon, 16 May 2022 16:52:52 -0400 Received: from colin.muc.de ([193.149.48.1]:64510 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1nqhhx-0005Da-Ji for 55412@debbugs.gnu.org; Mon, 16 May 2022 16:52:50 -0400 Received: (qmail 60800 invoked by uid 3782); 16 May 2022 20:52:43 -0000 Received: from acm.muc.de (p4fe15b7d.dip0.t-ipconnect.de [79.225.91.125]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 16 May 2022 22:52:43 +0200 Received: (qmail 9791 invoked by uid 1000); 16 May 2022 20:52:42 -0000 Date: Mon, 16 May 2022 20:52:42 +0000 To: Eli Zaretskii Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Message-ID: References: <838rr4kq56.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <838rr4kq56.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at, acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Eli. On Sat, May 14, 2022 at 19:58:13 +0300, Eli Zaretskii wrote: > > Date: Sat, 14 May 2022 15:45:10 -0000 > > From: Christian Tanzer > > ;;; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work like it > > ;;; used to in Emacs 27 and earlier. In fact, it is completely broken, if one > > ;;; uses a frame-parameter in ':eval'. > > ;;; > > ;;; The following elisp snippet demonstrates the problem in an Emacs 28.1 > > ;;; instance started with 'emacs -Q' [ .... ] > > ;;; In Emacs 27 and earlier, that is exactly what happens. Selecting a > > ;;; different frame doesn't change the titles of all other frames. > > ;;; In Emacs 28.1, all frames show the same frame title, with the last one > > ;;; selected determining which one is shown for the bunch of them. Changing to > > ;;; a different frame changes the titles of all frames to the title of the > > ;;; newly selected one. > Thank you for your report. > Alan, this is due to one of the changes introduced for the > minibuffer-follows-selected-frame feature. Specifically, commit > 7c2ebf6 made a change in gui_consider_frame_title which causes this > regression. If I revert a part of that commit as shown below: > diff --git a/src/xdisp.c b/src/xdisp.c > index 6963935..9740e6b 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -12796,8 +12796,9 @@ gui_consider_frame_title (Lisp_Object frame) > mode_line_noprop_buf; then display the title. */ > record_unwind_protect (unwind_format_mode_line, > format_mode_line_unwind_data > - (NULL, current_buffer, Qnil, false)); > + (f, current_buffer, selected_window, false)); > + Fselect_window (f->selected_window, Qt); > set_buffer_internal_1 > (XBUFFER (XWINDOW (f->selected_window)->contents)); > fmt = FRAME_ICONIFIED_P (f) ? Vicon_title_format : Vframe_title_format; > then the problem goes away. Yes. It is clear that that Fselect_window call is needed. > The log message of that commit says about this part: > * src/xdisp.c (gui_consider_frame_title): Remove redundant Fselect_window, > which caused an unwanted frame switch. Amend the arguments to > format_mode_line_unwind_data to match. > As you see, the call to select-window is not redundant, because > without it the frame's title cannot reference the frame-parameters of > that frame. > Do you remember why the frame switch here was "unwanted"? What > bad things happen if we restore the removed code? I think I've managed to reconstruct why I made this part of the change. With the Fselect_window call in place: (i) When minibuffer-follows-selected-frame is nil, and the minibuffer is the current window before switching frames with C-x 5 o, it remains the current window on returning to the first frame. (ii) When minibuffer-follows-selected-frame is t (the default) and other circumstances are as in (i), the minibuffer is no longer the selected window on returning to the first frame. I wanted to fix this inconsistency, I think. Clearly, this inconsistency is less important than frame-title-format not working. May I suggest that one of us applies your patch immediately to the release branch. I will then attempt to find a less harmful way of fixing that inconsistency, and will take direction from you which branch it should be committed to. > Thanks. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Tue May 17 09:26:08 2022 Received: (at 55412) by debbugs.gnu.org; 17 May 2022 13:26:08 +0000 Received: from localhost ([127.0.0.1]:56092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqxDE-0002Hh-8Y for submit@debbugs.gnu.org; Tue, 17 May 2022 09:26:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqxDC-0002HL-ER for 55412@debbugs.gnu.org; Tue, 17 May 2022 09:26:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59046) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqxD5-0004Og-GE; Tue, 17 May 2022 09:25:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WcgicBlNsYMaxXTcaqMZ/HMZib/wDgcrT0jWXm3GKHU=; b=jKpcop5JBf5d cP+LCRhD36z1llkJeh/agrhClOMzbYlZUvn4zqCn6KFGjbU9fLNfFOYkpbDnkZ6v6XfJTteU0r3A+ 13TRfKzMgp65yQe+qy19gG5e+WmzUDPcx2Fv+hKuqsq4Kgf5/bcUvH7K5MxnNfOPOp4w1jd2ySfLO 4TYAyKMyEIYERpqghS6+zZ3CC0i76TiLfxEYCZEC7NCKDq7E63rcBt0A516X/S8bL6ZH5NQXd3esR Ou+Du7USbmnTIWHGCn1GVxnRCUbRNk0PG5UtTNDAO+lamvGSvQjMxdrwRMW4+9hQnQOdOHkyJ9MW4 DrnLpMg4s/wtlUzfwke+/A==; Received: from [87.69.77.57] (port=1674 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqxD4-0002XY-Vp; Tue, 17 May 2022 09:25:59 -0400 Date: Tue, 17 May 2022 16:25:50 +0300 Message-Id: <83ilq4gujl.fsf@gnu.org> From: Eli Zaretskii To: Alan Mackenzie In-Reply-To: (message from Alan Mackenzie on Mon, 16 May 2022 20:52:42 +0000) Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly References: <838rr4kq56.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at, acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 16 May 2022 20:52:42 +0000 > Cc: tanzer@swing.co.at, 55412@debbugs.gnu.org, acm@muc.de > From: Alan Mackenzie > > I think I've managed to reconstruct why I made this part of the change. > With the Fselect_window call in place: > (i) When minibuffer-follows-selected-frame is nil, and the minibuffer is > the current window before switching frames with C-x 5 o, it remains the > current window on returning to the first frame. > (ii) When minibuffer-follows-selected-frame is t (the default) and other > circumstances are as in (i), the minibuffer is no longer the selected > window on returning to the first frame. > I wanted to fix this inconsistency, I think. > > Clearly, this inconsistency is less important than frame-title-format not > working. May I suggest that one of us applies your patch immediately to > the release branch. I will then attempt to find a less harmful way of > fixing that inconsistency, and will take direction from you which branch > it should be committed to. Thanks, please go ahead and install the patch on the emacs-28 branch. From debbugs-submit-bounces@debbugs.gnu.org Wed May 18 03:20:11 2022 Received: (at 55412) by debbugs.gnu.org; 18 May 2022 07:20:11 +0000 Received: from localhost ([127.0.0.1]:58799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrDyd-0002PT-8d for submit@debbugs.gnu.org; Wed, 18 May 2022 03:20:11 -0400 Received: from mout.gmx.net ([212.227.15.19]:46701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrDyc-0002PC-5h for 55412@debbugs.gnu.org; Wed, 18 May 2022 03:20:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1652858390; bh=nYv5OWalDqa8est4Cc78Je9TY71bNlovhcRwCZpZdmc=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=FIwQC52S5ru3bkb056vgbqapFX5q0sdHAARMViqrGYJ+rDpmqjEihRvMMNu2TPGJr aqOUz++KBGJnxsmLdX2qcfANj7+9WK0UUiahM7XbO0UG589JxVfho0g0wtXK+EN4cX cAs3wxMahAr0IMEyADvO6tNmj3VIrQ+ty11caTK0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.19]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2mFi-1njTjO0Due-0135n0; Wed, 18 May 2022 09:19:50 +0200 Message-ID: <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> Date: Wed, 18 May 2022 09:19:48 +0200 MIME-Version: 1.0 Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Content-Language: en-US To: Alan Mackenzie , Eli Zaretskii References: <838rr4kq56.fsf@gnu.org> From: martin rudalics In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:vZVeXReY3WYInGRaKDpKUb+hu6rDUNp48vKpg4BkB3z8r4HBXRR FoZi6eyy308ycemrVUjkV4wmKnH4YWr4pjE5V697b7ieyQBd0IQPRb2PMw2fuQV3fJAN0NG L617o3I86qdfUdzuiMANuq5+QgnQsAtUK9kgu9ECq7bZGcUd/VmeizRflbqOYiyXJBU3WS/ QFJSTyYEjcgFgW1Dj3rVw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:1XhAVSM+LAc=:5rewhoz0uNoaOA8cS3nM/4 Z5nk+jImIxyhraaT4Fzzj63B38j+yzQ7SsyqZgGwucPrxntGUYkCNCqkpn1zPiw4sC3Y9acQU O5ZJu8Y2y8MclaromqgILruQGHwgQmWqnqAeFeQ8O1dM19/SWysB9bLUcnHo3pg8b9p71pfZj rEB3NTq8JulnGHgPXzKvko2ApqDzhzlqY64vvn5eiF6OiWdxkJ4UwFepp8GMPbZW79BcspWRc YCtKxqBh0qh4C0/5OqMaJGGZTRsiKxm1Z8+IUep41SJ6gOKCAc7cKiwupG1cKljmDzsTjEEpQ Rhtj08GFsy63nlxPqnpQ+XMzdbaaql9eCEaANMDT0JsTYyGiadFGd1+FJwgH/B8r3sdDHjMO+ 3PZFIZZ8FxnXjtXdXw/U8VxYPtVlPDX5Y2SWDW5HGPtq+aszp+iZ3A+jCSGvpo/yYLMz8qhLz 8Lq/1bcax0c+GcA4lVWndXO9zmZWNhB25EPM3URmI+tnTS/MMhNZ/CibLx6B9L8tRzAn9nDXl pSs1XoSMCv/itzfc8IPEhUGMI0jGVJZIbrSnr4xJk8LzGAo1Ab3C34MMVrHuF7bGLQL+03ex2 J+maoejn09xobtBFOowlARvOvCRXHVrfGNPtbkIeoukPkDA95g1tIupDm73FZLkQOW8Yx5ZEk 6jHSLrKxLPbU9az+MX1NofYCxIWomteRkXwa0iheyFTdx/aDT3QhzHi6K1Vlfte54gZCokyUu fo9xXrfOyT7afcgJrbGa4B6MmkGZ62XUeU4KZMHq/XKAuvOQfM2uUTAgcUrfKQ7PeRDKeJlbv m3+c6G5oAn1zppYkjhWc2kzqeUT0s2/QLOeZDGXqBNZMOZRbwtjRUspGhnQXkiYvP3y6IrMrx lpbvsFblnJ1Tst+Aly14i/IXZT6XUMsvPwMZq1M6YJzU/IByUu2ARxTau6ci1NdwUZ0P4MUvC 9QasQGFtFnTEkSq0Ks6bWE956jRBFl2AI63qbUH3vZHYSnZQrS7odxyOzLk+V7m1muoVAzo8L oPD5/RDkdpvhNOkRy1RF3Mj3Nb5vK75hwmG/rdrVL1YTnroAkJE7wUK0xp4R+o5hsr7D5/XUo fK7Tw8VLp4aFVgO+fvRRjKIRBQn6z58hK6LtGJLoiLmDGBbKxmXmSMWpA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > With the Fselect_window call in place: > (i) When minibuffer-follows-selected-frame is nil, and the minibuffer is > the current window before switching frames with C-x 5 o, it remains the > current window on returning to the first frame. > (ii) When minibuffer-follows-selected-frame is t (the default) and other > circumstances are as in (i), the minibuffer is no longer the selected > window on returning to the first frame. > I wanted to fix this inconsistency, I think. > > Clearly, this inconsistency is less important than frame-title-format not > working. When I type M-:, save the expression to evaluate from some other frame, and the subsequent yank inserts that expression into a normal buffer instead of the minibuffer, the resulting behavior does not constitute a less important inconsistency but an annoying regression. This is one of the things that used to work "ever since". > May I suggest that one of us applies your patch immediately to > the release branch. I will then attempt to find a less harmful way of > fixing that inconsistency, and will take direction from you which branch > it should be committed to. In that case please default 'minibuffer-follows-selected-frame' to nil and then try to find a suitable solution. Or try the patch I posted. martin From debbugs-submit-bounces@debbugs.gnu.org Wed May 18 07:35:45 2022 Received: (at 55412) by debbugs.gnu.org; 18 May 2022 11:35:45 +0000 Received: from localhost ([127.0.0.1]:59192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrHxw-00053E-PI for submit@debbugs.gnu.org; Wed, 18 May 2022 07:35:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrHxv-000531-Aa for 55412@debbugs.gnu.org; Wed, 18 May 2022 07:35:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55220) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrHxo-00046n-J2; Wed, 18 May 2022 07:35:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UntO53esyOXv/jMDVit1g2OLDcfyTINLoRCX29XTB4g=; b=oYdEsoAakze6 GdQqXiNR62oM1VtpNAYz5tvkeI0vpxZE5ewwUBfQ9vL1ERNBYKdO+Rtr+Ta8z4ZUKC6BnYeHm3S4c 4SNC0NczXKXP6surV7cg99v/knjs+qbNShQwVnO0HKaXdQniYvpUPPjKmITND8uzmU18QOy61es5I YQ4Hyx/3qMCNBInNKGg9zqZs3w8QHkz8W8AIZG16I0KU+84C95hadxnJD/3OtPQTkrij6h+rI+mVJ y8jwPZtSUUa0F+jQfC6R97Kk1Q+CU3yLN6sR/DlqCdwdj3GsufWr07VECJOULWbM6kC5AXerMwGga 6JOzTgOZ1B49qbsfArGEDg==; Received: from [87.69.77.57] (port=3584 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrHxl-0004FW-7U; Wed, 18 May 2022 07:35:35 -0400 Date: Wed, 18 May 2022 14:35:27 +0300 Message-Id: <83leuzf4zk.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> (message from martin rudalics on Wed, 18 May 2022 09:19:48 +0200) Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, acm@muc.de, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 18 May 2022 09:19:48 +0200 > Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at > From: martin rudalics > > When I type M-:, save the expression to evaluate from some other frame, > and the subsequent yank inserts that expression into a normal buffer > instead of the minibuffer, the resulting behavior does not constitute a > less important inconsistency but an annoying regression. This is one of > the things that used to work "ever since". Can you tell more about the inconsistency you get in this scenario? I'm afraid I don't follow the description and therefore cannot try reproducing it myself. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed May 18 11:02:09 2022 Received: (at 55412) by debbugs.gnu.org; 18 May 2022 15:02:09 +0000 Received: from localhost ([127.0.0.1]:33188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrLBg-0007WC-SM for submit@debbugs.gnu.org; Wed, 18 May 2022 11:02:09 -0400 Received: from mout.gmx.net ([212.227.17.21]:56213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrLBd-0007Vg-IK for 55412@debbugs.gnu.org; Wed, 18 May 2022 11:02:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1652886107; bh=bLi0R5MBZkZ/bEsTaGbLSo1jS3FEd8o6CbiNxU5kBbw=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=C2soW8PbM/umLTakxIjOFzo57cK/t5QXtCYduBsVzAsuBdiWZvtc8A1dwHq8vtprx QDj74uqucZ0r1aJPUwU+K77o9ZlJ/r86+ttLQ4SbG5bCpQbgMfaGPV6VQxDCRlbNhG 7FVptmtyaUoufwvS7zoivpy0k/arlqLAkyJyAkKQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([213.142.97.45]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N3siG-1nimYk13my-00zo9A; Wed, 18 May 2022 17:01:46 +0200 Message-ID: Date: Wed, 18 May 2022 17:01:43 +0200 MIME-Version: 1.0 Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Content-Language: en-US To: Eli Zaretskii References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> From: martin rudalics In-Reply-To: <83leuzf4zk.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:y7GHFGE1P3w0oP51L3gjCO2DtsQDsyarxGcHy5FJQtytcbo5QEP VcE9ssBK7sxf4XFNeYGIz+BULubk2f8id5hCy0HMuXw6eoplq4v+Fr5kACgwoX3PcxQTbw7 QrarTeqGKwNDMei1ijAKCQZR3drVF3FfMokl1YQmeFNa0PHrixmcAsueTXPaY78RHIya20k D2ByECXKk4aA+0FiC05tw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:L3kDzGDz6pM=:zb0bEDzMFqeknJBXkO54Br u6uJSqMN1u33VMdkTfcxR1JDm4/BtqvOmC0JKnT4swns9qGi6w3yDkV4G7eWCV+i2Cc9IkycI I2J4oFHeC2bQ9iRW5U7IY4CLrY0v28P3PWpgU/YvsTRfE5MfDPWG8+J2B71XDyl0yPDg0u/o0 nTxC6tKKGy20rcYMVVkiPJiIaHb7mK8AVT5FJ3Dkb8nNNzzT0k1nuSawFhU24Di+cM5E3q+1T LaW/1eypg2w17pLBEFYo8vEUnJ4lRvBx/sb3YzJN4tyP+GB7z1w+MzZ5/H848tGDB2O/fOHg7 w1HwzqjxS27rdqDgbUHHB2uFQD/48FgXKidEjDf539x8SGRkmA+DGulBtv2YhzfnBXuxHuxzH /LUsNYd8i1Lf1FPqdwUGEdn5vl7MfUACLKcW0Cdl7wDzsJBaUnf+jbza8uAlwbM7LyBiDJUmi 1G0HImOr7TolZlsE8aig4uezHwJNAw+iURztV2uNpSxliHDDXNLaV0WPCd8lS6j2O7D1E73i8 AYeizTjh2NPLjovlod2KJq5P75zkB4iULrdSZRjU8/TAwZiId7Hax6n7wCrzzMeV4/I1Pgoau dzhRQrLJby9nP9qvkm+5toagorg/PwmMCrpg8Xk+kBBI+X8ICQj6sT1VLUQ/n2tkBz+tZqDnn PIrOOdhnJ3iKZjB6ZoE0i8UENfj3AGy/1WOJyO++8nD+ou3HPqTnRLkBKpnRyMV4VXXsO642r pPzPRn7Eg2uh++qn2MvE533i90KDc/ufdtSfqcM9KaaFEZgpiGX0NN0YyCTtcxblJ1JIu4OKp OA6oaTuHQvfHMq2T+m3ZqJbkZo4KkpnTYrGC9bIhG+9j6PuJK9d6rJsbeWxcwdUnHPIEY52B5 lQVtG6ZFGB6h/0awIe61rILhOZgSrHMetxsBUBVuZzqVTUqMb4KU+cRTwx5tmDkiZglR5VZmd Edn8eJMQkmz0mDO5dX2qLiU4e5W9KQwEl0Xg03LLcVygUB1zKQpC+rv/sVHvjwK3BFcnhWPF3 lqEgia0uc0AW5eEaflwnjXvLYROTGRLkUkGT/qmcjz51v+U8yb1eE5apureHzlQfD9sFtzSfD tqG44lW8d0Uf3Cpsc/R3/DaeDsbj40B1Aq65/qcgboCyUCTXE+i5AEYyg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, acm@muc.de, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> When I type M-:, save the expression to evaluate from some other frame, >> and the subsequent yank inserts that expression into a normal buffer >> instead of the minibuffer, the resulting behavior does not constitute a >> less important inconsistency but an annoying regression. This is one of >> the things that used to work "ever since". > > Can you tell more about the inconsistency you get in this scenario? > I'm afraid I don't follow the description and therefore cannot try > reproducing it myself. Suppose I want to calculate the sum of two numbers: number-1 is shown in a buffer on frame-1, number-2 is show in a buffer on frame-2. I start typing M-: (+ on frame-1 then I do C-x o, mark number-1, type M-w, C-x o and C-y to yank number-1 into the minibuffer. Then I add a space to the minibuffer, type C-x 5 o to go to frame-2, mark number-2, type M-w and C-x 5 o to get back to frame-1. Ever since, that last C-x 5 o got me to the minibuffer window. With the proposed change, that C-x 5 o will get me to the window of number-1 and I have to manually select the minibuffer window to yank number-2 there. martin From debbugs-submit-bounces@debbugs.gnu.org Wed May 18 11:13:06 2022 Received: (at 55412) by debbugs.gnu.org; 18 May 2022 15:13:06 +0000 Received: from localhost ([127.0.0.1]:33228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrLMH-0007oO-Tr for submit@debbugs.gnu.org; Wed, 18 May 2022 11:13:06 -0400 Received: from colin.muc.de ([193.149.48.1]:39719 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1nrLMF-0007nS-Po for 55412@debbugs.gnu.org; Wed, 18 May 2022 11:13:04 -0400 Received: (qmail 59394 invoked by uid 3782); 18 May 2022 15:12:57 -0000 Received: from acm.muc.de (p4fe15a4c.dip0.t-ipconnect.de [79.225.90.76]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 18 May 2022 17:12:56 +0200 Received: (qmail 19124 invoked by uid 1000); 18 May 2022 15:12:56 -0000 Date: Wed, 18 May 2022 15:12:56 +0000 To: martin rudalics Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Message-ID: References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Martin. On Wed, May 18, 2022 at 17:01:43 +0200, martin rudalics wrote: > >> When I type M-:, save the expression to evaluate from some other frame, > >> and the subsequent yank inserts that expression into a normal buffer > >> instead of the minibuffer, the resulting behavior does not constitute a > >> less important inconsistency but an annoying regression. This is one of > >> the things that used to work "ever since". > > > > Can you tell more about the inconsistency you get in this scenario? > > I'm afraid I don't follow the description and therefore cannot try > > reproducing it myself. > Suppose I want to calculate the sum of two numbers: number-1 is shown in > a buffer on frame-1, number-2 is show in a buffer on frame-2. I start > typing M-: (+ on frame-1 then I do C-x o, mark number-1, type M-w, C-x o > and C-y to yank number-1 into the minibuffer. Then I add a space to the > minibuffer, type C-x 5 o to go to frame-2, mark number-2, type M-w and > C-x 5 o to get back to frame-1. > Ever since, that last C-x 5 o got me to the minibuffer window. With the > proposed change, that C-x 5 o will get me to the window of number-1 and > I have to manually select the minibuffer window to yank number-2 there. I think I can see where the problem is. I've even found the patch where this problem was introduced. I'll see if I can get a patch to you this evening to fix it. > martin -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed May 18 11:49:45 2022 Received: (at 55412) by debbugs.gnu.org; 18 May 2022 15:49:45 +0000 Received: from localhost ([127.0.0.1]:33285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrLvk-0002ZB-UU for submit@debbugs.gnu.org; Wed, 18 May 2022 11:49:45 -0400 Received: from colin.muc.de ([193.149.48.1]:46697 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1nrLvj-0002Yy-6W for 55412@debbugs.gnu.org; Wed, 18 May 2022 11:49:43 -0400 Received: (qmail 82461 invoked by uid 3782); 18 May 2022 15:49:37 -0000 Received: from acm.muc.de (p4fe15a4c.dip0.t-ipconnect.de [79.225.90.76]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 18 May 2022 17:49:36 +0200 Received: (qmail 19633 invoked by uid 1000); 18 May 2022 15:49:36 -0000 Date: Wed, 18 May 2022 15:49:36 +0000 To: martin rudalics Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Message-ID: References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at, Eli Zaretskii , acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Martin and Eli. On Wed, May 18, 2022 at 17:01:43 +0200, martin rudalics wrote: > >> When I type M-:, save the expression to evaluate from some other frame, > >> and the subsequent yank inserts that expression into a normal buffer > >> instead of the minibuffer, the resulting behavior does not constitute a > >> less important inconsistency but an annoying regression. This is one of > >> the things that used to work "ever since". > > Can you tell more about the inconsistency you get in this scenario? > > I'm afraid I don't follow the description and therefore cannot try > > reproducing it myself. > Suppose I want to calculate the sum of two numbers: number-1 is shown in > a buffer on frame-1, number-2 is show in a buffer on frame-2. I start > typing M-: (+ on frame-1 then I do C-x o, mark number-1, type M-w, C-x o > and C-y to yank number-1 into the minibuffer. Then I add a space to the > minibuffer, type C-x 5 o to go to frame-2, mark number-2, type M-w and > C-x 5 o to get back to frame-1. > Ever since, that last C-x 5 o got me to the minibuffer window. With the > proposed change, that C-x 5 o will get me to the window of number-1 and > I have to manually select the minibuffer window to yank number-2 there. Please try the following patch, which may solve the above problem without hurting the bug fix. diff --git a/src/frame.c b/src/frame.c index ccac18d23c..7869726850 100644 --- a/src/frame.c +++ b/src/frame.c @@ -1564,6 +1564,10 @@ do_switch_frame (Lisp_Object frame, int track, int for_deletion, Lisp_Object nor if (! FRAME_MINIBUF_ONLY_P (XFRAME (selected_frame))) last_nonminibuf_frame = XFRAME (selected_frame); + if (EQ (f->selected_window, f->minibuffer_window) + && NILP (Fminibufferp (XWINDOW (f->minibuffer_window)->contents, Qt))) + Fset_frame_selected_window (frame, Fframe_first_window (frame), Qnil); + Fselect_window (f->selected_window, norecord); /* We want to make sure that the next event generates a frame-switch diff --git a/src/frame.h b/src/frame.h index 0b8cdf62de..87c44dd22b 100644 --- a/src/frame.h +++ b/src/frame.h @@ -123,7 +123,8 @@ #define EMACS_FRAME_H /* This frame's selected window. Each frame has its own window hierarchy and one of the windows in it is selected within the frame. - The selected window of the selected frame is Emacs's selected window. */ + The selected window of the selected frame is Emacs's selected window. + This window may be the mini-window of the frame. */ Lisp_Object selected_window; /* This frame's selected window when run_window_change_functions was diff --git a/src/minibuf.c b/src/minibuf.c index 847e7be5ad..66aed0ad70 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -203,14 +203,6 @@ move_minibuffers_onto_frame (struct frame *of, bool for_deletion) zip_minibuffer_stacks (f->minibuffer_window, of->minibuffer_window); if (for_deletion && XFRAME (MB_frame) != of) MB_frame = selected_frame; - if (!for_deletion - && MINI_WINDOW_P (XWINDOW (FRAME_SELECTED_WINDOW (of)))) - { - Lisp_Object old_frame; - XSETFRAME (old_frame, of); - Fset_frame_selected_window (old_frame, - Fframe_first_window (old_frame), Qnil); - } } } diff --git a/src/xdisp.c b/src/xdisp.c index 6963935666..7e166121df 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -12796,8 +12796,10 @@ gui_consider_frame_title (Lisp_Object frame) mode_line_noprop_buf; then display the title. */ record_unwind_protect (unwind_format_mode_line, format_mode_line_unwind_data - (NULL, current_buffer, Qnil, false)); + (f, current_buffer, selected_window, false) + /* (NULL, current_buffer, Qnil, false) */); + Fselect_window (f->selected_window, Qt); set_buffer_internal_1 (XBUFFER (XWINDOW (f->selected_window)->contents)); fmt = FRAME_ICONIFIED_P (f) ? Vicon_title_format : Vframe_title_format; > martin -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed May 18 12:03:53 2022 Received: (at 55412) by debbugs.gnu.org; 18 May 2022 16:03:53 +0000 Received: from localhost ([127.0.0.1]:33295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrM9Q-0002w6-MC for submit@debbugs.gnu.org; Wed, 18 May 2022 12:03:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrM9O-0002vr-Ed for 55412@debbugs.gnu.org; Wed, 18 May 2022 12:03:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrM9H-0001zs-ED; Wed, 18 May 2022 12:03:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ng2Ut1h646iTfoVhdRj+ghkVxJbMta7nhL1eRf1qoaE=; b=QLZ1o5EY6VBw K1P9iIYMJs3Tsvr0ATPJSVuWVGB5jQ2y/e3szORUnrohWq0SBG5uK0ajAHGh+/P0K6aTsrfxBNZUF T3ZOPB0SiBF5eThZZLC48hrSWynMhEbuYw8vLikd2gicHD1iBBYgntHjRud450THIYeKCMqJs1GWo aT33kTbQrz2Wqsoa+36pC9qT54nxreSiuAD7WNGoWtFLNi5220QYYtur25COwb3M2W4Kp2MS4MQh2 AOz69i3gDaqEswEI59TWB4mORhFj/yddxhpy6yprKEcvaU0hRydTpTa5AqLvXBIoLuBNWV4L0snyc mDr4vGJxPUVw/nxd8h9gcA==; Received: from [87.69.77.57] (port=4189 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrM9D-0002pZ-Ae; Wed, 18 May 2022 12:03:43 -0400 Date: Wed, 18 May 2022 19:03:32 +0300 Message-Id: <83sfp6eskr.fsf@gnu.org> From: Eli Zaretskii To: Alan Mackenzie In-Reply-To: (message from Alan Mackenzie on Wed, 18 May 2022 15:49:36 +0000) Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, rudalics@gmx.at, acm@muc.de, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 18 May 2022 15:49:36 +0000 > Cc: Eli Zaretskii , 55412@debbugs.gnu.org, tanzer@swing.co.at, > acm@muc.de > From: Alan Mackenzie > > > Suppose I want to calculate the sum of two numbers: number-1 is shown in > > a buffer on frame-1, number-2 is show in a buffer on frame-2. I start > > typing M-: (+ on frame-1 then I do C-x o, mark number-1, type M-w, C-x o > > and C-y to yank number-1 into the minibuffer. Then I add a space to the > > minibuffer, type C-x 5 o to go to frame-2, mark number-2, type M-w and > > C-x 5 o to get back to frame-1. > > > Ever since, that last C-x 5 o got me to the minibuffer window. With the > > proposed change, that C-x 5 o will get me to the window of number-1 and > > I have to manually select the minibuffer window to yank number-2 there. > > Please try the following patch, which may solve the above problem > without hurting the bug fix. Thanks, but shouldn't this somehow depend on the value of minibuffer-follows-selected-frame? From debbugs-submit-bounces@debbugs.gnu.org Wed May 18 12:38:41 2022 Received: (at 55412) by debbugs.gnu.org; 18 May 2022 16:38:41 +0000 Received: from localhost ([127.0.0.1]:33351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrMh7-0003qC-6q for submit@debbugs.gnu.org; Wed, 18 May 2022 12:38:41 -0400 Received: from colin.muc.de ([193.149.48.1]:63431 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1nrMh5-0003pv-Un for 55412@debbugs.gnu.org; Wed, 18 May 2022 12:38:40 -0400 Received: (qmail 15243 invoked by uid 3782); 18 May 2022 16:38:33 -0000 Received: from acm.muc.de (p4fe15a4c.dip0.t-ipconnect.de [79.225.90.76]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 18 May 2022 18:38:32 +0200 Received: (qmail 19866 invoked by uid 1000); 18 May 2022 16:38:32 -0000 Date: Wed, 18 May 2022 16:38:32 +0000 To: Eli Zaretskii Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Message-ID: References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> <83sfp6eskr.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83sfp6eskr.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, rudalics@gmx.at, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Eli. On Wed, May 18, 2022 at 19:03:32 +0300, Eli Zaretskii wrote: > > Date: Wed, 18 May 2022 15:49:36 +0000 > > Cc: Eli Zaretskii , 55412@debbugs.gnu.org, tanzer@swing.co.at, > > acm@muc.de > > From: Alan Mackenzie > > > Suppose I want to calculate the sum of two numbers: number-1 is shown in > > > a buffer on frame-1, number-2 is show in a buffer on frame-2. I start > > > typing M-: (+ on frame-1 then I do C-x o, mark number-1, type M-w, C-x o > > > and C-y to yank number-1 into the minibuffer. Then I add a space to the > > > minibuffer, type C-x 5 o to go to frame-2, mark number-2, type M-w and > > > C-x 5 o to get back to frame-1. > > > Ever since, that last C-x 5 o got me to the minibuffer window. With the > > > proposed change, that C-x 5 o will get me to the window of number-1 and > > > I have to manually select the minibuffer window to yank number-2 there. > > Please try the following patch, which may solve the above problem > > without hurting the bug fix. > Thanks, but shouldn't this somehow depend on the value of > minibuffer-follows-selected-frame? I think it does. If minibuffer-follows-selected-frame is nil, when we return to a frame on which a minibuffer has been opened, the minibuffer will still be there, so there is no need to select a different window. If m-f-s-frame is t, and we have moved away from the frame on which a minibuffer was opened, that minibuffer will have moved to the new frame. It will either be terminated before we return to the original frame (in which case we select a window different from the now invalid mini-window), or the minibuffer returns to the original frame when we switch back. The critical criterion is whether there's a valid minibuffer in the mini-window of the frame we switch to. It doesn't really matter whether that minibuffer has moved between frames, or was always there. So, maybe this process is independent of minibuffer-follow-selected-frame. But I think it works. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed May 18 12:52:09 2022 Received: (at 55412) by debbugs.gnu.org; 18 May 2022 16:52:09 +0000 Received: from localhost ([127.0.0.1]:33371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrMu9-0004Ee-6Q for submit@debbugs.gnu.org; Wed, 18 May 2022 12:52:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrMu6-0004EI-Sh for 55412@debbugs.gnu.org; Wed, 18 May 2022 12:52:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34764) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrMtz-00018S-S7; Wed, 18 May 2022 12:51:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Y4HsHGon0vm67d26Vfi6roEWhOi+DmvDAhlz9VDIxeU=; b=NpIcH8XLX48h tl60a1gwlbaQCYQ5XAMxjLqLo5eCSnTW9skVWg3MiMoyVVpdh8Xk3e6hYiSK4PCcQt9SSC/DqOKCP vEm7h7N3eNcgsc3LEkH/w5Kq07ts1rDbItLMxUXBUkRAZs6BVS23LSvHVatL/1v3MmIq4mb8XrvIE OOpfKbpFZ07dnv6kvYnNn0Jd3fpwanrjDK1QfnpIkLp5k0NcEPfDufVBuNe8G/XfKFavmkOIFr4lH XrByTMh8LydeqkaAs3e1C1tLnMXzBfVbQU6KrfyXWaaxXFusVpsX+PuJMvv+AWKySPRx9W/osDPoY NkaC6rFAwsDpe1kQxVM3gA==; Received: from [87.69.77.57] (port=3335 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrMtz-0007FH-9r; Wed, 18 May 2022 12:51:59 -0400 Date: Wed, 18 May 2022 19:51:54 +0300 Message-Id: <83mtfeeqc5.fsf@gnu.org> From: Eli Zaretskii To: Alan Mackenzie In-Reply-To: (message from Alan Mackenzie on Wed, 18 May 2022 16:38:32 +0000) Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> <83sfp6eskr.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, rudalics@gmx.at, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 18 May 2022 16:38:32 +0000 > Cc: rudalics@gmx.at, 55412@debbugs.gnu.org, tanzer@swing.co.at > From: Alan Mackenzie > > > Thanks, but shouldn't this somehow depend on the value of > > minibuffer-follows-selected-frame? > > I think it does. If minibuffer-follows-selected-frame is nil, when we > return to a frame on which a minibuffer has been opened, the minibuffer > will still be there, so there is no need to select a different window. > > If m-f-s-frame is t, and we have moved away from the frame on which a > minibuffer was opened, that minibuffer will have moved to the new frame. > It will either be terminated before we return to the original frame (in > which case we select a window different from the now invalid > mini-window), or the minibuffer returns to the original frame when we > switch back. > > The critical criterion is whether there's a valid minibuffer in the > mini-window of the frame we switch to. It doesn't really matter whether > that minibuffer has moved between frames, or was always there. So, > maybe this process is independent of minibuffer-follow-selected-frame. > But I think it works. It would be good to have some of these explanations in comments there. From debbugs-submit-bounces@debbugs.gnu.org Thu May 19 03:18:25 2022 Received: (at 55412) by debbugs.gnu.org; 19 May 2022 07:18:25 +0000 Received: from localhost ([127.0.0.1]:34324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nraQT-0003RE-CX for submit@debbugs.gnu.org; Thu, 19 May 2022 03:18:25 -0400 Received: from mout.gmx.net ([212.227.17.20]:37763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nraQQ-0003Qz-HL for 55412@debbugs.gnu.org; Thu, 19 May 2022 03:18:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1652944683; bh=YfITvoHMHqZCaS8z6W7a0cFGp8X7G2FqjlL4UPiDj7Q=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=TGseiIEIZWSIsDDyA6mPToVATInP553tJh5pMxms8Zg/qYnX5L64ClEOeyXA2irCn yQMskX/gRkFGRCf/hVrsYYe/7XfNgY5M5xdRaPVV4pKc/gQokfZKwL3vtjlFWEJmHo DXio6OOOHTt2kCNC4/lC3iF9Azn2wd1K4IMKmxd8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.237]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MryTF-1nU3N01vO9-00nwVB; Thu, 19 May 2022 09:18:03 +0200 Message-ID: Date: Thu, 19 May 2022 09:18:01 +0200 MIME-Version: 1.0 Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Content-Language: en-US To: Alan Mackenzie References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> From: martin rudalics In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:9GFeekmzscHzad3QvAiddO85FHnvzMfFX9PwXkQzcaqNmvaIOrb xg3fZRPCOF57Djv/5+QIwncKkLpO0iYtwJ9WPUjcVC45rfYg20XMmXh6selMSUux0veS246 06OHN3bgGjb1amlzOoXXbqnxe8/43yen1RePvWHFsNiR4bQ5lp8b8fzd5B7J/XT+sgmQAkI m6zR3nfHRlJSVz1lJBO0g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/Rv1U5V+DY0=:mjUfTI3dsHGg41rPMH0BtJ U4HV5Bcio4tvS9aXJ8z9yQhl+fQ/wercOo7+LQtagxJ8U13+HqCqQQuki2s6SZp8D1oYlxY+N 8l4SgDK7yzUR1yjspxdWS/6o2MWB/OVoe6JQPoItxXFy2E+lso/dzdMi8RpUPdxBVJRzA8l3y amoaXezqMrVQqM54IWfhsT8SJW9ixqPzGbikvT7e0todP38lYWdVJQ6qU1QP1bwbllGt4HcHD Jv4cqcOV+uvs4hcb/HZ378KUftNCG1jY6IimKPCLrRtLyb4VBXCIqumKo9qYooI2sbOigTDW0 KPgLfEAz4NIYavvNUA/KPBbhBhTdEFRKOWpx5tXh0/AnNt4SKpA8zCQWIpT3zIlIr5fGYd+vV ANRWBXRu6RnnRLz6D2tQHXuAa4HmW1pleicpTJy56qhM7+htJgxkNeClqaGDoIvZm8jBv75PP NhrR1ANGZ32uYSKivMLt6g6F+8/0MXsDJum2ZJ8GvyCloY9Lnw2P3jXM8d+av/q7j29XFAC+H qeTNxh2B1+gkJtOFyChZn+s6BnycMCBVmDHB5qKMuwJHACCw9bqY3TKlVoNWjGtiHgbxkO8aT jb7JvBguUXgfveH+Ovz1TS2LMqOj/LicTLaOLfw6dExlDbA2L1mDYOKRPBNCWVV63u2akxG7q +tyDe+5PlHy6sMZ38vjGWSnP0oe0vJlDN2Ng+ZpAQxV2aowyGXCh6xLo17Hu0cVCVpA0H9CQv QVE1mBGY3M2lyuO0VOCdi3AvKmeEJLQU7cl0jSRTxqlWf4cQh1YIAGPrUFOa7CGcWn7rzDE59 R3Z5a38YVnm2j9b1MVAG7wKFanVyhEII3C2f87IVMf/pNJyt/DR9DYZtIEejFlou/LuSz30rD 3ZFekAT7T7o09PWwdSrdQMiw4HpVvBlhKrxtBfrSuXBPAj8Y1Yp7tTcYuW9+CY3Nd5MSQk0ht fv7xDh1sI+O+4MHW+6z21RajmZTsCelmrB7p1tMHMNiK3J4MGCfD8fYn4/lvcF004Hk8nDmiy XhUsIkdtUYQKAL0O9aRTnEhtmsqqYq5+K6TmUt/0Wed3zhRHhKUshDloh8xqW3U1tJFDpUTVd LuQVTRX/56/aGT1Kkt4bjXQ/klKPPejERPpC07BS7edw6NZSmOnjqALDw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Please try the following patch, which may solve the above problem > without hurting the bug fix. It solves the above problem here. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Fri May 20 04:23:52 2022 Received: (at 55412) by debbugs.gnu.org; 20 May 2022 08:23:52 +0000 Received: from localhost ([127.0.0.1]:37493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrxvM-0003n3-3N for submit@debbugs.gnu.org; Fri, 20 May 2022 04:23:52 -0400 Received: from mout.gmx.net ([212.227.15.19]:39685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrxvF-0003mC-Tp for 55412@debbugs.gnu.org; Fri, 20 May 2022 04:23:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1653035002; bh=HEW5B1mGM+B7DYUklbqfNFrgZeaxonho3gosEdDQG9Y=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=Qp5Abe2jguWJlfV4RD6tAz3jzTnpOWGFgPi31oUTTL8eDXAwQLrMowCjl1GMNeNqc hKk9GHBFJhC1WHrtGI2fZPIQ7uHoU5AEWSJrpw5ahKksJHLMRxbPINjqQspIbO/u+B sLfMgwyvQ44ApNOJHQXELFGIU7lojy9z98p9zEpE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.124]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MiaY9-1nLOBE3GIJ-00fmpm; Fri, 20 May 2022 10:23:19 +0200 Message-ID: <408f7b88-2000-bd10-bd9d-4e06018e8ff0@gmx.at> Date: Fri, 20 May 2022 10:23:17 +0200 MIME-Version: 1.0 Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Content-Language: en-US To: Eli Zaretskii , Alan Mackenzie References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> <83sfp6eskr.fsf@gnu.org> <83mtfeeqc5.fsf@gnu.org> From: martin rudalics In-Reply-To: <83mtfeeqc5.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:SjpcB9gpuca8GmBO4FDwEcpRGG2J93itpMUv6jTmtwgePhTCXEG Nq9dYdMzvVah1pnJTpsoApxrXNvUdBuBlz9lBGjGPa4CIkPVk4DKqaEktumvrHg7NXCXRd8 GiyRruY/K//hP/DQLNgOM2ZynaRwTa2gjMueIpsLYUHpdj4WnjjHAjNz6+L+0yu94wYW+Tt lv5HaZbZFfIGpYR1oTxNw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:8McwQb51cx8=:IPLSVTx6eP4aAhe5Sw1rE1 Fbmm2dRCaL5TdJSHcbHX990/ApEAt34VmFfluWdzm2oj/Gm8P0W1gwkPZXyFdgjib0dnKLoAV ILtZUhj/YQZflmlZE6BeyK5QF9KhDf0hmoeHrORylsfKlrEB38vnlTaQEFJNBVItndkOU5WZG /+1s+h4CP0yYhSVuJrRA/w8bty87dt9q2a7emAonLXt34m+DXfW5AwvW0Z4UDJ8P3JceFUf3T 5Zpjf5aen94tdW9/QyBl5tLv+9oKJN1DhY6LZdcsIYhDHYGzfwqsflU4BHuw2M+OYJmUrO+g2 pwxltI9wAgm5+LHdMmcAUuC0IEOczmBPT4Ivxb6v0J31Tp5KOYJs8HQ7ztc3H9dLaMe28zH8I YL+rau1QxjxYAUA7+UuEWtvp0rZo21PUPbIqmOHsdw9XvoTwECOeKn7S1xUJaBEvw0laSfpU/ Lxfhc1RG0HhueNm4HCCox0NivrGE4ItAAyAvgpaXJ6VPRqWDO578iyHPStxaxhHcjHWRbh3s3 uGlN6Ug7CMzkHscHva18OvaCXhLgO/P6daQPTUytFAqUMJffKR7FL1JPqbg35WkYW6eMeHa2Z QhxNs94mXBN1FSDZKioz/c8kd0jE4tGj90HZUyLQim3MgX41hv7Vj8lu2aeVkoVshnz+vvk1z +C256DkhHy20iw+ajrMDzpM5gqd3PhWDoJ4Ijmh8axvVtK7x51kn6VXCtK+L5PSggCRI9AgSl 8NpPilvNuafDOHk+qEY7Ly8bhl+EFM4a9SKLUtKHklSyYjWONlsaUpR0dnR9HtLP7UPjrcJvL WhJk83dZuyP4T6DmDIlIii+GdpiYimmZDPItV49GRjtmrXGS6h/a4bKAY+sse8JilK52G9g7S sHXJONmiddzjn7L7ZojdJuMl4WwDBXEcrkfRc8SfOPSA93z0m7EROcwB5KZ91JUJo4b9+EgrT 9CimI2XrNqzsxo1stEmflbrQukJnGlhPcnEKKzihgwqlqN9GoTYOySn/ysHCbN0d/GE78vjPG TBrNnRB1VLu+i1xltnNYC6J/Eq5arRj/rGrHHBeMkHJDjqOljQ7e5lgT9sQaW4szsUjzlJf6Z sngS4/0rywM/02HKez6SgcESy6gW5nn/Ms5mkOUoXDkz/z5/IJVsePVUA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > It would be good to have some of these explanations in comments there. I understand that we want a quick solution for the present bug so it can be included in Emacs 28.2. But I still don't understand why nobody even cared to try the patch I sent earlier. With the current code, whenever there are at least two frames present, 'gui_consider_frame_title' calls via Fselect_window among others redisplay_other_windows Fredirect_frame_focus resize_mini_window move_minibuffers_onto_frame and sets last_nonminibuf_frame internal_last_event_frame Has anyone ever tried to understand the implications of all these? Why should redisplay indiscriminately set 'windows_or_buffers_changed' when recomputing the frame title? Why should we try to redirect frame focus which is already sufficiently hairy by itself so hardly anyone really understands what it does. Why should formatting the frame title try to resize a mini window or move minibuffers onto the selected frame? Why set last_nonminibuf_frame which might affect 'display-buffer' and apparently relies on some internal kludgery to set it precisely to the same value it had before title line formatting started. And why reset internal_last_event_frame which also appears complicated enough to not touch it unless you know precisely why and when. Similar things happen with mode lines display - unwind_format_mode_line apparently can call Fselect_window up to three times in a row with the implications sketched above. When trying to fix Bug#32777 I spent some time investigating these issues but never found out why on earth we should call routines like 'select-frame' and 'select-window' from redisplay. If there is any rationale for these, it should be explained in comments first before moving on to explain why moving minibuffers between frames can go awry. martin From debbugs-submit-bounces@debbugs.gnu.org Fri May 20 06:58:57 2022 Received: (at 55412) by debbugs.gnu.org; 20 May 2022 10:58:57 +0000 Received: from localhost ([127.0.0.1]:37710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns0LQ-0004VR-T3 for submit@debbugs.gnu.org; Fri, 20 May 2022 06:58:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns0LP-0004VG-2r for 55412@debbugs.gnu.org; Fri, 20 May 2022 06:58:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37272) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns0LH-0003V9-UJ; Fri, 20 May 2022 06:58:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vr+OE/zqZSUr/rp2USafeF6H3ZmiJTj4xBL8/rfHC1I=; b=ikw7PIVs3zx3 glOcbaM/b+MgGnp4hArx95dg22z8aPZI7ga2dX036NxZu6XBHN1Bxa/AOKmIlPXPzsLYteiiJeLgB JcVNjkMWVlEXtgfTY2nplj0T/4jyLCkEMLwXcP5Kh+euOg2qaWYE2G6NRvINzz+kfsqoE0LjDmi/S B7EXPr7gyvXNkHX6zZJRoWO/mhbQa2ckcce28d78frRfgVYj8ZvB5Xdi0ONhL/NqNgRbX0JvEGbAN +Xs4mxrUZ3J8gpma/+91VrUnIZwxaekOFsZT0cDMbTSsPA5Ox5WhowOEfeaezTgDjR3VDhmskxb0i Rx2+n2cjeBuldaadtXHfRw==; Received: from [87.69.77.57] (port=2956 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns0LG-0007bz-QP; Fri, 20 May 2022 06:58:47 -0400 Date: Fri, 20 May 2022 13:58:45 +0300 Message-Id: <83k0agbhcq.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <408f7b88-2000-bd10-bd9d-4e06018e8ff0@gmx.at> (message from martin rudalics on Fri, 20 May 2022 10:23:17 +0200) Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> <83sfp6eskr.fsf@gnu.org> <83mtfeeqc5.fsf@gnu.org> <408f7b88-2000-bd10-bd9d-4e06018e8ff0@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, acm@muc.de, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 20 May 2022 10:23:17 +0200 > Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at > From: martin rudalics > > > It would be good to have some of these explanations in comments there. > > I understand that we want a quick solution for the present bug so it can > be included in Emacs 28.2. But I still don't understand why nobody even > cared to try the patch I sent earlier. I don't think I understand what patch that is, but we could install different solutions on master and the release branches. In general, I prefer the old code to a new one, because the old code by definition keeps old behavior, and thus runs lower risks of breaking something. But I won't object installing what is deemed a better solution on master, even though it is riskier. > With the current code, whenever there are at least two frames > present, 'gui_consider_frame_title' calls via Fselect_window among > others > > redisplay_other_windows > > Fredirect_frame_focus > > resize_mini_window > > move_minibuffers_onto_frame > > and sets > > last_nonminibuf_frame > > internal_last_event_frame > > Has anyone ever tried to understand the implications of all these? Why would we need to do that? This code was there for many years, so its effects are by now a de-facto standard behavior of Emacs. We don't have human power and resources to revisit those decisions unless someone submits a bug report, or unless some deep refactoring or reimplementation of the code is taking place. > When trying to fix Bug#32777 I spent some time investigating these > issues but never found out why on earth we should call routines like > 'select-frame' and 'select-window' from redisplay. Well, now we know at least one reason: so that referencing frame-parameters would what Lisp programs expect. From debbugs-submit-bounces@debbugs.gnu.org Fri May 20 07:33:54 2022 Received: (at 55412) by debbugs.gnu.org; 20 May 2022 11:33:54 +0000 Received: from localhost ([127.0.0.1]:37809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns0tG-0003cC-5H for submit@debbugs.gnu.org; Fri, 20 May 2022 07:33:54 -0400 Received: from colin.muc.de ([193.149.48.1]:19403 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1ns0tE-0003by-Fy for 55412@debbugs.gnu.org; Fri, 20 May 2022 07:33:53 -0400 Received: (qmail 85922 invoked by uid 3782); 20 May 2022 11:33:46 -0000 Received: from acm.muc.de (p4fe15826.dip0.t-ipconnect.de [79.225.88.38]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 20 May 2022 13:33:46 +0200 Received: (qmail 6042 invoked by uid 1000); 20 May 2022 11:33:45 -0000 Date: Fri, 20 May 2022 11:33:45 +0000 To: martin rudalics Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Message-ID: References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> <83sfp6eskr.fsf@gnu.org> <83mtfeeqc5.fsf@gnu.org> <408f7b88-2000-bd10-bd9d-4e06018e8ff0@gmx.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <408f7b88-2000-bd10-bd9d-4e06018e8ff0@gmx.at> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Martin. On Fri, May 20, 2022 at 10:23:17 +0200, martin rudalics wrote: > > It would be good to have some of these explanations in comments there. > I understand that we want a quick solution for the present bug so it can > be included in Emacs 28.2. But I still don't understand why nobody even > cared to try the patch I sent earlier. My apologies for not being aware of it. Your post from last Sunday with the patch was before I was in the thread, and I missed, in your references to the patch, that it was a recent post in this thread. I've just spent about an hour perusing the patch, and have the following observations and questions. The patch is too large to go into the emacs-28 branch, so for a "quick safe fix", we'd still need the smaller patch I posted a small number of days ago, or something like it. with_window_selected is not re-entrant, since it uses a static data structure. Is this deliberate, or just a case of not yet making it re-entrant? I get nervous when I see "selected_frame = ...;" or "selected_window = ....;" outside of do_switch_frame or the corresponding window function, since it means selected_{frame,window} have been set without regard to all the other things which must be kept in synch with them. At the moment, all these "wild" settings of selected_frame are in xdisp.c, which I suppose has special reasons for them. with_window_selected would add another "wild" setting of selected_frame, this one outside of xdisp.c (in window.c) and I ask whether or not this is a good thing. I think the root of the problem your patch is trying to solve is that the same C code is used for implementing C-x 5 o and lower level, temporary, frame switches. If this is the case, a good way of proceeding would be to refactor do_switch_frame into a function appropriate for lower level C calls, and the remainder for C-x 5 o. For example, the call to move_minibuffers_onto_frame is clearly needed for C-x 5 o, but is a complicated nuisance for lower level C. With such a new extracted C function, we could replace the "selected_frame = ...;" in xdisp.c by calls to this function. Maybe. > With the current code, whenever there are at least two frames present, > 'gui_consider_frame_title' calls via Fselect_window among others > redisplay_other_windows > Fredirect_frame_focus > resize_mini_window > move_minibuffers_onto_frame > and sets > last_nonminibuf_frame > internal_last_event_frame Yes. It also clears f->select_mini_window_flag, which I posted a separate thread on emacs-devel about. Here I think the problem is the same as above: Fselect_window is a high level function for doing things like C-x o, but we really need a low level function with which we could do a controlled temporary switch to a different window, without the unwanted complications of move_minibuffers_onto_frame etc.. > Has anyone ever tried to understand the implications of all these? Why > should redisplay indiscriminately set 'windows_or_buffers_changed' when > recomputing the frame title? Why should we try to redirect frame focus > which is already sufficiently hairy by itself so hardly anyone really > understands what it does. Why should formatting the frame title try to > resize a mini window or move minibuffers onto the selected frame? I think my analysis above might point a way out of these problems. > Why set last_nonminibuf_frame which might affect 'display-buffer' and > apparently relies on some internal kludgery to set it precisely to the > same value it had before title line formatting started. And why reset > internal_last_event_frame which also appears complicated enough to not > touch it unless you know precisely why and when. > Similar things happen with mode lines display - unwind_format_mode_line > apparently can call Fselect_window up to three times in a row with the > implications sketched above. > When trying to fix Bug#32777 I spent some time investigating these > issues but never found out why on earth we should call routines like > 'select-frame' and 'select-window' from redisplay. If there is any > rationale for these, it should be explained in comments first before > moving on to explain why moving minibuffers between frames can go awry. I don't think redisplay should be calling Fselect_window or do_switch_frame at all. Instead we should call (not yet existing) lower level functions. > martin -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Fri May 20 08:11:05 2022 Received: (at 55412) by debbugs.gnu.org; 20 May 2022 12:11:05 +0000 Received: from localhost ([127.0.0.1]:37874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns1TE-0006oJ-Um for submit@debbugs.gnu.org; Fri, 20 May 2022 08:11:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns1Sy-0006nW-FZ for 55412@debbugs.gnu.org; Fri, 20 May 2022 08:11:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns1Sr-0007xA-R6; Fri, 20 May 2022 08:10:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nUFcCQGcpbeMOLN4jucmCQFvE//MS8uv0Dak9mhvf+o=; b=m2rElqTmqiXn FJZLZNVD6nVrZPTo+8qOntO1FYaTJr8DJBF0gNSOqz5f4JUX7vC6vYs83y9e0ZFMOjD0Fjxw3yg6L 9984Hml76l2plzeJ85KZXB7gVKVGHDJpeeuBfU6asgmsXAtkWxvN2vM/A3pHkUKEIRg/dnwbBjJpX ztrnpmKRIvPFsrgmDElDQyuqlH+mwLJNf0XWLttzPQOPcxUi4wLaF9GUHuB2WVHc4ommdnDBvc+Ma 9X+KuUYlZShcna6P3b1y2/AuYmdHuOAYDAfvJPfE+axq/fDCwKKYJnlUt25tGg0lRyO8RF8/R8DgK 9byQ2mm+WoO7WxhphPYUDQ==; Received: from [87.69.77.57] (port=3390 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns1Sr-0006N9-9O; Fri, 20 May 2022 08:10:41 -0400 Date: Fri, 20 May 2022 15:10:40 +0300 Message-Id: <837d6gbe0v.fsf@gnu.org> From: Eli Zaretskii To: Alan Mackenzie In-Reply-To: (message from Alan Mackenzie on Fri, 20 May 2022 11:33:45 +0000) Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> <83sfp6eskr.fsf@gnu.org> <83mtfeeqc5.fsf@gnu.org> <408f7b88-2000-bd10-bd9d-4e06018e8ff0@gmx.at> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, rudalics@gmx.at, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 20 May 2022 11:33:45 +0000 > Cc: Eli Zaretskii , 55412@debbugs.gnu.org, tanzer@swing.co.at > From: Alan Mackenzie > > I don't think redisplay should be calling Fselect_window or > do_switch_frame at all. Instead we should call (not yet existing) lower > level functions. Assuming those hypothetical lower-level functions will do enough of Fselect_window to keep the semantics, I don't object. From debbugs-submit-bounces@debbugs.gnu.org Fri May 20 16:39:15 2022 Received: (at 55412) by debbugs.gnu.org; 20 May 2022 20:39:15 +0000 Received: from localhost ([127.0.0.1]:40179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns9P0-0001p1-PV for submit@debbugs.gnu.org; Fri, 20 May 2022 16:39:14 -0400 Received: from colin.muc.de ([193.149.48.1]:27469 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1ns9Oy-0001on-O2 for 55412@debbugs.gnu.org; Fri, 20 May 2022 16:39:13 -0400 Received: (qmail 60359 invoked by uid 3782); 20 May 2022 20:39:06 -0000 Received: from acm.muc.de (p4fe15826.dip0.t-ipconnect.de [79.225.88.38]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 20 May 2022 22:39:06 +0200 Received: (qmail 9829 invoked by uid 1000); 20 May 2022 20:39:06 -0000 Date: Fri, 20 May 2022 20:39:06 +0000 To: Christian Tanzer , Eli Zaretskii Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Message-ID: References: <838rr4kq56.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <838rr4kq56.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, martin rudalics , acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Christian and Eli. On Sat, May 14, 2022 at 19:58:13 +0300, Eli Zaretskii wrote: > > Date: Sat, 14 May 2022 15:45:10 -0000 > > From: Christian Tanzer > > ;;; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work like it > > ;;; used to in Emacs 27 and earlier. In fact, it is completely broken, if one > > ;;; uses a frame-parameter in ':eval'. [ .... ] > Thank you for your report. > Alan, this is due to one of the changes introduced for the > minibuffer-follows-selected-frame feature. Specifically, commit > 7c2ebf6 made a change in gui_consider_frame_title which causes this > regression. If I revert a part of that commit shown below: [ .... ] I have now committed the patch from Wednesday (slightly amended) to the emacs-28 branch at savannah. This should have fixed the bug. Christian, if downloading the latest version from the savannah server is inconvenient, please let me know, and I will send you the patch by email so that you can patch your own version of Emacs 28. [ .... ] > Thanks. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 04:33:04 2022 Received: (at 55412) by debbugs.gnu.org; 21 May 2022 08:33:04 +0000 Received: from localhost ([127.0.0.1]:40664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsKXo-0007wA-NL for submit@debbugs.gnu.org; Sat, 21 May 2022 04:33:04 -0400 Received: from mout.gmx.net ([212.227.17.21]:39163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsKXm-0007vZ-Cx for 55412@debbugs.gnu.org; Sat, 21 May 2022 04:33:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1653121962; bh=4tk7u1HfJlbF9m8WF7BTEoRPNnWNQayj8TfSrkWO824=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=UTJNBR5TafGauwWw+zI06BLMYwM3Kdv4Xap57QAHi3HpQrCGzxrMgsf9gne4PtQkU 1jdoewkQk6yLGfOlHfAj45OePPHxF/y1xq9XOgJx3C6vyHMKSRVogPONO+7E8uf5r/ exStTeQAhn6j85BEIEQ1F5lRFCG1ayeGTcuwynfk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.31]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MS3il-1oHOSX2VGV-00TV46; Sat, 21 May 2022 10:32:42 +0200 Message-ID: <30699594-f491-07af-fd87-dabab35d71e3@gmx.at> Date: Sat, 21 May 2022 10:32:41 +0200 MIME-Version: 1.0 Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Content-Language: en-US To: Eli Zaretskii References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> <83sfp6eskr.fsf@gnu.org> <83mtfeeqc5.fsf@gnu.org> <408f7b88-2000-bd10-bd9d-4e06018e8ff0@gmx.at> <83k0agbhcq.fsf@gnu.org> From: martin rudalics In-Reply-To: <83k0agbhcq.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:jR4kV4TCuLlR/ublAqFBNgVsZUphgLqVUW3ux5956z3unaQabBw b0Wy98EpRVDAseRD//jSRMG/inICgDVhf57lt6JCtVZJGu8Dm2bv9g2jR5ww+6Fr2kM8tsF MzO6e/R/B3btkG9tjBeWFsQvi/dF3q5aHTvZ5MkZ/6z7LI9OGccZCKlYyTWe6c2yg2w+X43 oOxPDxYsKWeahmUJW3K3g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:FmW8wZO9T+Y=:K3+m0EMuRv7v9ht8b/kjNf 45dpfb3AVTUe2CDtRaO82QqOb+jMFo80DM/vv8T8eRTm6ifhBc2u6o4SW7MbWIzlfFveUvik6 GG3Vp/UzN9vw+xhUGeBtzCQqdAIIImJ8jVmc8IpVNZZivGvlHbsMTvhuXHVW8DIVZ9GSEgkh/ bCi4tVuDL6lRNNvf76aExw1FgepC48R25NPBkCaYk8kfo37BmRv8J3IRJ316wzokpTBRk6hQC MyHX6pw0AinfBH+uoLjo80m2Mh/dP644B/b3/FBULjEokYkBVHUn8A75kHpsHOnb2fQrwDuRq XFM6R5+XPQ8xzJM69DOUCw420sU2zg+P0aU+phWfP6PsnyZgoZJKhpSWj2d/ChgFJtOT+okJa WRm+vNC/9dgYzS8gEPErMTQ1Ay9DPy6LIB0fetXx1bsMRMFgBQfCi8FzmK3bWSZfKo1IyzTFZ Kpnc6GGmVli2nnvdWo3XwfcVDH+YJdhK6j3X88SDAhz7d7SUAHAOD6Ll6HWzyj5GsEhkMiYoA W6+OnKjP/EsSW6Ne8GDKjx/9U1UN0QvQy+af8lvfC/QnaX2LmUBrioQB7juHTG6g6UKq9L53v nLgVCGo2rZHn3gyRAFhE4Oj8bynlCnuh0yE5E+LDBOtLB3uyA6O48IB18+M3u2BJdjdvZkyEO thBBdHipf5h/qG6mlBNJH3IRGGgH/ucYm0Xeho61VUd9FMySMBGwm8/Jbr2r3WypHeyMCrRf1 7O8YWEjPSHUnfmYuaWM1SO+E81FYLIsQpOlYtjWGkzc0FUAm8YEEFFhHIUPJYppW+SMZJPjZP 31TQWP384NTjLe5POSAcFtFFRzR0GDUrQHpYJgoxW5rtP4pce7AqytEktWIboNVOAFsh9vdH8 S5Cbk6AI3irqhcra8Vfg8DhGQeiH5DWQ4PSJQCz2fvXbwc0oWa+67U6vX0K7VMTxDCWCjbarC pka5r7DsrVyTMLUE1C+uLWI595QUCc8ThUQIq3v/Spw4BNdkxYx8E+3nH0/WkrtNh0mhqE7gC SSQqnV8E4CllTKteQC/c0D2EenKJbtFF3iAY4gWZ81MwOt9cYGC7WkAZfX41aHwr6NesaRKCC eJ5VUbmd1UpPfiFR3EHNvuRMeOA9xdAuUYh2xmEoxcRIqmvkDqVclzq3g== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, acm@muc.de, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> When trying to fix Bug#32777 I spent some time investigating these >> issues but never found out why on earth we should call routines like >> 'select-frame' and 'select-window' from redisplay. > > Well, now we know at least one reason: so that referencing > frame-parameters would what Lisp programs expect. I don't understand what you mean here. Please elaborate. martin From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 04:33:09 2022 Received: (at 55412) by debbugs.gnu.org; 21 May 2022 08:33:09 +0000 Received: from localhost ([127.0.0.1]:40666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsKXs-0007wN-SV for submit@debbugs.gnu.org; Sat, 21 May 2022 04:33:09 -0400 Received: from mout.gmx.net ([212.227.17.22]:47271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsKXn-0007vb-9W for 55412@debbugs.gnu.org; Sat, 21 May 2022 04:33:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1653121972; bh=XBqIbaGljRx1X4E/AwmShiDDPeIovEU3cdHw0mFMUDY=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=LP0VW7kov1hePo4ksLKGkAF5T4E3ISsq8XbmyaOzutvN7eQ7SYXnkWDLEoyXdjZFN 5To5p32jv/zRQQmK1GzCK3q7QnUWTeKWxfpU1Z6JNxBH4b+nYVESg8wK4coX2twREF T2FVrlrnzMy6GNWHys7zeZ2akKhLWZr6yaDc1ZBE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.31]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MtOKc-1na7hd3N2E-00utgk; Sat, 21 May 2022 10:32:51 +0200 Message-ID: <5b197424-4849-9771-ff1d-41b7a8295ba2@gmx.at> Date: Sat, 21 May 2022 10:32:51 +0200 MIME-Version: 1.0 Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Content-Language: en-US To: Alan Mackenzie References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> <83sfp6eskr.fsf@gnu.org> <83mtfeeqc5.fsf@gnu.org> <408f7b88-2000-bd10-bd9d-4e06018e8ff0@gmx.at> From: martin rudalics In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:k0veoLrRZKJkS8f2stESpc7Ai4c3DMt0Cio9e4SnbZhEtJCHQgL SGjnpwbBdRAEzkmbzAB29I03ycJTMakFCPtxTg8uYBjjlN4qVRg1fIcvFpKKaESTTRWb+OK wPX2mlLpliWHzodpBZ+Biixc7gaLPfGzctxx4n4CRLAjSjrr0QFN0hUNcL6fvGsLfNcCr1L EkHAXE3gAoCanw2RCRouw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:8zoGq8alH/I=:eAM4wf5UgMKmdOIqJqysG2 LSrbtjq9mFHNxJjKNH1wq6ASrJHjSaJJap4Qy4CJoexCdE0BixJ94HuXOOOZL5GX0EQhGjpoc 0LICHMhqullienyafGvqnnvVpm9rpN5RpYG6mIo8cAd9mC2A0rQboZyOEszzp07tk8f7Xv8Hl kZoB73GylGAW2pyMwVlK3cTvfs9B2kMj7T191j41VQyaZJKCw4CtBa9UNd78iRKq3tEOkFz9Z 1Zg45DZSLqHSDPOAe9EY0o+TBrkrBxvQnbptx4Ce5Xs/zQnnthnPwdhxbGUh0AX2k6xjN0bJR 7HV62IRVKszQJRfjSi9lLoeuqJ8yid9Q5PXQmf6rw5RHxbk/EXeKVWxjHv/jHsOFMEnAyIVJO cO+rw9QND3GNcqmNyWLJ4G3zLXva0+Ge6BUb8BMCkMuyV609Hj1kPQeDlQ1FTaGS7Xlkjex92 kM0kisKg82HXovlMgPIHvYbOyING2uTGszkUTFoL2cVffAPC120uScNpkludyP368pK4KiE91 R11thhgekRRs9IYGt98cSCWCPP6w8WDxQiPMarxkEhvQcZsS+jniSYzvMAsQKiM1BvbFnURky 2VBlM2/0ROVqv7LGiTzKqBa6tmj4qNgCf6az5szPqt0L1O0bmftfe50BKEGU/xo0rLzo4odVA 8Mp8xpE4ClnGYo6vYyDBcugX9XVVtDz1Tf4D2UpR63HcqDHwEDmoe+Z4T3T9jirk3rnUjbleS gFlepUuZmpqucMii3LZ9PPHx8z3cpDu7keyfSZHJB4CX3lL9QKRDCh+lofiVar1EpitbXe78b YMEHCcbXagkez1e4vYMRMaNc0pCP3lS+VSNogYlM4dmNidNWikqru0ZvrVktp0WnHbTfx5vaq RROPFq6nlpmleQcfxvE7x2jg1TNhAHm3TdhJz95jymKPFrlpzirincvRiDnuW621qOsLN+Wrk a0EceftYAInTWWiYFPlYkgCVB7IeGAyimhMjxxx0/YLQdRN+gakMB8YSH9UDiyfmmihgTiNIf SKo7mRX3jH7ShaqUR0lFH0JNFAJNBYJRZY/mLTSvffLB07dIRPIoRjVoA/50Jj1ULukqE18zq 6nDA2kjW6EQpdqbimHfkRemA4gypk0oNvXng195EFbnJ49StYJ+sXphXA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, tanzer@swing.co.at, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > with_window_selected is not re-entrant, since it uses a static data > structure. Is this deliberate, or just a case of not yet making it > re-entrant? You mean Vwith_window_selected_vector. It's deliberate, just transferred here from 'format_mode_line_unwind_data' which did the same. Apparently the overhead for allocating a new vector during redisplay was deemed as too expensive for making this re-entrant. > I get nervous when I see "selected_frame = ...;" or "selected_window = > ....;" outside of do_switch_frame or the corresponding window function, > since it means selected_{frame,window} have been set without regard to > all the other things which must be kept in synch with them. At the > moment, all these "wild" settings of selected_frame are in xdisp.c, > which I suppose has special reasons for them. What concerns me is that xdisp.c sets selected_window and selected_frame in the first place (also due to my attempts to fix Bug#39977). My patch removes them all. This part of the redisplay code has been mended over and over again in the past years, adding all those "special reasons" you mention. > with_window_selected would add another "wild" setting of selected_frame, > this one outside of xdisp.c (in window.c) and I ask whether or not this > is a good thing. The canonical function to set selected_window is the static select_window_1 and that's in window.c (with_window_selected sets selected_window too but that's only a minor optimization). > I think the root of the problem your patch is trying to solve is that > the same C code is used for implementing C-x 5 o and lower level, > temporary, frame switches. If this is the case, a good way of > proceeding would be to refactor do_switch_frame into a function > appropriate for lower level C calls, and the remainder for C-x 5 o. For > example, the call to move_minibuffers_onto_frame is clearly needed for > C-x 5 o, but is a complicated nuisance for lower level C. With such a > new extracted C function, we could replace the "selected_frame = ...;" > in xdisp.c by calls to this function. Maybe. The redisplay code has to temporarily select a window also when there's only one frame around in which case do_switch_frame wouldn't enter the picture at all. with_window_selected handles both cases. > I don't think redisplay should be calling Fselect_window or > do_switch_frame at all. Instead we should call (not yet existing) lower > level functions. That's what with_window_selected and its unwind form have been designed for. Basically, any such code has to guarantee invariants like: - The selected frame's selected window is the selected window. - Code run within with_window_selected can rely on the fact that the selected window's buffer is current. Moreover, the code has to guarantee that selecting a window correctly sets up point from the window's point and stores the old point in the previously selected window#s point. And it obviously has to guarantee that the involved buffers, windows and frames are alive when switching to and back from them - things redisplay had always problems with (confer Bug#47244). Not reliably doing all these things in one place easily produces bugs that show up only in sessions that run for a long time and are consequently very difficult to debug. One major advantage of with_window_selected is that then one can debug functions like 'select-window', 'select-frame' or 'redirect-frame-focus' without being continuously hassled by redisplay which here accounts for nine out of ten calls of these functions at least and eventually caused me to abandon a number of fixes for say Bug#32777, Bug#39977, Bug#24500 and Bug#24803. martin From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 04:36:20 2022 Received: (at 55412) by debbugs.gnu.org; 21 May 2022 08:36:20 +0000 Received: from localhost ([127.0.0.1]:40672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsKau-00081Y-Ee for submit@debbugs.gnu.org; Sat, 21 May 2022 04:36:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsKaf-00080m-3y for 55412@debbugs.gnu.org; Sat, 21 May 2022 04:36:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49102) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsKaY-00042u-3M; Sat, 21 May 2022 04:35:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YrPvC2sUOkh1+h2EmBWiICPR7LrHz79jrdYAo0S/zVw=; b=r0uGQ4oo9p84 rs0atw8rkGPBNlVp5RoYHAF5dF/8qRDAIS4BRf+gYWX9uwKK6tIkQNTtKWBz8/HkCFRyVLxVyWI9Y O5SI3/Ddtjp9ATdDm2YkkSjMqwhjXQ6p10QKNxNMzfghYD879Es9G8sOkCHXy10/1lOjo+SaIvJ/T SOhH2VqyBVrSvtBJyK4P4IBLyLfoKb2LtX8zeF6XdM6NM6ddTl+gDTTRJTaVfGEauB20J4nWLH7Is kHTrrpeARhv92oy2Arq8uGwTMpz1sLNFB3tKqm1VORxXqBpOa/iTccQm18bo97B+cGEYnKgWu19M7 oOePT41wYOD4he6LgfIi8A==; Received: from [87.69.77.57] (port=1049 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsKaX-0002Lr-Jm; Sat, 21 May 2022 04:35:53 -0400 Date: Sat, 21 May 2022 11:35:47 +0300 Message-Id: <831qwn9tb0.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <30699594-f491-07af-fd87-dabab35d71e3@gmx.at> (message from martin rudalics on Sat, 21 May 2022 10:32:41 +0200) Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> <83sfp6eskr.fsf@gnu.org> <83mtfeeqc5.fsf@gnu.org> <408f7b88-2000-bd10-bd9d-4e06018e8ff0@gmx.at> <83k0agbhcq.fsf@gnu.org> <30699594-f491-07af-fd87-dabab35d71e3@gmx.at> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, acm@muc.de, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 21 May 2022 10:32:41 +0200 > Cc: acm@muc.de, 55412@debbugs.gnu.org, tanzer@swing.co.at > From: martin rudalics > > >> When trying to fix Bug#32777 I spent some time investigating these > >> issues but never found out why on earth we should call routines like > >> 'select-frame' and 'select-window' from redisplay. > > > > Well, now we know at least one reason: so that referencing > > frame-parameters would what Lisp programs expect. > > I don't understand what you mean here. Please elaborate. See the OP's report: a :eval form in frame-title-format that references a frame-parameter assumes that the frame whose title is being evaluated is the selected-frame when the :eval form runs. From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 05:00:04 2022 Received: (at 55412) by debbugs.gnu.org; 21 May 2022 09:00:05 +0000 Received: from localhost ([127.0.0.1]:40694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsKxw-0000F7-9V for submit@debbugs.gnu.org; Sat, 21 May 2022 05:00:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsKxq-0000E0-KY for 55412@debbugs.gnu.org; Sat, 21 May 2022 05:00:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49324) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsKxj-0007NF-8P; Sat, 21 May 2022 04:59:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GUgnaPdwMwmzCtrIO/+yxgEOUS+wn+FYoOBH32UTFHI=; b=LN9al0c888ND 5jIz95C0dBtdfvwam4OkjQnsJZHdYWtCKt6Hg9fquNfJq8RJ+66GcnhRWaC9Ru6gI7XBpbGEPAQEw thnCecuyA4NZNQQohwI4L3kol6W8jypDOvH9JkvMuDoW58ET66QaeUVnvG3JO2h8L0tY7IBGTzNWW rtmzej944fRaDbwwCQi8eUfT7yvWADGzezthXXd+1+z+c1y2aPN/QeUZZ/pePbBLabc6r05TpQjdB FN79juzn4y6Q4pFL95G5+WoMOpjJxboVoxaO1sNJFaXTDYU+bUZgRpRrernR0ELDK0X8Tz4FJNGju Z1p+lIG0Wk8vj/lghvbQNQ==; Received: from [87.69.77.57] (port=2517 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsKxi-0007iI-Gn; Sat, 21 May 2022 04:59:50 -0400 Date: Sat, 21 May 2022 11:59:43 +0300 Message-Id: <83zgjb8dmo.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <5b197424-4849-9771-ff1d-41b7a8295ba2@gmx.at> (message from martin rudalics on Sat, 21 May 2022 10:32:51 +0200) Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly References: <838rr4kq56.fsf@gnu.org> <87d23565-b8ba-3b08-0d10-068be3b0c5fd@gmx.at> <83leuzf4zk.fsf@gnu.org> <83sfp6eskr.fsf@gnu.org> <83mtfeeqc5.fsf@gnu.org> <408f7b88-2000-bd10-bd9d-4e06018e8ff0@gmx.at> <5b197424-4849-9771-ff1d-41b7a8295ba2@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, acm@muc.de, tanzer@swing.co.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 21 May 2022 10:32:51 +0200 > Cc: Eli Zaretskii , 55412@debbugs.gnu.org, tanzer@swing.co.at > From: martin rudalics > > > I get nervous when I see "selected_frame = ...;" or "selected_window = > > ....;" outside of do_switch_frame or the corresponding window function, > > since it means selected_{frame,window} have been set without regard to > > all the other things which must be kept in synch with them. At the > > moment, all these "wild" settings of selected_frame are in xdisp.c, > > which I suppose has special reasons for them. > > What concerns me is that xdisp.c sets selected_window and selected_frame > in the first place (also due to my attempts to fix Bug#39977). My patch > removes them all. Frankly, I don't understand why would we want that. AFAICT, that patch just moves those assignments to a single place, and what does that gain us, as counter-weight to potential breakage due to subtly different stuff the original code was doing? The new code also makes the temporary change in the selected window more heavy and expensive, which is not a good idea inside redisplay. Note that redisplay also changes the current buffer, and it does that independently of selecting a window. I'm not sure window.c is ready (or was designed) for such subtleties. > Moreover, the code has to guarantee that selecting a window correctly > sets up point from the window's point and stores the old point in the > previously selected window#s point. And it obviously has to guarantee > that the involved buffers, windows and frames are alive when switching > to and back from them - things redisplay had always problems with > (confer Bug#47244). Not reliably doing all these things in one place > easily produces bugs that show up only in sessions that run for a long > time and are consequently very difficult to debug. The general advantage of doing things in one place is well known, but I'm not sure this particular case lends itself well to such generalizations. IMNSHO, we are once again rocking a boat for no good reason (and no, the problems in bug#47244 do _not_ IMO justify this, because that bug can be fixed in other ways, as mentioned in that and related discussions several times). Bottom line, I'm not happy about this patch, sorry. From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 08:35:42 2022 Received: (at 55412) by debbugs.gnu.org; 21 May 2022 12:35:42 +0000 Received: from localhost ([127.0.0.1]:40865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsOKb-0002Aa-Pg for submit@debbugs.gnu.org; Sat, 21 May 2022 08:35:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsOKY-0002AI-8k for 55412@debbugs.gnu.org; Sat, 21 May 2022 08:35:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsOKR-0005OM-Ka; Sat, 21 May 2022 08:35:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=c3C7OYZrGQntDx0hsqOsBiweBzTmi5zrBRs9V0s/QbY=; b=P/1Bcc2MuBI/ X0slYUHoY9S6MmapTUtWVdVh/J9owLrVLez2qI4xdhjYCBwDDMCQwDtzgWlaQ6f1VJzVNXvmP2Frz xlGuvIIzYjhfhjBye5RpG2ySb8zdKidEs6q1bUZbCjFGXBElbVv2VJ5R0zyVkeIMk5voAl3D+SeNz t5FwvXT7Vv0fUyhqCFtsXRUbX1IEtUNKG41p0LsTkjnaxnW12N2n0jscwcCfg748qeCUiYX/LYyvI PAdzy4U2+1ylr+m3zneEktAZEXNpsVky2IIbL2ALm1H5js3Xm1GRtNJTXhG6pRiLh6Hr/mrgJ7HyC Q8A95Zu3yyHI+16q8R1drg==; Received: from [87.69.77.57] (port=4017 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsOKR-0004sp-3q; Sat, 21 May 2022 08:35:31 -0400 Date: Sat, 21 May 2022 15:35:20 +0300 Message-Id: <83r14n83nb.fsf@gnu.org> From: Eli Zaretskii To: tanzer@gg32.com In-Reply-To: (tanzer@gg32.com) Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55412 Cc: 55412@debbugs.gnu.org, acm@muc.de, rudalics@gmx.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 21 May 2022 11:25:22 -0000 > From: tanzer@gg32.com > Cc: martin rudalics , 55412@debbugs.gnu.org > > I needed to move back to Emacs 27.2 because there are some other bugs > in 28.1 that I have no idea how to properly report: > > - Emacs 28.1 most often crashes after loading a .emacs.desktop. > > It doesn't crash without a .emacs.desktop or with a simple one, but > at the moment I cannot start 28.1 on any of my usual .emacs.desktop > files without a crash. I suspect only a reboot will solve that. > > After the last reboot, I could start 28.1 once with a complex > .emacs.desktop, for a second (simultaneous) Emacs instance with a > different .emacs.desktop I had to use Emacs 27.2. > > Would it help to supply one of the crash dumps that macOS displayed > and how would I submit such a bug report? > > - The second bug concerns .emacs.desktop.lock files. For some reason, > 28.1 doesn't remove the lock file when exiting. > > Obviously, this isn't reproducible with `emacs -Q`. Again, how would > I submit such a bug report? Yes, please submit bug reports for those issues with as much relevant support data as you can, including any relevant customizations. E.g., for desktop.el-related issues, please post the .emacs.desktop file that causes those issues. Thanks. FTR, Emacs 28 never crashed on me due to anything related to desktop.el, which I use all the time. I also never saw any problems with removing .emacs.desktop.lock with v28.1. From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 12:48:43 2022 Received: (at 55412) by debbugs.gnu.org; 21 May 2022 16:48:43 +0000 Received: from localhost ([127.0.0.1]:42867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsSHP-0007X8-MV for submit@debbugs.gnu.org; Sat, 21 May 2022 12:48:43 -0400 Received: from mx0.gg32.com ([168.119.248.232]:7640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsNEg-0004Jm-0S for 55412@debbugs.gnu.org; Sat, 21 May 2022 07:25:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=20220514; bh=ADRueoEXHwl Fmw0MyKakupF4pJt0giKUlwtIWLqeQog=; h=cc:from:to:subject:date:reply-to: references:in-reply-to; d=gg32.com; b=qaHuoHRkJjRMgXCytrgdNPvO8pBA6B+V 2qnCv17O38F55DkZRCUm0x2LefTG7/2jwxKlKJiepVdNoqriKuQPu+UbUSz6yMEyq0w0sq b80lZA6V9kOzKJ1U03yLYfxHeZGUYOFp2d4BOA2qAYNHzSeKX+PkvRt+Hn17PoGSYus8nz 36cYkqGiMgK1rJa67MYCcd8aGmYA9XBMpacO3cNwtJ0qThZhFzp8GtMGYHE47VXMVx64Xz S0aUQb+sdj3Q30k1Afne+6+2zdd2A9XRHZmvNW9UeyAEHwz4fqOeQuKFjd6yOEt3QbLuqs dSLtTb/YEflULqLtuxg7nCw6ptb5hQ== Received: by mx0.gg32.com (OpenSMTPD) with ESMTP id bc3419bc; Sat, 21 May 2022 12:25:23 +0100 (WEST) X-mailer: PMA 0.8.0 In-reply-to: Your message of "Fri, 20 May 2022 20:39:06 +0000" References: Content-Type: text/plain; charset="utf-8" Date: Sat, 21 May 2022 11:25:22 -0000 Mime-Version: 1.0 Content-transfer-encoding: 8bit Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly To: Alan Mackenzie , Eli Zaretskii From: tanzer@gg32.com Message-Id: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55412 X-Mailman-Approved-At: Sat, 21 May 2022 12:48:38 -0400 Cc: 55412@debbugs.gnu.org, martin rudalics X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: tanzer@gg32.com Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Alan and Eli, Alan Mackenzie wrote at Fri, 20 May 2022 20:39:06 +0000: > On Sat, May 14, 2022 at 19:58:13 +0300, Eli Zaretskii wrote: > > > Date: Sat, 14 May 2022 15:45:10 -0000 > > > From: Christian Tanzer > > > > ;;; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work like it > > > ;;; used to in Emacs 27 and earlier. In fact, it is completely broken, if one > > > ;;; uses a frame-parameter in ':eval'. > > [ .... ] > > > Thank you for your report. > > > Alan, this is due to one of the changes introduced for the > > minibuffer-follows-selected-frame feature. Specifically, commit > > 7c2ebf6 made a change in gui_consider_frame_title which causes this > > regression. If I revert a part of that commit shown below: > > [ .... ] > > I have now committed the patch from Wednesday (slightly amended) to the > emacs-28 branch at savannah. This should have fixed the bug. Thank you. I was very impressed how fast you guys moved! > Christian, if downloading the latest version from the savannah server is > inconvenient, please let me know, and I will send you the patch by email > so that you can patch your own version of Emacs 28. Unfortunately, I'll have to wait for 28.2. But thanks for the offer nevertheless. I needed to move back to Emacs 27.2 because there are some other bugs in 28.1 that I have no idea how to properly report: - Emacs 28.1 most often crashes after loading a .emacs.desktop. It doesn't crash without a .emacs.desktop or with a simple one, but at the moment I cannot start 28.1 on any of my usual .emacs.desktop files without a crash. I suspect only a reboot will solve that. After the last reboot, I could start 28.1 once with a complex .emacs.desktop, for a second (simultaneous) Emacs instance with a different .emacs.desktop I had to use Emacs 27.2. Would it help to supply one of the crash dumps that macOS displayed and how would I submit such a bug report? - The second bug concerns .emacs.desktop.lock files. For some reason, 28.1 doesn't remove the lock file when exiting. Obviously, this isn't reproducible with `emacs -Q`. Again, how would I submit such a bug report? Thanks again and have a nice weekend, Christian PS: ATM, I'm not set up to compile Emacs myself as I temporarily moved into a very small house and don't have any Linux machine here. I'm not masochistic enough to setup up a compilation environment on the little Macbook I have (which is severly lacking on disc space). From debbugs-submit-bounces@debbugs.gnu.org Sun May 22 13:34:31 2022 Received: (at 55412-done) by debbugs.gnu.org; 22 May 2022 17:34:31 +0000 Received: from localhost ([127.0.0.1]:46272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nspTK-0002mX-V2 for submit@debbugs.gnu.org; Sun, 22 May 2022 13:34:31 -0400 Received: from colin.muc.de ([193.149.48.1]:40452 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1nspTJ-0002mK-CC for 55412-done@debbugs.gnu.org; Sun, 22 May 2022 13:34:30 -0400 Received: (qmail 2111 invoked by uid 3782); 22 May 2022 17:34:23 -0000 Received: from acm.muc.de (p4fe15ce5.dip0.t-ipconnect.de [79.225.92.229]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 22 May 2022 19:34:22 +0200 Received: (qmail 29146 invoked by uid 1000); 22 May 2022 17:34:18 -0000 Date: Sun, 22 May 2022 17:34:18 +0000 To: tanzer@gg32.com Subject: Re: bug#55412: 28.1; In Emacs 28.1, using ':eval' in 'frame-title-format' doesn't work properly Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55412-done Cc: 55412-done@debbugs.gnu.org, martin rudalics , Eli Zaretskii , acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Christian. On Sat, May 21, 2022 at 11:25:22 -0000, tanzer@gg32.com wrote: > Hello Alan and Eli, > Alan Mackenzie wrote at Fri, 20 May 2022 20:39:06 +0000: > > On Sat, May 14, 2022 at 19:58:13 +0300, Eli Zaretskii wrote: > > I have now committed the patch from Wednesday (slightly amended) to the > > emacs-28 branch at savannah. This should have fixed the bug. > Thank you. I was very impressed how fast you guys moved! OK, thanks! I'm now closing the bug with this post. > I needed to move back to Emacs 27.2 because there are some other bugs > in 28.1 that I have no idea how to properly report: [ .... ] I'm sorry about these, and hope we manage to get them fixed, too! > Thanks again and have a nice weekend, You too! > Christian > PS: ATM, I'm not set up to compile Emacs myself as I temporarily moved > into a very small house and don't have any Linux machine here. I'm > not masochistic enough to setup up a compilation environment on > the little Macbook I have (which is severly lacking on disc space). OK. -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Sep 12 15:16:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Jun 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator